Problem with str_replace function when removal apart of the template

[kh99]

Originally Posted by Dave

This is a nicer way:

PHP Code:

$code = 
 '<if condition="' . $show['threadrating'] . '"> 
        <td class="vbmenu_control" id="threadrating" nowrap="nowrap"> 
            <a href="' . $show[nojs_link] . '#goto_threadrating"><span id="threadrating_current"><if condition="' . $show['rating'] . '">' . $vbphrase[rating] . ': <img class="inlineimg" src="' . $stylevar[imgdir_rating] . '/rating_' . $thread[rating].gif . '" alt="<phrase 1="' . $thread[votenum] . '" 2="' . $thread[voteavg] . '">' . $vbphrase[thread_rating_x_votes_y_average] . '</phrase>" border="0" /><else />' . $vbphrase[rate_thread] . '</if></span></a> 
            <if condition="' . $show['popups'] . '"><script type="text/javascript"> vbmenu_register("threadrating"); </script></if> 
        </td> 
    </if>'; 

$vbulletin->templatecache['SHOWTHREAD'] = str_replace ($code,' ',$vbulletin->templatecache['SHOWTHREAD']); 


Put the code within single quotes, escape the variables and no need to add slashes in front of quotes.
Also much easier to read.

But that won't work the same. You want to avoid having the variables evaluated because you're trying to match the string that's in the template cache.