What's wrong with this code?

[Davey]

I found the bug allright.

PHP Code:

while ($memberlist = $DB_site->fetch_array($memberlistquery))
{
eval('$endtemplate .= "' . fetch_template('guild_memberrow') . '";');
}
if (!$memberlist['username'])
{
echo "something's wrong.";
}
// done
$templatename = 'guild_memberslist'; 


See attachment.

Now how to fix that? lol

[Dean C]

Well i've no idea without looking at it fully. Are you not showing me some code? How does it output undisclosed?

[Davey]

I changed the templates to debug the <if> conditioning.
It'd look something like:

<td>
<if condition="$memberlist[field6]">
$memberlist[field6]
</if>
<if condition="!$memberlist[field6]">
Undisclosed.
</if>

edit.- That prooves that it's not <if> but it's the $memberlist fetched array which isn't doing as it should for whatever reason.

[Dean C]

You are going seriously wrong here Where are you getting field6 from? You should be using the field username? Also if you're trying to get profile fields then you have to join the profilefield table (or whatever it is in vB3)

[Davey]

<tr>
<td style="text-align: center; vertical-align: middle">
<a href="member.php?u=$memberlist[userid]">$memberlist[musername]</a>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field5]">
$memberlist[field5]
</if>
<if condition="!$memberlist[field5]">
Undisclosed.
</if>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field6]">
$memberlist[field6]
</if>
<if condition="!$memberlist[field6]">
Undisclosed.
</if>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field7]">
$memberlist[field7]
</if>
<if condition="!$memberlist[field7]">
Undisclosed.
</if>
</td>
</tr>

It's not returning anything, let alone the profile fields. Not that I understand JOIN'ing at all.
edit.- I've updated the code and templates in the first post.

[Tigga]

Try something like this instead:

PHP Code:

 $memberlistquery = $DB_site->query(" 
SELECT user.*, userfield.*
FROM " . TABLE_PREFIX . "user AS user
LEFT JOIN " . TABLE_PREFIX . "userfield AS userfield USING (userid)
WHERE '8' IN (membergroupids) 
ORDER BY username ASC 
") or die("mysql error"); 


[Davey]

That didn't work any, still comes up blank.

[Tigga]

Try moving this part:

PHP Code:

if (empty($_REQUEST['do'])) 
{ 
    $_REQUEST['do'] = 'members'; 
} 


Below the call to global.php. It being above the call to global.php will create a problem... Other than that I don't see anything else wrong.

[Davey]

lol

Originally Posted by CarCdr

Also, I would do the check for an empty $_REQUEST['do'] so that it is set before including global.php. This will allow it to pre-cache the $actiontemplates.

Who's right?
*confused*

[Tigga]

Keep that code below the call to global.php, then add this above to cache the templates:

$actiontemplates['none'] = &$actiontemplates['members'];