Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
  #1  
Old 09-02-2002, 10:59 AM
joecool joecool is offline
 
Join Date: Mar 2002
Posts: 134
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Number problem? PHP

Hello, i have a small PHP script, and thought that the way i did it was a long way .. Just wondering if there is a smaller way.

Here is my code.

PHP Code:
 <?php 
  
  $newpm
=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND dateline>$bbuserinfo[lastvisit] AND folderid=0 $ignoreusers");
  
  if (
$newpm['messages']==and $bbuserinfo['userid']!=0) {
    echo(
"You have 0 messages");
 }elseif (
$newpm['messages']==1) {
    echo(
"You have 1 message");
   }elseif (
$newpm['messages']==2) {
    echo(
"You have 2 messages");
    }elseif (
$newpm['messages']==3) {
    echo(
"You have 3 message");
  }elseif (
$newpm['messages']==4) {
    echo(
"You have 4 messages");
    }elseif (
$newpm['messages']==5) {
    echo(
"You have 5 messages");
    }elseif (
$newpm['messages']==6) {
    echo(
"You have 6 messages");
    }elseif (
$newpm['messages']==7) {
    echo(
"You have 7 messages");
    }elseif (
$newpm['messages']==8) {
    echo(
"You have 8 messages");
    }elseif (
$newpm['messages']==9) {
    echo(
"You have 9 messages");
    }elseif (
$newpm['messages']>=10) {
    echo(
"You have 10+ messages");
    }else 
    echo(
"you are not logged in!!!");
  
?>
Basically its for a small hack, to allow people to see their messages on you homepage, but just wondered if i could make it more simple. ??? Any ideas???
Reply With Quote
  #2  
Old 09-02-2002, 03:13 PM
Issvar Issvar is offline
 
Join Date: Mar 2002
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes, there are more simple ways.

One way is:
PHP Code:
if ($newpm['messages'] >= && $newpm['messages'] < 10 && $bbuserinfo['userid'] != 0) {
  echo 
"You have $newpm['messages'] messages";
} elseif (
$newpm['messages'] > 10) {
  echo 
"You have 10+ messages";
} else {
  echo 
"You are not logged in!!!"
If you wouldn't be using numbers, but for instance words for numbers, you would use a switch statement like:
PHP Code:
if ($bbuserinfo['userid'] != 0) {
  echo 
"You are not logged in!!!";
}
switch (
$newpm['messages']) {
case 
0$newpms="zero"; break;
case 
1$newpms="one"; break;
case 
2$newpms="two"; break;
case 
3$newpms="three"; break;
case 
4$newpms="four"; break;
default: 
$newpms="four plus";
}
echo 
"You have $newpms messages"
Reply With Quote
  #3  
Old 09-02-2002, 04:14 PM
g-force2k2 g-force2k2 is offline
 
Join Date: Mar 2002
Location: Everywhere you wanna be..
Posts: 1,608
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

joecool why don't you just use...

PHP Code:
if($bbuserinfo[userid] == 0) {
  echo 
"You are not logged in!!!";
} else {
  if(
$newpm[messages] == 1) {
    
$type "message";
  } else {
    
$type "messages";
  }
  echo 
"You have $newpm[messages] $type!";

regards...

g-force2k2
Reply With Quote
  #4  
Old 09-02-2002, 04:22 PM
joecool joecool is offline
 
Join Date: Mar 2002
Posts: 134
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks people.. Its all sorted now.. Cool..
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 05:57 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03938 seconds
  • Memory Usage 2,209KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete