vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Number problem? PHP (https://vborg.vbsupport.ru/showthread.php?t=43075)

joecool 09-02-2002 10:59 AM
Number problem? PHP
 
Hello, i have a small PHP script, and thought that the way i did it was a long way .. Just wondering if there is a smaller way.

Here is my code.

PHP Code:
 <?php 
  
  $newpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND dateline>$bbuserinfo[lastvisit] AND folderid=0 $ignoreusers");
  
  if ($newpm['messages']==0 and $bbuserinfo['userid']!=0) {
    echo("You have 0 messages");
 }elseif ($newpm['messages']==1) {
    echo("You have 1 message");
   }elseif ($newpm['messages']==2) {
    echo("You have 2 messages");
    }elseif ($newpm['messages']==3) {
    echo("You have 3 message");
  }elseif ($newpm['messages']==4) {
    echo("You have 4 messages");
    }elseif ($newpm['messages']==5) {
    echo("You have 5 messages");
    }elseif ($newpm['messages']==6) {
    echo("You have 6 messages");
    }elseif ($newpm['messages']==7) {
    echo("You have 7 messages");
    }elseif ($newpm['messages']==8) {
    echo("You have 8 messages");
    }elseif ($newpm['messages']==9) {
    echo("You have 9 messages");
    }elseif ($newpm['messages']>=10) {
    echo("You have 10+ messages");
    }else 
    echo("you are not logged in!!!");
  
?>
Basically its for a small hack, to allow people to see their messages on you homepage, but just wondered if i could make it more simple. ??? Any ideas???

Issvar 09-02-2002 03:13 PM
Yes, there are more simple ways.

One way is:
PHP Code:
if ($newpm['messages'] >= 0 && $newpm['messages'] < 10 && $bbuserinfo['userid'] != 0) {
  echo "You have $newpm['messages'] messages";
} elseif ($newpm['messages'] > 10) {
  echo "You have 10+ messages";
} else {
  echo "You are not logged in!!!"; 
If you wouldn't be using numbers, but for instance words for numbers, you would use a switch statement like:
PHP Code:
if ($bbuserinfo['userid'] != 0) {
  echo "You are not logged in!!!";
}
switch ($newpm['messages']) {
case 0: $newpms="zero"; break;
case 1: $newpms="one"; break;
case 2: $newpms="two"; break;
case 3: $newpms="three"; break;
case 4: $newpms="four"; break;
default: $newpms="four plus";
}
echo "You have $newpms messages"; 

g-force2k2 09-02-2002 04:14 PM
joecool why don't you just use...

PHP Code:
if($bbuserinfo[userid] == 0) {
  echo "You are not logged in!!!";
} else {
  if($newpm[messages] == 1) {
    $type = "message";
  } else {
    $type = "messages";
  }
  echo "You have $newpm[messages] $type!";
} 
regards...

g-force2k2

joecool 09-02-2002 04:22 PM
Thanks people.. Its all sorted now.. Cool.. :)


All times are GMT. The time now is 01:33 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01112 seconds
  • Memory Usage 1,737KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (4)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete