converting my 3.0.x hacks to 3.5

[Sean S]

Hi there, I'm trying to upgrade my website to 3.5, however, on a test forum, I'm trying to upgrade all my hacks/addons first.

I've been reading through the changes and changed this part of the hack, however, it doesn't seem to work. Basically it doesn't record the data and it redirects back to the same page without showing the redirect message. can someone take a look at it and tell me what I did wrong?

PHP Code:

if ($_POST['do'] == 'rate')
{
    $vbulletin->input->clean_array_gpc('p', array(
    'profileid' => INT,
    'userid' => INT,
    'group1' => INT,
    ));

    if (!$vbulletin->userinfo['userid'])
        print_no_permission();

    if(!$userid OR !$group1 OR !$profileid)
        eval(standard_error(fetch_error('error_requiredfields')));

    $votevalue = $group1;
    $rate_check = $db->query("SELECT * FROM " . TABLE_PREFIX . "ratings WHERE profileid='$profileid' AND userid='$userid'");
    if($db->num_rows($rate_check)!=0)
    {
        $db->query("DELETE FROM " . TABLE_PREFIX . "ratings WHERE profileid='$profileid' AND userid='$userid'");
        $db->query("INSERT INTO " . TABLE_PREFIX . "ratings (id, profileid, userid, rating) VALUES ('', '$profileid', '$userid', '$votevalue')");
        $_REQUEST['forceredirect'] = true;
        $url = "member.php?u=$profileid";
        eval(print_standard_redirect('Thank you. You will now be redirected ...',0));
        exit;
    }
    else
    {
           $db->query("INSERT INTO " . TABLE_PREFIX . "ratings (id, profileid, userid, rating) VALUES ('', '$profileid', '$userid', '$votevalue')");
        $_REQUEST['forceredirect'] = true;
        $url = "member.php?u=$profileid";
        eval(print_standard_redirect('Thank you. You will now be redirected ...',0));
        exit;
    }
} 


Also I'm not sure exactly how this part of the code would exactly update in 3.5

PHP Code:

    if(!$userid OR !$group1 OR !$profileid)
        eval(standard_error(fetch_error('error_requiredfields'))); 


thanks in advance for any help

Also I have one other quick question, in vb 3.5,

do I use

PHP Code:

$vbulletin->userinfo['userid'] 


instead of

PHP Code:

$bbuserinfo['userid'] 


?

thank you.