vb.org Archive - converting my 3.0.x hacks to 3.5

Hi there, I'm trying to upgrade my website to 3.5, however, on a test forum, I'm trying to upgrade all my hacks/addons first.

I've been reading through the changes and changed this part of the hack, however, it doesn't seem to work. Basically it doesn't record the data and it redirects back to the same page without showing the redirect message. can someone take a look at it and tell me what I did wrong?

PHP Code:


		
			
if ($_POST['do'] == 'rate')

{

    $vbulletin->input->clean_array_gpc('p', array(

    'profileid' => INT,

    'userid' => INT,

    'group1' => INT,

    ));



    if (!$vbulletin->userinfo['userid'])

        print_no_permission();



    if(!$userid OR !$group1 OR !$profileid)

        eval(standard_error(fetch_error('error_requiredfields')));



    $votevalue = $group1;

    $rate_check = $db->query("SELECT * FROM " . TABLE_PREFIX . "ratings WHERE profileid='$profileid' AND userid='$userid'");

    if($db->num_rows($rate_check)!=0)

    {

        $db->query("DELETE FROM " . TABLE_PREFIX . "ratings WHERE profileid='$profileid' AND userid='$userid'");

        $db->query("INSERT INTO " . TABLE_PREFIX . "ratings (id, profileid, userid, rating) VALUES ('', '$profileid', '$userid', '$votevalue')");

        $_REQUEST['forceredirect'] = true;

        $url = "member.php?u=$profileid";

        eval(print_standard_redirect('Thank you. You will now be redirected ...',0));

        exit;

    }

    else

    {

           $db->query("INSERT INTO " . TABLE_PREFIX . "ratings (id, profileid, userid, rating) VALUES ('', '$profileid', '$userid', '$votevalue')");

        $_REQUEST['forceredirect'] = true;

        $url = "member.php?u=$profileid";

        eval(print_standard_redirect('Thank you. You will now be redirected ...',0));

        exit;

    }

}

Also I'm not sure exactly how this part of the code would exactly update in 3.5

PHP Code:


		
			
    if(!$userid OR !$group1 OR !$profileid)

        eval(standard_error(fetch_error('error_requiredfields')));

thanks in advance for any help :)

Also I have one other quick question, in vb 3.5,

do I use

PHP Code:


		
			
$vbulletin->userinfo['userid']

instead of

PHP Code:


		
			
$bbuserinfo['userid']

?

thank you.

X vBulletin 3.8.12 by vBS Debug Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (4)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages:

X vBulletin 3.8.12 by vBS Debug Information

Page Generation 0.01136 seconds
Memory Usage 1,737KB
Queries Executed 10 (?)

More Information

Template Usage:

(1)ad_footer_end
(1)ad_footer_start
(1)ad_header_end
(1)ad_header_logo
(1)ad_navbar_below
(3)bbcode_code_printable
(4)bbcode_php_printable
(1)footer
(1)gobutton
(1)header
(1)headinclude
(6)option
(1)post_thanks_navbar_search
(1)printthread
(3)printthreadbit
(1)spacer_close
(1)spacer_open

Phrase Groups Available:

global
postbit
showthread

Included Files:

./printthread.php
./global.php
./includes/init.php
./includes/class_core.php
./includes/config.php
./includes/functions.php
./includes/class_hook.php
./includes/modsystem_functions.php
./includes/class_bbcode_alt.php
./includes/class_bbcode.php
./includes/functions_bigthree.php

Hooks Called:

init_startup
init_startup_session_setup_start
init_startup_session_setup_complete
cache_permissions
fetch_threadinfo_query
fetch_threadinfo
fetch_foruminfo
style_fetch
cache_templates
global_start
parse_templates
global_setup_complete
printthread_start
bbcode_fetch_tags
bbcode_create
bbcode_parse_start
bbcode_parse_complete_precache
bbcode_parse_complete
printthread_post
printthread_complete

Messages:

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01136 seconds Memory Usage 1,737KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code_printable (4)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (3)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: