Totally confused (Needs help)

[Joshie787]

<? 
connectTOforum();

$query = mysql_query("SELECT * from thread WHERE forumid='2' ORDER BY threadid DESC LIMIT 0, 5");
while($row = mysql_fetch_array($query)){ 

	$date = date('m-d-y', $row['dateline']);
	$time = date('g:iA', $row['dateline']);
	?>

<? 	$query2 = mysql_query("SELECT * from post WHERE threadid='$row[threadid]' ORDER BY 'threadid' DESC LIMIT 1");
	$info2  = mysql_fetch_array($query2); ?>
<? 	$comment = htmlentities($info2[pagetext]);
	$comment = str_replace ("\n", "<br/>", "$comment");
	$find = array(
	"'\[b\](.*?)\[/b\]'is",
	"'\[i\](.*?)\[/i\]'is",
	"'\[u\](.*?)\[/u\]'is",
	"'\[size=(.*?)\](.*?)\[/size\]'is",
	"'\[color=(.*?)\](.*?)\[/color\]'is",
	"'\[img\](.*?)\[/img\]'is",
	"'\[url\](.*?)\[/url\]'is",
	"'\[url=(.*?)\](.*?)\[/url\]'is");
	$replace = array(
	"<b>\\1</b>",
	"<i>\\1</i>",
	"<u>\\1</u>", 
	"<font size=\"\\1\">\\2</font>",
	"<font color=\"\\1\">\\2</font>",
	"<img src=\"/tutorials/thumbnail.php?url=\\1&width=460\" class=\"link\">", 
	"<a href=\"\\1\" class=\"link\">\\1</a>", 
	"<a href=\"\\1\" class=\"link\">\\2</a>");

	while(
	(preg_match("'\[b\](.*?)\[/b\]'is",$comment)) || 
	(preg_match("'\[i\](.*?)\[/i\]'is",$comment)) || 
	(preg_match("'\[u\](.*?)\[/u\]'is",$comment)) || 
	(preg_match("'\[size=(.*?)\](.*?)\[/size\]'is",$comment)) ||
	(preg_match("'\[color=(.*?)\](.*?)\[/color\]'is",$comment)) || 
	(preg_match("'\[img\](.*?)\[/img\]'is",$comment)) || 
	(preg_match("'\[url\](.*?)\[/url\]'is",$comment)) || 
	(preg_match("'\[url=(.*?)\](.*?)\[/url\]'is",$comment))) {
	$comment = preg_replace($find,$replace,$comment);
	} ?>	

<div class="post">
		<h3><span class="date"><? echo($date); ?>, <? echo($time); ?></span> <? echo($row['title']); ?></h3>
		<div class="content">
			<? echo"$comment"; ?>
			<div class="post-foot">
				<a href="http://www.siteaddress.com/forum/showthread.php?threadid=<? echo($row[threadid]); ?>" class="link">Comments</a>(<strong><? echo($row[replycount]); ?></strong>)</td>
			</div>
		</div>
	</div>
<? } ?>

When I post a link, the link does this

http://www.siteaddress.com/Josh/"http://www.siteaddress.com/forums/downloads.php?do=file&id=4"

I have no idea how to make it properly post the correct address

[Chris M]

Firstly, why does your code have unnecessary <? and ?> tags in? You can have PHP code execute within a php file without having to open and close php tags constantly; The idea is to close them when you need to execute non-php code, and then open the tag again if needed...

Secondly:

<a href="http://www.siteaddress.com/forum/showthread.php?threadid=<? echo($row[threadid]); ?>" class="link">Comments</a>(<strong><? echo($row[replycount]); ?>

In the selected code above, you are echo'ing an id into a tag... "echo" is a command to display on screen, and removing this may help...

Finally, I can see no reference to "downloads.php" in any of your code...

Chris

[Chris M]

Here is a quick & basic clean-up of your code:

PHP Code:

<?php 
connectTOforum();
 
$query = mysql_query("SELECT * from thread WHERE forumid='2' ORDER BY threadid DESC LIMIT 0, 5");
while($row = mysql_fetch_array($query)){ 
 
    $date = date('m-d-y', $row['dateline']);
    $time = date('g:iA', $row['dateline']);
 
$query2 = mysql_query("SELECT * from post WHERE threadid='$row[threadid]' ORDER BY 'threadid' DESC LIMIT 1");
    $info2  = mysql_fetch_array($query2);
$comment = htmlentities($info2[pagetext]);
    $comment = str_replace ("\n", "<br/>", "$comment");
    $find = array(
    "'\[b\](.*?)\[/b\]'is",
    "'\[i\](.*?)\[/i\]'is",
    "'\[u\](.*?)\[/u\]'is",
    "'\[size=(.*?)\](.*?)\[/size\]'is",
    "'\[color=(.*?)\](.*?)\[/color\]'is",
    "'\[img\](.*?)\[/img\]'is",
    "'\[url\](.*?)\[/url\]'is",
    "'\[url=(.*?)\](.*?)\[/url\]'is");
    $replace = array(
    "<b>\\1</b>",
    "<i>\\1</i>",
    "<u>\\1</u>", 
    "<font size=\"\\1\">\\2</font>",
    "<font color=\"\\1\">\\2</font>",
    "<img src=\"/tutorials/thumbnail.php?url=\\1&width=460\" class=\"link\">", 
    "<a href=\"\\1\" class=\"link\">\\1</a>", 
    "<a href=\"\\1\" class=\"link\">\\2</a>");
 
    while(
    (preg_match("'\[b\](.*?)\[/b\]'is",$comment)) || 
    (preg_match("'\[i\](.*?)\[/i\]'is",$comment)) || 
    (preg_match("'\[u\](.*?)\[/u\]'is",$comment)) || 
    (preg_match("'\[size=(.*?)\](.*?)\[/size\]'is",$comment)) ||
    (preg_match("'\[color=(.*?)\](.*?)\[/color\]'is",$comment)) || 
    (preg_match("'\[img\](.*?)\[/img\]'is",$comment)) || 
    (preg_match("'\[url\](.*?)\[/url\]'is",$comment)) || 
    (preg_match("'\[url=(.*?)\](.*?)\[/url\]'is",$comment))) {
    $comment = preg_replace($find,$replace,$comment);
    }
?>    
 
<div class="post">
<h3><span class="date"><?php echo "$date"; echo ","; echo "$time"; ?></span><?php echo "$row['title']"; ?></h3>
        <div class="content">
            <?php echo "$comment"; ?>
            <div class="post-foot">
                <a href="http://www.siteaddress.com/forum/showthread.php?threadid=<?php $row[threadid] ?>" class="link">Comments</a>(<strong><?php echo "$row[replycount]"; ?></strong>)</td>
            </div>
        </div>
    </div>
<?php } ?>

Chris

[Joshie787]

Sorry :P, Im a php newb as you can tell, the downloads.php is because that is just a part of my index code. Thanks for the help Chris M.

ah, with that cleanup code I get this error

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/neoen/public_html/Josh/index.php on line 134

and T_T, for some reason Im still getting this for my links

http://www.siteaddy.com/Josh/%22http://celes.servegame.com/acctv2.asp%22