vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Totally confused (Needs help) (https://vborg.vbsupport.ru/showthread.php?t=157375)

Joshie787 09-09-2007 01:58 AM
Totally confused (Needs help)
 
Code:
<?
connectTOforum();

$query = mysql_query("SELECT * from thread WHERE forumid='2' ORDER BY threadid DESC LIMIT 0, 5");
while($row = mysql_fetch_array($query)){

        $date = date('m-d-y', $row['dateline']);
        $time = date('g:iA', $row['dateline']);
        ?>

<?        $query2 = mysql_query("SELECT * from post WHERE threadid='$row[threadid]' ORDER BY 'threadid' DESC LIMIT 1");
        $info2  = mysql_fetch_array($query2); ?>
<?        $comment = htmlentities($info2[pagetext]);
        $comment = str_replace ("\n", "<br/>", "$comment");
        $find = array(
        "'\[b\](.*?)\[/b\]'is",
        "'\[i\](.*?)\[/i\]'is",
        "'\[u\](.*?)\[/u\]'is",
        "'\[size=(.*?)\](.*?)\[/size\]'is",
        "'\[color=(.*?)\](.*?)\[/color\]'is",
        "'\[img\](.*?)\[/img\]'is",
        "'\[url\](.*?)\[/url\]'is",
        "'\[url=(.*?)\](.*?)\[/url\]'is");
        $replace = array(
        "<b>\\1</b>",
        "<i>\\1</i>",
        "<u>\\1</u>",
        "<font size=\"\\1\">\\2</font>",
        "<font color=\"\\1\">\\2</font>",
        "<img src=\"/tutorials/thumbnail.php?url=\\1&width=460\" class=\"link\">",
        "<a href=\"\\1\" class=\"link\">\\1</a>",
        "<a href=\"\\1\" class=\"link\">\\2</a>");

        while(
        (preg_match("'\[b\](.*?)\[/b\]'is",$comment)) ||
        (preg_match("'\[i\](.*?)\[/i\]'is",$comment)) ||
        (preg_match("'\[u\](.*?)\[/u\]'is",$comment)) ||
        (preg_match("'\[size=(.*?)\](.*?)\[/size\]'is",$comment)) ||
        (preg_match("'\[color=(.*?)\](.*?)\[/color\]'is",$comment)) ||
        (preg_match("'\[img\](.*?)\[/img\]'is",$comment)) ||
        (preg_match("'\[url\](.*?)\[/url\]'is",$comment)) ||
        (preg_match("'\[url=(.*?)\](.*?)\[/url\]'is",$comment))) {
        $comment = preg_replace($find,$replace,$comment);
        } ?>       

<div class="post">
                <h3><span class="date"><? echo($date); ?>, <? echo($time); ?></span> <? echo($row['title']); ?></h3>
                <div class="content">
                        <? echo"$comment"; ?>
                        <div class="post-foot">
                                <a href="http://www.siteaddress.com/forum/showthread.php?threadid=<? echo($row[threadid]); ?>" class="link">Comments</a>(<strong><? echo($row[replycount]); ?></strong>)</td>
                        </div>
                </div>
        </div>
<? } ?>
When I post a link, the link does this

Code:
http://www.siteaddress.com/Josh/"http://www.siteaddress.com/forums/downloads.php?do=file&id=4"
I have no idea how to make it properly post the correct address

Chris M 09-09-2007 03:57 AM
Firstly, why does your code have unnecessary <? and ?> tags in? You can have PHP code execute within a php file without having to open and close php tags constantly; The idea is to close them when you need to execute non-php code, and then open the tag again if needed...

Secondly:
Code:
<a href="http://www.siteaddress.com/forum/showthread.php?threadid=<? echo($row[threadid]); ?>" class="link">Comments</a>(<strong><? echo($row[replycount]); ?>
In the selected code above, you are echo'ing an id into a tag... "echo" is a command to display on screen, and removing this may help...

Finally, I can see no reference to "downloads.php" in any of your code...

Chris

Chris M 09-09-2007 04:03 AM
Here is a quick & basic clean-up of your code:
PHP Code:
<?php 
connectTOforum();
 
$query = mysql_query("SELECT * from thread WHERE forumid='2' ORDER BY threadid DESC LIMIT 0, 5");
while($row = mysql_fetch_array($query)){ 
 
    $date = date('m-d-y', $row['dateline']);
    $time = date('g:iA', $row['dateline']);
 
$query2 = mysql_query("SELECT * from post WHERE threadid='$row[threadid]' ORDER BY 'threadid' DESC LIMIT 1");
    $info2  = mysql_fetch_array($query2);
$comment = htmlentities($info2[pagetext]);
    $comment = str_replace ("\n", "<br/>", "$comment");
    $find = array(
    "'\[b\](.*?)\[/b\]'is",
    "'\[i\](.*?)\[/i\]'is",
    "'\[u\](.*?)\[/u\]'is",
    "'\[size=(.*?)\](.*?)\[/size\]'is",
    "'\[color=(.*?)\](.*?)\[/color\]'is",
    "'\[img\](.*?)\[/img\]'is",
    "'\[url\](.*?)\[/url\]'is",
    "'\[url=(.*?)\](.*?)\[/url\]'is");
    $replace = array(
    "<b>\\1</b>",
    "<i>\\1</i>",
    "<u>\\1</u>", 
    "<font size=\"\\1\">\\2</font>",
    "<font color=\"\\1\">\\2</font>",
    "<img src=\"/tutorials/thumbnail.php?url=\\1&width=460\" class=\"link\">", 
    "<a href=\"\\1\" class=\"link\">\\1</a>", 
    "<a href=\"\\1\" class=\"link\">\\2</a>");
 
    while(
    (preg_match("'\[b\](.*?)\[/b\]'is",$comment)) || 
    (preg_match("'\[i\](.*?)\[/i\]'is",$comment)) || 
    (preg_match("'\[u\](.*?)\[/u\]'is",$comment)) || 
    (preg_match("'\[size=(.*?)\](.*?)\[/size\]'is",$comment)) ||
    (preg_match("'\[color=(.*?)\](.*?)\[/color\]'is",$comment)) || 
    (preg_match("'\[img\](.*?)\[/img\]'is",$comment)) || 
    (preg_match("'\[url\](.*?)\[/url\]'is",$comment)) || 
    (preg_match("'\[url=(.*?)\](.*?)\[/url\]'is",$comment))) {
    $comment = preg_replace($find,$replace,$comment);
    }
?>    
 
<div class="post">
<h3><span class="date"><?php echo "$date"; echo ","; echo "$time"; ?></span><?php echo "$row['title']"; ?></h3>
        <div class="content">
            <?php echo "$comment"; ?>
            <div class="post-foot">
                <a href="http://www.siteaddress.com/forum/showthread.php?threadid=<?php $row[threadid] ?>" class="link">Comments</a>(<strong><?php echo "$row[replycount]"; ?></strong>)</td>
            </div>
        </div>
    </div>
<?php } ?>
Chris

Joshie787 09-09-2007 04:34 AM
Sorry :P, Im a php newb as you can tell, the downloads.php is because that is just a part of my index code. Thanks for the help Chris M.

ah, with that cleanup code I get this error

Code:
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/neoen/public_html/Josh/index.php on line 134
and T_T, for some reason Im still getting this for my links


Code:
http://www.siteaddy.com/Josh/%22http://celes.servegame.com/acctv2.asp%22


All times are GMT. The time now is 10:25 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01036 seconds
  • Memory Usage 1,753KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_code_printable
  • (1)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (4)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete