vb.org Archive - member.php (2.3.0).

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=111)

- - member.php (2.3.0). (https://vborg.vbsupport.ru/showthread.php?t=50798)

Davey

03-25-2003 02:11 PM

member.php (2.3.0).

I know I'm probably wrong (seeing as I'm still learning PHP, etc.), but I saw this code, and it made me wonder.

PHP Code:


		
			
  //$DB_site->query("UPDATE session SET userid=0 WHERE sessionhash='".addslashes($session[sessionhash])."'");

  $DB_site->query("DELETE FROM session WHERE sessionhash='".addslashes($session[dbsessionhash])."'");



  if ($bbuserinfo[userid] > 0) {

    // make sure any other of this user's sessions are deleted (incase they ended up with more than one)

    $DB_site->query("DELETE FROM session WHERE userid='$bbuserinfo[userid]'");

  }

What is the point of:

PHP Code:


		
			
  //$DB_site->query("UPDATE session SET userid=0 WHERE sessionhash='".addslashes($session[sessionhash])."'");

  $DB_site->query("DELETE FROM session WHERE sessionhash='".addslashes($session[dbsessionhash])."'");

It seems as though the second section is deleting the users sessionhash from the username rather than the sessionhash itself.
Surely this is just another unneeded query? Or am I looking at this wrong?

Dave.

filburt1

03-25-2003 02:22 PM

Quote:

// make sure any other of this user's sessions are deleted (incase they ended up with more than one)

sessions.php is terrifying to look at, anyway.

Davey

03-25-2003 02:27 PM

So I was right or what?
Was that code adding an extra query or was it genuinely needed to function correctly?

Dave.

N9ne	03-25-2003 03:37 PM

The first query in that batch of code is for guests, the second, for members.

Xenon

03-25-2003 04:11 PM

Yes, it's needed.

Without it guestsessions would make problems ;)

Davey

03-26-2003 10:48 AM

Ohhh I see.
Thanks.

Dave.

All times are GMT. The time now is 03:17 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01040 seconds Memory Usage 1,724KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (6)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: