vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   Community Lounge (https://vborg.vbsupport.ru/forumdisplay.php?f=13)
-   -   New vB3 script is out (https://vborg.vbsupport.ru/showthread.php?t=54135)

filburt1 06-10-2003 06:35 PM

New vB3 script is out
 
<a href="http://www.vbulletin.com/forum/showthread.php?threadid=73163" target="_blank">http://www.vbulletin.com/forum/showt...threadid=73163</a>

assassingod 06-10-2003 06:43 PM

No table or column conflicts, i'm all set for vB3;)

colicab-d 06-10-2003 06:52 PM

im good too ;)

N9ne 06-10-2003 07:03 PM

Yep I saw this just after it was posted, no conflicts on my end either, didn't expect any :)

filburt1 06-10-2003 08:02 PM

BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.

Freddie Bingham 06-10-2003 08:03 PM

Quote:

Today at 02:02 PM filburt1 said this in Post #6
BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.


I think we need to hire you as a developer so you can show us how it is done.

I'm still waiting to see you code a forum better than the "lowly" vB2 since you obviously think you have the skills. One would hope a moderator of the official hacking site would have a bit more respect.

Scott MacVicar 06-10-2003 08:10 PM

Quote:

Today at 10:02 PM filburt1 said this in Post #6
BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:

1. 1 and 0 everywhere instead of true and false
2. STILL using array keys not in strings
3. Exceeding 80-char line limit

However it's a billion times better than vB2, nobody can argue with that.

That script doesn't reflect what the vB3 core looks like.
1. PHP treats 1/true and 0/false the same
2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is.
3. The line limit is exceeded by some HTML which isn't in any of the vB code.

filburt1 06-10-2003 08:15 PM

I knew it would be taken with offense, none intended...:(

(although if you're serious I'm it ;))

I'm just quoting industry standards as well as what the PHP manual says.

Freddie Bingham 06-10-2003 08:18 PM

Quote:

Today at 02:15 PM filburt1 said this in Post #9
I knew it would be taken with offense, none intended...:(

(although if you're serious I'm it ;))

I'm just quoting industry standards as well as what the PHP manual says.


I suppose you mean no offense every other time you make a post like this?

filburt1 06-10-2003 08:19 PM

Quote:

Today at 05:10 PM Scott MacVicar said this in Post #8
That script doesn't reflect what the vB3 core looks like.
1. PHP treats 1/true and 0/false the same
2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is.
3. The line limit is exceeded by some HTML which isn't in any of the vB code.

1. I know, but for readability, true/false sure is prettier
2. Line 327: "$index[Key_name]" should be $index['Key_name'], technically.
3. Lines 332, 335, and 346 are (mostly) PHP.

filburt1 06-10-2003 08:22 PM

Quote:

Today at 05:18 PM freddie said this in Post #10
I suppose you mean no offense every other time you make a post like this?
Freddie,

I seriously didn't mean to offend and I know you, Scott, and the others worked your asses off on it. However, I'm just used to the Nazi-strictness of the NASA GSFC Code 588 Java Style Guide (http://aaa.gsfc.nasa.gov/Files/JavaFinal.doc), in which most of the concepts can be brought over to PHP.

filburt1 06-10-2003 08:23 PM

Quote:

Today at 05:03 PM freddie said this in Post #7
I'm still waiting to see you code a forum better than the "lowly" vB2 since you obviously think you have the skills. One would hope a moderator of the official hacking site would have a bit more respect.
I tried and abandoned the project in the course of a week :p

edit: a dev himself has once said that he can't stand to look at vB2 code now that he's been working on vB3...can't recall who said it though...

filburt1 06-10-2003 08:26 PM

Quote:

Today at 05:10 PM Scott MacVicar said this in Post #8
That script doesn't reflect what the vB3 core looks like.
1. PHP treats 1/true and 0/false the same
2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is.
3. The line limit is exceeded by some HTML which isn't in any of the vB code.

Clarification: does that mean that these few points don't apply to "actual" vB3 files?

Freddie Bingham 06-10-2003 08:26 PM

I said it.

I was speaking of the formatting, not the code itself.

filburt1 06-10-2003 08:28 PM

Well, me too...:)

Freddie Bingham 06-10-2003 08:30 PM

Quote:

Today at 02:28 PM filburt1 said this in Post #16
Well, me too...:)

What you have here is a Scott quickie script, not vB3. You should reserve your judgement until then.

Scott MacVicar 06-10-2003 08:30 PM

$vb3_index["$table"]["$index[Key_name]"] you would want that over $vb3_index["$table"][$index['Key_name']] as if $index['Key_name'] is a negative integer you would get an error notice.

Which you dont get in the latest versions of PHP as I just tested in there :P

Also PHP will treat what is in there as a string anyway.

The long line is due to indenting and is perfectably readable.

shovel 06-10-2003 09:16 PM

Being that I've studied the layout of releases from vBulletin, I'm guessing a vB3 release very, very soon. on June 15th, at around 12:00PM GMT perhaps? Maybe I should start a money pool and we could "guess" when the release is? :p

filburt1 06-10-2003 09:21 PM

They had a poll going at vB.com a while back...I think all the guesses have expired by now. :D

filburt1 06-10-2003 09:22 PM

Quote:

Today at 05:30 PM freddie said this in Post #17
What you have here is a Scott quickie script, not vB3. You should reserve your judgement until then.
So, you're saying we can blame everything on Scott! Coolies! :p

(j/k...)

shovel 06-10-2003 09:25 PM

Quote:

Today at 06:21 PM filburt1 said this in Post #19
They had a poll going at vB.com a while back...I think all the guesses have expired by now. :D
More the reason to start another. :p

DrkFusion 06-10-2003 10:02 PM

WOa, I have never seen any of Filburts posts where he pulled back from a fight :p

filburt1 06-10-2003 10:30 PM

Well, I do like being a moderator here and seeing all the stuff that we say about KEPTIC behind his back :)

Shuriken-UK 06-11-2003 12:31 AM

woo no conflabs! bring on the next version of vb for meeeeeee

Boofo 06-11-2003 01:00 AM

As long as the scripts and the code do what they are meant to do, then that's all that matters to me. Politically correct don't mean squat when it comes to working code. Just my 3 1/2 cents worth. ;)

filburt1 06-11-2003 01:06 AM

Dammit Bob, use the [high][high][/high] tag! :p

Boofo 06-11-2003 01:11 AM

I was going to, but then I got sidetracked. As long as it works, though, huh? :p ;)

Here is what I got when I ran the script.

Quote:

Any conflicting tables or columns must be removed or renamed before the upgrade to vBulletin 3 proceeds

Table Conflicts
No Table Conflicts

Column Conflicts
attachment

Index Conflict for postid
Column Conflict for postid
I don't know why the attachment column is doing this. I haven't changed anything there that I remember. I plan on waiting a little while to upgrade anyway. ;)

Smoothie 06-11-2003 03:18 AM

Quote:

Table Conflicts

No Table Conflicts
Column Conflicts

No Column conflicts
I'm as ready as it gets. :)

GoTTi 06-11-2003 03:30 AM

/me gulps

/me throws filburt a sword and shield and dives out of the way

Link14716 06-11-2003 04:57 AM

Quote:

Yesterday at 10:11 PM Boofo said this in Post #27
I was going to, but then I got sidetracked. As long as it works, though, huh? :p ;)

Here is what I got when I ran the script.



I don't know why the attachment column is doing this. I haven't changed anything there that I remember. I plan on waiting a little while to upgrade anyway. ;)


You've probably installed the vB3 style attachments, which would cause that conflict.

Link14716 06-11-2003 04:58 AM

Quote:

Yesterday at 06:16 PM shovel said this in Post #18
Being that I've studied the layout of releases from vBulletin, I'm guessing a vB3 release very, very soon. on June 15th, at around 12:00PM GMT perhaps? Maybe I should start a money pool and we could "guess" when the release is? :p
Hopefully not, my license expires on the 14th and I don't feel like renewing for a while ;)

Shuriken-UK 06-11-2003 05:12 AM

lol link if it does come out on 15th i will laugh and laugh :P

Link14716 06-11-2003 05:14 AM

Quote:

Today at 02:12 AM Shuriken-UK said this in Post #32
lol link if it does come out on 15th i will laugh and laugh :P
And if it comes out before I will laugh and laugh. :-D

assassingod 06-11-2003 06:04 AM

Quote:

Today at 03:06 AM filburt1 said this in Post #26
Dammit Bob, use the [high][high][/high] tag! :p
I second that;) It's too early to read light text:(

Boofo 06-11-2003 07:07 AM

Quote:

Today at 12:57 AM Link14716 said this in Post #30
You've probably installed the vB3 style attachments, which would cause that conflict.
No, I never installed that hack. Doesn't work with any of the extra attachments hacks and too buggy for me.

shovel 06-11-2003 12:17 PM

Agreed. :rolleyes:

filburt1 06-11-2003 12:24 PM

Quote:

Today at 02:12 AM Shuriken-UK said this in Post #33
lol link if it does come out on 15th i will laugh and laugh :P
Jelsoft typically does major things on Mondays, so that's not likely.

trafix 06-11-2003 12:46 PM

Here is a tuff question .....

How much work would it take to rebuild hacks to VB3

I am talking about a major hack like my members choice ... It is basicly fully self contained.

Any ideas??

shovel 06-11-2003 12:51 PM

Get ready for some major coding trafix. ;)

filburt1 06-11-2003 01:18 PM

Luckily for me, vBMS shouldn't come to a complete rewrite the way I designed it *sly look* :p


All times are GMT. The time now is 04:47 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01469 seconds
  • Memory Usage 1,824KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (18)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (40)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete