![]() |
New vB3 script is out
<a href="http://www.vbulletin.com/forum/showthread.php?threadid=73163" target="_blank">http://www.vbulletin.com/forum/showt...threadid=73163</a>
|
No table or column conflicts, i'm all set for vB3;)
|
im good too ;)
|
Yep I saw this just after it was posted, no conflicts on my end either, didn't expect any :)
|
BTW, based on this script, i still have to say the devs aren't making good enough code. I know I sound like an a-hole, but what I see:
1. 1 and 0 everywhere instead of true and false 2. STILL using array keys not in strings 3. Exceeding 80-char line limit However it's a billion times better than vB2, nobody can argue with that. |
Quote:
I think we need to hire you as a developer so you can show us how it is done. I'm still waiting to see you code a forum better than the "lowly" vB2 since you obviously think you have the skills. One would hope a moderator of the official hacking site would have a bit more respect. |
Quote:
1. PHP treats 1/true and 0/false the same 2. The array keys not in strings, i couldn't find any of these in the scripts. Please do show me where it is. 3. The line limit is exceeded by some HTML which isn't in any of the vB code. |
I knew it would be taken with offense, none intended...:(
(although if you're serious I'm it ;)) I'm just quoting industry standards as well as what the PHP manual says. |
Quote:
I suppose you mean no offense every other time you make a post like this? |
Quote:
2. Line 327: "$index[Key_name]" should be $index['Key_name'], technically. 3. Lines 332, 335, and 346 are (mostly) PHP. |
Quote:
I seriously didn't mean to offend and I know you, Scott, and the others worked your asses off on it. However, I'm just used to the Nazi-strictness of the NASA GSFC Code 588 Java Style Guide (http://aaa.gsfc.nasa.gov/Files/JavaFinal.doc), in which most of the concepts can be brought over to PHP. |
Quote:
edit: a dev himself has once said that he can't stand to look at vB2 code now that he's been working on vB3...can't recall who said it though... |
Quote:
|
I said it.
I was speaking of the formatting, not the code itself. |
Well, me too...:)
|
Quote:
What you have here is a Scott quickie script, not vB3. You should reserve your judgement until then. |
$vb3_index["$table"]["$index[Key_name]"] you would want that over $vb3_index["$table"][$index['Key_name']] as if $index['Key_name'] is a negative integer you would get an error notice.
Which you dont get in the latest versions of PHP as I just tested in there :P Also PHP will treat what is in there as a string anyway. The long line is due to indenting and is perfectably readable. |
Being that I've studied the layout of releases from vBulletin, I'm guessing a vB3 release very, very soon. on June 15th, at around 12:00PM GMT perhaps? Maybe I should start a money pool and we could "guess" when the release is? :p
|
They had a poll going at vB.com a while back...I think all the guesses have expired by now. :D
|
Quote:
(j/k...) |
Quote:
|
WOa, I have never seen any of Filburts posts where he pulled back from a fight :p
|
Well, I do like being a moderator here and seeing all the stuff that we say about KEPTIC behind his back :)
|
woo no conflabs! bring on the next version of vb for meeeeeee
|
As long as the scripts and the code do what they are meant to do, then that's all that matters to me. Politically correct don't mean squat when it comes to working code. Just my 3 1/2 cents worth. ;)
|
Dammit Bob, use the [high][high][/high] tag! :p
|
I was going to, but then I got sidetracked. As long as it works, though, huh? :p ;)
Here is what I got when I ran the script. Quote:
|
Quote:
|
/me gulps
/me throws filburt a sword and shield and dives out of the way |
Quote:
You've probably installed the vB3 style attachments, which would cause that conflict. |
Quote:
|
lol link if it does come out on 15th i will laugh and laugh :P
|
Quote:
|
Quote:
|
Quote:
|
Agreed. :rolleyes:
|
Quote:
|
Here is a tuff question .....
How much work would it take to rebuild hacks to VB3 I am talking about a major hack like my members choice ... It is basicly fully self contained. Any ideas?? |
Get ready for some major coding trafix. ;)
|
Luckily for me, vBMS shouldn't come to a complete rewrite the way I designed it *sly look* :p
|
All times are GMT. The time now is 04:47 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|