vb.org Archive - PM on Promotion

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - PM on Promotion (https://vborg.vbsupport.ru/showthread.php?t=328659)

lange

03-16-2021 12:31 AM

PM on Promotion

Hi,

I would be interested by this mod under vB3 (maybe vB5 too).

https://vborg.vbsupport.ru/showthread.php?t=140629

No problem for the install. Promotions are done with no error message but no PM is sent to the user. No PHP error in the logs too. Tested on default style.

I will retest later.

Regards

TheLastBatman

03-16-2021 01:14 AM

Not tested but in the install instructions change $pmdm =& datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY); to $pmdm = datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY);

lange

03-16-2021 01:55 AM

Installed the product again, replaced the line of code and tested the promotion...

This time as it is said in the last message of the topic, the cron job does not work, the promotion is not done automatically. No PM sent to the user again.

In the logs:

Code:

PHP Deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /home/.../public_html/.../includes/class_dm.php on line 810

PHP Fatal error:  <ul><li>blabla</ul>Unable to proceed with save while $errors array is not empty in class <strong>vB_DataManager_PM</strong> in /home/.../public_html/.../includes/class_dm.php on line 810

TheLastBatman

03-16-2021 04:21 AM

Got it working

PHP Code:


		
			
$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_primary_alertpm'], $promotion['username'], $promotion['title']);
                $pmdm = datamanager_init('PM', $vbulletin, ERRTYPE_SILENT);
                $pmdm->set_info('is_automated', true);
                $pmdm->set('fromuserid', $vbulletin->options['sendpm_on_promotion_fromuserid']);
                $pmdm->set('fromusername', $vbulletin->options['sendpm_on_promotion_fromusername']);
                $pmdm->set_info('receipt', false);
                $pmdm->set_info('savecopy', false);
                $pmdm->set('title', $vbulletin->options['sendpm_on_promotion_pm_subject']);
                $pmdm->set('message', $pmbody);
                $pmdm->set_recipients($promotion['username'], $pmpermissions);
                $pmdm->set('dateline', TIMENOW);
        $pmdm->set('allowsmilie', true);

                ($hook = vBulletinHook::fetch_hook('private_insertpm_process')) ? eval($hook) : false;

                $pmdm->pre_save();
        if (empty($pmdm->errors))
                {
                    $pmdm->save();
                    ($hook = vBulletinHook::fetch_hook('private_insertpm_complete')) ? eval($hook) : false;
                }
                unset($pmdm);

lange

03-16-2021 09:57 AM

I tested quickly by forcing promotions to 2 of my 11 usergroups and it works fine on PHP 7.4.x with no error message in the logs. I will restore my database and let the automatic promotion system go to see if it still works. I will give you some feedback but there is no reason that the automatic system does not work.

I only tested for the number of posts as a requirement for promotions. Do you think it will work if reputation is considered in promotions?

Anyway, I'll test that too before the feedback.

Thank you very much!

lange

03-16-2021 03:11 PM

1 Attachment(s)

OK, tested on a clean new install/restored database.

The mod works well by manually running the promotion, the PM is sent and received correctly by the user. Unfortunately it's not working automatically, it's listed, enabled and scheduled in the scheduled task but the PM is not sent and received by the user. No PHP error in the log.

I checked the scheduled task log, it's listed. See the Attach File.
Log Phrase: Usergroup: <strong>{1}</strong>{2}; Users: {3}<dfn>* = Primary Usergroup, % = Secondary Usergroup</dfn>

The other tasks seem to work normally, at least for the Thread Views task. I did not check for other tasks.

Maybe something needs to be fixed in cron.php or some other files.

Regards

lange

03-16-2021 08:05 PM

I think I will use this mod by disabling the User Promotions cron on the list and manually running it once a day for example. It just remains to check if everything else is working properly.

Seven Skins

03-16-2021 10:38 PM

See if this helps...

Change this line:

PHP Code:


		
			
$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_alertpm'], $promotion['username'], $promotion['title']);

TO:

PHP Code:


		
			
$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_primary_alertpm'], $promotion['username'], $promotion['title']);

lange

03-16-2021 10:53 PM

Thanks

It's already included there

Tested this morning.

TheLastBatman

03-16-2021 11:00 PM

yeah if the auto cron isnt running that may be an issue else were, I had a member on my site report they never received a registration verification email either, so there may be a hick-up in the php 7.4 version.

lange

03-17-2021 09:08 AM

I will try to use the cPanel cronjob to make the PHP promotion cron work.

TheLastBatman

03-17-2021 04:11 PM

let me know if that works, are you using 3.8.14 also? and if so are auto emails being sent for registration for you?

lange

03-17-2021 04:59 PM

1 Attachment(s)

OK, I will respond to the topic if it works on cPanel.

Yes all email stuff works otherwise I wouldn't use 3.8.x especially since my forum is totally private (by invitation only) with only a very small login box as homepage.

Send Welcome Email
Welcome Private Message
Email Address to Notify About New Members
Verify Email address in Registration

Right now, it is 7.4.9. A few weeks ago, it was 7.4.11, I don't know the reason for the version downgrade.

lange

04-10-2021 07:25 AM

Feedback

I tried the cron with all possible permutations. This does not work under PHP 7.4. Not tested with previous versions.

Code:

/opt/cpanel/ea-php74/root/usr/bin/php /home/username/public_html/forum//includes/cron/promotion.php >> /home/username/myjob.log

/usr/bin/curl example.com/includes/cron/promotion.php

/usr/local/bin/php -q /home/username/public_html/forum/includes/cron/promotion.php > /dev/null 2>&1

All times are GMT. The time now is 05:03 PM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01229 seconds Memory Usage 1,765KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (2)bbcode_code_printable (3)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (14)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: