![]() |
[BUG] Tournament ladder
Seems as though my members are not moving up to the next round sometimes.
Before I had players not moving from 1st round up to 2nd round. Now They seem to be not moving from 2nd round to 3rd round (finals). Aslo, if member1 beats member2, member1 goes above member3 and member4 in the next round. Here's what it looks like (click to enlarge, of course): https://vborg.vbsupport.ru/external/2006/01/5.jpg As you can see in the 1st round, jessicajoanne moved above cyberhypnotic's 1st match when she won and I moved above hers when I won. Then moxdevil won the 2nd round and moved above jessicajoanne and cyberhypnotic's 2nd match. Also, jessicajoanne won the 2nd round, but it won't move her up. Any suggestions? One last thing, is the tournament fixed to be playable on IE? |
Tournaments are playable in IE, yes :)
The sorting in each line depends on the UserID, this means your 2nd round with 4 players left is sorted by UserID from left to right. That's why "jessicajoanne" moved leftmost, seems this user has the lowest UserID. This User also should move up to the Final, that's right... Hmmmm, I will check this again. Please test 2- and 4-player-Tournaments, they should work well ? |
2 Player tournament worked fine. I'll check on the 4 Player tourney.
Here's the thing. You said the users are moved according to UserID? Well, by UserID, they are lined up jessicajoanne (11), cyberhypnotic (1), moxdevil (13), and nsewerin (14). Same with the 1st round. As you can see, moxdevil is 13 and nsewerin is 14, but 69Charger is 50 and between them. :ermm: This is just a guess, but this is my thoughts on it: What if - moxdevil(13) moves up before jessicajoanne(11), therefore being organized according to UserID before jessicajoanne(11) is able to move up. Know what I mean? (13) took the place of (11), therefore leaving nowhere for (11) to go, so (11) sits in 2nd round waiting. Another thing. Nothing big and major, just a typo. Some people might want to know how to fix it later on though: In arcade.php (root folder), if you look for one time: Code:
{$playerinfo[3]['timesplayed']}{$ibforums->lang['tourneytxt1']} Code:
{$playerinfo[3]['timesplayed']}{$ibforums->lang['tourneytxt2']} |
Hmmm, did you upgrade to v2.5.4+ and have the actual arcade.php ?
|
Yes, I had version 2.5.3 installed from a fresh install originally. Then when you released 2.5.4, I followed instructions exactly as given.
I've had this problem, even in version 2.5.3. I'm actually surprised nobody else complained about it, which kinda makes me think it's something with my copy only. Do you suggest an uninstall and then a fresh install? Should I delete everything from my server, including games? Making it like it never existed? Then do a brand new fresh install? Or are you still looking into the code? Is there any possible way to stop the code from ordering by member ID? That way, the winner of each round just moves up to their respective next round in the ladder? |
MR.Zeropage
Im getting this error: Code:
There is a SQL error. |
@cyberhypnotic:
I can confirm that there sometimes is a problem with 8-player-tournaments, but I am not sure how to reproduce it. This now is on the "Bug-List" and I will look for a fix. The sorting is another thing I'd like to change, and as there are many planned improvements for the Tournament-System I guess this will come along with that. @Reece B: Create the Tournament in AdminCP instead of ModCP and the Error won't show up ;) Will fix the ModCP in v2.5.5+ :) |
MrZeropage, could you tell me which part of the code deals with sorting? Maybe I can take a look at it and if it looks doable for me, I can alter it to disable the sorting.
I can just comment out the sorting portion of the script. |
Okay cheers mr.zeropage!
|
@cyberhopnotic:
Here is the Code that generates the Tournament-View: Code:
for($i=1; $i<=$numrungs; $i++) { As you see the concept seems to be the problem, as it is sorted by "faceoff" (Match1, Match2 ...) which is ok but is not looking up in which faceoff/Match this player was in the last round ("rung"). I guess this can only be solved by one additional query ... |
What about this line at the bottom:
Code:
$this->output .= $this->define_ladder($i, $playerinfo); I see that it's mainly tables, so is it possible to separate the tables by doing this: 8 player tournament: Table 1 with 3 tables within (not counting the tables to make up the lines that connect each round): first set of 2 players move up to connected table (next round) Table 2 with 3 tables within: second set of 2 players move up to connected table (next round) Table 3 with 3 tables within: third set of 2 players move up to connected table (next round) Table 4 with 3 tables within: fourth set of 2 players move up to connected table (next round) That way in the 2nd round (rung) it doesn't mix up playerinfo[0] and playerinfo[1] and it doesn't mix up playerinfo[2] and playerinfo[3] with any other tables with the ordering because it can only go to the next table up, which is only one choice, not 4 total. OR Simply put: 8 player tourney: playerinfo[0] OR playerinfo[1] = playerinfo[0] in next rung (round 2) playerinfo[2] OR playerinfo[3] = playerinfo[1] in next rung (round 2) playerinfo[4] OR playerinfo[5] = playerinfo[2] in next rung (round 2) playerinfo[6] OR playerinfo[7] = playerinfo[3] in next rung (round 2) THEN playerinfo[0] OR playerinfo[1] = playerinfo[0] in next rung (final match) playerinfo[2] OR playerinfo[3] = playerinfo[1] in next rung (final match) THEN playerinfo[0] OR playerinfo[1] = playerinfo[0] in next rung (tourney champ) Something like would work? Of course with all of the if conditions and such. Remember, I'm not a great piece of work with code, but I would like to learn more and I've learned enough to make out some things and possibly switch up some things. For example, I took the Post Award Hack, which only allowed to post one award and altered the xml a little into another plug in (Post Award Hack#2) and Imported Product as a separate product so I could have 2 awards to post. Yes, it took a little more coding to make it work, but it worked is all that matters. This stuff makes me tick, basically. I love messing around with coding and scripts. More of a hobby I guess though. But that's off topic... back on topic. So would any of these things above work out in a coded PHP environment? |
Hmmm, I will think about that idea to query the last round/rung and then check who advanced :)
|
OK. I'll be around.
If I knew more about PHP and databases, I'd try to help figure it out more. Sorry that I can only lend my minimal help. |
Any word on the progress of this?
Appreciate the help so far. |
Any word on how this is going?
|
MrZeropage, any news on this issue? My members are getting restless, lol.
|
I work okay, as long as every one summit there score and do not have a zero then it will work fine. If it cotain zero score then the user will never advance
|
Obviously if someone has 0 points they will never advance. :rolleyes:
This isn't about that. If you read back, you'll see exactly what the problem is. Basically, if player 8 wins first, they get placed ABOVE players 1 & 2, therefore blocking 1 or 2 from moving up. Got me? I've been posting this issue since BEFORE the release of 2.3.4 and it's STILL an issue. Apparently I'm never going to get a damn solution from the author of the code though. |
I haven't been able to organise a tournament since the upgrade to 2.5.4 .. emails are sent to members and when they click on the link to start the tournament all they see is a blank page with a single crown on it !?
|
MrZeropage, it's been awhile since we last discussed this. Is it possible that you could respond in regards to the questions in this thread?
Also, I've been thinking about the tournament ladder order. Isn't there a way you could work with the cases and make them if statements? Like, if playerinfo[0] is greater than playerinfo[1] then playerinfo[0] is the result for the next rung, else if playerinfo[1] > playerinfo[0] then playerinfo[1] is the result for the next rung? I'm STILL having problems with the ordering of the members in an 8 player tournament. Am I doing something wrong? When I assign them to matches, during the creation of the tournament, am I supposed to keep them in a specific order? |
Mines doing the same thing on the ladder rather it be a 2,4,8 player tourney some work fine others don't seems to be a hit and miss like right now I have 19 tourneys some 2,4,8 I have 1, 2 player tourney showing has played has scored and like no info then I have three 4 player ones that are like that 2 messed up first level other ones did not allow the player to play second level..and my 8 ppl tourneys I have only gotten 1 that worked and submitted with a crown..
It seems to be a hit and miss deal with computing something..not sure will subscribe in hopes of a fix.. |
Zeropage know of this bug and he is working on it.
|
I wanted to add i know its being worked on but tonight when going through to delete some of the tourneys that went bad I noticed something..every tourney thats not completing and spazing out shows the user it stalls on added twice not sure if this helps for example my dizzy tourney stalled and it shows this
Edit Tournament No user was found for some of the UserIDs entered or you entered the same ID more than once. Player MamaShea replace LM50538 replace gavinsmom replace RobynLynn replace MamaShea replace Notice how mamashea is added twice did the same thing on all bad tourneys some user is in their twice..and I did not add them twice anyway thought this info might help figure this bug out..I know on some its suppose to do this but its doing it on some when the user has not even played yet like the tourney above mamasheas has the has played 3has played best result: its not giving her a play button or how many she has played anyway not sure if it helps but thought I would add it incase.. |
I am currently thinking about re-coding that Tournament-Table to make it work the way we want. Will spent this weekend on Tournaments
|
Any updates MrZero :) I love the tourney system its a huge hit on my site hope you figure it out :) I will test for you as well if you need some testing :)
|
Looks like it is done and works good - just got back from my short holiday-trip and will concentrate on releasing ibPro v2.5.5+ a.s.a.p.
|
look forward to it :)
|
All times are GMT. The time now is 05:57 PM. |
Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
![]() |
|
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|