Second problem is solved

Try to post this url between [img] tags in your sig

do not forget to turn on redirect in sigs and tell me what happened

Got it - it was vbFirewall - this mod: https://vborg.vbsupport.ru/showthread.php?t=196791

Thanks for updating us, NLP-er. Much appreciated. :)

Sayid: thank you, that's extremely helpful. I believe I've pinpointed the problem; vBulletin has a setting to define the maxium height and width of even remotely-hosted signature images like that one. If an image is above these limits, vB treats it like a link, instead, hence the redirection.

I'll take a look at putting together a quick patch. Thanks again for the clarification. :)

I don't know why, but all of our signature images, regardless of them being local or remote, are not showing up properly.

The remote ones just show up as a link, while the local ones just show up as SIGPIC (in brackets).

I have even set the option to enable this only for guests, yet it is still doing this for all the non-guests.

Even with all of the options turned OFF in the settings page, the signature pics do not work.

They ONLY work when the product is disabled.

The only other modification installed is vMail. This is on a 3.8.3 install.

Thats the same as I am experiencing.

I am getting a funny error message whenever you click on a member's username ..... saying



http://www.naijadiscussion.com/naijaforum/index.php4

Links that have variables in them like this, result in an 'invalid url' error:

That is likely from an improperly done file edit.

Thanks, I will look into it and fix it.

I applied the 1.03 update but it still kills all of my signature images regardless of they are local or external.

See attached for an example.

I've got a fix worked out for some of the signature images which I'll have up shortly, though turning off verification for signatures should certainly stop the problem in the meantime; I've tested both uploaded signature pictures and remotely-hosted IMG tags this way, and both show up fine when the signature setting is set to "No."

Re-upload the latest externalredirect.php file; it has modified URL verification. :)

Hard to diagnose from afar (though let me know if turning off signature verification fixes the issue).

If you're comfortable with giving me temporary admin/FTP access via PM, I'd be glad to take a look. :)

Unfortunately, even with signature verification turned off, the issue persists. I have to disable the product to prevent the error.

I'll send you a PM shortly, thank you.

Not at all! Sorry to hear about the issues; I'll do what I can to pinpoint them, and I'll look forward to the PM. :)

This mod conflicts with Links and Download manager.
I am getting this weird error on various pages:
When I turn Two-Step links off, they dissappear.

Everything works fine now. It was the file edit that was not improperly done.

Thanks aspen0 .... great mod

installed and nominated :up:

Okay, to anyone having issues with images in signatures: it appears there's a conflict only when a user is using an upload signature picture and an externally-linked image at the same time. I'm looking into how best to work around this, but for those of you who allow both of these things and want to keep using the rest of the hack (for posts, comments, blogs, etc.), here's a quick fix:

Just update the "Remove external link on postbit signature" plugin in the "in the "postbit_display_start" hook location. Replace it with this:

Set signature verification to "No" and your signature images should be left alone, and you can use the rest of the hack's functionality for the time being.

I've yet to see how this would help at all with SEO
It's no different that adding a nofollow tag to external links IMO
Has anyone installed this and done nothing else and has seen positive results from it?

regards

I'm not sure if you read aspen's initial posts, but they explain the SEO benefits. They also explain why adding nofollow tags to external links doesn't work the way it used to.

Please see here:

http://www.mattcutts.com/blog/pagerank-sculpting/

At least on Google for sure, nofollow no longer provides any SEO benefit. Zip zero zilch.

Hello thank you for mod. But i cant make it work for me. I have done all file mods, put php file in forum root, installed product. But no effect :(. I have vbseo installed maybe that's the problem. Can you help me please with some advice?

The fix you posted does indeed work, but I only allow my users to use an upload signature and it happens to me, as well. It only happens on signatures that have an image that is linked. At least, as far as I can tell. This signature triggered the issue:

Now, what I did find was that... in the user's profile, in the "About Me" section, it works perfectly. But in showthread, it just displays the sigpic tags. HTH.

There may be a conflict with VBseo. You could have also done the file edits incorrectly. Please doublecheck your work, they can be confusing, for instance one edit needs to go just inside a closing } in a line of 3 } and it can be easy to misread it and put it after all three, instead of after just the first two.

Some sections on my forum are mostly driven by RSS feeds from other external sites so I have lots and lots of links to other sites. Trust me .. I am seeing a big positive difference in what the mod is doing already on my site. I had once used the rel="nofollow" anchor tag attribute without any value-added noticed so I say stay clear of it.

I am monitoring this mod on my site and will provide updates later. So far, it works well for me.

You can check for yourself > Naija Discussion Forum


:up: :up: :up:

Yeah thank you. It was my mistake in file edits.

Hi,
The following link gives a invalid url:
http://jv.news24.com/Beeld/Opinie/Ru...540963,00.html

This seems to be the case on all none www urls, any help on this?

Thanks

if you've got it installed please mark it as such Stefanus.

I will look into that bug, should be an easy fix.

Subdomains/non-www domains work fine; it's the commas that's causing the problem. I've modified the externalredirect.php file to allow for those, as well. Just uploaded the attached version over your existing one. :)

Updated, the only new file is the externalredirect.php, you can just upload the new one.

The update is that we've seriously relaxed the URL verification. It was decided there really wasn't a need for security to make sure the url variable was actually a URL and people kept posting weird URLs that would break it, so its gone.

This is different from the one Chris just attached above.

Please help - I get a 500 Internal Server Error when any link is clicked. externalredirect.php works as a page but the error comes if the outgoing url is included as ?=...

I also have the issue with images in signatures?. Was this ever resolved?

Yes, just recently. :) If you're using both an embedded external image AND an uploaded signature image in signatures, find the "Remove external link on postbit signature" plugin and change its location from "postbit_display_start" to "postbit_display_complete" and populate it with the following code:

You might have to empty your signature cache under Maintenance -> Update Counters, as well. Let me know if this works for you. :)

Regarding the 500 error; I'm afraid I don't quite understand that last part. Could you rephrase?

Thanks

I just installed this and it works only for new posts for me :-(.

When I perform Rebuild Post Cache in Maintenance -> Update Counters, all external links change to normal - without externalredirect.php in address (even those which I just created and worked until rebuild of post cache).

When I have post with external link (without externalredirect.php in address) and I resave this post (only hit edit and just after it save), redirect appears.

Any ideas why process of rebuilding post cache is removing redirects on external links?

I also tried disable all hacks and install this on two separate forums - still the same result.

vBulletin 3.8.3

It could be the postcache process doesn't call the same hooks as the normal posting process, I don't know though.

I know I noticed some inconsistencies as well, but they only lasted a few minutes. We'll see if the other Chris has any ideas.

Found a bug in 1.0.4

https://vborg.vbsupport.ru/external/2009/08/23.png

If you have RSS enabled on your site, it uses the external.php file and when a member visits an external link, they are directed to the WARNING page.

But it looks like that when Im looking at who's online.

The mod works fine, but just thought Id point out this little "incompatibility".

Maybe its just me :-P

The highlighted part of the link has nothing to do with the external page, its a link thats meant for my site.

The post cache should use the standard bb code parsing functions. Are you sure the settings are all set to "Yes" before the rebuilding?

There's an automatic redirect on the external link page.
You think google does not detect this?

This is great and I caught it at the perfect time. My most recent forum is brand new. It looks like this awesome hack doesn't go back and handle old post links. However, my site only had like 10 links so far. :)

Thank you for this. The only other option besides having horrible page rank was to disable live links... and that's a no-no!