Private Messaging Cut-off bug

[Tom1234]

Even though I have "Private Messaging Cut-off Limit" set to 0, I am seeing this statement in warning PMs:

"Please note that your Private Messaging system in our Forums has been deactivated, due to your Warning Level."

[sv1cec]

Even though I have "Private Messaging Cut-off Limit" set to 0, I am seeing this statement in warning PMs:

"Please note that your Private Messaging system in our Forums has been deactivated, due to your Warning Level."
Yeap, in your functions_warning.php find:


if($vboptions['warn_send_pm_warning']==1 AND $level < $vboptions['warn_pmcutoff'])


Replace that with:


if($vboptions['warn_send_pm_warning']==1 AND $level < $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0)


Also in the same file find:


if($vboptions['warn_send_em_warning']==1 OR ($level >= $vboptions['warn_pmcutoff']}


Replace that with:


if($vboptions['warn_send_em_warning']==1 OR ($level >= $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0))


Didn't try these, but they should work. Somehow I didn't take into consideration, that you could set that to zero, stupid me.

Rgds

[Tom1234]

There is a comment in the form that implies you should set it to zero to de-activate it, so I didn't think that would be rare:

"If you set this number to anything but 0,..."

Should I be concerned along the same lines about the avatar and signature cut-off limit? I have them set to zero also.

[sv1cec]

LoL, not you, I was concerned, that I haven't done something stupid in the other places as well. You were right, to set it to zero, it's just that when I made the code, which adds that remark at the end of the PM or email, I didn't bother checking for zero value, I just checked if the warnings lever was higher than the cut-off limit.

No the rest of the code is correct, I checked!!

Rgds

[kmike]

This has caused the absence of PMs about warning in 3.4.7 when PM cutoff is zero.
When I change this line:

if($vboptions['warn_send_pm_warning']==1 AND $level < $vboptions['warn_pmcutoff'] AND $vboptions['warn_pmcutoff']>0)


to the v3.4.6's:

if($vboptions['warn_send_pm_warning']==1)


in includes/functions_warning.php, all works as expected.

[sv1cec]

Yes, but you are not covering the case, when a user is receiving a warning while being above the pm cutoff limit. He can't see the warning PM in this case, that's why in the laterst versions, whoever is above the cutoff limit, gets an e-mail, instead of a PM.

[kmike]

But new code simply doesn't send any PMs when "PM cutoff" is zero and user already has some warnings, because $level is always greater than $vboptions['warn_pmcutoff'] in this case.

[sv1cec]

You are right, the conditional should be changed to :


if (($vboptions['warn_send_pm_warning']==1 AND $vboptions['warn_pmcutoff']==0) OR (($vboptions['warn_send_pm_warning']==1 AND $vboptions['warn_pmcutoff']!=0 AND $level < $vboptions['warn_pmcutoff']))


I'll change it in the next release, asap.

Rgds and tnx

[Tom1234]

Is this fixed in 3.4.8 or the next release after that?

[sv1cec]

No, got it fixed in 3.4.8.

Rgds and sorry for the inconvenience.