More upgrade instruction problems..

[drumsy]

I don't know what the problem is, but a lot of the instructions in the latest upgrade seem to be telling me to locate code that's a little bit different than before.

An examples:

From the installation instructions for 3.4.4, the version I installed two days ago:


In the same file, find:

// ### NOT PREVIEW - ACTUAL POST ###
if ($newpost['visible'])
{

Right below that, add the following:

// Change for automatic warning
// You have to use "ObsceneWords" as Title of the Warning.
// You have to use a Hidden Warner.
if ($vboptions['warn_automatic'] == 1)
{
$Protected_Usergroups = explode("|",$vboptions['warn_protected_usergroups']);
if($Protected_Usergroups[0])
{
foreach($Protected_Usergroups as $pro)
{
if($pro == $bbuserinfo['usergroupid'])
{
$userprotected = 1;
}
}
}
if ($bbuserinfo['userid'] != 1 AND $userprotected != 1 AND $wehavecensoredwords == 1)
{
// Get Warning Types
$warn_type = array();
$warn_type = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "warning_types WHERE warn_name='ObsceneWords'");
$thread1="}/showthread.php?p={$_POST['postid']}']Warned Post ('{$vboptions['bburl')";
$thread2="$vboptions[bburl]/showthread.php?p=$newpostid";
$warnerdata=$DB_site->query_first("select username, email from ".TABLE_PREFIX."user where userid='{$vboptions['warn_automatic_warner']}'");
if ($alert=='')
{
$alert='No';
}
warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment, $alert);
}
}
// End of automated warnings things

In the latest download, the upgrade instructions from 3.4.4 to 3.4.5 state this:

3. Edit newreply.php and find:

$wcomment="(This is an automatic warning, no moderator was involved.)";
if ($alert=='')
{
$alert='No';
}
warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment,$alert);

Replace this with:

$wcomment=$original_text;
if ($alert=='')
{
$alert='No';
}
warn_calculations($warn_type['tid'], $wcomment, $newpostid, $bbuserinfo, $vboptions['warn_automatic_warner'], $alert);

$wcomment="(This is an automatic warning, no moderator was involved.)";

warn_notify($thread1, $thread2, $bbuserinfo, $warnerdata['email'], $warnerdata['username'], $vboptions['warn_automatic_warner'], $warn_type, $level, $wcomment,$alert);

Now, is it me, or was the following line never even in the 3.4.4 installation instructions?

$wcomment="(This is an automatic warning, no moderator was involved.)";

It's in the newest installation instructions, but not in the one I had. This makes it very confusing when upgrading. Please advise...

Also, for English users, in the pm_newpm, that line should read: You appear to be the Collector of this site. Under which ID do you want this message to be sent?

[sv1cec]

You are right. What happens is that I constantly work on this hack and improve it, correct errors etc. Sometimes I find something, and I correct it. Usually what I do, is create a new zip and upload it, perhaps using the same version number (else would would be in version 341.145.983 or something). I advise users to always download the latest zip, just before starting the installation. But even if you do that, there is no guarantee that something will not be added later on. Usually these are small things, which are in the hack's files, so next time you do an upgrade and the hack files will be uploaded, you will upload the latest version.

In this instance, it was in a standard file, so I apologize. What else can I say?

As for the template, please understand that English is not my first language, so sometimes my English are not perfect.

Rgds

[drumsy]

No problems, I just wanted to make sure that I was seeing things correctly, and also advise other installers to be vigilant.