Log in

View Full Version : Another small "bug" or oversight :P


Dorign
03-23-2005, 04:33 PM
In the options, you're able to name the currency the itemshop uses. However, in the templates, they're all hardcoded for "Gil." :P

Revan
03-23-2005, 05:15 PM
Yeah yeah... but changing that takes bloody ages! :p
Nah jk I will get around to it for Final, I promise :)

Dorign
03-23-2005, 06:53 PM
Take your time, I know changing it takes bloody ages.. I was going through changing "Gil" to "GP," but it took so long I just settled for "Gil." :P

Revan
03-23-2005, 07:34 PM
If you are feeling lucky and want to test something out for me, you could try using the search and replace in vB Styles and Templates, replacing "Gil" by "$vboptions[rpg_currency]"

hang on... all I have to do is use this search and replace in my xml file
Why didnt I think of this.... d'oh!

First step: Open postbit_legacy and find both instances of "Gil" replacing with $vboptions[rpg_currency]

Okay I made revision1 of the rpg_templates.xml, upload and run the Repair -> Templates in rpg_install.php :)
You tell me where else that phrase is hardcoded and I'll fix, but I think that there shaved the major bits off ;)

Dorign
03-24-2005, 07:49 PM
Did that.. still saw "Gil" in a few places.. might have been something I did, though.

rpgcp.php
lottery.php

Two of the places I saw "Gil." Also, though it wasn't tested, I noticed when I retreated from a monster once, it said the monster gained 4 gil; not sure if that one was hardcoded or set to the variable.

I'll leave it as Gil, though, for now.. if someone else wants to test this.. :P
(my users like "Gil")

Revan
03-24-2005, 08:38 PM
Monster gained 4 gil? What the hell do monsters want with money? :p
And Im sure I fixed both those scripts, might be summit you did then ;)

Dorign
03-25-2005, 11:07 PM
All I know is it said the monster got 4 gil when I ran.. :P

Revan
03-26-2005, 12:42 AM
That was a non-harmful bug, pwned.

Dorign
03-26-2005, 02:26 AM
Yeah, I thought it was funny, reminded me of fleeing in FFIV and VI. :P Still, just figured I'd mention that it was naming "gil" there, in case you ever were searching things down in the future.