ver3 b1 - bugs i noticed after upgrading...

[Chief Corn]

upgraded to ver3 b1 from ver2.53, had to remove and insert all the new code into the files before i could run rpg_install.php. install ran with no problems.

Bugs & Problems I have since upgrading:

1.) Healing Center doesn't heal you, and it doesn't post correct number of points/money in pocket. (FIXED, SEE MY UPDATE BELOW)

2.) Item Shop purchasing items aren't being displayed (expanded or contracted), and tried running DB fix but to no avail. (FIXED)

3.) Not sure if it's just me as admin, but my class avatar disapeared as well as my atck, def, spd, etc. points..but i can see everyone elses class avatar and correct number of pts. my class_id in the admincp user settings it's set to 1 which is amazon and is correct. it looks like my class isn't registering though making all my stats blank. (FIXED)

4.) the new file headquarters.php has a mysql error when launching: Table 'database_name.rpg_limit_settings' doesn't exist. Invalid SQL: SELECT level1_wins, level2_wins FROM rpg_limit_settings. (FIXED)

5.) after creating a New Battle it brings you to a blank page, and doesn't register when you check in Browse Battles. (FIXED)

Created a test account for anyone who would like to try the beta before they install it on their forums. Took the chance of installing it since we only have like 5 people playing...so no big harm done. Help would be appreciated. Thanks in advance.

Site: http://www.TreeThugs.com
User: vBorg
Pass: test

***UPDATE***
problem #1 fixed (healing center not healing). seems when it transfered the rpg_heal template to the new RPG Integrated category it did not change the "?action=" call to "?do=". money was fixed by removing [money] after $usermoney.

maybe alot of the problems i'm having can be resolved with some template fixes.

[Revan]

2.) Item Shop purchasing items aren't being displayed (expanded or contracted), and tried running DB fix but to no avail.This may be related to problem #3, awaiting feedback after trying the below.

3.) Not sure if it's just me as admin, but my class avatar disapeared as well as my atck, def, spd, etc. points..but i can see everyone elses class avatar and correct number of pts. my class_id in the admincp user settings it's set to 1 which is amazon and is correct. it looks like my class isn't registering though making all my stats blank.You must understand that if the upgrade ran absolutely flawless, Class ID #1 is Unknown, while Class ID #2 is Sky Reaper. Amazon is Class ID #34, IIRC.
You may need to re-create your character, and hit Update in headquarters.
Then try to purchase items again.

4.) the new file headquarters.php has a mysql error when launching: Table 'database_name.rpg_limit_settings' doesn't exist. Invalid SQL: SELECT level1_wins, level2_wins FROM rpg_limit_settingsFixed, please download the new zip and replace headquarters.
Also, look at this thread https://vborg.vbsupport.ru/showthread.php?p=621178#post621178 for fix to error in newthread/newreply if any.
If you do not get errors in those files, then do not apply the above fix.

5.) after creating a New Battle it brings you to a blank page, and doesn't register when you check in Browse Battles.This may be related to a template problem, try reimporting your templates manually in ACP.

[Chief Corn]

didn't realize there was a problem with the newthread/newreply until i tried doing it and deleting those bits solved that problem. thanks for that fix

i uploaded the new headquarters.php and that did trick. all options worked as they were supposed to. i deleted all old templates. then reuploaded all the files anyways and did a full repair from the rpg_install.php to see if it would resolve any bugs.

my class avatar and atk, def, etc points are back after using headquarters.php (my class was reset to unknown). one thing that caught my eye though after updating my stats is my hp jumped to 155 from 59 what i previously had. i assume that would be the new revamped stats calculating?

i deleted all old templates, and everything is at default (as of this posting). itemshop still does not show any purchaseable items, and starting a new battle still sends to a blank page. it goes to '?do=donewbattle', and clicking refresh on the browser sends you to the invalid user page.

[Revan]

my class avatar and atk, def, etc points are back after using headquarters.php (my class was reset to unknown). one thing that caught my eye though after updating my stats is my hp jumped to 155 from 59 what i previously had. i assume that would be the new revamped stats calculating?You are correct.

i deleted all old templates, and everything is at default (as of this posting). itemshop still does not show any purchaseable items, and starting a new battle still sends to a blank page. it goes to '?do=donewbattle', and clicking refresh on the browser sends you to the invalid user page.Did you try updating the Item Types?
Maybe something has gone wrong in there.

I will also re-test the battle stuff.
For now, I have uploaded a new version fixing some other problems.
EDIT: I know what the Battle problem is now!
There's a template missing.
Fix instructions are in your update mail.

[Cyricx]

What templates are missing?

I would love to get mine up and running again too :)

EDIT -

Looks like I found it

rpg_battle_userinbattle
$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
<!-- no cache headers -->
<meta http-equiv="Pragma" content="no-cache" />
<meta http-equiv="Expires" content="-1" />
<meta http-equiv="Cache-Control" content="no-cache" />
<!-- end no cache headers -->
<title>$vboptions[bbtitle] - Battle Error</title>
$headinclude
</head>
<body>
$header
$navbar
<form name="enterbattle" method="post" action="battlefight.php?do=enterbattle">
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: collapse" bordercolor="#111111" width="100%">
<tr>
<td width="77%" valign="top">
<table border="1" cellpadding="4" cellspacing="0" style="border-collapse: collapse" bordercolor="#000000" width="100%">
<tr>
<td width="100%">
<p align="center"><b>Battle System</b></td>
</tr>
<td width="100%" valign="top">
<table cellpadding="4" cellspacing="0" border="1" width="100%" bordercolor="#000000" style="border-collapse: collapse" height="311">
<tr>
<td rowspan="2" width="10%" height="284">&nbsp;</td>
<td height="19">&nbsp;</td>
<td rowspan="2" width="10%" height="284">&nbsp;</td>
</tr>
<td width="79%" align="center" valign="middle" height="228"> <br /><br /><br /><br /><br /><br />
$message<br /><br /><br /><br /><br /></td>
</tr>
</table>
</td>
</tr>
</table>
$footer
</body>
</html>


Incase anyone else is having the same prob.

[Chief Corn]

great job on the quick updates. creating a new battle works now, and everything in the battle from weapons to retreating works. i turned off $battledebug which was still set to 1 in the new battleupdate.php. it would be nice if after you created a battle it would take you to an awaiting for user to accept page so you know your battle processed...right now it just takes you back to the battle page with no confirmation.

ah yes. the itemshop does indeed work. i had to recheck the item types for generic. i did get this error though when trying to add a new item...

Warning: Variable passed to each() is not an array or object in /admincp/itemadmin.php on line 338


336: ));
337:
338: while ((list($key, $val) = each($name) AND list($key, $val2) = each($cat)
339: AND list($key, $val3) = each($cost) AND list($key, $val4) = each($desc)
340: AND list($key, $val5) = each($icon) AND list($key, $val6) = each($damage)
341: AND list($key, $val7) = each($order) AND list($key, $val8) = each($levelreq)))



a quick fix for the footer problems in rpg_battle_browse, and rpg_battle_stats templates just add a </table> above $footer to close it off.

one minor bug in rpgcp.php when you are in battle it says you are not.

every other option seems to work in my quick test. looks ready to go gold after another test. again great job on the hack.

[Revan]

Fixed the battledebug and the rpgcp files.
Now going to go test the adding items.

Ok fixed the item adding. That was actually a bigger mess than just that one error.
Gonna go reupload zip now.

it would be nice if after you created a battle it would take you to an awaiting for user to accept page so you know your battle processed...right now it just takes you back to the battle page with no confirmation.Well you would have seen this if you had the Redirects enabled in your ACP ;)

[Cyricx]

Anyway of finding out what we will need to do get everything updated from v3? like which files to upload or what queries to run? :)

I had to do alot of database fiddlin after the first one hehe, reset my classes and everything :(

[Revan]

Im not sure I understand what you mean... If you mean what queries were ran during the upgrade, all you have to do is open rpg_install and look under upgrade.