query problem

[miz]

$threads = $DB_site->query("
SELECT $votequery $previewfield
thread.threadid, thread.title AS threadtitle, lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
" . iif($vboptions['threadsubscribed'] AND $bbuserinfo['userid'], ", NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed") . "
" . iif(!$deljoin, ", NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason") . "
FROM " . TABLE_PREFIX . "thread AS thread
" . iif(!$deljoin, " LEFT JOIN " . TABLE_PREFIX . "deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')") . "
" . iif($vboptions['threadsubscribed'] AND $bbuserinfo['userid'], " LEFT JOIN " . TABLE_PREFIX . "subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = $bbuserinfo[userid])") . "
$previewjoin
WHERE thread.threadid IN (0$ids)
ORDER BY sticky DESC, $sqlsortfield $sqlsortorder
");

this is the orginal query from forumdisplay
now i tired to modify it abit

$threads = $DB_site->query("
SELECT user.userid AS user_uid , user.teamid AS userteamid, $votequery $previewfield
thread.threadid, thread.title AS threadtitle, lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
" . iif($vboptions['threadsubscribed'] AND $bbuserinfo['userid'], ", NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed") . "
" . iif(!$deljoin, ", NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason") . "
FROM " . TABLE_PREFIX . "thread AS thread
" . iif(!$deljoin, " LEFT JOIN " . TABLE_PREFIX . "deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')") . "
" . iif($vboptions['threadsubscribed'] AND $bbuserinfo['userid'], " LEFT JOIN " . TABLE_PREFIX . "subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = $bbuserinfo[userid])") . "
$previewjoin
LEFT JOIN " . TABLE_PREFIX . "user ON(user.userid = thread.postuserid)
WHERE thread.threadid IN (0$ids)
ORDER BY sticky DESC, $sqlsortfield $sqlsortorder
");

now i got this error :
Invalid SQL:
SELECT user.userid AS user_uid , user.teamid AS userteamid,
IF(votenum >= 1, votenum, 0) AS votenum,
IF(votenum >= 1 AND votenum > 0, votetotal / votenum, 0) AS voteavg,
post.pagetext AS preview,
thread.threadid, thread.title AS threadtitle, lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
, NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed
, NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason
FROM thread AS thread
LEFT JOIN deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')
LEFT JOIN subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = 1)
LEFT JOIN post AS post ON(post.postid = thread.firstpostid)
LEFT JOIN user ON(user.userid = thread.postuserid)
WHERE thread.threadid IN (0,2,1)
ORDER BY sticky DESC, lastpost DESC

mysql error: Column: 'lastpost' in field list is ambiguous

mysql error number: 1052

what am i doing worng ?

[Marco van Herwaarden]

mysql error: Column: 'lastpost' in field list is ambiguous
Means that the column 'lastpost' is found in to tables that are in the query. SQL don't know which instance of lastpost you mean.

You should use a syntax like:

SELECT a.ambiguousfield, b.ambiguousfield FROM tablea AS a, tableb AS b

Using the "table AS xx" you can create a short name to refer to a table, then prefix the column with that shortname and a dot.

PS This is general info as i didn't even tried to read your query ;)

[miz]

hmm with out adding the user part its working fine i also tried with FROM user AS user
but still same error

[Marco van Herwaarden]

Well both the thread and the user table got a column called 'lastpost'.

So you would have to refer to that column by either user.lastpost or thread.lastpost

[miz]

Well both the thread and the user table got a column called 'lastpost'.

So you would have to refer to that column by either user.lastpost or thread.lastpost
edited the query
and this is the error

Invalid SQL:
SELECT user.userid AS user_uid , user.teamid AS userteamid, user.lastpost AS userlastpost,
IF(votenum >= 1, votenum, 0) AS votenum,
IF(votenum >= 1 AND votenum > 0, votetotal / votenum, 0) AS voteavg,
post.pagetext AS preview,
thread.threadid, thread.title AS threadtitle, lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
, NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed
, NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason
FROM thread AS thread
LEFT JOIN deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')
LEFT JOIN subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = 1)
LEFT JOIN post AS post ON(post.postid = thread.firstpostid)
LEFT JOIN user AS user ON(user.userid = thread.postuserid)
WHERE thread.threadid IN (0,2,1)
ORDER BY sticky DESC, lastpost DESC

mysql error: Column: 'lastpost' in field list is ambiguous

same 1

[sabret00the]

SELECT user.userid AS user_uid , user.teamid AS userteamid, user.lastpost AS userlastpost,
IF(votenum >= 1, votenum, 0) AS votenum,
IF(votenum >= 1 AND votenum > 0, votetotal / votenum, 0) AS voteavg,
post.pagetext AS preview,
thread.threadid, thread.title AS threadtitle, thread.lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
, NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed
, NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason
FROM thread AS thread
LEFT JOIN deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')
LEFT JOIN subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = 1)
LEFT JOIN post AS post ON(post.postid = thread.firstpostid)
LEFT JOIN user AS user ON(user.userid = thread.postuserid)
WHERE thread.threadid IN (0,2,1)
ORDER BY sticky DESC, lastpost DESCshould fix it.

[Marco van Herwaarden]

edited the query
and this is the error

Invalid SQL:
SELECT user.userid AS user_uid , user.teamid AS userteamid, user.lastpost AS userlastpost,
IF(votenum >= 1, votenum, 0) AS votenum,
IF(votenum >= 1 AND votenum > 0, votetotal / votenum, 0) AS voteavg,
post.pagetext AS preview,
thread.threadid, thread.title AS threadtitle, lastpost, thread.forumid, pollid, open, replycount, postusername, postuserid, thread.iconid AS threadiconid,
lastposter, thread.dateline, IF(views<=replycount, replycount+1, views) AS views, notes, thread.visible, sticky, votetotal, thread.attach
, NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed
, NOT ISNULL(deletionlog.primaryid) AS isdeleted, deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason
FROM thread AS thread
LEFT JOIN deletionlog AS deletionlog ON(thread.threadid = deletionlog.primaryid AND type = 'thread')
LEFT JOIN subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = 1)
LEFT JOIN post AS post ON(post.postid = thread.firstpostid)
LEFT JOIN user AS user ON(user.userid = thread.postuserid)
WHERE thread.threadid IN (0,2,1)
ORDER BY sticky DESC, lastpost DESC

mysql error: Column: 'lastpost' in field list is ambiguous

same 1
You are using the column 'lastpost' more then once, so you should also change it more then once.