Can someone help me with this script? [Archive]

Takamine334

11-11-2004, 05:25 AM

<?

function dbconnect($mysql_host, $mysql_user, $mysql_pass,$mysql_db)
{
global $link ;
$link = mysql_connect($mysql_host, $mysql_user, $mysql_pass);
if (!$link) return false ;
$select = mysql_select_db($mysql_db);
if (!$select) return false;
return true ;
}

function get_date_time($timestamp = 0)
{
if ($timestamp)
return date("Y-m-d H:i:s", $timestamp);
else
return gmdate("Y-m-d H:i:s");
}

echo "<center>Users Import Script</center><hr>";
echo "This script will now import all users from Vbulletin forum into the database of the tracker ! ";
echo "If you see any error message, check your config.php files and put the right parameters inside.<hr>" ;

require_once("config.php");

if ( dbconnect($mysql_host, $mysql_user, $mysql_pass,$mysql_db) )
{
echo "<li>Connection to SQL database was a success</li>";

$res = mysql_query("SELECT username,password,email FROM ".$tableprefix."user") ;

if ($res) {
echo "<li>Connection to Vbulletin users list was a success !</li>";
while ($dat=mysql_fetch_array($res))
{
echo " Now adding: ".$dat['username']." into tracker users list";

$rz = mysql_query("INSERT INTO users (username, password, email, status, added) VALUES
('" . $dat['username'] . "',
'" . $dat['password'] . "',
'" . $dat['email'] . "',
'confirmed' ,'" . get_date_time() . "' )
");
$userid2 = mysql_insert_id();
echo "with id : ".$userid2." .";
if (!$rz) {
echo " An error occured : ";
if (mysql_errno() == 1062)
echo "Username already exists!";
}

}
}
else echo "<li>Cannot retrieve Vbulletin users list !</li>";
}
else echo "<li>Connection to SQL database failed</li>";

?>

What this script does is adds users from the USER table and puts them in a table called USERS. It's for a Bit Torrent tracker page.

The problem is it pulls the users in numerical order and adds them.
Example:

Table USER
INSERT INTO `user` VALUES (1,6,'',0,'Admin',
INSERT INTO `user` VALUES (2,2,'',0,'smssf',
INSERT INTO `user` VALUES (3,2,'',0,'tcort','
INSERT INTO `user` VALUES (4,2,'',0,'AtEaseWeb.com Kids Suck!',
INSERT INTO `user` VALUES (5,2,'',0,'thebigguy','
INSERT INTO `user` VALUES (1668,3,'',0,'nemo45',
INSERT INTO `user` VALUES (7,2,'',0,'luvdmb36',
INSERT INTO `user` VALUES (8,2,'',0,'Cole','
INSERT INTO `user` VALUES (9,2,'',0,'roach',

notice the user nemo45 with USERID of 1668

once the script is run to add the users, here's what I get:

Table USERS
INSERT INTO `users` VALUES (1,'Admin',
INSERT INTO `users` VALUES (2,'smssf',
INSERT INTO `users` VALUES (3,'tcort',
INSERT INTO `users` VALUES (4,'AtEaseWeb.com Kids Suck!',
INSERT INTO `users` VALUES (5,'thebigguy',
INSERT INTO `users` VALUES (6,'nemo45',
INSERT INTO `users` VALUES (7,'luvdmb36',
INSERT INTO `users` VALUES (8,'Cole',
INSERT INTO `users` VALUES (9,'roach',

Now notice nemo45

Since Nemo45 is the 6th user added, it gave it USERID 6 instead of USERID 1668.

This is a bug that will show wrong users on my Vbulletin website when they post music files. Can someone please edit this script so that it pulls the correct USERID in table USER and puts it in table USERS?

Logikos

11-11-2004, 05:49 AM

Your code is very sloppy and i suggest you read up on something called whitespace. Anyways, try using the addslashes() function inside the insert query.

Takamine334

11-11-2004, 01:35 PM

I didn't write this code and I don't know much about PHP...I wish I did. I guess I could read up on whitespaces, but I dont' think that will help much as I've never had any formal training on PHP coding.

Takamine334

11-11-2004, 11:28 PM

no one? Hmm, I thought this was a forum where people knew php...guess not. oh well.

AN-net

11-12-2004, 02:16 AM

you should use $DB_site variable for connecting with the vb database and if the table USERS is in the same database use $DB_site again;) You can also just copy the user table from database to another, rename it, add/drop/edit fields and your done:)

Takamine334

11-12-2004, 02:38 AM

you should use $DB_site variable for connecting with the vb database and if the table USERS is in the same database use $DB_site again;) You can also just copy the user table from database to another, rename it, add/drop/edit fields and your done:)

can you show me what you're talking about? I'll even pay you to write the code out correctly.

AN-net

11-12-2004, 03:02 AM

can you show me what you're talking about? I'll even pay you to write the code out correctly.
if your using phpmyadmin go to the user table, click the operations tab.

if the USERS table is in a separate database then vb, use "Copy table to (database.table):" fill in the name of the database the USERS table is in and the name of the new table and choose "structure and data only."'

if its in the same database then still use "Copy table to(database.table)" and select your vb's database and a new name for the copy table and select "structure and data only."

after that alter the new copied table until it looks like the USERS table;)

Logikos

11-12-2004, 03:26 AM

no one? Hmm, I thought this was a forum where people knew php...guess not. oh well.
Post like that kinda gets on my nerves. When posting help, give people some time. Not everyone is on at the same time as you are. In any case your query should look something like this.

$rz = $DB_site->query("
INSERT INTO " . TABLE_PREFIX . "users
(username, password, email, status, added)
VALUES
(
'" . addslashes($dat['username']) . "',
'" . addslashes($dat['password']) . "',
'" . addslashes($dat['email']) . "',
'confirmed',
'" . get_date_time() . "'
)
");

AN-net

11-12-2004, 03:56 AM

livewires query will only work if your using the same database as vb;)

Takamine334

11-12-2004, 04:00 AM

deleted post

Takamine334

11-12-2004, 04:04 AM

Post like that kinda gets on my nerves. When posting help, give people some time. Not everyone is on at the same time as you are. In any case your query should look something like this.

$rz = $DB_site->query("
INSERT INTO " . TABLE_PREFIX . "users
(username, password, email, status, added)
VALUES
(
'" . addslashes($dat['username']) . "',
'" . addslashes($dat['password']) . "',
'" . addslashes($dat['email']) . "',
'confirmed',
'" . get_date_time() . "'
)
");

Connection to SQL database was a success
Connection to Vbulletin users list was a success !
Now adding: Admin into tracker users list
Fatal error: Call to a member function on a non-object in /www/g/groove_salad/htdocs/BitTorrent/users_import_script/import2.php on line 41