percentage code is way off on large boards

[Boofo]

Can anyone plaese tell me what I am doing wrong in the following code that would cause larger boards with high post and thread counts to display these percentages really far off?

$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100, 2) . '%';

$statscache['topthreadspercent'] = vb_number_format(($topstarter['count'] / $getthreadviews['count']) * 100, 2) . '%';

On my smaller board they are very accurate. But on a larger board they seem to be showing up like the following:

15,300 Posts (15,300.00%)

I have tried different variations of this and they all turn out the same.

[assassingod]

Don't know if this'll work or not, but try dividing by a hundred (or 10 or 1000):

if($stats['activepercent'] > 100)
{
$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100 / 1000, 2 ) . '%';
}
else
{
$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100, 2) . '%';
}

[Boofo]

Thanks. Steve. I'll have someone with a large board test this and get back to you here with the results. ;)

[Boofo]

Steve, do you know how to take the last 2 zeros after the decimal point off on a whole percent? Like if it is 50.00%, how would you make it so it showed up as 50%, but ONLY on whole percentages? If it is like 50.05%, I want that to show up.

[AN-net]

you could round it;)

[Boofo]

But that wouldn't leave it if it was 50.05%, would it? ;)

[AN-net]

you could creat some kind if statement:)

[Boofo]

Any examples? ;)

[John]

Any examples? ;)


// If you've got a percentage value like this:
$percentage = 50.05;

// You can lob off the last two digits:
$lasttwo = substr($percentage, -2);

// And then see if that equals 00
if ($lasttwo == '00')
{
// intval returns an integer value
$percentage = intval($percentage);
}

// echo it out, you'll see that if $lasttwo == 00, it returns an int
echo $percentage;


There's probably an infinitely more simple method of doing it, lol - but it works. :)

[Boofo]

As long as it works, that's all that really counts. Thank you, sir. ;)

Would you have any ideas on the percentage problems for bigger boards? )

EDIT: How would I incorporate this with this code?

if($stats['activepercent'] > 100)
{
$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100 / 1000, 2 ) . '%';
}
else
{
$statscache['activepercent'] = vb_number_format(($numbermembers / $newuserid) * 100, 2) . '%';
}

[John]

What does the $newuserid variable represent?

[John]

Either way - to figure out percentages, you divide the small number by the big number, and multiple by 100.

Looking at your code, I think you're doing it the other way round. (Presuming that $numbermembers is the total number, and $newuserid is the fraction of that.) If $newuserid is the bigger number, ignore the variable switch I made in the vb_number_format function below.

I've also removed the if statement, as I can't see what the difference is between the code in each branch.



// this gives us a value in the $statscache['activepercent'] variable
$statscache['activepercent'] = vb_number_format(($newuserid / $numbermembers) * 100, 2 );

// You can lob off the last two digits:
$lasttwo = substr($statscache['activepercent'], -2);

// And then see if that equals 00
if ($lasttwo == '00')
{
// intval returns an integer value
$statscache['activepercent']= intval($statscache['activepercent']);
}

// if you want it in the variable, we can add the trailing % from before
$statscache['activepercent'] .= '%';

[John]

Also, instead of $newuserid, shouldn't it be $activemembers?

[Boofo]

Also, instead of $newuserid, shouldn't it be $activemembers?

When I used $activemembers like you suggested, it returned a 0. The $newuserid is the userid of the newest member, which would give you the highest number. ;)

I used this same code at one time and it seems that any boards that have over 1000 posts mess up with the percentage like this. It ends up showing like 15,300%. What would cause this to be happening? On my small site I don't have that problem. It works great for me.

[John]

What do you get with $numbermembers / $newuserid?

[Boofo]

I get this:

Total Registrations: 46, Active Registrations: (42 Members = 91.30%)

That shows up fine but the problem I am having is with the Top Poster Percentage and the Top Thread Starter Percentage on larger boards. On mine, it works like it is suppposed to. On larger boards with large post counts and thread counts it really messes up. Check out my Forumhome Stats hack thread on the last 2 or 3 pages and you will see what I mean. Or even the first post in this thread.