some help with code please !!

[burnist]

Okay, I need some help with this code block. It worked fine on vb2 and now i've upgraded to vb3 it dosn't and im not shure if i missed anything else that needs changed. It is my own version of an itemshop. It takes the users money from the profile field, the cost of the item from the item table then subtracts the cost. Next it pulls the users current item puts a space then the item's id so str replace can be used not to limit the number of items a user can have.

if ($action == "buy"){
$item = $_GET['item'];
$itemquery = $DB_site->query("SELECT * FROM items WHERE id = '".$item."' ");
$iteminfo = $DB_site->fetch_array($itemquery);
if (($bbuserinfo["field5"] >= $iteminfo["price"])) {
$newmoney = ($bbuserinfo["field5"]-$iteminfo["price"]);
$newitems = $bbuserinfo['items']." ".$item;
$DB_site->query("UPDATE userfield SET field5 = '".$newmoney."' WHERE userid = '".$bbuserinfo['userid']."';");
$DB_site->query("UPDATE user SET items = '".$newitems."' WHERE userid = '".$bbuserinfo['userid']."';");
$url = "shop.php?action=thanks";
eval(print_standard_redirect('itemshop_purchaseoka y'));
} else
eval(print_standard_error('itemshop_notenough'));
}

It dosn't produce any parse errors or sql errors either so that all I can tell you about it.

[Xenon]

replace $action with $_REQUEST['action']

[burnist]

it still didn't work.

Heres the whole file just incase there is something in it thats causing the problem and not just in that section

<?php


// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NO_REGISTER_GLOBALS', 1);
define('GET_EDIT_TEMPLATES', true);
define('THIS_SCRIPT', 'shop');

$globaltemplates = array(
'itemshop_chocoboitemhead',
'itemshop_canbuy',
'itemshop_chocoboitembit',
'itemshop_home',
'itemshop_purchaseokay',
'itemshop_notenough'
);

require("./global.php");
$show = $_GET['show'];


//////////////////display chocobo items///////////////
if (($show] == "chocobo") OR ($show == "")) {
$iteminfo = $DB_site->query("SELECT * FROM items WHERE itemtype = 'chocobo' ORDER BY 'id' ASC ");

eval("\$chocoboitemhead .= \"".fetch_template("itemshop_chocoboitemhead")."\";");
while ($item = $DB_site->fetch_array($iteminfo)){
if ($item["itemtype"] == "chocobo") {
eval("\$canbuy .= \"".fetch_template("itemshop_canbuy")."\";");
eval("\$itembits .= \"".fetch_template("itemshop_chocoboitembit")."\";");
}
}
eval("print_output(\"".fetch_template("itemshop_home")."\");");
}


//////////////////pay for items///////////////
if ($_REQUEST['action'] == "buy"){
$item = $_REQUEST['item'];
$itemquery = $DB_site->query("SELECT * FROM items WHERE id = '".$item."' ");
$iteminfo = $DB_site->fetch_array($itemquery);
if (($bbuserinfo["field5"] >= $iteminfo["price"])) {
$newmoney = ($bbuserinfo["field5"]-$iteminfo["price"]);
$newitems = $bbuserinfo['items']." ".$item;
$DB_site->query("UPDATE userfield SET field5 = '".$newmoney."' WHERE userid = '".$bbuserinfo['userid']."';");
$DB_site->query("UPDATE user SET items = '".$newitems."' WHERE userid = '".$bbuserinfo['userid']."';");
$url = "shop.php?action=thanks";
eval(print_standard_redirect('itemshop_purchaseoka y'));
} else
eval(print_standard_error('itemshop_notenough'));
}
?>

[assassingod]

Try using:

if($HTTP_POST_VARS['action']=="buy")

[burnist]

still getting nothing in either table

[Xenon]

are you sure your templates are correct an the action value is set up?

[burnist]

it worked fine on vb 2 and i didn't change anything in it except the template calls and as far as i know, those are working okay expect for the final redirect, which you wouldn't get because its in the action == buy section. Its probobly some simple variable that i've missed or something when changing it to vb3 but i can see what it is

[AN-net]

to make the if statement work right anyways it shouldnt be this:

} else
eval(print_standard_error('itemshop_notenough'));
}
?>

it should be:

}
else{
eval(print_standard_error('itemshop_notenough'));
}
?>

[mr e]

I don't know if this changes anything, but is this supposed to have the ']' in it?

if (($show] == "chocobo") OR ($show == "")) {


shouldn't it be

if (($show == "chocobo") OR ($show == "")) {

[burnist]

okay, at mr e that was an error that got in while moving the file into the php tag on here somehow. and at AN NET it had no effect but, if that was the case the file would have parse errored wouldn't it :S ?