mysql_fetch_array() error

[corsacrazy]

ok i am getting an error after having this query on my index

this is the error

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /forums/admin/db_mysql.php on line 154



this is the query



$newestsql=$DB_site->query("SELECT * FROM gal_Object where Freigabe='y' order by newat desc limit 1");
while($newObject=$DB_site->fetch_array($newestsql)) {
$getnewthumb=$DB_site->query_first("SELECT * FROM gal_Pictures where Object='$newObject[ID]' ORDER BY rand() DESC LIMIT 1");
// get a random pic
$tmpnew=explode(".",$getnewthumb[filename]);
$newthumbfilename="gt_".$tmpnew[0].".jpg";
eval( '$newestsql = "' . gettemplate( 'home_newest' ) . '";' );
}


this is line 154

$this->record = mysql_fetch_array($this->query_id);

[noppid]

Try...

LIMIT 0,1

That's the only thing that jumps out to me.

[NTLDR]

Your only fetching one row, hence you should be using query_first and remove the while loop.

[corsacrazy]

ok so im now trying

$newestsql=$DB_site->query_first("SELECT * FROM gal_Object where Freigabe='y' order by newat desc limit 0,1");
{
$getnewthumb=$DB_site->query_first("SELECT * FROM gal_Pictures where Object='$newObject[ID]' ORDER BY rand() DESC LIMIT 1");
// get a random pic
$tmpnew=explode(".",$getnewthumb[filename]);
$newthumbfilename="gt_".$tmpnew[0].".jpg";
eval( '$newestsql = "' . gettemplate( 'home_newest' ) . '";' );
}

but its not werking atall

if i remove the { i get a Parse error

[NTLDR]

Neither of the {} are needed as far as I can see with that code segment.

[noppid]

I see Limits which are not needed on query_first.

I see an array element with no single quotes around it.

I see order by rand, but rand() will not equate to a field name, just a number.

[filburt1]

Also, a side note: never, ever query in a loop :)

[corsacrazy]

Today at 03:08 PM noppid said this in Post #6 (https://vborg.vbsupport.ru/showthread.php?postid=419698#post419698)


I see an array element with no single quotes around it.



can u show me this please ?

[NTLDR]

Its not stricly needed, but heres what he means:

$getnewthumb[filename];
$getnewthumb['filename'];

The second being the prefered way to do it.

[corsacrazy]

:( @ Call to undefined function: mysql_fetch_array()

[NTLDR]

As I've already said, theres no need to use the while loop and $DB_site->fetch_array as your only getting one row from the DB.

[corsacrazy]

Today at 03:49 PM NTLDR said this in Post #11 (https://vborg.vbsupport.ru/showthread.php?postid=419713#post419713)
As I've already said, theres no need to use the while loop and $DB_site->fetch_array as your only getting one row from the DB.



if i take that out the whole thing just doesnt werk and i get a broken red X instead of the image

atleaset wiv the erro the script is working

[Link14716]

Here's how it should look...
$newestsql=$DB_site->query_first("SELECT * FROM gal_Object where Freigabe='y' order by newat desc");
$getnewthumb=$DB_site->query_first("SELECT * FROM gal_Pictures where Object='$newestsql[ID]' ORDER BY rand(NOW()) DESC");
// get a random pic
$tmpnew=explode(".",$getnewthumb['filename']);
$newthumbfilename="gt_".$tmpnew['0'].".jpg";
eval( '$newestsql = "' . gettemplate( 'home_newest' ) . '";' );

[corsacrazy]

U R A LEGEND took me a few template changes but i finally got it sorted CHEERS TO ALL THE VB people AND ESPECIALLY MR LINK ! im gald i got my self that vb license now ;)