Do you see any errors in this code?

[Prince]

** the reason I ask is because at 75% it is supposed to display a red image, but it conitnues to display yellow past 75.


$inboxpms=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND folderid=0 $ignoreusers");
if ($inboxpms < 1) {
$pmpercent = "1"; // stop divisions by zero
} else {
$pmpercent = round(($inboxpms[messages] / $pmquota) * 100,2);
}
if ($pmpercent>50) {
$barimg="{imagesfolder}/yellow.gif";
} elseif ($pmpercent>75) {
$barimg="{imagesfolder}/red.gif";
} else {
$barimg="{imagesfolder}/green.gif";
}

[Xenon]

yes i see a fault in your code so it is correct:
$inboxpms=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND folderid=0 $ignoreusers");
if ($inboxpms < 1) {
$pmpercent = "1"; // stop divisions by zero
} else {
$pmpercent = round(($inboxpms[messages] / $pmquota) * 100,2);
}
if ($pmpercent>50 && $pmpercent<=75) {
$barimg="https://vborg.vbsupport.ru/vbimages/yellow.gif";
} elseif ($pmpercent>75) {
$barimg="https://vborg.vbsupport.ru/vbimages/red.gif";
} else {
$barimg="https://vborg.vbsupport.ru/vbimages/green.gif";
}

remember when something is higher than 75 ist also higher than 50 ;)

[Prince]

I see your logic there, but that screwed up the PM %. :confused:

[Xenon]

????

can't see a fault, can you explain a bit more?

[Prince]

The code tells how full the PM box is based on the max number of PM's allowed.
So, right now I have it set to a max of 75 PM's, and I have 60 PMs total in my PM box, so the % should read 86% full, but when I changed the code it made that % inaccurate, it said something like 40% full.

[Xenon]

perhaps you have 60 pms total, but just 30 pms in your inbox?
you just call pms in folderid=0 (inbox-folder) but no sent messages would be inside

[Prince]

this code is looking at all folders:


$inboxpms=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] $ignoreusers");
if ($inboxpms < 1) {
$pmpercent = "1"; // stop divisions by zero
} else {
$pmpercent = round(($inboxpms[messages] / $pmquota) * 100,2);
}
if ($pmpercent>50) {
$barimg="{imagesfolder}/yellow.gif";
} elseif ($pmpercent>75) {
$barimg="{imagesfolder}/red.gif";
} else {
$barimg="{imagesfolder}/green.gif";
}

[Xenon]

i'd really change the code to that:
$inboxpms=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] $ignoreusers");
$pmpercent=round(($inboxpms[messages] / $pmquota) * 100,2);

if ($pmpercent>50 && $pmpercent<=76) {
$barimg="https://vborg.vbsupport.ru/vbimages/yellow.gif";
} else if ($pmpercent>75) {
$barimg="https://vborg.vbsupport.ru/vbimages/red.gif";
} else {
$barimg="https://vborg.vbsupport.ru/vbimages/green.gif";
}

no division by zero is possible, because zero is devided by something else, not the other way round...

[Prince]

Perfect!

thanks Xenon :)

[Xenon]

np :)

[Neo]

Good Job.