Help pls tracking down template problem post 4.2.0PL3 -> 4.2.1

[stardotstar]

Hi all,

4.2.0 PL3 -> 4.2.1 went smoothly, no errors reported during or after and templates that were incompatible were not active ones on the site.

I thought everything had gone swimmingly until one of my admins reported that they couldn't move a thread anymore. The destination forum dropdown menu was not populated.

I confirmed and then checked against the vB4 default template which works fine.

My work around for now is to get the staff to use the vB4 default template.

I did some digging and found a thread on vB with the usual first steps - try default template (tick) and failing that disable hooks - and the thread died there:
http://www.vbulletin.com/forum/forum/vbulletin-4/vbulletin-4-questions-problems-and-troubleshooting/3968573-destination-forum-problem-after-4-2-1-update
This is the screen grab that shows how it looks for me too:

http://img689.imageshack.us/img689/6628/capturevl.jpg

So I found that the inlinemod.php file has some differences that point to the symptom:

Old:

Line 2125: $moveforumbits = construct_move_forums_options();

Becomes:

$moveoptions = construct_move_forums_options();

$option_templater = vB_Template::create('option');
$option_templater->register('options', $moveoptions);
$moveforumbits = $option_templater->render();



Old:


Line 2599: $moveforumbits = construct_move_forums_options();



Becomes:



$moveoptions = construct_move_forums_options();

$option_templater = vB_Template::create('option');
$option_templater->register('options', $moveoptions);
$moveforumbits = $option_templater->render();



and



Line 4588: $moveforumbits = construct_move_forums_options();


becomes:



$moveoptions = construct_move_forums_options();

$option_templater = vB_Template::create('option');
$option_templater->register('options', $moveoptions);
$moveforumbits = $option_templater->render();

I can confirm that my template works if I replace the new inlinemod.php with the 4.2.0 PL3 one so that is one possible short term fix for me alongside the default template use.

Can someone suggest how I would go about tackling this in the template code? Clearly some way of building the forum list is broken and I also wonder what other things are likely to be effected in this kind of way.

Best regards
Will

--------------- Added 1368433672 at 1368433672 ---------------

Arghh, I started editing the templates looking in "threadadmin_moveposts" and noted that moveforumbits was called - I did some testing and I think that by saving and resaving the style - even though I didn't actually change antyhing it is fixed. Very frustrating because I can't tell what I did. On my other site its working now too so maybe it was a cache??