Board Optimization - United-Forum CSS Sprites - ludicrous speed - NOW! [Archive]

View Full Version : Board Optimization - United-Forum CSS Sprites - ludicrous speed - NOW!

Pages : [1] 2 3

Osbes

07-11-2011, 10:00 PM

tl;dr Makes your forum faster.

Want an easy one-click installation for this addon? . Vote for this jira-entry (http://tracker.vbulletin.com/browse/VBIV-13825)

Add on currently is in beta stage

When visiting a website, speed is a very important factor not only for users but crawlers as well. Long loading times are a nuisance since your time is basically wasted during the waiting period. Hence, we (http://www.united-forum.de) are trying everything we can in order to speed up our site. One great way to improve loading times is by the use of css sprites. Unfortunately these are not implemented by vBulletin.

We therefore decided to develop our own css-sprite add on for vBulletin boards and want to share this code with the worldwide vBulletin community.

Live demo The add on is permanently running in our vBulletin board ( > 2.000.000 posts), take a look:
http://www.united-forum.de

The add on will be supported via this thread. If you have any questions, issues, improvements or feedback regarding this add on, please feel free to post a comment or write us a pm at any time. We are happy to discuss :)

vBulletin performance using css spritesOur tests are based on version 0.7.0. We used the analytic tools firebug network utility and the googlelabs.com page speed site (http://pagespeed.googlelabs.com/)

on the client side the following parameter were used:
download speed: 5.7 MBit/s
ping: 31ms

https://vborg.vbsupport.ru/external/2011/10/15.png

https://vborg.vbsupport.ru/external/2011/10/16.png
css sprites - what are they? The intention behind css sprites is the bundling of many small graphics into one large graphic in order to decrease the number of required http requests. This shortens the loading times of the given website. In addition, the the accumulated size of all small graphics is higher than the size of the sprite due to reasons of compression.
You can find further information in a great article by Chris Coyier (http://css-tricks.com/158-css-sprites/).
What is the gain in using css sprites?Aside from the technical implementation, the question on how much one actually does gain by using css sprites is of the most interest. Obviously they decrease loading times - but how important are small loading times and what is the impact on vBulletin overall loading times?

A short time ago, Jasper Aguila pointed out that speed is one crucial stickiness factor in his blog on vBulletin.com (https://www.vbulletin.com/forum/entry.php/2484-Stickiness-Factors-in-Forums).

The internet has unfortunately contributed to the exponential decrease in attention span for many individuals. That's why this decade is seeing a trend in emerging technologies emphasizing the importance of speed request. It's crucial for your content to be promptly distributed in a timely manner, else bounce rate will increase - making you lose returning visitors. It's also important to note that slow sites may be penalized by search engines.

With better browsers, more powerful processors, and improved technologies constantly releasing each year, it's becoming quite difficult to provide excuses for slow loading pages. Therefore, try optimizing your server for speed. Read up and learn optimization techniques at vBulletin.com's Server Configuration forum.

In addition, the google ranking is influenced by the site speed as well.

Google Webmaster Central Blog (http://googlewebmastercentral.blogspot.com/2010/04/using-site-speed-in-web-search-ranking.html)
You may have heard that here at Google we're obsessed with speed, in our products and on the web. As part of that effort, today we're including a new signal in our search ranking algorithms: site speed. Site speed reflects how quickly a website responds to web requests.

vBseo Webmaster Mert G?k?eimam (http://www.vbseo.com/f4/has-anyone-utilized-css-image-sprites-41900/#post261635)
CSS sprites is a huge bonus for big boards , any big board owner definately should use it.Last but not least, not only the user's loading time is reduced, but also does the server load decrease as the server will have to handle a lot less of http requests. This clears available connections and cpu time.
Add on features In the current released beta version 0.7.2, sprites are available for FORUMHOME and FORUMDISPLAY. Coming up next SHOWTHREAD.

Sprites are created style based for all forum styles and saved in a folder which you can set via the imgdir_sprite stylevar. You have one additional button in the ACP (CSS-Sprites -> Refresh) which automatically creates all sprites, the according css definitions and includes those css definitions in the vBulletin css rollup files.
Installation

First of all, if you didnt want to change the templates manually, install the Template Modification System (https://vborg.vbsupport.ru/showthread.php?t=152931) (TMS). Now proceed with the installation:
upload the contents of the upload folder into your forum home directory.
import the add on in the ACP
upon installation a new stylevar imgdir_sprite will be created. Update this stylevar based on your file structure - default value is the vbulletin sprite directory. Make sure the folder is writable, else the sprites can't be saved!
create the sprites via the ACP at CSS-Sprite using the Refresh option.
If you have installed TMS, you are done now. This was an easy gained speed up, not? If you didnt installed TMS and didnt want to do it, proceed with the next point:
in order to use the sprites, you then will have to edit some templates. The diffs (xou will find it in the do_not_upload folder show which parts you have to delete '<' and which parts to add '>' In addition, on top find the lines in which you will find the respective code.[/b]

Osbes

07-12-2011, 09:51 PM

Frequently Asked Questions

Question
My Icon (mostly the paperclip) looks like http://dl.dropbox.com/u/246391/Robin_result.png (it is stretched and vertical lines are added), what can i do?
Answer
I assume you use a GD Libary older than 2.0.36.

GD had a problem handling grayscale images with alpha channel correctly, which was fixed with GD 2.0.36 in the year 2007 (https://bitbucket.org/pierrejoye/gd-libgd/src/733361a31aab/NEWS).

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".
I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed by Debian in the year 2009 (http://security-tracker.debian.org/tracker/CVE-2009-3546).

For the embed Version of GD within PHP, this issue is fixed since PHP 5.3.0.

Question
Does this addon works with CDNs?
Answer
Yes. This addon has one side support for CDNs. One side meaning we can't write the sprite on your external server (and never can). But it doesn't has any problems reading the icons out of your CDN and writing it to a local filepath where your CDN sync function can distribute it to your CDN.

Question
How to add custom icons into the sprite?
Answer
The addon has the option to include custom icons. Be warned it's meant for advanced users (and style designers). An explanation can be found here:
https://vborg.vbsupport.ru/showp...&postcount=177 (https://vborg.vbsupport.ru/showpost.php?p=2228826&postcount=177)

Question
I am using an Add-On for changing the forum icons (like www.vbulletin.org/forum/showthread.php?t=244351). When using CSS Sprites, my forum icons are reverted to the original state.
Answer
The feature to use forums custom icons is builtin in vBulletin 4. You can add to every forum an own imageprefix, so it will use forums custom icons. If you use the vBulletin imageprefix for your your forums, these icons will instantly added to the sprite.

An explanaition to this can be found in the vBulletin Manual (under Prefix for Forum Status Images):
https://www.vbulletin.com/docs/html/main/forum_add_forum

Question
Google pagespeed still tells me that i should combine icons into sprites.
Answer
Despite covering hundreds of icons our addon can't cover everything. Especially gradients can't be automatically replaced since they differ a lot in custom styles. But, we do offer a hook so you can add your own icons into the sprite, based on the needs your board has.
A longer answer why we can't include gradients and all custom icons can be found here
https://vborg.vbsupport.ru/showp...2&postcount=49 (https://vborg.vbsupport.ru/showpost.php?p=2223052&postcount=49)

To add the missing Icons yourself, please read: How to add custom icons into the sprite?
Question
Double background issue/ search icon dissapears Answer
Some custom styles do include their own background, for example behind the search icon.
Since sprites replace the icons with the sprite background this gets in the way.
Solution: Modify your search icon to include both background and icon and refresh the sprite.

Osbes

07-12-2011, 09:51 PM

Version 0.7.2 (06.08.2011)
now supporting folders for forum prefixes
sprite generation splittet to avoid timeouts on sites which a huge number of styles
checks if the gd version is 2.0.36 or higher (experimental)
Version 0.7.1 (01.08.2011)
added support for search.php pages including What's New
some minor bugfixesVersion 0.7.0 (01.08.2011)
full support for ltr/rtl
forum sidebar support added
FORUMDISPLAY support addedVersion 0.6.3 (23.07.2011)
Added the possibility to use TMS for automatic template modification.
Icons can now be merged into different sprites and css rollups instead of one big sprite.
Addon is now compatible with vBulletin 4.1.xVersion 0.6.2 (17.07.2011)
Added support for http filepaths and therefore one-way support for CDNs
Templates are now using the cache system
clientscript/sprite_vbulletin_collapse.js removed.Version 0.6.1 (17.07.2011)
bug-fix: using alternative paths for post icons could cause that these are not includes in the sprite.Version 0.6.0 (17.07.2011)
possibility to add custom icons into the sprite via plugin-hook sprite_add_icon
added log output during sprite generation in the acp
option to deactivate using post icons in your sprite (default should be on)Version 0.5.1 (12.07.2011)
Added support php versions < 5.3.0. Addon now just requires php5 due to TypeHinting (http://www.php.net/manual/en/language.oop5.typehinting.php)Version 0.5.0 (12.07.2011)
Add-On release
FORUMHOME css-sprite support

Jeff Ledger

07-12-2011, 10:20 PM

Let's say

The goal is good but it's hard for other forums using different styles than yours use it.

Sprite require the css must be 100% exactly, and if someone use custom icons they will need to make a different sprite also the css.

It takes even more time than the usually way to reedit sprite and css.

I prefer doing sprite css for every single style, means custom css and custom sprite png. This is more effective and useful than a product like that.

Btw nice mod. Keep up the good work

Jeff

Mooff

07-12-2011, 10:31 PM

The goal of our Add on is to solve that problem. The Add on creates a different sprite for each style based on the used icons, their dimension (hight width) and vbulletin stylevars.

We are using 9 different styles (not counting our mobile styles) and it works without problems in all of them. Without additional refinement.

The intention is to create an addon where the board admin doesn't have to know anything about html or css and still can use sprites.

Hornstar

07-13-2011, 09:40 AM

Jeff Ledger

07-13-2011, 10:13 AM

final kaoss

07-14-2011, 02:39 AM

Yeah it sounds like it has some potential

Barbaro

07-14-2011, 03:41 PM

guau 4.1.4?

gracias

Mooff

07-14-2011, 04:51 PM

I guess you want to know whether it does work with 4.1.4? ;)

We can't test it for ourselfs, since we are going to jump 4.1.4 and update with the release of 4.1.5.
BUT on the german ( www.vbulletin-germany.org ) modding site we received feedback that this addon does work well with 4.1.4

Regards Mooff

Barbaro

07-14-2011, 07:06 PM

Exactly, it hurts, I will be pending for 4.1.5.

Good mod, thanks

regards

cherylferraro

07-15-2011, 04:08 AM

Not working for me but I think this will be fantastic when it's fully functional. Thank you for working on it :)

Mooff

07-15-2011, 07:00 AM

While posing a bug report please include
- vBulletin Version
- full bug description (what, where, whether you did the template edits ...)
(if possible link to your site where the addon is active)

so we can fix whatever the problem is. :)

cherylferraro

07-15-2011, 04:23 PM

VB version 4.1.4 patch 1

Bug description: Uploaded the files and did the template edits on a test style. Set 777 permissions on sprite folder and refreshed CSS-Sprites via admincp. No sprites were generated, or if they were they were not added to the images/sprites folder. I can't find the sprites. I guess it goes without saying that the status icons were not displayed on forumhome.

I tried uninstalling and then reinstalling. It still didn't work.

Thanks again for your work on this mod. It will be a great addition to vb.

Osbes

07-15-2011, 04:53 PM

Are you using the PHP GD Libary? This addon currently doens't support ImageMagick.
Which Version of the PHP GD Libary is installed?

If you are currently not using the PHP GD Libary or it is older than GD2, please install/update GD and try it agein.

If you are using GD2, please send me via PN the output of
<?php
phpinfo();
and the output after refreshing the css-sprites via admincp.

If possible, please check your php error-logs if if some errors related to the sprite.php occurred.

Big Big Thanks for the nice feedback :)

cherylferraro

07-16-2011, 04:56 PM

Thank you for your prompt response. Based upon the info you provided I was able to get the sprite generation issue sorted out. The sprite has been generated and now resides in the images/sprites directory.

On to the next issue. I made the template edits in a test style but the status icons do not display on forumhome. The test style is user selectable (testing sprites) if you would like to take a look to see if you can determine what I've done to break your very useful mod :)

The link is: http://www.browncafe.com/forum/

I just took a look at the sprite-css templates and they are all empty. Is that working as intended or was I supposed to put some css in there myself?

Osbes

07-16-2011, 05:47 PM

Hi, thanks for your feedback, i just wanted you to ask, whether the sprite-main.css Template is empty or not, since http://www.browncafe.com/forum/clientscript/vbulletin_css/style00016l/sprite-main.css was empty.

The templates should be filled automatically after the sprite is generated. I suggest, that the problem is somehow related to your first issue.

What was your solution for this?

Can you insert some debug messages to see, whether the templates are filled or not?

if(empty($template))
{
$vB_Database->query_write('
INSERT INTO
`' . TABLE_PREFIX . 'template`
SET
title = "sprite-main.css",
styleid = ' . $vB_Database->sql_prepare($style['styleid']) . ',
template = ' . $vB_Database->sql_prepare(compile_template($cssrule)) . ',
template_un = ' . $vB_Database->sql_prepare($cssrule) . ',
dateline = ' . TIMENOW . ',
username = "unitedforum",
version = ' . $vB_Database->sql_prepare('0.5.0') . ',
product = "sprite",
mergestatus = "none"
');

var_dump("INSERT");
}
else
{
$vB_Database->query_write('
UPDATE
`' . TABLE_PREFIX . 'template`
SET
version = ' . $vB_Database->sql_prepare('0.5.0') . ',
template = ' . $vB_Database->sql_prepare(compile_template($cssrule)) . ',
template_un = ' . $vB_Database->sql_prepare($cssrule) . ',
dateline = ' . TIMENOW . '
WHERE
templateid = ' . $vB_Database->sql_prepare($template['templateid']) . '
');

var_dump("UPDATE");
}

I suggest, that the script dies after

imagepng($sprite, DIR . '/' . $sprite_filepath);
imagedestroy($sprite);

Which is just before the SQL-Statements. Thats why i think, that it is related to your first issue.

cherylferraro

07-16-2011, 08:05 PM

The sprite was generated after I enabled GD to be the image processor.

I am unsure where to put the text for the debug messages you provided so I made a wild guess and pasted that text onto the end of sprite.php. Is that where it is supposed to go?

After refreshing CSS-Sprites via admin panel the sprite-main.css and all of the other css sprite templates are still empty.

Osbes

07-16-2011, 11:14 PM

The debug messages are for us to identify your problem. Please send them to me via private message.

I am currently putting the final touch on the next version. Aside performance improvements it will include addtional log output in the acp visible each time the sprites are refreshed. These messages should be helpful to identify and solve problems like yours.

Once you have the new version installed please copy everything which shows up and also send it to me via private message.

Mooff

07-16-2011, 11:25 PM

0.6.0 is now live! (changelog will be translated tomorrow, it's 2:30am in germany right now ;) )

Since most of you are still hesitant about the addon i want to give you some numbers:

Without the addon we had ~55* http requests on FORUMHOME. Now we are left with 17. That's a difference of 38 http requests per click.
Let's say you have a small board with 500 pageimpressions on FORUMHOME each day. Makes 19000 http requests you save a day. 570000 requests a month!
Now imagine a big board with 50000 pageimpressions. 57 million saved http requests each month.

Believe me,
your users want you to use css sprites.
your server wants you to use them.
and google wants you to use them.

Sidenote: With the new version we included the member profile popupmenu. Which means not only FORUMHOME is affected now but you save up to 7 http requests on almost every page of your forum - yikes.

*number does vary with number of threads using a threadicon. Threads in our board usually do not have one, so on other boards this number might easily be a lot higher.

Osbes

07-17-2011, 09:25 PM

Version 0.6.2 released.

Added support for http filepaths and therefore one-way support for CDNs
Templates are now using the cache system

cherylferraro, your problem should be solved in 0.6.2.

final kaoss

07-17-2011, 09:38 PM

Now if you can automate the template changes, alot more people would be interested. Thanks.

Osbes

07-17-2011, 09:45 PM

Andreas has added the corresponding XML-File for the Template Modification System.
http://www.vbulletin-germany.org/showthread.php?8960-Optimiere-dein-vBulletin-Forum-durch-CSS-Sprites&p=75100#post75100

Beside the use of the TMS, i didnt know another way, cause you actually need to replace these lines.

final kaoss

07-17-2011, 10:30 PM

ok. Do you mind putting up the template changes in codeboxes again? This is nearly unreadable..

Template: FORUMHOME
72d72
< <h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/users_online.png" alt="{vb:rawphrase currently_active_users}" />{vb:rawphrase currently_active_users}</h3>
---
> <h3 class="blocksubhead">{vb:rawphrase currently_active_users}</h3>
90c90
< <h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/event.png" alt="{vb:rawphrase todays_events}" /><vb:if condition="$show['todaysevents']">{vb:rawphrase todays_events}<vb:else />{vb:rawphrase upcoming_events_for_the_next_x_days, {vb:raw vboptions.showevents}}</vb:if></h3>
---
> <h3 class="blocksubhead"><vb:if condition="$show['todaysevents']">{vb:rawphrase todays_events}<vb:else />{vb:rawphrase upcoming_events_for_the_next_x_days, {vb:raw vboptions.showevents}}</vb:if></h3>
100c100
< <h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/birthday.png" alt="{vb:rawphrase todays_birthdays}" />{vb:rawphrase todays_birthdays}</h3>
---
> <h3 class="blocksubhead">{vb:rawphrase todays_birthdays}</h3>
109c109
< <h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/forum_stats.png" alt="{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}" />{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}</h3>
---
> <h3 class="blocksubhead">{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}</h3>
128c128
< <h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/legend.png" alt="{vb:rawphrase icon_legend}" />{vb:rawphrase icon_legend}</h3>
---
> <h3 class="blocksubhead">{vb:rawphrase icon_legend}</h3>
131,134c131,134
< <dt><img src="{vb:stylevar imgdir_statusicon}/forum_new-16.png" alt="{vb:rawphrase new_posts_forum}" /></dt><dd>{vb:rawphrase new_posts_forum}</dd>
< <dt><img src="{vb:stylevar imgdir_statusicon}/forum_old-16.png" alt="{vb:rawphrase no_new_posts_forum}" /></dt><dd>{vb:rawphrase no_new_posts_forum}</dd>
< <dt><img src="{vb:stylevar imgdir_statusicon}/category-16.png" alt="{vb:rawphrase category_forum}" /></dt><dd>{vb:rawphrase category_forum}</dd>
< <dt><img src="{vb:stylevar imgdir_statusicon}/forum_link-16.png" alt="{vb:rawphrase link_forum}" /></dt><dd>{vb:rawphrase link_forum}</dd>
---
> <dt></dt><dd>{vb:rawphrase new_posts_forum}</dd>
> <dt></dt><dd>{vb:rawphrase no_new_posts_forum}</dd>
> <dt></dt><dd>{vb:rawphrase category_forum}</dd>
> <dt></dt><dd>{vb:rawphrase link_forum}</dd>

Template: forumhome_forumbit_level2_nopost
3c3
< <img src="{vb:stylevar imgdir_statusicon}/category_forum_{vb:raw forum.statusicon}.png" class="forumicon" id="forum_statusicon_{vb:raw forum.forumid}" alt="" />
---
> 

Template: forumhome_forumbit_level2_post
4c4
< <img src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}forum_{vb:raw forum.statusicon}-48.png" class="forumicon" id="forum_statusicon_{vb:raw forum.forumid}" alt="" />
---
> 

Template: forumhome_lastpostby
3c3,11
< <vb:if condition="$show['icon']"><img src="{vb:raw icon.iconpath}" alt="{vb:raw icon.title}" border="0" /></vb:if>
---
> <vb:if condition="$show['icon']">
> <vb:if condition="$lastpostinfo['lasticonid'] == -1">
> 
> <vb:elseif condition="$lastpostinfo['lasticonid'] == 0 && !empty($vbulletin->options['showdeficon'])" />
> 
> <vb:else />
> 
> </vb:if>
> </vb:if>
6c14
< <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
> <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"></a>
18c26
< <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
> <a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"></a>

Template: forumhome_subforumbit_nopost
2c2
< <img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/subforum_{vb:raw forum.statusicon}.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />
---
> 

Template: forumhome_subforumbit_post
2c2
< <img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}subforum_{vb:raw forum.statusicon}-48.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />
---
> 

Template: memberaction_dropdown
5c5
< <img src="{vb:stylevar imgdir_siteicons}/profile.png" alt="" />
---
> 
12c12
< <img src="{vb:stylevar imgdir_siteicons}/forum.png" alt="" />
---
> 
20c20
< <img src="{vb:stylevar imgdir_siteicons}/message.png" alt="" />
---
> 
29c29
< <img src="{vb:stylevar imgdir_siteicons}/blog.png" alt="" />
---
> 
38c38
< <img src="{vb:stylevar imgdir_siteicons}/homepage.png" alt="" />
---
> 
47c47
< <img src="{vb:stylevar imgdir_siteicons}/article.png" alt="" />
---
> 
56c56
< <img src="{vb:stylevar imgdir_siteicons}/add.png" alt="" />
---
> 
65c65
< <img src="{vb:stylevar imgdir_siteicons}/email.png" alt="" />
---
> 

Also, if you intend on keeping the diff file... Please tell people they need to use something like tortoise svn to open the thing. I just so happened to have it still installed and windows basically said "use this"

Mooff

07-17-2011, 10:42 PM

It's meant to be read like this:

Template: forumhome_subforumbit_post
2c2
< <img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}subforum_{vb:raw forum.statusicon}-48.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />
---
> 

translates into:

In template: forumhome_subforumbit_post
In Line 2 - search for

<img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}subforum_{vb:raw forum.statusicon}-48.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />

and replace with



Hope that helps.

edit: You do not need any special program to open the diff file. Any editor is enough. It's plain text. Opening it via tortoise svn just adds color coding.

final kaoss

07-17-2011, 11:03 PM

oh, I know what it translates into, infact I removed those extra >'s. Alot easier to copy now.

Template: FORUMHOME
72d72
<h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/users_online.png" alt="{vb:rawphrase currently_active_users}" />{vb:rawphrase currently_active_users}</h3>
---
<h3 class="blocksubhead">{vb:rawphrase currently_active_users}</h3>
90c90
<h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/event.png" alt="{vb:rawphrase todays_events}" /><vb:if condition="$show['todaysevents']">{vb:rawphrase todays_events}<vb:else />{vb:rawphrase upcoming_events_for_the_next_x_days, {vb:raw vboptions.showevents}}</vb:if></h3>
---
<h3 class="blocksubhead"><vb:if condition="$show['todaysevents']">{vb:rawphrase todays_events}<vb:else />{vb:rawphrase upcoming_events_for_the_next_x_days, {vb:raw vboptions.showevents}}</vb:if></h3>
100c100
<h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/birthday.png" alt="{vb:rawphrase todays_birthdays}" />{vb:rawphrase todays_birthdays}</h3>
---
<h3 class="blocksubhead">{vb:rawphrase todays_birthdays}</h3>
109c109
<h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/forum_stats.png" alt="{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}" />{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}</h3>
---
<h3 class="blocksubhead">{vb:rawphrase x_statistics, {vb:raw vboptions.bbtitle}}</h3>
128c128
<h3 class="blocksubhead"><img src="{vb:stylevar imgdir_misc}/legend.png" alt="{vb:rawphrase icon_legend}" />{vb:rawphrase icon_legend}</h3>
---
<h3 class="blocksubhead">{vb:rawphrase icon_legend}</h3>
131,134c131,134
<dt><img src="{vb:stylevar imgdir_statusicon}/forum_new-16.png" alt="{vb:rawphrase new_posts_forum}" /></dt><dd>{vb:rawphrase new_posts_forum}</dd>
<dt><img src="{vb:stylevar imgdir_statusicon}/forum_old-16.png" alt="{vb:rawphrase no_new_posts_forum}" /></dt><dd>{vb:rawphrase no_new_posts_forum}</dd>
<dt><img src="{vb:stylevar imgdir_statusicon}/category-16.png" alt="{vb:rawphrase category_forum}" /></dt><dd>{vb:rawphrase category_forum}</dd>
<dt><img src="{vb:stylevar imgdir_statusicon}/forum_link-16.png" alt="{vb:rawphrase link_forum}" /></dt><dd>{vb:rawphrase link_forum}</dd>
---
<dt></dt><dd>{vb:rawphrase new_posts_forum}</dd>
<dt></dt><dd>{vb:rawphrase no_new_posts_forum}</dd>
<dt></dt><dd>{vb:rawphrase category_forum}</dd>
<dt></dt><dd>{vb:rawphrase link_forum}</dd>

Template: forumhome_forumbit_level2_nopost
3c3
<img src="{vb:stylevar imgdir_statusicon}/category_forum_{vb:raw forum.statusicon}.png" class="forumicon" id="forum_statusicon_{vb:raw forum.forumid}" alt="" />
---


Template: forumhome_forumbit_level2_post
4c4
<img src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}forum_{vb:raw forum.statusicon}-48.png" class="forumicon" id="forum_statusicon_{vb:raw forum.forumid}" alt="" />
---


Template: forumhome_lastpostby
3c3,11
<vb:if condition="$show['icon']"><img src="{vb:raw icon.iconpath}" alt="{vb:raw icon.title}" border="0" /></vb:if>
---
<vb:if condition="$show['icon']">
<vb:if condition="$lastpostinfo['lasticonid'] == -1">

<vb:elseif condition="$lastpostinfo['lasticonid'] == 0 && !empty($vbulletin->options['showdeficon'])" />

<vb:else />

</vb:if>
</vb:if>
6c14
<a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
<a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"></a>
18c26
<a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"><img src="{vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png" alt="{vb:rawphrase go_to_last_post}" /></a>
---
<a href="{vb:link thread, {vb:raw threadinfo}, {vb:raw pageinfo_lastpost}}#post{vb:raw lastpostinfo.lastpostid}"></a>

Template: forumhome_subforumbit_nopost
2c2
<img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/subforum_{vb:raw forum.statusicon}.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />
---


Template: forumhome_subforumbit_post
2c2
<img class="inlineimg" src="{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}subforum_{vb:raw forum.statusicon}-48.png" alt="" border="0" id="forum_statusicon_{vb:raw forum.forumid}" />
---


Template: memberaction_dropdown
5c5
<img src="{vb:stylevar imgdir_siteicons}/profile.png" alt="" />
---

12c12
<img src="{vb:stylevar imgdir_siteicons}/forum.png" alt="" />
---

20c20
<img src="{vb:stylevar imgdir_siteicons}/message.png" alt="" />
---

29c29
<img src="{vb:stylevar imgdir_siteicons}/blog.png" alt="" />
---

38c38
<img src="{vb:stylevar imgdir_siteicons}/homepage.png" alt="" />
---

47c47
<img src="{vb:stylevar imgdir_siteicons}/article.png" alt="" />
---

56c56
<img src="{vb:stylevar imgdir_siteicons}/add.png" alt="" />
---

65c65
<img src="{vb:stylevar imgdir_siteicons}/email.png" alt="" />
---

final kaoss

07-17-2011, 11:52 PM

Also, why isn't the logo added in this list? I'm sure everyone keeps the same logo name. Also I've done some testing and the page loading speed, requests & bytes in (tested with wepbagetest.org and my browsers) are roughly the same without this mod installed.

Also, I notice that on the test skin, the images are forced to reload, ignoring the cache settings that I put in my htaccess. And when I clear my cookies and view the regular skin, they cache fine (according to my browser, webpagetest.org and yslow). You should look into that and I think this is what's causing it.

Add ReadMarker Javascript

/images/misc/vbulletin4_logo.png

giorgino

07-18-2011, 06:00 AM

Great great mod, but without forum custom icon support is useless for me :)

Osbes

07-18-2011, 07:08 AM

Hello extreme-gaming,

no problem, i putted up the template changes in codeboxes again :)

The extra > and < is to indicate what should be replaced by what, but i understand that it is a little unhandy, if you want to select-copy-replace multiple lines.

I am adding icons step by step. Thats why the Logo is currently not added.

It is weird, that you didnt noticed a significant drop in the requests, using the addon. Can you send me a link, so i can try your implementation in the test skin?

I think you set the expires entity-header and cache-control header in your htaccess for images, right? This should behave totally independent to my addon.

I just double checked this an its working correct on our forum.

My Browsers sends:
GET /images/sprites/sprite.png HTTP/1.1
If-Modified-Since: Sun, 17 Jul 2011 21:49:42 GMT

and gets as response
HTTP/1.1 304 Not Modified

and then he loads the file from the browser-cache.

So that this isnt working on your forum seems also a little bit weird. Please send me a link, so i can check this in your test skin and the corresponding .httacces file, so i can check your cache settings.

Best regards
Sebastian

Osbes

07-18-2011, 07:16 AM

Great great mod, but without forum custom icon support is useless for me :)

Hi giorgino,

what do you mean by forum custom icon? We suppport forumicons with imageprefix and - since this is the main concepts of this addon - customised forumicons since the first release.

Check Sprites like:
http://www.united-forum.de/images/sprites/sprite.png
or
http://www.thailand-asienforum.com/forum/images/sprites/sprite.png

Best regards
Sebastian

giorgino

07-18-2011, 07:36 AM

Hi Sebastian :)
I mean the forum custom icons, see the pict

giorgino

07-18-2011, 07:38 AM

The mod I use for custom icons is https://vborg.vbsupport.ru/showthread.php?t=244351

klaus

07-18-2011, 07:44 AM

Works great for me on vb414. There are less requests like promised.

However I use Absolute path (http://cdn.domain.com/forum/image/buttons vs. images/buttons) in my image_dir style vars and this plugin doesn't seem to support it when I run the "refresh".

Overall I think this is a very significant performance enhancer that VB should have built into the software about 2 years ago. Thank you for writing this add-on and keep it going.

Mooff

07-18-2011, 07:44 AM

giorgino

07-18-2011, 07:53 AM

@giorgino
The way you use that mod seems to be no different than the basic vb4 setting (forum prefix).

check our board. We have different icons for almost all our games - starcraft2, tiberium twilight, tiberium wars, red alert3....
www.united-forum.de

I've tried to install your mod that work but it reset the forums custom icons to default icons... what's wrong?

Osbes

07-18-2011, 07:56 AM

@giorgino
The feature to use forums custom icons is builtin in vBulletin 4. You can add to every forum an own imageprefix, so it will use forums custom icons. If you use the vBulletin imageprefix for your your forums, these icons will instantly added to the sprite.

If you want to further use the Forum Category Icons addon, i can create you a plugin, so this icons will also added.

But i would advise you to use the builtin solution from vBulletin, so you didnt need an extra addon and an extra plugin from us on top of this.
This could make your workload during every vBulletin Update easier (less addons and plugins = less problems)

###

@klaus
Can you send me the output, when using an absolute path, via PN? This would help me finding the problem :)

Best regards
Sebastian

doctorsexy

07-18-2011, 08:11 AM

Will give it till it can be loaded with less fuss... looks good :D:up:

giorgino

07-18-2011, 08:45 AM

@giorgino
The feature to use forums custom icons is builtin in vBulletin 4. You can add to every forum an own imageprefix, so it will use forums custom icons. If you use the vBulletin imageprefix for your your forums, these icons will instantly added to the sprite.

If you want to further use the Forum Category Icons addon, i can create you a plugin, so this icons will also added.

But i would advise you to use the builtin solution from vBulletin, so you didnt need an extra addon and an extra plugin from us on top of this.
This could make your workload during every vBulletin Update easier (less addons and plugins = less problems)

Ouch Sebastian!
I don't know how to customize each icon per forum basis, with standard vB4 features. Can you advise me a guide to perform this? So I can uninstall the plugin and use yours?

Mooff

07-18-2011, 09:23 AM

@giorgino

In the ACP go to
-> Forum Manager
-> search for the forum you want to edit
-> edit forum
-> scroll down to 'Style Options'
-> Prefix for Forum Status Images --> add your forum prefix there (you can have a different one for each forum - and you need to add the prefix in your subforums as well, if you want the special icons to show up there). For forums which should use the default icons - do nothing.

you then need icons which are named accordingly
So if your forum prefix is, let's say, 'sc2_'
you need the following additional icons
sc2_forum_new-48.png
sc2_forum_old-48.png
sc2_subforum_new-48.png
sc2_subforum_old-48.png

In your ../statusicons folder.

Mooff

07-18-2011, 09:28 AM

Will give it till it can be loaded with less fuss... looks good :D:up:

Unfortunately we can't make the template changes easier. :(

In order to use sprites we need to replace the image codes in those templates. And since images are widely spread around in those templates it is a bit of a hassle to replace that code.

In addition we can't just upload the whole templates cause the code inbetween the image parts might be modified heavily on some boards and shouldn't be replaced.

If anyone has an idea how to make it easier - please let us know.

final kaoss

07-18-2011, 10:53 AM

No, I never did set expires, I'm using this in my htaccess. If you want to compare the load times on my site, select the df2 skin at the bottom left.

# Author: Matty Asia
# Version 1.6
# Downloaded from: http://www.vbulletin.com/forum/showthread.php?325798
RewriteEngine On
RewriteCond %{HTTP_USER_AGENT} "Mozilla/4\.76 \[en\] $Windows NT 5\.0; U$"
RewriteRule .* - [F,L]
Options +FollowSymLinks
### THIS IS A LITTLE EXTRA SECURITY AND CAN BE REMOVED
#RewriteRule ^includes/(.*) index.php
#RewriteRule ^vb/(.*) index.php
#RewriteRule ^packages/(.*) index.php
### THIS IS THE ACTUAL REWRITE
RewriteRule ^threads/([0-9]+)(?:/?$|(?:-[^/]+))(?:/?$|(?:/page([0-9]+)?)) showthread.php?t=$1&page=$2&%{QUERY_STRING}
RewriteRule ^members/([0-9]+) member.php?u=$1&%{QUERY_STRING}
RewriteRule ^forums/([0-9]+)(?:/?$|(?:-[^/]+))(?:/?$|(?:/page([0-9]+)?)) forumdisplay.php?f=$1&page=$2&%{QUERY_STRING}
RewriteRule ^blogs/([0-9]+)(?:/?$|(?:-[^/]+))(?:/?$|(?:/page([0-9]+)?)) blog.php?u=$1&page=$2&%{QUERY_STRING}
RewriteRule ^entries/([0-9]+)(?:/?$|(?:-[^/]+))(?:/?$|(?:/page([0-9]+)?)) entry.php?b=$1&page=$2&%{QUERY_STRING}
RewriteRule ^list/([^/]*/)([0-9]+) list.php?r=$1$2&%{QUERY_STRING}
RewriteRule ^content/(.*) content.php?r=$1&%{QUERY_STRING}
RewriteRule ^widget/config/([0-9]+) widget.php?r=config/$1&%{QUERY_STRING}
RewriteRule ^((urllist|sitemap).*\.(xml|txt)(\.gz)?)$ vbseo_sitemap/vbseo_getsitemap.php?sitemap=$1 [L]
RewriteCond %{REQUEST_FILENAME} -s [OR]
RewriteCond %{REQUEST_FILENAME} -l [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^.*$ - [NC,L]
RewriteRule ^$ $1.php?r=$2 [QSA]

####Gzip
<IfModule mod_rewrite.c>
RewriteCond %{REQUEST_FILENAME} -f
RewriteRule ^(.*)(js|css|php)$ redir.php?file=$1$2&type=$2 [L]
</IfModule>
## Rewrites
RewriteEngine on
Options +FollowSymlinks
RewriteCond %{REQUEST_FILENAME} -s [OR]
RewriteCond %{REQUEST_FILENAME} -l [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^.*$ - [NC,L]

# Forum
RewriteRule ^threads/.* showthread.php [QSA]
RewriteRule ^forums/.* forumdisplay.php [QSA]
RewriteRule ^members/.* member.php [QSA]
RewriteRule ^blogs/.* blog.php [QSA]
ReWriteRule ^entries/.* entry.php [QSA]
RewriteCond %{REQUEST_FILENAME} -s [OR]
RewriteCond %{REQUEST_FILENAME} -l [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^.*$ - [NC,L]
# MVC
RewriteRule ^(?:(.*?)(?:/|$))(.*|$)$ $1.php?r=$2 [QSA]
ErrorDocument 404 /404.php
ErrorDocument 403 /404.php
ErrorDocument 500 /404.php

# Cache static content for 1 MONTH
<FilesMatch "\.(ico|pdf|flv|jpg|jpeg|png|gif|swf|mp3|mp4|css|js |txt|xml)$">

Header set Cache-Control "max-age=2592000, public, must-revalidate"

</FilesMatch>

# Remove ETag headers
Header unset Pragma
FileETag None
Header unset ETag

# compress text, html, javascript, css, xml:
AddOutputFilterByType DEFLATE text/plain
AddOutputFilterByType DEFLATE text/html
AddOutputFilterByType DEFLATE text/xml
AddOutputFilterByType DEFLATE text/css
AddOutputFilterByType DEFLATE application/xml
AddOutputFilterByType DEFLATE application/xhtml+xml
AddOutputFilterByType DEFLATE application/rss+xml
AddOutputFilterByType DEFLATE application/javascript
AddOutputFilterByType DEFLATE application/x-javascript

Hello extreme-gaming,

no problem, i putted up the template changes in codeboxes again :)

The extra > and < is to indicate what should be replaced by what, but i understand that it is a little unhandy, if you want to select-copy-replace multiple lines.

I am adding icons step by step. Thats why the Logo is currently not added.

It is weird, that you didnt noticed a significant drop in the requests, using the addon. Can you send me a link, so i can try your implementation in the test skin?

I think you set the expires entity-header and cache-control header in your htaccess for images, right? This should behave totally independent to my addon.

I just double checked this an its working correct on our forum.

My Browsers sends:
GET /images/sprites/sprite.png HTTP/1.1
If-Modified-Since: Sun, 17 Jul 2011 21:49:42 GMT

and gets as response
HTTP/1.1 304 Not Modified

and then he loads the file from the browser-cache.

So that this isnt working on your forum seems also a little bit weird. Please send me a link, so i can check this in your test skin and the corresponding .httacces file, so i can check your cache settings.

Best regards
Sebastian

Without it installed.

http://www.webpagetest.org/result/110718_F8_12XTQ/

Page Speed 1.9 Score: 80/100
Load time 3.018 seconds on second load
Requests 8
KB's 35
F A A B B

With it installed.
http://www.webpagetest.org/result/110718_5T_12XVE/

Page Speed 1.9 Score: 80/100
Load time 2.935 seconds on second load
Requests 8
KB's 64

F A A B C

So I wind up losing a grade and on the forum refresh, it's noticeable that the images reload on the test skin

Osbes

07-18-2011, 11:30 AM

I didnt unterstand the Grading behind webpagetest.org, but as you can see, you gained alot of Performance using this addon.

Without addon

First View
Load Time: 5.161s
Requests: 78

Repeat View
Load Time: 2.405s
Requests: 8

With addon

First View
Load Time: 3.759s
Requests: 59

Repeat View
Load Time: 2.387s
Requests: 8

So the performance is better in any aspect using this addon. Your Load Time dropped significant 1.5 seconds on the first view.

As far as i can see, your grading only dropped cause on the second test (with addon) there is an additional
http://pagead2.googlesyndication.com/pagead/images/ad_choices_en.png
,but this isnt coming from our addon. Maybe you gained additional google ad since the forum is faster, using adaptiv ad strategies? This would be a big bonus.

giorgino

07-18-2011, 02:28 PM

Osbes

07-18-2011, 04:12 PM

If someone of you are using CDNs, please update to the latest version (0.6.2) :)

final kaoss

07-20-2011, 04:26 PM

with this installed. This get's reported

The following images served from vgchat.info should be combined into as few images as possible using CSS sprites.

/images/buttons/collapse_40b.png
/images/buttons/search.png
/images/misc/arrow.png
/images/misc/blog/top-highlight.png
/images/misc/forum_stats.png
/images/misc/navbit-home.png
/images/misc/tab-collapsed.png

For showforum:

The following images served from vgchat.info should be combined into as few images as possible using CSS sprites.

/images/buttons/collapse_40b.png
/images/buttons/lastpost-right.png
/images/buttons/search.png
/images/buttons/sortarrow-asc.png
/images/misc/arrow.png
/images/misc/black_downward_arrow.png
/images/misc/navbit-arrow-right.png
/images/misc/navbit-home.png
/images/misc/tag.png
/images/site_icons/forum.png
/images/site_icons/homepage.png
/images/site_icons/profile.png
/images/statusicon/thread-16-right.png
/images/statusicon/thread_dot-16-right.png
/images/statusicon/thread_hot-16.png
/images/statusicon/thread_hot-30.png
/images/statusicon/thread_hot_new-16.png
/images/statusicon/thread_lock-16.png
/images/statusicon/thread_new-16.png
/images/statusicon/thread_old-30.png

Add these to the next update?

giorgino

07-20-2011, 04:34 PM

I've a big problem. My attachments aren's visible anymore (error 404) :(
Can you help me?

Osbes

07-20-2011, 08:41 PM

Hello extreme-gaming,
i have currently added icons from FORUMHOME to the sprite, but yes the next step will be adding icons from SHOWFORUM.

----------------------------------

/images/misc/forum_stats.png

This image is replaced in the last version.
I see, that you are using some additional stats, so these add this image antoher time. Please replace

<img alt="Spam-O-Matic Statistics" src="images/misc/forum_stats.png" title="Spam-O-Matic Statistics">

with



but be aware that "Spam-O-Matic Statistics" could be an phrase, so look first in your template.

Do this also for "Visitors found this page by searching for:" and "Video Game Chat - Vbulletin Statistics"

----------------------------------

/images/buttons/search.png
/images/misc/arrow.png
/images/misc/navbit-home.png

These images will be supportet in the next bigger addon with a lot of icons from SHOWFORUM (0.7.0 or maybe earlier).

----------------------------------

/images/misc/tab-collapsed.png
/images/misc/tab-expanded.png

These images could be replaced within this addon, but not in the near future, since i have to modify an vBulletin-Javascript what will increase my workload to support this addon a lot with every vBulletin Update just to save 2 images.

----------------------------------

/images/buttons/collapse_40b.png
/images/buttons/collapse_40b_collapsed.png

These images will never be replaced within this addon, since it is used by many other addons and as long as you didnt change everything to using sprites it will need a second Javascript-file just to manipulate the className-attribute instead of the scr-attribute.
vBulletin has to do this.

----------------------------------

/images/misc/blog/top-highlight.png

I am not sure whether or not i will add this icon, since it looks like an gradient and i am not sure whether or not i will create an second sprite for gradients. I would advise using CSS3 for gradients (just like digital point did with his addon for gradients): https://vborg.vbsupport.ru/showthread.php?t=263393

Best regards
Sebastian

Osbes

07-20-2011, 08:56 PM

Hello giorgino,
i haven't added anything in connection to the attachment-system in this addon, so i didnt belive, that this problem has to do anything with it.

as far as i can see, you are using nginx and vbseo rewrite for attachments? an am i correct, that you problem is, that attachment-urls like http://www.propit.it/attachments/f66/372d1280162113-firma-nostro-libro-ospiti-stlegdv14-1-1-.4.09-005.jpg resolve into an 404 error? since our forum use nginx and vbseo too, i think i can help you anyway.

vbseo will rewirte the url of yout attachments to something like "attachments/f66/372d1280162113-firma-nostro-libro-ospiti-stlegdv14-1-1-.4.09-005.jpg". in our nginx configuration, nginx deliver jpeg directly and doesnt check each time if they exists, so it could use vbseo if it didnt exists.
since we didnt wanted to change this behavior of nginx we drop the rewrite of attachments with vbseo. hope this could help you.

Best regards
Sebastian

Mooff

07-20-2011, 11:25 PM

Another quick word on gradients.
I'm not so sure whether we should implement them at all. Those gradients are mostly used for background manipulation and in the styles i made for our board i used those gradients in many places. Places they weren't used in the default vb version and i removed them in a lot of backgrounds where vbulletin has them.
I personally think it will be impossible for us to create the addon in a way that we will automatically find all the places where you have used this one particular gradient - and will end up in serving the background some times via sprite and some times via icon.

But you can add those gradients in the sprite yourself. Since 0.6.0 we have added the
posibility to add custom icons into the sprite via the plugin-hook sprite_add_icon.
Be aware that this option is meant for experienced users and will probably stay that way for a long time. That aside, if you are using a modded style it gives the style designer the opportunity to offer a plugin to our addon, which includes all his additional graphics.

Makaveli007

07-21-2011, 06:57 PM

i receive the following on vb4.1.4 when clicking refresh

Call to undefined function imagecreatetruecolor() in /home/makaveli/public_html/admincp/sprite.php on line 653

any ideas?

Mooff

07-21-2011, 07:02 PM

You probably do not have GD (http://www.php.net/manual/en/book.image.php) installed on your server.

giorgino

07-21-2011, 07:35 PM

final kaoss

07-21-2011, 09:42 PM

Disable attachment rewriting in vbseo. How can you not understand that?

drop the rewrite of attachments with vbseo

Hi Sebastian you're right. We've nginx with some difficult in configuration... (cry).
I don't understand your super nice help (my english is really poor, sorry for this) and I ask you for extended suggestions

Makaveli007

07-21-2011, 10:03 PM

You probably do not have GD (http://www.php.net/manual/en/book.image.php) installed on your server.

you are correct sir. thanks. resolved

giorgino

07-22-2011, 05:44 AM

Disable attachment rewriting in vbseo. How can you not understand that?

Great! Thank you, work perfect!

Osbes

07-22-2011, 07:33 AM

Hi giorgino,

the commenly wrong assumption when working with nginx is, that every matching location directives will executed. Nginx will in general execute only one location directive.

To summarize, the order in which directives are checked is as follows:

Directives with the "=" prefix that match the query exactly. If found, searching stops.
All remaining directives with conventional strings. If this match used the "^~" prefix, searching stops.
Regular expressions, in the order they are defined in the configuration file.
If #3 yielded a match, that result is used. Otherwise, the match from #2 is used.

So if your nginx configuration looks like (http://www.axivo.com/community/threads/proper-vbseo-rewrite-rules-for-vbulletin-3.123/):

location / {
try_files $uri $uri/ @vbseo;
}

location @vbseo {
fastcgi_pass 127.0.0.1:9000;
fastcgi_param SCRIPT_FILENAME $document_root/vbseo.php;
fastcgi_param QUERY_STRING vbseourl=$request_uri;
include fastcgi_params;
internal;
}

location ~ \.(jpg|jpeg|png|gif|ico) {
add_header Cache-Control public;
add_header Cache-Control must-revalidate;
expires 7d;
access_log off;
}

and you want to access an vbseo rewrite attachment url like http://www.propit.it/attachments/f66/372d1280162113-firma-nostro-libro-ospiti-stlegdv14-1-1-.4.09-005.jpg the executed location directive will be

location ~ \.(jpg|jpeg|png|gif|ico) {
add_header Cache-Control public;
add_header Cache-Control must-revalidate;
expires 7d;
access_log off;
}

Since this doenst call vbseo.php the url will not resolve in the correct attachment url and you get an 404 http error.

So you could either extend your nginx configuration to always use try_files and then call vbseo.php as fallback, or you disable the rewrite of attachments with vbseo.

On our Forum we disabled this rewrite, cause the gain of this is - for us - lower than the gain of performance, since using try_files for every file isnt that good.

Best regards
Sebastian

giorgino

07-22-2011, 07:52 AM

Hi sebastian since you're so kind, I try to take advantage of your expertise.

This is my .conf

server {
listen 80;
server_name www.mysite.it mysite.it;
access_log /var/log/nginx/it.mysite.www.log;
error_log /var/log/nginx/err_it.mysite.www.log;

root /store1/www/it.mysite.www/doc_root;
index index.html index.htm index.php;

#
# Setup Expire
#
location ~* \.(jpg|jpeg|gif|css|png|js|ico)$ {
root /store1/www/it.mysite.www/doc_root;
access_log off;
expires 30d;
}

#
# Inizio Direttive per vBulletin/vBSEO
#

location ~ \.php$ {
fastcgi_pass 127.0.0.1:9000;
#fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
fastcgi_param SCRIPT_FILENAME $document_root/vbseo.php;
include fastcgi_params;
}

location / {
rewrite (sitemap_.*\.xml\.gz) /vbseo.php?vbseourl=vbseo_sitemap/vbseo_getsitemap.php&sitemap=$1 last;
try_files $uri $uri/ /vbseo.php?$args;
}

location /vbseo/(includes|resources/html|resources/xml)/ {
allow 127.0.0.1;
deny all;
}

location ~ /admincp/
{
index index.php index.html;
fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
include fastcgi_params;
if ($uri ~ \.php)
{
fastcgi_pass 127.0.0.1:9000;
}
break;
}

# --- fine
}

Mooff

07-23-2011, 07:59 AM

Version 0.6.3 (23.07.2011)
Added the possibility to use TMS for automatic template modification.
Icons can now be merged into different sprites and css rollups instead of one big sprite.
Addon is now compatible with vBulletin 4.1.xNew template edits:
None

giorgino

07-23-2011, 08:23 AM

Hi Mooff which template changes from 0.6.2 -> 0.6.3?
How upgrade? Simply overwrite files and rebuild sprites?

Osbes

07-23-2011, 08:35 AM

Hi giorgino,

There are no template changes from 0.6.2 -> 0.6.3.

If you want to Upgrade from 0.6.2 -> 0.6.3, simply overwrite files, reinstall the addon (simply upload XML-product file with overwrite) and rebuild sprite.

If you want to switch from maually template changes to automatic template changes, there is additional work to be done:

install the Template Modification System
undo the template changes you did for sprites
reinstall this addon (simply upload XML-product file with overwrite).

Now your Templates are automatic changed. This will help you in the next versions, since the upcomming template changes will also be done automatically.

I would advise to do it now, before more template modification need to be done.

Best regards
Sebastian

PS:
I will look into your nginx configuration later :)

giorgino

07-23-2011, 09:48 AM

Thank you Sebastian, I given a look in TMS plugin, but is in german language...
Do you know if exist in english also?

P.s.: Thank you very much!

Osbes

07-23-2011, 09:59 AM

There is an Version on vbulletin.org:
https://vborg.vbsupport.ru/showthread.php?t=152931

Mooff

07-23-2011, 10:01 AM

English version is here:
https://vborg.vbsupport.ru/showthread.php?t=152931&page=42
(it says vb3.8 mod, but on page 42 users are reporting it is working with 4.1.x)

Though, if you are german i would use this one:
http://www.vbulletin-germany.org/showthread.php?24-Template-Modification-System/page114
(version number is higher)

P.S.: If you need support regarding the TMS Addon please ask in those threads, much higher chance someone can help you.

8thos

07-25-2011, 05:19 AM

Truly one of the worst modifications I've ever installed.

Not your fault though. Using a custom skin. Disabled for now.

Mooff

07-25-2011, 07:26 AM

If you are talking about the link on your signature, that board is not that custom, i really do not see why the addon shouldn't work. At first glance i dare to say we are not at fault, neither is your custom skin.

That aside on your FORUMHOME (as a guest) it should get your http requests down to ~30 from ~40

But well, since you are using a map for the flags at the bottom i would have guessed you would appreciate a sprite addon. Techniques are very similar and both are meant to do the same thing. Reduce http requests, speed up loading time.

Osbes

07-25-2011, 07:37 AM

8thos

07-25-2011, 09:04 AM

Hello Octavius.

to just describe it as "worst addon" without any describtion of your error is really sad for me.

If you can describe me your problem, i am sure that i can help you to get it working :)

There are a lot other forums with custom styles out there, where this addon works perfect. I have also visit your site just now and since you are using the elementary way vbulletin adresses the images etc. it should work :)

Please check, that you have changed the StlyeVar imgdir_sprite f?r every style. If you didn't do this, the Sprite will be overwritten by every style, what will cause your problem.

In the next version this behavior is changed, so that there is no need anymore to change this StyleVar, since causes some mistakes from time to time.

Best regards
SebastianI didn't really mean that. I got excited and when it didn't work, I was let down. Like I said, not your fault. I did no stylevar edits all whatsoever. Therein lies my problem. I didn't understand this part of the directions and skipped it:

upon installation a new stylevar imgdir_sprite will be created. Update this stylevar based on your file structure - default value is the vbulletin sprite directory. Make sure the folder is writable, else the sprites can't be saved!

:confused:

Osbes

07-25-2011, 10:12 AM

Hello Octavius.

i have uploaded a new Version (0.6.3a). Please use this :)

With this you do not need to change the StlyeVar imgdir_sprite anymore. This should simplify the installation process.

To avoid additional errors, please make sure, that the default vbulletin sprite directory (just look into the StlyeVar imgdir_sprite to see which is this), is writeable, so this addon can save the sprites in this folder.

Best regards
Sebastian

8thos

07-25-2011, 04:29 PM

Mooff

07-25-2011, 05:09 PM

Depends on your server settings.

Your webserver needs write access in order to write and save the sprite. If your webserver is owner of the folder it would work, if your webserver isn't 755 won't be enough.

Just try it out, if it doesn't work try 777.

8thos

07-25-2011, 05:31 PM

755 is enough, thanks. I'll try again.

Juggernaut

07-26-2011, 01:35 AM

Installed, I think everything went right this time, although my costum skin doesn't use the legend.png icon. :D

Crotan

07-27-2011, 05:34 PM

Osbes

07-27-2011, 06:02 PM

Hello Crotan,

yes, with 0.6.3a this isn't needed anymore.

Best regards
Sebastian

Crotan

07-28-2011, 12:01 AM

Hello Crotan,

yes, with 0.6.3a this isn't needed anymore.

Best regards
Sebastian

Thanks, mod seems to be working alright. Still have a lot of gradients left :(

But mostly everything else seems to be covered by the CSS sprites

Wynex

07-28-2011, 06:10 PM

can this addon be uninstalled without damage to the templates?

Osbes

07-28-2011, 06:37 PM

Hello Wynex.

Yes, this addon didnt do any template changes directly.

If you are using the template modification system, it will automaticly removes the changes that were needed for his addon.

If you manually edit the templates, you can see with the aid of the diff-file, what content of the template was before.

Best regards
Sebastian

kavehch

07-28-2011, 08:34 PM

thanks dear

install

Wynex

07-29-2011, 03:23 AM

Hi Sebastian,

I've installed it and it said "54 icons added."
When I look at the template changes it only has a small list of changes in there

ORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_misc}/birthday.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_misc}/event.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_misc}/forum_stats.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_misc}/legend.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_misc}/users_online.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/category-16.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/forum_link-16.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/forum_new-16.png Suchtext gefunden
FORUMHOME United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/forum_old-16.png Suchtext gefunden
forumhome_forumbit_level2_nopost United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/category_forum_{vb:raw forum.statusicon}.png Suchtext gefunden
forumhome_forumbit_level2_post United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}forum_{vb:raw forum.statusicon}-48.png Suchtext gefunden
forumhome_lastpostby United-Forum.de CSS-Sprites replace {vb:raw icon.iconpath} Suchtext gefunden
forumhome_lastpostby United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_button}/lastpost-{vb:stylevar right}.png Suchtext gefunden
forumhome_subforumbit_nopost United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/subforum_{vb:raw forum.statusicon}.png Suchtext gefunden
forumhome_subforumbit_post United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}subforum_{vb:raw forum.statusicon}-48.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/add.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/article.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/blog.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/email.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/forum.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/homepage.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/message.png Suchtext gefunden
memberaction_dropdown United-Forum.de CSS-Sprites replace {vb:stylevar imgdir_siteicons}/profile.png

what do I have to do to enable the rest of the added icons?

Mooff

07-29-2011, 08:20 AM

Hi Wynex,

some of the template edits are for icon groups, which change dynamically depending the actual state of the forum - unread/ read/ closed ...

We have a list in post 3 explaining which templates were added and how many icons that particular edit does effect.

I made a visualisation based on that in our board (see attachment).

In addition we currently have a beta version of 0.7.0 running in our board, which adds support for the FORUMDISPLAY templates, meaning all threadicons like newpost, hot thread and so on. If everything goes well this should be released in a couple of days. =)

Crotan

07-29-2011, 05:46 PM

In addition we currently have a beta version of 0.7.0 running in our board, which adds support for the FORUMDISPLAY templates, meaning all threadicons like newpost, hot thread and so on. If everything goes well this should be released in a couple of days. =)

I look forward to it

Juggernaut

07-30-2011, 06:18 AM

Does 0.6.3 require the earlier template edits as well or only the edits for that version?

Osbes

07-30-2011, 06:42 AM

The earlier template edits are also required.

If you use the Template Modification System from Andreas, every template edit will be done automatically.

8thos

07-31-2011, 05:08 AM

I have no idea why this doesn't work.

Osbes

07-31-2011, 07:15 PM

Hello Octavius.,

what is your current problem?
Please send me a pn with the output when refreshing the css sprite, so i can look into it.

Best regards
Sebastian

8thos

07-31-2011, 08:11 PM

Hello Octavius.,

what is your current problem?
Please send me a pn with the output when refreshing the css sprite, so i can look into it.

Best regards
SebastianThanks man I will PM you when I get home from work!

Osbes

07-31-2011, 10:16 PM

Hello Octavius.,

its 01:08 in Germany and i am just finishing 0.7.0, so take your time, i will be resting ;).

Best regards
Sebastian

Mooff

07-31-2011, 11:22 PM

2am in germany - hope you guys enjoy the addon as much as we do. Looking at the pagespeed make me drool every time. :D

http://gadgetsteria.com/wp-content/uploads/2009/12/ludicrous-speed.png

DNCL

07-31-2011, 11:57 PM

Hello, the threads status icons the normal ones not the hot threads appears like this, any idea why? :)

https://vborg.vbsupport.ru/external/2011/07/1.jpg

It's like there is something wrong with images positioning in the big generated image.

Mooff

08-01-2011, 12:31 AM

Please force refresh your site (ctrl+r / ctrl+f5). Looks like you have an old sprite in your browser cache.

If that doesn't work hit the sprite-refresh button in the acp and send us the output.

final kaoss

08-01-2011, 01:26 AM

There's one thing I would like to see added to this.

Domain Sharding

As we've been discussing this and other tweaks here (https://vborg.vbsupport.ru/showthread.php?p=2227475#post2227475).

And please... if your going to post in english at least put the screenshots in english too... thanks.

Osbes

08-01-2011, 05:14 AM

Hello extreme-gaming,

sorry, since we are from germany our tools are also in german, but we will try to use an english version for the screenshots next time :)

Since Version 0.6.2 i have added support for URLs within the imgdir_* Stylevars, so you can use this addon with CDNs. So i would assume, that Domain Sharding also works.

How is Domain Sharding implemented on your site, whats the content of the imgdir_* StyleVars?

Best regards
Sebastian

8thos

08-01-2011, 05:25 AM

final kaoss

08-01-2011, 06:26 AM

I have them all set to (via stylevars)

/i1/
like /i1/icons
/i1/sprites

And now your plugin says:

DF2
0 custom icons added.
0 imageprefixes for forums found.
38 icon candidates added.
/home/username/public_html/forum/i1/statusicon/category-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/category_forum_link.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/category_forum_new.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/category_forum_old_lock.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/category_forum_old.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_link-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_new-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_old-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_new_lock-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_old_lock-16.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_link-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_new-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_new_lock-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_old-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/forum_old_lock-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_link-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_new-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_old-48.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_link.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_new.png does not exist or is not readable.
/home/username/public_html/forum/i1/statusicon/subforum_old.png does not exist or is not readable.
/home/username/public_html/forum/i1/buttons/lastpost-left.png does not exist or is not readable.
/home/username/public_html/forum/i1/buttons/lastpost-right.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/rss_40b.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/subscribed_40b.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/profile.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/forum.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/message.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/blog.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/homepage.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/article.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/add.png does not exist or is not readable.
/home/username/public_html/forum/i1/site_icons/email.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/users_online.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/event.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/birthday.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/forum_stats.png does not exist or is not readable.
/home/username/public_html/forum/i1/misc/legend.png does not exist or is not readable.
Starting with main.
0 icons added.
Creating sprite (width:1000px height:1px).

Warning: imagepng() [function.imagepng]: Unable to open '[path]/i1/sprites/sprite-16-main.png' for writing: No such file or directory in [path]/admincp/sprite.php on line 798
Error occurred: Unable to save sprite in /i1/sprites/sprite-16-main.png.
CSS template successfully updated.
Starting with forumdisplay.
0 icons added.
Creating sprite (width:1000px height:1px).

Warning: imagepng() [function.imagepng]: Unable to open '[path]/i1/sprites/sprite-16-forumdisplay.png' for writing: No such file or directory in [path]/admincp/sprite.php on line 798
Error occurred: Unable to save sprite in /i1/sprites/sprite-16-forumdisplay.png.
CSS template successfully updated.
Starting with forumhome.
0 icons added.
Creating sprite (width:1000px height:1px).

Warning: imagepng() [function.imagepng]: Unable to open '[path]/i1/sprites/sprite-16-forumhome.png' for writing: No such file or directory in [path]/admincp/sprite.php on line 798
Error occurred: Unable to save sprite in /i1/sprites/sprite-16-forumhome.png.
CSS template successfully updated.
Starting with showthread.
0 icons added.
Creating sprite (width:1000px height:1px).

Warning: imagepng() [function.imagepng]: Unable to open '[path]/i1/sprites/sprite-16-showthread.png' for writing: No such file or directory in [path]/admincp/sprite.php on line 798
Error occurred: Unable to save sprite in /i1/sprites/sprite-16-showthread.png.
CSS template successfully updated.

Hello extreme-gaming,

sorry, since we are from germany our tools are also in german, but we will try to use an english version for the screenshots next time :)

Since Version 0.6.2 i have added support for URLs within the imgdir_* Stylevars, so you can use this addon with CDNs. So i would assume, that Domain Sharding also works.

How is Domain Sharding implemented on your site, whats the content of the imgdir_* StyleVars?

Best regards
Sebastian

Mooff

08-01-2011, 09:51 AM

Are those files readable and the folder writeable for the username/group you are using for php?

DNCL

08-01-2011, 09:56 AM

If that doesn't work hit the sprite-refresh button in the acp and send us the output.

1 styles found.

Default Style
0 custom icons added.
0 imageprefixes for forums found.
Processing post icons.
14 post icons found.
Adding sidebar icons.
122 icon candidates added.
/forum/images/statusicon/forum_new_lock-16.png does not exist or is not readable.
/forum/images/statusicon/forum_old_lock-16.png does not exist or is not readable.
Starting with images/sprites/sprite-1-main.png.
97 icons added.
Creating sprite (width:1000px height:117px).
Sprite saved, updating css-rules.
Starting with images/sprites/sprite-1-main_rtl.png.
97 icons added.
Creating sprite (width:1000px height:117px).
Sprite saved, updating css-rules.
CSS template successfully updated.
Starting with images/sprites/sprite-1-forumdisplay.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-1-forumdisplay_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with images/sprites/sprite-1-forumhome.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-1-forumhome_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with images/sprites/sprite-1-showthread.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-1-showthread_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.

giorgino

08-01-2011, 10:39 AM

Hi guys this template changes don't match:

Template: pagenav
5c5
Trova:
<a href="{vb:raw lastaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw totalpages}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}<img src="{vb:stylevar imgdir_pagination}/last-{vb:stylevar right}.png" alt="{vb:rawphrase last}" /></a>

8c8
Trova:
<a rel="next" href="{vb:raw nextaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw nextpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/next-{vb:stylevar right}.png" alt="{vb:rawphrase next}" /></a>

18c18
Trova:
<a rel="prev" href="{vb:raw prevaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw prevpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/previous-{vb:stylevar right}.png" alt="{vb:rawphrase previous}" /></a>

27c27
Trova:
<a rel="start" href="{vb:raw firstaddress}{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase first_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw firstnumbers.first}, {vb:raw firstnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/first-{vb:stylevar right}.png" alt="{vb:rawphrase first}" />{vb:rawphrase first}</a>

30c30
Trova:
<a rel="prev" href="{vb:raw prevaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw prevpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/previous-{vb:stylevar right}.png" alt="{vb:rawphrase previous}" /></a>

40c40
Trova:
<a rel="next" href="{vb:raw nextaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw nextpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/next-{vb:stylevar right}.png" alt="{vb:rawphrase next}" /></a>

43c43
Trova:
<a href="{vb:raw lastaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw totalpages}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}<img src="{vb:stylevar imgdir_pagination}/last-{vb:stylevar right}.png" alt="{vb:rawphrase last}" /></a>

giorgino

08-01-2011, 11:15 AM

I've upgraded from 0.6.3 to 0.7.0 and I've this issue

nikosb

08-01-2011, 11:56 AM

I've upgraded from 0.6.3 to 0.7.0 and I've this issue

the same on 0.7.0

Osbes

08-01-2011, 12:19 PM

Sorry for the problems, there is update missing for the css-rule .threadbit .nonsticky a.threadstatus, .threadbit .sticky a.threadstatus in threadlist.css

Please change the original

.threadbit .nonsticky a.threadstatus, .threadbit .sticky a.threadstatus {
background-position: {vb:stylevar padding} 4px;
background-repeat: no-repeat;
clear: right;
display: block;
float: left;
position: relative;
width: 60px;
}

to

.threadbit .nonsticky a.threadstatus, .threadbit .sticky a.threadstatus {
background-repeat: no-repeat;
clear: right;
display: block;
float: left;
position: relative;
width: 60px;
}

I will update to 0.7.0a which include this change in the TMS-rules in a few minute.

Osbes

08-01-2011, 12:27 PM

0.7.0a is uploaded.

This should solve the problem :)

giorgino

08-01-2011, 12:32 PM

My thread.css is

.threadbit .nonsticky a.threadstatus, .threadbit .sticky a.threadstatus {
background-repeat: no-repeat;
background-position: {vb:stylevar padding} 4px;
position: relative;
float: {vb:stylevar left};
clear: {vb:stylevar right};
width: {vb:math {vb:stylevar threadbit_iconsize.width}{vb:stylevar threadbit_iconsize.units} + {vb:math 2 * {vb:stylevar padding}}};
display:block;
}

Osbes

08-01-2011, 12:41 PM

Hello giorgino,

please remove

background-position: {vb:stylevar padding} 4px;

This overwrites the background-position of our sprites.

Best regards
Sebastian

final kaoss

08-01-2011, 12:49 PM

No they aren't because my images aren't located there. They are at i1.vgchat.info

Are those files readable and the folder writeable for the username/group you are using for php?

giorgino

08-01-2011, 12:52 PM

Perfect Osbes :) Thank you, great work!

What about this issue?
https://vborg.vbsupport.ru/showpost.php?p=2227589&postcount=97

Osbes

08-01-2011, 01:01 PM

Hello giorgino

Sorry, i overlook this.

I made these based on 4.1.3, maybe this changed with 4.1.5.

Are there some images like
<img src="{vb:stylevar imgdir_pagination}/last-{vb:stylevar right}.png" alt="{vb:rawphrase last}" />
in your pagenav? If you use a custom design, maybe this was removed, then you also didnt need this changes.

Best regards
Sebastian

final kaoss

08-01-2011, 01:04 PM

So how do I get this to point to i1.vgchat.info since the forum is at vgchat.info/forum

Osbes

08-01-2011, 01:05 PM

Hello extreme-gaming,

what would be the corresponding absolute filepath that is used for i1.vgchat.info , ..., i3.vgchat.info?

Are you using some rewirte rules to support the link between "/i1/icons" and i1.vgchat.info ?

In the most CDNs (like used bei vBSeo), there are URLs in the StyleVars, what our addon understands, but i dont know if you need additional software like vBSeo to Support CDNs for vBulletin).

Best regards
Sebastian

final kaoss

08-01-2011, 01:10 PM

Sorry about that, it's i1.vgchat.info. I don't have to use any rewrite rules at all, since I've changed the image paths via stylevars so the paths I used were these.

/1/icons
../1/icons

giorgino

08-01-2011, 01:12 PM

Yes Osbes I use 4.1.5 :)

Another issue in search.php (new messages)

Mooff

08-01-2011, 01:16 PM

@giorgino

Thanks for the report, we have missed that one. Search.php seems to use another threadbit template, we will update this later today.
Subscribed forums in the user control panel do work though.

final kaoss

08-01-2011, 01:18 PM

Your addon still thinks the images can be found here though. When they cant.

/home/vgchat/public_html/forum/i1/statusicon/category-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_link.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_new.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_old_lock.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_old.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_link-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new_lock-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old_lock-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_link-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new_lock-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old_lock-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_link-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_new-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_old-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_link.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_new.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_old.png

bilgicc

08-01-2011, 01:30 PM

Good modifications. I rate and Nominate for MOTM.

Can you added this images for sprites.

Thanks for mod.

giorgino

08-01-2011, 01:43 PM

These are the template changes updated for 4.1.5 for reference and help

* Template: pagenav
* 5c5
Trova:
<a href="{vb:raw lastaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw totalpages}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}<img src="{vb:stylevar imgdir_pagination}/last-{vb:stylevar right}.png" alt="{vb:rawphrase last}" /></a>
---
Sostituisci con:

<a href="{vb:raw lastaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw totalpages}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}</a>


* 8c8
Trova:
<a rel="next" href="{vb:raw nextaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw nextpage}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/next-{vb:stylevar right}.png" alt="{vb:rawphrase next}" /></a>
---
Sostituisci con:

<a rel="next" href="{vb:raw nextaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw nextpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"></a>


* 18c18
Trova:
<a rel="prev" href="{vb:raw prevaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw prevpage}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/previous-{vb:stylevar right}.png" alt="{vb:rawphrase previous}" /></a>
---
Sostituisci con:

<a rel="prev" href="{vb:raw prevaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw prevpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"></a>


* 21c21
Trova:
<a rel="start" href="{vb:raw firstaddress}{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase first_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw firstnumbers.first}, {vb:raw firstnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/first-{vb:stylevar right}.png" alt="{vb:rawphrase first}" />{vb:rawphrase first}</a>
---
Sostituisci con:

<a rel="start" href="{vb:raw firstaddress}{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase first_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw firstnumbers.first}, {vb:raw firstnumbers.last}, {vb:raw total}}">{vb:rawphrase first}</a>


* 23c23
Trova:
<span<vb:if condition="THIS_SCRIPT == 'member'"> class="popupspan"</vb:if>><a href="javascript://" class="popupctrl">{vb:rawphrase page_x_of_y, {vb:raw pagenumber}, {vb:raw totalpages}}<vb:if condition="THIS_SCRIPT == 'member'"><img src="{vb:stylevar imgdir_misc}/black_downward_arrow.png" title="" alt="" /></vb:if></a>
---
Sostituisci con:

<span<vb:if condition="THIS_SCRIPT == 'member'"> class="popupspan"</vb:if>><a href="javascript://" class="popupctrl">{vb:rawphrase page_x_of_y, {vb:raw pagenumber}, {vb:raw totalpages}}<vb:if condition="THIS_SCRIPT == 'member'"></vb:if></a>


* 25c25
Trova:
<span<vb:if condition="THIS_SCRIPT == 'member'"> class="popupspan"</vb:if>><a href="javascript://" class="popupctrl"><vb:if condition="THIS_SCRIPT == 'member'"><img src="{vb:stylevar imgdir_misc}/black_downward_arrow.png" title="" alt="" /></vb:if>{vb:rawphrase page_x_of_y, {vb:raw pagenumber}, {vb:raw totalpages}}</a>
---
Sostituisci con:

<span<vb:if condition="THIS_SCRIPT == 'member'"> class="popupspan"</vb:if>><a href="javascript://" class="popupctrl"><vb:if condition="THIS_SCRIPT == 'member'"></vb:if>{vb:rawphrase page_x_of_y, {vb:raw pagenumber}, {vb:raw totalpages}}</a>


27c27
Trova:
<a rel="start" href="{vb:raw firstaddress}{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase first_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw firstnumbers.first}, {vb:raw firstnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/first-{vb:stylevar right}.png" alt="{vb:rawphrase first}" />{vb:rawphrase first}</a>
---
Sostituisci con:

<a rel="start" href="{vb:raw firstaddress}{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase first_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw firstnumbers.first}, {vb:raw firstnumbers.last}, {vb:raw total}}">{vb:rawphrase first}</a>


30c30
Trova:
<a rel="prev" href="{vb:raw prevaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw prevpage}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/previous-{vb:stylevar right}.png" alt="{vb:rawphrase previous}" /></a>
---
Sostituisci con:

<a rel="prev" href="{vb:raw prevaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw prevpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase prev_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw prevnumbers.first}, {vb:raw prevnumbers.last}, {vb:raw total}}"></a>


40c40
Trova:
<a rel="next" href="{vb:raw nextaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw nextpage}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"><img src="{vb:stylevar imgdir_pagination}/next-{vb:stylevar right}.png" alt="{vb:rawphrase next}" /></a>
---
Sostituisci con:

<a rel="next" href="{vb:raw nextaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw nextpage}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase next_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw nextnumbers.first}, {vb:raw nextnumbers.last}, {vb:raw total}}"></a>


43c43
Trova:
<a href="{vb:raw lastaddress}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?</vb:if><vb:if condition="$use_amp">&</vb:if>page={vb:raw totalpages}</vb:if>{vb:raw address2}<vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}<img src="{vb:stylevar imgdir_pagination}/last-{vb:stylevar right}.png" alt="{vb:rawphrase last}" /></a>
---
Sostituisci con:

<a href="{vb:raw lastaddress}{vb:raw address2}<vb:if condition="$show['pagelinks']"><vb:if condition="$use_qmark">?<vb:else />&</vb:if>page={vb:raw totalpages}</vb:if><vb:if condition="$anchor">#{vb:raw anchor}</vb:if>" title="{vb:rawphrase last_page} - {vb:rawphrase results_x_to_y_of_z, {vb:raw lastnumbers.first}, {vb:raw lastnumbers.last}, {vb:raw total}}">{vb:rawphrase last}</a>

Mooff

08-01-2011, 01:44 PM

Thanks bilgicc

As for gradients:
Another quick word on gradients.
I'm not so sure whether we should implement them at all. Those gradients are mostly used for background manipulation and in the styles i made for our board i used those gradients in many places. Places they weren't used in the default vb version and i removed them in a lot of backgrounds where vbulletin has them.
I personally think it will be impossible for us to create the addon in a way that we will automatically find all the places where you have used this one particular gradient - and will end up in serving the background some times via sprite and some times via icon.

But you can add those gradients in the sprite yourself. Since 0.6.0 we have added the
posibility to add custom icons into the sprite via the plugin-hook sprite_add_icon.
Be aware that this option is meant for experienced users and will probably stay that way for a long time. That aside, if you are using a modded style it gives the style designer the opportunity to offer a plugin to our addon, which includes all his additional graphics.

If i find some time later today i'll translate our german faq on how to use that plugin-hook.

--------------------------------

Your addon still thinks the images can be found here though. When they cant.

If you do not tell our addon where those images are located - it can't find them.

How would your users access those files via their web browser (please provide a full sample link we can click to see an image)?
In addition the folder where our addon wants to write the sprite has to be writeable and accessible by the user/group which does execute our addon. We cannot hack your linux system in order for our addon to save data. ;) :D

final kaoss

08-01-2011, 01:49 PM

SO HOW DO i DO THAT??? I already explained three times what I edited. And still, no support.

Anyways, they would get to it from here
http://vgchat.info/i1/sprites/sprite-16-main.png
Thanks bilgicc

As for gradients:

If you do not tell our addon where those images are located - it can't find them.

How would your users access those files via their web browser (please provide a full sample link we can click to see an image)?
In addition the folder where our addon wants to write the sprite has to be writeable and accessible by the user/group which does execute our addon. We cannot hack your linux system in order for our addon to save data. ;) :D

And listen. I already know that it has to be readable/writable and quite frankly, you would be aware that I already knew that if you actually backtracked a bit & read (since I already had this installed and working prior to moving the images). THAT HAS NOTHING TO DO WITH IT, People here aren't stupid. The problem here is what I've been posting

THERE ARE NO IMAGES AT /forum/i1/statusicon/category-16.png
That one would be found here now /i1/statusicon/category-16.png

/home/vgchat/public_html/forum/i1/statusicon/category-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_link.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_new.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_old_lock.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/category_forum_old.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_link-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new_lock-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old_lock-16.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_link-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_new_lock-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/forum_old_lock-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_link-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_new-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_old-48.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_link.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_new.png does not exist or is not readable.
/home/vgchat/public_html/forum/i1/statusicon/subforum_old.png

Mooff

08-01-2011, 02:16 PM

You can be aggressive all you want. In the end you do tell our addon to look in the wrong place.
We cannot magically guess where your images are located. And no you apparently did not tell us that.

Thats a link to an actual image used by a vbulletin board:
https://www.vbulletin.com/forum/images/statusicon/forum_new-48.png
where are your images located. Not the sprite. The images your users see when they visit your site.

Again i have to guess what link you might have to add. Your feedback is not clear enough. I'm really sorry, but that's the way it is.

so add http://vgchat.info/i1/statusicon/ as your statusicon image directory. That might work, that might not work. Or maybe http://1i/vgchat.info/ or http://3i/vgchat.info. Help me helping you - i really cannot work with the level of information you do provide.

DNCL

08-01-2011, 02:20 PM

Hello Mooff, you looked into my problem? :)

final kaoss

08-01-2011, 02:24 PM

When people have to repeat themselves over and over, what do you expect?

And where do you want me to change this at? In the stylevars or in the template edits? Because right now, this is how I'm setting the image paths.

so add http://vgchat.info/i1/statusicon/ as your statusicon image directory.

You can be aggressive all you want. In the end you do tell our addon to look in the wrong place.
We cannot magically guess where your images are located. And no you apparently did not tell us that.

Thats a link to an actual image used by a vbulletin board:
https://www.vbulletin.com/forum/images/statusicon/forum_new-48.png
where are your images located. Not the sprite. The images your users see when they visit your site.

Again i have to guess what link you might have to add. Your feedback is not clear enough. I'm really sorry, but that's the way it is.

so add http://vgchat.info/i1/statusicon/ as your statusicon image directory. That might work, that might not work. Or maybe http://1i/vgchat.info/ or http://3i/vgchat.info. Help me helping you - i really cannot work with the level of information you do provide.

Mooff

08-01-2011, 02:35 PM

@DNCL please install 0.7.0a it should solve that bug.

@exterme-gaming
I do expect new information when i'm asking a question. New information which actually can be called an answer.
Repeating the same 'not enough information' over and over again won't help at all. Getting called not supportive isn't of help either. Since we are actually trying to help you right now.

In that box, replace /i1/statusicon with http://vgchat.info/i1/statusicon
(so the addon does read your files from there (and similar) http://vgchat.info/i1/statusicon/forum_new-48.png )

final kaoss

08-01-2011, 02:47 PM

DF2
Error occurred: Your sprite folder uses an URL. Sprites cannot be saved via URLs. Please use an local filepath on your system for the StyleVar imgdir_sprite.

DNCL

08-01-2011, 02:56 PM

Problem solved. :), still the search results issue as giorgino mentioned. :)

8thos

08-01-2011, 03:04 PM

Good news. This mod really did create sprites but because I was doing so many changes to my styles and because of the delay from my CDN, webpagetest.org didn't give me an accurate score. I will have to try again later.

With this new update, do we still have to install template modification system?

I disabled template modification system because it changed the way I access edit templates and was too confusing to mess around with.

Mooff

08-01-2011, 03:05 PM

I was talking about the stylevars: imgdir_statusicon / imgdir_misc / imgdir_button / imgdir_siteicons /
Stylevars where our addon needs to read the old files. The files which are displayed when our addon is not running. The files which shall be replaced by our addon.

Of course we cannot connect to an external server to write the sprite. So imgdir_sprite has to be local - which is stated as an error via the addon.

edit: TMS is not needed. You can do all template changes manually. But i would strongly advise to use TMS, since the number of changes is really high. TMS does them in a blink of an eye. Manually does take it's time though.
As a sidenote. If vb4 would have native sprite support, no user based template changes would be necessary at all.

final kaoss

08-01-2011, 03:10 PM

This is exactly where I made the edits like you suggested. In the stylevars.

so add http://vgchat.info/i1/statusicon/ as your statusicon image directory. That might work, that might not work. Or maybe http://1i/vgchat.info/ or http://3i/vgchat.info. Help me helping you - i really cannot work with the level of information you do provide.

I was talking about the stylevars: imgdir_statusicon / imgdir_misc / imgdir_button / imgdir_siteicons /
Stylevars where our addon needs to read the old files. The files which are displayed when our addon is not running. The files which shall be replaced by our addon.

Of course we cannot connect to an external server to write the sprite. So imgdir_sprite has to be local - which is stated as an error via the addon.

edit: TMS is not needed. You can do all template changes manually. But i would strongly advise to use TMS, since the number of changes is really high. TMS does them in a blink of an eye. Manually does take it's time though.
As a sidenote. If vb4 would have native sprite support, no user based template changes would be necessary at all.

Mooff

08-01-2011, 03:16 PM

if(strpos($stylevars['imgdir_sprite']['imagedir'], 'http://') !== false)
{
echo 'Error occurred: Your sprite folder uses an URL. Sprites cannot be saved via URLs. Please use an local filepath on your system for the StyleVar imgdir_sprite. ';
}

That's when you receive that error. That is the only time you will receive that error. You won't get that error when you change the statusicon imgdir.
So please change your imgdir_sprite folder to a local path - and keep the other ones at http.

8thos

08-01-2011, 03:32 PM

Mooff

08-01-2011, 03:38 PM

Edit templates.

Every (supported) imagecode in the templates needs to be replaced via a fitting sprite class.

8thos

08-01-2011, 03:44 PM

Edit templates.

Every (supported) imagecode in the templates needs to be replaced via a fitting sprite class.I don't know if there's a bug in my template modification system or what but I can't edit templates in it. That's why I said it was hard and confusing cause I played around with it and it won't let me do anything.

So to get sprites working I'd have to turn it on and when I want to edit templates I'd have to disable template modification system which would then disable the sprites in united forum sprites mod?

smh. :rolleyes:

I'll bug vb.com to add sprite support. Might take them two years.

Crotan

08-01-2011, 03:52 PM

Upgrade Instructions?

Upload Files
Upload XML
Done if using TMS
Do refresh to find new supported images

Anything else?

Osbes

08-01-2011, 03:53 PM

Hello Crotan,

if you use TMS, this is it.

If you doenst use TMS add a 329 Lines Diff-File with Template-Changes to your workload. :/

Best regards
Sebastian

Mooff

08-01-2011, 03:59 PM

Does deactivating TMS revert all template changes? I don't know never tested that.

Crotan

08-01-2011, 04:16 PM

Hello Crotan,

if you use TMS, this is it.

If you doenst use TMS add a 329 Lines Diff-File with Template-Changes to your workload. :/

Best regards
Sebastian

Think I'll be going with TMS then, :p

However for some of the images it spits out an error with the wrong file path, for instance:

122 icon candidates added.
...../forums/forums/images/icons/icon1.png does not exist or is not readable.
...../forums/forums/images/icons/icon2.png does not exist or is not readable.

Where it lists the forums directory twice, looking in the wrong spot?

Crotan

08-01-2011, 05:06 PM

hmm on that note, this latest 0.7.0a version has removed the statusicons from search.php results list :confused:

https://vborg.vbsupport.ru/attachment.php?attachmentid=131603&stc=1&d=1312221956

final kaoss

08-01-2011, 05:09 PM

I had to uninstall it & go back to my old skin. This is how it's acting up now...

http://vgchat.info/forum/?styleid=16

Osbes

08-01-2011, 05:21 PM

Crotan

08-01-2011, 05:47 PM

Hi Crotan,

how does ist the Path for icon1.png in the AdminCP defined?

Jeah, we forget the search.php and will resolve this problem within the next day (maybe tonight, but it is 20:20 in Germany) :)

Best regards
Sebastian

/forums/images/icons/icon1.png

Is that not the standard file path, I've never changed it for any of the default post icons.

Seems the mod is expecting /images/icons/XXXXX.png

The latest version also removed the magnification glass for the search on the navbar. :rolleyes:

Osbes

08-01-2011, 06:01 PM

/forums/images/icons/icon1.png

Thanks, i will look for a way to solve this in the next version :)

The latest version also removed the magnification glass for the search on the navbar.

You have set an additional background:
.globalsearch .searchbutton {
background: url("images/Seamus/gradients/back3.png") repeat-x scroll left top transparent;
border: 1px solid #1B518F !important;
border-radius: 7px 7px 7px 7px;
box-shadow: 0 0 2px #1A1A1A;
margin-left: -5px;
margin-top: -2px;
}

The background-definition overwrites the sprite.

If you remove this, you will see the sprite.
To didnt lose your styling, you could change the http://flotgaming.net/forums/images/buttons/search.png icon accordingly and refresh the sprite :)

DNCL

08-01-2011, 06:04 PM

the magnification glass for the search is there for me, no need for fix in my case.

giorgino

08-01-2011, 06:34 PM

the magnification glass for the search is there for me, no need for fix in my case.

Idem for me

Osbes

08-01-2011, 07:43 PM

DNCL

08-01-2011, 09:37 PM

Hello Osbes,

Moved thread redirect icon not appearing too in forumdisplay, white instead.

Please fix it :)

Crotan

08-01-2011, 10:27 PM

Version 0.7.1 (01.08.2011)
added support for search.php pages including What's New
some minor bugfixes

@Crotan
I have also tried to fix your Problem with
/forums/images/icons/icon1.png
please test the new version :)

Best regards
Sebastian

search.php status icons are now showing up. :up:

however same thing as before but with "(with bburl_path / )" added into the mix.
..../forums/forums/images/icons/icon1.png (with bburl_path / ) does not exist or is not readable.
..../forums/forums/images/icons/icon2.png (with bburl_path / ) does not exist or is not readable.

Also thanks for the heads up, I'll look into this.
.globalsearch .searchbutton {
background: url("images/Seamus/gradients/back3.png") repeat-x scroll left top transparent;
border: 1px solid #1B518F !important;
border-radius: 7px 7px 7px 7px;
box-shadow: 0 0 2px #1A1A1A;
margin-left: -5px;
margin-top: -2px;
}

Osbes

08-02-2011, 04:25 AM

Hello Osbes,

Moved thread redirect icon not appearing too in forumdisplay, white instead.

Please fix it :)

Hello DNCL,

i just doublechecked it in the sprite.php and in our liveforum and it is working for me. Can you please send me an URL to your forum where i can see this problem?

Best regards
Sebastian

Osbes

08-02-2011, 04:33 AM

Crotan

08-02-2011, 05:10 AM

Hello Crotan,
thanks for the helpful output.

I had assumed, that your Forum URL (in Site Name / URL / Contact Details in the AdminCP) looks like

http://flotgaming.net/forums/

and than the addon would use (with bburl_path /forums ), what would have resolved your problem.

Since the bburl_path is just / am i right, that your Forum URL looks like

http://flotgaming.net/

?

Whats the Content of your Forum Component URL ? Something like

http://flotgaming.net/forums/
or
forums

?

Best regards
Sebastian

Forum URL (in Site Name / URL / Contact Details in the AdminCP) looks like

http://flotgaming.net/forums

I don't have any of the component URLs for the forums/cms/blog setup since I'm not using mod rewritten urls :( Only Advanced friendly rewrites.

So I don't have anything specified in those component boxes, it will be what ever is vBulletin default I suppose

Thanks for the great support for your Mod!

Osbes

08-02-2011, 05:25 AM

tpearl5

08-02-2011, 02:49 PM

Any plans to make this work with showthread?

Osbes

08-02-2011, 02:56 PM

Hello tpearl5,

Support for SHOWTHREAD is planned for 0.8.0.

Best regards
Sebastian

Mooff

08-02-2011, 02:57 PM

First Post:

Add on features

In the current released beta version 0.7.1, sprites are available for FORUMHOME and FORUMDISPLAY. Coming up next SHOWTHREAD.

;) :D

Crotan

08-02-2011, 03:10 PM

Please try the attached sprite.php

Replace this with the sprite.php in your admincp-folder and recreate the sprite.

I have added some additional Debug (starts and ends with DEBUG). if this file doesn't resolve your problem, pls send me those :)

Best regards
Sebastian

Looks like that fixed the post icons! and 14 were added for each style. No "does not exist or is not readable" error read out for any of them anymore. :up:

There are still two statusicons that it can't find however, I'm not sure what makes these any different than the usual statusicons that it's able to find and create sprites for.

DEBUG
array(3) { ["scheme"]=> string(4) "http" ["host"]=> string(14) "flotgaming.net" ["path"]=> string(7) "/forums" } DEBUG
..../forums/Seamus/statusicon/forum_new_lock-16.png (with bburl_path /forums ) does not exist or is not readable.
..../forums/Seamus/statusicon/forum_old_lock-16.png (with bburl_path /forums ) does not exist or is not readable.

I should mention the .... isn't what the mod is printing out its just my FTP directories that I'm taking out of my copy and pastes.

Just looking at it, the correct path would be ...../forums/images/Seamus/statusicon/forum_old_lock-16.png

But then again those files legitimately don't exist. My custom statusicons don't include old_lock or new_lock in 16x16 sizes only 48x48. Neither does the default vBulletin statusicons :confused:

There is however a forum_lock-16.png

giorgino

08-02-2011, 03:31 PM

Hi Osbes is it impossible to have templates changes integrated in your plugin?

I don't love the TMS option (another plugin installated = risk), so I'm using the manual changes option.

I'm not a coder, but if is possible and you teach me how to do this, I offer you my time for write the code to integrate in your plugin (sorry for my english..)

Osbes

08-02-2011, 03:35 PM

Hello Crotan,

good to hear, that it fixed your problem :)

To didnt miss any images, i evalutated what values are used for the statusicon in the image codes:

{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}forum_{vb:raw forum.statusicon}-16.png

it is possible, that this icon never exists within vbulletin, but i will check (and remove) these after 4.1.6 first, since the mobile style use this definition and i dont know if these will be included und how much this style will be changed.

On a side note: i didnt add any templatechanges for the mobile style at present. and i wont do before 4.1.6

Best regards
Sebastian

Osbes

08-02-2011, 03:38 PM

Hello giorgino,

it would be no problem to replace every perfect match of old code with new ones that use sprites, but the problem is, that it is complicated to revert such changes or update any changes.

Since the TMS does all this (and more), i didnt want to reinvent the wheel.

Best regards
Sebastian

valdet

08-02-2011, 04:14 PM

Just came across this wonderful mod.

Is it possible to make this hack work for older versions of vB 3.x (3.6, 3.7 and 3.8) series.

tpearl5

08-02-2011, 04:16 PM

Hello tpearl5,

Support for SHOWTHREAD is planned for 0.8.0.

Best regards
Sebastian

First Post:

;) :D

Missed that - thanks!

Osbes

08-02-2011, 05:14 PM

Hello valdet,

since our liveforum doesn't use vBulletin 3.8.x we wont do it.

But if someone wants to port our addon to vBulletin 3.8.x, we will appreciate it.

But you are not allowed to charge money for the addon and the branding needs to be intact (but you can extend it).

So if someone wants to port our addon to vBulletin 3.8.x, feel free to do it, we will glady help.

Best regards
Sebastian

final kaoss

08-02-2011, 05:47 PM

You can install a test forum with 3.8 being the installed version. Just remember the rules to password protect it & name it testvb.

Hello valdet,

since our liveforum doesn't use vBulletin 3.8.x we wont do it.

But if someone wants to port our addon to vBulletin 3.8.x, we will appreciate it.

But you are not allowed to charge money for the addon and the branding needs to be intact (but you can extend it).

So if someone wants to port our addon to vBulletin 3.8.x, feel free to do it, we will glady help.

Best regards
Sebastian

Osbes

08-02-2011, 06:03 PM

Hello extreme-gaming,
yes, that would be possible, but since the development of an vBulletin 3.8.x port of this addon wouldnt be usefull for our forum, since we didnt use 3.8.x, i wont invest time into this.

Please dont forget, that developing this addon happens beside my work and freetime :)

Best regards
Sebastian

ZeroHour

08-02-2011, 07:12 PM

I am not sure why but my forum category images are cut off by a few pixels on the sprite which breaks the drop shadow effect.
Any ideas?

archet1337

08-03-2011, 12:25 AM

This is a brilliant mod! Thanks for sharing. Working great on 4.1.5

Not that it matters much and is a quick fix, but you forgot to translate the phrase $vbphrase[sprite_navgroup_configuration] to english :)

Also, the attachment icon looks a bit weird. See attached image. How to fix this?

FReeSTER

08-03-2011, 01:08 AM

this mod is great but it gave me a hard time. For some reason it HIDED must of the forum images.

So I Un-Install until I know how to fix it

thanks

popmyzit

08-03-2011, 03:02 AM

I am testing this I get error on refresh

Default Style
Error occurred: Your sprite folder is not writeable. Please check the permissions on the directory "".

Where can I modify the directory? What is the default directory so I can make it writable.

thanks

Crotan

08-03-2011, 04:14 AM

Osbes

08-03-2011, 04:52 AM

Hello archet1337,

Also, the attachment icon looks a bit weird. See attached image. How to fix this?

the problem is, that you are not using GD-Libary 2.0.36 (or later) and your image isn't using "color RGBA", but "gray+alpha". You can tell this problem by the vertical lines you get.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

GD 2.0.36 (2007-11-xx)
88, Fixed support of PNG grayscale image with alpha channel (Pierre)https://bitbucket.org/pierrejoye/gd-libgd/src/733361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

2009

libgd2 (http://packages.debian.org/src:libgd2) (2.0.36~rc1~dfsg-3+lenny1) stable-security; urgency=high

* Non-maintainer upload by the Security Team.
* Fixed CVE-2009-3546 (http://security-tracker.debian.org/tracker/CVE-2009-3546): possible buffer overflow or buffer over-read attacks via crafted files (Closes: #552534 (http://bugs.debian.org/552534))

-- Giuseppe Iuculano <iuculano@debian.org (http://qa.debian.org/developer.php?login=iuculano@debian.org)> Mon, 09 Nov 2009 21:46:06 +0100

I am really shocked by this, since you are now the sixth person with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.

Best regards
Sebastian

Osbes

08-03-2011, 04:54 AM

Hello FReeSTER,

what exactly is your problem? i dont understand what you mean.

Best regards
Sebastian

popmyzit

08-03-2011, 04:56 AM

Thanks still have an issue with the error above.

Tried also in Vbulletin 3.8:

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in [path]/global.php(355) : eval()'d code on line 56

Fatal error: Class 'vB_Template' not found in /home/user/public_html/forum/index.php(596) : eval()'d code on line 157

I don't have time to hack it up for Vbulletin 3.8 but hopefully somebody does.

Osbes

08-03-2011, 06:16 AM

Hello popmyzit,

please look into the StyleVar imgdir_sprite. Since your error message just says

Error occurred: Your sprite folder is not writeable. Please check the permissions on the directory "".

Ik looks like this StyleVar is empty on your system, you could use as a value the default sprite folder of vBulletin:

images/sprites

Best regards
Sebastian

Osbes

08-03-2011, 06:49 AM

Hello ZeroHour,

i just want to inform you, that i didnt forget your problem, but i didnt have the time to give you a solution at the moment.

Best regards
Sebastian

popmyzit

08-03-2011, 02:44 PM

Thanks Sebastian will try the above,

best

steeler7

08-03-2011, 04:31 PM

I ran the Google Page Speed Test and My score still stinks :) It suggested that I run Css Sprites even though I put this Hack on and it appears that I have sprites in the Image Directory that was made too.

Mooff

08-03-2011, 04:38 PM

giorgino

08-03-2011, 04:59 PM

And there of course is allways the option of using the 'add_custom_image_to_sprite' hook we provide in our addon, where you can add additional custom icons your board uses.

Hi Moof, can you provide some sort of instruction to add custom icons to your (super-great) plugin?

archet1337

08-03-2011, 05:09 PM

After running the google speed test, I noticed that there is still 27 images that is not turned into css sprites.

How do I add these as well?

Most of them are in my additional.css template.

steeler7

08-03-2011, 05:13 PM

But i suppose you do see an improvement?

Yes, google will still show up css sprites beeing an issue since gradients can't be included in the sprite since they are highly dependend on styles. But since they are mostly <10px google says you should combine them.
In addition, if you have some addons installed google might pick up on pictures those addons include.

And there of course is allways the option of using the 'add_custom_image_to_sprite' hook we provide in our addon, where you can add additional custom icons your board uses.

Aside that, i have to ask this, did you make the required template changes? Without them your board won't be using the sprite.

Yes, I did make ther required Template changes and the listing of images they mention that should be made into CSS Sprites are these ..

GlossyHeader.png
collapse.png
collapse_40b.png
lastpost-right.png
search.png
widget-comment.png
selected-tab-gradient-with-top-alpha.png
icon1.png
arrow.png
bottom-shadow.png
event.png
facebook_login.gif
forum_stats.png
legend.png
navbit-home.png
rss_40b.png
tab-collapsed.png
forum.png
profile.png
category-16.png
forum_link-16.png
forum_new-16.png
forum_old-16.png
post_old.gif

Tough for me to say if there's been an improvement since I didn't run the test before hand. I'm trying to make other optimizations and work on the Leverage caching. My score of 54 is pretty bad :)

Mooff

08-03-2011, 05:26 PM

lastpost-right.png
search.png
event.png
forum_stats.png
legend.png
forum.png
profile.png
category-16.png
forum_link-16.png
forum_new-16.png
forum_old-16.png

Those should be covered by the addon (if you made all template changes). If they are not you are probably using some what's going on block modification - then you should search for them manually and replace them.

I'm going to translate the custom_icon_add instructions we have posted on vb-ger.org right now, as a warning. They are what i would call advanced. ;)

Mooff

08-03-2011, 05:41 PM

How-To:
Include custom icons to your sprite:

!Warning! very advanced - if you do not know what you are doing. Stop right here.

Custom icons are added via plugin and hook

In the ACP create a new plugin

Add-on: vBulletin
Hook: sprite_add_icon
Titel: choose your own title. whatever makes sense for you
execution order: 5
PHP-CODE: (this is an example, path would be your icon, css would be the name of your icon!)

$files[] = array(
'path' => $stylevars['imgdir_siteicons']['imagedir'] . '/add.png',
'css' => 'siteicons_add',
'rollup' => $CSS_FORUMHOME_ROLLUP,
'height' => 23,
'width' => 24,
'padding' => array(
'top' => 4,
'right' => 4,
'bottom' => 4,
'left' => 4
)
);

As for the rollup part. Right now allways use $CSS_FORUMHOME_ROLLUP - in later versions we will have different sprites for FORUMHOME and SHOWTHREAD (f.e.) - then you can choose which one. right now stay with Forumhome.
height, width and padding are optional. If you do not need them, delete all of those array values.
set it to active
save
refresh css sprites
modify the template in which your sprite is placed
search

<img srv="http://....customimage.png" />

replace



the icon should be loaded via the sprite now

I hope it helps. And do not say i didn't warn you. It is advanced. :p

steeler7

08-03-2011, 06:33 PM

Those should be covered by the addon (if you made all template changes). If they are not you are probably using some what's going on block modification - then you should search for them manually and replace them.

I'm going to translate the custom_icon_add instructions we have posted on vb-ger.org right now, as a warning. They are what i would call advanced. ;)

I'm sorry if I made you think too much today. I just realized that I only applied the Template Changes for this version not all of the previous ones. If I had any knowledge of what TMS does I'd use that, seems easier than having to go do all of these manual edits :)

archet1337

08-03-2011, 06:56 PM

Thanks Mooff, that helps a lot :)

But some of the images I have to replace is defined in additional.css.

Do I have to find where they are called in the forumhome template and add the code there and remove the line from additional.css, or is there another way to do that?

Osbes

08-03-2011, 07:00 PM

Hello archet1337,

please give an full example of your situation, this would help us to give you the best solution :)

Best regards
Sebastian

Andyrew

08-03-2011, 07:03 PM

Just installed and I get this when I run refresh. ?

/home/xxxxxx/public_html/forums/images/statusicon/forum_new_lock-16.png (with bburl_path / ) does not exist or is not readable.
/home/xxxxxx/public_html/forums/images/statusicon/forum_old_lock-16.png (with bburl_path / ) does not exist or is not readable.

Those images appear chopped of at the bottom in firefox even look worse in IE.

Osbes

08-03-2011, 07:14 PM

Hi Andyrew,

both images currently doesnt exists within vBulletin, but there are possibile values for:

{vb:stylevar imgdir_statusicon}/{vb:raw forum.imageprefix}forum_{vb:raw forum.statusicon}-16.png

I think i will remove these until they are delivered by vBulletin, to cause less confusion.

Those images appear chopped of at the bottom in firefox even look worse in IE.
What did you mean by that? Please provide more details (an images maybe or your site-url) to this problem.

Best regards
Sebastian

Andyrew

08-03-2011, 07:24 PM

Hi Andyrew,

What did you mean by that? Please provide more details (an images maybe or your site-url) to this problem.

Best regards
Sebastian

Many of the icons don't look correct when I enable your plugin.

Mooff

08-03-2011, 07:29 PM

You are not using the latest Version.
This first bug is fixed in 0.7.1 (showthread icons)
The attachment icon is due to a bug in GD version 2.0.35. A version which is >4 years old and has some security issues which were fixed 4 years ago.

We need more infos on the FORUMHOME icons though. We can't reproduce that. Would be great if you can link us to your site (maybe a teststyle), where we can see what is causing that behaviour.

Crotan

08-03-2011, 07:41 PM

steeler7

08-03-2011, 07:57 PM

Uh-Oh....

I am missing pretty much every icon possible on my forum after I went through and did all of the template stuff.

Any idea what I did wrong?

final kaoss

08-03-2011, 07:57 PM

That's the same thing happening on the skin that I have this plugin installed on

http://vgchat.info/forum/index.php?styleid=16

Many of the icons don't look correct when I enable your plugin.

Also this really needs to be changed for people who have images on subdomains/cdn's like myself. Because I tried to add http://i1.vgchat.info/ to the sprite stylevars since thats the only way I know of to point it there while the forum is sitting on http://vgchat.info/forum/
I have my images there because there, they are cookie-free

DF2
Error occurred: Your sprite folder uses an URL. Sprites cannot be saved via URLs. Please use an local filepath on your system for the StyleVar imgdir_sprite.

Osbes

08-03-2011, 08:20 PM

If you have some image like

http://dl.dropbox.com/u/246391/Robin.png

which looks like

http://dl.dropbox.com/u/246391/Robin_result.png

in the Sprite (it is stretched and vertical lines are added), than you possible use a GD Libary older than 2.0.36.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

GD 2.0.36 (2007-11-xx)
88, Fixed support of PNG grayscale image with alpha channel (Pierre)https://bitbucket.org/pierrejoye/gd-libgd/src/733361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

2009

libgd2 (http://packages.debian.org/src:libgd2) (2.0.36~rc1~dfsg-3+lenny1) stable-security; urgency=high

* Non-maintainer upload by the Security Team.
* Fixed CVE-2009-3546 (http://security-tracker.debian.org/tracker/CVE-2009-3546): possible buffer overflow or buffer over-read attacks via crafted files (Closes: #552534 (http://bugs.debian.org/552534))

-- Giuseppe Iuculano <iuculano@debian.org (http://qa.debian.org/developer.php?login=iuculano@debian.org)> Mon, 09 Nov 2009 21:46:06 +0100

I am totally shocked by this, since there seem to be a whole bunch of people with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.
So there seems to be a lot problem within the maintenance of servers, if some serious security issue isnt solved since 2-4 years. If you pay money for server maintenance i would be deeply shocked, if i were you.

Best regards
Sebastian

archet1337

08-03-2011, 08:24 PM

Hello archet1337,

please give an full example of your situation, this would help us to give you the best solution :)

Best regards
Sebastian

Hello Sebastian and Mooff.

I need the following images to be converted into sprites:

http://www.radioctrl.com/highslide/graphics/loader.white.gif
Defined in highslide.css
.highslide-loading {
background-image: url(graphics/loader.white.gif);

http://www.radioctrl.com/images/gradients/grey-up.png
Defined in socialgroups_overview.css
li.sgicon .maincol {
background:#ffffff url({vb:stylevar imgdir_gradients}/grey-up.png) repeat-x scroll

and stylegenerator.css
.forumhead+.childforum .L2:first-child .forumrow,.forumhead+.L2 .forumrow
background: #FFFFFF url(images/gradients/grey-up.png) repeat-x scroll

http://www.radioctrl.com/images/styles/Aesthetica/misc/arrow.png
Defined in additional.css
.toplinks .notifications a.popupctrl {
background: #242424 url({vb:stylevar imgdir_misc}/arrow.png) {vb:stylevar right} center no-repeat ;

http://www.radioctrl.com/images/styles/Aesthetica/style/bottomBarBG.gif
Defined in additional.css
.bottomBar {
background:url(images/styles/Aesthetica/style/bottomBarBG.gif) repeat-x top left;

There is a couple more, but you get the idea?

What do I do to make the images defined in css files into sprites?

Mooff

08-03-2011, 08:39 PM

@exterme-gaming

Version 0.6.2 (17.07.2011)

Added support for http filepaths and therefore one-way support for CDNs

The addon has CDN support since version 0.6.2 - users have confirmed it does work with CDNs. You issue has nothing to do with our addon but simply with the fact that you do not listen at all. And god knows we tried to help.

Osbes

08-03-2011, 08:39 PM

Hello extreme-gaming,

Also this really needs to be changed for people who have images on subdomains/cdn's like myself. Because I tried to add

http://i1.vgchat.info/ to the sprite stylevars since thats the only way I know of to point it there while the forum is sitting on

It is impossible write the contet via HTTP, since this is a read-only access.

So you can't use an URL within the styleVar imgdir_sprite as long as you refresh the sprite. After this you can move the sprite to every folder you like and change the StyleVar.

If you are using a CDN correctly, it will synchronize your folder, so there is no need to set an URL for this StyleVar. Suppport for CDN is added since 0.6.2 and is proven by other users to work.

If you are using "Domain Sharding" you can set the correct relative path based from the forum-path to your icons.

Best regards
Sebastian

Osbes

08-03-2011, 08:44 PM

steeler7

08-03-2011, 08:49 PM

Hello steeler7,

please provide us with more information, which images are missing? have you made the template changes and refresh the sprite? can you provide us with your forum url, so we can look at it ourself?

Best regards
Sebastian

www.pittsburghsportstavern.com/forum

the images missing look to be statusicons, subforum and forum variety it looks like, last post arrow ...

I did make all of the Template changes (can't guarantee I didn't make a mistake along the way. That was a lot of Editing) and then I ran a refresh of the sprite.

Thanks!

final kaoss

08-03-2011, 08:51 PM

Hi, I need more info about how to do this because every time I tried it didn't recognise the new place... for example..

/home/vgchat/public_html/forum/i1/pagination/next-left.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/pagination/previous-right.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/pagination/previous-left.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/pagination/first-right.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/pagination/first-left.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/black_downward_arrow.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/tag.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/expires.gif (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/moderated_small.gif (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/trashcan_small.gif (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/paperclip.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/subscribed.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/misc/sticky.gif (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/buttons/sortarrow-asc.png (with bburl_path / ) does not exist or is not readable.
/home/vgchat/public_html/forum/i1/buttons/sortarrow-desc.png (with bburl_path / ) does not exist or is not readable.
Hello extreme-gaming,

It is impossible write the contet via HTTP, since this is a read-only access.

So you can't use an URL within the styleVar imgdir_sprite as long as you refresh the sprite. After this you can move the sprite to every folder you like and change the StyleVar.

If you are using a CDN correctly, it will synchronize your folder, so there is no need to set an URL for this StyleVar. Suppport for CDN is added since 0.6.2 and is proven by other users to work.

If you are using "Domain Sharding" you can set the correct relative path based from the forum-path to your icons.

Best regards
Sebastian

Osbes

08-03-2011, 08:54 PM

Osbes

08-03-2011, 09:03 PM

Hello extreme-gaming,

If i understand you right, i can access your file via

http://vgchat.info/forum/../i1/pagination/next-left.png

and

http://vgchat.info/forum/

is your forum url?

Than please use

../i1/pagination

you could even use a URL like

http://vgchat.info/i1/pagination

or

http://i1.vgchat.info/pagination

for this stylevar.

For the imgdir_sprite StyleVar, you must use a relative path like

../i1/sprites

Best regards
Sebastian

final kaoss

08-03-2011, 09:23 PM

alright I'll try that & unfortunately hostgator won't upgrade their GD version. Is there any chance this thing can use imagemagik?

Greetings,

Thank you for the verification. Unfortunately upgrading the GD Library version that is installed on your server is something we are unable to do. The process of doing so would impact the availability of every website on the server. If it's absolutely critical that this library be upgraded, your only available options would be to upgrade your hosting to a VPS or Dedicated plan where you would have root access to your server to administer as you wish.
If you have any more questions please let us know.
Cheers,

Charles G
Linux Systems Administrator
HostGator.com LLC
http://support.hostgator.com

They even bumped it saying...

Hello,

It is unlikely that the GD library would be upgraded in shared server environment. The version on the server is the version released with CentOS 5, and in general packages on CentOS/RedHat do not get version upgrades until the next major operating system release.

Best regards,

James Boothe
Linux Systems Administrator
HostGator.com LLC
http://support.hostgator.com

Osbes

08-03-2011, 09:36 PM

Hello extreme-gaming,

delicious answer "fixing a security risk is not an option", so i will never use this hoster.

As a work around you can save all images with png 8-bit grey as png rgba color.

Best regards
Sebastian

final kaoss

08-03-2011, 09:40 PM

and how exactly am I supposed to do that... I have 4000 images, I need an automated solution if this this is the only work around.

Hello extreme-gaming,

delicious answer "fixing a security risk is not an option", so i will never use this hoster.

As a work around you can save all images with png 8-bit grey as png rgba color.

Best regards
Sebastian

Osbes

08-03-2011, 09:43 PM

Hello archet1337,

i will make an example for

.highslide-loading {
background-image: url(graphics/loader.white.gif);

If there isnt any additional padding, margin, width, ... via CSS, the code f?r the files-array is:

$files[] = array(
'path' => 'graphics/loader.white.gif',
'css' => 'graphics_loader_white',
'background' => true
);

After this, add to

class="highslide-loading ..."

the sprite class

class="sprite_custom_graphics_loader_white highslide-loading ..."

after this, remove the

background-image: url(graphics/loader.white.gif);

from the css-rule highslide-loading.

if the css-rule is now empty, you can of course erase the highslide-loading from

class="sprite_custom_graphics_loader_white highslide-loading ..."

Please note, that you need to use an own sprite-image if you want to use gradients.

Best regards
Sebastian

Mooff

08-03-2011, 09:44 PM

You clearly do not have 4000 8-bit grey images on your server.

Aside that won't fix your 'CDN' problem. All it does fix is pictures looking strange in the sprite (in most cases the attachment icon).

Osbes

08-03-2011, 09:48 PM

and how exactly am I supposed to do that... I have 4000 images, I need an automated solution if this this is the only work around.

Hello extreme-gaming,

have you this problem with every image? Since this is greyscale format you shouldnt have this issue with colored images, this would be weird/impossible.

I thought you have this problem just with a few images - like everyone else from who i know about this problem - so it would be possible to make it manually.

I didnt have a automatic solution for something like this at my hand (since image conversion is way beyond the scope of this addon), so i can just advise you to search for an solution (maybe based on a different image-library) and share it with us :)

Best regards
Sebastian

final kaoss

08-03-2011, 09:50 PM

Excuse me but you have no idea how many images I have, tyvm.

You clearly do not have 4000 8-bit grey images on your server.

Aside that won't fix your 'CDN' problem. All it does fix is pictures looking strange in the sprite (in most cases the attachment icon).

Osbes

08-03-2011, 09:52 PM

Hello extreme-gaming,

if you have the whole directory on a windows based system, you can use a gui with like ifranview with batch conversion to do this automaticlly.

Best regards
Sebastian

Mooff

08-03-2011, 09:53 PM

Oh come on, you do not have 4000 8-bit grey (http://en.wikipedia.org/wiki/Grayscale) images on your server.

Aside, you missed the important part of my post.

This won't fix your CDN problem. I won't. They are not related at all. Not. Nada. None.

edit: I fixed my post. Maybe you will see it now.
edit: dude, this is fun. I linked my fix. Maybe you can link me to show how you use 8-bit greyscale pictures to show colors. Or is your site some black, white and grey paradise?

final kaoss

08-03-2011, 09:56 PM

I'll say it again. You have no idea how many images I have, what I use them for etc and so on. You have no idea if and how I choose to modify my images.. You need to learn not to put your nose where it doesn't belong. Let's end this argument now.

edit: I fixed my post. Maybe you will see it now.

Oh come on, you do not have 4000 8-bit grey images on your server.

Aside, you missed the important part of my post.

This won't fix your CDN problem. I won't. They are not related at all. Not. Nada. None.

Osbes

08-03-2011, 10:06 PM

Just noticed in the 0.7.1 zip file, the product xml that is included in there is still 0.7.0a, or atleast the version id wasn't updated to reflect the new version.

the separate xml seems to be updated but I just downloaded the zip file since it includes both

Hello Crotan,

thanks for the notice. Fox told me this yesterday on vBGo, this should be fixed since then. I just checked it again, but it seems to be 0.7.1, so i assume that this is fixed.

Best regards
Sebastian

steeler7

08-03-2011, 10:50 PM

Hello steeler7,

i think you got a typo in your changes.

on your site it reads:



but the "1/" is wrong, it should read



So please remove the 1/

Best regards
Sebastian

The 1/ is my statusicon folder. I have a bunch of different status icons organized into seperate folders and in the Forums section, editing the Forums, I indicate what folder of Icons I want for that Forum with a XX/ .

Using Firebug it shows all of the missing Icons like you mentioned but with different numbers which are indicating the different folders those images sit in.

Thanks!

archet1337

08-04-2011, 04:00 AM

Hello archet1337,

i will make an example for

.highslide-loading {
background-image: url(graphics/loader.white.gif);

////////////

Best regards
Sebastian

Thank you! I will have a go at it when I get back from work.

Regards,
Archet

Osbes

08-04-2011, 04:47 AM

Hello steeler7,

if i understand you correctly you are using folders for the Prefix for Forum Status Images in the AdminCP?

Best regards
Sebastian

DragonByte Tech

08-04-2011, 04:48 AM

EDIT: Nevermind, the AdminCP file wasn't properly overwritten.

PS: the Settings link reads "Einstellungen" - pretty sure that's not English ;)

Fillip

Taurus1

08-04-2011, 10:25 AM

This looks fantastic. Before I commence with installation, just one thing please. I don't quite understand which template edits to do in the diffs file. All those in there? Or just the 2 for version 0.7.1?

Mooff

08-04-2011, 10:48 AM

All of them.

You need to edit every template where you want to use the sprite instead of images.
I would advise to install the TMS though, then the edits will be done during the install automatically. Manual editing takes some time since we support (not sure about the exact number) a huge load of pictures right now.

Taurus1

08-04-2011, 11:10 AM

Taurus1

08-04-2011, 11:23 AM

How long does it take to create the sprites? OK, I know I have a lot of skins installed, but it has been running for about 10 minutes now, and only 2 sprites have been created thus far.

Taurus1

08-04-2011, 11:57 AM

OK, I am getting the connection was reset error everytime I run the Refresh. It runs for about 20 minutes and then times out. Please advise.

Osbes

08-04-2011, 12:08 PM

Hello Taurus1,

i will change this in 0.7.2 so that he creates one sprites, than redirect to create antoher sprite and so one.

So it will be no problem for forums with a huge amount of styles :)

Best regards
Sebastian

Taurus1

08-04-2011, 12:14 PM

Thank you for the quick response Sebastian! So at this stage can I just continue hitting the refresh until all is done? And will it only create the contents of the templates when all sprites have been created? Because I see at this stage none of the templates has any contents in.
OH, and will this have an affect on my CND? Sorry for all the questions!

Taurus1

08-04-2011, 12:19 PM

OK, it seems to have finished now, but none of the css templates has any content inside, and now all my styles have no icons. What should I do now?? Please help!

Mooff

08-04-2011, 12:25 PM

There should be debug messages during sprite creation. Did any error show up there?

Please send us those messages.

Osbes

08-04-2011, 12:35 PM

This addon support CDNs since 0.6.2

After one sprite (and the rtl version) is created, it should fill the corresponding CSS file like sprite-main.css with content.

Just like Mooff said, please sead us the messages that are shown after the refresh of the sprites :)

Best regards
Sebastian

Taurus1

08-04-2011, 12:36 PM

There should be debug messages during sprite creation. Did any error show up there?

Please send us those messages.

There was no messages. When I clicked Refresh nothing actually showed, I could just see that something was going on, as it said 'Connecting' and it was circling on top of my browser. I could see the sprites being created on my server. But after about 20 minutes my ACP would just give me the time out error. I clicked the Refresh link again, and the same thing happened again. After doing it a third time, right at the end it did display a page with some info on, but I did not save or keep that unfortunately. My bad....sorry!:(
I disabled it for now, just to get my forum looking OK again.

sivaganeshk

08-04-2011, 01:31 PM

I have different images for statusicon (for categories), can this mod can convert it to css Sprites ??

my forum : collegers.net (guess sharing d link is allowed )

Mooff

08-04-2011, 01:39 PM

@Taurus1
I can't think of a reason why the debug won't show up. And without debug it is really hard to help, we would have to start guessing and probably won't guess right for a long time.

@sivaganeshk
seems like you are using the vb4 build in prefixes for forums. Our addon can handle that. We use that on our board as well (see livedemo on www.united-forum.de ).

steeler7

08-04-2011, 02:42 PM

Hello steeler7,

if i understand you correctly you are using folders for the Prefix for Forum Status Images in the AdminCP?

Best regards
Sebastian

Yes. Through the Forums & Moderators panel in the ADMIN CP is where I am placing the number prefix for each individual folder.

Thanks!

Taurus1

08-04-2011, 03:01 PM

I disabled the mod until we can figure out what is wrong. But now all my forum icons are still missing on my forumdisplay pages. Please help!

EDIT: Sorry that was a cache issue. All icons back now.

steeler7

08-04-2011, 03:39 PM

After looking around and such, I got the "/" removed by using an underscore. So now some folders (only did a couple for now to test) are "1_" and they read out just like yours do at your United-Forums board when I checked with Firebug. I ran the Sprite Refresh and Still no Icons are showing up.

Thanks!

FReeSTER

08-04-2011, 04:54 PM

this mod is great but it gave me a hard time. For some reason it HIDED must of the forum images.

So I Un-Install until I know how to fix it

thanks

Hello FReeSTER,

what exactly is your problem? i dont understand what you mean.

Best regards
Sebastianonce I installed the Mod after few hrs, I noticed that almost all the statusicons images were HIDE. They were like they never been there..... Once I un-install the Mod after an hr or 2 came back to normal.:confused:

Osbes

08-04-2011, 06:04 PM

Hello FReeSTER,

this is a weird behavior, have you look into it via firebug or something else?

I would assume that your cache played a trick on you. If you want me to look into it, please give a link were you are using sprites and have this kind of problem, then i can give you a solution :)

Best regards
Sebastian

Osbes

08-04-2011, 06:05 PM

steeler7

08-04-2011, 07:50 PM

Hello steeler7,

with 0.7.2 i will add a solution for you, so that it will work with using folders for the Prefix for Forum Status Images.

I will build it tomorrow or the day after it.

Best regards
Sebastian

I just ended up figuring it all out and making the fixes on my end. I took a while renaming a ton of files and such but I eliminated the folders all together and just renamed the Files after doing a search here at VB.org and stumbling upon how.

Thanks for the option! I'm sure that someone else might find it handy that was using the folder setup as I was.

I do however have one problem remaining. Fix one and another pops up :)

My Thread Icons are either showing up, not showing up or showing the entire sprite image. I think it's called a Thread Icon. Basically the icon next to the Thread Titles..

You can have a look here :

http://www.pittsburghsportstavern.com/forum/forumdisplay.php/7-Steelers-Talk

Osbes

08-04-2011, 07:58 PM

Hi steeler7,

you are missing these template-edits:

Template: threadlist.css
368d354
< background-position: {vb:stylevar padding} 4px;
376,394d361
< .threadbit .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_old-30.png); }
< .threadbit.dot .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot-30-{vb:stylevar right}.png); }
< .threadbit.dot.hot .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_hot-30-{vb:stylevar right}.png); }
< .threadbit.dot.hot.lock .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_hot_lock-30-{vb:stylevar right}.png); }
< .threadbit.dot.hot.lock.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_hot_lock_new-30-{vb:stylevar right}.png); }
< .threadbit.dot.hot.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_hot_new-30-{vb:stylevar right}.png); }
< .threadbit.dot.lock .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_lock-30-{vb:stylevar right}.png); }
< .threadbit.dot.lock.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_lock_new-30-{vb:stylevar right}.png); }
< .threadbit.dot.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_dot_new-30-{vb:stylevar right}.png); }
< .threadbit.hot .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_hot-30.png); }
< .threadbit.hot.lock .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_hot_lock-30.png); }
< .threadbit.hot.lock.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_hot_lock_new-30.png); }
< .threadbit.hot.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_hot_new-30.png); }
< .threadbit.lock .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_lock-30.png); }
< .threadbit.lock.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_lock_new-30.png); }
< .threadbit.moved .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_moved-30.png); }
< .threadbit.moved.new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_moved_new-30.png); }
< .new .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_new-30.png); }
396d362
< background: url({vb:stylevar imgdir_statusicon}/thread_deleted_30-{vb:stylevar right}.png) no-repeat {vb:stylevar padding} 4px;

These definitions overwrites the background-definition used by the sprites, thats why it isnt shown correctly. So please remove these definitons.

Best regards
Sebastian

Crotan

08-04-2011, 08:00 PM

disregard

fukdawrld

08-04-2011, 10:55 PM

I have 9 different skins most with different icons. I couldn't get this to work so i uninstalled. Now my icons are missing as well. I will pm you my info If you have time could you look into it? I would love to use this but I couldn't get it to work.

fukdawrld

08-05-2011, 12:05 AM

My icons came back after a while for all my skins. I would love to get this working though. I'll try again later.

Crotan

08-05-2011, 12:31 AM

My icons came back after a while for all my skins. I would love to get this working though. I'll try again later.

You should refresh the page after hitting refresh in the admincp for the mod, you saying after a while sounds like browser caching. It might have been working fine the whole time you just never reloaded the images.

F5

fukdawrld

08-05-2011, 01:47 AM

I did do that...I also cleared my cache and opened a new browser (opera) just to see. I'm not sure why it did that.

Thank u though.

FReeSTER

08-05-2011, 04:58 AM

Osbes

08-05-2011, 05:55 AM

Hi fukdawrld,

i send you a new pm, please inform me, when you have uploaded the files :)

Best regards
Sebastian

iask

08-05-2011, 06:16 AM

i use cdn

0 custom icons added.
0 imageprefixes for forums found.
Processing post icons.
14 post icons found.
116 icon candidates added.
/home/xxxxxx/domains/xxxxxxxxx/public_html/images/styles/ShinyBlue/statusicon/forum_new_lock-16.png (with bburl_path / ) does not exist or is not readable.
/home/xxxxx/domains/pctuts.be/public_html/images/styles/ShinyBlue/statusicon/forum_old_lock-16.png (with bburl_path / ) does not exist or is not readable.
/home/xxxxxx/domains/pctuts.be/public_html/images/styles/ShinyBlue/buttons/search_rtl.png (with bburl_path / ) does not exist or is not readable.
Starting with images/sprites/sprite-213-main.png.
91 icons added.
Creating sprite (width:1000px height:116px).
Sprite saved, updating css-rules.
Starting with images/sprites/sprite-213-main_rtl.png.
90 icons added.
Creating sprite (width:1000px height:116px).
Sprite saved, updating css-rules.
CSS template successfully updated.
Starting with images/sprites/sprite-213-forumdisplay.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-213-forumdisplay_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with images/sprites/sprite-213-forumhome.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-213-forumhome_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.
Starting with images/sprites/sprite-213-showthread.png.
0 icons added.
Sprite was not created.
Starting with images/sprites/sprite-213-showthread_rtl.png.
0 icons added.
Sprite was not created.
CSS template successfully updated.

Mooff

08-05-2011, 08:24 AM

Output does look fine.
Since you left your url in i checked the main sprite - and it does look fine aswell (aside the GD 2.0.35 version - guys please update, that version is 4 years old).
So what exactly is not working?
Did you do the required template changes?

stephen1976

08-05-2011, 10:16 AM

okay installed on 4.1.5 PL1

there is only one slight error the Paperclip icon on threads now appears a little odd ( i think it now stands out more! )

see pic

Mooff

08-05-2011, 10:27 AM

We will update the FAQ with that question soon. Really shocked it does affect so many servers.

If you have some image like

http://dl.dropbox.com/u/246391/Robin.png

which looks like

http://dl.dropbox.com/u/246391/Robin_result.png

in the Sprite (it is stretched and vertical lines are added), than you possible use a GD Libary older than 2.0.36.

GD had a problem handling grayscale images with alpha channel correctly, wich was fixed with GD 2.0.36 in the Year 2007.

https://bitbucket.org/pierrejoye/gd-libgd/src/733361a31aab/NEWS

The solution is to update the GD-Libary to 2.0.36 (or later) or replace every file which uses "gray+alpha" with an version using "color RGBA".

I would advise to update the GD-Libary, cause there is also a serious security problem, that was fixed in the Year 2009 by Debian.

I am totally shocked by this, since there seem to be a whole bunch of people with this kind of problem and this fix is 4 years old and since 2 years known als high security fix by debian.
So there seems to be a lot problem within the maintenance of servers, if some serious security issue isnt solved since 2-4 years. If you pay money for server maintenance i would be deeply shocked, if i were you.

Best regards
Sebastian

Crotan

08-05-2011, 02:00 PM

We will update the FAQ with that question soon. Really shocked it does affect so many servers.

I'm not, most hosts get by on the bare minimums, overloading shared hosting boxes and the like. Having 4 year outdated image libraries with a security hole sounds just right.

sadiq6210

08-05-2011, 02:32 PM

Could you explain this step more?

upon installation a new stylevar imgdir_sprite will be created. Update this stylevar based on your file structure - default value is the vbulletin sprite directory. Make sure the folder is writable, else the sprites can't be saved!

Crotan

08-05-2011, 04:11 PM

Could you explain this step more?

Look in the style Manager in the admincp, installing this mod will create a new stylevar named "imgdir_sprite" Make sure the folder is chmod 755, is what it means by make sure it's writable so that vbulletin can save the new sprite images it creates.

giorgino

08-05-2011, 10:22 PM

One strange issue: "Moved" topic hasn't icons

Osbes

08-05-2011, 11:41 PM

Hello,

version 0.7.2 is currently running on our liveforum. If nothing wrong happens, i will release it tomorrow.

Best regards
Sebastian

fukdawrld

08-05-2011, 11:58 PM

Thanks for all your help. It built the sprites.

Osbes

08-06-2011, 12:03 AM

Hello giorgino,

thanks for the info, i missed to integrate the following template change within the TMS rules.

Template: threadlist.css
< .threadbit.moved .threadstatus { background-image: url({vb:stylevar imgdir_statusicon}/thread_moved-30.png); }

I have integrated it to 0.7.2.

If you didnt want to wait, you can remove the css-rule .threadbit.moved .threadstatusfrom within the template threadlist.css manually.

Best regards
Sebastian