PDA

View Full Version : Combining CSS using minify and delivering using if/elseif isn't working


Abhik
06-21-2010, 10:21 AM
Hello,
I am using Minify (http://code.google.com/p/minify/) to combining the CSS files and delivering it with if/elseif conditions.. The index is working fine, but the other's is not.

Please tell me where I am doing wrong

1. I am storing CSS as files in filesystem

2. Replacing the code at headerinclude template

<vb:if condition="$vboptions['storecssasfile']">
{vb:cssfile main-rollup.css}
{vb:raw template_hook.custom_css_links}
<vb:else />
{vb:cssfile bbcode.css,editor.css,popupmenu.css,reset-fonts.css,vbulletin.css,vbulletin-chrome.css,vbulletin-formcontrols.css{vb:raw template_hook.custom_css_list}}
</vb:if>with

<vb:if condition="$vboptions['storecssasfile']">
<vb:if condition="THIS_SCRIPT == 'index'"><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumhome-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'forumdisplay'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumdisplay-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'showthread'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,showthread-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'usercp' AND THIS_SCRIPT == 'private' AND THIS_SCRIPT == 'member'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,usercp-rollup.css,datepicker.css,private.css,additional.c ss,postbit.css,usercp-rollup.css,memberinfo-rollup.css" />

<vb:elseif condition="THIS_SCRIPT == 'newreply'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,reviewpost.css,attachmen t.css" />

<vb:elseif condition="THIS_SCRIPT == 'group'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,socialgroups.css,socialg roups_overview.css" />

<vb:else />
{vb:cssfile main-rollup.css}
{vb:raw template_hook.custom_css_links}

</vb:if>
</vb:if>Only the index is working, but the other elseif conditions isn't working. When I enter the combined CSS link in browser, it's loading though.

TIA

BTW, at 4.0.3, I had this in headerinclude template to call the CSS. But, in 4.0.4, it's changed a bit.
<vb:if condition="$vboptions['storecssasfile']">
<link rel="stylesheet" type="text/css" href="{vb:raw vbcsspath}main-rollup.css" />
{vb:raw template_hook.custom_css_links}
<vb:else />
<link rel="stylesheet" type="text/css" href="{vb:raw vbcsspath}bbcode.css,editor.css,popupmenu.css,rese t-fonts.css,vbulletin.css,vbulletin-chrome.css,vbulletin-formcontrols.css{vb:raw template_hook.custom_css_list}" />
</vb:if>

ChopSuey
06-21-2010, 10:22 AM
Just store CSS as files, much better imo.

Abhik
06-21-2010, 10:28 AM
I am already doing that, just to tell you if you haven't read the post properly.
What I am trying is to combine them. That's all

ChopSuey
06-21-2010, 02:56 PM
They're not working because you didn't close all the IF Conditions.

Abhik
06-21-2010, 04:54 PM
Aah!! Okay..
So, what should I do to close them properly?

ChopSuey
06-21-2010, 04:59 PM
Close every single one of them.

DragonBlade
06-21-2010, 08:49 PM
They are closed properly

Debug your if statements by putting some strings and see what happens.

ChopSuey
06-23-2010, 01:08 PM
He needs to close 5 more tags.

Abhik
06-23-2010, 02:21 PM
He needs to close 5 more tags.

So, you mean, this should be..?

<vb:if condition="$vboptions['storecssasfile']">
<vb:if condition="THIS_SCRIPT == 'index'"><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumhome-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'forumdisplay'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumdisplay-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'showthread'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,showthread-rollup.css,additional.css" />

<vb:elseif condition="THIS_SCRIPT == 'usercp' AND THIS_SCRIPT == 'private' AND THIS_SCRIPT == 'member'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,usercp-rollup.css,datepicker.css,private.css,additional.c ss,postbit.css,usercp-rollup.css,memberinfo-rollup.css" />

<vb:elseif condition="THIS_SCRIPT == 'newreply'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,reviewpost.css,attachmen t.css" />

<vb:elseif condition="THIS_SCRIPT == 'group'" /><link rel="stylesheet" type="text/css" href="{vb:raw vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,socialgroups.css,socialg roups_overview.css" />

<vb:else />
{vb:cssfile main-rollup.css}
{vb:raw template_hook.custom_css_links}

</vb:if>
</vb:if>
</vb:if>
</vb:if>
</vb:if>
</vb:if>
</vb:if>

ChopSuey
06-23-2010, 03:01 PM
Yes sir.