PDA

View Full Version : Impossible to validate hackpage because of footer


derfelix
01-24-2010, 06:17 AM
Hello everybody.

I have a hackpage that shows stuff by a user..
works fine...
but the page wont validate because of..... footer... :confused:
the url of the hackpage is:
http / /:myhost.com/forums/myhack.php?u=1&i=1

The problem is, in footer there is a link : TOP
Now thislink is constructed in template:
<a href="{vb:raw relpath}#top" onclick="document.location.hash='top'; return false;">{vb:rawphrase top}</a>
I checked $relpath and thats the problem.. the output is as expected:
http / /:myhost.com/forums/myhack.php?u=1&i=1
instead of :
http / /:myhost.com/forums/myhack.php?u=1&amp;i=1
so the page will not validate...

$relpath is generated in class core, around line 3985. I looked everywhere.. no hook even near that place....

This would meen, that any page having a &amp; in the url will NOT validate?? -- I cant believe that.. so I must be doing something wrong...

So my question is:.. is this a bug.. or am I doing something wrong..

F.

PS:
I get around 9 validation errors with http:/ /validator.w3.org..
all with stuff like:
# Error Line 1854, Column 167: reference to entity "i" for which no system identifier could be generated

…b5suite/showimage.php?u=1&i=2"

This is usually a cascading error caused by a an undefined entity reference or use of an unencoded ampersand (&) in an URL or body text. See the previous message for further details.

if i check the page without the i=2 (defining $i=2; in php code to get the same output..)
it validates fine...

Lynne
01-24-2010, 03:11 PM
Questions regarding default vBulletin 4 should be asked on the vBulletin.com forums. See this sticky - Installation Issues / Questions or bug reports regarding default vBulletin 4.0 (https://vborg.vbsupport.ru/showthread.php?t=228035)

If you are wondering if something is a bug - vb.com is the place to look and ask about it, not here.

derfelix
01-24-2010, 04:51 PM
I know lynn
But you also know that if i tell them about my hack.. they will send me here..

Lynne
01-24-2010, 05:01 PM
Have you tried using {vb:var xxx} instead of {vb:raw xxx} ?

derfelix
01-24-2010, 05:27 PM
You are a genius, Lynn!! It works great..
<a href="{vb:var relpath}#top" onclick="document.location.hash='top'; return false;">{vb:rawphrase top}</a>
I changed footer template for the top link.. and it show the &amp; And.. the page now validates...
Now one last question... How to pursuade vbulletin to make that change...??
Because if you use seo urls, you wont need it..
I didnt see urls that need 2 get parameters anywhere..
So posting a bug report will give me the answer.. working as designed..