PDA

View Full Version : Board Optimization - vB4 SuperCharged - Optimises CSS, Javascript and HTML


Pages : [1] 2 3

Darkimmortal
12-05-2009, 10:00 PM
This is designed for vBulletin 4.0.x only.

DO NOT INSTALL on vB 4.1.x or 4.2.x.

Even if it worked correctly, the effect is negligible as vB4 is nowhere near as terrible client-side speed-wise as it once was.

DO NOT ask for fixes, they will not come, I have moved to XenForo.


__________________________________________________ ______________


tl;dr - Significant frontend speed improvements for vBulletin 4

Don't forget to Mark as Installed if you use this mod, and a nomination for MOTM would be nice :)

__________________________________________________ ______________


Features:


CSS Optimiser: Minifies all CSS files and serves CSS directly, eliminating the PHP overhead from css.php.

Javascript Optimiser: Intelligently defers Javascript loading (puts script tags just before </body> on the fly) and combines common Javascript files. Also features optional compression with Google Closure Compiler.

HTML Optimiser: Based on HELLCAT's Realtime Page Compressor (https://vborg.vbsupport.ru/showthread.php?t=106333), and adds complete whitespace removal around block and meta elements and removal of unimportant comments.

Attachment Optimiser: Intended for FastCGI users only - serves attachment thumbnails and images directly rather than through PHP.

All this is done efficiently and on-the-fly - no need for any template edits.

__________________________________________________ ______________


Installation:
Ensure you have CSS stored on the filesystem and not your database. To check this, go to Settings > Options > Style & Language Settings > Store CSS Stylesheets as Files? and ensure it is set to "Yes".
Disable Remote YUI if you have it enabled. To check this, go to Settings > Options > Server Settings and Optimization Options > Use Remote YUI and ensure it is set to "None".
Upload the contents of vbsc.zip to your forum root directory via FTP.
Ensure the files vbsc.js and vbsc.js.gz in /clientscript/ are writable (chmod).
Install product-vbsc.xml as a Product. (Plugins & Products > Manage Products > Add/Import Product)
Run Compress Javascript and Compress CSS under the vB4: SuperCharged Admin CP section.
Check to ensure that all the settings are correct for your forum, as some of the optimisers are likely to conflict with other poorly coded mods, and not all are turned on by default (vB4: SuperCharged > Options)._________________________________________ _______________________


Conflicts:
If you wish to run vBSEO along with the Attachment Optimiser, you must disable Attachment Rewrites under URL Rewrite Settings > Forum URLs. This incompatibility is by design.
If you run vBSEO's Cleanup HTML function, you should choose between it and vBSC's HTML Optimiser. Running both at once is a waste of resources and may create conflicts that would not otherwise exist.____________________________________________ ____________________


Upgrading:
Upload the contents of vbsc.zip to your forum root via FTP. (Overwrite the existing files.)
Install the new product-vbsc.xml, ensuring you have Allow Overwrite set to Yes. (Plugins & Products > Manage Products > Add/Import Product)
Run Compress Javascript and Compress CSS under the vB4: SuperCharged Admin CP section.__________________________________________ ______________________


Changelog:


1.51:

A minor, optional update involving product-vbsc.xml only.
Fixed conflict between vBSC, vBSEO and certain language/template customisations which prevented the PM notifications from opening a new window when requested.1.5:

Several changes made to various files - don't forget vbsc.zip when updating.
The Javascript Optimiser will now function properly without the Common Javascript Cache enabled, for those of you more concerned about download size than http requests ;)
As I've found disabling the Common Javascript Cache can take 500ms off the rendering time in Firefox, it is no longer enabled by default.
Fixed Facebook Connect.
Fixed compatibility with certain types of Adsense ads
Fixed loadvBCss inline javascript calls being incorrectly left alone, screwing up nested CMS Sections among other things.
Fixed the removal of the space between "by" and the username in the last post column with the HTML optimiser enabled.
Restored modification date check on vbsc.js1.4:

Several changes made to various files - don't forget vbsc.zip when updating.
Google Closure Compiler appears to be working again, so you can re-enable that.
Fixed error spam and even fatal errors when importing products, possibly at the expense of compatibility with YAFB, but who needs that now anyway?
Improved inline Javascript regexes, fixing several VSa mods, and probably others too.
Improved descriptions of some settings.
HTML Optimiser is no longer on by default (it's pretty resource heavy and pointless).
Fixed hard-coded /admincp/ reference in the CSS Auto-Compress hook.1.3:
Several changes made to vbsc.php - don't forget vbsc.zip when updating.
Disable Google Closure Compiler if you have it enabled as it no longer works and I'm not sure why yet.
The CSS optimiser now overwrites the existing CSS files with the minified equivalents, reducing the amount of regex guesswork needed.
Fixed error appearing on the login page with the CSS optimiser enabled.
Tested with [AJAX] - Advanced Forum Statistics (https://vborg.vbsupport.ru/showthread.php?t=232811)1.2:

Changes made to various files - don't forget vbsc.zip when updating.
Added Advanced Attachment Optimiser for img tags (skips attachment.php altogether rather than simply adding a redirect) and improved the original one (designed to be run together).
The DIR constant is now used throughout vBSC.
Fixed style00000 bug on redirect pages - now defaults to style id 1.
Fixed strange bug in the CSS Optimiser where in some circumstances, css.php style URLs (with commas) would be used in direct links, breaking everything.
Removed a pretty pointless check on the modification date of vbsc.js (due to issues). You'd have to be an idiot not to run compress css/js after updating vBulletin :P1.1:

Changes made to various files - don't forget vbsc.zip when updating.
No longer works on vBulletin 4.0.0 - supports 4.0.1 only.
Removed common css cache - vBulletin's new "-rollup" system only results in a couple of extra requests and less conflicts.
Added support for new LTR/RTL vbulletin_css folders to all elements of the CSS Optimiser.
Improved support for obscure ways of including CSS that some mods may use.
Fixed unnecessary errors when some Javascript files are not present.
The appropriate DIR constant is now used when including vbsc_global.php, hopefully fixing the invalid argument supplied for foreach() error.
Fixed bug in Compress Javascript for forum-only vBulletin - file_get_contents(./clientscript/).
Fixed CSS Optimiser incompatibility with Yay! Another Facebook Bridge (https://vborg.vbsupport.ru/showthread.php?t=232457), which for some reason breaks write_style_css_directory().
CSS Optimiser now uses write_style_css_directory() rather than the full build_style() function.1.01:
Changes made to various files - don't forget vbsc.zip when updating.
Fixed compatibility with child styles.
Improved Javascript and CSS Optimiser error messages.1.0:

Changes made to various files - don't forget vbsc.zip when updating.
Fixed bug in the Javascript Optimiser where the type attribute was required on a script tag - some mods leave this out or put it after src.
The monolithic vbsc.js file is now optional, although enabled by default (under the setting Common Javascript Cache). Many people's problems seem to be related to it, and there isn't much difference without it, as long as the loading deferral is still there.
The CSS files showthread.css, postbit-lite.css, postbit.css and forumdisplay.css are no longer included in the common CSS cache. This fixes a conflict with Abe1's Post Thank You Hack (https://vborg.vbsupport.ru/showthread.php?t=231666), along with other incompatibilities. The vBSC CSS hacks that were necessary due to conflicting rules in these files have also been removed.
The CSS Files and JS Files settings, along with some other things, have been moved to includes/vbsc_global.php. Due to this, uninstalling before upgrading is no longer strictly necessary.
Greatly improved the details given by the Javascript Optimiser fallback warning and steps to take to get it to disappear for people having issues.
Fixed compatibility with the Forum-only version of vBulletin.
Added some Blog files to the common Javascript cache.
vBSC will now detect if you have the CMS or Blog products disabled and skip caching their Javascript files as necessary.
Improved descriptions of admin settings.0.92:
Fixed bug in the JS Optimiser causing bits of HTML comments to be visible at the bottom of the page under certain circumstances.
Worked around a stupid bug in Latest Posts and Newest Members on Forum Home (https://vborg.vbsupport.ru/showthread.php?t=231098) which somehow doesn't occur during normal operation and only when the HTML is messed with by the HTML optimiser. In other words, not my fault :p0.91:
Fixed(?) rare issue where reCaptcha would fail to appear with JS Optimiser enabled.0.9:
Changes made to vbsc.php - don't forget vbsc.zip when updating.
Added "vbseo" to the inline Javascript whitelist.
Fixed compatibility with ibProArcade (https://vborg.vbsupport.ru/showthread.php?t=229595) and any other mods which utilise the css_start hook to add additional CSS.
Fixed message about Compress CSS always appearing on certain CMS pages. If the styleid from cms_node is not found, it defaults silently to the board default style, just as vBulletin itself does.
Fixed compatibility with Flashchat 6 Integration (https://vborg.vbsupport.ru/showthread.php?t=231184) and any other mod which uses shorthand css.php URLs.
Fixed display of topic review with the CSS optimiser enabled.
Fixed lack of spaces between usernames in various places.0.82:
Fixed specific issue where the domain name was included before the YUI reset-fonts.css url, causing it to end up included after vbsc.css and screw things up.0.81:
Fixed CSS optimiser not supporting style IDs of > 9.
Fixed CSS optimiser not working on some redirection pages, especially after login.0.8:
Changes made to vbsc.php - don't forget vbsc.zip when updating.
Added warning if CSS and/or Javascript are not cached correctly, and it now falls back to the normal CSS/JS rather than messing everything up if they aren't.
Fixed user style selection not being considered with the CSS Optimiser enabled.
Compress CSS now grabs the styles from the database and performs the equivalent rebuilding process to saving a stylevar automatically. This is likely to fix a lot of people's issues :)
Added a whitelist of various vB-related terms to the inline Javascript optimiser, hopefully fixing issues with Google Custom Search and ad providers other than Google (which was previously blacklisted).
Fixed broken posting permissions box on newthread/postreply with the CSS Optimiser enabled.
Fixed automatic CSS compression 404'ing when running the vB upgrade script.
Completely changed how automatic CSS compression is run, resulting in a smoother experience free of iframes. It also only runs once regardless of how many styles you have.
Fixed incompatibility with BBR - Resize Images with lytebox (https://vborg.vbsupport.ru/showthread.php?t=230411), and probably other mods.
Tested compatibility with GCBOS (https://vborg.vbsupport.ru/showthread.php?t=228046) 0.6.10.0.7:
Changes made to vbsc.php - don't forget vbsc.zip when updating.
Fixed CMS sections widget not working with JS Optimiser enabled. The fix for this will probably also fix other YUI-related issues.
Fixed visitor messages being too wide with CSS Optimiser enabled.0.6:
Several changes made to vbsc.php - don't forget vbsc.zip when updating.
Added a number of additional Javascript and CSS files - please uninstall vBSC before installing 0.6.
Compress JS now makes a small modification to the actual code to workaround a bug which can break a lot of things (most notably inlinemod) and generally screw things up.
Fixed links to compressed code in the admin cp.
Fixed /clientscript/ -> clientscript/ in the JS optimiser.
Closure Compiler is now optional, and defaults to off because it really provides little gain other than download size and takes ages to run. Standard JSMin is now the default form of compression.
Added error messages for both compressors.
Fixed vbulletin_textedit.js not being filtered out properly due to nearby HTML comments.
Tested compatibility with GCBOS and additional_css mods.0.5:
Fixed any prefix to css.php not being removed properly and being displayed as text in the header.0.4:
Fixed references to /clientscript/ instead of clientscript/, which broke support for forums not running in the root of a domain.
Fixed incompatibility with new css.php URLs in RC2.
Fixed conditional comments around IE Javascript being removed.
Fixed weird inlinemod issue.
Added popuplist.css - please uninstall before upgrading or add this to your CSS Files list manually.
Fixed incompatibility with Google Adsense. Fixes for other ad providers and other inline Javascript will be added on request.0.3:
Added HTML Optimiser
Fixed @charset spam in vbsc.css
Fixed vbsc_ files not being used due to a regression during release.
cpnav_vbsc.xml was accidentally left out in 0.2 :P
CSS is now automatically compressed when the files are updated through the StyleVar system, or otherwise. This also fixes the random deletion of vbsc.css and other vbsc_ css files.0.2:
Added JS optimiser_________________________________________ _______________________

ONLY if you wish to use the Attachment Optimiser, something similar to this is needed in your server config (nginx):

location /customattachments {
if ($request_uri ~* \.(png)) {
add_header Content-Type image/png;
}
if ($request_uri ~* \.(jpg|jpeg)) {
add_header Content-Type image/jpeg;
}
if ($request_uri ~* \.(gif)) {
add_header Content-Type image/gif;
}
} (although some browsers will probably be happy enough without these headers)

Brandon Sheley
12-06-2009, 04:47 AM
I like anything with "optimizer" in the title :)

SİMAR
12-06-2009, 02:01 PM
thanks

AzzidReign
12-07-2009, 01:42 AM
I'll be installing this when vb4 goes gold :)

Tom Kagan
12-08-2009, 05:30 PM
While this does eliminate the execution of the php code which generates the correct stylesheet sets, I can't see how this improves the user experience. The number of individual http requests is greatly expanded. This goes against a rule of thumb for web design "best practices".

Darkimmortal
12-08-2009, 06:09 PM
Say you've got 3 FastCGI processes and 5 stylesheets included via css.php. Assuming none of those FastCGI processes are busy handling requests, it will take theoretically as much as twice as long for anything to render, and from a load perspective, one user will become six (not counting cache)

I'll be adding concatenation shortly for both CSS and Javascript soon :)

abdobasha2004
12-09-2009, 10:16 AM
does this work for vb 3.7?

Tom Kagan
12-09-2009, 11:56 AM
It's already designed to concatenate the css. I know you'll stop using the FastCGI, but big deal - studies show the bigger problem for the user is the latency involved with multiple HTTP requests. I can only see this as "optimzation" if your server sucks and you care more about the server load stats than the latency of the user experience. Besides, since the css is essentially static, set your "expires" header properly on css output and a pageload will only hit the server once with the original code.

Darkimmortal
12-09-2009, 01:59 PM
Hugely improved version coming in a few hours :D

Also, multiple http requests = bad, multiple http requests where at least one can't complete until the others do = worse. It's not the server I'm concerned about ;)

Darkimmortal
12-10-2009, 12:49 AM
Annnnd... done :)

Feels good to have pages loading in a fraction of a second and being immediately responsive :D

And ~2 second loads from an unprimed cache.

dacho
12-10-2009, 11:36 AM
Sounds very interesting, I'll try it later
Thanks

Skyrider
12-10-2009, 04:10 PM
Makes me wonder why vBulletin 4 doesn't has these features build in of what this plugin has to offer.

kall
12-10-2009, 06:42 PM
Should there be an xml/bitfield file in there somewhere?

I'm guessing that you didn't really intend for people to have to figure out to add ?c=css and c=.js to the end of vbsc.php. :)

Darkimmortal
12-10-2009, 06:59 PM
Should there be an xml/bitfield file in there somewhere?

I'm guessing that you didn't really intend for people to have to figure out to add ?c=css and c=.js to the end of vbsc.php. :)

My bad, forgot to include that :P

Also I'll be releasing 0.3 shortly :)

Delilahs
12-10-2009, 07:10 PM
how long until 0.3 Darkimmortal?

Darkimmortal
12-10-2009, 07:18 PM
0.3 released :)

haothiencz
12-10-2009, 07:44 PM
I wonder if it works in Vb.3.8.x since it doesnt take any effect to file system rite? This mod looks very promising

Darkimmortal
12-10-2009, 09:26 PM
The HTML and JS optimisers definitely would, CSS optimiser is a bit less likely to. But then again, CSS is used so little in 3.8 that it doesn't really matter.

Of course you'd need to update the Javascript file list to contain only the files used in 3.8. And not all of them - only the common ones.

pein87
12-10-2009, 11:06 PM
So this would work with vbulletin 3.8.x? Whats the difference in performance then vboptimizer?

LPH2004
12-10-2009, 11:19 PM
Excellent job. Installed on www.harrypotterchat.org and the site doesn't feel so sluggish.

Delifed
12-10-2009, 11:27 PM
Hmm get one error. When compressing javascript

\
Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin_cms.js in [path]/admincp/vbsc.php on line 45


using vbulletin beta 5

kall
12-11-2009, 02:03 AM
It seems to be eating my css and js - I'm left with an odd www.domain.com in the top of the header, (js-related, turning that off removes it) and it's doing some strange things to my header layout class (because turning off css fixes that).

Most likely it's my bad, but I can't debug it properly till tomorrow. :(

Darkimmortal
12-11-2009, 02:23 PM
So this would work with vbulletin 3.8.x? Whats the difference in performance then vboptimizer?

If vboptimizer is the mod I'm thinking of, all it does is internal enhancements - queries, template caching etc. vB4:SC does a totally different thing and they should work just fine along side each other.

Hmm get one error. When compressing javascript

\
Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin_cms.js in [path]/admincp/vbsc.php on line 45


using vbulletin beta 5

Ah you must not have the full publishing suite then. You can probably ignore that error and I'll add file detection in 0.4 :)

It seems to be eating my css and js - I'm left with an odd www.domain.com in the top of the header, (js-related, turning that off removes it) and it's doing some strange things to my header layout class (because turning off css fixes that).

Most likely it's my bad, but I can't debug it properly till tomorrow. :(

Can you link me to your site?

slackin-jer
12-11-2009, 02:45 PM
My style doesn't work after installing this product...

http://www.balancecommunity.com/forum/forum.php

Darkimmortal
12-11-2009, 02:56 PM
You have to run Compress CSS and Compress JS ;)

I'll add install code to do that automatically in 0.4. :)

slackin-jer
12-11-2009, 03:11 PM
I did run Compress CSS and Compress JS but I still have the styling issues

Darkimmortal
12-11-2009, 03:14 PM
Oh you run from /forum/, I never built it to handle that :P

http://www.balancecommunity.com/forum/clientscript/vbulletin_css/style00001/vbsc.css

As you can see it's generated fine, but the URL is wrong. I'll be releasing 0.4 shortly with a fix :)

kall
12-11-2009, 04:43 PM
Could it be that my issue's being caused by the adsense js getting affected?

http://www.nzboards.com is the site in question. The style with adsense in the advertising templates has the issues.

Kayden
12-11-2009, 04:51 PM
Decent mod. I'll be waiting until it's more "friendly" with vB 4.0, though. :)

Darkimmortal
12-11-2009, 06:50 PM
Could it be that my issue's being caused by the adsense js getting affected?

http://www.nzboards.com is the site in question. The style with adsense in the advertising templates has the issues.

Try disabling remote YUI

Decent mod. I'll be waiting until it's more "friendly" with vB 4.0, though.

Can you be more specific? :P

kall
12-11-2009, 07:10 PM
Try disabling remote YUI
No joy, still exactly the same. :(

JVCode
12-11-2009, 09:32 PM
I'm having the same problems as kall. Followed the 'Install' instructions to the T.

Darkimmortal
12-12-2009, 04:03 AM
0.4 will be released tomorrow - RC2 broke a lot of stuff.

Tom Kagan
12-12-2009, 01:37 PM
Just as a mention: my original comments were based off of the 0.1 version. Since I did not examine the code but was going off of an example of what this mod does which darkimortal originally had in the OP, I suspect he had inadvertenly reversed his example which he later removed. It's a moot point now. However, I did want to make it clear that, when this mod is complete, it intends to make the optimizations which are considered best practice for external css and js handling.

Darkimmortal
12-13-2009, 01:18 AM
I'm having the same problems as kall. Followed the 'Install' instructions to the T.

0.4 includes fixes for Adsense - let me know if that helps :)

And @all - don't forget to add popuplist.css to your CSS Files list, or uninstall the product before upgrading.

kall
12-13-2009, 02:22 AM
It sure did fix the adsense issue. :D

When I enable css compression though, I still get the weird http://www.nzboards.com/ in the top of the header. :S

kall
12-13-2009, 02:27 AM
Umm. Where's this new .css supposed to be found? I can't see any templates in the product xml..

Darkimmortal
12-13-2009, 06:14 AM
No I mean vBulletin RC2 added it on pretty much every page so it's worth compressing in the cache:

https://vborg.vbsupport.ru/external/2009/12/35.png

Also now that I've seen where that nzboards in the header is in the code, would you mind turning CSS compression off so I can see what's causing it?

kall
12-13-2009, 07:32 AM
Ohh. Silly me. :)

Yup, if you mean 'Enable CSS Optimiser' = No, done.

abroad
12-13-2009, 08:13 AM
this messed up my whole site. I have RC2

kall
12-13-2009, 03:35 PM
this messed up my whole site. I have RC2
You might want to be more specific as to what the problem is.

Darkimmortal
12-13-2009, 03:47 PM
this messed up my whole site. I have RC2

Either give me the link to your site with it like that, or if you can't leave it like that, send the the HTML source in a PM.

Did you definitely run compress css and js after installing?


Also kall, see if 0.5 works for you now :)

RadioErewan
12-13-2009, 11:13 PM
Destroys a lot of links. Wrong CSS cached. Popups disappeared. Unable to log out. Unisntalled. (RC2)

Darkimmortal
12-14-2009, 12:19 AM
http://images.loqu.com/photos/252/125/you-re-doing-it-wrong.jpg

I can't debug what I can't see, nor do I have any problems even on my modded installation.

Also did you check the contents of /clientscript/vbsc.js and /clientscript/vbulletin_css/style-whatever/vbsc.css?

SnakeV
12-14-2009, 12:41 AM
When i have this plugin enabled with JS, CSS and HTML optimizer the moderation tools don't work.

For example if i select a message with the checkbox at the top corner right of the message it don't select the message.

Also the vbsc.js is being replaced incorrectly, it's being replaced with this:
<script type="text/javascript" src="/clientscript/vbsc.js"></script>

When it should be without the slash:
<script type="text/javascript" src="clientscript/vbsc.js"></script>

Thanks.

Darkimmortal
12-14-2009, 12:53 AM
When i have this plugin enabled with JS, CSS and HTML optimizer the moderation tools don't work.

For example if i select a message with the checkbox at the top corner right of the message it don't select the message.

Also the vbsc.js is being replaced incorrectly, it's being replaced with this:
<script type="text/javascript" src="/clientscript/vbsc.js"></script>

When it should be without the slash:
<script type="text/javascript" src="clientscript/vbsc.js"></script>

Thanks.

Yeah I'm able to reproduce that, seems to only happen when the page is loaded via a link rather than refresh though, which is pretty weird.

yahooooh
12-14-2009, 01:22 AM
could you release it for 3.8

LPH2004
12-14-2009, 03:32 AM
I'm having trouble with the latest 0.5 release (had it with 0.4 too) and RC2.

The pull down menus from the navigation bar become text. The chatbox stops working.

If I disable javascript and css compression then the site runs fine (leaves html optimization).

I've disabled the plugin, uninstalled it, reinstalled it, reuploaded files.

I've attached a disabled and enabled image to help.

kall
12-14-2009, 04:35 PM
Also kall, see if 0.5 works for you now :)
It does.. well, the issues I reported are gone, but now js compression is adding a little --> before my vBSEO copyright in the footer.

I can actually live with that though. ;)

Darkimmortal
12-14-2009, 07:32 PM
I'm having trouble with the latest 0.5 release (had it with 0.4 too) and RC2.

The pull down menus from the navigation bar become text. The chatbox stops working.

If I disable javascript and css compression then the site runs fine (leaves html optimization).

I've disabled the plugin, uninstalled it, reinstalled it, reuploaded files.

I've attached a disabled and enabled image to help.

I've tested 0.6 specifically with the GCBOS mod - let me know if it works for you :)

ArtAttack
12-14-2009, 08:31 PM
The css optimizer breaks visitor messages for me. The message boxes go past the forum width.

Darkimmortal
12-15-2009, 02:52 PM
The css optimizer breaks visitor messages for me. The message boxes go past the forum width.

Yup I can reproduce that - will fix for 0.7 :)

Darkimmortal
12-16-2009, 04:05 PM
Anyone having issues with vB4 turning RTL after upgrading to RC4 might want to check this out: http://www.vbulletin.com/forum/showthread.php?331287-RC4-made-all-my-pages-go-RTL-again

tl;dr - save any stylevar and it will work again.

Bounce
12-16-2009, 07:46 PM
Anyone having issues with vB4 turning RTL after upgrading to RC4 might want to check this out: http://www.vbulletin.com/forum/showthread.php?331287-RC4-made-all-my-pages-go-RTL-again

tl;dr - save any stylevar and it will work again.

yip, my style went pete tong :eek:

Saving a stylevar indeed fixed it

I notice if you have this hack enabled on upgrade the install can't find

install/vbsc.php :erm: I realise its not supposed to be in the install folder, just saying lol

Darkimmortal
12-16-2009, 08:58 PM
yip, my style went pete tong :eek:

Saving a stylevar indeed fixed it

I notice if you have this hack enabled on upgrade the install can't find

install/vbsc.php :erm: I realise its not supposed to be in the install folder, just saying lol

Yup I noticed that too - I think I'll hold off on fixing it until they implement this hook (http://www.vbulletin.com/forum/showthread.php?327316-Hook-Location-Requests&p=1866877&viewfull=1#post1866877) though :)

MarkJW
12-16-2009, 10:14 PM
Not sure if it's due to this mod, but after upgrading from Beta 4 to RC2 and installing this mod, none of attachments work. When I click on them, they take me to "attachment.php?.jpg". The image was a JPG, and the link seems to be correct. Does vB4: Supercharged change how attachment.php works? I've disabled Attachment Optimization and even disabled the entire mod, but nothing changes, so I'm pretty sure it's RC2, but I just wanted to make sure.

Darkimmortal
12-16-2009, 10:22 PM
Not sure if it's due to this mod, but after upgrading from Beta 4 to RC2 and installing this mod, none of attachments work. When I click on them, they take me to "attachment.php?.jpg". The image was a JPG, and the link seems to be correct. Does vB4: Supercharged change how attachment.php works? I've disabled Attachment Optimization and even disabled the entire mod, but nothing changes, so I'm pretty sure it's RC2, but I just wanted to make sure.

Try disabling Attachment Optimiser in the Plugin Manager - if that doesn't help then it almost certainly isn't being caused by vB4:SC.

EDIT: Wait, you've disabled the entire mod? Maybe it's a bug in vBulletin itself then :/

You could try turning attachment optimiser on as a workaround. :P


EDIT 2: Just checked and my attachments are still working fine, this is on RC4 though with Attachment Optimiser enabled (because I need it :P). And I don't think they were broken on RC2 either.

Dark-Master
12-17-2009, 03:54 PM
I will be using this addon in Gold Edition!

merkaz
12-17-2009, 08:09 PM
I'll be installing this when vb4 goes gold

MarkJW
12-18-2009, 12:39 AM
Try disabling Attachment Optimiser in the Plugin Manager - if that doesn't help then it almost certainly isn't being caused by vB4:SC.

EDIT: Wait, you've disabled the entire mod? Maybe it's a bug in vBulletin itself then :/

You could try turning attachment optimiser on as a workaround. :P


EDIT 2: Just checked and my attachments are still working fine, this is on RC4 though with Attachment Optimiser enabled (because I need it :P). And I don't think they were broken on RC2 either.
Probably an RC2 bug, but I haven't been able to find anyone with the same problem.

Oh well.

BSMedia
12-18-2009, 06:59 AM
My forum went from a 66/100 to a 70/100 after using this.

After some .htaccess work, I've got it up to an 80/100, going to try to see if I can get 100/100 :D


Edit: 90/100 is probably as high as I'm going to go until I can see what the dev's have planned for optimization in their releases following gold.

Darkimmortal
12-18-2009, 11:14 AM
I might have a go at tackling "Optimise images", "Specify image dimensions" and some of "Use efficient CSS selectors" in a later release :)

But for now I'm focused on getting fully deferred Javascript.

And I suppose "Parallelise downloads across hostnames" could be done fairly easily with some extra subdomains pointing at the root, along with some code to distribute downloads across them.



I dunno about 100/100, but ticks across the board in the Page Speed Firebug addon is good enough for me :)

lord_of_chaos
12-18-2009, 02:02 PM
Hello,
nice add-on you have here, indeed. :)

Did I just over-read it or didn't you mention that the PHP / Webserver needs write access to "/clientscript/vbsc.js" and "/clientscript/vbsc.js.gz"? Took me some time to find that out. Could be added to the first post. :)

BSMedia
12-18-2009, 03:33 PM
And I suppose "Parallelise downloads across hostnames" could be done fairly easily with some extra subdomains pointing at the root, along with some code to distribute downloads across them.

That'll have to be done at the server level, I'm not sure any script or modification can handle it.

I setup mine last night in about 6 minutes. I made. Then in the image paths for StyleVars i just entered the full path (http://images1.site.com) and everything appears to be working.

images1.site.com (statusicons)
images2.site.com (gradients)
images3.site.com (site_icons)
images4.site.com (misc)
images5.site.com (images)
clientscript.site.com (clientscript)

Then I modified the headinclude template to point the clientscript call to http://clientscript.site.com/blahblah.js?V=whatever

Here is a quick guide on Setting up parallel hostnames for vBulletin optimization (http://davidmchenry.info/2009/12/18/how-to-serve-parallel-hostnames-for-vbulletin-optimize-vbulletin-4/) & vBulletin 4 optimized .htaccess for vBulletin optimization (http://davidmchenry.info/2009/12/18/vbulletin-4-optimized-htaccess/)

BSMedia
12-18-2009, 09:21 PM
There seems to be a bug with this mod and CMS sections.

When it's enabled the sections on the CMS don't appear.

When it's disabled, the CMS sections appear just fine.

Darkimmortal
12-18-2009, 09:46 PM
There seems to be a bug with this mod and CMS sections.

When it's enabled the sections on the CMS don't appear.

When it's disabled, the CMS sections appear just fine.

Can you give me a link to your site where that is happening?

BSMedia
12-18-2009, 11:20 PM
Yeah

http://apertureforums.com

It's currently disabled, but I'll enable it for a while so you can see it in action.

Darkimmortal
12-21-2009, 05:40 AM
I was able to reproduce the sections bug - it will be fixed in 0.7, which I'm holding off on releasing until after gold. :)

cloferba
12-21-2009, 08:41 PM
I was able to reproduce the sections bug - it will be fixed in 0.7, which I'm holding off on releasing until after gold. :)

this is today...not? :D

Darkimmortal
12-21-2009, 10:24 PM
Yeah just give me a sec to install gold on my board to test things out :P

Hornstar
12-22-2009, 12:07 AM
I like the sound of this. Tagged for when I upgrade to vb4 ^^

aj8690
12-22-2009, 03:08 AM
Installed.

Having some style issues when CSS optimization is enabled... (This is the post reply page)

milsirhc
12-22-2009, 05:39 AM
Happening in new thread too.

Boko577
12-22-2009, 10:32 AM
So I moved my CSS.php file from database into the /clientscript. Then when I went to my site it looked totally different. After doing this, I followed the rest of the instructions until #6, compress js and css. I was able to compress js, but css won't compress, I just get kinda a gray bar in the middle of the screen. What am I doing wrong. By the way I'm using 4.0 gold

euantor
12-22-2009, 11:02 AM
Looks good. I'll have a go later :)

Darkimmortal
12-22-2009, 11:56 AM
Installed.

Having some style issues when CSS optimization is enabled... (This is the post reply page)

Reproduced, will fix for 0.8 :)

So I moved my CSS.php file from database into the /clientscript. Then when I went to my site it looked totally different. After doing this, I followed the rest of the instructions until #6, compress js and css. I was able to compress js, but css won't compress, I just get kinda a gray bar in the middle of the screen. What am I doing wrong. By the way I'm using 4.0 gold

I'm not sure what way you did it, but you want to go to Options > Style and Language Settings > Store CSS Stylesheets as Files and set it to Yes. Sounds like you were trying to actually move the css.php file? :/ If so, move it back. ;)

cloferba
12-22-2009, 04:45 PM
when i click on compress javascript...i recieve this error

Warning: file_put_contents(./clientscript/vbsc.js) [function.file-put-contents]: failed to open stream: Permission denied in [path]/admincp/vbsc.php on line 87

Warning: file_put_contents(./clientscript/vbsc.js.gz) [function.file-put-contents]: failed to open stream: Permission denied in [path]/admincp/vbsc.php on line 88

Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbsc.js.gz in [path]/admincp/vbsc.php on line 89

i think is because /clientscript/vbsc.js.gz doesnt exist...but its not on the files you give to download

Darkimmortal
12-22-2009, 04:54 PM
Make sure PHP can write to those files :)

You need to do some chmodding or whatever

cloferba
12-22-2009, 05:19 PM
ready..i miss to set 777..

but i see my forum as the image:

https://vborg.vbsupport.ru/
whats going wrong?

this skin doesnt uses images...only html to colours, like default vbulletin skin

i see default vb skin same as the image

movslow
12-22-2009, 05:54 PM
Mine did the same thing ^^ .

Was forced to uninstall.

The instructions aren't very clear.

To users of the previous CSS Optimiser and Attachment Optimiser: Delete both plugins before installing vB4:SC.
Ensure you have CSS stored in /clientscript and not in your database. - HOW ???
Disable Remote YUI if you have it enabled. - HOW ??
Upload the contents of vbsc.zip to your forum root.
Install product-vbsc.xml as a Product.
Run Compress JS and Compress CSS under the vB4: SuperCharged admin menu section.
You're good to go, but you might want to check over the settings first.

:confused:

Darkimmortal
12-22-2009, 06:02 PM
Sorry, I'll update the instructions.

EDIT: Done. I reckon the stylevar saving thing is what caused your problem(s).

sturdy
12-22-2009, 06:48 PM
unfortunately not working for me... page becomes white without design and just text :(

movslow
12-22-2009, 07:13 PM
Sorry, I'll update the instructions.

EDIT: Done. I reckon the stylevar saving thing is what caused your problem(s).

I appreciate that.

Fixed my issue, thank you.

I can see a difference. I was using VB Optomise in the past, and had to remove it w/the upgrade. This seems to help out.

Nice work.

:up:

Boko577
12-22-2009, 08:14 PM
Reproduced, will fix for 0.8 :)



I'm not sure what way you did it, but you want to go to Options > Style and Language Settings > Store CSS Stylesheets as Files and set it to Yes. Sounds like you were trying to actually move the css.php file? :/ If so, move it back. ;)

Got the site back up a little after posting the comment, thanks I'll try this over. Sorry I got vBulletin only 3 days ago so I'm still a noob... :o

Boko577
12-22-2009, 08:27 PM
ready..i miss to set 777..

but i see my forum as the image:

http://img52.imageshack.us/img52/83/sinttulof.jpg
whats going wrong?

this skin doesnt uses images...only html to colours, like default vbulletin skin

i see default vb skin same as the image

This can happen for many different reasons. At first I thought you may have moved your actual CSS.php file in your FTP thingy like I did the first time because this is what happened, but it may also be as simple as that you just have to do step 6 and compress both of them. If neither of those are the issues then I didn't run into any other sort of problem when I did mine.

cloferba
12-22-2009, 08:28 PM
Sorry, I'll update the instructions.

EDIT: Done. I reckon the stylevar saving thing is what caused your problem(s).


i?ve done this but now i see my template as default one :(

i mean..it has losted all the colours..and now it is like default vb skin

Darkimmortal
12-22-2009, 08:46 PM
Did you save a stylevar in every style your site uses?

Then rerun Compress CSS ofc.

In 0.8 I'll have Compress CSS run the equivalent code to saving a stylevar to simplify things a bit :)

cloferba
12-22-2009, 09:01 PM
Did you save a stylevar in every style your site uses?


i dont understand this..im not an english speaker..sorry

if i disable CSS compression, i can see the style with customize colors

what step im missing to get this work?

cloferba
12-22-2009, 09:18 PM
what i do is next..

Styles & Templates > My style...all Style options...stylevar..and i press GO

then i select Block Background (for example) and i click on save

the skin i use is rainbow..
https://vborg.vbsupport.ru/showthread.php?threadid=230642

movslow
12-23-2009, 05:20 PM
Conflict w/this mod.

https://vborg.vbsupport.ru/showthread.php?p=1936605#post1936605

Darkimmortal
12-23-2009, 07:24 PM
I'll look into that, thanks

SnakeV
12-24-2009, 01:23 AM
There are an incompatibility issue with this Google Custom Search code:

<script type="text/javascript">
var googleSearchIframeName = "cse-search-results";
var googleSearchFormName = "cse-search-box";
var googleSearchFrameWidth = 600;
var googleSearchDomain = "www.google.com";
var googleSearchPath = "/cse";
</script>
<script type="text/javascript" src="http://www.google.com/afsonline/show_afs_search.js"></script>

Thanks

kall
12-24-2009, 05:41 AM
Damn, we're getting close now.

My remaining issue of "why is it making my entire site 100% width?" is gone.

Remaining, the little --> in the footer next to the vBSEO copyright. ;)

movslow
12-24-2009, 05:02 PM
I'll look into that, thanks

I wanted to elaborate for you.

With the cache installed and enabled, the image resizer would not work, or @ least in the Chrome browser.

As soon as I disabled it, I could view the image.

Good mod, but it can't interfere w/existing mods.
:up:

Darkimmortal
12-24-2009, 05:49 PM
Yeah that could make things complicated - a lot of mods add Javascript which requires the vBulletin stuff to run and don't like having their <script> tags moved around. I'll see if I can think up a workaround :)

Blackhat
12-24-2009, 07:40 PM
I loose the css formatings after I installed it. and the quick reply disappeared

Darkimmortal
12-24-2009, 08:07 PM
Save any stylevar on each of your styles and then go to Compress CSS.

cloferba
12-24-2009, 08:23 PM
no what to do with my issue.. :(

Quarantine
12-25-2009, 09:37 AM
I'd like to report that this plugin seems to be conflicting with chatbox plugins like this (https://vborg.vbsupport.ru/showthread.php?t=228046&page=26). After uninstalling vB4 Supercharged, the chatbox plugin works as it should.

Any ideas why?

Darkimmortal
12-25-2009, 04:33 PM
It works fine with GCBOS on my test forum. :/

Raug
12-26-2009, 09:22 PM
I believe that the css compression crunches this box at the bottom of the page. I want to say it does it to other similar boxes, but I haven't actually actually confirmed it with any but this one.

Darkimmortal
12-27-2009, 12:03 AM
I believe that the css compression crunches this box at the bottom of the page. I want to say it does it to other similar boxes, but I haven't actually actually confirmed it with any but this one.

Yup that's a known bug

I've got loads of stuff to fix for 0.8 D:

teenhut
12-27-2009, 01:25 AM
Holy Shit!

My site just became shit load faster! Thanks :D

Darkimmortal
12-27-2009, 05:34 AM
0.8 released - huge amount of bugfixes, although I'm bound to have introduced more :P

Also note that saving a stylevar before running Compress CSS is no longer necessary - it's done automatically now.


Anyway, enjoy :)

TransAmDan
12-27-2009, 07:25 AM
Wow, it feels so whizzy now. Thanks for the mod, keep up the good work.

I has a small question which may sort itself out, in CMS on http://forum2.solent-renegades.co.uk/content.php (http://forum2.solent-renegades.co.uk/content.php)I get Please run the Compress CSS function of vB4: SuperCharged in your Admin CP. Your forum is currently running without optimised CSS as a fallback. However dosn't appear in Forums or Blogs.

TeknoSounds
12-27-2009, 07:27 AM
Been testing a dev site out using 4.0 and threw this on there

No sure if its just me...but the new version on the CMS homepage is giving me the css error saying its fallen back to the default and I need to run it again, but when going into the main forums, the error goes away.

*edit* Heh looks like me and TransAmDan were posting at the same time.

Raug
12-27-2009, 07:47 AM
Now it seems like 0.8 CSS compression makes me lose my background color and centering for my fixed width :(

Darkimmortal
12-27-2009, 07:54 AM
Been testing a dev site out using 4.0 and threw this on there

No sure if its just me...but the new version on the CMS homepage is giving me the css error saying its fallen back to the default and I need to run it again, but when going into the main forums, the error goes away.

*edit* Heh looks like me and TransAmDan were posting at the same time.

0.81 probably didn't fix the issue I've just realised D:

Does your site put a strange styleid on the CMS css files compared to all the rest? TransAmDan seems to have style 1 everywhere, but 12 (which doesn't actually exist on the filesystem) on the CMS :/

I just installed a fresh vB4 and it definitely isn't doing that, and no problems either on two heavily modded copies.

Now it seems like 0.8 CSS compression makes me lose my background color and centering for my fixed width

If it isn't fixed in 0.81, can I have the URL of your site?

TransAmDan
12-27-2009, 08:06 AM
Have tried 0.81, this didn't make any difference for me. You mentioned Stye 1, and 12, is there something missing in my CMS styles? I did have problem in my upgrade stages from VB4 Beta 2 tp Beta 4 and RC2, all had problems, so perhaps something happened to my CMS Styles in this time.

Delilahs
12-27-2009, 08:09 AM
I get the following message appear above both the CMS and Forum on my site.

Please run the Compress JS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised Javascript as a fallback.

Please run the Compress CSS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised CSS as a fallback.

I've looked at my admin panel, and cannot see the ooption to run either of these files, I have created and uploaded the vbsc.js and gz files, and made them writable (666) but cannot see the option to run the script in the admin cp.

Any ideas?

Link to my forum is below.

Darkimmortal
12-27-2009, 08:13 AM
I get the following message appear above both the CMS and Forum on my site.



I've looked at my admin panel, and cannot see the ooption to run either of these files, I have created and uploaded the vbsc.js and gz files, and made them writable (666) but cannot see the option to run the script in the admin cp.

Any ideas?

Link to my forum is below.

Assuming you uploaded vbsc.zip, you should see these options in your Admin CP:

https://vborg.vbsupport.ru/external/2009/12/21.png

Have tried 0.81, this didn't make any difference for me. You mentioned Stye 1, and 12, is there something missing in my CMS styles? I did have problem in my upgrade stages from VB4 Beta 2 tp Beta 4 and RC2, all had problems, so perhaps something happened to my CMS Styles in this time.

Well for some reason on your CMS pages I'm seeing: (style id 12)

<link rel="stylesheet" type="text/css" href="css.php?styleid=12&amp;langid=1&amp;d=1261907792&amp;td=ltr&amp;sh eet=vbulletin.css,popupmenu.css,vbulletin-chrome.css,components.css,vbulletin-formcontrols.css" />

Whereas on your other pages it's (style id 1)

<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001/vbsc.css" />

Could it perhaps be a template that needs reverted?

TransAmDan
12-27-2009, 08:17 AM
Well for some reason on your CMS pages I'm seeing: (style id 12)

<link rel="stylesheet" type="text/css" href="css.php?styleid=12&amp;langid=1&amp;d=1261907792&amp;td=ltr&amp;sh eet=vbulletin.css,popupmenu.css,vbulletin-chrome.css,components.css,vbulletin-formcontrols.css" />

Whereas on your other pages it's (style id 1)

<link rel="stylesheet" type="text/css" href="clientscript/vbulletin_css/style00001/vbsc.css" />

Could it perhaps be a template that needs reverted?

Thanks for pointing that out I'll see if I can recreate the CMS Styles. I'm very impressed with your super fast responses.

Delilahs
12-27-2009, 08:19 AM
Do we upload the whole of the .zip file, or just the folder inside the .zip file labelled VBSC ?

Darkimmortal
12-27-2009, 08:22 AM
Just upload the contents of the zip file to your forum's root directory. So that the admincp stuff goes into admincp, etc.

Delilahs
12-27-2009, 08:23 AM
Just checked the contents of the folder within the .zip file,and there are only 2 .php files in there, you may want to check the upload files, as the drop down menu you have in your screenshot are not in my admin control panel anywhere.

Delilahs
12-27-2009, 08:24 AM
The only file in the Admincp folder is the vbsc.php file, nothing else

Gnoll
12-27-2009, 08:30 AM
More Faster :D :D , Installed + Nominated

Darkimmortal
12-27-2009, 08:32 AM
The only file in the Admincp folder is the vbsc.php file, nothing else

Just checked the vbsc.zip file - it's fine.

Make sure you also upload the cpnav_vbsc.xml file to /includes/xml ;)

TeknoSounds
12-27-2009, 08:41 AM
Was not fixed in 0.81 :(
Its probably the style issue numbering issue. I'm only running the default style on the dev site, but I had other styles before it.
It appears the styleid is 9.

site is:
http://dev.teknosounds.com/messageboard

note theres no content on the cms atm.

Delilahs
12-27-2009, 08:42 AM
Ok, all done and working, the problem I had was in your instructions, you said upload the contents of the .zip folder to your forum root.

So I did, that meant the folder inside named 'VBCS' became a directory in the forum root.

Perhaps you should rename the folder within the .zip file to 'forum' that way people would possibly recognise the structure.

TransAmDan
12-27-2009, 08:48 AM
Well for some reason on your CMS pages I'm seeing: (style id 12)

Whereas on your other pages it's (style id 1)

Could it perhaps be a template that needs reverted?


Found it, In the table in the database 'cms_node' there is a field called 'styleid' it indeed had 12 in it, changed this to 1, and wahoo, problem solved.

The message on the front of my CMS page has gone, and by checking the HTML of the CMS page I can verify it is now calling StyleID 1.

Darkimmortal
12-27-2009, 08:50 AM
Was not fixed in 0.81 :(
Its probably the style issue numbering issue. I'm only running the default style on the dev site, but I had other styles before it.
It appears the styleid is 9.

site is:
http://dev.teknosounds.com/messageboard

note theres no content on the cms atm.

Your CMS seems to be running on styleid 1 - but since you've only got one style it sounds more like my code is a fault. Almost certainly it's this:

function vbsc_curstyle(){
global $vbulletin;
$sid = $vbulletin->userinfo['styleid'];
if($sid < 1)
$sid = $vbulletin->options['styleid'];
return sprintf("style%05d", $sid);
}

I'll have a dig through the vBulletin source and find out where they pull the styleid from.


Ok, all done and working, the problem I had was in your instructions, you said upload the contents of the .zip folder to your forum root.

So I did, that meant the folder inside named 'VBCS' became a directory in the forum root.

Perhaps you should rename the folder within the .zip file to 'forum' that way people would possibly recognise the structure.

Good idea :)

TeknoSounds
12-27-2009, 08:53 AM
as far as zip file structure, I'd make the new folder that contains the admincp and whatnot folders called 'upload'...should also add your xml file in there so you only need to download the zip instead of the 2 files.

seems to be the standard at least :)

TeknoSounds
12-27-2009, 09:00 AM
Okay, going off Trans post, I went into my cms_node table and sure enough the styleid was 1. I changed this to the styleid 9 that was reflected in the AdminCP and the error goes away.

Maybe this is a bug with the cms where its not putting the proper styleid into the table?

Darkimmortal
12-27-2009, 09:08 AM
I'll have a dig through the vBulletin source and find out where they pull the styleid from.

$vbcsspath = 'css.php?styleid=' . $vbulletin->userinfo['styleid'] . '&langid=' . LANGUAGEID . '&d=' . $style['dateline'] . '&td=' . $vbulletin->stylevars['textdirection']['string'] . '&sheet=';

Looks like it's probably not an issue in my code then. D:

Must be something that happens to some people after upgrading, because I can't reproduce anything like it on a clean install, even after fiddling with styles.

as far as zip file structure, I'd make the new folder that contains the admincp and whatnot folders called 'upload'...should also add your xml file in there so you only need to download the zip instead of the 2 files.

seems to be the standard at least

Yeah "upload" seems like a good idea, but including the xml file inside the zip will make things awkward for me :p

TeknoSounds
12-27-2009, 09:10 AM
Hmm guess it'll need to be reported to vB as a bug then. And ya, that sounds right if its been an upgrade...only puts default info in instead of pulling current styleid.

Ahh too true, I understand now that you've only updated the xml these past two minor upgrades.

Darkimmortal
12-27-2009, 09:17 AM
I dunno... technically it's working as designed, just incredibly annoying. How many people would ever need to have entire different styles for CMS sections anyway... :/

Delilahs
12-27-2009, 09:21 AM
Regarding the file structure, I concur with the way Tekno has described it.

I've also had to go into my Mysql database and change the style id manually in cms_node to 9 instead of 1.

This has to be a bug in the cms as it worked absolutely fine on the forum pages, without any trouble once I had uploaded the correct structure.

Darkimmortal
12-27-2009, 09:32 AM
Ok, updated the zip file :)

Also it's not really a bug tbh. Without css.php it would definitely be a problem, but they have it silently outputting the default style when given a non-existent style id. I'll add a workaround to do the same in the next release, but I'm going to wait a while this time - I've been firing out releases too fast :p

TeknoSounds
12-27-2009, 09:34 AM
Just an FYI.
Created a thread on vB.com

http://www.vbulletin.com/forum/showthread.php?333676-Styleid-bug-when-upgrading-to-vB-4-0

milsirhc
12-27-2009, 02:34 PM
Thanks!

FYI, having Enable CSS Optimiser Turned On.. messed up with IPBArcade templates.

Fr4n-FX
12-27-2009, 02:49 PM
messed up with IPBArcade templates.

i have this problem too

Delilahs
12-27-2009, 03:01 PM
same here, I've turned off the CSS Optimiser, and the arcade is fine again.

thincom2000
12-27-2009, 03:09 PM
The description says that it will move all JS to before the closing body tag. What about cases where there may not be a closing body tag?

Theoretical example (which occurs quite often on my live site): A section of page that is loaded via AJAX and contains JS. Would the JS in the AJAX-loaded section be ignored? Since there is no body tag, I'm worried what would happen if the JS Optimizer tried to move it.

Fr4n-FX
12-27-2009, 03:11 PM
same here, I've turned off the CSS Optimiser, and the arcade is fine again.

sorry is easy fix, in ADMINCP "vb4: Supercharged" section "CSS Files" add the ARCADE.css file:

"tagcloud.css",
"ARCADE.css",
"forumhome.css"

next run again "Compress CSS" script and works fine for me.

Delilahs
12-27-2009, 03:28 PM
well done Fr4n-FX.

ARCADE has to be in uppercase as well, as I found out.

Fr4n-FX
12-27-2009, 03:36 PM
no problem, thx to Darkimmortal for this mod.

movslow
12-27-2009, 06:26 PM
Has this been fixed w/the image resizer mod?
:confused:

arauf
12-27-2009, 07:16 PM
please find the attached screenshot, i am facing this prob after installing this product and when i disable it everything works fine, so it need more work, please upgrade it.

Darkimmortal
12-27-2009, 07:58 PM
Has this been fixed w/the image resizer mod?
:confused:

Yes, I specifically fixed that in 0.8 :)

please find the attached screenshot, i am facing this prob after installing this product and when i disable it everything works fine, so it need more work, please upgrade it.

I can't reproduce anything like that. Can you give me the link to your site and try and narrow it down as to which part (HTML/JS/CSS optimiser) is causing it?

teenhut
12-27-2009, 08:48 PM
Could this modifcation technically cause any problems?

Just wondering, not sure. My site all of a sudden stopped working.

www.teenhut.net/index.php

Any easy way to uninstall it without being able to login into the forum? Like disable or something, so i can check if forum runs with this disabled?

Darkimmortal
12-27-2009, 09:51 PM
Well I'm running it on nginx too without any problems :/

Anyway go to your product table in the database and set the 'active' field to 0.

Darkimmortal
12-27-2009, 10:26 PM
Also just noticed how ibProArcade includes its css - the css_start hook. Seeing as I'm taking css.php out of the equation, I'm gonna have to call hooks like that within my hook and hopefully handle the results correctly :/

min0taur
12-28-2009, 12:48 AM
Not Working with suite?

Darkimmortal
12-28-2009, 02:20 AM
Not Working with suite?

It is. Check you followed all the steps correctly.

teenhut
12-28-2009, 03:16 AM
Well I'm running it on nginx too without any problems :/

Anyway go to your product table in the database and set the 'active' field to 0.

Did that, but site still doesnt work.

Following is the error I see in error log and cant figure out whats wrong :(


2009/12/27 16:54:29 [error] 6470#0: *2958 FastCGI sent in stderr: "PHP Parse error: syntax error, unexpected '<' in /usr/share/nginx/html/teenhut.net/includes/class_core.php(3900) : eval()'d code on line 1" while reading response header from upstream, client: 98.240.246.113, server: teenhut.net, request: "GET /search.php?do=getdaily&contenttype=vBForum_Post HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "http://www.teenhut.net", referrer: "http://www.teenhut.net/search.php?do=finduser&userid=9515&contenttype=vBForum_Post&showposts=1"
2009/12/27 16:54:37 [error] 6470#0: *2989 FastCGI sent in stderr: "PHP Parse error: syntax error, unexpected '<' in /usr/share/nginx/html/teenhut.net/includes/class_core.php(3900) : eval()'d code on line 1" while reading response header from upstream, client: 67.195.37.185, server: teenhut.net, request: "GET /members/list/l101.html HTTP/1.0", upstream: "fastcgi://127.0.0.1:9000", host: "http://www.teenhut.net"
2009/12/27 16:54:39 [error] 6470#0: *2958 FastCGI sent in stderr: "PHP Parse error: syntax error, unexpected '<' in /usr/share/nginx/html/teenhut.net/includes/class_core.php(3900) : eval()'d code on line 1" while reading response header from upstream, client: 98.240.246.113, server: teenhut.net, request: "GET /search.php?do=finduser&userid=9515&contenttype=vBForum_Post&showposts=1 HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "http://www.teenhut.net", referrer: "http://74.125.95.132/search?q=cache:y5YgTxgssWcJ:www.teenhut.net/teen-sexuality/12259-scrotum-ball-sizes-pictures.html+scrotum+pictures&cd=6&hl=en&ct=clnk&gl=us"




there are millions of such errors in error.log file. My host said there is something wrong with template code.


This refers to some syntax error in the file /usr/share/nginx/html/teenhut.net/includes/class_core.php.

The line number 3900 is included in the following code snippet:

```````````````
$template_code = self::fetch_template($this->template);
if (strpos($template_code, '$final_rendered') !== false)
{
eval($template_code);
}
else
{
eval('$final_rendered = "' . $template_code . '";');
}

if ($vbulletin->options['addtemplatename'] AND !$suppress_html_comments)
{
$template_name = preg_replace('#[^a-z0-9_]#i', '', $this->template);
$final_rendered = "<!-- BEGIN TEMPLATE: $template_name -->\n$final_rendered\n<!-- END TEMPLATE: $template_name -->";
}
```````````````

This could be due to some issue with the template files of the bulletin. Are you aware of any recent changes/upgrades in the server or any plugins installed in the forum which might have caused this issue?

The other PHP files on the server are working fine.

Please have your developer or a vBulletin expert look into this issue. If the troubleshooting requires any assistance on the server side, let us know.


Thanks,
Not sure if it has anything to do with your product now, i made active field to 0, but still doesnt work. But if you can help out with anything, it will be really great :(

movslow
12-28-2009, 03:37 AM
Yes, I specifically fixed that in 0.8 :)



Thank you sir!!!
:up::up:

Greight
12-28-2009, 05:45 AM
Though I ran compress css this message keeps showing on top of the forum :
Please run the Compress CSS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised CSS as a fallback.

Darkimmortal
12-28-2009, 06:00 AM
Though I ran compress css this message keeps showing on top of the forum :
Please run the Compress CSS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised CSS as a fallback.

Link?

TeknoSounds
12-28-2009, 06:06 AM
I bet thats the same problem we were having Dark

Darkimmortal
12-28-2009, 06:14 AM
True, although he didn't say anything about it being only the CMS :/

I'll have to think up some sort of workaround for this in the next release D:

TeknoSounds
12-28-2009, 06:21 AM
well, is it possible to do a database call to the settings table and pull the current styleid and update the cms_node table in a mod? Or would that require something else?

Maybe do an initial call to compare the two fields, and if doesn't match, update the cms_node?

TeknoSounds
12-28-2009, 06:32 AM
Okay so new issue with Flashchat6 integration mod:
Going to the flashchat link it places css.php?sheet=memberlist.css at the top of the page.

Adding memberlist.css to the css list and recompressing didn't help it appears :(

Darkimmortal
12-28-2009, 06:51 AM
well, is it possible to do a database call to the settings table and pull the current styleid and update the cms_node table in a mod? Or would that require something else?

Maybe do an initial call to compare the two fields, and if doesn't match, update the cms_node?

It's possible yes, but a nicer solution would be if it handled the issue(?) silently (like vB itself does) and served CSS from the default style.

-snip-

Looks like he managed to fool my regex by simply using the url css.php?sheet= rather than the full styleid stuff etc.

I'll fix that in 0.9 :)

TeknoSounds
12-28-2009, 06:55 AM
It's possible yes, but a nicer solution would be if it handled the issue(?) silently (like vB itself does) and served CSS from the default style.

Yeah, I'm not quite certain while they have it set with its own style identifier instead of pulling from vB itself.
Really tho, since its there, vB just needs to correct their installation setup, as setting a default as 1 despite what the actual is is bad programming imo.

Looks like he managed to fool my regex by simply using the url css.php?sheet= rather than the full styleid stuff etc.

I'll fix that in 0.9 :)

schweet, can't wait :D
Thanks for all the help.

haluk
12-28-2009, 10:43 AM
There is no space between usernames in Thread Information.

https://vborg.vbsupport.ru/

sbisig
12-28-2009, 02:32 PM
The plugin includes an unwanted

-->

at the bottom of the the main forum page, below "Mark forum read". At least on my site it occurs.

aj8690
12-28-2009, 03:08 PM
Reproduced, will fix for 0.8 :) Still having issues with the display of "Topic Review" box on "Reply to Topic" pages... when CSS optimization is enabled.

Darkimmortal
12-28-2009, 05:33 PM
The plugin includes an unwanted

-->

at the bottom of the the main forum page, below "Mark forum read". At least on my site it occurs.

Can I have a link to where this happens?

Still having issues with the display of "Topic Review" box on "Reply to Topic" pages... when CSS optimization is enabled.

Ah, forgot about that bit. Added to my list for 0.9.

There is no space between usernames in Thread Information.

http://img187.imageshack.us/img187/9629/nospace.png

Will be fixed in 0.9 :)

kall
12-28-2009, 09:38 PM
A bit of a critical issue encountered with js compression - it causes ReCaptcha to not display in registration. :O

Darkimmortal
12-28-2009, 10:17 PM
A bit of a critical issue encountered with js compression - it causes ReCaptcha to not display in registration. :O

I can't reproduce that but I'll fire out 0.91 quickly with it added to the JS blacklist.

bart6767
12-28-2009, 11:26 PM
I tryed this and i get this and the bottom of the forum page <![endif]--> -->

And the blog is all over the place and messed up ?

I unstalled it again and all is fine and can you tell me what the bug it with the blog ?

Darkimmortal
12-28-2009, 11:29 PM
I tryed this and i get this and the bottom of the forum page <![endif]--> -->

And the blog is all over the place and messed up ?

I unstalled it again and all is fine and can you tell me what the bug it with the blog ?

Can I have a link to your site?

And please keep it uninstalled - it's easier for me to debug that way.

bart6767
12-28-2009, 11:32 PM
Can I have a link to your site?

And please keep it uninstalled - it's easier for me to debug that way.

http://www.randalstowncsc.net/

Darkimmortal
12-28-2009, 11:53 PM
Try disabling Options > General Settings > Add Template Name in HTML Comments.

And if that fails, see if the problem disappears when you disable the HTML Optimiser.

bart6767
12-29-2009, 12:01 AM
Try disabling Options > General Settings > Add Template Name in HTML Comments.

And if that fails, see if the problem disappears when you disable the HTML Optimiser.

Tryed both and its still the same .

Blog is messed up and still see this and bottom of forum page <![endif]-->


Take alook your self as i will keep it installed for 10 mins .

http://www.randalstowncsc.net/blog.php

Darkimmortal
12-29-2009, 12:10 AM
Tryed both and its still the same .

Blog is messed up and still see this and bottom of forum page <![endif]-->


Take alook your self as i will keep it installed for 10 mins .

http://www.randalstowncsc.net/blog.php

I don't see either of those problems in Firefox, Chrome, Opera, IE7 or IE8 :/

bart6767
12-29-2009, 12:12 AM
I see it in IE8

Darkimmortal
12-29-2009, 12:13 AM
Oh now I see what you mean :p

Fixing it now :)

bart6767
12-29-2009, 12:19 AM
Just had a look and i can see it in firefox as well.

Darkimmortal
12-29-2009, 12:50 AM
See if 0.92 works for you now :)

bart6767
12-29-2009, 12:59 AM
See if 0.92 works for you now :)

Ok that fixed the <![endif]-->

But the blog still goes off the page for me in IE 8 and fire fox .

I have turned it off again untill the blog bug is fixed .

Ripper
12-29-2009, 01:18 AM
<a href="http://bearcatsnation.com/forums/forum.php" target="_blank">http://bearcatsnation.com/forums/forum.php</a> - My style has changed back to the original yet in my control panel, blog, cms are all the style I made? Only mod I installed so far anyone else having this problem?

Ripper
12-29-2009, 01:35 AM
Ok going to look dumb but http://www.bearcatsnation.com/forums works and keeps everything in line, but http://bearcatsnation.com/forums reverts back to the original? Really not sure how I screwed this up, did make a redirect from my root to the forums directory?

Darkimmortal
12-29-2009, 04:31 AM
Ok going to look dumb but http://www.bearcatsnation.com/forums works and keeps everything in line, but http://bearcatsnation.com/forums reverts back to the original? Really not sure how I screwed this up, did make a redirect from my root to the forums directory?

Well as an unregistered user, I don't see any problem :/

And if you're really running 0.82 you need to update :p

Ok that fixed the <![endif]-->

But the blog still goes off the page for me in IE 8 and fire fox .

I have turned it off again untill the blog bug is fixed .

Would you mind turning the mod back on for a second and pastebin (http://pastebin.com/)'ing the html source so I can look at it later?

TeknoSounds
12-29-2009, 05:27 AM
Dark, just in case you were curious, .92 fixed the memberlist.css issue I was havin. Thanks! :D

Ripper
12-29-2009, 05:41 AM
Well as an unregistered user, I don't see any problem :/

And if you're really running 0.82 you need to update :p



Would you mind turning the mod back on for a second and pastebin (http://pastebin.com/)'ing the html source so I can look at it later?

Ment to reply back i fixed it. Just had a some bad syntax. Love the mod man, it's great, great mod!:)

bollie
12-29-2009, 08:02 AM
Good or bad ?

min0taur
12-29-2009, 09:33 AM
Does this works fine with vbulletin suite GOLD?

pupil
12-29-2009, 10:12 AM
Many thanks for excellent mod

I have small problem

album pics cannot be viewed when Attachment Optimiser is set to enable..

movslow
12-29-2009, 03:59 PM
Does this works fine with vbulletin suite GOLD?

I've been using it just fine.
:up:

bart6767
12-29-2009, 04:31 PM
Well as an unregistered user, I don't see any problem :/

And if you're really running 0.82 you need to update :p



Would you mind turning the mod back on for a second and pastebin (http://pastebin.com/)'ing the html source so I can look at it later?

I have sent you PM

BSMedia
12-29-2009, 05:35 PM
Still seems to have problems with the CMS and this mod.

Its a great mod for the forums only option, but the suite seems to cause some problems.

On the CMS there is an issue with Sections and Categories, sometimes they're appearing and sometimes they won't and sometimes categories appear in wrong section

min0taur
12-29-2009, 07:21 PM
I've been using it just fine.
:up:

Great! Thanks :)

Darkimmortal
12-29-2009, 07:32 PM
Still seems to have problems with the CMS and this mod.

Its a great mod for the forums only option, but the suite seems to cause some problems.

On the CMS there is an issue with Sections and Categories, sometimes they're appearing and sometimes they won't and sometimes categories appear in wrong section

Can you enable it temporarily and link me to where it happens?

Many thanks for excellent mod

I have small problem

album pics cannot be viewed when Attachment Optimiser is set to enable..

I don't use albums do I didn't notice that, thanks for letting me know :)

darsalles
12-29-2009, 08:26 PM
With compress javascript I get this error:

Warning: file_get_contents(./clientscript/vbulletin_cms.js) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 74

Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin_cms.js in [path]/admincp/vbsc.php on line 76

Darkimmortal
12-29-2009, 08:32 PM
With compress javascript I get this error:

Warning: file_get_contents(./clientscript/vbulletin_cms.js) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 74

Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin_cms.js in [path]/admincp/vbsc.php on line 76

I take it you don't have the suite? Can't believe I forgot to take that into account :p

darsalles
12-29-2009, 09:25 PM
the suite D:??

im new on vbulletin i just installes vb 4.0 PL1

Bounce
12-30-2009, 12:08 AM
Please run the Compress JS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised Javascript as a fallback.

Message will not disappear....

I've ran this several times lol :eek:

bart6767
12-30-2009, 12:35 AM
Ok it seems to be when i turn on the Enable JS Optimiser then thats when the blog gets messed up .

Darkimmortal
12-30-2009, 12:39 AM
Message will not disappear....

I've ran this several times lol :eek:

Can I have a link to your site?

And were there any errors when you ran Compress JS?

Bounce
12-30-2009, 09:08 AM
Can I have a link to your site?

And were there any errors when you ran Compress JS?

Still a test site but feel free, sent you a pm.

Big-Pete
12-30-2009, 10:01 AM
Im running vb4 gold pl1 and vbseo 3.5 rc1 and when i enable the JS compression and run the js compression tool i get errors where the site is just a white page with a few links on it, and i get this message which is strange as ive run the compressor (several times) :-
Please run the Compress JS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised Javascript as a fallback.

As soon as i set the Enable JS Optimiser to no the site returns to normal.. its running ok with the css optimiser though..

Good hack though, noticed an improvement straight away.. :)

Bounce
12-30-2009, 02:47 PM
I'm also find if I Enable JS Optimiser it changes the layout of the post thread where it shows the posticons in the postbit lol

Turning it off sorts the layout.

Shamil.
12-30-2009, 03:14 PM
I take it you don't have the suite? Can't believe I forgot to take that into account :p

oooh, naughty boy...!

Darkimmortal
12-31-2009, 01:05 AM
Im running vb4 gold pl1 and vbseo 3.5 rc1 and when i enable the JS compression and run the js compression tool i get errors where the site is just a white page with a few links on it, and i get this message which is strange as ive run the compressor (several times) :-
Please run the Compress JS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised Javascript as a fallback.

As soon as i set the Enable JS Optimiser to no the site returns to normal.. its running ok with the css optimiser though..

Good hack though, noticed an improvement straight away.. :)

You shouldn't be noticing that much of an improvement :p

Not without JS Optimiser anyway - it does most of the actual speedup.


Also, link?

Raug
12-31-2009, 06:45 AM
Hm, Dark, any reason there's a clash with the CSS optimizer and Abe1's thank hack? For some reason it changed the reply icon on posts from the arrow to the thank icon.

Darkimmortal
01-01-2010, 01:49 AM
Hm, Dark, any reason there's a clash with the CSS optimizer and Abe1's thank hack? For some reason it changed the reply icon on posts from the arrow to the thank icon.

Reproduced, fixing for the next release :)

Darkimmortal
01-01-2010, 06:09 AM
01/01/10 - perfect day for a 1.0 release :)

Happy new year everyone :>

Raug
01-01-2010, 06:20 AM
Hm, the thanks icon still appears for my reply button :(

Darkimmortal
01-01-2010, 06:21 AM
Hm, the thanks icon still appears for my reply button :(

Did you remember to recompress the CSS and Javascript?

Raug
01-01-2010, 06:22 AM
Yeah, I even uninstalled and reinstalled to make sure it didn't work.

I don't know if it makes a difference, but I moved the hook like Abe1 said to get the thanks button to appear in a different location.

TimberFloorAu
01-01-2010, 06:25 AM
Installed. Great work mate !

Darkimmortal
01-01-2010, 06:26 AM
Yeah, I even uninstalled and reinstalled to make sure it didn't work.

I don't know if it makes a difference, but I moved the hook like Abe1 said to get the thanks button to appear in a different location.

Well on my test forum which is running an unmodified copy of both vB4:SC and the Post Thank You Hack I see this:

https://vborg.vbsupport.ru/external/2010/01/83.png

(The missing icon is a bug in Post Thank You Hack)

Can I have a link to your forum?

Raug
01-01-2010, 06:35 AM
<span style="text-decoration: line-through">Yeah, somehow the image shows up after I run the CSS compressor. The path to the reply icon is still the reply icon, but it shows the thanks icon (which is missing without compression like you see it).</span>

So that was a bug of the thanks hack and an oversight. Thanks for pointing that out.

MikeWarner
01-01-2010, 08:21 AM
Looks like this will be a good mod - Bit I'm having the same issues as some above. I get the error "Please run the Compress CSS function of vB4: SuperCharged in your Admin CP. Your forum is currently running without optimised CSS as a fallback."

I have compressed both Javascript and CSS. I've even deleted the vbsc.js and vbsc.js.gz files and tried again (no errors given), but I'm still getting the message. It seems to render in Chrome ok, but it is a mess in IE, so I've disabled the hack for now. I look forward to a fix or pointer on what I'm doing wrong.

Many thanks.

Gnoll
01-01-2010, 08:32 AM
Thank you for update :) , upgraded

Darkimmortal
01-01-2010, 09:01 AM
Looks like this will be a good mod - Bit I'm having the same issues as some above. I get the error "Please run the Compress CSS function of vB4: SuperCharged in your Admin CP. Your forum is currently running without optimised CSS as a fallback."

I have compressed both Javascript and CSS. I've even deleted the vbsc.js and vbsc.js.gz files and tried again (no errors given), but I'm still getting the message. It seems to render in Chrome ok, but it is a mess in IE, so I've disabled the hack for now. I look forward to a fix or pointer on what I'm doing wrong.

Many thanks.

Link?

Also the mess you described is to be expected with the way it tacks that message on before even <html> :p

MikeWarner
01-01-2010, 09:16 AM
I've enabled the plug-in if just for you, let me know when you are done so I can fix or turn off again. Thanks :)
http://www.ridehub.co.uk

Edit - not sure if this matters, but my forum root is the directory route, i.e. it is located in / not /forums/

Darkimmortal
01-01-2010, 09:25 AM
http://www.ridehub.co.uk/clientscript/vbulletin_css/style00003/vbsc_vbulletin.css

Looks like Compress CSS hasn't run properly. Were there any errors?

And the folder layout doesn't make any difference - I run it live from / :)

MikeWarner
01-01-2010, 09:28 AM
No - but I have fixed it now. I noticed when running the Compress CSS tool that is was for some reason compressing the forum style twice, and the default skin once, which was strange...

So I tried the default skin and it worked fine. The custom skin was a child of the default skin, so I moved it to have no parent. I then reran the Compress CSS tool and it only ran once on that skin. It now works.

Thanks for looking into this though. :)

MikeWarner
01-01-2010, 09:33 AM
Update - I moved the custom style to become a child of the default skin, and the error came back. I then changed back to no parent style and it fixed again.

Darkimmortal
01-01-2010, 09:36 AM
Ah, child skins is one thing I never tested D:

MikeWarner
01-01-2010, 09:45 AM
Not a problem for now, but I will have a LOT of child styles soon, so a fix would be much appreciated. :)

Thanks

Bounce
01-01-2010, 11:25 AM
The file clientscript/vbsc.js is missing???

Never knew there was one?

Big-Pete
01-01-2010, 11:42 AM
The file clientscript/vbsc.js is missing???

Never knew there was one?


Just done the upgrade and I got the same error message..

Darkimmortal
01-01-2010, 01:33 PM
Then run Compress Javascript (and Compress CSS), like it says in the upgrade instructions.

Bounce
01-01-2010, 05:37 PM
Then run Compress Javascript (and Compress CSS), like it says in the upgrade instructions.

Top of my forum shows error..

Warning: filemtime() [function.filemtime]: stat failed for ./clientscript/vbsc.js in /var/www/vhosts/mmmmm.com/httpdocs/xxxx/includes/functions.php(6469) : eval()'d code on line 180

Please run the Compress CSS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised CSS as a fallback.

When I run Compress Javascript get the error...

An error occurred when saving clientscript/vbsc.js and/or clientscript/vbsc.js.gz. Ensure PHP has permission to write to these files.

There is no vbsc.js in clientscript.

min0taur
01-01-2010, 06:58 PM
Thanks for the update ! Installed

relaxiha
01-02-2010, 03:50 AM
error
Warning: filemtime() [function.filemtime]: stat failed for ./clientscript/vbsc.js in [path]/includes/functions.php(6469) : eval()'d code on line 163

Raug
01-02-2010, 04:28 AM
Top of my forum shows error..

Warning: filemtime() [function.filemtime]: stat failed for ./clientscript/vbsc.js in /var/www/vhosts/mmmmm.com/httpdocs/xxxx/includes/functions.php(6469) : eval()'d code on line 180

Please run the Compress CSS function of vB4: SuperCharged in your Admin CP.
Your forum is currently running without optimised CSS as a fallback.

When I run Compress Javascript get the error...

An error occurred when saving clientscript/vbsc.js and/or clientscript/vbsc.js.gz. Ensure PHP has permission to write to these files.

There is no vbsc.js in clientscript.

4. Ensure the files vbsc.js and vbsc.js.gz in /clientscript/ are writable. You may need to create these first, or simply chmod the whole /clientscript/ directory to be writable. Not all servers will need this, but if you encounter errors in Compress JS, this is most likely why.
You have to create it if it doesn't exist.

Darkimmortal
01-02-2010, 04:48 AM
Added blank copies of vbsc.js and vbsc.js.gz to vbsc.zip.

EDIT: What the hell, this useless forum sent out an auto update notification for that? D:

Darkimmortal
01-02-2010, 06:48 AM
Updated :)

MikeWarner
01-02-2010, 08:49 AM
Nice one - seems to work with Child Styles now. Thanks.

Bounce
01-02-2010, 10:34 AM
not an error in site lol, thanks Darkimmortal :up:

linuxututs
01-02-2010, 06:03 PM
My site flashes like when going from page to page.

Anyway to fix this?

I have clientscripts chmod 777 -R. ( I had already created the files from last time I tried this also, but over-wrote everything on this new install. )

Thanks,

Darkimmortal
01-02-2010, 06:06 PM
Link?

linuxututs
01-02-2010, 06:16 PM
Oh, sorry. Mysite. (http://www.linuxtuts.net/content/)

Darkimmortal
01-02-2010, 06:31 PM
Oh wow, it's made a horrible mess of your HTML. Would you mind disabling vB4:SC completely so I can see what's causing it?

linuxututs
01-02-2010, 06:39 PM
Done. Thanks for the help to BTW. :)

Thanks,

MikeWarner
01-03-2010, 10:49 AM
I also installed this - seems to have further helped by adding further compression:
https://vborg.vbsupport.ru/showthread.php?t=178286

Darkimmortal
01-03-2010, 12:15 PM
Yeah that is all stuff any good server would have anyway :p

Darkimmortal
01-03-2010, 01:41 PM
Done. Thanks for the help to BTW. :)

Thanks,

I thought the JS Optimiser was your problem, but I put your site's html through it in my test environment and it came out just fine :/

See if you can eliminate which optimiser is causing your issues and I'll see what I can do to fix it (although most likely it's one of your mods that's causing the problem).

linuxututs
01-03-2010, 04:47 PM
Yeah, I got to thinking about it, and I have My Server tweaked to the Max already server-side and figure that could/is the problem as well Mate.

Great Mod and wish I could use it, but my sites already fast as lighting, I was just looking for a little more if you get what I mean. ( I'm also an overclocker...hahaha )

Thanks Darkimmortal,

slimshotty
01-03-2010, 11:33 PM
I am getting an error. This appears at the top of site:

Warning: Invalid argument supplied for foreach() in [path]/includes/functions.php on line 4762
The file ./clientscript/vbulletin_css/style00009/vbulletin.css is missing. This would indicate your forum is not set to save CSS on the filesystem. If you are certain it is, try running Compress CSS again.

To prevent issues, your forum is currently running without optimised CSS as a fallback.

I get these errors when running Compress CSS:

vB4 Default Style ... (Templates) (StyleVars) () ()

Warning: Invalid argument supplied for foreach() in [path]/includes/adminfunctions_template.php on line 1035
(Controls) Done.


Warning: file_get_contents(./clientscript/vbulletin_css/style00009/vbulletin.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/popupmenu.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/vbulletin-chrome.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/components.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/vbulletin-formcontrols.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/postlist.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/attachment.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/attachments.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/editor.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/forumbits.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/threadlist.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/tagcloud.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

Warning: file_get_contents(./clientscript/vbulletin_css/style00009/forumhome.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208
DarkVision ... (Templates) (StyleVars) () ()
Warning: Invalid argument supplied for foreach() in [path]/includes/adminfunctions_template.php on line 1035
(Controls) Done.

I chmod 777 the vbulletin_css directory.

Can you tell me how to resolve?

Thanks,

Slim

slimshotty
01-04-2010, 03:32 AM
I resolved my issue by re-applying 4.0 PL1 and enabling vbsc. It works great now.

supportMM
01-04-2010, 05:53 AM
Sweet, it got rid of that nagging side bar jerk on open.

Installed. Thanks :)

abroad
01-06-2010, 10:07 AM
I resolved my issue by re-applying 4.0 PL1 and enabling vbsc. It works great now.

how does re-applying work as I get the same error

Darkimmortal
01-06-2010, 12:22 PM
how does re-applying work as I get the same error

Make sure you have CSS set to be saved on the filesystem (see the installation instructions).

bfdzio
01-06-2010, 12:38 PM
I saw one guy ask and read like 12 pages after but can't find any answer to this.

I made two changes to my CSS before I had decided to give this a shot. I lost one of them. I had changed it so my link color INSIDE of posts only was a different color than the text, and I changed the color of my thread prefixes. The thread prefixes color is still the one I changed it to, but the one inside of threads does not work anymore. I disabled the mod and turned off storing CSS, and none of it is working. Is there any reason why only one change would stop working, and what can I do to fix this?

EDIT: Nevermind, fixed it finally. This always happens. I try for a day and then ask the question. Then I figure it out. For some reason I had my 'additional css' comment causing the problem. Just removed it even though it was commented out and it works now.

LouisB
01-06-2010, 03:01 PM
Great mod. No problems at all and can see an improvement.

SnakeV
01-06-2010, 09:13 PM
Installed and nominated for MOTM :)

dihuta
01-07-2010, 04:29 AM
Confilct with Album Ajax Rating.
Reported here: https://vborg.vbsupport.ru/showthread.php?t=228768&page=2

Cface
01-07-2010, 05:25 AM
got this error on your version 1.01. Just thought you'd like to know.
# Default Style ... (Templates) (StyleVars) () () (Controls) Done.

Warning: file_get_contents(./clientscript/vbulletin_css/style00001/popupmenu.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208
# SimpleBlue ... (Templates) (StyleVars) () () (Controls) Done.

Warning: file_get_contents(./clientscript/vbulletin_css/style00002/popupmenu.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208

From the compress CSS script page..

And from the Compress JS page..
Warning: file_get_contents(./clientscript/vbulletin-sidebar.js) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 75

Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin-sidebar.js in [path]/admincp/vbsc.php on line 77
Maybe you should make a nice error handler for folks that freak out :P

Darkimmortal
01-07-2010, 12:38 PM
Confilct with Album Ajax Rating.
Reported here: https://vborg.vbsupport.ru/showthread.php?t=228768&page=2

I'll look into that, thanks

got this error on your version 1.01. Just thought you'd like to know.
# Default Style ... (Templates) (StyleVars) () () (Controls) Done.

Warning: file_get_contents(./clientscript/vbulletin_css/style00001/popupmenu.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208
# SimpleBlue ... (Templates) (StyleVars) () () (Controls) Done.

Warning: file_get_contents(./clientscript/vbulletin_css/style00002/popupmenu.css) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 208
From the compress CSS script page..

And from the Compress JS page..
Warning: file_get_contents(./clientscript/vbulletin-sidebar.js) [function.file-get-contents]: failed to open stream: No such file or directory in [path]/admincp/vbsc.php on line 75

Warning: filesize() [function.filesize]: stat failed for ./clientscript/vbulletin-sidebar.js in [path]/admincp/vbsc.php on line 77Maybe you should make a nice error handler for folks that freak out :P

That's odd... any reason why those files might not exist? Are you using the forum-only version? Are you even using vBulletin 4? :p

ArtAttack
01-07-2010, 08:22 PM
Section Navigation widget breaks with javascript optimizer.

darsalles
01-08-2010, 01:32 PM
Im getting this error with 1.01 version on JS compress:

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 68

and this on css compress:

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 191

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 196

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 201
# Rainbow Skin ... (Plantillas) (Variables de Estilos) () () (Controles) Terminado.


Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 191

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 196

Warning: Invalid argument supplied for foreach() in [path]/admincp/vbsc.php on line 201

I have VB 4.0 PL1 forum

Bitti
01-09-2010, 08:11 AM
An automatic css compressor would be nice is if adding a new template or change an existing

Darkimmortal
01-09-2010, 09:15 AM
Oh, it used to do that :/

I'll add that back in the next release :)

Bounce
01-10-2010, 06:05 PM
Hi, dunno if this has been mentioned but this conflicts with facebook bridge

https://vborg.vbsupport.ru/showthread.php?t=232457

Get error trying to run css