0-9 Link?

[Chadi]

Hi folks. Need some little help here.

I have this mod I released that shows an ABC link nav menu for any specific forum the code is placed into.

https://vborg.vbsupport.ru/showthread.php?t=211939

The letters are linked like this:

<a rel="nofollow" href="http://www.yourdomain.com/forumdisplay.php?f=2&letter=a">A</a>

However, I'd like to add another link for numbers, but one link for any number: 0-9 and the link would be "#" not "0-9". Clicking the link would show all threads that begin with any number.

How can I achieve this?

Thanks.

[Dead Eddie]

I don't remember the code for that one, but at some point it hooked into a query with code like :

where $something = $letter

You'll need to do a conditional. If $letter == '#', your query is going to look like:

where $something BETWEEN 0 AND 9

I'm rebuilding my computer at the moment, so I didn't look at the mod. If you need more help, I'll reinstall that and take a second look. Also, I didn't test it, but in theory it should work. :)

[Chadi]

Thanks Eddie, but I don't know anything about programming past the assistance I was given. If you can figure it out, great thanks.

[Dead Eddie]

Untested...so try it on a test install first:

if(isset($_GET['letter'])) {
$vbulletin->input->clean_GPC('r', 'letter', 'TYPE_STR);
$letter = $db->escape_string($vbulletin->GPC['letter']);

if($letter == '#') {
$hook = " AND LEFT(thread.title, 1) BETWEEN 0 AND 9";
}
else {
$hook = " AND LEFT(thread.title, 1) = '$letter'";
}

$hook_query_where .= $hook;
}

Also, change the hook location in the file you've released to forumdisplay_query_threadid. That might solve some people's problems.

[Chadi]

Thanks, but what am I supposed to do with that code? Where does it go in the plugin file?

[Dead Eddie]

That's the updated code. It replaces what's in the plugin.

Also, I looked at the vbseo version, and it doesn't look like it was changed (except that it uses the correct hook). So, I'm wondering if there's either a change that didn't get picked up with the plugin, or if there really needs to be two different files.

[Chadi]

Thanks Ed. Still confused though.

The plugin now is this:

<?xml version="1.0" encoding="ISO-8859-1"?>

<product productid="asp_thread_listing" active="1">
<title>Thread Listing by Letter</title>
<description>Listing of threads by the first letter of the title</description>
<version>.1</version>
<url />
<versioncheckurl />
<dependencies>
</dependencies>
<codes>
</codes>
<templates>
</templates>
<plugins>
<plugin active="1" executionorder="5">
<title>Add Where Letter</title>
<hookname>forumdisplay_query</hookname>
<phpcode><![CDATA[if(isset($_GET['letter'])){
$vbulletin->input->clean_GPC('r', 'letter', TYPE_STR);

$letter = $db->escape_string($vbulletin->GPC['letter']);

$hook_query_where .= " AND LEFT(thread.title, 1) = '$letter'";

}]]></phpcode>
</plugin>
</plugins>
<phrases>
</phrases>
<options>
</options>
<helptopics>
</helptopics>
<cronentries>
</cronentries>
<faqentries>
</faqentries>
</product>


With your changes, is it supposed to look like this?

<?xml version="1.0" encoding="ISO-8859-1"?>

<product productid="asp_thread_listing" active="1">
<title>Thread Listing by Letter</title>
<description>Listing of threads by the first letter of the title</description>
<version>.1</version>
<url />
<versioncheckurl />
<dependencies>
</dependencies>
<codes>
</codes>
<templates>
</templates>
<plugins>
<plugin active="1" executionorder="5">
<title>Add Where Letter</title>
<hookname>forumdisplay_query</hookname>
<phpcode><![CDATA[if(isset($_GET['letter'])) {
$vbulletin->input->clean_GPC('r', 'letter', 'TYPE_STR);
$letter = $db->escape_string($vbulletin->GPC['letter']);

if($letter == '#') {
$hook = " AND LEFT(thread.title, 1) BETWEEN 0 AND 9";
}
else {
$hook = " AND LEFT(thread.title, 1) = '$letter'";
}

$hook_query_where .= $hook;
}]]></phpcode>
</plugin>
</plugins>
<phrases>
</phrases>
<options>
</options>
<helptopics>
</helptopics>
<cronentries>
</cronentries>
<faqentries>
</faqentries>
</product>


I'll look into the vbseo thing again.

--------------- Added 1240808021 at 1240808021 ---------------

Just wanted to give you a heads up. Tested your code on a fresh install, non-vbseo. It always displayed all threads regardless of the letter clicked.

[Dismounted]

This line is incorrect (PHP Tags "fix" it):
$vbulletin->input->clean_GPC('r', 'letter', 'TYPE_STR);

Change it to:
$vbulletin->input->clean_GPC('r', 'letter', TYPE_STR);
Also, you should be using the Admin CP to generate the XML - it will remove any structural errors.

[Dead Eddie]

This line is incorrect:
$vbulletin->input->clean_GPC('r', 'letter', 'TYPE_STR);
Change it to:
$vbulletin->input->clean_GPC('r', 'letter', 'TYPE_STR');
Also, you should be using the Admin CP to generate the XML - it will remove any structural errors.

Hm, I thought those TYPE_* were constants.

Just wanted to give you a heads up. Tested your code on a fresh install, non-vbseo. It always displayed all threads regardless of the letter clicked.

You didn't make this change yet:

Also, change the hook location in the file you've released to forumdisplay_query_threadid. That might solve some people's problems.

If after making that change, you're still having problems, let me know. I should be able to install a test board today after work.

[Chadi]

Thanks, that works now.

I have two issues now:

One, I'm trying to figure out the proper code replacement for "forum-path" so a person can copy/past this into forumdisplay template to use the mod globally, not per forum (as I currently have it linked directly to one specific forum).

Example:

http://www.talkjesus.com/scriptural-bible-answers/?letter=a"

That's the link for letter A.

What should be the vbseo replacement for the forum title/path which for me here is "scriptural-bible-answers"? My vbseo panel shows

[forum_title]

I tried that like this, it did not work.

Talk Jesus | Christian Forums & Chat - Powered by vBulletin (http://www.vbseo.com/redirect-to/?redirect=http%3A%2F%2Fwww.talkjesus.com%2F)[forum_title]/?letter=a"

I even added a $ before [forum and still does not work. Just redirects back to home page.

Second question is, I'd like to add a 0-9 # link as well, before the letter A table column.

Example:
Scriptural Bible Answers - Talk Jesus | Christian Forums & Chat (http://www.vbseo.com/redirect-to/?redirect=http%3A%2F%2Fwww.talkjesus.com%2Fscriptu ral-bible-answers%2F)

So I want a link like this:

"0-9"

The question is, how can I properly link it so it shows all threads in that forum that begin with any number? What would the link code look like for a singe link for "0-9" or better yet, just "#"?

Thanks!

--------------- Added 1240864909 at 1240864909 ---------------

Would appreciate if anyone can help me on this, thanks.

I'm trying to make the template versions to one version, vbseo or non-vbseo since vbseo changes it automatically.

Regarding 0-9 numbered threads listing:

I tried this, does not work, shows no threads but I do have one thread that begins with a letter, "144,000..."

<a rel="nofollow" href="http://www.talkjesus.com/scriptural-bible-answers/?letter=#">#</a>

Regarding the template code:

I'm using this in a test forum (fresh install) without vbseo
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="center">
<td colspan="30" height="16" class="thead">
<strong>Search topics by first letter</strong><tr align="center">
<td class="alt1" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]">All</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=a">A</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=b">B</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=c">C</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=d">D</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=e">E</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=f">F</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=g">G</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=h">H</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=i">I</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=j">J</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=k">K</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=l">L</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=m">M</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=n">N</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=o">O</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=p">P</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=q">Q</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=r">R</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=s">S</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=t">T</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=u">U</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=v">V</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=y">Y</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=x">X</a></td>
<td class="alt2" width="3%">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=y">Y</a></td>
<td class="alt1" style="padding:5px;text-align:center">
<a rel="nofollow" href="http://www.talkjesus.com/test/forumdisplay.php?f=$foruminfo[forumid]&letter=Z">Z</a></td>
</tr>
</table>
<br />

I tried the same code above in my default install with vbseo enabled, does not work. Says invalid links.

[Dismounted]

Hm, I thought those TYPE_* were constants.
It isn't that - they are constants. In the posted code, there was a single quote in front of it. I removed this in the second one, but the PHP highlighter seems to like to "fix" things, making it not shown.

[Chadi]

I'd like to send an update on the mod so, please someone help me out.
Thanks :)

[Chadi]

Would appreciate help on this please