whats wrong with this ?

[wolfe]

i am trying to get the favourite mod from the arcade hack to work on another part of my forum so far php correct but theres a problem with the script the image is not changing on click ? and ideas.


<script type="text/javascript">

var lastfav;


// Favorites handling.
function favsprocess()
{
if (xml.handler.readyState == 4 && xml.handler.status == 200 && xml.handler.responseText)
{
thisfav = document.getElementById('favs_' + lastfav);
if (xml.handler.responseText==1)
{
thisfav.src = 'images/thread/subfav.gif';
thisfav.alt = 'Remove Favourite';
thisfav.title = 'Remove Favourite';
} else if (xml.handler.responseText==2)
{
thisfav.src = 'images/thread/addfav.gif';
thisfav.alt = 'Add Favourite';
thisfav.title = 'Add Favourite';
}

}
}

function dofavs(threadid)
{
xml = new vB_AJAX_Handler(true);
xml.onreadystatechange(favsprocess);

lastfav = threadid;
xml.send('tindex.php', 'do=processfav&threadid=' + threadid);
}


</script>

[cheesegrits]

I'm not entirely sure, but I don't think you can change a src like that. I think you have to use Image objects, like this:

<script type="text/javascript">

var lastfav;

var subfav = new Image();
var addfav = new Image();

subfav.src = 'images/thread/subfav.gif';
addfav.src = 'images/thread/addfav.gif';

// Favorites handling.
function favsprocess()
{
if (xml.handler.readyState == 4 && xml.handler.status == 200 && xml.handler.responseText)
{
thisfav = document.getElementById('favs_' + lastfav);
if (xml.handler.responseText==1)
{
thisfav.src = subfav.src;
thisfav.alt = 'Remove Favourite';
thisfav.title = 'Remove Favourite';
} else if (xml.handler.responseText==2)
{
thisfav.src = addfav.src;
thisfav.alt = 'Add Favourite';
thisfav.title = 'Add Favourite';
}

}
}

function dofavs(threadid)
{
xml = new vB_AJAX_Handler(true);
xml.onreadystatechange(favsprocess);

lastfav = threadid;
xml.send('tindex.php', 'do=processfav&threadid=' + threadid);
}


</script>



Like I said, I'm not sure, but give that a go.

-- hugh

[wolfe]

worked a treat m8 thx


WHERE thread.threadid IN($tindex)
its not just seleting the threads with the fav ids ?

the $tindex look like this 1223,3434,5252,5251 etc

[cheesegrits]

Can you post the whole query?

The only thing I can think of without any context is that maybe you are using 'single quotes' rather than "double quotes", so $tindex isn't getting expanded.

-- hugh

[wolfe]

$favcache = unserialize($vbulletin->userinfo['tfavcache']);
// Favorites
$tindex = implode(',', (array)$favcache);

$threadarray = $vbulletin->db->query_read("
SELECT thread.*, icon.title AS icontitle, icon.iconpath AS iconpath, user.username, user.userid, user.usergroupid, IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid

FROM " . TABLE_PREFIX . "thread AS thread
LEFT JOIN " . TABLE_PREFIX . "icon AS icon ON(icon.iconid = thread.iconid)
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.username = thread.postusername)
WHERE thread.threadid IN($tindex) $pqr
ORDER BY $sqlsort $sortorder $secondarysortsql
LIMIT " . ($limitlower - 1) . ", $perpage ");

[cheesegrits]

Nothing obvious wrong with that.

You might want to try assigning the query to a variable and var_dumping() it before it executes, so you can copy and paste the literal query into somelike like phpMyAdmin or a mysql command line, and see what it actually generates.

-- hugh