Links and Downloads Manager

[evildream]

22.06.08 Version 2.2.9-post1 - This is the supported version

Includes some bug fixes since 2.2.9 plus the full Chinese, French and Spanish translations (thanks guys). Should work fine with all versions of vb3.6 and vb3.7.

It says it's for both 3.6 and 3.7 and I had installed 2.2.8 then upgraded to see if it fixed the problem, and it didn't.

[obmob]

Hmm... i'm really new to sync, but I think your setup should work. Maybe you need to configure something for subcategories.

Please wait for Andrew, I'm sure he has a better idea.

[frantorm]

please someone could say could add as a proxy to the front of urls downloads? links.php?url=http://anonym.to/? $urldownload <-

That file should I change?

Thanks

[Stilgar]

I'm having a little trouble after installing 2.2.9-post2. The new image permissions don't seem to work correctly. I have it set so that two of the three Usergroups that can post links, can also add thumbnails. However, the thumbs do not show. There is a space where the thumb should be, but the image is not there.

Thanks for your help,

James

[sparklywater]

Can someone please tell me if it is possible to add a simple border around the edge of images in the photo gallery? Even if it is a simple black-line border? The example gallery shown on the following documentation page shows that the images in the gallery don't have any borders, but is it possible to customise this layout to include a border?

http://www.eirma.org/wikis/index.php/Image:Photolib.jpg

What about changing the alignment / positioning of the images on the page? Does this mod have such features to change the layout of the photo library page?

[obmob]

Try applying the "tborder" class around the image code, use a:
<div class="tborder">image code goes here</div>

That should do the trick :D

[stwilson]

I have tried and tried and tried to layout links in one category as follows:

Category
-Sub Categories
--List of Links, with Title and a few link details (Hits, rating, etc.) but not all the content
---Clicking on Link Title shows link content, which in my case is a fair amount of text, images and a download file

I have read the user guide, tried every possible configuration but cannot get it to lay out the way I described above. What I get is the Category, with a list of Sub-categories. Clicking on a Sub-Category shows all the links and every piece of link content (text, images, etc.) for each link. Since my entries in this section will have a fair amount of text, images, and attributes, I do not want to show all that with the link listings. Rather, I would like my users to click on the link title to see the content for that link and to then be able to download the attachment.

My question is, is that possible to accomplish? Thanks for any direction you can offer.

[kompakt]

Another question. In my directory structure, one has to make a few clicks before getting to the new categories so I would like more parent categories flagged with new entries.

Is it possible to control how many parent categories are flagged when a new entry is added? I don't recall seeing a setting for this.

[josiespencer]

My registered users are restricted to 2 downloads a day. I have a user who belongs to no other user group:

https://vborg.vbsupport.ru/

The Registered group is set to 2:

https://vborg.vbsupport.ru/

And yet he can download many more than that:

https://vborg.vbsupport.ru/

Any clue?

[IrPr]

Hi Mr Andrew;

Bug report:
With can_edit_link and no can_select_category and no can_admin_links permission, when local_links.php generates editlink form ldm_construct_category_list() returns null, so no $optbit, so no pcatid[] input array in form, so ll_error_category standard error will be returened when form submitted.

How to fix:
local_links.php (line 1328) in "editlink" area
"can_add_link" permission should be "can_edit_link"

[m002.p]

I would love to use this mod. However ive tried two times and couldnt get it working on each due to the dir root errors etc, no doubt due to the php.ini settings.

However, I have a question; is it possible to install this mod on one domain, and have the uploads folder on another?

I ask this because like I say my domain has problems with the directories (probably as it is windows too), but my friend has a linux domain which would be worth a shot using.

Any help appreciated

Matt

[IrPr]

I would love to use this mod. However ive tried two times and couldnt get it working on each due to the dir root errors etc, no doubt due to the php.ini settings.

However, I have a question; is it possible to install this mod on one domain, and have the uploads folder on another?

I ask this because like I say my domain has problems with the directories (probably as it is windows too), but my friend has a linux domain which would be worth a shot using.

Any help appreciated

Matt
You can upload your files in second server/domain and submit thats url instead of uploading

[Sycoloco1212]

when ever i try todo something or goto the page i get this

Sycoloco, you do not have permission to access this page. This could be due to one of several reasons:

1. Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
2. If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.

[obmob]

My registered users are restricted to 2 downloads a day. I have a user who belongs to no other user group:

http://www.uber-goober.com/myPictures/LDMX.png

The Registered group is set to 2:

http://www.uber-goober.com/myPictures/LDMY.png

And yet he can download many more than that:

http://www.uber-goober.com/myPictures/LDMZ.png

Any clue?:p
http://www.eirma.org/wikis/index.php/Special:Search?search=allowances

when ever i try todo something or goto the page i get this

Sycoloco, you do not have permission to access this page. This could be due to one of several reasons:

1. Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
2. If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.

Hmm... don't forget to set your member's permissions :D

[sparklywater]

Is it not possible to moderate user-comments before they are displayed on the website?

[sparklywater]

Someone please help, I'm trying to include some HTML formatting in my entry layout, and although the formatting does correctly display the first time it is submitted and applied, the HTML code reverts back to bbCode format and the HTML code does not show up in the editer window when the same entry is edited again. For example if I apply the bold attribute in HTML around a text like this: <b>This text is bold</b>, when the entry is edited again the HTML code does not remain in this way but changes to bbCode format: [ b] This text is bold [/b]. This causes problems because I need the HTML code to remain in the exact way I enter them in order to apply the required formatting to the entry using HTML. I've checked my LDM settings and HTML input is enabled in entries. If anyone has any idea what I am talking about and can offer some advice on how to solve this, please let me know. How can I prevent the WYSYWIG editer from automatically converting HTML code into bbCode?

EDIT: I've just noticed that this problem only accurs with the Advanced WYSIWYG editor but not the Standard editor, so switching to the standard version solves the problem.

[stwilson]

I noticed one small issue for the Attributes option. The Attributes display order works for the presentation of the link but does not order correctly in Add Entry form. I don't know what the order is for the Add Link form but it is not consistent with the Display Order identified in the Admin Panel.

One other suggestion for Attributes, allow for adding a required option per attribute. I find that Attributes will be very powerful for me but there is no way for me to identify specific attributes (not all of them) that I would like my members to enter.

[Sycoloco1212]

:p
http://www.eirma.org/wikis/index.php/Special:Search?search=allowances


Hmm... don't forget to set your member's permissions :D

i still need help, when i click Links and Downloads and try to click anything in that category like as in "permissions"

i get this still, on everthing under Downloads and Links

Sycoloco, you do not have permission to access this page. This could be due to one of several reasons:

1. Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
2. If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.

[sparklywater]

i still need help, when i click Links and Downloads and try to click anything in that category like as in "permissions"

i get this still, on everthing under Downloads and Links

Sycoloco, you do not have permission to access this page. This could be due to one of several reasons:

1. Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
2. If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.


are you logged in as an admin and have you reviewed the permission-settings for that category? There are general/global permissions and also category-specific permissions.

[derfelix]

Maybe its only me.. but probably I am doing something wrong....

Talking about Keywords..
(this is only theoretical.. but i plan to have it running in couple of weeks)

I set up LDM as a simple link directory with 16 categories...
Users add links with title, description AND Keywords..
Suppose every user adds 5 keywords.. some are double.. some not..
so if i plan to have about 5000 links.. that makes 25000.. keywords.. no.. because of doubles etc.. but lets say about 5000 in total..

--------
Now on the display links page for example and in other places I have the "Filter" (a dropdown that shows all keywords).. that would be a dropdown with 5000 fields?????
I know this is theoretical only, but realistic is to have about 1000 keywords after 5000 links.. (specially if you have very different categories)
even a the 1000 keywords loaded every page would slow down the system.. or am I wrong..
Ok the filter is limited to keywords by category.. but still.. we dont know how big we get..
I would suggest an option to turn the keyword filter off.. specially to save ressources on bigger board

Thats only an idea... but maybe i'm totally wrong..

Felix

[obmob]

Arent's keywords shown while you type them? :confused:

I get a popup while writing the keyword.

[yahoooh]

i suggest :
comments be in the same shownig page of link or download
like vbulletin threads

[derfelix]

Arent's keywords shown while you type them? :confused:

I get a popup while writing the keyword.
@obmob
yes thats when you add or modify.. but if you are in a category just browsing the links, i have (top left) a dropdown "sort by" and just below that a second dropdown called "filter".. thats the one i meant.
----------
@Andrew..
just found a little (for me) bug in ratings...
If 3 people rate a link.. lets say:
user 1 rates 5
user 2 rates 3
user 3 rates 4
(total 12 => average 4 ... works fine)

now 2 things can happen:
1. another user comments.. but does NOT rate..
2. user 3 clicks on "Clear ratings"

in my understanding the average should still be 4.. because only 2 users have rated.. (users 1 and 2 .. total 8.. average 4)

But its different.. if 1. happens.. rating becomes 8/3 => ~3
if 2. happens rating becomes 12/4 => 3
and if 1. AND 2 happen.. then rating becomes 8/4 => 2!

Maybe its supposed to be like that..but
Personally i dont want users that have commented but NOT rated to be counted in ratings..
so i made myself a little fix:

open: local_links_actions.php
in function ldm_fix_rating_counts find:
foreach ($rates as $r) {
$numrate += 1;
$totrate += $r;
}

replace with
foreach ($rates as $r) {
if($r>0)
{
$numrate += 1;
$totrate += $r;
}
}

of course on live sites this will not be an ideal solution.. because it will only fix the rating of a link as soon as somebody either rates or comments..
if the site is still small.. admin can modify (open and save) 1 comment/rating in each existing link.. .. if a link is commented/rated for the first time.. there is no problem..

AHHHHHHH... drawback.. now the the number of comments (as it is the same number will only show the amount of ratings.. (not counting the number of comments that have no vote) :(
...

-------------
A yes another harder to fix issue..
in the dropdown where you preview the comments (in the linkbit).. IF the site is running in UTF-8 there are some issues (strange characters appearing) sometimes..
I found the problem..
its in the function ldm_cleantext_to_width_rows
IF you run UTF8 and have a special character where the line is supposed to stop.. substr can truncate a non ascii character.. because the count is wrong.. returning the string but the last character is truncated.. showing a weird sign..
The only fix I know of is to use mb_strlen and mb_substr instead of strlen and substr..
I did some test by replacing substr(....) by mb_substr(.....,"UTF-8") in that function.. (also the strlen)
IT WORKS for me.. BUT..
if the mb_substr exists since php 4.06 not all providers have the php multi-byte extension installed.. (i had to activate them on my localhost)
so a fix would only be for those who have it installed.. and are using UTF-8 .. but it still is a a pain.. because you have to specify the encoding every time... AND you DONT always need the mb_substr.. only sometimes.. like here.
maybe there is another workaround???

Felix





..

[IrPr]

@obmob
yes thats when you add or modify.. but if you are in a category just browsing the links, i have (top left) a dropdown "sort by" and just below that a second dropdown called "filter".. thats the one i meant.
----------
@Andrew..
just found a little (for me) bug in ratings...
If 3 people rate a link.. lets say:
user 1 rates 5
user 2 rates 3
user 3 rates 4
(total 12 => average 4 ... works fine)

now 2 things can happen:
1. another user comments.. but does NOT rate..
2. user 3 clicks on "Clear ratings"

in my understanding the average should still be 4.. because only 2 users have rated.. (users 1 and 2 .. total 8.. average 4)

But its different.. if 1. happens.. rating becomes 8/3 => ~3
if 2. happens rating becomes 12/4 => 3
and if 1. AND 2 happen.. then rating becomes 8/4 => 2!

Maybe its supposed to be like that..but
Personally i dont want users that have commented but NOT rated to be counted in ratings..
so i made myself a little fix:

open: local_links_actions.php
in function ldm_fix_rating_counts find:
foreach ($rates as $r) {
$numrate += 1;
$totrate += $r;
}

replace with
foreach ($rates as $r) {
if($r>0)
{
$numrate += 1;
$totrate += $r;
}
}

of course on live sites this will not be an ideal solution.. because it will only fix the rating of a link as soon as somebody either rates or comments..
if the site is still small.. admin can modify (open and save) 1 comment/rating in each existing link.. .. if a link is commented/rated for the first time.. there is no problem..

AHHHHHHH... drawback.. now the the number of comments (as it is the same number will only show the amount of ratings.. (not counting the number of comments that have no vote) :(
...

-------------
A yes another harder to fix issue..
in the dropdown where you preview the comments (in the linkbit).. IF the site is running in UTF-8 there are some issues (strange characters appearing) sometimes..
I found the problem..
its in the function ldm_cleantext_to_width_rows
IF you run UTF8 and have a special character where the line is supposed to stop.. substr can truncate a non ascii character.. because the count is wrong.. returning the string but the last character is truncated.. showing a weird sign..
The only fix I know of is to use mb_strlen and mb_substr instead of strlen and substr..
I did some test by replacing substr(....) by mb_substr(.....,"UTF-8") in that function.. (also the strlen)
IT WORKS for me.. BUT..
if the mb_substr exists since php 4.06 not all providers have the php multi-byte extension installed.. (i had to activate them on my localhost)
so a fix would only be for those who have it installed.. and are using UTF-8 .. but it still is a a pain.. because you have to specify the encoding every time... AND you DONT always need the mb_substr.. only sometimes.. like here.
maybe there is another workaround???

Felix





..
Awesome!
thanks Felix ;)

[chickendippers]

Hi there,
Great script, but my server keeps killing processes because they're running too long. Here's the report form the server, I don't suppose anyone could shed some light on the problem?
lfd on sh2.valcatohosting.com: Excessive resource usage: ***** (29021)

Time: Mon Jul 28 11:18:56 2008
Account: ****
Resource: Process Time
Exceeded: 601 > 600 (seconds)
Executable: /usr/bin/php
Command Line: /usr/bin/php /home/f****/public_html/new/local_links.php
PID: 29021
Killed: Yes

[sparklywater]

i suggest :
comments be in the same shownig page of link or download
like vbulletin threads

That's Exactly what I need. Can someone please let me know how I can make the full list of comments appear right below the playbit, instead of on a separate page ie. like YouTube comments I want the comments table to appear right below the video / media. I tried to swap over the codes but the content of the comments does not appear in the new page. Someone please help... ?

[derfelix]

hmmm... we must have different configuration.. mine looks like that.. ( in some way)

one page has the listing of 20 items per page..
and if i click on one item.. a separate page opens (like youtube) where i have the item.. and below the comments..

:eek:

(my items are not videos.. but that doesnt matter ... can be anything)

Felix

[sparklywater]

hmmm... we must have different configuration.. mine looks like that.. ( in some way)

one page has the listing of 20 items per page..
and if i click on one item.. a separate page opens (like youtube) where i have the item.. and below the comments..

(my items are not videos.. but that doesnt matter ... can be anything)


Let me know if you can get that layout with an embedded video, I don't think it will work. Opening up a video or audio in an embedded player opens up a different template such as 'links_playerbit_RealPlayer' and I think the problem is with these specific templates for embedded multimedia. The comments do not appear displayed just below the multimedia; instead, a link is displayed below the multimedia which takes you to a different page which shows all the comments correctly. Please let me know if there is a way to have the comments directly on the embedded player page instead of having links to other pages.

[sparklywater]

How come some variables like the following list don't work in templates such as 'links_play_embedded', but at the same time other variables like '$linkratebit' do work??

$linkfavbit
$linksendtofriendbit
$linkreportlinkbit
$linklikebit
$linkstarbit
$linknewbit

How can I get these variables to work in the 'links_play_embedded' template too?

[stwilson]

hmmm... we must have different configuration.. mine looks like that.. ( in some way)

one page has the listing of 20 items per page..
and if i click on one item.. a separate page opens (like youtube) where i have the item.. and below the comments..

:eek:

(my items are not videos.. but that doesnt matter ... can be anything)

Felix
I have the same issue. My lists of links do not work like you suggest either. I have a page of 10 links but clicking on the link title fires off the action of opening a new browser and taking me to that link. I would prefer to have the clicking take the user to the link's detail, including the comments. I have tried every possible configuration but cannot get it to work this way. The fact that yours works like you posted gives me hope.

[Stilgar]

Is anyone else having problems showing Thimbnails on Links using Version 2.2.9-post2?

Ever since upgrading to this version, I have not been able to make Thumbnails show.

Added:

The Thumbnails do show when viewing the Category in the "Short Entries" version.

[Delazar]

Hi,

wenn ich versuche eine Kategorie zu erstellen, bekomme ich folgende Meldung:
Warnung: Invalid argument supplied for foreach() in [path]/includes/local_links_misc.php (Zeile 74)
Ich habe schon mal alles deinstalliert und wieder Installiert, immer noch das gleiche.

Was kann es sein?

Gru?
Delazar

[gamextract]

I've just installed the 2.2.9 version on my 3.7 vbulletin, and I'm getting this security token error. Any help on how to fix this would be great.


Your submission could not be processed because a security token was missing.

If this occurred unexpectedly, please inform the administrator and describe the action you performed before you received this error.


I checked the local_links.php
and local_links_actions.php

and both already have the define('CSRF_PROTECTION', true);

I'm confused as to what I'm missing

I've even gone through all my template files and made sure the

<input type="hidden" name="securitytoken" value="$bbuserinfo[securitytoken]" />

was included where needed

[gamextract]

Edit-sorry for the double/new post

[AndrewD]

still wait : timer to download to prevent hotlinking
i still prefer timer than any other way
or also verification by image

Sorry for the long delay... needed my rest :)

There is an LDM add-on, secure-urls, in the release/extras directory which provides timer- and user- based locks on LDM urls.

[AndrewD]

Using vb 3.6.4 and LDM 2.2.9 post2 and having this problem that's been frustrating me for hours because it should be simple.

local_file_root is set to Yes
local_file_root is set to /attachments/
sync_enabled is set to Yes
sync_populate_categories is set to Yes
sync_populate_entries is set to Yes

I uploaded the files into /attachments/songs/mp3/
set chmod 777 to all directories

When adding a category I set this:
Synchronise with... songs/mp3/

And gives me this error:
Cannot synchronise category with songs/mp3/ - directory not found.

What on earth am I doing wrong??

Did you get to the bottom of this?

local_file_root set to 'yes' means 'look for the files outside your website, starting at the root of the file structure. So with (I presume you mean) local_file_root_prefix set to 'attachments', LDM will try to find your songs in the directory /attachments/songs/mp3/.. at the root of the file system.

Also worth checking that your site's php settings allow this access, particularly, is open_basedir set? You can find this information on the LDM admin pages, on the left side.

[AndrewD]

Hi Mr Andrew;

Bug report:
With can_edit_link and no can_select_category and no can_admin_links permission, when local_links.php generates editlink form ldm_construct_category_list() returns null, so no $optbit, so no pcatid[] input array in form, so ll_error_category standard error will be returened when form submitted.

How to fix:
local_links.php (line 1328) in "editlink" area
"can_add_link" permission should be "can_edit_link"

Thanks - that bug has been there for a long, long time.

[AndrewD]

Someone please help, I'm trying to include some HTML formatting in my entry layout, and although the formatting does correctly display the first time it is submitted and applied, the HTML code reverts back to bbCode format and the HTML code does not show up in the editer window when the same entry is edited again. For example if I apply the bold attribute in HTML around a text like this: <b>This text is bold</b>, when the entry is edited again the HTML code does not remain in this way but changes to bbCode format: [ b] This text is bold [/b]. This causes problems because I need the HTML code to remain in the exact way I enter them in order to apply the required formatting to the entry using HTML. I've checked my LDM settings and HTML input is enabled in entries. If anyone has any idea what I am talking about and can offer some advice on how to solve this, please let me know. How can I prevent the WYSYWIG editer from automatically converting HTML code into bbCode?

EDIT: I've just noticed that this problem only accurs with the Advanced WYSIWYG editor but not the Standard editor, so switching to the standard version solves the problem.

The code uses vbulletin wysiwyg textbox forms. I imagine that the html/bbcode handling is built into the handling of these forms.

[AndrewD]

Maybe its only me.. but probably I am doing something wrong....

Talking about Keywords..
(this is only theoretical.. but i plan to have it running in couple of weeks)

I set up LDM as a simple link directory with 16 categories...
Users add links with title, description AND Keywords..
Suppose every user adds 5 keywords.. some are double.. some not..
so if i plan to have about 5000 links.. that makes 25000.. keywords.. no.. because of doubles etc.. but lets say about 5000 in total..

--------
Now on the display links page for example and in other places I have the "Filter" (a dropdown that shows all keywords).. that would be a dropdown with 5000 fields?????
I know this is theoretical only, but realistic is to have about 1000 keywords after 5000 links.. (specially if you have very different categories)
even a the 1000 keywords loaded every page would slow down the system.. or am I wrong..
Ok the filter is limited to keywords by category.. but still.. we dont know how big we get..
I would suggest an option to turn the keyword filter off.. specially to save ressources on bigger board

Thats only an idea... but maybe i'm totally wrong..

Felix

Thanks, will check if I've beem that stupid (highly likely) and provide the option to turn this off. There have been similar problems with other drop-down menus during development.

[AndrewD]

I noticed one small issue for the Attributes option. The Attributes display order works for the presentation of the link but does not order correctly in Add Entry form. I don't know what the order is for the Add Link form but it is not consistent with the Display Order identified in the Admin Panel.

One other suggestion for Attributes, allow for adding a required option per attribute. I find that Attributes will be very powerful for me but there is no way for me to identify specific attributes (not all of them) that I would like my members to enter.

I added attributes earlier this year, and the code is still rather raw and buggy. I'll check and also see how to deal with your good suggestion.

[RikiB]

Sorry for the long delay... needed my rest :)


Its good to see you back!

Just a reminder how nice it would be to have the new JW Player (version 4). :)

Also, do you think it would be possible to expose all the flash variables? The one I am most interested in is the streamscript variable that allows pseudo-streaming and extra security.

Thanks!

[Delazar]

Hi,

wenn ich versuche eine Kategorie zu erstellen, bekomme ich folgende Meldung:
Warnung: Invalid argument supplied for foreach() in [path]/includes/local_links_misc.php (Zeile 74)


Ich habe schon mal alles deinstalliert und wieder Installiert, immer noch das gleiche.

Was kann es sein?

Gru?
Delazar

Hat keiner eine Ahnung was das sein k?nnte?

[obmob]

Andrew speaks german? :eek:

Welcome!

[AndrewD]

Hat keiner eine Ahnung was das sein k?nnte?

I don't speak (or read) German, but I understand enough to see an error message :)

After you install LDM, does anything work at all, or do you always get this message?

Are you sure that you have uploaded all the files into the correct directories?

[AndrewD]

A rather unpleasant soul who has clearly been checking the LDM code in some depth has started throwing occasional SQL injection hacks at our website. So far this has not caused anything more serious than SQL errors, but it highlights a potential security bug in the LDM code. I will include the fix in the next upload - in the meantime if anyone else if being hit, let me know and I'll explain how to prevent the problem.

[derfelix]

talking about german.. just found a search bug..:eek:

difficult to explain..
the word Austria is "?sterreich" in german..

I have several links containing "?sterreich" in link title or keyword...
i do a search.. get 5 results.. ==> it works fine..

NOW i change to sortorder...
and get NO Result !!!!
Search Results
Searching for entries matching %C3%B6sterreich, looking in keywords for any words
Found 0 matching entries
Why? because in the sort order form.. there the word ?sterreich is suddenly urlencoded.. giving: %C3%B6sterreich and it tells me.. No result found for %C3%B6sterreich!!! This is true because %C3%B6sterreich does not exist.. it is ?sterreich.

here part of the page sourcecode:
<td align="right">
<form action="local_links_search.php" method="get">
<span class="smallfont">
<input type="hidden" name="action" value="show" /><input type="hidden" name="page" value="1" /><input type="hidden" name="pp" value="20" /><input type="hidden" name="search" value="%C3%B6sterreich" /><input type="hidden" name="literal" value="1" /><input type="hidden" name="keys" value="1" /><input type="hidden" name="beforeafter" value="1" /> Sort by <!-- BEGIN TEMPLATE: links_catsortbit -->

<span class="smallfont">

<select class="select" name="sort" onchange="this.form.submit();" size="1" style="width:200px">
<optgroup label="Sort by">

<option value="N" >Title (ascending)</option>
<option value="n" >Title (descending)</option>
<option value="h" >Hits (overall)</option>


i think.. ( not sure.. ) it should be urlencoded when passed through the form but then urldecoded before searching the database... it should be urldecoded before being displayed...
or
not urlencoded at all.. but then i think you need it for spaces.. hmmm not sure..

Felix

[AndrewD]

talking about german.. just found a search bug..:eek:

difficult to explain..
the word Austria is "?sterreich" in german..



thanks - I found a similar bug within the search/sort order code when there is a space in the search string. I suspect it is the same problem, but will check.

edited - try editing local_links_search.php, round about line 1150, there's a sequence


$search['string'] = $vbulletin->GPC['search'];
$search['literal'] = $vbulletin->GPC['literal'] ? $vbulletin->GPC['literal'] : 1;
$search['keys'] = $vbulletin->GPC['keys'];
$search['desc'] = $vbulletin->GPC['desc'];


change the first line:


$search['string'] = urldecode($vbulletin->GPC['search']);
$search['literal'] = $vbulletin->GPC['literal'] ? $vbulletin->GPC['literal'] : 1;
$search['keys'] = $vbulletin->GPC['keys'];
$search['desc'] = $vbulletin->GPC['desc'];

[AndrewD]

Its good to see you back!

Just a reminder how nice it would be to have the new JW Player (version 4). :)

Also, do you think it would be possible to expose all the flash variables? The one I am most interested in is the streamscript variable that allows pseudo-streaming and extra security.

Thanks!

I've run a few tests with the new JW player, and got it doing the basics with LDM. I can't figure out how to make the streamscript variable work - seems it should accept the standard ldm streamer, but nothing happens. However, file=LDM streamer script does work fine for both video and music.

I'm sure I can expose the rest of the flash variables via a plugin

[RikiB]

Ahh great. I was hoping to find a way that prevented people from downloading an FLV file.

The only way I have discovered to protect FLV files from download is to pay for a real streaming service which is very expensive. There is also lightppd but Im not sure if that would even help.

Perhaps this is impossible currently, let me know if this will be a waste of time.

Thanks again!

[vbboarder]

Hi Andrew, welcome back from your vacation/ break! Hope you are well rested.:)
I have 3 bugs to report:

1. When editing an entry, the user is able to upload another file (the file is saved in the upload directory), but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated.

2. The category of a forum is not replaced in the phrase when using {4} in ldm_thread_create_body. Instead, the LDM database name is always shown.

3. The "Add LDM to VB navbar" plugin link does not work if vbAdvanced is installed and not located at the forum root. Solution, find:
'<td class="vbmenu_control"><a href="local_links.php">'

And replace that with:
'<td class="vbmenu_control"><a href="' . $vbulletin->options['bburl'] . '/local_links.php">'

[vbboarder]

My flash videos were playing fine a week ago, but I recently installed vbTubePro and then the videos in LDM were not showing. Not sure if it's because of vbTubePro, but I can't recall working on anything else besides LDM and vbTubePro this past week. Anyways, here's the bug and solution fix.

Problem: the JW wma/wmv player does not show if the window mode is not transparent/ windowless.

Solution:
1. Edit links_playerbit_JWwmPlayer template - FIND:
file:?$player_stream?

After that ADD:
background:?transparent?, windowless:?true?,

2. The old 1.0 JW Silverlight player can't handle the background parameter, so download the new JW Silverlight media player at: http://www.jeroenwijering.com/?item=jw_wmv_player

3. Add the JW prefixes to silverlight.js, wmvplayer.js, wmvplayer.xaml (ie: rename to JWsilverlight.js) and overwrite the files in the /forum/clientscript folder.

Problem: the JW flash player does not show if the window mode is not transparent/ windowless.

Solution:
1. Edit links_playerbit_JWPlayer template - FIND:
ldmso$player_id.addParam(?allowfullscreen?, ?true?);

Before that, ADD:
ldmso$player_id.addParam(?wmode?, ?transparent?);

2. The current JWPlayer for Flash works with this modification. However, the new JWPlayer 4 is available and also compatible with this edit. It's available at: http://www.jeroenwijering.com/?item=JW_FLV_Media_Player

Hope that helps people having trouble displaying videos using the JW players ;)

[derfelix]

try editing local_links_search.php, round about line 1150, there's a sequence...

Works Like a charm!!!!!
Thank You Sir !!!!

Felix

[stwilson]

I have the same issue. My lists of links do not work like you suggest either. I have a page of 10 links but clicking on the link title fires off the action of opening a new browser and taking me to that link. I would prefer to have the clicking take the user to the link's detail, including the comments. I have tried every possible configuration but cannot get it to work this way. The fact that yours works like you posted gives me hope.
Andrew,

Welcome back! Any suggestion on how to set my links properties so clicking on the link title opens the link details versus attempting to open the link? I have tried everything but cannot figure it out. Is that even an option?

[AndrewD]

Maybe its only me.. but probably I am doing something wrong....

Talking about Keywords..
(this is only theoretical.. but i plan to have it running in couple of weeks)

I set up LDM as a simple link directory with 16 categories...
Users add links with title, description AND Keywords..
Suppose every user adds 5 keywords.. some are double.. some not..
so if i plan to have about 5000 links.. that makes 25000.. keywords.. no.. because of doubles etc.. but lets say about 5000 in total..

--------
Now on the display links page for example and in other places I have the "Filter" (a dropdown that shows all keywords).. that would be a dropdown with 5000 fields?????
I know this is theoretical only, but realistic is to have about 1000 keywords after 5000 links.. (specially if you have very different categories)
even a the 1000 keywords loaded every page would slow down the system.. or am I wrong..
Ok the filter is limited to keywords by category.. but still.. we dont know how big we get..
I would suggest an option to turn the keyword filter off.. specially to save ressources on bigger board

Thats only an idea... but maybe i'm totally wrong..

Felix

I took a look at this, and I don't think the problem is as serious as it might be. The keyword filter shown on a category display page only includes kywords that have actually been used for entries in that category. Pages where users can add keywords use an Ajax-enabled drop-down of matching keywords. Have I missed something?

Still, I will add a control setting to disable this menu.

[derfelix]

Well i tested with a little spider i wrote... grabs links with description and keyword metatags.. and adds it to the db.. the 50 links i added to the category had very many keywords (from metatags) about 40 or 50 per link... for some reason they were not somilar so i ended up with 2500 keywords for 50 links :eek:

of course if a human fills in the link he will rather add 1 or 2 keywords.. but if you use the keywords from metatags sometimes you have over 100 keywords per link.. ( I know that thats wrong for search engines.. but some people just put them there)
thats why i thought: oh my gosh...

but if you add a way to disable it.. i think it would be great..

Felix

[AndrewD]

Andrew,

Welcome back! Any suggestion on how to set my links properties so clicking on the link title opens the link details versus attempting to open the link? I have tried everything but cannot figure it out. Is that even an option?

If I understand your question correctly, you can do this on a per-category basis or for everything.

On a per-category-basis, edit the category of interest and go to the control settings tab
For everything, go to ldm/admin/settings

Set the template_linkbit to 'Title Only'

Save

You will then see the entries in the category/categories displayed as single lines with just title, date and number of hits. Click on one of the links and it will take you to the full listing for that entry. Click again and it will take you to the entry.

See images.

[AndrewD]

My flash videos were playing fine a week ago, but I recently installed vbTubePro and then the videos in LDM were not showing. Not sure if it's because of vbTubePro, but I can't recall working on anything else besides LDM and vbTubePro this past week. Anyways, here's the bug and solution fix.

Problem: the JW wma/wmv player does not show if the window mode is not transparent/ windowless.

Solution:
1. Edit links_playerbit_JWwmPlayer template - FIND:


After that ADD:


2. The old 1.0 JW Silverlight player can't handle the background parameter, so download the new JW Silverlight media player at: http://www.jeroenwijering.com/?item=jw_wmv_player

3. Add the JW prefixes to silverlight.js, wmvplayer.js, wmvplayer.xaml (ie: rename to JWsilverlight.js) and overwrite the files in the /forum/clientscript folder.

Problem: the JW flash player does not show if the window mode is not transparent/ windowless.

Solution:
1. Edit links_playerbit_JWPlayer template - FIND:


Before that, ADD:


2. The current JWPlayer for Flash works with this modification. However, the new JWPlayer 4 is available and also compatible with this edit. It's available at: http://www.jeroenwijering.com/?item=JW_FLV_Media_Player

Hope that helps people having trouble displaying videos using the JW players ;)


Thanks - I will be updating the jw player in the next release, so will make these fixes there. In the meantime, your explanation is excellent and I'ms ure anyone affected can follow it.

[sparklywater]

when can we expect the next release of LDM?

[stwilson]

If I understand your question correctly, you can do this on a per-category basis or for everything.

On a per-category-basis, edit the category of interest and go to the control settings tab
For everything, go to ldm/admin/settings

Set the template_linkbit to 'Title Only'

Save

You will then see the entries in the category/categories displayed as single lines with just title, date and number of hits. Click on one of the links and it will take you to the full listing for that entry. Click again and it will take you to the entry.

See images.

Thank you Andrew! That worked. I will play around with one of the templates to get the layout I need but overall that worked. Is there any way to get the set it up to show, upon clicking on the title in the list, to take you directly the version that shows when you click on the show comments (action=ratelink&linkid=347&catid=81&lpage=1)? I guess what I'm trying to say is I would like the detail page to show the listing with the comments underneath it.

[AndrewD]

when can we expect the next release of LDM?

2.2.9 is likely to stay the supported release for at least a couple of months, perhaps with a few more bug fixes applied.

I have done quite some work already on 2.3.0, but some of the suggestions and the bug reports posted here will take time to complete. Perhaps an early alpha will be available fairly soon, but thorough testing is the big challenge these days.

Coded so far for 2.3.0:

+ Category Display
Added option to display/remove keyword filter dropdown
+ Starred nominations
Entries can be unnominated
Nominations are no longer stacked, i.e. only user's current nomination is recorded
+ Session ids
vBulletin session ids handled corrrectly throughout
+ Efficiency changes
Admin and categories tables cached in vBulletin datastore and other code rewritten to eliminate various database lookups
+ Media Players
Upgraded JWsilverlight player to version 1.1 and added windowless and background params
+ Hooks
Added ldm_icons_cached after caching list of icon filenames
+ Bug fixes
Fixed id3tag-enhancements extra
Fixed permissions-related null category bug within Edit Entry
Fixed sort order/pagination bugs when searches contain urlencoded chars
Fixed Add LDM to VB navbar plugins for situation when vbAdvanced is not installed in forum directory

Still to do:

- Redo much of the 'attributes' code to fix bugs/improve functionality
- Provide import mechanism for vb attachments
- Move to jw media player 4.0
- Disentangle comments and ratings calculations
- Option to make comments/ratings visble inline consistently
- other bug fixes

Anything else?

[sparklywater]

- Option to make comments/ratings visble inline consistently

Would this feature allow display of the 'links_viewall_comment' template (ie. the full list of comments), within the playerbit templates, such as 'links_playerbit_Realplayer' and 'links_playerbit_JWplayer' ?

Also, is it possible to make the LDM variables 'global', so that their use is not restricted to specific templates only, allowing them to be used in other templates too? Is there some code I can edit to do this myself?

Here is an example of how I would like the comments-list displayed within the playerbit templates:


http://www.sparklywater.com/files/misc/comments.bmp


PS. I'm not sure if the comments listing is already paginated, but if not then it would keep things more organised if the comments are listed across a number of pages rather than all running down a single long page.

[AndrewD]

Would this feature allow display of the 'links_viewall_comment' template (ie. the full list of comments), within the playerbit templates, such as 'links_playerbit_Realplayer' and 'links_playerbit_JWplayer' ?

Also, is it possible to make the LDM variables 'global', so that their use is not restricted to specific templates only, allowing them to be used in other templates too? Is there some code I can edit to do this myself?

Here is an example of how I would like the comments-list displayed within the playerbit templates:

PS. I'm not sure if the comments listing is already paginated, but if not then it would keep things more organised if the comments are listed across a number of pages rather than all running down a single long page.

These are broadly what I have in mind. I have to check to ensure I can be consistent across different displays.

[sparklywater]

These are broadly what I have in mind. I have to check to ensure I can be consistent across different displays.

great, thanks for considering our suggestions, I for one would be happy to test any alpha version of LDM you decide to release :)

[obmob]

Is it possible to disable comments, but keep rating options on? o.?

Thanks :D

[AndrewD]

Is it possible to disable comments, but keep rating options on? o.?

Thanks :D

I think that's already there in 2.2.9 - ldm/admin/settings/comments and ratings/hide comment + hide rate

[sparklywater]

If I add this line of code into a template, ' <!--$linkid::entities--> ' , only then the entities / attributes are displayed within the template. Is there a similar line of code I need to add to make the following variables work in other templates:

$linkeditbit
$linkfavbit
$linksendtofriendbit
$linkreportlinkbit
$linklikebit
$linkstarbit
$linknewbit

?

[AndrewD]

If I add this line of code into a template, ' <!--$linkid::entities--> ' , only then the entities / attributes are displayed within the template. Is there a similar line of code I need to add to make the following variables work in other templates:

$linkeditbit
$linkfavbit
$linksendtofriendbit
$linkreportlinkbit
$linklikebit
$linkstarbit
$linknewbit

?

There's two different points to consider -

a) the various link_linkbit_* templates can all use any of the variables that are used in the other templates - so you can freely mix and match among these templates.

b) however, the variables are built up in different ways (or not at all) depending on what you are doing. So for example, after a search, not all the variables are created. Similarly when rating/commenting, etc.

For any particular action, the same variables will always be created, regardless of the template. For different actions, different combinations of the variables are created. This is what I need to check carefully.

[sparklywater]

a) the various link_linkbit_* templates can all use any of the variables that are used in the other templates - so you can freely mix and match among these templates.

My problem is that I need to use the link_linkbit_* variables in either the 'links_play_embedded' template or the 'links_playerbit_RealPlayer' template, but they don't work in these templates. Can you please tell me in which php file these variables are defined to work only in the link_linkbit_* templates?

[Simon Lloyd]

Andrew D, can this be used to manage a users downloads if a user was to purchase a subscription and move in to a different usergroup for 1 day can a limit of 1 download be set, would i have to manually change the usergroup each time - i'm a complete novice in html and php and am just setting up my forum i want a pay per download section on my site, is this possible with this mod?

[stwilson]

2.2.9 is likely to stay the supported release for at least a couple of months, perhaps with a few more bug fixes applied.

I have done quite some work already on 2.3.0, but some of the suggestions and the bug reports posted here will take time to complete. Perhaps an early alpha will be available fairly soon, but thorough testing is the big challenge these days.

Coded so far for 2.3.0:

+ Category Display
Added option to display/remove keyword filter dropdown
+ Starred nominations
Entries can be unnominated
Nominations are no longer stacked, i.e. only user's current nomination is recorded
+ Session ids
vBulletin session ids handled corrrectly throughout
+ Efficiency changes
Admin and categories tables cached in vBulletin datastore and other code rewritten to eliminate various database lookups
+ Media Players
Upgraded JWsilverlight player to version 1.1 and added windowless and background params
+ Hooks
Added ldm_icons_cached after caching list of icon filenames
+ Bug fixes
Fixed id3tag-enhancements extra
Fixed permissions-related null category bug within Edit Entry
Fixed sort order/pagination bugs when searches contain urlencoded chars
Fixed Add LDM to VB navbar plugins for situation when vbAdvanced is not installed in forum directory

Still to do:

- Redo much of the 'attributes' code to fix bugs/improve functionality
- Provide import mechanism for vb attachments
- Move to jw media player 4.0
- Disentangle comments and ratings calculations
- Option to make comments/ratings visble inline consistently
- other bug fixes

Anything else?

Andrew,

Thank you. One other suggestion, a few more layout templates to choose from. :D AND just in case you have nothing else to do, the ability to integrate Google Maps into the link display page, via a latitude and longitude attribute, with a waypoint attribute too. I would pay for someone to custom develop that for me! hint...hint...:D

[AndrewD]

Andrew D, can this be used to manage a users downloads if a user was to purchase a subscription and move in to a different usergroup for 1 day can a limit of 1 download be set, would i have to manually change the usergroup each time - i'm a complete novice in html and php and am just setting up my forum i want a pay per download section on my site, is this possible with this mod?

Simon, yes, I think this will work

1- set up VB so that when users puchase a subscription, they are moved to usergroup XYZ
2- in LDM/admin/allowances, you give usergroup XYZ the right to download one file per day
3- give other usergroups zero allowance
4- in LDM/admin/permissions, you give usergroup XYZ *can_access*link* permission and deny it to other usergroups.
5- deny usergroups *can_bypass_bandwidth_limits* permission

5 if there are usergroups that you want to bypass these restrictions, then don't set any of their allowances.

If you want to apply the limit only to downloads in a particular category, follow steps 2 and 3 in the same way, but in place of step 4

6- in the defined category, edit/category/permissions, give/remove the *can_access_link* and *can_bypass_bandwidth_limits* permissions
7- in LDM/admin/permissions, give everyone *can_access_link* and *can_bypass_bandwidth_limits* permissions

My only uncertainty is how well the *day* start/end calculation in LDM will synchronise with vbulletin's calculation. You will need to test it to find out.

[derfelix]

While we are at it.. a little internetexplorer bug when editing keywords..

ok we are at the normal display page.. with a page with 20 entries..
each entry (depending of the template you are using) allows you as admin to edit keywords inline..

works fine (I modified the template a little bit)
BUT if you toggle the tag graphic the word "keywords" appears and a field where you can edit the keywords of this entry.. and a go button..

if you click the word "keywords" it goes back to the tag symbol...

In IE7 it acts weird.. because the link is linked to a jumpmark that doesnt really exist.. #$linkid
and it eventually reloads the page.. or pushes the link to the top of the screen when you edit it.. (adding the jumpmark #$linkid to the url)

I fixed it that way:
the link in the template is:
<a href="#{$linkid}" onclick="ldm_show('keys{$linkid}_', 1, 2);">$vbphrase[ll_keywords]</a>
i changed it to:
<a href="#" onclick="ldm_show('keys{$linkid}_', 1, 2);return false;">$vbphrase[ll_keywords]</a>
It has to be done twice (also for the tag image when you toggle).. otherwise IE will jump to the link.. this is NOT the way it should act (imho).. because:

if you are editing the last link on the page... it will open the editfield (as it should) but will then "jump" to that link.. so if you had it in the middle of the page.. it will scroll that link to the top of the page..
It's the same when you close the editbox when klicking on the word: "keywords"
(grrr hope you understood what i meant)


Anyway there should at least be a: return false; at the end of the "onclick" stuff..

Felix

PS: I also removed the $linkid leaving only the # thinking there is no point jumping to that link because you are allready at that link..(i might be wrong)

[Simon Lloyd]

Andrew D, thanks for the very detailed information, i have VBAdvanced, Donations Pro and Mark Solved Mods is your's ok with these? I'm a novice so is it easy to install?

Regards,
Simon

[AndrewD]

Andrew D, thanks for the very detailed information, i have VBAdvanced, Donations Pro and Mark Solved Mods is your's ok with these? I'm a novice so is it easy to install?

Regards,
Simon

Certainly ok with vbadvanced - don't know about the others - not had any reports of problems. Installation is straightforward, but am here to help in case of problems.

[Simon Lloyd]

Andrew, thanks for the responses!, i'm running 3.7.2 PL1 and am going to install this, will post back.

Regards,
Simon

[Simon Lloyd]

Andrew, in your instructions:
Upload all the contents of /release/forum and its subdirectories into the corresponding forum directories
(i.e. clientscript/ into clientscript/, includes/ into includes/, etc. i understand that this means open the folder in LDM and copy contents to corresponding folder in /forum, however inside these folders are folders marked XML and ldm-ox-icons do these just get uploaded to the corresponding parent folder (i.e Includes for the XML) without opening and copying the contents?, also the other files in the /forums folder i.e local_link's eyc do they just go in my /forum folder?

Regards,
Simon

[AndrewD]

Andrew, in your instructions:
i understand that this means open the folder in LDM and copy contents to corresponding folder in /forum, however inside these folders are folders marked XML and ldm-ox-icons do these just get uploaded to the corresponding parent folder (i.e Includes for the XML) without opening and copying the contents?, also the other files in the /forums folder i.e local_link's eyc do they just go in my /forum folder?

Regards,
Simon

The files and directory structure inside release/forums should be copied into exactly the same directory structure in your /forum folder, i.e. files in release/forum/includes/xml go into forums/includes/xml and so on. The only folder which will not already exist is the images/ldm-ox-icons

[chet]

I seem to have usergroup permision problems

I have set up two categorys, one usergroup should be able to see both category's and entries within the category's, the second usergroup should only be able to see just one category and the entries within.

The second usergroup can see the category but not the entries, I can the following when I try to access the Category: -

Sorry - there is nothing to show you (no permisions, all entries are hidden, etc)

Can you let me know where I have gone wrong please

Club officals can view both, Team managers have the problem

Cheers

Chet

https://vborg.vbsupport.ru/external/2008/08/38.jpg

[Simon Lloyd]

Andrew, sorry to be a pain, can you tell me where the vba_modules and extra's folders go as i don't have these in my configuration?

[vbboarder]

I have some feature requests for LDM 2.3.0 or another future update:

1. Allow featured_user_favs to accept usergroups such that all users in that group will have their favorites featured (ie: favorites of all users in VIP group are featured).

2. Use settings in vBulletin's "search relevance options" to order searches.

3. Provide an option for similar_threads plugin to search only in the same category as the entry being searched.

4. Integrate LightWindow into LDM and provide an option to make it the default Flash/ PDF/ image/ video player. LightWindow is a very versatile and robust solution for displaying many file types with just one script (don't need to combine multiple scripts like Lightbox + JW/ Wimpy players). Also, it's free and MIT-licensed so it's less strict than the creative commons license of Lightbox & JW players. Check it out here: http://stickmanlabs.com/lightwindow/#features

5. Need fix for this bug: When editing an entry, the user is able to upload another file (the file is saved in the upload directory), but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated.

Thanks for this great mod and helpful contributions! :D

[AndrewD]

Andrew, sorry to be a pain, can you tell me where the vba_modules and extra's folders go as i don't have these in my configuration?

Simon, these don't get uploaded and you can ignore them unless you need them. vba_modules contains a set of modules to integrate LDM inside vbadvanced. extras contains a whole series of 'specials', mainly in the form of vbulletin plugins, which in some way extend LDM. Each of the extras sits in its own subdirectory with a 'readme' file explaining what it does and how to use it.

By the way, have you found the wiki at www.eirma.org/wikis, which explains a lot about LDM.

[AndrewD]

I have some feature requests for LDM 2.3.0 or another future update:

1. Allow featured_user_favs to accept usergroups such that all users in that group will have their favorites featured (ie: favorites of all users in VIP group are featured).

2. Use settings in vBulletin's "search relevance options" to order searches.

3. Provide an option for similar_threads plugin to search only in the same category as the entry being searched.

4. Integrate LightWindow into LDM and provide an option to make it the default Flash/ PDF/ image/ video player. LightWindow is a very versatile and robust solution for displaying many file types with just one script (don't need to combine multiple scripts like Lightbox + JW/ Wimpy players). Also, it's free and MIT-licensed so it's less strict than the creative commons license of Lightbox & JW players. Check it out here: http://stickmanlabs.com/lightwindow/#features

5. Need fix for this bug: When editing an entry, the user is able to upload another file (the file is saved in the upload directory), but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated.

Thanks for this great mod and helpful contributions! :D

Noted - will see what I can do - some of these are straightforward but the tricky one looks like (2)

[AndrewD]

I seem to have usergroup permision problems

I have set up two categorys, one usergroup should be able to see both category's and entries within the category's, the second usergroup should only be able to see just one category and the entries within.

The second usergroup can see the category but not the entries, I can the following when I try to access the Category: -

Sorry - there is nothing to show you (no permisions, all entries are hidden, etc)

Can you let me know where I have gone wrong please

Club officals can view both, Team managers have the problem

Cheers

Chet

https://vborg.vbsupport.ru/attachment.php?attachmentid=85454&stc=1&d=1218729968

The forum-based permission system is a bit tricky to understand. It was the original protection mechanism I wrote for LDM, and it is applied separately to categories and entries (i.e. entries in categories can have different permissions than the category). LDM's own permissions system is applied at the category level, so you don't have that possible confusion.

I think your problem is that you have not correctly associated the entries in your categories with the correct forums. This is shown by the information on the screenshot you posted - the categories are associated correctly with the different forums but both your entries have been associated with the same forum.

The category and all the entries which are to be visible to Club Officials and Team Managers should be associated with the Team Members forum.

The category and all the entries which are to be visible to Club officials only should be associated with the Club Officials forum.

You can make the changes in a number of ways - with edit category and checking the box 'Also make this forum the parent of all entries currently in the category' or with edit entry, or on the admin/mass edits pages.

For what you are trying to achieve, you could also (instead of using the forums based permissions system) use LDM's own permissions. Edit the categories, select the usergroup permissions tab and give/deny *can_view_category* permission.

Hope this helps, but get back to me if not.

[pooslokka]

Hai guys,
just installed and this is a wonderfull Plugin. We had no any issues in installing.
Cheers to the developer !

[Simon Lloyd]

Simon, these don't get uploaded and you can ignore them unless you need them. vba_modules contains a set of modules to integrate LDM inside vbadvanced. extras contains a whole series of 'specials', mainly in the form of vbulletin plugins, which in some way extend LDM. Each of the extras sits in its own subdirectory with a 'readme' file explaining what it does and how to use it.

By the way, have you found the wiki at www.eirma.org/wikis, which explains a lot about LDM.I'm using vbadvanced so do i need to place the contents of the vba folder somewhere? As for the wiki im checking that now!

Regards,
Simon

[AndrewD]

I'm using vbadvanced so do i need to place the contents of the vba folder somewhere?


No - just keep them on your PC. If you decide to use any of the LDM vba modules, you simply upload them via your vb admincp/vba/download upload modules

[AndrewD]

5. Need fix for this bug: When editing an entry, the user is able to upload another file (the file is saved in the upload directory), but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated.


I can't reproduce this bug - my tests replace the upload and update the allowances - can you give me more details

[Simon Lloyd]

Andrew, i've installed it, just have to configure it now, it's a vast add-on! seems really great, such a lot of work gone in to it once again thanks ;)

Hey guys, if you use this mod donate as i did to give this guy the motivation to keep helping us and coming up with great things like this!

[pooslokka]

Hai Andrew,

Ok, every think configured and woks nicely. I have a question.

When i click the subforum that created when creating a catagory, page cannot disply appear. some problem with the link. how to solve that?

Thank you for making this useful plugin.

[AndrewD]

While we are at it.. a little internetexplorer bug when editing keywords..

ok we are at the normal display page.. with a page with 20 entries..
each entry (depending of the template you are using) allows you as admin to edit keywords inline..

works fine (I modified the template a little bit)
BUT if you toggle the tag graphic the word "keywords" appears and a field where you can edit the keywords of this entry.. and a go button..

if you click the word "keywords" it goes back to the tag symbol...

In IE7 it acts weird.. because the link is linked to a jumpmark that doesnt really exist.. #$linkid
and it eventually reloads the page.. or pushes the link to the top of the screen when you edit it.. (adding the jumpmark #$linkid to the url)

I fixed it that way:
the link in the template is:
<a href="#{$linkid}" onclick="ldm_show('keys{$linkid}_', 1, 2);">$vbphrase[ll_keywords]</a>
i changed it to:
<a href="#" onclick="ldm_show('keys{$linkid}_', 1, 2);return false;">$vbphrase[ll_keywords]</a>
It has to be done twice (also for the tag image when you toggle).. otherwise IE will jump to the link.. this is NOT the way it should act (imho).. because:

if you are editing the last link on the page... it will open the editfield (as it should) but will then "jump" to that link.. so if you had it in the middle of the page.. it will scroll that link to the top of the page..
It's the same when you close the editbox when klicking on the word: "keywords"
(grrr hope you understood what i meant)


Anyway there should at least be a: return false; at the end of the "onclick" stuff..

Felix

PS: I also removed the $linkid leaving only the # thinking there is no point jumping to that link because you are allready at that link..(i might be wrong)

I can't reproduce this, but I can see what you saying and have coded the change (also got rid of some duplicate text that I'd put in there for debugging quite a while ago and forgot about...)

[AndrewD]

Hai Andrew,

Ok, every think configured and woks nicely. I have a question.

When i click the subforum that created when creating a catagory, page cannot disply appear. some problem with the link. how to solve that?

Thank you for making this useful plugin.

I don't think I understand - it seems to work ok for me. May I take a look at your site? (send me a PM)

[pooslokka]

One more question.
I dont want the uploads to go in to a forum as a new thread? is it possible to do that?

Edited :

Since now the category forum works, i think it is alright to have this function :D Tx.

[pooslokka]

Hai Andrew,

Ok, every think configured and woks nicely. I have a question.

When i click the subforum that created when creating a catagory, page cannot disply appear. some problem with the link. how to solve that?

Thank you for making this useful plugin.

This problem ok, Solved.
I have posted another question. Pls help.

[pooslokka]

Another question .

i uploaded an MP3

Upload error - file is larger than maximum size allowed. but the size was 510k.

i have specified 800K :(

* THIS file type has not listed in vb
* after specifying the size and save, the file type table of LDM does not show the size 800k in it file types table.

Edited : Sorry, it takes little time to understand each options. Just now find the solution. Thank You.

[ccole513]

For your next release Andrew do you think it would be possible to add an option that would bypass the timeout hit limit based on usergroup premissions?

[Stilgar]

I'm having a little trouble after installing 2.2.9-post2. The new image permissions don't seem to work correctly. I have it set so that two of the three Usergroups that can post links, can also add thumbnails. However, the thumbs do not show. There is a space where the thumb should be, but the image is not there.

The Thumbnails do show when viewing the Category in the "Short Entries" version.

Thanks for your help,

James

[AndrewD]

I'm having a little trouble after installing 2.2.9-post2. The new image permissions don't seem to work correctly. I have it set so that two of the three Usergroups that can post links, can also add thumbnails. However, the thumbs do not show. There is a space where the thumb should be, but the image is not there.

The Thumbnails do show when viewing the Category in the "Short Entries" version.

Thanks for your help,

James

Sorry to hear that there is still a problem. I find these very difficult to debug without direct access to the site - do you mind if I take a look? I will need admin access (send me a PM).

[yahoooh]

i really suggest and need the comments and rate show in the same page of entry
like vbulletin thread

this make eazy and perfect show of the entry in LDM

[kevinh]

Is it possible to upload multiple images for one LDM entry? (just as you can allow multiple images to be attached to a forum post)

Thanks,
Kevin

[AndrewD]

Is it possible to upload multiple images for one LDM entry? (just as you can allow multiple images to be attached to a forum post)

Thanks,
Kevin

Yes, using the "Entry Attributes" features introduced in 2.2.9. Use LDM/admin/Entry attributes to set up one or more attributes as images or image uploads, then the Add/Edit entry form will expand to alow you to provide these.

[Simon Lloyd]

Andrew, thanks for your help last night!, can i ask is it possible (as mostly i intend my downloads to be text files) to have an excerpt or uncopiable show (including scrollbars) of the text in the item window? just so the folk can see what they are getting but can't copy it until they are in the download usergroup?

[yahoooh]

also caotcha image for unregistered users when they download i do not wanna prevent the download for them but i need captcha iamges which is perfect than any other option
and need this only for download not for play media file

thank u very much

[vbboarder]

I can't reproduce this bug - my tests replace the upload and update the allowances - can you give me more details

I'm using VB 3.7.2, LDM 2.2.9-post1, Firefox 2, Windows XP (SP2). My upload folder is located within the public htdocs folder. I am testing with administrator privileges in VB/ LDM. I am using LDM's extra swfuploader plugin.

When editing an entry, the user is able to upload another file (the file is created in the upload directory), but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated. For example, I had an entry with an uploaded file called first.mp3. I edited that entry to change the uploaded file to second.mp3. The new file was created, but after saving the edit, the new mp3 did not play instead the old mp3 still played since it wasn't deleted and the user upload allowance was not updated.

Also, if the file extension of the new file is different from the old file, the "Rename" field will not accept a name with the new file extension since LDM still has the old file extension in the database.

Suggestion: If you can't fix this problem, can you PLEASE provide an option to disable changing the file upload when editing an entry? The user is still allowed to delete the file upload and edit the entry, just don't allow the user to edit the file upload. PLEASE provide this option in your next update if you can't fix this problem.

Note: found partial solution to this problem - read my next post.

[vbboarder]

I found the cause to this problem: When editing an entry, the user is able to change the file uploaded, but the new file does not show (file is not linked to in the entry) and his upload allowance is not updated.

This bug persists if you installed LDM's extra swfuploader plugin (problem described in my previous post). If you use the default uploader, this problem does not appear. Solution: disable/ uninstall the swfuploader until that plugin is fixed. ;)

Andrew, can you please patch the swfuploader 'cause having the progress bar is really useful? Otherwise, please provide an option to disable changing the file upload when editing an entry.

[vbboarder]

I have several more bugs to report:

1. In LDM settings, the link_imagesize setting states, "Left blank: LDM uses the current value of Thumbnail Size from the VB admincp." However, this is not true: if left blank, no thumbnails are created even if thumbnail size is specified in VB > Message Attachment Options and VB > Album Options (anywhere else I should check?). Solution: just specify the size for LDM's link_imagesize.

2. The category of a forum is not replaced in the phrase when using {4} in ldm_thread_create_body. Instead, the LDM database name is always shown.

3. The id3tag-enchancements plugin does not update the entry's attributes with the new id3 info if the entry is edited to upload a new file that has a id3 tag.

4. When editing an entry with both an uploaded file and an image file, if that image is deleted then the uploaded file is also deleted. Andrew in addition to fixing this bug, can you provide an option to disable deleting the thumbnail image file?

[vbboarder]

The plugin, Add LDM Quick Search to VB navbar, does not work because the code/ syntax for the security token is incorrect.
Solution: FIND:
<input type="hidden" name="securitytoken" value="$bbuserinfo[securitytoken]" />

And REPLACE that with:
<input type="hidden" name="securitytoken" value="' .$vbulletin->userinfo['securitytoken'].'" />

[AndrewD]

I'm using VB 3.7.2, LDM 2.2.9-post1, Firefox 2, Windows XP (SP2). My upload folder is located within the public htdocs folder. I am testing with administrator privileges in VB/ LDM. I am using LDM's extra swfuploader plugin.


As you discovered, this was a problem in the interaction between the ldm php code and the swfupload code. The fix is straightforward - please can you test the attached local_links_actions.php (which goes in the forums directory)

Also, if the file extension of the new file is different from the old file, the "Rename" field will not accept a name with the new file extension since LDM still has the old file extension in the database.


If you are using the swfuploader, its javascript should automatically fill in the "Rename" field with the filename of the current upload, and as far as I can see, LDM then accepts it with this bug fix installed. Let me know.

1. In LDM settings, the link_imagesize setting states, "Left blank: LDM uses the current value of Thumbnail Size from the VB admincp." However, this is not true: if left blank, no thumbnails are created even if thumbnail size is specified in VB > Message Attachment Options and VB > Album Options (anywhere else I should check?). Solution: just specify the size for LDM's link_imagesize.


LDM only checks this when you do an update on the LDM/admin/settings page, and leave the link_imagesize field blank. As far as I can see, it then correctly picks up the current value from VB/Message Attachment Options, and that value should then appear on the LDM admin settings and is used correctly. However, I think my logic is wrong - this doesn't allow for the possibility that the admin subsequently changes the value on VB/Message Attachment Options

2. The category of a forum is not replaced in the phrase when using {4} in ldm_thread_create_body. Instead, the LDM database name is always shown.


I think this has always been so. I'll add another parameter to the phrase so that you can also access the category name if you wish.

3. The id3tag-enchancements plugin does not update the entry's attributes with the new id3 info if the entry is edited to upload a new file that has a id3 tag.


will investigate

4. When editing an entry with both an uploaded file and an image file, if that image is deleted then the uploaded file is also deleted. Andrew in addition to fixing this bug, can you provide an option to disable deleting the thumbnail image file?

will investigate

The plugin, Add LDM Quick Search to VB navbar, does not work because the code/ syntax for the security token is incorrect.


Thanks - this was fixed in the 2.2.9-post2 release

[Espeacke]

Hello ...
First good day and apologize for my English is bad. [I come from mexico]
I have a question:

The problem is with the entries of their product ..
My links appear like this:

http://img128.imageshack.us/img128/7649/dibujoce0.jpg

Any disorderly.

And I have seen other sites with links and downloads manager running the links as categories:

clicking on this entry:
http://img229.imageshack.us/img229/1707/dibujo1vy6.jpg
It will take us towards the link:

http://img201.imageshack.us/img201/1606/dibujo2og0.jpg

Thus not much disturbing and we do not have so many links on a single page.
I tried to move and move configurations rather than achievement that appear so.
Someone told me that configurations are templates and that is why I am writing to you.

Greetings.

sorry if this repeated the
question:D. not understand much English.

[AndrewD]

Hello ...
First good day and apologize for my English is bad. [I come from mexico]
I have a question:

The problem is with the entries of their product ..
My links appear like this:

http://img128.imageshack.us/img128/7649/dibujoce0.jpg

Any disorderly.

And I have seen other sites with links and downloads manager running the links as categories:

clicking on this entry:
http://img229.imageshack.us/img229/1707/dibujo1vy6.jpg
It will take us towards the link:

http://img201.imageshack.us/img201/1606/dibujo2og0.jpg

Thus not much disturbing and we do not have so many links on a single page.
I tried to move and move configurations rather than achievement that appear so.
Someone told me that configurations are templates and that is why I am writing to you.

Greetings.

sorry if this repeated the
question:D. not understand much English.

Yes, I think I understand.

You can change how LDM looks with the settings on the LDM/admin/settings page. To get the very compact look in your second image, find the template_linkbit parameter and choose "Title Only".

But your colleague is also correct - to make major changes, then you have to edit the templates. vBulletin is built around a large number of templates which define how everything is displayed. This is not really the best place to explain.

[Espeacke]

But your colleague is also correct - to make major changes, then you have to edit the templates. vBulletin is built around a large number of templates which define how everything is displayed. This is not really the best place to explain.


I mention this as you configure and salio as we wanted.
For need additives templates?
And where addressing the issue?

In the meantime Thank your help.
Greetings.:D

[vbboarder]

Hi Andrew, your new local_links_actions.php works flawlessly! It corrects the mentioned problems regarding changing the uploaded file when editing an entry.

LDM only checks this when you do an update on the LDM/admin/settings page, and leave the link_imagesize field blank.
The link_imagesize setting in LDM settings does not retrieve the size from VB > Message Attachments when I update the LDM settings page.

I think this has always been so. I'll add another parameter to the phrase so that you can also access the category name if you wish.
Please do add the category parameter for {4} - it would be very useful. The LDM wiki actually states {4} is replaced with category for ldm_thread_create_body.

[vbboarder]

I have a few more feature requests:

1. Modify id3tag-enhancements plugin to auto-create entry attributes for video files. Currently, it only uses the id3 info to size the video player.

2. It's confusing for users to see both the File URL and File Upload textfields. Can you combine them so that only 1 textfield is used for the File URL & Upload - should be do-able since URL's & file paths are different.
If not possible, can you at least combine those 2 textfields into 1 table row so that they don't appear as separate entities. Similarly, this visual problem occurs for Image URL and Image Upload, so a change in that presentation would also be much appreciated.

3. LDM should auto-create blank index.html for files & thumbnails LDM directories to help prevent users from directly accessing the files in those directories.

Thanks for considering these requests. ;)

[ErnieTheMilk]

Thanks for this, nice job

Could someone advise me how to change the wording in the navbar from links/downloads to something else please.

Thanks

[obmob]

I think that's already there in 2.2.9 - ldm/admin/settings/comments and ratings/hide comment + hide rateOM! Oo

Let me see if it is what I want, thanks Andrew

[AndrewD]

Thanks for this, nice job

Could someone advise me how to change the wording in the navbar from links/downloads to something else please.

Thanks

You need to edit the vbulletin phrase ldm_vbmenu_ldm - vb/admincp/languages/search in phrases

[ErnieTheMilk]

You need to edit the vbulletin phrase ldm_vbmenu_ldm - vb/admincp/languages/search in phrases

Thanks Andrew, when I do a search as you say the message returned is -

No Phrases Matched Your Query

Any ideas?

[AndrewD]

Thanks Andrew, when I do a search as you say the message returned is -

No Phrases Matched Your Query

Any ideas?

Are you searching against the phrase title - by default, the searches look at the text

[TsirhCitna]

Is there anyway to add a screenshot for downloads? I found the extra for links, but I have been unable to find a way other than an external upload for download screenshots.

[AndrewD]

Is there anyway to add a screenshot for downloads? I found the extra for links, but I have been unable to find a way other than an external upload for download screenshots.

You can add a thumbnail image to any entry, either at the time you create the entry or by editing it. There is an extra available which will automatically extract an image from the ID3 tag data for mp3 files. However, there is currently no automated process for generating thumbnails of other documents, although I've recently been pointed towards a couple of tools for doing this.

Which file formats are of interest?

[ErnieTheMilk]

Are you searching against the phrase title - by default, the searches look at the text

Many thanks Andrew, I changed the 'search in' option from Phrase Text Only to Phrase Text and Phrase Variable Name and it worked like a charm :)

[Stilgar]

Sorry to hear that there is still a problem. I find these very difficult to debug without direct access to the site - do you mind if I take a look? I will need admin access (send me a PM).


Yes, please find my PM with site access.

Thank you, Andrew,

James

[Stilgar]

It would also seem that if I deny a UserGroup the ability to upload files, it also turns off their ability to upload images. Is there a way to avoid this? It would be great to allow them to upload images and not other file types.

[TsirhCitna]

You can add a thumbnail image to any entry, either at the time you create the entry or by editing it. There is an extra available which will automatically extract an image from the ID3 tag data for mp3 files. However, there is currently no automated process for generating thumbnails of other documents, although I've recently been pointed towards a couple of tools for doing this.

Which file formats are of interest?Exe, Rar, Zip, Dmg, etc.

Basically just another upload box specifically for adding screenshots would be perfect.

[AndrewD]

Exe, Rar, Zip, Dmg, etc.

Basically just another upload box specifically for adding screenshots would be perfect.

Is the existing image thumbnail feature sufficient? - you can upload screenshots with that. You enable this with ldm/admin/settings/link_imagesize and related settings

[aktifnet]

demo?

[TsirhCitna]

Is the existing image thumbnail feature sufficient? - you can upload screenshots with that. You enable this with ldm/admin/settings/link_imagesize and related settingsAh!

It seems that if you leave it blank (to use vBulletin size) it doesn't show up.

[AndrewD]

Ah!

It seems that if you leave it blank (to use vBulletin size) it doesn't show up.

You are the second person to report this, so there is clearly a bug which I have missed.

[BeFit4Free]

How do we use this as a link exchange?

[GrendelKhan{TSU]

Hey Andrew... I think I asked this like.... couple years ago (lol) and given all the add-ons maybe I just missed it...


is there a, safe or usergroup-based, way to hotlink to a file after its been uploaded?

goal: I want to hotlink the file to a mp3 player in one's profile and a jukebox player play list.


ps. keep up the awesome work as usual. still one of the best add-ons aruond :)

[blackwolfcds]

Good morning,

First, a big thank you for this wonderful module.

I have a problem with the "filter".
I have a category which includes many files (more than 20000 for some).
If you choose a filter, for example the letter "B", only the first page complies.
If you click on page 2, for example, the filter cancels ...

I tried with versions post1 and post2, and invariably the same problem.

If someone can help me, it would be very nice.

Thank you in advance.

[AndrewD]

Good morning,

First, a big thank you for this wonderful module.

I have a problem with the "filter".
I have a category which includes many files (more than 20000 for some).
If you choose a filter, for example the letter "B", only the first page complies.
If you click on page 2, for example, the filter cancels ...

I tried with versions post1 and post2, and invariably the same problem.

If someone can help me, it would be very nice.

Thank you in advance.

You are right, this is a bug. I will fix in the upload when possible.

Edited: In the meantime, if you want to fix it yourself, edit local_links.php in your forum directory. Find the following code (around line 675):


$pagenav = construct_page_nav($pagenumber, $thispage, $nhits, $LINKS_SCRIPT.".php?catid=$viewcatid&amp;sort=$sort", "&amp;pp=$thispage");


and replace with


$pagenav = construct_page_nav($pagenumber, $thispage, $nhits, $LINKS_SCRIPT.".php?catid=$viewcatid&amp;sort=$sort".(strlen($viewfilter) ? "&amp;filter=$viewfilter" : ""), "&amp;pp=$thispage");

[Stilgar]

How can I limit a usergroup to only being able to add one Link to the list?

Also, Where can I change $linkimgjump ? I would like to change the image's link to go to:

<a href="member.php?u=$linkuserid">$linkusername</a>


Thanks!

p.s. Andrew, I was able to allow images to be displayed on the directory. I just used the File Upload instead of the Image upload. Then I just limited the files available for upload to only image file types. It adds the Thumbnails just as I wanted. Now all I have to do is edit out the file links so members are not trying to download the thumbs. Thanks for all your help!

James

[blackwolfcds]

You are right, this is a bug. I will fix in the upload when possible.

Edited: In the meantime, if you want to fix it yourself, edit local_links.php in your forum directory. Find the following code (around line 675):


$pagenav = construct_page_nav($pagenumber, $thispage, $nhits, $LINKS_SCRIPT.".php?catid=$viewcatid&amp;sort=$sort", "&amp;pp=$thispage");


and replace with


$pagenav = construct_page_nav($pagenumber, $thispage, $nhits, $LINKS_SCRIPT.".php?catid=$viewcatid&amp;sort=$sort".(strlen($viewfilter) ? "&amp;filter=$viewfilter" : ""), "&amp;pp=$thispage");


Thank you very much :)

I edited the file local_links.php as you said and now it works correctly :up:

[AndrewD]

How can I limit a usergroup to only being able to add one Link to the list? not currently an option - would require writing some extra code or a plugin

Also, Where can I change $linkimgjump ? I would like to change the image's link to go to:

<a href="member.php?u=$linkuserid">$linkusername</a>



linkimgjump is set up in includes/local_links_include.php, function ldm_get_entrybits. The clean way to modify it as you want is to create a small plugin tied to the ldm_linkbit_create hook.

[Stilgar]

Ok, sounds good. Thank you.

How can I change the Link Title displayed in links_linkbit ($linkurljump) to be linked to the member's forum profile?

Added: Nevermind, I found it!

<a href="member.php?$session[sessionurl]u=$linkuserid">$linkname</a>


Thanks! :)

[exportforce]

Hello,

just wanted to try this one, but every time I try to do something, it comes up, that some securitytoken would be wrong or missing...
I am running 3.7.2. pl2

any tips ?

edit:
Also when I try to uninstall it, it just gives me a blank site.
Could you please post an uninstaller, so I can clean it up and reinstall it ?

[sparklywater]

Why can we not enter percentage values for the 'link_imagemagsize' setting? For example 100% would mean cover full screen of user. Also, why is there only one dimension setting in 'link_imagemagsize', why not both width and height?

[AndrewD]

Hello,

just wanted to try this one, but every time I try to do something, it comes up, that some securitytoken would be wrong or missing...
I am running 3.7.2. pl2

any tips ?

edit:
Also when I try to uninstall it, it just gives me a blank site.
Could you please post an uninstaller, so I can clean it up and reinstall it ?

For the security token, check that you did not patch any of the templates before vbulletin introduced this mechanism. This could leave you with obsolete forms.

There should be no problem uninstalling via the standard vbulletin/admincp/products section. The uninstaller leaves the database tables intact, but this would not create a blank screen.

Blank screens are often a sign of a php bug somewhere. Have you tried vb/admincp/settings/ turn off gzip compression

[AndrewD]

Why can we not enter percentage values for the 'link_imagemagsize' setting? For example 100% would mean cover full screen of user. Also, why is there only one dimension setting in 'link_imagemagsize', why not both width and height?

I did wonder about allowing percentages for the image size. However, there's a problem - when you use a percentage in html, you are (afaik) refering to a percentage of the container size in which the item sits, not a percentage of screen size. A size of something specified as "100%" would depend on the specifications for other features on the board and would not mean "full page width". It could also vary with choice of template. It seems less confusing to stick with pixel sizes.

Again, I wondered about having both width and height parameters, but this would end up distorting pictures - by using only one value, the code can maintain the aspect ratio of the picture.

Am open to discussion

[sparklywater]

Again, I wondered about having both width and height parameters, but this would end up distorting pictures - by using only one value, the code can maintain the aspect ratio of the picture.

Am open to discussion


I can understand the importance of maintaining aspect-ratio, but I found one problem with the LDM imagemagsize setting. This setting sets the size of the image 'along larger dimension', and this becomes problematic if the image has a larger width than height (which is usually the case). This is because having a fixed width means that the height of the image varies according to the original size of the image, and this sometimes results in images having heights too large for the screen. What would be more useful is to have the 'imagemagsize' set the HEIGHT of the image rather than the width, which would then allow the width of the image to vary according to the aspect-ratio of the original picture. This would cause less problems because obviously the screen of the user is wider than the screen's height, so it can allow for more variability in the horizontal direction.

[AndrewD]

I can understand the importance of maintaining aspect-ratio, but I found one problem with the LDM imagemagsize setting. This setting sets the size of the image 'along larger dimension', and this becomes problematic if the image has a larger width than height (which is usually the case). This is because having a fixed width means that the height of the image varies according to the original size of the image, and this sometimes results in images having heights too large for the screen. What would be more useful is to have the 'imagemagsize' set the HEIGHT of the image rather than the width, which would then allow the width of the image to vary according to the aspect-ratio of the original picture. This would cause less problems because obviously the screen of the user is wider than the screen's height, so it can allow for more variability in the horizontal direction.

OK, that makes sense. I'll give it a try.

[sparklywater]

OK, that makes sense. I'll give it a try.

If you make the change please let me know how I can edit my current installation for the new setting. It would particularly improve the 'lightbox' display of images.

[AndrewD]

If you make the change please let me know how I can edit my current installation for the new setting. It would particularly improve the 'lightbox' display of images.

If you want to make the change yourself, try the following:

edit includes/lcal_links_resize.php

find, around line 145:


$thumb_w = ($old_x >= $old_y ? (int) ($size) : (int) ($size*$old_x/$old_y));
if ($thumb_w>$old_x) {
$thumb_w = $old_x;
}
$thumb_h = (int) ($thumb_w*($old_y/$old_x));


if you want to force the pictures to be the defined height, replace these lines by:


$thumb_h = $size;
$thumb_w = (int) $size * $old_x/$old_y;


ditto, to force the width:


$thumb_w = $size;
$thumb_h = (int) $size * $old_y/$old_x;

[ErnieTheMilk]

This is such a great hack... thank you!

I am having a small problem of when I use it, I am being logged out and being asked to log back in, is there anything I can do about this, or something I am doing wrong to put this right!

[AndrewD]

This is such a great hack... thank you!

I am having a small problem of when I use it, I am being logged out and being asked to log back in, is there anything I can do about this, or something I am doing wrong to put this right!

Check how you've got your board url and forum defined on your vb/admincp/options. Most times when I hear this problem, it's because people are using www . sitename . com to get to the site but have defined it on the vbadmincp as sitename . com. The consequence is that the logon cookie disappears when you move between pages inside ldm.

[ErnieTheMilk]

it's because people are using www . sitename . com to get to the site but have defined it on the vbadmincp as sitename . com.

Great job Andrew, blinking marvellous! :D :up:

[vbboarder]

If your site contains Quicktime media files, you may want to advise your users of this:
Quicktime media will not play or will play without the player's controls bar if the mime types are not set in the user's browser. This may occur for other media types also (Windows, Real, etc), but I have only verified this problem with Quicktime. Solution:

The USER must edit their Quicktime's browser preferences: In Quicktime, go to Edit > Preferences > Quicktime Preferences > Browser > MIME Settings (located at bottom of Browser tab) > select the mime types that you want Quicktime to play. For best compatibility, I selected Quicktime movie (mov, qt), aac, mpeg-4, 3gpp, 3gpp2, qhtm. Click "OK", then "Apply", then "OK" again. Your users should now be able to play Quicktime media files :D

[vbboarder]

The default mime type for avi files (video/avi) does not work in Firefox. The correct mime type is: application/x-mplayer2
You can set that in VB in the control panel on the left side: select Attachments > Attachment Manager > Edit avi > then for mime type, type in: Content-type: application/x-mplayer2
That should do it, you can now play avi files in both IE and Firefox :D

[vbboarder]

Bug report: Real media will not play in IE browser. The solution requires 2 steps:
1. In VB control panel on the left side: select Attachments > Attachment Manager > Edit all file types that you want Real to play (ie: ra, rv, rm, etc.) > then for each file type, type in for mime type: Content-type: audio/x-pn-realaudio

2. Edit local_stream.php (in the forum root folder) so that the mime type is only changed for NON-IE browsers. Around line 143, FIND:

foreach ($mimetype as $k=>$mime) {
if (preg_match("/-real/", $mimetype[$k])) {
$mimetype[$k] = "Content-type: audio/x-pn-realaudio-plugin";
}
}


And REPLACE that with:

// MODIFIED to change mime type ONLY IF browser is NOT Explorer (!is_browser('ie') does not work for IE7, but can check for other browsers)
require_once(DIR . '/includes/functions.php');
if (is_browser('firefox') || is_browser('safari')) {
foreach ($mimetype as $k=>$mime) {
if (preg_match("/-real/", $mimetype[$k])) {
$mimetype[$k] = "Content-type: audio/x-pn-realaudio-plugin";
}
}
}


Real media should be able to play in both IE and Firefox :D

[vbboarder]

Bug report: JWPlayer can play mp4 & m4v files when viewing the entry itself, but the player does not show when viewing a category's list of entries. It should show the player for mp4 & m4v files because the same player shows for flv, swf, & mp3 files when viewing a category's list of entries. Andrew, I can help fix this bug if you can advise me which file/ where to edit?

[vbboarder]

Not sure if this is a LDM bug or IE7 (Windows XP) bug: IE7 will pop up a notification stating that "IE can't open the page" and the "operation was aborted" when loading a page that has a video larger than ~5 MB. However, the page still loads fine and the video plays (testing non-Flash videos that are 20 MB).

[vbboarder]

Bug report: I discovered a serious conflict for file types that are set by the user to be played by Quicktime. For Quicktime file types, if a non-Quicktime player is set with a higher priority in LDM than the Quicktime player, then both players will show up on top of each other in the browser. More seriously, Firefox will become unresponsive (but can still be terminated).

The source of this bug stems from 2 sources: LDM and Quicktime. LDM because it creates an object tag for the highest priority player, and Quicktime because it allows users to set mime types in the browser. This problem may occur for other media types also (Windows, Real, etc), but has only been verified for Quicktime. Changing the mime types in VB will NOT fix the problem.

Solution: Change the media players priority in LDM so that Quicktime has the highest priority for all Quicktime file types. In VB control panel on the left side, select Links and Downloads > Players > then give Quicktime a high priority like 20 so that it's higher than the Windows & Real players. Now only the Quicktime player should show and not freeze up Firefox :D

[vbboarder]

Bug report: Ok, this is probably the most difficult bug I've come across thus far since I've used VB. Spent a whole day :rolleyes::confused::eek: to find a partial work-around. The problem is that media players (ALL 3 - Windows Player, Quicktime, RealPlayer) will display and play media in IE7 but will only play, but NOT display in Firefox 2 (can hear the audio, but can not see the player or video/ image). First I thought it was a transparency issue similar to the LDM bug fix I did for the Flash and Silverlight players, but setting the transparency/ blend parameters for these players had NO effect. After hours of testing different hacks and trial & error debugging, I found the source of the problem.

Partial work-around: Remove this script from the headinclude template:
<script type="text/javascript" src="$stylevar[yuipath]/yahoo-dom-event/yahoo-dom-event.js?v=$vboptions[simpleversion]"></script>

Removing this script will enable the players to display in Firefox. However, this partial solution is obviously not good since many VB scripts will not work since they depend on that yahoo event script. Andrew, can you PLEASE debug this one? I'll be glad to test out any fix you have. Thanks ;)

Note: testing with VB 3.7.2, LDM 2.2.9-post1, Windows XP (SP2), Firefox 2, Explorer 7, Quicktime 7.5, RealPlayer 11, Windows Player 11, and admin privileges for XP, VB & LDM.

[vbboarder]

Ok, I'm done with my bug reports for now..... ;)

[AndrewD]

Ok, I'm done with my bug reports for now..... ;)

Wow

[TsirhCitna]

OK, will take a look



Yes, I'd found this bug and I have the fix ready. It's releated to the new CSRF mechanisms in vBulletin. All you need to do is edit local_links_ajax.php (main forum directory)

After the line

define('CSRF_PROTECTION', true);
add

define('CSRF_SKIP_LIST', 'swfupload'); // because of problems with flash scripts assuming IE

I'm still having this same issue with anyone who is not an admin.

[RikiB]

The inline player seems to work only with FLV, is there a way to get Mp4/xml working with it as well?

also, is there anyway to have the entry thumbnail be a direct link to the file? It seems $linkimgjump forces it to open in litebox instead of opening the file.

Thanks

[vbboarder]

In researching the Yahoo event script conflict with embedded players, I discovered a possible fix. I verified that the problem exists with VB 3.7.2 alone without LDM. You can reproduce the problem with VB 3.7.2 in Firefox 2 with Flash Player 9 (I'm using Windows XP - sp2):

1. Create a forum with HTML code enabled (remember to allow admins only to post if this will be a permanent forum).
2. Create a thread and post with this sample object tag from youtube:

<object width="425" height="344"><param name="movie" value="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0"></param><param name="allowFullScreen" value="true"></param><embed src="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0" type="application/x-shockwave-flash" allowfullscreen="true" width="425" height="344"></embed></object>
3. Save and view the thread. The embedded flash player will temporarily show for ~1 sec. when the page loads, but then disappears (if autostart is enabled, video should play but still does not show). Refreshing the page and clearing the cache does not help.

Since the Flash player showed in LDM but NOT in VB alone, I realized that a possible work-around is to create the embedded player with a JS script and not by the object or embed tags. In LDM, the JW Flash & Silverlight players were able to show because they do not directly use the object and embed tags. Instead, the players are created by a script in the links_playerbit_JWPlayer and links_playerbit_JWwmPlayer templates. Hope that helps to create a plugin fix for the other media players.

Since this bug is obviously a VB bug, I posted it at VB's site: http://www.vbulletin.com/forum/project.php?issueid=26190
Everyone, please confirm/ comment on this bug at that link so that the VB team will make this bug a high priority. Even if Andrew is able to provide a plugin fix for LDM, this bug will still affect posts at HTML enabled forums since users can NOT post script tags even if HTML is enabled. For example, you may want to create a HTML enabled forums where admins can post YouTube videos for users to watch. Without this bug fixed, you're not able to do that. :rolleyes:

[AndrewD]

In researching the Yahoo event script conflict with embedded players, I discovered a possible fix. I verified that the problem exists with VB 3.7.2 alone without LDM. You can reproduce the problem with VB 3.7.2 in Firefox 2 with Flash Player 9 (I'm using Windows XP - sp2):

1. Create a forum with HTML code enabled (remember to allow admins only to post if this will be a permanent forum).
2. Create a thread and post with this sample object tag from youtube:

<object width="425" height="344"><param name="movie" value="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0"></param><param name="allowFullScreen" value="true"></param><embed src="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0" type="application/x-shockwave-flash" allowfullscreen="true" width="425" height="344"></embed></object>
3. Save and view the thread. The embedded flash player will temporarily show for ~1 sec. when the page loads, but then disappears (if autostart is enabled, video should play but still does not show). Refreshing the page and clearing the cache does not help.

Since the Flash player showed in LDM but NOT in VB alone, I realized that a possible work-around is to create the embedded player with a JS script and not by the object or embed tags. In LDM, the JW Flash & Silverlight players were able to show because they do not directly use the object and embed tags. Instead, the players are created by a script in the links_playerbit_JWPlayer and links_playerbit_JWwmPlayer templates. Hope that helps to create a plugin fix for the other media players.

Since this bug is obviously a VB bug, I posted it at VB's site: http://www.vbulletin.com/forum/project.php?issueid=26190
Everyone, please confirm/ comment on this bug at that link so that the VB team will make this bug a high priority. Even if Andrew is able to provide a plugin fix for LDM, this bug will still affect posts at HTML enabled forums since users can NOT post script tags even if HTML is enabled. For example, you may want to create a HTML enabled forums where admins can post YouTube videos for users to watch. Without this bug fixed, you're not able to do that. :rolleyes:

I will see what I can find out. During the years, I've found that there are frequently interactions problems between the browser and media handling infrastructures - flash, windows media player and real player have all caused problems and they are all specific to certain releases of the support products. It's a real pain to keep up-to-date.

On a similar note, the guy who runs the quirksmode site must be ocmpletely hairless, trying to keep track o the javascript features that do or do not work in different browsers/browser versions.

I posted a question yesterday about an oddity in PHP which has really got me confused.

[RikiB]

On my own site, I use a simple bbcode definition

Title

defined as

<a href="local_links.php?action=jump&id={option}" target="_new">{param}</a>

I also use

Title

defined as

<a href="local_links.php?catid={option}" target="_new">{param}</a>

to jump to a category

Is there any way to post an inline video using the JW player in a post using bbcode? That way I can see the player inside the post and just hit play?

Also, mp4 files done seem to work with the inline player :(

Thanks for the hard work!
- Riki

[bayigurita]

When using force_redirect=0 / 1, the download unable to resume, but if using force_redirect=2, the download able to resume. So I used option "2". But the hits won't count. Is there anyway to make it counted just by clicking the link?

I'm using different server for my downloadable files and my vbulletin LDM

[AndrewD]

When using force_redirect=0 / 1, the download unable to resume, but if using force_redirect=2, the download able to resume. So I used option "2". But the hits won't count. Is there anyway to make it counted just by clicking the link?

Sorry, not with the code as it's currently written. What do you mean by 'won't resume' with force_download=0/1?

[bayigurita]

Sorry, not with the code as it's currently written. What do you mean by 'won't resume' with force_download=0/1?

Nobody was able to resume the download, if I set force_redirect=0 or force_redirect=1. The file I hosted was larger than 100MB (not at the same vbulletin+LDM host), and if I try to download, and stop it in the middle and resume the download, the download start from the beginning not resuming properly.

[AndrewD]

Nobody was able to resume the download, if I set force_redirect=0 or force_redirect=1. The file I hosted was larger than 100MB (not at the same vbulletin+LDM host), and if I try to download, and stop it in the middle and resume the download, the download start from the beginning not resuming properly.

If you try to deliver large files held on a different server with force_redirect=0, then indeed you are going to have problems, because the script running on your server will use all its available cpu time fetching the file. This should not happen with force_redirect=1, because LDM simply triggers a browser redirect to get the file. With force_redirect=2, LDM is not involved at all in the transfer process.

[sparklywater]

Andrew,

I need to 'force' mp3 files to be downloaded rather than open up in a browser window or external player, ie. when the user clicks on the link a dialog box should pop up asking whether they'd like to save or open the file. Can you please explain how I can do this?

[AndrewD]

Andrew,

I need to 'force' mp3 files to be downloaded rather than open up in a browser window or external player, ie. when the user clicks on the link a dialog box should pop up asking whether they'd like to save or open the file. Can you please explain how I can do this?

Try ldm/admin/settings -> security and miscellaneous settings -> force_saveas -> yes

Let me know if it works as expected.

[sparklywater]

Try ldm/admin/settings -> security and miscellaneous settings -> force_saveas -> yes

Let me know if it works as expected.


That method does not work in Internet Explorer.

I was thinking of a more format-specific method which you seem to have mentioned in the wiki here: http://www.eirma.org/wikis/index.php/Configuring_Filetypes_in_vBulletin

Here is a quote from that page:

"Specifying the mimetype as "Content-type: application/force-download" is a useful way to force a filetype to be downloaded rather than opened within the browser window or by a program on the user's PC"

That sounds perfect but I don't know how to specify the mp3 filetype as 'application/force-download'.

[vbboarder]

Can someone please verify if the conflict between Yahoo event script and embedded players exists in Firefox 3? For more info on this bug, you can read my posts #903 & 908. You can reproduce and verify the bug by:

1. Create a forum with HTML code enabled (remember to allow admins only to post if this will be a permanent forum).
2. Create a thread and post with this sample object tag from youtube:
<object width="425" height="344"><param name="movie" value="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0"></param><param name="allowFullScreen" value="true"></param><embed src="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0" type="application/x-shockwave-flash" allowfullscreen="true" width="425" height="344"></embed></object>
3. Save and view the thread. The embedded flash player will temporarily show for ~1 sec. when the page loads, but then disappears (if autostart is enabled, video should play but still does not show). Refreshing the page and clearing the cache does not help.

After testing, please post if the flash video remains displayed or disappears. I have not tested in Firefox 3 myself because I'm still waiting for several Firefox 3 bugs to be fixed and Firefox 2 still has a relatively large usage base (~18%) so this bug needs to be fixed. Much appreciated for any help.

[sparklywater]

Does anyone know if there is a way to check a user's browser for the latest RealPlayer plugin, and if they don't have it then display a message or an update?

[AndrewD]

That method does not work in Internet Explorer.

I was thinking of a more format-specific method which you seem to have mentioned in the wiki here: http://www.eirma.org/wikis/index.php/Configuring_Filetypes_in_vBulletin

Here is a quote from that page:

"Specifying the mimetype as "Content-type: application/force-download" is a useful way to force a filetype to be downloaded rather than opened within the browser window or by a program on the user's PC"

That sounds perfect but I don't know how to specify the mp3 filetype as 'application/force-download'.

That's close to what the force_saveas settings does. Clearly I need to test it some more.

To specify the mp3 mimetype, go to vb/admincp/attachments/attachment manager.

Edit mp3, and change the mimetype box to Content-type: application/force-download. Remember what it used to be in case you want to go back again.

[AndrewD]

Can someone please verify if the conflict between Yahoo event script and embedded players exists in Firefox 3? For more info on this bug, you can read my posts #903 & 908. You can reproduce and verify the bug by:

1. Create a forum with HTML code enabled (remember to allow admins only to post if this will be a permanent forum).
2. Create a thread and post with this sample object tag from youtube:
<object width="425" height="344"><param name="movie" value="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0"></param><param name="allowFullScreen" value="true"></param><embed src="http://www.youtube.com/v/zzSpPaCIG0g&hl=en&fs=1&rel=0" type="application/x-shockwave-flash" allowfullscreen="true" width="425" height="344"></embed></object>
3. Save and view the thread. The embedded flash player will temporarily show for ~1 sec. when the page loads, but then disappears (if autostart is enabled, video should play but still does not show). Refreshing the page and clearing the cache does not help.

After testing, please post if the flash video remains displayed or disappears. I have not tested in Firefox 3 myself because I'm still waiting for several Firefox 3 bugs to be fixed and Firefox 2 still has a relatively large usage base (~18%) so this bug needs to be fixed. Much appreciated for any help.

With firefox 3 on my pc (running vista sp1), the video shows completely ok and reshows after a page refresh. Ditto IE7, ditto Safari.

Are you sure that this isn't down to the version of Flash on your system?

[sparklywater]

That's close to what the force_saveas settings does. Clearly I need to test it some more.

To specify the mp3 mimetype, go to vb/admincp/attachments/attachment manager.

Edit mp3, and change the mimetype box to Content-type: application/force-download. Remember what it used to be in case you want to go back again.

I have just tried that and in Internet Explorer it does not pop up the download box when clicking on the link (it starts downloading to temporary folder automatically).

[TsirhCitna]

I'm still having this same issue with anyone who is not an admin.
So any ideas on this? With no way to see the progress of the upload via the swf uploader this mod is useless for me. No user is going to wait for a 100MB upload without knowing what is going on.

[RikiB]

Is there any way to use the JW player to link to streaming video content, one hosted on the same server using the rtmp, and rtmpe protocol?

-Riki

[vbboarder]

With firefox 3 on my pc (running vista sp1), the video shows completely ok and reshows after a page refresh. Ditto IE7, ditto Safari.

Are you sure that this isn't down to the version of Flash on your system?

I don't think it's the Flash version - I have the latest - version 9.0.124.0

Thanks Andrew for testing this bug on Firefox 3. I had another person confirm that this bug does not exist in Firefox 3, but is a problem in Firefox 2 so I'll assume that's the case for now. It's never been a problem on IE7. Andrew, don't waste your time on this bug - it should be fixed by Yahoo and/or Mozilla, or I guess the user will be required to use Firefox 3. :rolleyes:

[AndrewD]

I'm still having this same issue with anyone who is not an admin.

I can't really help without access to your site. If you want me to take a look, send me a PM with site details and two usernames/passwords - an admin and a user affected by the problem.

[sparklywater]

I need to update the JW media player to version 4.1 http://www.jeroenwijering.com/?item=JW_FLV_Media_Player .

Is it possible to do this myself with my current installation if I upload the new files with the same filenames?

[sparklywater]

Is there any way to use the JW player to link to streaming video content, one hosted on the same server using the rtmp, and rtmpe protocol?

rtmp is supported in the latest version of JWPlayer:

"The 4.1 release introduces an new streamer flashvar (RTMP + HTTP), token-based security, color flashvars and a lot of fixes and enhancements."

http://www.jeroenwijering.com/?item=JW_FLV_Media_Player

[AndrewD]

I need to update the JW media player to version 4.1 http://www.jeroenwijering.com/?item=JW_FLV_Media_Player .

Is it possible to do this myself with my current installation if I upload the new files with the same filenames?

I had some problems with that approach, because the handling of the flash variables has changed. I have the new version working correctly but with some new templating. I'll post it this evening.

I have not yet tested the rtmp handling.

[sparklywater]

With the current version of JWPlayer, there is a problem in IE 6 + IE 7. When returning to an embedded audio page after the first visit, the whole player becomes blank / black (but it appears correctly on the first visit). I have seen this on two different PCs, one with IE7 and one in IE6, but the problem doesn't exist in Firefox.

Here is an image to show the blank player:


https://vborg.vbsupport.ru/external/2008/08/11.jpg


I'm just hoping that the problem goes away with the new version of JWPlayer.

+

[AndrewD]

With the current version of JWPlayer, there is a problem in IE 6 + IE 7. When returning to an embedded audio page after the first visit, the whole player becomes blank / black (but it appears correctly on the first visit). I have seen this on two different PCs, one with IE7 and one in IE6, but the problem doesn't exist in Firefox.

Here is an image to show the blank player:


https://vborg.vbsupport.ru/attachment.php?attachmentid=86049&stc=1&d=1219743785


I'm just hoping that the problem goes away with the new version of JWPlayer.

+

Yes - this is a known caching problem with Flash + IE, not JW player. I thought that I had got round it with the LDM implementation.

[sparklywater]

Is there a way to prevent IE from caching the player (from server-end, not client-end)? Perhaps there's something about it on Microsoft's support pages...

[AndrewD]

Is there a way to prevent IE from caching the player (from server-end, not client-end)? Perhaps there's something about it on Microsoft's support pages...

I've spent many hours on this. It is a well-documented bug. You are welcome to try to find a different solution and let me know!

[sparklywater]

I've spent many hours on this. It is a well-documented bug. You are welcome to try to find a different solution and let me know!

Well I'd be very happy to accept your solution (using LDM implementation) but unfortunately it doesn't seem to be working for me :(

Do you think in the next version of JWPlayer the caching problem in LDM will go away?

[AndrewD]

Well I'd be very happy to accept your solution (using LDM implementation) but unfortunately it doesn't seem to be working for me :(

Do you think in the next version of JWPlayer the caching problem in LDM will go away?

All we can do is try. I'm in the office at the moment so can't test it. As I said, it's a problem in flash not in jwplayer, but perhaps jw has found a way round it.

[sparklywater]

All we can do is try. I'm in the office at the moment so can't test it. As I said, it's a problem in flash not in jwplayer, but perhaps jw has found a way round it.

I'm testing out the embedded players on their website: http://www.jeroenwijering.com/?item=JW_FLV_Media_Player

and it looks like they have found a way round it (there are no caching probs in IE).

[Xenocat]

Howdy! I'll start off by saying I love this mod...

With that said tho, I've run into a recent issue with upload permissions. Seems only Administrators can upload unrestricted file sizes now. Everybody else gets a security token error, and can't upload.

I've gone thru each and every usergroup permission for LDM, and everything LOOKS ok... it was working before the latest vb security patch...

Anybody else having a problem w/ uploads? I use it to manage a community depot for source engine map files (upwards of 50 megs per file), and it kinda kills the community when they can't upload. I'm at a total loss as to what exactly the problem is now.

Any help would be greatly appreciated!

[TsirhCitna]

I can't really help without access to your site. If you want me to take a look, send me a PM with site details and two usernames/passwords - an admin and a user affected by the problem.Sent.

[AndrewD]

Howdy! I'll start off by saying I love this mod...

With that said tho, I've run into a recent issue with upload permissions. Seems only Administrators can upload unrestricted file sizes now. Everybody else gets a security token error, and can't upload.

I've gone thru each and every usergroup permission for LDM, and everything LOOKS ok... it was working before the latest vb security patch...

Anybody else having a problem w/ uploads? I use it to manage a community depot for source engine map files (upwards of 50 megs per file), and it kinda kills the community when they can't upload. I'm at a total loss as to what exactly the problem is now.

Any help would be greatly appreciated!

I think I know what the problem is, but will have to work out a new solution.

Probably, you are using the flash-based swfuploader addon. I suspect that it works ok with Internet Explorer and fails with Firefox and other browsers.

There is a known bug with flash, which always sets cookies for internet explorer rather than the browser that is actually being used. I had written a workaround, which the latest security fixes from vb seem to have broken.

Can you confirm

[vbboarder]

Bug report: JWPlayer can play mp4 & m4v files when viewing the entry itself, but the player does not show when viewing a category's list of entries. It should show the player for mp4 & m4v files because the same player shows for flv, swf, & mp3 files when viewing a category's list of entries. Andrew, I can help fix this bug if you can advise me which file/ where to edit?
Andrew, any help on this one? I can help fix.

[sparklywater]

Andrew, any help on this one? I can help fix.

Maybe the latest version of JWplayer will fix it? Andrew will be posting it soon.

[vbboarder]

Maybe the latest version of JWplayer will fix it? Andrew will be posting it soon.
Doubt it.... I already installed & integrated version 4.0 of the JW player myself. Thanks for suggesting.... will test it when Andrew posts the plugin for version 4.1.

[AndrewD]

Andrew, any help on this one? I can help fix.

It's the jwaddons xml. The attached version should fix the problem. Note that you need to kill all the existing installed LDM plugins with "JWPlayer Addons" in the title.

Let me know if this works ok.

[vbboarder]

It's the jwaddons xml. The attached version should fix the problem. Note that you need to kill all the existing installed LDM plugins with "JWPlayer Addons" in the title.

Let me know if this works ok.
Thanks for the fix - I'll post after testing it out :D

[AndrewD]

Sent.

Howdy! I'll start off by saying I love this mod...

With that said tho, I've run into a recent issue with upload permissions. Seems only Administrators can upload unrestricted file sizes now. Everybody else gets a security token error, and can't upload.

I've gone thru each and every usergroup permission for LDM, and everything LOOKS ok... it was working before the latest vb security patch...

Anybody else having a problem w/ uploads? I use it to manage a community depot for source engine map files (upwards of 50 megs per file), and it kinda kills the community when they can't upload. I'm at a total loss as to what exactly the problem is now.

Any help would be greatly appreciated!

Really weird bug in Firefox

Take care::::

For a *temporary* fix, try editing the links_addnewlink template.

About 280 lines in, you'll find this sequence of text:


<if condition="$links_permissions['can_set_permissions'] and ($links_permissions['can_upload_files'] or $links_permissions['can_link_files'])">
<tr>
<td class="alt1" width="30%">
<strong>$vbphrase[ll_rename]</strong><br />
<span class="smallfont">
$vbphrase[ll_renameinfo]
</span>
</td>
<td class="alt1">
<input type="text" class="bginput" name="linkfile" id="linkfile" value="$linkfile" size="50" tabindex="1" onkeypress="return ldm_noenter()" />
</td>
</tr>
<else />
<tr style="display:none;">
<td class="alt1" colspan="2">
<input type="hidden" name="linkfile" value="$linkfile" />
</td>
</tr>
</if>


Change it to


<if condition="$links_permissions['can_set_permissions'] and ($links_permissions['can_upload_files'] or $links_permissions['can_link_files'])">
<tr>
<td class="alt1" width="30%">
<strong>$vbphrase[ll_rename]</strong><br />
<span class="smallfont">
$vbphrase[ll_renameinfo]
</span>
</td>
<td class="alt1">
<input type="text" class="bginput" name="linkfile" id="linkfile" value="$linkfile" size="50" tabindex="1" onkeypress="return ldm_noenter()" />
</td>
</tr>
<else />
<tr style="display:none;">
<td class="alt1" colspan="2">
<input type="hidden" name="linkfile" id="linkfile" value="$linkfile" />
</td>
</tr>
</if>

[Xenocat]

Thanks for looking into this - Before I make the aforementioned change, will usergroup permissions still govern who can upload? Its not a free upload site for anybody, so I want to keep it so that users in the correct user groups can upload only

EDIT to add: problem seems to exist in IE as well

[vbboarder]

It's the jwaddons xml. The attached version should fix the problem. Note that you need to kill all the existing installed LDM plugins with "JWPlayer Addons" in the title.

Let me know if this works ok.

Thanks for the fix! The player now shows when listing a category's entries for mp4 and m4v files, but now incorrectly sizes the player.
Bug Report: when viewing a category's listing for audio files with album art, the player's size is the size of the album art, NOT the preset size. This problem did not exist with the prior version of jwaddons.xml.
When you fix this bug, can you PLEASE make LDM use the size for videos if it detects album art and use the size for mp3 if it detects no artwork?
Also, can you make LDM show the player for aac & m4a files, which are supported by the JW Player? ;)

[vbboarder]

Howdy! I'll start off by saying I love this mod...

With that said tho, I've run into a recent issue with upload permissions. Seems only Administrators can upload unrestricted file sizes now. Everybody else gets a security token error, and can't upload.

I've gone thru each and every usergroup permission for LDM, and everything LOOKS ok... it was working before the latest vb security patch...

Anybody else having a problem w/ uploads? I use it to manage a community depot for source engine map files (upwards of 50 megs per file), and it kinda kills the community when they can't upload. I'm at a total loss as to what exactly the problem is now.

Any help would be greatly appreciated!

Which VB version update are you referring to that caused the problem? 3.7.2 PL2 or 3.7.3?

[Xenocat]

3.7.2 pl2..

Didn't realize 3.2.3 was out yet.. ill do that update and see if, by some magical occurance, the problem gets fixed

[sparklywater]

Andrew, I'm eagerly awaiting the new JWPlayer update, as soon as you can please, thanks :)

[sparklywater]

Does anyone know if there is a way to check a user's browser for the latest RealPlayer plugin, and if they don't have it then display a message or an update?

I've found the answer to this question here:

http://real.custhelp.com/cgi-bin/real.cfg/php/enduser/std_adp.php?p_faqid=4193&p_created=1087424588&p_sid=Eq2_ofcj&p_accessibility=&p_redirect=&p_lva=&p_sp=cF9zcmNoPTEmcF9zb3J0X2J5PSZwX2dyaWRzb3J0PSZwX 3Jvd19jbnQ9NzQsNzQmcF9wcm9kcz0zJnBfY2F0cz0mcF9wdj0 xLjMmcF9jdj0mcF9zZWFyY2hfdHlwZT1hbnN3ZXJzLnNlYXJja F9ubCZwX3BhZ2U9MSZwX3NlYXJjaF90ZXh0PWRldGVjdCByZWF scGxheWVy&p_li=&p_prod_lvl1=3&p_prod_lvl2=0&tabName=4&p_topview=1

[TsirhCitna]

Really weird bug in Firefox

Take care::::

For a *temporary* fix, try editing the links_addnewlink template.

About 280 lines in, you'll find this sequence of text:


<if condition="$links_permissions['can_set_permissions'] and ($links_permissions['can_upload_files'] or $links_permissions['can_link_files'])">
<tr>
<td class="alt1" width="30%">
<strong>$vbphrase[ll_rename]</strong><br />
<span class="smallfont">
$vbphrase[ll_renameinfo]
</span>
</td>
<td class="alt1">
<input type="text" class="bginput" name="linkfile" id="linkfile" value="$linkfile" size="50" tabindex="1" onkeypress="return ldm_noenter()" />
</td>
</tr>
<else />
<tr style="display:none;">
<td class="alt1" colspan="2">
<input type="hidden" name="linkfile" value="$linkfile" />
</td>
</tr>
</if>
Change it to


<if condition="$links_permissions['can_upload_files'] or $links_permissions['can_link_files']">
<tr>
<td class="alt1" width="30%">
<strong>$vbphrase[ll_rename]</strong><br />
<span class="smallfont">
$vbphrase[ll_renameinfo]
</span>
</td>
<td class="alt1">
<input type="text" class="bginput" name="linkfile" id="linkfile" value="$linkfile" size="50" tabindex="1" onkeypress="return ldm_noenter()" />
</td>
</tr>
<else />
<tr style="display:none;">
<td class="alt1" colspan="2">
<input type="hidden" name="linkfile" value="$linkfile" />
</td>
</tr>
</if>

That works.

[obmob]

Well... I should be ashamed, but finally i'm editing some templates on LDM 2.2.9 :(

So... Iwas wondering if there is a way to edit some stuff in the "main" template.

First, the top block, where the download's site is displayed, is there a way to add a conditional to it to hide the white row? Or just hide it completely in LDM's index page :p

Then... why is it that after certain categories a new blank row appears? Ithought this was for categories with no subcategories, but the first one is has no dependant categories, and the second one does... then below there are more main categories. :confused:

Anyway, i would like to know what is supposed to show there, if ishould enable something extra or if there is a way to delete those big rows :p

What else.... hmm, is there a way toshow descriptions, maybe the short one in the main page? Right below the category name :)

Guess that's all for tonight, been so busy this year... it sucks :eek:

Thanks Andrew!

[AndrewD]

Thanks for looking into this - Before I make the aforementioned change, will usergroup permissions still govern who can upload? Its not a free upload site for anybody, so I want to keep it so that users in the correct user groups can upload only

EDIT to add: problem seems to exist in IE as well

I couldn't reproduce it with IE. Which version of IE, which operating system?

In my tests, admins could use the SWFuploader extra with any browser, and other users could use it correctly with IE but not Firefox 3.

The template change does not modify who is allowed to upload. The problem that I discovered was related to a form field which is hidden from non-admins. Note that I have edited the fix I posted last night - both the first and the second version work, but the latest version is better.

[AndrewD]

Well... I should be ashamed, but finally i'm editing some templates on LDM 2.2.9 :(

So... Iwas wondering if there is a way to edit some stuff in the "main" template.

First, the top block, where the download's site is displayed, is there a way to add a conditional to it to hide the white row? Or just hide it completely in LDM's index page :p

The problem is in the links_catbit_extras template, which is used to build a set of messages which are normally placed in that white row. If there is nothing to show, the template really should return nothing, but the way it's currently written it returns an empty div container. Take a look at the template if you wish - you would have to repeat all the conditional tests inside the div as a master conditional outside the div.

Then... why is it that after certain categories a new blank row appears? Ithought this was for categories with no subcategories, but the first one is has no dependant categories, and the second one does... then below there are more main categories. :confused:

Anyway, i would like to know what is supposed to show there, if ishould enable something extra or if there is a way to delete those big rows :p

If I'm understanding you correctly, this happens when the display_order changes. You can get rid of it by clearing the links_linkseparator template.

What else.... hmm, is there a way toshow descriptions, maybe the short one in the main page? Right below the category name :)


You are using the'Brief' category template, which is links_catbit_brief. Include $catdesc in it somewhere.

[Goomzee]

Is there any screen shot of this Mod i mean how it works

[AndrewD]

Is there any screen shot of this Mod i mean how it works

Take a look at the online wiki - http://www.eirma.org/wikis/index.php/Links_and_Downloads_Manager

[Goomzee]

thankx but there are some folders i am installing this is 1st time so i just upload released folder on public_html and then upload some files in under forums foldrer and what about extra and vba_modules folder where i uploaed them and what do i do with development and tests folder upload them or not

[GrendelKhan{TSU]

Hey Andrew... I think I asked this like.... couple years ago (lol) and given all the add-ons maybe I just missed it...

is there a, safe or usergroup-based, way to hotlink to a file after its been uploaded?


GOAL: I want to hotlink the file to a mp3 player in one's profile and a jukebox player play list.


ps. keep up the awesome work as usual. still one of the best add-ons aruond :)

again, sorry as I know it must be obvious and I'm just missign it. but is there a way to do usergroup group based hotlinking to uploaded files?

[AndrewD]

thankx but there are some folders i am installing this is 1st time so i just upload released folder on public_html and then upload some files in under forums foldrer and what about extra and vba_modules folder where i uploaed them and what do i do with development and tests folder upload them or not

This is explained in the wiki.

In the release folder, you upload the contents of the forum directory and its subdirectories into exactly the same layout on your site. Ignore the release/extras directory for the time being - as its name suggests, it contains optional extras. release/vba_modules contains interface modules for the vbAdvanced product - again, you ignore this unless you want to use vbadvanced.

You can completely ignore the contents of the development folder, unless you want to modify the products.

tests is exactly what it says - it contains some simple tests. Again you can ignore it.

[AndrewD]

again, sorry as I know it must be obvious and I'm just missign it. but is there a way to do usergroup group based hotlinking to uploaded files?

I don't really understand your question - do you mean you want to provide people with a url that takes them directly to the download? This is simply the local_links.php?action=jump url shown in the linkbit. However, it will only work on protected files if the user has already logged on to the vb site and has cookies stored.

Are you wanting something else, e.g. the equivalent of a tinyurl?

[Goomzee]

thankx i understand but one more question i am already using VBadvanced so should i upload this folder or not "vba_modules" and i am ingore all folders excpcet forums folder right?

[AndrewD]

thankx i understand but one more question i am already using VBadvanced so should i upload this folder or not "vba_modules" and i am ingore all folders excpcet forums folder right?

No. You install the vba modules by uploading the ones you want to use, using the 'Upload/Download module' section in the vb/admincp/vba section

[Goomzee]

thankx today i already downloaded this but i will upload this Mod i hope it will not crash my forums DB

[GrendelKhan{TSU]

I don't really understand your question - do you mean you want to provide people with a url that takes them directly to the download? This is simply the local_links.php?action=jump url shown in the linkbit. However, it will only work on protected files if the user has already logged on to the vb site and has cookies stored.

Are you wanting something else, e.g. the equivalent of a tinyurl?

Yes, kinda like tinyurl..... but more like photobucket or hotlinkfiles.com. simply, want to be able to use LDM as an hosting solution for external pages or sites, as well as destination area in itself.

if I were to frame specific intent/goals:

Example of forum Usage:
I have a profile mp3 player set up (demo (http://www.unrealaddicts.com/forums/members/grendelkhan-tsu-.html)).. seems a shame or waste not to be able to use mp3 uploaded in LDM for that. Users complain and confused as there are too many places one has to upload the same MP3 file. Right I recommend people go to hotlinkfiles.com to add a URL to the mp3 player. Just seems like a shame given its right there already in LDM.

this would be true in other areas of my forum as well (not just forums).

Also, when I add an mp3 to my profile... I might want to set it for anyone to be able to hear it (not just logged in members).


From the member perspective:
Generally speaking, if I have uploaded an mp3 or file to LDM, I want use/share it in external places or sites. Again, like photobucket, vbaGallery, youtube or hotlinkfiles.com. (and kinda like tinyurl). Upload and link to other sites.

As admin this consolidates features on the site as a whole, streamlines usage, and funnels people to upload to LDM (as opposed to elsewhere on the forum or other sites completely).

Also, it would be good to be able to limit this ability (ie: not everyone is allowed to hotlink).



Again, I don't know if this is possible or reasonable. Not trying to massively increase your load. just simply put, would be nice and efficient and possibly increase usage if members could link uploads to external pages/sites. :)

[sparklywater]

Andrew, I have found a fix to the cache problem in Flash + IE.

The trick is to add the width and height values to the flashvars:

http://www.jeroenwijering.com/?thread=9236

This has fixed the problem in my current installation so I think I will stick with this version for now.

[AndrewD]

I provide release 2.2.9-post 3 for careful testing.

This consolidates the bug fixes in the 2.2.9-post2 release and provides a few more bug fixes for the most serious recent reports/requests.

Appreciate your reports. One of the bug fixes has required quite a significant change to the code which build s the link bits, so I'm keen to know if there are new problems there.

Development of version 2.3.0 is well underway, but I am making no promises when it will be available.

Changes from 2.2.9 post 2 to post 3

Media Players

Upgraded JWplayer to version 4.1
Upgraded JWsilverlight player to version 1.1 and added windowless and background params
Enabled mp4 and m4v handling in inline JWplayer

Bug fixes

Fixed Edit Entry to work correctly in combination with swfuploader
Fixed template bug which prevented swfuploader extra working for non-admins
Fixed sort order/pagination bugs when searches contain urlencoded chars
Fixed Add LDM to VB navbar plugins for situation when vbAdvanced is not installed in forum directory
Fixed pagenav control when entry filters are active
Fixed template error in admin/statistics box
Fixed autothread creation in situtions where done in another username, e.g. moderation
Fixed bug in linkbit creation when handling entries with no url
Fixed potential SQL injection security breach

Changes from 2.2.9 post 1 to post 2

Permissions
- Added *can_add_image* permission to control which usergroups can add thumbnails to entries

Thread/post creation
- ldm_post_addrating_title and ldm_thread_create_title phrases both accept (entry name, category name, submission date) as variables {1}, {2}, {3}; default ldm_post_addrating_title phrase change to Re: {1}

Uploads
- Restrictions (if any) in VB usergroup attachments permissions included in controls on uploadable filetypes/maximum filesizes
- Removed thumbnail image formfield from Add/Edit Entry form when attachment permissions disallowed for all image types
- Modified code to set file permissions of uploaded files to 0644 (some versions of php erroneously set this to 0600)

Extras
- Added 'upload-names' extra to modify the naming convention for file uploads
- Extended 'hide-magnifier' extra to deal sensibly with images specified as full urls

Bug fixes
- Updated JWsilverlight.js file so that Silverlight player works with Firefox 3
- Changed to vertical layout of yes/no form settings with right-to-left languages
- Correctly cache the *humanverify* template
- Changed German language file xml to ISO-8859-1
- Fixed bug in 'import-radiostation' extra introduced in release 2.2.9

[vbboarder]

Is this bug fixed in the new update?

When editing an entry with both an uploaded file and an image file, if that image is deleted then the uploaded file is also deleted. In addition to fixing this bug, can you provide an option to disable deleting the thumbnail image file?

[vbboarder]

Thanks for the update! Do we have to reinstall all extra plugins? If yes:
1. Do we have to first uninstall then reinstall the extra plugins?
2. Are the settings for the extra plugins saved so we don’t have to re-enter the values after reinstalling?
3. Will you implement an auto plugins updater (similar to auto templating in VB) in a later update?

[AndrewD]

Is this bug fixed in the new update?

I'm not sure that I was able to reproduce that problem - I will have to check.

Thanks for the update! Do we have to reinstall all extra plugins? If yes:
1. Do we have to first uninstall then reinstall the extra plugins?
2. Are the settings for the extra plugins saved so we don?t have to re-enter the values after reinstalling?
3. Will you implement an auto plugins updater (similar to auto templating in VB) in a later update?

You will have to reinstall the plugins for the extras. Settings are saved correctly, so no problem there.

I'll take a look at autoupdating the extras.

[Ophelia]

Andrew,

I know you've addressed this already, but we are having the security token issue.

I don't remember editing any files, so is there a way to check this? Right now we are getting the error when we try to upload.

[vbboarder]

The entries listing in What's New page is above the limit set in LDM settings. This is probably due to the setting days_seen_on_portal overriding links_seen_on_portal.

[vbboarder]

The JW player incorrectly handles swf files. The flash/ video will auto loop (by default this should not happen), the time does not show for swf files with time, the player controls do not work - can play flash/ video, but can NOT pause, forward/ rewind, or interact with controls created by the swf itself. This is not a bug with LDM, VB or even Adobe Flash player, it's a limitation with the JW player - tested with JW player 4.0 in Firefox2 & IE7.

Solution: disable swf from all media players in LDM until JW player can play swf (Windows, Quicktime, & Realplayer also can't correctly play it). When the user clicks on the entry's title link or download entry image link, the flash/ video will open up in a new tab/ window and play correctly using Adobe's Flash player (if installed in the browser).

Fix needed: The JW player will still show for swf files (even if no media players have swf set in LDM) when listing a category's entries. This entices the users to play the file using the JW player, which it can not do. Andrew, can you please disable showing the player for swf files when listing a category's entries?

[obmob]

The problem is in the links_catbit_extras template, which is used to build a set of messages which are normally placed in that white row. If there is nothing to show, the template really should return nothing, but the way it's currently written it returns an empty div container. Take a look at the template if you wish - you would have to repeat all the conditional tests inside the div as a master conditional outside the div.



If I'm understanding you correctly, this happens when the display_order changes. You can get rid of it by clearing the links_linkseparator template.



You are using the'Brief' category template, which is links_catbit_brief. Include $catdesc in it somewhere.
Thanks, now i have something to do on sunday XD

[RikiB]

When I try and add a link from my wowza streaming server I get this

Sorry - unable to handle protocol rtmp://

Is there a way to access the streamer variable in the JW player?

[AndrewD]

Andrew,

I know you've addressed this already, but we are having the security token issue.

I don't remember editing any files, so is there a way to check this? Right now we are getting the error when we try to upload.

Main thing to check:

- Have you (or maybe have I) at some point in the past edited any of the LDM templates used on your site and forgotten to 'revert' them?

Are you using the LDM flash-based swfuploader extra for handling uploads or just the standard form-based uploader?

Will take a look at your site if you want.

[AndrewD]

When I try and add a link from my wowza streaming server I get this

Sorry - unable to handle protocol rtmp://

Is there a way to access the streamer variable in the JW player?

That's right, LDM is not currently configured to understand how to handle and deliver rtmp:// protocol, i.e. it doesn't know how to act as an rtmp server. I've no idea if this is a simple or very complex protocol to handle.

[AndrewD]

The JW player incorrectly handles swf files. The flash/ video will auto loop (by default this should not happen), the time does not show for swf files with time, the player controls do not work - can play flash/ video, but can NOT pause, forward/ rewind, or interact with controls created by the swf itself. This is not a bug with LDM, VB or even Adobe Flash player, it's a limitation with the JW player - tested with JW player 4.0 in Firefox2 & IE7.

Solution: disable swf from all media players in LDM until JW player can play swf (Windows, Quicktime, & Realplayer also can't correctly play it). When the user clicks on the entry's title link or download entry image link, the flash/ video will open up in a new tab/ window and play correctly using Adobe's Flash player (if installed in the browser).


Fix needed: The JW player will still show for swf files (even if no media players have swf set in LDM) when listing a category's entries. This entices the users to play the file using the JW player, which it can not do. Andrew, can you please disable showing the player for swf files when listing a category's entries?

There's a couple of places to make this change.

Inline players

If you are using the JWplayer extra to play media inline, then got to vb/admincp/products and players/plugin manager

Edit the Links and Downloads Manager - JWPlayer Addons plugin attached to hook ldm_linkbit_create.

Change line:

if ($links_defaults['inlineJWplayer_active'] and in_array($linkfiletype, array("mp3", "flv", "swf", "mp4", "m4v", ))) {


to


if ($links_defaults['inlineJWplayer_active'] and in_array($linkfiletype, array("mp3", "flv", "mp4", "m4v", ))) {


and delete the line


case "swf":


Save

Edit the Links and Downloads Manager - JWPlayer Addons plugin attached to hook ldm_linkbit_gettypebit.

Change the line

if (in_array($linkfiletype, array("mp3", "flv", "swf", "m4v", "mp4",))) {


to

if (in_array($linkfiletype, array("mp3", "flv", "m4v", "mp4",))) {


Save

Standard players

Go to ldm/admin/media players. Find JWflvPlayer. Remove swf from the list of filetypes handled and save.

[vbboarder]

Thanks for the fix Andrew! :D

[Origin2]

I'm getting this error when trying to access any of your files "Codification Error" "Bad compression"....
I can't even edit any settings or access anything

[Ophelia]

Main thing to check:

- Have you (or maybe have I) at some point in the past edited any of the LDM templates used on your site and forgotten to 'revert' them?

Are you using the LDM flash-based swfuploader extra for handling uploads or just the standard form-based uploader?

Will take a look at your site if you want.

Looking in vBulletin under styles, everything is showing that it's been reverted.

We are using the normal form based uploader.

Before I bother you with looking, let me do some testing to see exactly what is happening. I'll repost when I have that information.

[AndrewD]

I'm getting this error when trying to access any of your files "Codification Error" "Bad compression"....
I can't even edit any settings or access anything

This is the first report of this problem, and the error messages are not being generated inside LDM as far as I can tell. Do you want me to take a look at your site - I will need full admin privileges? Send me a PM if so.

[derfelix]

A little utf-8 bug for keywords..

IF the site is in UTF-8 AND you are using multi-language.. (example german and english)
then
when you add keywords to an entry containing special characters like ? ? ? ? there is a problem.. they wont display or get truncated at the special character..

i found the reason:
the strtolower function cannot convert special characters.. (it says though it will leave them as is.. thats true for some.. but not for those i need..
keyword: "key????test" will come out.. as "key" only..

i did a fix for me.. (it will only work if you dont have multi-encodings on your site AND if your site is UTF-8 for ALL languages)

Fix:
in the function ldm_explode_keywords in the file: local_links_include.php
find:
return preg_split("/[,;\s]+/", strtolower($words));
replace with:
return preg_split("/[,;\s]+/", mb_strtolower($words,"UTF-8"));

hope that helps someone...

Felix
PS: still anotherone when testing.. the highlighting doesnt work on keywords with special chars... but that is really minor...(will look into it if time permitting)
PPS: the mb extensions must be installed in php (usually are by default)

[AndrewD]

PS: still anotherone when testing.. the highlighting doesnt work on keywords with special chars... but that is really minor...(will look into it if time permitting)
PPS: the mb extensions must be installed in php (usually are by default)
Thanks - I went stir crazy with this a year or so ago with trying to highlight Chinese searches... What to do when you don't understand anything that's on the screen.

[Origin2]

it's a problem with my crappy host >_>

derflix I tried that but still didn't work

[sparklywater]

I need to add a separate link in one of the category listing pages (which displays all the entries in that category), but if I try to add the link to the 'links_linkbit_short_direct' template, the link is added to every row of entry in that category. I don't want the separate link to appear in every row, I need it to appear once somewhere in that category's entry-list page.

I can't add the link to the 'links_main' template because this causes it to appear in every category (I only need the link to appear in one category). How can I add an additional link or some other text to a category's listing without it appearing in every row of entry in that category?

[AndrewD]

I need to add a separate link in one of the category listing pages (which displays all the entries in that category), but if I try to add the link to the 'links_linkbit_short_direct' template, the link is added to every row of entry in that category. I don't want the separate link to appear in every row, I need it to appear once somewhere in that category's entry-list page.

I can't add the link to the 'links_main' template because this causes it to appear in every category (I only need the link to appear in one category). How can I add an additional link or some other text to a category's listing without it appearing in every row of entry in that category?

Can you not make it part of the category's extended description?

Alternatively, there are a series of placeholders in the links_main template, which come from elements of the $ldm_includeinmain array, e.g. $ldm_includeinmain[precat]. You could write a very small plugin which is tied to the ldm_maindisplay_end hook, e.g.:


if ($viewcatid==25) {
$ldm_includeinmain[precat] = "additional html";
}


This would only appear in categoryid #25

[vbboarder]

Thanks for the fix! The player now shows when listing a category's entries for mp4 and m4v files, but now incorrectly sizes the player.
Bug Report: when viewing a category's listing for audio files with album art, the player's size is the size of the album art, NOT the preset size. This problem did not exist with the prior version of jwaddons.xml.
When you fix this bug, can you PLEASE make LDM use the size for videos if it detects album art and use the size for mp3 if it detects no artwork?
Also, can you make LDM show the player for aac & m4a files, which are supported by the JW Player? ;)

Bug Fix To correctly size the JW player for audio files with album art, edit the JWPlayer Addons plugin attached to the ldm_linkbit_create hook. FIND AND DELETE:

$player_height += $links_defaults['link_imagesize'];
$player_width = max($player_width, $links_defaults['link_imagesize']);

To show JW player for m4a files when viewing a category's list of entries, follow Andrew's instructions in this post, except you're adding "m4a" to the codes he mentioned:
https://vborg.vbsupport.ru/showpost.php?p=1608717&postcount=978
Also in the JWPlayer Addons plugin attached to the ldm_linkbit_create hook, FIND:
case "mp3":
After that, ADD:
case "m4a":

DO NOT enable JW player 4 for aac files, even though it claims support for it. The JW player caused Firefox 2 to freeze/ hang when I tried to play aac files.

[derfelix]

Hi andrew...
I did some tests
with german umlaut.. (???) or french accents (? ? ? ? ?) my fix above seems to work...
BUT
with chinese... AAAAAAAAAAAAAAAGH.... you are right.. that is a pain....

but i think i narrowed it down.. BUT i would need some help..

OK.. the problem is.. in UTF-8 with multibyte characters.. there is a preg_replace problem..
(dont ask me why)

The problem is in the line..:
// Apply highlighting to each of the substrings
$resstrings = preg_replace($find, $replace, $substrings);
(its the $find that doesnt work for UTF-8 chinese)

I ran some examples with dummy strings.. (notice the /u modifier was added)
example :
$resstrings = preg_replace("/(\b???\b)/iu", " Replaced: $1 ", "test ??? test");
will give: test Replaced: ??? test
==> works!!!

but:
$resstrings = preg_replace("/(\b欢迎您\b)/iu", " Replaced: $1 ", "欢迎欢迎您 欢迎");
will give: 欢迎欢迎您 欢迎
==> no highlight :(
------------
The problem whith characters like chinese seems to be the boundary \b
so i tried:
$resstrings = preg_replace("/(" . preg_quote("欢迎您") . ")/iu", " Replaced: $1 ", "欢迎欢迎您 欢迎");

will give: 欢迎 Replaced: 欢迎您 欢迎
==> works.. chinese text is highlighted..!!!!!

BUT.. my question.. is there a drawback?????
not using the boundary \b ???
i used the preg_quote just to avoid $1 errors.. but i guess its not really needed..

to implement this in LDM it would be:
in local_links_include.php in function ldm_make_highlight_regex
find:
$find[] = '/(\b'.$w.'\b)/i';
replace with:
$find[] = '/('.preg_quote($w).')/iu';
actually i would also (maybe) add @ in front of the preg_replace in $resstrings = preg_replace($find, $replace, $substrings);
i have ran some tests with keywords in chinese.. they highlight... tried message-text: works also...
PLEASE TEST...!!!!
Felix

[AndrewD]

Bug Fix To correctly size the JW player for audio files with album art, edit the JWPlayer Addons plugin attached to the ldm_linkbit_create hook. FIND AND DELETE:

To show JW player for m4a files when viewing a category's list of entries, follow Andrew's instructions in this post, except you're adding "m4a" to the codes he mentioned:
https://vborg.vbsupport.ru/showpost.php?p=1608717&postcount=978
Also in the JWPlayer Addons plugin attached to the ldm_linkbit_create hook, FIND:

After that, ADD:

DO NOT enable JW player 4 for aac files, even though it claims support for it. The JW player caused Firefox 2 to freeze/ hang when I tried to play aac files.


Thanks for the info.

The sizing bug was originally intended to be a feature - the larger player would include the album cover within the player, rather than displaying it separately. But this did not work consistently.

[AndrewD]

find:
$find[] = '/(\b'.$w.'\b)/i';
replace with:
$find[] = '/('.preg_quote($w).')/iu';

BUT.. my question.. is there a drawback?????

Felix

Thanks, Felix. Indeed the problem is/was the word boundary. The drawback with removing the word boundary markers is that you end up highlighting substrings in the results which the search itself did not match.

For example, suppose you have a string "happily merrily sadly happilymerrilysadly" and you do a search for merrily

This should highlight as "happily merrily sadly happilymerrilysadly"

and it does with the word boundary flags in the regex.

But without them, it highlights as "happily merrily sadly happilymerrilysadly"

** Edited **

Can you try another way of solving the word boundary problem. Edit the loop in ldm_make_highlight_regex as follows:


foreach ($words AS $w) {
if ($w != "") {
$find[] = '/([\p{C}\p{P}\p{Z}]' . $w . '[\p{C}\p{P}\p{Z}]' . ')/iu';
$find[] = '/^(' . $w . '[\p{C}\p{P}\p{Z}]' . ')/iu';
$find[] = '/([\p{C}\p{P}\p{Z}]' . $w . '$)/iu';
}
}

[pooslokka]

Hai we have now your plugin for last thow months and working like a charm.

I have a question.

Do thumbnails are auto generated or we need to upload a thumbnail ? this is for wallpapers.

:confused:

[AndrewD]

Hai we have now your plugin for last thow months and working like a charm.

I have a question.

Do thumbnails are auto generated or we need to upload a thumbnail ? this is for wallpapers.

:confused:

First, you have to set the LDM admin setting link_imagesize, otherwise thumbs are not shown at all

Then, if you fill in the Image field on the Add/Edit Entry form with a image url or image upload, LDM will use that to generate the thummb.

Otherwise, if the entry url itself is an image, the thumbnail is autogenerated from the entry url.

Otherwise, if you have installed the id3tag_enhancements LDM extra and the url is an mp3, it will try to pull out the album art from the mp3.

[derfelix]

Thanks, Felix. Indeed the problem is/was the word boundary. The drawback with removing the word boundary markers is that you end up highlighting substrings in the results which the search itself did not match.
For example, suppose you have a string "happily merrily sadly happilymerrilysadly" and you do a search for merrily

This should highlight as "happily merrily sadly happilymerrilysadly"

and it does with the word boundary flags in the regex.

But without them, it highlights as "happily merrily sadly happilymerrilysadly"

So we need to solve the word boundary problem in utf8.

Well then.. I am happy.. :p then it is actually a feature..

if you search for "intern" in google.. in the description and the title, words like international or internal or internship are highlighted!!!!

i was going to anyway modify the search from "word" to "*word*" because if i do a search for "luxury" and only have one entry with the word "luxuryhotels" in description.. i would get no results..it would not show up.. in that case at least the highlighting would allready be done..
---------------------
on the otherhand.. using ldm as is.. it is also not a major drawback:
if you are looking for merrily ... it will only show you results where the word "merrily" is standalone... so you do have the correct results.. and if you have an extra sadlymerrilysadly then only it will be highlighted.. wich i think is a feature!!!
---------------------

so if it is the only drawback.. i'm sticking to that solution, especially as php6 is going to have full unicode support.. and I am ready to bet that in php6 this problem will be solved!!

But at least for the moment adding the /u modifier (making it /iu) to the regex will help for languages like german, french or spanish as the highlighting will work as you expect it..


Felix
PS: just seen your edit.. doing testing now!

[EDIT]
just tested your routine... works fine with description....(not working with keywords) hmmm

BUT with chinese there is another problem... did some reading (i do not understand chinese)
i was trying to extract content to use as description.. thats how i stumbled into this article:
it says
Chinese sentences are written with no special delimiters such as space to indicate word boundaries. Existing Chinese NLP systems therefore employ preprocessors to segment sentences into words. source: http://portal.acm.org/citation.cfm?id=981621

if this is true i think that the "no boundary" version will for the moment be the easiest solution...for chinese

[pooslokka]

First, you have to set the LDM admin setting link_imagesize, otherwise thumbs are not shown at all

Then, if you fill in the Image field on the Add/Edit Entry form with a image url or image upload, LDM will use that to generate the thummb.

Otherwise, if the entry url itself is an image, the thumbnail is autogenerated from the entry url.

Otherwise, if you have installed the id3tag_enhancements LDM extra and the url is an mp3, it will try to pull out the album art from the mp3.

Tx, but how to specify the link_imagesize ? no example given,
is this format ok? 200px ? 150px

[AndrewD]

Tx, but how to specify the link_imagesize ? no example given,
is this format ok? 200px ? 150px

No, you just put in a number. As the admin page says:

Size in pixels (along larger dimension) of thumbnail image shown within linkbit. 0: No thumbnails is displayed and data entry forms do not offer image fields.

The information about picking up current value of Thumbnail Size, as set in the vBulletin Admin Control Panel, is not working on every system, for a reason that I do not yet understand.

[AndrewD]

Chinese sentences are written with no special delimiters such as space to indicate word boundaries. Existing Chinese NLP systems therefore employ preprocessors to segment sentences into words.

Yes, that was one of the things I discovered too, when I looked into this some time ago. There has been a very helpful and knowledgable Chinese user (ItsBlack) on this forum (he has done all the Chinese translations) - maybe he will spot this post and comment.

I will look at the keyword problem

Edited:

yes, of course, there needs to be a fourth line:

$find[] = '/^(' . $w . '$)/iu';


this is all because the special utf8 regex characters do not map neatly onto \b, as far as I can tell - \b matches at start and end of line which the utf8 specials do not.

[pooslokka]

No, you just put in a number. As the admin page says:

Size in pixels (along larger dimension) of thumbnail image shown within linkbit. 0: No thumbnails is displayed and data entry forms do not offer image fields.

The information about picking up current value of Thumbnail Size, as set in the vBulletin Admin Control Panel, is not working on every system, for a reason that I do not yet understand.

Done, Thumbs are generated nicesly :up:

[derfelix]

maybe he will spot this post and comment.
Looking forward for that...

yes, of course, there needs to be a fourth line:

$find[] = '/^(' . $w . '$)/iu';


this is all because the special utf8 regex characters do not map neatly onto \b, as far as I can tell - \b matches at start and end of line which the utf8 specials do not.

Works as a charm..

Felix

[vbboarder]

Yeeaahh - it's LDM's 1000th post in this thread alone!

Congrats Andrew on a successful mod & community, and thanks for all your help!