custom plugin breaks profile pics

[stephenNYC]

Hi. I made a plugin that, when active, breaks the profile pics. I am trying to figure out why, so I can fix it.

It has a MySql table with 4 columns (num, headline, news, category) that I added to the vBulletin database.
The php code checks postback; if yes, insert.
Then it always selects the last record. (code below)
thanks for any assistance
Stephen

$postback = $_POST["postback"];

if ($postback=="yes") { // new input, so insert
$cNewsHeadline = $_POST["headline"];
$cNewsNews = $_POST["news"];
$insertNews= $db->query_write("INSERT INTO ".TABLE_PREFIX ." cNews (headline, news) VALUES ('".$cNewsHeadline."','".$cNewsNews."')");
}

$NewsResult=$db->query_read("SELECT * FROM " . TABLE_PREFIX . "cNews ORDER BY num DESC LIMIT 1");
$cRow = mysql_fetch_assoc($NewsResult);

$cNewsContent= "<form action='index.php' method='post'><input type='text' name='headline' value='".$cRow['headline']."'><BR>";
$cNewsContent=$cNewsContent."<INPUT TYPE='text' size='80' NAME='news' value='".$cRow['news']."'><BR>";
$cNewsContent=$cNewsContent."<INPUT TYPE='submit'>";

$cUserNewsContent= "<table><tr><td class='thead'><font color='#6600FF'>".$cRow['headline']."</font></td></tr>";
$cUserNewsContent=$cUserNewsContent."<tr><td class='smallfont'>".$cRow['news']."</td></tr></table>";

[ragtek]

you should never write things direct in the db!
read this articles https://vborg.vbsupport.ru/forumdisplay.php?f=187

and where you have built this code into?

[stephenNYC]

Thanks for the reply, I'll read the articles; any one i particular?

The code is in a file named cNews.php, and the file is called as include in the plugin:

include("cNews.php");
eval('$ConsciousNews= "' . fetch_template('ConsciousNewsTemplate') . '";');

[Eikinskjaldi]

Inserting direct into the db is fine, especially when its a custom table owned by you.

When you say "breaks profile pics", what exactly does that mean?

[ragtek]

Inserting direct into the db is fine, especially when its a custom table owned by you.


since when? i learned never to trust the data

[stephenNYC]

thanks for the replies and questions
by broken images I mean we get red x's in explorer and nothing in firefox
if I disable the plugin, they work fine
Stephen

[ragtek]

then the path to the image is false

look at it