query code standards

[Antivirus]

I'm aware that both give me the same result, however with regards to an interger in a WHERE clause, which method is better? Enclosing the int within '2' or without. Is either method faster, or less likely to create problems elsewhere?


$check = $db->query_first("
SELECT eventid FROM " . TABLE_PREFIX . "scst_event
WHERE eventid = '" . $vbulletin->GPC['eventid'] . "'
AND userid = '" . $vbulletin->userinfo['userid'] . "' LIMIT 0, 1
");


or like this:

$check = $db->query_first("
SELECT eventid FROM " . TABLE_PREFIX . "scst_event
WHERE eventid = " . $vbulletin->GPC['eventid'] . "
AND userid = " . $vbulletin->userinfo['userid'] . " LIMIT 0, 1
");


thanks :)

[Kirk Y]

I've always been told that integers shouldn't be quoted.

[Attilitus]

Yep, its more efficient to not quote integers as PHP will view them as a string and will thus be forced to do a conversion before searching for it in an int field.

[Antivirus]

ah, i see - that makes sense, thanks for clarifying it.

Quite often, in native vb code, i have seen something like '" . $vbulletin->userinfo['userid'] . "' so I was confused as to why. Thanks