stumped on yucky parse error

[Antivirus]

I have to call multiple instances of the postbit_attachmentthumbnail template from within the adminCP (crazy, i know)

I am calling it like this:


while ($attachment = $db->fetch_array($attachments))
{
// ... display each thumbnail
$thumbs .= "
<a href=\"attachment.php?".$session['sessionurl']."attachmentid=".$attachment['attachmentid']."&amp;d=".$attachment['dateline']."\" target=\"_blank\">
<img class=\"thumbnail\"
src=\"attachment.php?".$session['sessionurl']."attachmentid=".$attachment['attachmentid']."&amp;stc=1&amp;thumb=1&amp;d=".$attachment['thumbnail_dateline']."\"
border=\"0\"
alt=\"
<phrase
1=\"".$attachment['filename']."\"
2=\"".$attachment['counter']."\"
3=\"".$attachment['filesize']."\"
4=\"".$attachment['attachmentid']."\"
>
".$vbphrase['image_larger_version_x_y_z']."
</phrase>
\"
/>
</a>
&nbsp;".iif($show['br'], "<br /><br />")."
";
}
print_description_row($thumbs, 0, 6, '', 'center');


however i'm not getting the results i need ( see attached "yucky.gif" )

It's something to do with closing the image tag i'm pretty sure. I've been on this for 3 hours now and starting to get brainfry or brainfart. :p

[Eikinskjaldi]

Here's a thought...close the img tag.

Here's another, do this with the template system, thats what it is there for.

[Antivirus]

Isn't the following bit in red closing the img tag"

</phrase>
\"
/>
</a>
&nbsp;".iif($show['br'], "<br /><br />")."

If i'm not mistaken the <phrase> things might be an issue as well, that seems to be some sort of javascript tag which creates the hover text in the alt tag. I don't however know where this is defined and am guessing it's not defined within the admincp.

I didn't think I could eval templates from within the adminCP. I've never seen that done before in any of jelsoft's admin scripts. (or am i just totally fried???)

[Marco van Herwaarden]

Admin scripts usualy do not use the template system (to avoid getting locked out of admincp if there is an error in templates!).

Look at the source of the output page to find your error.

[Opserty]

Don't forget <phrase> tags aren't standard HTML duh :p

[Antivirus]

Well I finally gave up on hving the phrase tags included, and once removed, I'm no longer getting the errors, so thanks for the help people :)

[Opserty]

Use the construct_phrase() (http://members.vbulletin.com/api/vBulletin/_includes_functions_php.html#functionconstruct_phr ase) function see if that works?

[Antivirus]

that function didn't work for me, i think because the <phrase> tag has something to do with javascript, which I am clueless about. Thanks for suggestion though :)

[Adrian Schneider]

<phrase> is not valid HTML ;)

BTW, since you aren't parsing values in your double quotes, switch to single! It will make it so much cleaner to read because you don't have to escape all the HTML attribute quotes.

[Antivirus]

oh, good point thanks Sir.