What's Wrong With My Code?

[noonespecial]

Can someone explain what I'm doing wrong?

$entry= $db->query_first("SELECT tags FROM " . TABLE_PREFIX . "journal_entries WHERE journal_id=1");

$entry['tags'] = stripslashes($entry['tags']);
if ($entry['tags'])
{
$kwords = explode(',', trim($entry['tags']));
$entry['tags'] = '';
foreach ($kwords AS $keyword)
{
$keyword = trim($keyword);
$entry['tags'] .='<a href="/journal.php?' .$vbulletin->session->vars['sessionurl']. 'do=showjournal&amp;tag='.$keyword.'&amp;j='.$j.'" target="_top">' .$keyword. '</a>, ';

}
$entry['tags']= substr_replace($entry['tags'],'',-2);
}

eval('print_output("' . fetch_template('journal_blogcloud') . '");');
$db->free_result($entry);

I'm trying to get this to export all the "tags" (separated by a comma) by a journal ID.

What's wrong with my code?

[nico_swd]

What error do you get?

[noonespecial]

No error, it's just not exporting anything in the template for "$entry[tags]"

Do I need a while statement somewhere?

[nico_swd]

I edited your code for testing purposes, and it seems to be working for me this way. So if $entry['tags'] really holds the expected content, it should work.


<?php

// $entry = $db->query_first("SELECT tags FROM " . TABLE_PREFIX . "journal_entries WHERE journal_id=1");
$entry['tags'] = 'test, one, two, three four, five';

if ($entry['tags'])
{
$kwords = explode(',', trim(stripslashes($entry['tags'])));
$entry['tags'] = array();

foreach ($kwords AS $keyword)
{
$keyword = trim($keyword);
$entry['tags'][] = '<a href="/journal.php?' . $vbulletin->session->vars['sessionurl'] . 'do=showjournal&amp;tag='.$keyword.'&amp;j='.$j.'" target="_top">' .$keyword. '</a>';
}

$entry['tags'] = implode(', ', $entry['tags']);
echo $entry['tags'];
}

// eval('print_output("' . fetch_template('journal_blogcloud') . '");');
// $db->free_result($entry);

[noonespecial]

$entry['tags'] has some "null" data ... would that cause a problem?

$entry = $db->query_first("SELECT tags FROM " . TABLE_PREFIX . "journal_entries WHERE journal_id =" . $vbulletin->GPC['j']." AND tags IS NOT NULL");

EDIT: only pulls one entry from the correct row ... not all of them.

should i be doing a "query" instead -- and then grabbing the data out of the array a different way?

[nico_swd]

Your script expects $entry['tags'] to hold a string, with comma separated values. Can you post an example of what $entry['tags'] holds?

[noonespecial]

Some examples:

random, staff, inside

random

drew

NULL

tags varchar(255) latin1_swedish_ci Yes NULL

From PHPMyadmin, if this helps.

$entrys = $db->query_read("SELECT * , tags IS NULL AS isnull FROM " . TABLE_PREFIX . "journal_entries WHERE journal_id =" . $vbulletin->GPC['j']." ORDER BY isnull ASC, tags ASC");

while ($entry = $db->fetch_array($entrys))
{

if ($entry['tags'])
{
$kwords = explode(',', trim($entry['tags']));
$entry['tags'] = '';
foreach ($kwords AS $keyword)
{
$keyword = trim($keyword);
$entry['tags'] .='<a href="/journal.php?' .$vbulletin->session->vars['sessionurl']. 'do=showjournal&amp;tag='.$keyword.'&amp;j='.$j.'">' .$keyword. '</a>, ';

}
$entry['tags']= substr_replace($entry['tags'],'',-2);
}
}

Also doesn't work.

Edit:

Do I need to somehow add "commas" to the end of the other values?

I am so lost..

Someone, please help.