PDA

View Full Version : Administrative and Maintenance Tools - Template Modification System


Pages : [1] 2 3 4

Andreas
07-20-2007, 10:00 PM
Template Modification System
Description
This modification allows easy management of template modifications.
Hack authors can define the necessary template modifications for their products.
When exporting a product, all template modifications assigned to this product
in MASTER style will be embedded into the product XML and imported on the
end-user vBulletin installation automatically if TMS is available.
Alternatively, it is also possible to create separate XML files for template modifications.
This way, 3rd parties can provide Template-Modification XML files for existing hacks.
Hack authors can also export standard template modification instructions as
textfiles to package them with their hacks, which allows users that do not
have TMS to also install them

In case the author defined modifications do not work (eg. the user uses a custom style),
the users can easily customize the modifications for their style(s).

TMS modified templates transparently, e.g. all Templates can still be modified
manually in style manager - they will appear unchanged there.


System Requirements
This Modification requires MySQL 4.1 or higher - it does not work with MySQL 4.0!
If you use MySQL 4.1 series, MySQL 4.1.10 or higher is required
If you use MySQL 5.0 series, MySQL 5.0.3 or higher is required
TMS 1.2.0 Beta 1 or higher requires vBulletin 4.1.5 or higher

vBulletin Compatibility
Versions up to and including 1.1.5 are compatible with vBulletin 3.6.X, 3.7.X and 3.8.X
Version 1.1.5 is partly compatible with vBulletin 4.0.X and 4.1.X
Version 1.2.0 Beta 1 or higher is compatible with vBulletin 4.1.5 or higher
vBulletin 4.1.11 or higher is currently not fully supported by TMS. If you use this version please apply the following patch: 136973

Branding:
Please note that TMS puts a small branding/copyright notice in footer - see readme.txt for further details.

Version History
1.2.0 Beta 4

Bugfix: Database error when trying to add a template modification (this bug was introduced in TMS 1.2.0 Beta 3)


1.2.0 Beta 3

Changed: Converted hardcoded text to phrases
New Feature: Added doubleclick for editing style variables
Bugfix: Database error when trying to add a template modification with an existing varname to a different style
Changed: Fixed formatting of templateedits.php
Bugfix: Fixed erors when manually modifying a template with template modifications


1.2.0 Beta 2

Bugfix: Fixed errors in style variable editing code


1.2.0 Beta 1

Changed: Ported to vBulletin 4.1
New Feature: If an error occurs while trying to compile a template this error is now being disaplayed when trying to save the template modification
New Feature: Styles variables used in templates can be edited via AJAX from the modify template screen


1.1.5

Fixed Bug: Fixed incorrect variable type
New Feature: Box 'Template-Modifications' (shown on editing a template) can now be collapsed/expanded


1.1.4

Fixed Bug: Fixed HTML error/XSS in Template Modifications Manager


1.1.3

Fixed Bug: Added missing phrase on ACP home


1.1.1

Fixed Bug: Fixed Error with conflicting Template Modifications when importing a product
Fixed Bug: Removed Pre-Selection of processing mode when adding new modifications
Fixed Bug: Fixed Bug with zlib.output_compression AND vBulletin internal gzip being both turned on
Fixed Bug: Display search results correctly
Fixed Bug: Added missing phrase 'varname_x_already_exists'
New Feature: Automatically rebuild template modifications after vBulletin Upgrade


1.0.0

Changed: Several files renamed
Fixed Bug: Fixed incorrect handling of product ids that contain only numbers
New Feature: Search text can be search in template when editing a Template-Modification in Style Manager
Changed: Multiple Template-Modifications can be loaded via AJAX
First Release on vBulletin.org


1.0.0 RC 1

Fixed Bug: All Bugs reported for Beta 4 have been fixed
Changed: Display of modified Templates with HTML comments has been modified
Changed: Debug-Mode is no longer required
New Feature: It is now possible to export/import style-specific Template-Modifications


1.0.0 Beta 4

Fixed Bug: All Bugs reported for Beta 3 have been fixed
Changed: Sorting in Template Modifications Manager has been changed
New Feature: When adding or editing a Template-Modification, the Template can now be displayed and searched via AJAX
Changed: When exporting as Text, the original instructions (eg. insert below/above) are retained
New Feature: It is now possible to test each Template-Modification
New Feature: Testing improved. It is now being display if a Template is OK after applying a Template Modification
New Feature: When editing a Template, it is possible to activate/deactvate multiple Template-Modifications
New Feature: Template-Modifications can now also be exported and tested from withing Product Manager
New Feature: Function to display a template with all Modifications applied.
This function can also display embedded comments to make it easier to identify changed parts


1.0.0 Beta 3

Fixed Bug: All Bugs reported for Beta 2 have been fixed
New Feature: Simplified adding Template-Modifications by allowing to select how to handle replacement text (eg. replace or insert above/below)
New Feature: Each Template-Modification can now be disabled
Changed: Testing Template-Modifications has been reworked:
Column ordering can now be set through vBulletin Options; column headers are clickable to sort results
Output has been separated by styles
It is now possible to test only selcted products
New Feature: TMS now integrates with 'Style Manager' and 'Product Manager'
New Feature: The language can be selected when exporting Template-Modifications
New Feature: Weh TMS gets deactivated, all Template-Modifications will be deactivated too
New Feature: Display of Template-Modifications while editing a Template in Style Manager has been improved:
It is now being display if a Template-Modification could be applied
Template-Modifications can be edited via AJAX


1.0.0 Beta 2
First public Beta

Andreas
07-21-2007, 01:14 PM
Why should I use TMS? Most products modify templates automatically.
Many product nowadys do not require manual template edits any longer - they automatically modify templates during runtime.
This is easy for the user - as long as the author-defined serch texts can be found.
If this is not the case, the user must manually edit templates, or modify the plugins of the product.
Both options have drawbacks: If you manually modify templates, those templates are not automatically updated upon vBulletin updates.
Modifying the plugins means that you have to do this every time you update the product.
Furthermore, modifying the templates at runtime costs performance.

TMS does not have these disadvantages: The User can easily customize author-defined template modifications.
Those modifications are kept on vBulletin updates and continue to work - as long as the part of the template
the modification is refering to is not modified.
TMS also does not execute any code in the frontend at runtime, eg. there is no overhead at all.

I tried to customize a Template modification but I got an error that the template is not customized?
TMS can only operate on custom/customized templates. If a Template is inherited from a parent style and you
want to customize a Template-Modification for this Template, you must either customize the template in the
destination style or customize the Template-Modification for the template in the parent style it was inherited from.

I tested template modifications, but all modifications seem to be missing in my styles - there are only results for MASTER
As said before, TMS can only operate on custom/customized templates.
If templates in a certain style are inherited from parent styles, you will get no results for these template in the child style.

I tried to import a Template Modification XML but got an error that this is not a valid product?
Template Modification XML files are no products.
You must import them through ACP / Styles & Template / Template-Modifications Manager

How can I use TMS for already installed hacks for which I have manually modified templates?
If a Template-Modifications XML is already available for this hack, just undo the template edits you did manually.
Afterwards, go to ACP / Styles & Template / Template-Modifications Manager.
Click Up-/Download Template-Modifications and import the XML.
If you want to test if everything is OK, got to ACP / Products & Plugins / Manage Products and
select Template-Modifications / Test from the dropdown

If no Template-Modifications XML does exist, you must add the modifications to TMS yourself.

How can I add Template-Modifications to TMS?
Go to ACP / Styles & Templates / Template-Modifications Manager
In the style where you want to add the Template-Modification, select 'Add Template-Modification' form the dropdown.
If you want to add a Template-Modification to all styles add them to the MASTER style.
Please note that you can only add Template-Modifications for templates that are custom/cusomized in the choosen style.
On the next page, select the product and template for which you want to add a template modification.
Enter a short, descriptive tilte and chose a varname.
The varname must be uniqe and can only consist of alpha-numeric characters (eg. a-z, A-Z, 0-9, - and _);
you can choose any varname you want - it is just used to identify Template-Modifications internally.
Make sure that active is set to 'Yes'.
Search order can normally be left at the default value (5); this only needs to be changed if
several modifications operate on the same position in the template and thus their order is important.
Copy the text that should be searched into textarea 'Search for Text', copy the text that should replace
the previous text (or get inserteb below or above it) into the following textarea and choose the
appropriate mode (eg. Replace, Isert Below or Insert Above).
If you still have the installation instructions for you hacks, this can be mostly done with copy & paste.

Where can I get Template Modifiction XML files?
There are several XMLs already available at vBHacks-Germany.org.
http://vbhacks-germany.org/showthread.php?t=5584
http://vbhacks-germany.org/showthread.php?t=5833
Also, some products released on vBuleltin.org by Surviver, Stoebi (and maybe some other german authors too) already do have TMS data in their product XML files.

Surviver
07-21-2007, 01:14 PM
Thank you Andreas, Great Add-On :)

Installed & Nominated for MotM

PS: Some TMS-XML Files attached

Yours Truly
07-21-2007, 01:15 PM
*** reserved for FAQ ***
Wow your 1st 3.6.x would be awesome to see some 3.5.x ports =]

Kihon Kata
07-21-2007, 01:54 PM
I'll try this soon, I've DL'ed it.

I can tell you one thing, I am afraid of this:

Warning
-------
The maintenance function 'Rebuild all Styles' MUST NOT be executed when the Plugin System or TMS is disabled!


What happens if one does this?

Hellboys
07-21-2007, 02:28 PM
One of the best Hack on VB !

Many Thanks Andreas for providing this great work.

Andreas
07-21-2007, 02:57 PM
What happens if one does this?
You wil get database errors becasue a necessary field will be deleted if you tick "Renumber all Templates".

TCattitude
07-21-2007, 07:45 PM
Welcome back to "the dot org", Andreas.
Thanks for all your releases (and, of course, TMS) ;)

4number8
07-21-2007, 09:54 PM
Nice work Andreas, many thanks for this!

hcmagix
07-21-2007, 11:40 PM
One of the best Hack on VB !

Many Thanks Andreas for providing this great work.

We use this hack some months ago and its the best hack ever seen. Fine that the english speaking world can use the hack now :)

Have fun and no more stress by vbulletin upgrade :)

special thanks to Andreas aka Kirby

Paul M
07-22-2007, 01:31 AM
TMS can only operate on custo/customized templates.

Perhaps I'm not understanding this - are you saying that if I am using a style (let's call it 'My-Style') that is a child of the MASTER STYLE then TMS will not work on any of the 'My-Style' templates unless they are customised versions in My-Style (i.e. not inherited from MASTER) ?

This seems to be a bit of a big drawback as that's how most forums I've seen are set-up.

alessai
07-22-2007, 01:42 AM
:confused: hmmmm i didnt get it?!!!
so what does it do exactly? it make the changes for certain style into another ? or what?!!

:p sorry if i sound stuiped

Andreas
07-22-2007, 08:05 AM
Perhaps I'm not understanding this - are you saying that if I am using a style (let's call it 'My-Style') that is a child of the MASTER STYLE then TMS will not work on any of the 'My-Style' templates unless they are customised versions in My-Style (i.e. not inherited from MASTER) ?

No. It means:
If your postbit template is not customized in style 'My Style' (which inherits from MASTER), you can't apply modifications to this template that are different from the modification applied to MASTER postbit template.
Technical background: Templates that are inherited only exist as references.

so what does it do exactly?
Basically: It allows you to modify templates without customizing them.
This means, that your modifications will still work after vBulletin updates - vBulletin will not 'complain' about outdated templates.
It means that you don't have to edit templates manually if the product support TMS - just install/uninstall/activate/deactivate, the template stuff will be done automatically.
All this is done without any overhead at frontend runtime.

@All
If you are using this modification and have added template-modifications for products released on vBulletin.org to your installation - feel free to export your XMLs and share them with others here.

D&Y
07-22-2007, 08:09 AM
Excellent !! Works Great !!

D&Y Clicks Install !

MrZeropage
07-22-2007, 08:13 AM
Fantastic thing, good to see it is final 1.0.0 now :)

Thanks for this handy tool !

calorie
07-22-2007, 08:36 AM
Kirby!!! Thanks for the release. Will look at this when time permits. :)

hcmagix
07-22-2007, 09:21 AM
MOTM klicked :)

@All
If you are using this modification and have added template-modifications for products released on vBulletin.org to your installation - feel free to export your XMLs and share them with others here.
right!

mhc1576
07-22-2007, 11:57 AM
It does not work in IE7 :

Line: 120
Char: 55
Error: Identifier expected
Code: 0
URL: http://....../templateedits.php

and it is not possible to go anywhere by Go.

Andreas
07-22-2007, 12:03 PM
Try the attached JS file.
I'll also update the package later.

mhc1576
07-22-2007, 12:13 PM
Sorry,

Same error......

Andreas
07-22-2007, 12:23 PM
I assume you did clear your browser cache before testing again?

mhc1576
07-22-2007, 12:35 PM
I did ctrl F5 and that should reload or??

Edit:
Well IE...
I restarted the browser and after that it was ok.

Thanks a lot Andreas, I tried this at vBH-germany but never got it to work but now it works.

Andreas
07-22-2007, 12:41 PM
No, that might not be enough.
Please clear the cache.

Pathor
07-22-2007, 03:40 PM
Installed and nominated for the mod of the month. ;)

Delphiprogrammi
07-22-2007, 05:37 PM
one word fantastic you got my vote for mod of the month to

* Delphiprogrammi installs

Andreas the go button is giving me a javascript error when you select "add a new template modification" and after that clicking the go button also the system says i do not have any customized templates which is not true i do have customized templates

Internet explorer 6 ... yeah the bad one

edit problem solved ....

rellek
07-23-2007, 08:05 AM
Thank you soooo much for releasing this fine modification here! :)
//clicked installed
//clicked MoTM

tuwebfacil
07-23-2007, 10:39 AM
This should be standard on vBulletin!

Great Idea!

captainslater
07-23-2007, 11:01 AM
Greatest mod ever, thanks for sharing to all now.

thincom2000
07-23-2007, 01:12 PM
With this installed it is impossible to edit templates in the normal way through Style Manager because the form is all messed up. Also the Product Manager doesn't display all products. Sadly, I have had to disable this product for the time being.

Andreas
07-23-2007, 01:48 PM
Screenshots and/or HTML source of the 'messed up' pages would be useful.

thincom2000
07-23-2007, 03:13 PM
Here is a screenshot of my Style Manager after enabling this. Sometimes it shows even less of the editor i.e. just the Product bar, etc.

Delphiprogrammi
07-24-2007, 11:14 AM
hi,

there is a missing phrase called

varname_x_already_exists it's in adminfunctions_templateedits line 726

GrendelKhan{TSU
07-24-2007, 02:11 PM
omg.. coming from a guy who just did 30 differfent template reverts and re-updates in last upgrade...

THANK YOU!!!!!

<< installed and nomianted. :)

taxick
07-24-2007, 09:24 PM
Hey

I get this error - plz help me! I cant uninstall agian becurs the same sql error

Database error in vBulletin 3.6.5:

Invalid SQL:

SELECT templateid, searchstrregex, replacestr
FROM templateedit AS templateedit
INNER JOIN templateeditlocation AS templateeditlocation ON (templateeditlocation.varname=templateedit.varname )
INNER JOIN template AS template ON (template.title=templateeditlocation.template)
LEFT JOIN style AS style ON (style.styleid=template.styleid AND FIND_IN_SET(templateedit.templateeditid, style.templateeditlist))
LEFT JOIN product AS product ON (product.productid=templateeditlocation.product)
WHERE (NOT ISNULL(style.styleid) OR (templateedit.styleid=-1 AND template.styleid=-1))
AND (product.active=1 OR templateeditlocation.product='vbulletin')
AND templateedit.active = 1


ORDER BY searchorder ASC;

MySQL Error : Illegal mix of collations (latin1_general_ci,IMPLICIT) and (latin1_swedish_ci,IMPLICIT) for operation '='
Error Number : 1267
Date : Tuesday, July 24th 2007 @ 09:55:09 PM
Script : ***********************
Referrer :
IP Address : **************
Username : Taxick
Classname : vB_Database

Delphiprogrammi
07-25-2007, 08:45 AM
hi,

there is a missing phrase called

varname_x_already_exists it's in adminfunctions_templateedits line 726

it keeps on trying to output the eror with the missing phrase with would be impossible as all my varnames are unique...

rellek
07-27-2007, 08:32 AM
Andreas, just one little request. Could you maybe release the German localization here as well? This would be very kind of you :)


best regards,
rellek

Andreas
07-27-2007, 08:34 AM
The german version is available at vBHacks-Germany.org:
http://www.vbhacks-germany.org/misc.php?do=findrelease&product=tms

rellek
07-27-2007, 08:49 AM
I mean for those who do not have an account at vBH, whyever.

Andreas
07-27-2007, 08:52 AM
The german version will only be available and supported at vBHacks-Germany.org.

rellek
07-27-2007, 08:53 AM
What a pity :(

mhc1576
07-27-2007, 07:23 PM
If you are a vB owner just register with the same email as here and you will get access.

Feckie (Roger)
07-27-2007, 07:30 PM
Nice To see You Back Andreas ...:)

thincom2000
07-29-2007, 07:44 AM
Well I had to remove a few plugins in order for this to stop breaking all my admin pages, but I got it working. Just in time for 3.6.8, too. Thanks!

alluidh
07-31-2007, 10:02 AM
The german version will only be available and supported at vBHacks-Germany.org.
Are you sure? I'm not able to post questions there because of the new rulesets and I didn't saw you there too.

Andreas
07-31-2007, 11:29 AM
Absolutely sure. vBHacks-Germany.org is the official german vBulletin hacks community and I will not support or release german modifications anywhere else.

@thincom
Which plugins specifically?
Can you post your phpinfo()?

Deepdog009
07-31-2007, 02:50 PM
And how R-U doing :D

Keep the ball rolling...

Tausend Dank!

StarBuG
07-31-2007, 07:02 PM
Hi Andreas,

finally English speaking users can enjoy this great hack too.

For me this is THE most important feature since the introduction of the plugin system.
I know I was a pain in the a.. with all my requests but the product is simply beautiful.
(Still missing a code search inside all modifications though :p)

I just want to say thank you and keep up your great work.
You are a real asset to this community

Nominated for the Hack of the month of course

Best regards

StarBuG

ps: do you still develope the german version or will this now be the most up to date version?

Brandon Sheley
07-31-2007, 09:25 PM
looks interesting :)

Andreas
08-01-2007, 10:34 AM
@StarBug
This version is the same as the german version (well, except for the language ;)).
A search feature is already planned, but there is no ETA yet.
The german version will be maintained the same way as the english version.

Hoffi
08-01-2007, 12:11 PM
Great to see the Hack here at vb.org too!

NFLfbJunkie
08-01-2007, 03:33 PM
So with this MOD are template edits done within TMS and no longer by pulling up the template from the appropriate style and then doing the edits? Also, after each template edit, are you supposed to export the template edit to use in the future should there be upgrades to the vBulletin software, thus not needing to redo all of your previous template edits?

Also, I noticed that the only style I have on my board is the Default style; I do not see a Master style. Should I have both?

Finally, on my board so far I have the following MODs installed along with all of the required template (and file) edits:
Thread Prefixes
Move Display Options Above Threads
Change Thread Prefix Inline
ibProArcade
vBadvanced CMPS
vBCredits
vBCredits with ibProArcade
Vb Save Drafts (MOD from vBHackers.com)
Project Tools

Do I need to uninstall these MODs beofre installing TMS or is there something I need to do with them after I install TMS?

Andreas
08-01-2007, 05:44 PM
So with this MOD are template edits done within TMS and no longer by pulling up the template from the appropriate style and then doing the edits?

TMS applies template modifications to compiled templates; the template source is not being modified.
If you use TMS for all your template modifications, it is not necessary to manually edit templates.

Also, after each template edit, are you supposed to export the template edit to use in the future should there be upgrades to the vBulletin software, thus not needing to redo all of your previous template edits?
You do not have to export template edits. This is only necessary if you want to copy template edits to another vBulletin installation or share them with other users.

Also, I noticed that the only style I have on my board is the Default style; I do not see a Master style. Should I have both?

MASTER style is only visible in debug mode, but it is not necessary to turn on debug mode to add template modifications in MASTER style.


Do I need to uninstall these MODs beofre installing TMS or is there something I need to do with them after I install TMS?
Do NOT uninstall these modifications! If you do so, you will loose the data.
However, you can undo the template edits you did manually for those modifications and add them to TMS instead. This is recommended to avoid having to manually update templates on vBulletin upgrades.

NFLfbJunkie
08-01-2007, 05:51 PM
Do NOT uninstall these modifications! If you do so, you will loose the data.
However, you can undo the template edits you did manually for those modifications and add them to TMS instead.


I don't quite understand what it means to "add them to TMS instead" after I undo (revert) the template edits I have done manually. Should I revert all of my templates that I have edited? And if so, afterwards, what do I have TMS do? I am not familiar with TMS just yet so any guidance would be appreciated.

NFLfbJunkie
08-01-2007, 05:54 PM
One other question I have is this MOD has nothing to do with files (i.e., .php files) that are edited as a result of adding MODs, correct? These will have to be re-edited regardless if an upgrade is done to the vBulletin software?

Andreas
08-01-2007, 06:17 PM
See FAQ:
https://vborg.vbsupport.ru/showpost.php?p=1297359&postcount=2

This explains what to do with manually applied template modifications.

NFLfbJunkie
08-01-2007, 06:25 PM
In some case the code that you are asked to search for may not be exactly what is in your template, so what should one do in these cases. For instance if I add a Template-Modification and put something in the for the search and replace text fields, what happens if the search text doesn't exactly match what the existing template has?

Andreas
08-01-2007, 08:29 PM
Then it won't work :)
If the instructions do not work for your Template, it most likely means your template has been customized.
So you have to modify the search/replace text to meet the requirements for your template - as you would do if you are manually editing templates.

NFLfbJunkie
08-01-2007, 11:53 PM
Are plugins & products supposed to be uploaded through the Plugins & Products sections of the AdminCP, while Template Modifications get uploaded through this MOD. Also, and maybe this question is off target, but when importing plugins, aren't template modifications being made, and if so, how are these edits separated from the edits a Template MOD makes?

Andreas
08-02-2007, 06:39 AM
You can import & export templates modifications through Styles & Templates / Template-Modifications Manager.
However, if a product directly supports TMS you don't have to do anything - the template edits are contained within the product XML and will be imported as well.

Funboy
08-02-2007, 11:20 AM
Great Mod, Thx for your hard work Andreas.

Regards
Funboy

NFLfbJunkie
08-02-2007, 01:40 PM
I have just a few more questions so I can understand exactly what this MOD does before I install it. From what everyone else is saying it seems like this MOD is a must have for vBulletin owners considering the constant upgrades with this software. If this MOD saves board adminstrators the time it takes to redo template edits after an upgrade, then it should be included with the vBulletin software package.


If a MOD calls for more than one template edit does each one need to be added separtely as a Template-Modification; and if one template needs to have more than one edit applied to it do these need to be added separately as well?
How exactly does the Template-Modification system work when a vBulletin upgrade is performed? Stated in the release notes is the fact that edited templates aren't affected when an upgrade is done. So does this mean that a board with MODs is running off of the edited and original templates?
Don't some MODs have a plugin that you need to install and also have template edits that need to be done for the MOD? For these MODs, I would assume you would add the edits through TMS. But how are the template edits that are done from the plugin added in to TMS?Hopefully I am not sounding too confused with the above questions. Again, just trying to figure out what seems to be a very handy tool when it comes to template editing.:D

Mazinger
08-02-2007, 06:26 PM
Thanks. This is very useful addon for those who edit templates much.

I'll give it a try later. :)

Alfa1
08-04-2007, 11:04 AM
This should be standard on vBulletin!

Great Idea!
Agreed.

Can someone please share the Template-Modification XML file for Thread prefixes (https://vborg.vbsupport.ru/showthread.php?t=123033)

Wulfnoth
08-04-2007, 11:39 AM
The xml-file is included in the .zip-file of TMS.

Alfa1
08-04-2007, 12:50 PM
That is amazing. Thanks!

patrickb
08-06-2007, 02:10 AM
This IS great!

Installed!

Would it be possible to provide an English version of the demos? Shouldn't be too hard...only rename the different edits.

slyreptile
08-06-2007, 02:15 AM
Am I understanding this correctly?

If I have a mod that needs manual template edits....

1. I must add it to the MASTER template, thus eliminating the need to perform manual template edits.

OR

2. Add the manual entries directly to the template, then Add them to the template we want it used on in the Manager? Obviously, the mod doesn't show as being there until it's directly added manually to the template.

Andreas
08-06-2007, 03:08 PM
If a MOD calls for more than one template edit does each one need to be added separtely as a Template-Modification; and if one template needs to have more than one edit applied to it do these need to be added separately as well?
Just like you would apply templay modifications manually:
If a mod required edits for 2 templates - you have to add 2 template modifications.
If it requires 2 modifications in 1 template, you have to add 2 template modifications, etc.


How exactly does the Template-Modification system work when a vBulletin upgrade is performed? Stated in the release notes is the fact that edited templates aren't affected when an upgrade is done. So does this mean that a board with MODs is running off of the edited and original templates?
TMS detects if a vBulletin upgrade was performed and template for which there are template modifications are defined in TMS. If there are sucgh templates, a warning mesage is being displayed on ACP home.
By clicking the link, those template modifications will be tested if the do still work.
If not you must modify the template modifications (this happens when search text is modified in the new vBulletin version and can't be found anymore).

Don't some MODs have a plugin that you need to install and also have template edits that need to be done for the MOD? For these MODs, I would assume you would add the edits through TMS. But how are the template edits that are done from the plugin added in to TMS?
There are products that edit templates at runtime.
You can either leave that as-is, or disable the plugin and add the necessary template modifications to TMS.


If I have a mod that needs manual template edits....

As stated in the FAQ:
1. Click Styles & Template / Template-Modifications Manager
2. Next to the Style where you want to add the template-modification (normally this would be MASTER) select 'Add Template-Modification'
3. Select the Template and Product
Set Active to Yes
Enter a varname and descriptive Title
4. Paste the seach text from the mod instructions into the 1st textarea
5. Paste the replace text from the mod instructions into the 2nd textare and choose the appropirate method as stated in teh instructions (eg. replace, insert above/below)
5. Click Save

Repeat these steps for all necessary template modifications.

Done.


Would it be possible to provide an English version of the demos? Shouldn't be too hard...only rename the different edits.

Rename the titles?
Not really ;)

BigDog56
08-06-2007, 09:28 PM
I can't get it to work on 3.6.8 I click on the Template mod. manager, clik on the master style, add template mod. and nothing happens. On the bottom left corner of IE I have an "Error on page" Message..

Andreas
08-07-2007, 07:20 AM
See post # 19.

BigDog56
08-07-2007, 11:19 AM
See post # 19. EDIT: Figured it out. Will try it shorty! Thank You!

ringleader
08-07-2007, 12:49 PM
Just to let you know, it's working for me with mySQL v4.0.26-standard.

The only thing is I keep getting this error:

Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 1984105 bytes) in [MyPath]/includes/adminfunctions_templateedits.php on line 970

I'll put up with having to come up with workarounds for this to keep this fantastic mod, however!

Andreas,

https://vborg.vbsupport.ru/

Delphiprogrammi
08-07-2007, 01:47 PM
Just to let you know, it's working for me with mySQL v4.0.26-standard.

The only thing is I keep getting this error:

Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 1984105 bytes) in [MyPath]/includes/adminfunctions_templateedits.php on line 970


That error has nothing todo with tms that's caused by your PHP configuration increase your memory limit in php.ini (root access requirerd or you can't do this)

ringleader
08-07-2007, 01:56 PM
That error has nothing todo with tms that's caused by your PHP configuration increase your memory limit in php.ini (root access requirerd or you can't do this)

Ah grand so. I'll try that.

It just keeps coming up in relation to TMS, like when adding/editing modifications in certain templates:
Updating Template-Modifications for Stye 'MASTER' and its Child-Styles ...

* MASTER ... (Templateedit-IDs)
Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 1984105 bytes) in [mypath]/includes/adminfunctions_templateedits.php on line 970

0tolerance
08-07-2007, 09:45 PM
OMG if you were here i'd kiss you!
this is the perfect modification for my board...
if only i could nominate for mod of the month!

one question does this work on 3.6.X or only versions 3.6.7 and above?
cause i run a 3.6.2 3.6.4 3.6.5 and 3.6.8 board(3 of them being development boards)

Andreas
08-08-2007, 04:06 AM
Any 3.6 is fine.

0tolerance
08-08-2007, 07:17 AM
Hi again.
I'm getting some troubles, when i go to "Add Template Modification" or any of the drop down menu items, they dont go any where at all.. but the links on the bottom of the frame such as up/download a template modification works.

Perhaps i need to do something else?

p.s. i must say how super easy it is to install your mod

BigDog56
08-08-2007, 10:08 AM
Works great now. This is a fantastic mod. Thank you very much!

Tulsa
08-09-2007, 02:42 PM
I'm getting an odd error on the main page of the admincp.

!!! Out-of-date Template-Modifications found !!!

There are 1 Template-Modifications that were not desinged for the currently installed vBulletin version. To make sure that vBulletin and your installed Products are working correctly, you must check and maybe modify those Template-Modifications.

Test Template-Modifications (http://www.pachitalk.com/forums/admincp/templateedits.php?do=test)

Delphiprogrammi
08-09-2007, 02:58 PM
I'm getting an odd error on the main page of the admincp.

yeah i get it to quite annoying

ringleader
08-10-2007, 07:08 AM
Me three. I just ignored it since there's nothing out of date for me.

AzzidReign
08-10-2007, 12:00 PM
Andreas - AWESOME MOD! I love it. At first it's a little weird to get use to or figure out...mainly b/c I hadn't really looked at it much but once I started working with it, DAMN IT'S AWESOME! I'm surprised more people aren't using this...this is by far the best mod I've worked with. After the initial set up (which I did before I upgraded to 3.6.8), it took some time, but when I updated vB, it took me a total of 5-10 minutes to update vB and get the site up and running with the templates! Much better than 5-10 hours with all my template edits! So thank you for making our lives easier! :)


I'm getting an odd error on the main page of the admincp.
Same here.

Broceliande
08-10-2007, 12:22 PM
i can not use it on 3.6.8
when i say edit template it does nothing

AzzidReign
08-10-2007, 12:43 PM
You have to reupload all the files. That happened at one of my friend's site, and all he had to do was reupload and overwrite all the files.

Andreas
08-10-2007, 01:07 PM
The '1 Out-of-Date Template Modifications found' message can safely be ignore - it's just a little bug.
To fix it: Delete the plugin 'Veraltete Template-modifikationen suchen' on Hook admin_index_main1.
Afterwards, import the attached plugin XML.
That should fix it.

Tulsa
08-10-2007, 02:00 PM
Fixed it! :)

bshutter
08-13-2007, 04:24 AM
Works great Ty

Michael Biddle
08-15-2007, 01:01 AM
Amazing mod Andreas, thanks for this, makes products so much easier on user side of things.

Alfa1
08-15-2007, 11:05 PM
I just noted that the TMS adds branding to my BFO vbulletin. How can this be removed?

Tulsa
08-15-2007, 11:54 PM
A question...

I just did an upgrade to two different mods I have installed and had template changes made and working in this mod. In order for those those template edits to work again, I had to resave the edit. I didn't change it, just had to resave it before it would effect the template. Is this normal?

slowphantom
08-16-2007, 04:07 AM
hi
what is this mean pls
Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT IF(templateedit.product='vbulletin', 1, product.active) AS productactive, templateedit.active AS editactive, templateedit.version AS editversion, template.version AS templateversion, templateeditlocation.product, templateeditid, templateedit.styleid AS tstyleid, template.styleid, template.title AS template, templateeditlocation.title, template.template_un, searchstrregex, IF(templateeditlocation.product='vbulletin', 'vBulletin', product.title) AS product, templateedit.replacestr
FROM templateedit AS templateedit
INNER JOIN templateeditlocation AS templateeditlocation ON (templateeditlocation.varname=templateedit.varname )
INNER JOIN template AS template ON (template.title=templateeditlocation.template)
LEFT JOIN style AS style ON (style.styleid=template.styleid AND FIND_IN_SET(templateedit.templateeditid, style.templateeditlist))
LEFT JOIN product AS product ON (product.productid=templateeditlocation.product)
WHERE (NOT ISNULL(style.styleid) OR (templateedit.styleid = -1 AND template.styleid = -1))
AND (templateedit.product = 'vbulletin' OR product.active = 1)
AND templateedit.active = 1
AND templateeditlocation.varname != 'tmsbranding'

AND templateeditlocation.product = 'tms'
ORDER BY style.displayorder ASC, style.styleid ASC, template.title ASC, product.title ASC, templateeditlocation.title ASC;

MySQL Error : Unknown column 'searchstrregex' in 'field list'
Error Number : 1054
Date : Thursday, August 16th 2007 @ 08:05:49 AM
Script : http://xxx.com/vb/admincp/templateedits.php?do=test&productid=tms&s=
Referrer : http://xxx.com/vb/admincp/index.php
IP Address : ............
Username : ...........
Classname : vb_database

now evrything is stop
cant remove any thing
help pls

Delphiprogrammi
08-16-2007, 09:07 AM
I just noted that the TMS adds branding to my BFO vbulletin. How can this be removed?

you can't ....


This work is Copyright (C) 2005-2007 by Andreas Kirbach.
The license holder is allowed to use and modify the script for his own use.
However, removing or editing the branding is NOT allowed!


also read readme.txt there is some info that migt become usefull ...

TCattitude
08-17-2007, 06:40 PM
Suggestions:
- Option to don't specify a "Search for Text" in selected template; instead, another two options to "put at the very top" and "put at the very bottom" of the selected template. Just to be lazy, really (and not put the part of the html in certain template that belongs to the very top, and then select "insert text above".
- Search in template modifications. With a lot of TMS installed, would be nice to search like if that modifications are actually templates; similar (a clone) of the search in templates.

Thanks... again... Andreas, for this every-day-more-really-awesome-upgrade-pain-saver mod!
TC

Michael Biddle
08-18-2007, 07:06 PM
Hey Andreas, how could I get this to work with your advanced plugin manager?

Like the dropdown doesnt show how to export the txt files?

Thanks in advanced.

Andreas
08-19-2007, 06:34 PM
@TCAttitude
Search is already planned.
Inserting at the top/end probably would need some significatin changes to the design and I don't think it is that important?

Stoebi
08-19-2007, 06:59 PM
@whitemike
open advplugins.php and search for

case 'productexport': page = "plugin.php?do=productexport&productid="; break;
Add below:

case 'tmsdeleteedits': page = "templateedits.php?do=deleteall&productid="; break;
case 'tmstestproduct': page = "templateedits.php?do=test&productid="; break;
case 'tmsexport': page = "templateedits.php?do=files&productid="; break;
Search for

$options['productexport'] = $vbphrase['export'];
Replace with:

if ($vbulletin->products['tms'])
{
$options['productexport'] = $vbphrase['export'] . '<optgroup label="' . $vbphrase[templateedits] . '"><option value="tmstestproduct">' . $vbphrase[test] . '</option><option value="tmsdeleteedits">' . $vbphrase[delete] . '</option><option value="tmsexport">' . $vbphrase[export] . '</option></optgroup>';
}
else
{
$options['productexport'] = $vbphrase['export'];
}



Kind Regards,

Stoebi

Michael Biddle
08-19-2007, 09:55 PM
@whitemike
open advplugins.php and search for

case 'productexport': page = "plugin.php?do=productexport&productid="; break;
Add below:

case 'tmsdeleteedits': page = "templateedits.php?do=deleteall&productid="; break;
case 'tmstestproduct': page = "templateedits.php?do=test&productid="; break;
case 'tmsexport': page = "templateedits.php?do=files&productid="; break;
Search for

$options['productexport'] = $vbphrase['export'];
Replace with:

if ($vbulletin->products['tms'])
{
$options['productexport'] = $vbphrase['export'] . '<optgroup label="' . $vbphrase[templateedits] . '"><option value="tmstestproduct">' . $vbphrase[test] . '</option><option value="tmsdeleteedits">' . $vbphrase[delete] . '</option><option value="tmsexport">' . $vbphrase[export] . '</option></optgroup>';
}
else
{
$options['productexport'] = $vbphrase['export'];
}

Kind Regards,

Stoebi

Awesome, Thanks bro

slowphantom
08-22-2007, 07:09 PM
neeeeeeeeeed help pls
my database is ++++t up
cant remove or add any products
it keep giveing me
this

https://vborg.vbsupport.ru/showpost.php?p=1318631&postcount=91

come on my forum is stop
pls help

saininja
08-25-2007, 08:23 AM
gibt es diesen HAck auch in german ????

J.

ragtek
08-25-2007, 09:14 AM
gibt es diesen HAck auch in german ????


J.
ja, gibt es!sobald das neue offizielle deutsche hackboard online geht, "bin ich mir sicher"/(wissen kann mans ja nie) das andreas den dort auch wieder reinstellt

Delphiprogrammi
08-27-2007, 03:39 PM
ja, gibt es!sobald das neue offizielle deutsche hackboard online geht, "bin ich mir sicher"/(wissen kann mans ja nie) das andreas den dort auch wieder reinstellt

english only in here :p

Centrix
08-27-2007, 06:21 PM
These days the readme says "in navbar, search:" but for all the templates I had so far it was not found in Navbar, but Header....

I think this mod is good for new people

Elenna
08-28-2007, 03:51 AM
This sounds like a god-send, thanks ever so much!

Just one teeny question... when I do an upgrade, and the templates are not upgraded, would it be best-practice to revert those templates (to get the official updates) and then have TMS do its thing? I'm sure that this is a very newbie question, but I've never done a vBulletin upgrade before, and would love to take this mod through its paces and give an upgrade a try!

AzzidReign
08-28-2007, 02:52 PM
Here's what I've done. I've taken a look at all my template modifications and compared them to the default template. Figure out where the edits go, and add them to TMS, but keep them disabled. If you are doing this for your whole skin, then what I did was copied the skin so that I can have a new and old skin, reverted all the templates on the new, closed the board, enabled all the TMS edits, then checked to see if the edits were working properly on the board. If they are, open your board with the "new" skin as your default and disable the old skin.

Magnumutz
09-01-2007, 09:49 PM
Question: I used TMS to modify the templates for vBCredits... and i was unsatisfied on how it edited, and now i want to delete the modifications on the templates, but it won't remove them. WHAT do i do?

Alfa1
09-02-2007, 12:38 PM
also read readme.txt there is some info that migt become usefull ...
Yes, I emailed andreas to inquire for options to get rid of the branding, but got no reply at all.

ringleader
09-04-2007, 09:04 AM
Question: I used TMS to modify the templates for vBCredits... and i was unsatisfied on how it edited, and now i want to delete the modifications on the templates, but it won't remove them. WHAT do i do?

Revert the template edit in the TMS admin screen.
This will stop the edit set through TMS being carried out.

evesve
09-11-2007, 08:17 PM
Just to let you know, it's working for me with mySQL v4.0.26-standard.

The only thing is I keep getting this error:

Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 1984105 bytes) in [MyPath]/includes/adminfunctions_templateedits.php on line 970

I'll put up with having to come up with workarounds for this to keep this fantastic mod, however!

Andreas,

http://www.minds.nuim.ie/~ringleader/clipart/god.jpg

That error has nothing todo with tms that's caused by your PHP configuration increase your memory limit in php.ini (root access requirerd or you can't do this)

Ah grand so. I'll try that.

It just keeps coming up in relation to TMS, like when adding/editing modifications in certain templates:
Updating Template-Modifications for Stye 'MASTER' and its Child-Styles ...

* MASTER ... (Templateedit-IDs)
Fatal error: Allowed memory size of 8388608 bytes exhausted (tried to allocate 1984105 bytes) in [mypath]/includes/adminfunctions_templateedits.php on line 970



I have same error...only together with TMS.
Fatal error: Allowed memory size of 20971520 bytes exhausted (tried to allocate 24617813 bytes) in /hsphere/local/home/xxxxx/xxxxxx.xx/vbforum/includes/adminfunctions_templateedits.php on line 970
Where can I find how to do? Do I have to contact the Webserver support? (I cant find any php.ini)


If I try yo uninstall TSM what happans to my modification (OK, I have only one, ibproarcade)

Alfa1
09-11-2007, 08:21 PM
Ah, that's where it comes from. I keep getting the same error as well. I never had that before I installed TMS.
I have lots of modifications, lots of members, lots of traffic. So I should have seen this before if it wasn't caused by TMS.

JokeAss
09-14-2007, 05:30 PM
This mod is really a gift from heaven..

Whenever I install a mod, instaed of changing the templates, I make a set of template mods. Upgrades propably go beautifully :)

Totti
09-15-2007, 12:07 PM
hey, this mod is absolute outstanding!! I'm so glad, i found this :)

thincom2000
09-15-2007, 05:54 PM
Yeah, still have a long way to go with adding all my template edits to this so I can finally revert them all.

I used to have that memory error... Forgot what I did to fix it. TMS caused a number of other problems for me as well. I ended up removing most of its plugins, and only keeping the following:

Veraltete Template-Modifikationen suchen
Template-Modifikationen neu erzeugen
Event-Handler: Style aktualisieren
Edits prüfen
Benötigte Felder laden
Event-Handler: Template compilieren

This maintained basic functionality and eliminated the chaos that was occurring in my AdminCP.

evesve
09-16-2007, 10:03 AM
I used to have that memory error... Forgot what I did to fix it.

Please, try to remember!!!
I cant enter my adminside anymore...

Alfa1
09-16-2007, 10:53 AM
This mod sure could use a new release or a total rewrite. The idea is brilliant.

hrk
09-16-2007, 11:00 AM
does this support latest 3.6.8 versions?

Totti
09-16-2007, 03:59 PM
i'm running it on 368 ... looks good

Alfa1
09-16-2007, 04:57 PM
It works on 3.68 but will cause errors now and then. It has branding on it.

Delphiprogrammi
09-16-2007, 05:42 PM
It works on 3.68 but will cause errors now and then. It has branding on it.

i don't understand what the f..... your problem is with branding ? the author has put allot of time and affort into it and he doesn't charge money the only thing he asks is that you leave the branding in place that is not to much to ask after all nobody is forcing you to use it if you don't want it uninstall and stop +++++ing about the branding

ragtek
09-16-2007, 05:59 PM
for 15€ you can delete the branding

Alfa1
09-16-2007, 11:26 PM
The only problem is that the author doesn't respond to my email. I'd be happy to pay the €15.
I do value the time and effort that Andreas has put into this work. Please do not misunderstand me. It's just that I have paid Jelsoft and various other coders combined quite a lot to make my board branding free. So not being able to get rid of branding would indeed be a reason to uninstall a good hack.

Roxie
09-17-2007, 12:13 AM
Works beautifully.

WarLion
09-17-2007, 05:44 AM
this is the best hack ever
install

giovannicosta
09-22-2007, 11:03 AM
I have 3.6.8 and in my admin cp, I get this error: Database error in vBulletin 3.6.8:

Invalid SQL:

SELECT templateid, searchstrregex, replacestr
FROM vb_templateedit AS templateedit
INNER JOIN vb_templateeditlocation AS templateeditlocation ON (templateeditlocation.varname=templateedit.varname )
INNER JOIN vb_template AS template ON (template.title=templateeditlocation.template)
LEFT JOIN vb_style AS style ON (style.styleid=template.styleid AND FIND_IN_SET(templateedit.templateeditid, style.templateeditlist))
LEFT JOIN vb_product AS product ON (product.productid=templateeditlocation.product)
WHERE (NOT ISNULL(style.styleid) OR (templateedit.styleid=-1 AND template.styleid=-1))
AND (product.active=1 OR templateeditlocation.product='vbulletin')
AND templateedit.active = 1

AND template.styleid=-1
ORDER BY searchorder ASC;

MySQL Error : Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (latin1_general_ci,IMPLICIT) for operation '='
Error Number : 1267
Date : Saturday, September 22nd 2007 @ 08:02:49 AM
Script : http://www.computerforumz.org/admincp/templateedits.php?do=test
Referrer : http://www.computerforumz.org/admincp/index.php?do=nav
IP Address : xxxxxxxxxxxxxxx
Username :xxxxxxx

Saint_ago
09-27-2007, 10:08 PM
I have 3.6.8 and in my admin cp, I get this error: Database error in vBulletin 3.6.8:

Invalid SQL:

SELECT templateid, searchstrregex, replacestr
FROM vb_templateedit AS templateedit
INNER JOIN vb_templateeditlocation AS templateeditlocation ON (templateeditlocation.varname=templateedit.varname )
INNER JOIN vb_template AS template ON (template.title=templateeditlocation.template)
LEFT JOIN vb_style AS style ON (style.styleid=template.styleid AND FIND_IN_SET(templateedit.templateeditid, style.templateeditlist))
LEFT JOIN vb_product AS product ON (product.productid=templateeditlocation.product)
WHERE (NOT ISNULL(style.styleid) OR (templateedit.styleid=-1 AND template.styleid=-1))
AND (product.active=1 OR templateeditlocation.product='vbulletin')
AND templateedit.active = 1

AND template.styleid=-1
ORDER BY searchorder ASC;

MySQL Error : Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (latin1_general_ci,IMPLICIT) for operation '='
Error Number : 1267
Date : Saturday, September 22nd 2007 @ 08:02:49 AM
Script : http://www.computerforumz.org/admincp/templateedits.php?do=test
Referrer : http://www.computerforumz.org/admincp/index.php?do=nav
IP Address : xxxxxxxxxxxxxxx
Username :xxxxxxx

Same here! And i can't uninstall!!!!

giovannicosta
09-28-2007, 04:27 PM
My whole admin panel is ruined now and it didn't even work!

Elenna
10-03-2007, 05:40 PM
I'm getting the same 'error' where the GO button doesn't work.

Would anyone mind posting what they did to fix that?

Thanks so much!

Hoffi
10-03-2007, 05:54 PM
Just change the Collation of your Database-Tables that all are the same.

Elenna
10-03-2007, 07:44 PM
As far as I can tell, my collation is the same on all of my tables (latin1_swedish_ci).

Elenna
10-03-2007, 09:29 PM
Try the attached JS file.
I'll also update the package later.

It is now working for me. I used the file, and I also made sure that my admincp is the first tab in my browser (in case that has anything to do with it, but I haven't tested).

Thanks!!

giovannicosta
10-04-2007, 01:40 PM
How do is solve the problem?

edgecutioner
10-05-2007, 09:16 AM
hey Andreas, thanks:)

now having many skins aren't so hard to maintain:D

Webmist
10-09-2007, 01:04 AM
Here's some of edit for products I have installed.

pscyhosis
10-10-2007, 01:45 PM
cannot install.
error msg

XML Error: not well-formed (invalid token) at Line 80

edgecutioner
10-10-2007, 02:25 PM
i'm running it on 368 ... looks good

i'm with you.. i'm running it on 3.6.8 and it's working fine ;)


My whole admin panel is ruined now and it didn't even work!
that's exactly why you should do backups before installing anything :erm:

dvdizaster
10-13-2007, 07:16 AM
i am having a huge problem,
after installing this ( im currently running 3.6.8)
after installing this, i can no longer uninstall TMS nor can i import or upload any products.

i also cannot un install TMS either.. whats wrong with it ? what did i do wrong ?

someone please help, i cant upload or disable products or anythng...

thanks !

dvdizaster
10-13-2007, 07:14 PM
can anyone help me out here ? i have a crippled admincp now !

bazzup
10-13-2007, 07:58 PM
you getting any error messages or anything?

dvdizaster
10-13-2007, 10:28 PM
no i dont have any error messages, the board is working fine, but now my text/link to add/import products is gone now after installing, and i cant uninstall the TMS because it's dropdown options box is gone !

dvdizaster
10-13-2007, 10:45 PM
how can i do a complete un install or a manual un install of this product ? m whole forum is F****** u p now ..

goddess_dix
10-14-2007, 11:05 PM
dvd-do a search at vbullitin.com for disabling plugin system. there is a line of code you can add to your config file to turn off all plugins so if tms is keeping you from getting in, you may be able to after disabling the plugins.

dartho
10-20-2007, 08:27 AM
Great Add-on (in theory - will find out very soon in practice)

One question - what sort of performance hit could one expect with this mod?

Thanks

Andreas
10-20-2007, 10:02 AM
@All those having problems with ACP (style manager, product manager):
I can only assume that it has smth. to do with output buffering.
You can disable the plugins on admin_complete that deal with manipulating the output buffer to avoid this, however you will lose some functionality.
If anyone experiencing those problems wants a real fix, feel free to PM me an ACP login so I can track down this issue, as I am unable to reproduce it locally.

@dartho
There is no single line of code being executed or even loaded in the frontend.
=> No effect on frontend performance at all

dartho
10-20-2007, 10:35 AM
Excellent! Installed a breeze on 3.6.8P1 :up:

giovannicosta
10-25-2007, 01:08 PM
@All those having problems with ACP (style manager, product manager):
I can only assume that it has smth. to do with output buffering.
You can disable the plugins on admin_complete that deal with manipulating the output buffer to avoid this, however you will lose some functionality.
If anyone experiencing those problems wants a real fix, feel free to PM me an ACP login so I can track down this issue, as I am unable to reproduce it locally.

@dartho
There is no single line of code being executed or even loaded in the frontend.
=> No effect on frontend performance at all

CAn you save my admin panel, I cant even email users :(

trigon
10-27-2007, 02:42 PM
works well on 3.6.8 PL1 :)

yoyoyoyo
10-28-2007, 11:58 AM
In addition to "replace" "add above" and "add below" it would be nice to have a "remove code" option - I know that you can get around this by the replace option, but it would be easier to use if there was simply a "remove code" option.

It would also be nice to have an option to globally disable/enable all of the template edits, similar to the one for the plugins.

Thanks again for such a great modification - I sure hope this becomes standard in vbulletin - it is an amazingly helpful modification.

Andreas
10-28-2007, 05:09 PM
@yoyoyoyo
A 'Remove' option is surely possible, but it is the same as replace with nothing :)

You can disable all edits by disabling TMS, you can also disable all edits for a certain product by disabling the product.

@giovannicosta
As stated before, I can't reproduce those problems myself - therefore I am somewhat unable to provide a fix :)
Sorry.
However, feel free to PM me an ACP login and i'll take a look.

2 X Viverridae
10-30-2007, 12:23 PM
Fantastic hack Andreas!

Thanks a bunch.

yoyoyoyo
11-04-2007, 06:14 PM
@yoyoyoyo
A 'Remove' option is surely possible, but it is the same as replace with nothing :)

You can disable all edits by disabling TMS, you can also disable all edits for a certain product by disabling the product.

thanks.

One thing that I would really like to have is a "search all template edits" option, similar to the "search all templates."

yoyoyoyo
11-04-2007, 07:05 PM
also - the reason I want the option to globally disable all of the template modifications at once is to troubleshoot possible troublesome template edits. I would like to have TMS set all template edits to disabled, but keep the plugin active, so I can choose to turn on the template edits one by one to see where the possible conflicts might be. I realize that I can do this on a template-by-template basis, or with phpmyadmin, but it would be nice to have the option to do so inside TMS.

Lionel
11-05-2007, 06:52 PM
Why would the comments display like that? I am trying to add in showthread template, above <if condition="$show['adminoptions']">


<if condition="$show['<!-- Lionel: Add update icon -->modcplink']">
code here
</if>
<<!-- / Lionel: Add update icon -->if condition="$show['adminoptions']">

shouldn't it be

<!-- Lionel: Add update icon --><if condition="$show['modcplink']">
code here
</if>
<!-- / Lionel: Add update icon --> <if condition="$show['adminoptions']">

yoyoyoyo
11-05-2007, 07:49 PM
Lionel -
are you talking about in the modified template view with comments in the regular template editor? I have had it show up like that there, but it does not output code like that.

Andreas
11-07-2007, 05:13 PM
thanks.

One thing that I would really like to have is a "search all template edits" option, similar to the "search all templates."
That has already been requested on vBulletin-Germany.org some time ago and is on the To Do-List :)

@Lionel
Well, adding

<if condition="$show['modcplink']">
code here
</if>


above

<if condition="$show['adminoptions']">


is actually the same as replacing

<if condition="$show['adminoptions']">


with

<if condition="$show['modcplink']">
code here
</if>
<if condition="$show['adminoptions']">

isn't it?

The first difference between the original 1st line

<if condition="$show['adminoptions']">


and the new 1st line

<if condition="$show['modcplink']">


is

modcplink']">


So this is considered as the beginning of the modification.

puertoblack2003
11-08-2007, 08:50 PM
how can i do a complete un install or a manual un install of this product ? m whole forum is F****** u p now ..


for those having problems uninstalling product!

go to >>Plugins & Products>>>plugin manager scroll all the way down to template manger disable all of the hack features, then go back to plugin manager and then uninstall "template manager" and that should work.

pb

Matty.B
11-10-2007, 03:55 AM
Quickly.. Installed And Great with vbCredits! Is there anywhere going to be made available to english speakers to get the xml's? just becuase i have used the translators and i just can't understand how to get signed on to vbhacks-germany .. I get a login screen... I have signed up to vbulletin-germany.org but that username and password don't work...

I really would like the XML's to help with this FANTASTIC mod :D

Links anyone?

Andreas
11-11-2007, 09:59 AM
vbhacks-germany.org does not exist any longer.
The official german modification site is vbulletin-germany.org

If you have problems registering/logging in there just send me a PM with your account name and i'll take a look.

yoyoyoyo
11-11-2007, 10:53 AM
Andreas - another feature request: the ability to download all of the template mods for a site - all template edits for all products - in one single xml file :)

Icy
11-11-2007, 11:29 AM
Andreas is there any chance/way to add customized template support in TMS? If not now then in future release?

yoyoyoyo
11-11-2007, 11:34 AM
Andreas is there any chance/way to add customized template support in TMS? If not now then in future release?that would be awesome! :)

Andreas
11-12-2007, 04:25 PM
Andreas is there any chance/way to add customized template support in TMS? If not now then in future release?
What does "customized template support" mean?

@yoyoyo
Smth. like 'Download Plugins' is already planned.

yoyoyoyo
11-12-2007, 10:53 PM
What does "customized template support" mean?

@yoyoyo
Smth. like 'Download Plugins' is already planned.
cool

"customized template support" refers to templates that are specific to a certain style

Icy
11-13-2007, 06:05 AM
What does "customized template support" mean?
Sorry for the missunderstanding. I recheck & finally understand how it works. In master style I'll find all templates & in normal style I'll find only those templates which has been customized/edited.

Anyway I believe there is a bug. When I enable the TMS I can edit templates but I can't save it because there is no Save or Save & Reload button. If I disable TMS then everything go back to normal. I've attached 2 screenshot. I reproduced the problem both in Firefox & Opera. I have not try Internet Explorer though.

Andreas
11-16-2007, 03:53 PM
@yoyoyo
Erm, TMS works just fine with custom/customized templates?

Do you want to create "virtual" templates, eg. advise TMS to apply modification X to template foo in style Y only, without template foo being customized in style Y?
That is (and most likely never will be) possible: If a template is not customized in a certain style, it does not physically exist - it's just a reference to the inherited template.

@Icy
Sorry, but I can't help you (without an ACP login for you board) as I am unable to reproduce the problem locally.

Icy
11-17-2007, 02:05 PM
@Icy
Sorry, but I can't help you (without an ACP login for you board) as I am unable to reproduce the problem locally.
PM sent

Andreas
11-18-2007, 02:21 PM
@All those having problems with TMS in ACP (Style Manager & Product Manager)
Could you check if the attached plugin fixes the problems?

nyunyu
11-18-2007, 04:19 PM
Sorry, this might not be any useful post as I just wanted to know if this hack can be use in 3.5.4 version of vbulletin?

Thanks

nyunyu
11-18-2007, 05:52 PM
maybe I was dumb...I installed this hack on 3.5.4 and it give me this error

Database error in vBulletin 3.5.4:

Invalid SQL:

### INSERT QUERY GENERATED BY fetch_query_sql() ###
INSERT INTO plugin
(`active`, `executionorder`, `title`, `hookname`, `phpcode`, `product`)
VALUES
('1', '5', 'Event-Handler: Produkt aktivieren/deaktivieren', 'admin_complete', '// Handle enabling/disabling Product \r\nif (($_REQUEST[\'do\'] == \'productenable\' OR $_REQUEST[\'do\'] == \'productdisable\') AND $vbulletin->GPC[\'productid\'] AND $vbulletin->adminloggedin AND can_administer(\'canadminplugins\'))\r\n{\r\n global $product_update;\r\n if (is_array($product_update) AND !empty($product_update))\r\n {\r\n require_once(DIR . \'/includes/adminfunctions_templateedits.php\');\r\n if ($_REQUEST[\'do\'] == \'productenable\' OR !in_array(\'tms\', $product_update))\r\n {\r\n $templates = array();\r\n $templatesq = $vbulletin->db->query_read(\"SELECT template FROM \" . TABLE_PREFIX . \"templateeditlocation WHERE product IN (\'\" . implode(\"\', \'\", $product_update) . \"\') GROUP BY template\");\r\n while ($templateedit = $vbulletin->db->fetch_array($templatesq))\r\n {\r\n $templates[] = $templateedit[\'template\'];\r\n } \r\n }\r\n else\r\n {\r\n define(\'TMSDEACTIVATED\', true);\r\n $templates = \'\';\r\n }\r\n rebuild_template_edits(\'\', $templates);\r\n }\r\n}', 'tms');

MySQL Error : Unknown column 'executionorder' in 'field list'
Error Number : 1054
Date : Monday, November 19th 2007 @ 03:48:36 AM
Script : http://nyunyu.info/animeproject/admincp/plugin.php
Referrer : http://nyunyu.info/animeproject/admincp/plugin.php?do=productadd
IP Address : 121.xxx.xxx.xxx
Username : nyunyu
Classname : vb_database


how to revert back?

dartho
11-18-2007, 10:59 PM
Edit: Confirmed by Andreas that it will not be compatible

you may be able to get it running under 3.5.4 by editing the product-tms.xml file and replace all occurences.

BUT - If there are 3.6.x code dependent hooks, it likely will not work and you may need to disable all plugins so you can then uninstall. AFter looking through all the posts in this thread, there is no menation of people NOT being able to get it working on 3.5.x..... yet
<plugin active="1" executionorder="5">
with
<plugin active="1">
then try and install again?




Otherwise the uninstallation instructions in the readme.txt file are:

Uninstallation
--------------
1) Uninstall product'Template Modification System' in ACP 'Products & Plugins / Manage Products'
2) Delete the following files
- includes/xml/cpnav_tms.xml
- admincp/templateedits.php
- includes/adminfunctions_templateedits.php
- clientscript/tms_templateeditmgr.js
- clientscript/tms_ajax.js
- includes/md5_sums_tms.php


You won't need to do step 1 if the install is failing

Andreas
11-19-2007, 03:36 AM
Due to the fact that there are no "always execute" installation codes (eg. version = *) in vBulletin 3.5.x, you won't be able to get this working properly on 3.5.x.

yoyoyoyo
11-19-2007, 03:53 AM
@yoyoyo
Erm, TMS works just fine with custom/customized templates?

Do you want to create "virtual" templates, eg. advise TMS to apply modification X to template foo in style Y only, without template foo being customized in style Y?
That is (and most likely never will be) possible: If a template is not customized in a certain style, it does not physically exist - it's just a reference to the inherited template.OK - that makes sense - it would be nice to be able to customize modified templates in certain styles, though, but I can see how that would be a problem.

nyunyu
11-19-2007, 11:44 AM
i wish there is someone port it to compatible with 3.5.4.
Anyway, nice hack

Alfa1
11-21-2007, 07:31 PM
Andreas, could you PM me the possibilities to get rid of the branding?

Andreas
11-22-2007, 04:50 PM
readme.txt

Alfa1
11-22-2007, 11:28 PM
Yes, I tried that, but got no response to my email.

Andreas
11-23-2007, 03:44 AM
If the E-Mail that I answered just a few minutes ago (dated october 10th) was yours:
I am sorry. It was stuck in my spam folder.

Icy
12-19-2007, 02:50 PM
I did something terrible. Now I can't remove this addon :( I Pmed you the details Andreas :) Help me when you are free.

TCooper
12-19-2007, 08:59 PM
what about a version for version 3.7.0
not to mention i love this for my 3.6.8 board!

TCooper
12-19-2007, 11:41 PM
really weird thing i did a fresh install for 3.7.0 beta 2 and installed this hack and have an error when you go to admincp/templateedits.php link in the admin area and then i have a test area i did an upgrade from 3.6.8 pl 2 to 3.7.0 beta 2 and dont get the error. why would that be....

KURTZ
12-25-2007, 02:56 PM
is this hack compatible w/3.7.0 beta 3?

AWJunkies
12-25-2007, 03:36 PM
GUYS no offense but nobody is going to support a BETA product until it is completely bug free. BETA IS NOT FOR LIVE SITES!!! So why would someone start working on programing for it when code keeps changing on it to fix bugs. You guys need to calm down and wait for final release of 3.7.0 and everyone most likely will upgrade their mods accordingly.

vgevolution
12-27-2007, 01:06 AM
Is anyone else able to create modifications for the footer template? Mine aren't taking affect at all. Seems to work when I use either Show modified Template or Show commented modified Template from within the Style Manager, but then the changes aren't apply in production. All template mods are active. I'm using vb3.6.8p2, and this is the first time I've tried to modify the footer, so I don't know how long the problem has been occurring. All I'm trying to do is add target="_new" code to the admincp and modcp links.

vgevolution
12-27-2007, 01:10 AM
Is the English version of this mod supposed to have the plugin names and footer credits in German?

Andreas
12-28-2007, 12:09 PM
Yes, they are supposed to be in german.

Modifying the footer should work just fine.

Can you attach the XML that does not work?

Also, this Mod should work just fine with 3.7 as well.

vgevolution
12-28-2007, 05:45 PM
Strange, it seems to be working now. Could template caching be delaying the changes?

Andreas
12-28-2007, 06:00 PM
Depends on how you are 'caching templates' ...

TCE Killa
12-30-2007, 01:46 PM
great mod thanks.

Nacho Love
01-03-2008, 06:49 PM
Hello everyone,

I am currently trying to follow the instructions laid out in the following thread:

http://vbdrupal.org/forum/showthread.php?t=1011

In order to basically make my site look similar to the vbdrupal.org website. My goal is to eventually have my left navigation, header and footer drupal blocks displayed on my forums - giving the appearance that the forum loads within my drupal website.

I have installed the template-modifications manager but have been unsuccessful in getting my changes to take effect. However I am very certain that I am doing something wrong that is likely straightforward for most of you, so can anyone help with my remedial questions? :o

First I get to this screen - which option do I want?

http://www.howibeatpanicandanxiety.com/tool_1.jpg

I've been using the MASTER STYLE one - fyi

Once in there, I grasp the basic concepts here of loading up a template (such as header), however, I don't believe my changes are taking effect. On the following screen ,what exactly do I need to do to make the code changes? I've been making the code appear by clicking 'view template', but from here I'm unsure of what to do to make my code changes take effect. What about naming - does it matter at all? Can anyone please provide step by step instructions on what to do?

http://www.howibeatpanicandanxiety.com/tool_2.jpg

Assuming I make the correct code changes, what are my next steps to apply these changes to my website? (pretend you're talking to an idiot :))

Thanks for the help, and sorry for being such a noob :erm:

goddess_dix
01-04-2008, 03:22 PM
Assuming I make the correct code changes, what are my next steps to apply these changes to my website? (pretend you're talking to an idiot :))

Thanks for the help, and sorry for being such a noob :erm:

after you set up and save your template changes (and have marked them active in your template setup), you must select the "rebuild all template modifications" option to have your site reflect the changes.

the fact it's for a vbdrupal site doesn't impact how tms works...all tms does is store you template edits in a central location, sort of like a parent style, so you can enable or disable them for different skins. basically it's a search/replace hack for your templates....you can also try making the changes directly in the templates to see how it looks and make sure you're getting the edits you want.

i'd put some random text in your edit so when you rebuild the template modifications, you can see easily whether it's taken or not, because if your simply judging by whether or not your vbdrupal content is showing, you might have another issue to resolve not related to tms.

Andreas
01-05-2008, 05:29 AM
You don't have to rebuild all template modifications - rebuildung is being done automatically when necessary.

'Rebuild All Templates' is just for odd cases where automatic rebuilding failed.

Icy
01-05-2008, 06:40 AM
Andreas, can I install this on vB 3.7.0 beta 3? If not then any ETA on releasing TMS for vB 3.7.0? One more question about the tms_debrand, can I run the query rather than installing the product? Or can I install the product then uninstall it? Also is this (https://vborg.vbsupport.ru/showpost.php?p=1298174&postcount=19), this (https://vborg.vbsupport.ru/showpost.php?p=1314430&postcount=85) & this (https://vborg.vbsupport.ru/showpost.php?p=1384949&postcount=165) bugfixes implemented already? Or I have to do this myself?

Andreas
01-05-2008, 08:30 AM
This is TMS for vBulelltin 3.7; unforfunetely I can only set 1 compatible version.

You can't 'install' tms_debrand.xml as the installation process will never complete - it's just to remove the branding.

The bugfixes have been implemented, but there is no ETA for a new version yet.

Icy
01-05-2008, 09:12 AM
Thanks but this (https://vborg.vbsupport.ru/showpost.php?p=1384949&postcount=165) one still not implemented. Should I import the tms-plugin-outputbuffer.xml plugin?

Andreas
01-05-2008, 09:48 AM
Please re-read my last post again ...

I said it's implemented, but there is no ETA for a new version yet.

Icy
01-05-2008, 01:04 PM
Sorry. I thought these three bugfixes have been implemented in current version. Thanks for the reply.

alexgeek
01-17-2008, 08:47 PM
Installed, thanks

KURTZ
01-18-2008, 02:43 PM
i dont understand: is compatible or not with 3.7.0 B3?

Icy
01-18-2008, 03:22 PM
i dont understand: is compatible or not with 3.7.0 B3?
I'm using it on my vB 3.7.0 B3 live forum :)

Hawaiian-TV
01-26-2008, 04:10 AM
I hate to be the rotten apple in your basket but I just installed the TMS, clicked View Template, made some manual modifications to a template on the MASTER style, then clicked Save. Voila' ... the modifications were done on all templates. I was impressed!

I noticed though that the template I modified (which was for another mod) didn't work properly so I uninstalled it via the Product Manager. The templates were all the same of course because I hadn't modified them. Then I went back to the TMS, selected that same template to "Revert" the templates back, and hit the Revert button.

Unfortunately the templates did not revert. Worse yet, I noticed for the first time a notice in German at the bottom of every page on the website that the template had been modified by the TMS system. (it almost brought back memories of Nazi Germany, seeing the site having been defaced by the product). Thank God I did of course save a backup SQL file to undo any damage your product may have caused. Maybe one or more other template mods I installed is conflicting with TMS? All I know is if others are having this same problem I suggest this product be moved temporarily to the Product Graveyard until it is fixed.

By the way, we are using VBulletin version 3.6.8 Patch 2.

Computerman

Andreas
01-26-2008, 12:18 PM
made some manual modifications to a template on the MASTER style, then clicked Save.

You should never ever modify templates in MASTER style (unless they are templates of a product you are deveoping).
Voila' ... the modifications were done on all templates. I was impressed!


I noticed though that the template I modified (which was for another mod) didn't work properly so I uninstalled it via the Product Manager.

You can't 'uninstall' templates vir product manager, only producst?


Unfortunately the templates did not revert.

If you manually modified a template in MASTER style, TMS won't ever revert those changed - as it has nothing to do with the modifications anyway.


Worse yet, I noticed for the first time a notice in German at the bottom of every page on the website that the template had been modified by the TMS system.

It is clearly stated in the readme.txt that TMS puts a branding in the footer.


All I know is if others are having this same problem I suggest this product be moved temporarily to the Product Graveyard until it is fixed.

There is no reason for such action; TMS runs fine on dozens of production sites.

Lionel
01-26-2008, 07:56 PM
There is no reason for such action; TMS runs fine on dozens of production sites.

You are being modest, Andreas, not dozens, HUNDREDS

Hawaiian-TV
01-26-2008, 08:51 PM
You should never ever modify templates in MASTER style (unless they are templates of a product you are deveoping).
Voila' ... the modifications were done on all templates. I was impressed!

I thought that was the point: Modify only the MASTER template manually, and all your other style templates are automatically modified along with that template ... and revertable back with a single button click? At least it would make sense to me that that is the way it would or should work.

You can't 'uninstall' templates vir product manager, only producst?
Yes, I know you can't uninstall templates via the product manager but what I said is that I went to uninstall a "product" (also called "add-ons") that required manual template edits. Those required manual template edits for that product were done on the MASTER template using the TMS system and when I hit the Revert button, they didn't revert, as the button seems to indicate, ... it's very misleading.

If you manually modified a template in MASTER style, TMS won't ever revert those changed - as it has nothing to do with the modifications anyway.What do you MEAN "it has nothing to do with the modifications anyway"? I modified only the MASTER template! .. and TMS then modified all my other templates the way I modified the MASTER template.... so it has EVERYTHING to do with the modifications, "anyway". Then I don't understand the purpose of this product. Please explain again what it does?

It is clearly stated in the readme.txt that TMS puts a branding in the footer.Oops! You're right. It didn't say however that the branding would be in German and also doesn't say this on this Modifications Forum in this thread. Please add it to the sticky description at the top of each page here so people won't miss it.

There is no reason for such action; TMS runs fine on dozens of production sites. Please then also publish a manual for TMS that shows in detail how to use it. I'm very confused about what this product really does (except for making it super easy to ruin all your templates in seconds at the single click of a button and wind up with German footers at the bottom of EVERY PAGE you didn't think you had to read about in the readme.txt file because such things are important enough that you'd expect them to have to be in a LARGE BOLD PRINT "NOTE:" right on the description page). :rolleyes::mad::confused:

All I can say is, this product wasted about 8 hours of my time today because I had to restore a whole database from a couple of days ago because of using this product. Good thing I had backups. CAUTION: IF YOU USE TMS, KEEP BACKUPS OF YOUR SITE... AND WAIT UNTIL FULL DISCLOSURE IS MADE ON THIS PRODUCT ON THE DESCRIPTION PAGE and a MANUAL IS PUBLISHED first on how to use it properly or I still recommend it be retired immediately to the Product Graveyard.

Thanks for the fast response. I hope you fix this soon, if it does what I tried to make it do, I would like to use it! :)

Computerman

Ingress
01-27-2008, 01:15 PM
CAUTION: IF YOU USE TMS, KEEP BACKUPS OF YOUR SITE

Making backups before any such edit is mandatory. Any modification is tested and installed three times until it is finally live on my site:

1. I install it on a local copy and test installation, deinstallation, template edits and so on
2. I install it on a live copy (testforum) and let selected users (usually the staff) test the new functionality and documention I created or adapted thoroughly.
3. I install the mod in my live environment

I don't like my site being a beta-test-area for anything so these steps almost guarantee that nothing will go wrong with my live site as nobody else can and will since you cannot predict how a mod will act on your site with probably some other mods.

From that point of view I can't understand why this mod should go to the mod-graveyard. It's up to the site-admin to prevent problems with his live environment.

Kind regards,

Ingress

Icy
01-27-2008, 02:07 PM
@Hawaiian-TV - Installs: 359! Assuming 300 people are using this (including me) Nobody got any complain against the HOW TO instructions & the modification description but you. The product didn't waste your 8 hours, you did! Never mind but your words sound like more ordering than requesting.

phenom21
02-02-2008, 02:06 AM
can u use this on 3.6.8

dartho
02-02-2008, 10:03 AM
can u use this on 3.6.8

Yes I have it running on a 3.6.8PL2 and 3.7 Beta 4

baz_kingfish
02-05-2008, 02:17 AM
I uploaded all of the respective files and installed your product on vBulletin 3.6.8, and it seemed to install ok. However, when I go into the "Templates Modifications Manager" and select "Add Template Modification" from the drop down list for my "Default Style"... nothing happens! I get a little yellow yeild sign with "page error" in the bottom left corner of my browser...that's it? :confused:

I can and did, however, upload the Welcome Message XML through the "Up/Download Template Modifications" link and that appears to be working correctly in my forum.

Any idea why the "Add Template Modification" function is not working?

Please advise,
KF

baz_kingfish
02-05-2008, 03:10 AM
Try the attached JS file.
I'll also update the package later.

Well, you must not have updated the "package" download yet. I found this fix and implemented it. All seems to be working now, and I successfully made my first manual update. You may want to update the download to save future users the grief of alot of reading through this thread! :(

Thanks,
KF

Andreas
02-05-2008, 08:38 AM
Yes, I know you can't uninstall templates via the product manager but what I said is that I went to uninstall a "product" (also called "add-ons") that required manual template edits.

If you are uninstalling a product that requires manual template modifications, you must manually undo those when you uninstall it.
Template Modifications for a certein product/addon done through TMS should be automatically undone when you uninstall ist

Those required manual template edits for that product were done on the MASTER template using the TMS system

This sounds confusing to me.
As already stated, you should never-ever manually modify MASTER templates!

when I hit the Revert button, they didn't revert, as the button seems to indicate, ... it's very misleading.[/COLOR][/COLOR]
When exactly did you click Revert?

If it was in some style (not MASTER) in Style Manager, the template will revert to the inherited template (which might be the MASTER template or a template customized in a parent style
If it was in MASTER style in Style Manager the template will be deleted (as there is nothing left to revert to)
If it was in some style (not MASTER!) in Template Modifications Manager, the template modification will revert to the inherited template modification (which might be the MASTER template modification or a template modification customized in a parent style
If it was in MASTER style in Template Modifications Manager, the template modification will be deleted (as there is nothing left to revert to)


[quote]Then I don't understand the purpose of this product. Please explain again what it does?
It does modify the templates before the are saved in compiled state.

Please add it to the sticky description at the top of each page here so people won't miss it.
Erledigt.

baz_kingfish
02-05-2008, 12:48 PM
This sounds confusing to me.
As already stated, you should never-ever manually modify MASTER templates!


That being the case, why do you even ALLOW modification of MASTER templates in the TMS system? Furthermore, why does the respective drop down list default to "MASTER". I accidentally made a minor mod to a master template even though I had selected "Add Mod..." in the drop down on the line that said "Default Templates". Somehow, the mod showed up in the TMS on BOTH the MASTER and Default. If it is that big of a deal, you should certainly NOT make the drop downs default to MASTER. Makes no sense...:confused:

Just my 2 cents...
KF

Andreas
02-05-2008, 01:51 PM
You should not manually modify MASTER templates; adding template modifications in TMS to MASTEr style is fine.

baz_kingfish
02-05-2008, 02:10 PM
ahhhh, thanks for the clarification. ;) That makes more sense...glad to know that MASTER mod I accidentally made is of no real consequence.

Sorry for being a DA.
KF

baz_kingfish
02-05-2008, 04:42 PM
I am trying to install NuRatings template mods using the TMS, but when I test a few of them, I get a check mark under test, but nothing under results? Also, when I review the Template code, I do not see the New Ratings mods in the template. Here is an example of the first one that is reacting this way.

Adding NuRatings' Post Ratings to each post in each post shown in the View Thread Page

--------------------------------------------------------------------------------
Product: NuRatings
Template: postbit
Title: Add NR Post Ratings to each post
Variable: addnrpostratingstopost

Search Text: <!-- controls --> which works.

Add BEFORE search text:
<if condition="$show['moderated']">
<td class="alt2" align="$stylevar[right]" style="border-left: 0px; border-top: 0px">
<else />
<td class="alt1" align="$stylevar[right]" style="border-left: 0px; border-top: 0px">
</if>

$post[nu_ratings_postbit]

<!-- controls -->
<if condition="$post['editlink']">

Any ideas? Should the product be set to vBulletin instead of NuRatings given that is where the postbit template resides? I have made other mods successfully using TMS, and do not have enough experience to know why/where/if this one is breaking. Does the fact that I am not getting a check mark unders results when I test mean it is not working?

Also, there are other mods that I need to make to the MEMBERINFO, SHOWTHREAD, navbar, and threadbit templates, but they are not available in the TMS drop down list when "Adding Template Modifications". What am I doing wrong here? :confused:

Any help is appreciated. I don't plan on enabling NuRatings until I can successfully implement the template changes through TMS.
Thanks,
KF

UPDATE: I figured out the other templates noted above need to be modified in the MASTER, so those problems are solved; however, I still can NOT get the above postbit modifications to TEST with a check in the Results field. That is all I lack to be finished...any ideas?
Thanks

Last UPDATE: Found the error -
<!-- controls -->
<if condition="$post['editlink']">
was in the template twice. It is working now...just not displaying the way I would like it to...but that is not a TMS problem. Please disregard my plea for help! :D
Thanks.

|Jordan|
02-06-2008, 08:23 PM
Does this hack add any database queries?

Boofo
02-06-2008, 10:05 PM
Andreas, excellent work, sir. Just what I needed. Thank you very much. ;)

Andreas
02-07-2008, 04:13 AM
Does this hack add any database queries?
There is no code being executend in frontend scripts, only in AdminCP.

rapidphim
02-11-2008, 03:03 AM
question for you... I am trying to install a fresh 3.7.0 beta4. Should I install this hack very first thing with only Default style before I install any other hacks/custom/modified styles?

Andreas
02-11-2008, 04:03 AM
Yes, that would be best.

rapidphim
02-11-2008, 04:11 AM
Thanks. Next, after that, I installed another custom/modified styles:
1/ will it or does it have any effect to Default style?
2/ now, I install another hack that require template edit, should I edit the Default template and it will automatically edit the second style that I just installed?

Andreas
02-11-2008, 05:29 AM
Don't modify any templates nmanually. Instead, take the instructions from the hack and insert them into TMS.

Boofo
02-11-2008, 07:46 AM
Does this actually modify them as you would manually or on the fly like the string replace?

Andreas
02-11-2008, 08:04 AM
It does not modify them as they would be if you were modifying them manually and it does not modify them on the fly ;)

vBulletin keeps two version of the templates in database: The orginal version (that is being used for display and editing in style manager) and a compiled version (that is actually being used for displaying templates in frontend).

TMS hooks into the compile process and changes the templates just before they are being compiled.

This means, that the compiled version is changed, but the template is still considered unchanged - you also won't see changes in style manager.

Boofo
02-11-2008, 08:43 AM
Ok, I see, It basically cuts out the middle man. A deeper version of on the fly, so to speak. ;)

So any template changes I have already made I can undo and just do with all with this. I'm liking this already. Is there any noticeable difference in execution time the more templates you have edited through this? No matter really, as anything to keep from manually editing a template is an upgrade bonus for me. I can remember the day when we would have begged for a template change over a file change. ;)

Nice job, buddy! You outdid yourself on this one. ;)

Andreas
02-11-2008, 08:46 AM
Is there any noticeable difference in execution time the more templates you have edited through this?

There is zero code being executed in frontend (eg. no performacne cost at all).
TMS code is only executed in ACP.

Boofo
02-11-2008, 09:00 AM
You sold me. Where do I sign up? ;)

Last question... will this hack be smart enough to catch template that change between version? Or is that something you have to keep on eye on your end? Knowing you I'm sure there is a built in safe-guard of some sort for dummies like me.

And this would be great to see in a future version of vb. ;)

Andreas
02-11-2008, 09:07 AM
When you upgrade vBulletin, TMS will detect this and check if templates for which you have made template modifications have been changed.

If this is the case, a message will appear on ACP home telling you that templates have been changed and that it is necessary to test if the modifications are still working.

When clicking the link, TMS will test and update those modifications that do still work.

Those modifications that do not work any longer (doesn't happen too often) will need manual adjustments.

Boofo
02-11-2008, 09:24 AM
Aha! You've been caught! You did have dummy Boofo in mind when you wrote this. ;)

For a hack that is not supposed to be supported, you are doing one hell of a job, my friend. Thanks for taking the time to answer all my questions, as simple as some of them must sound. As always, you continue to amaze me with the stuff you come up with. I'd install it twice if I could. Thank you, sir. And nice to see you hanging around the old farmstead. Looking forward to your next invention. ;)

rapidphim
02-11-2008, 01:09 PM
Don't modify any templates nmanually. Instead, take the instructions from the hack and insert them into TMS.
Should I also need to modify the Default template or just the custom/modify template that I just installed and leave the Default template untouch?

Andreas
02-11-2008, 01:15 PM
?
Sorry, I don't understant your question :)
Just take the hack instructions and insert tihe modifications into TMS and you're done (assuming the modifications do work in all styles).

rapidphim
02-11-2008, 01:56 PM
Let see:
1/ I am now having Default style (fresh, no hack yet) with brand new DB, forum (Master Template #1)
2/ I installed TMS
3/ Then, I will try to install another style (custom/modified... whatever it called) 2nd template (no children from master)
4/ Then, I will try to apply a hack for my forum that required template hack. Here, the question I am seaking for answer is that:
a/ Do I need to edit the Master(default) template by using tms and it will auto apply those edits to the 2nd template?
b/ Or, I leave the master template alone, and just edit the 2nd template by using TMS?
c/ what happen if I install 3rd template after all the template edits were done on the 2nd by using TMS? Will the 3rd template will auto adjust/fix with all the edits on the 2nd? Remember that I do not want to have any parent/child style.

Thanks so much for your help.

Andreas
02-11-2008, 03:17 PM
Add your TMS modifications in MASTER style - they will affect child syles.
(In fact, it isn't even possible to add modifications in child styles if the template isn't customized there)

rapidphim
02-11-2008, 03:40 PM
sorry for my stupidity... that means that I will have to edit the master template (default), and other template will be effected automatically?

Andreas
02-11-2008, 03:44 PM
Once again:
Do not manually modify MASTER templates - never-ever!

Just go to Styles & Templates / Templates Modifications Manager, select Add Template Modification from the dropdown in MASTER style and fill out the form.

Repeat this for all your modifications and you're done (unless your do have customized templates where the modifications defined for MASTER templates do not work).
In this case you will have to customize the template modifications as well.

rapidphim
02-11-2008, 04:46 PM
Yes of course I will not manually edit the master template but if I used the tms to do the editing, will all of other styles be edited automatically?

rapidphim
02-12-2008, 01:51 PM
Once again:
Do not manually modify MASTER templates - never-ever!

Just go to Styles & Templates / Templates Modifications Manager, select Add Template Modification from the dropdown in MASTER style and fill out the form.

Repeat this for all your modifications and you're done (unless your do have customized templates where the modifications defined for MASTER templates do not work).
In this case you will have to customize the template modifications as well.
Andreas,
I am testing this on 3.7.0 b4 but nothing happened when I select Add Template Modification in the Master style from the dropdown menu?

JokeAss
03-03-2008, 11:55 AM
Too bad this won't be updated...

Will it work with 3.7?

Icy
03-03-2008, 12:54 PM
This works fine for me on vBulletin 3.7 beta 5 :)

Black Tiger
03-03-2008, 11:40 PM
I have this one tagged for some time.
Now I wanted to install this, but I had to uninstall it for the time being.
I'm running vBulletin 3.7 beta 5, but when clicking on "Template modifications Manager" I get a java erro saying:
Line: 120
Sign: 55
Error: Id is expected
and the url points to /admincp/templateedits.php.

Same goes when clicking on "add template modification" but then the error is:
Line: 74
Sign: 1
Error: Object is expected
Code: 0
Same url.

I'm working with IE6 fully fixed and updated from Microsoft Update.

With Firefox portable all is going OK, but I'm working with IE6 and not interested in using Firefox. Is it possible to fix this?

Icy
03-04-2008, 01:44 AM
Try the fix (https://vborg.vbsupport.ru/showpost.php?p=1298174&postcount=19)

Black Tiger
03-06-2008, 01:49 AM
Thanks for the fix Icy, it's working great.
Marked as installed again!
But now a couple of questions rise. I presume all new template edits should be made now in the new "Master" style?

1.) How about template edits already made by hacks which were installed before installing TMS. Can this be integrated in TMS globally some way?
Or do I have to do them all manually piece by piece, so reverting first, and then putting them back in via the TMS system?

2.) When upgrading vbulletin, often templates need to be reverted. How does this work with upgrading vBulletin? Do I still have to do all template changes of the reverted templates again, or does this system "remember" the changes somehow and is able to put them back after the reverting?

3.) I would like the notice "Template modifikationen durch" changed in "Template modifications by", so from German to English, were can I do that?

Icy
03-06-2008, 03:27 AM
If you add a new template modification to Master style then it will inherit all the styles. So you don't have to add template modification to any other styles.

1. As far as I'm concern, you will have to do everything manually.

2. The TMS will test & show a stat if any of the template modification need to be changed/reverted. It works like vBulletin's "Find Updated Template" option.

3. You can't. The only option you have is that buy a branding free.

Black Tiger
03-06-2008, 02:01 PM
Thanks for your quick answers Icy!

1.) Oke I was afraid of that.:)
2.) I just implemented some new edits, the test is not done automatically, you have to use the test function after implenting indeed, but that works nice.
3.) There must be a way because it get's implemented some way. Branding free is for removing the notice. I don't want it removed I only want it displayed in English.

Thanks again for your quick support.

Icy
03-06-2008, 02:49 PM
Thanks for your quick answers Icy!.
You're most welcome :)
2.) I just implemented some new edits, the test is not done automatically, you have to use the test function after implenting indeed, but that works nice.
When you upgrade your vBulletin the TMS will automatically test all the modifications & show the status on your admin control panel index like the vBulletin's updated template function does.
3.) There must be a way because it get's implemented some way. Branding free is for removing the notice. I don't want it removed I only want it displayed in English.
As far as I'm concern somewhere in this thread Andreas mentioned the copyright will stay in German language. However you can wait for Andreas's confirmation.

Black Tiger
03-06-2008, 03:17 PM
Oke, otherwise I could pm Andrea.

Now I've got another problem. I just logged in to my ACP and see a notice that wasn't there before it has this headline:
Help !!! Out-of-date Template-Modifications found !!!
And this is the content of the notice:
There are 1 Template-Modifications that were not desinged for the currently installed vBulletin version. To make sure that vBulletin and your installed Products are working correctly, you must check and maybe modify those Template-Modifications.

Test Template-Modifications
But when I use the test function (it's clickable in this notice) all 3 template edit i made so far has a "v" in the circle, meaning they are ok.

So now I don't know what the problem is. Nore why it's giving this notice.

I could try and disable them one by one to see which one is giving the problem, but I wonder why this notice was not given yesterday after I implemented them.

Or could this notice appear because I'm using vb 3.7.0 beta 5 and TMS is not recognizing things?

Icy
03-06-2008, 03:39 PM
Try another fix (https://vborg.vbsupport.ru/showpost.php?p=1314430&postcount=85) :p

Black Tiger
03-06-2008, 03:44 PM
Oh LoL, I should start using the search function in this mod I see.;)
Happened because I'm used to it at vb.org that if fixes are made, they are included in the distribution package by the coder.
Thanks again Icy!

Lionel
03-09-2008, 05:14 PM
Hello, are there any known issues with the go button not working on a Mac G5 with Safari?

dancue
03-22-2008, 04:22 PM
Can you believe I just asked for this same exact type of mod in general discussions?!?!

Great mod!!

Edit.....

I have the same problem with the go button on safari. I'm using a macbook pro.

dancue
03-22-2008, 04:41 PM
I downloaded FF and it worked on that. I guess I will just have to use that.

dancue
03-22-2008, 07:13 PM
Okay, Okay...

This IS the greatest mod ever!! It SHOULD come standard on vBulletin!!!

My only suggestion would be to put together some instructions, maybe examples of how to use the product. I must admit, even after reading the faq, and the instructions I was still a bit intimidated, and then scared to "mess things up" after reading the 17 pages here.

A video tutorial would be nice. This Mod is worth the time to make one...I just don't know how.

If someone could do that it would save Andreas time so he may continue working on his wonderful mods!!

*clicked install
*nominated for MOTM

dancue
03-22-2008, 07:18 PM
Also, a quick question....

I added a template-modification to the master style, which worked great for me because it added it to all the other styles automatically. ( I do not have child styles)

Now, if I add a new style, will it automatically add the template-modifications to that style?