Collapsable First Post using AJAX (or Last Post!)

[magnus]

-NOTICE: This is for vBulletin v3.6 ONLY. You can find a v3.5 compatible version here (https://vborg.vbsupport.ru/showthread.php?t=145812).
-
*** Confirmed working on ALL vBulletin 3.6.x versions! ***

-
Keywords: FORUMDISPLAY, search, results, collapse, AJAX, collapsable, first, last, unread, post

Description:
Allows you to expand/collapse the first, last or first unread post of a thread from FORUMDISPLAY and search results without the need to load the entire thread.

Details:
Upon perusing the wonderful deals over at slickdeals.net (http://www.slickdeals.net), I noticed this nifty feature which caught my eye. I found it quite useful as most people have a bad habit of not being very descriptive with their thread titles. This little trick made my browsing experience much more enjoyable, so naturally I had to borrow [read: shamelessly rip] the idea.

Please note that no additional queries are added, unless using the 'First Unread Post' option. Otherwise, the only queries performed are the same as those when a thread is normally viewed.

The magic behind this modification is performed by jQuery: The Write Less, Do More, JavaScript Library (http://jquery.com/).

-
Usage:
Simply click the expand icon [+] in front of the thread title to expand, and the collapse icon [-] to collapse. Rocket science, eh?

-
Installation:

Download and unzip the ajax_first_post.zip archive.
Upload necessary files to their respective locations. (Attention custom style users! Be sure to upload the images to your custom image directory.)
Import the product-ajax_first_post.xml via the Product Manager.
Make any desired configuration changes via AdminCP > vBulletin Options > Collapsable First Post using AJAX
???
Profit!


Notes:
All template modifications are made automatically. They attach to pretty common text locations, so modified styles shouldn't* be a problem.

However, for those who wish (or need) to perform the edits manually, you can find that information here (https://vborg.vbsupport.ru/showpost.php?p=1230578&postcount=5).

-
Comments:
As with all my hacks, this modification is provided free of charge. However, if you find this product useful and have money burning a hole in your pocket, feel free to make a small donation (https://www.paypal.com/cgi-bin/webscr?cmd=_xclick&business=magn2o%40comcast%2enet&no_shipping=0&no_note=1&tax=0&currency_code=USD&lc=US&bn=PP%2dDonationsBF&charset=UTF%2d8), I won't mind.. really. :)

Version History:

1.0.0 - Initial release, here's to hoping...
1.1.0

Fixed JavaScript errors when using search.
Resolved (known) cross browser compatibility issues.

1.2.0

New AdminCP configuration options:

Ability to select first or last post to be displayed.
Ability to disable on a per forum basis.
Option to update thread views when expanded.
Option to disable automatic template editing with a single click.

Tweaked a couple plugins to prevent unnecessary checking.
Properly registers in Who's Online

1.2.1

Will no longer show expand icon next to thread redirects.
Added ability to display first unread post.
Completely revamped the automatic template editing system. Should now be able to make template edits to even the most modified templates as well.
Fixed a couple non-breaking typos.
Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.
Added a hover title to the expand icon to inform the user what they can expect when clicking it.



-
Tips, Tricks and Modifications:

Fix for users of passiveVid receiving Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(296) : eval()'d code on line [#] (https://vborg.vbsupport.ru/showpost.php?p=1442948&postcount=493)



Currently Known Bugs:

None


* Please note that this modification was developed on a forum with a userbase of 1 (myself). I've tested it for basic functionality but I cannot guarantee functionality or behavior on your forum. So, please -- make backups before installing this product!

[aveon]

wow man nice hack thanx for this i just love ajax

[KevNJ]

will be installing this when i get home. awesome mod!

[4x4 Mecca]

<a href="http://www.4x4mecca.com/forum/forumdisplay.php?f=36" target="_blank">http://www.4x4mecca.com/forum/forumdisplay.php?f=36</a>
I get an error message when I try. The plus sign is there, but what I see is "There was an error. Please try again."

[magnus]

For those who have problems with the automatic template edits, or who just like to do things the hard way, here are the template edits required:

First, disable the automatic template edits:

Browse to AdminCP > vBulletin Options > Collapsable First Post Using AJAX Options
Select No for Enable Automatic Template Editing


Now perform the following template edits:

In FORUMDISPLAY -

FIND:

$headinclude


ADD AFTER:

<script type="text/javascript" src="clientscript/jquery.js"></script>
<script type="text/javascript" src="clientscript/vbulletin_vbpost.js"></script>



-
In search_results -

FIND:

$headinclude


ADD AFTER:

<script type="text/javascript" src="clientscript/jquery.js"></script>
<script type="text/javascript" src="clientscript/vbulletin_vbpost.js"></script>



-
[CHANGED IN 1.2] In threadbit -

FIND: (should be the first line)

<tr>


REPLACE WITH:

<tr<if condition="empty($ajax_firstpost_excluded) || !in_array($forumid, $ajax_firstpost_excluded)"> <if condition="$vbulletin->options['ajax_firstpost_firstlast']">id="vbpostrow_$thread[lastpostid]"<else />id="vbpostrow_$thread[firstpostid]"</if></if>>



FIND:

$thread[title_editable]
<div>


ADD AFTER:

<if condition="empty($ajax_firstpost_excluded) || !in_array($forumid, $ajax_firstpost_excluded)"><img id="vbpostimg_<if condition="$vbulletin->options['ajax_firstpost_firstlast']">$thread[lastpostid]<else />$thread[firstpostid]</if>" src="$stylevar[imgdir_button]/expand.gif" onclick="return vbpost_get(<if condition="$vbulletin->options['ajax_firstpost_firstlast']">$thread[lastpostid]<else />$thread[firstpostid]</if>)" onMouseOver="this.style.cursor='pointer';" /></if>

[magnus]

http://www.4x4mecca.com/forum/forumdisplay.php?f=36
I get an error message when I try. The plus sign is there, but what I see is "There was an error. Please try again."

Hrm.. that error appears when the script is unable to pull data. However, I tested the backend on your site and it seems to be working: http://www.4x4mecca.com/forum/vbpost_ajax.php?postid=12979

Let me nose around a bit.

[magnus]

@4x4 Mecca:

Redownload the archive (https://vborg.vbsupport.ru/attachment.php?attachmentid=63325&d=1176923304) and upload/overwrite your existing vbpost_ajax.php with the new one. Let me know if that fixes it.

[4x4 Mecca]

Thanks! I just edited the teplates manually just incase that was the problem. It still isn't working.

[4x4 Mecca]

Error is still there. Any idea what might be interfering?

[Lionel]

http://www.4x4mecca.com/forum/forumdisplay.php?f=36
I get an error message when I try. The plus sign is there, but what I see is "There was an error. Please try again."

same for me

[magnus]

Ok, I removed the download link for a second while I try and track this down. My apologies.

[4x4 Mecca]

I have a few (read maybe a lot) hacks installed, but I don't know which one could be messing with it. Anyone else recreate this on their own site?

[ninjamaster]

THANKS M8 nice work :)

[Lionel]

this is also giving a javascript error in newposts

[magnus]

Wait, you get an error when trying to write a new post? I don't see how this could affect that. What's the error?

[Lionel]

no i get the error like the poster above me and also in do=getnew

[4x4 Mecca]

I didn't get an error when making a new post or new reply.

[Lionel]

and also in do=getdaily

[Lionel]

where is the new file ?

[4x4 Mecca]

uploaded

[4x4 Mecca]

Still not working, and errors on get new posts too.

[Lionel]

sorry, nothing changed

[magnus]

Do me a favor, check to see if you have a vbpost_postbit template..

[4x4 Mecca]

Yes, I do.

[Lionel]

I do

[magnus]

This is odd.. for some reason or another, it's not being displayed. I installed a fresh vB and imported this product and it worked fine. There has to be a hack conflict somewhere.

[4x4 Mecca]

Is there any way another mod could be creating this problem?

[sensimilla]

Nice addon, great job!

[bitdefuser]

Question.
When a user hits the (+), does it add to the thread view count? Because I don't see it adding in your screenshots.

[magnus]

Question.
When a user hits the (+), does it add to the thread view count? Because I don't see it happening in your screenshots.

No.

[bitdefuser]

Hm, can you please add an option that allows that?

[4x4 Mecca]

done, uploaded again.

[Lionel]

still the same for me

[4x4 Mecca]

still errors :(

[magnus]

This is so hard to do remotely.. lol.

[Lionel]

I am using vbseo if that means something

[magnus]

I developed this on a forum using vBSEO. That shouldn't be a problem.

[Lionel]

the image code I had to add manually in templates because of vbplaza

[magnus]

Ok, upload this file. This isn't going to fix it, it's to give me more information. I'm going to need you to delete it as soon as I'm done.

[Lionel]

after giving the alert, the image ajaxsmall.gif still displays and i must refresh to stop it

[magnus]

Also, I see 10 installs. Has anyone gotten this working? I need to know if this is a global problem or something confined to these 2 reports (so far).

[Lionel]

still the same with new file

[magnus]

4x4 Mecca, Ok. Delete the file.

Y'know, this could get lengthy. Do you have an AIM screename? :P

[Lionel]

i got msn

[bitdefuser]

Hm, can you please add an option that allows that?
:p Can you?

[Lionel]

die(print_r($post)); the debugging did not do anything. So the error must be before

[magnus]

Lionel, you need to access it directly. http://yoursite/vbpost_ajax.php?postid=[some post id]

[Lionel]

blank page

[magnus]

Apparently, you and 4x4 Mecca have different problems because I got output from him.

[4x4 Mecca]

You got output with the initial file, once I kept updating it, it no longer gave me output

[Lionel]

here is mine (http://www.haitiwebs.com/forums/vbpost_ajax.php?postid=38160)

and here (http://www.haitiwebs.com/forums/evolution-culinaire/)

[Lionel]

i deleted the file with the debugging and was using the one before

[Lionel]

I got output with the debugging LOADED LOADED

[magnus]

Are either of you using any plugin or template caches?

[Lionel]

not me. No cache plugin

[Lionel]

i am on mysql 5.0.2 and php 5.16

[WhaLberg]

Nice work, rated 'Excellent'. :)

[Lionel]

If some people got it to work, all that's left for me to think is my version of mysql

[magnus]

If vBulletin is working, it's not your MySQL version. This uses a normal vBulletin MySQL query.

[Lionel]

past that line

if ($vbulletin->GPC['ajax'])

it stops echoing whatever i put as test

[magnus]

Yea, that's what I'm running into w/ 4x4. We're working on it.

[bitdefuser]

Hm, can you please add an option that allows that?
Sorry but, can you please add an option that allows that?

EDIT: Suggestion: Also, the on the AJAX thread, put an option at the top "View full thread"

[magnus]

We've found a resolution. Standby for an update.

[magnus]

Sorry but, can you please add an option that allows that?

EDIT: Suggestion: Also, the on the AJAX thread, put an option at the top "View full thread"

I'll add it to the list. Thanks.

[magnus]

Ok, hack updated. Download and install as normal, if you're upgrading choose to overwrite.

[Lionel]

thanks... Is it supposed to display entire post?
I am still getting javascript error on getdaily and getnewpost

[magnus]

thanks... Is it supposed to display entire post?
I am still getting javascript error on getdaily and getnewpost

It's supposed to display the entire FIRST post, yes.

I'm aware of the errors, and I'll be fixing them in a bit. It should just be a matter of including the javascript on those pages. Right now, it's only included on FORUMDISPLAY.

[Lionel]

I did put the javascript in the searchresults. That takes care of javascript but does not display the post, even though i manually added the other code. So I did an if condition==forumdisplay so image displays only in forum display

[rjmjr69]

I get this error at the top of any page and the buttons do not work they appear but do nothing
script type="text/javascript" src="clientscript/jquery.js">

I got it forgot a <

Works just dandy now.

3.6.5

Using the PHP thats in the main folder not the forum folder the other one wouldnt work

WOW I love this!!!!! MOTM for sure

[Mr Chad]

ohh man this is great!

[magnus]

I get this error at the top of any page and the buttons do not work they appear but do nothing
script type="text/javascript" src="clientscript/jquery.js">

What's the error? Did you do the template edits manually, or automatically?

If you did them automatically, then follow my instructions on the first page to do them manually.

If you did them manually, you forgot a "<"

[rjmjr69]

What's the error? Did you do the template edits manually, or automatically?

If you did them automatically, then follow my instructions on the first page to do them manually.

If you did them manually, you forgot a "<"


Your right I forgot a <

Thank you so much this rocks........ Clicked MOTM


One little request. When A user is viewing a thread and Looking at Whos online shows an unknown location


This also does not work well with Thread Cosmetics hack On display of the thread it displays the Code for whatever decoration is applied..., I.E thread title is bold <strong> etc

[Hornstar]

wow. this is going to be a very popular mod ^^ nice work.

[magnus]

Update:
v1.1.0

Fixed JavaScript errors when using search.
Resolved (known) cross browser compatibility issues.


-
Thanks to 4x4 Mecca for help in working out a few kinks. There are additional template edits, so if you performed manual edits you'll want to re-check this post (https://vborg.vbsupport.ru/showpost.php?p=1230578&postcount=5).

Otherwise, just import and overwrite as usual.

[rjmjr69]

So for us that did manual edits Add the new search_post edit PLUS re import and overwrite?

[magnus]

@ rjmjr69:
Glad you got it working. Although, I don't see how this would affect Who's Online -- as you haven't actually left FORUMHOME. I'll look into it, though.

I'll also check into the cosmetics hack.

@ hornstar1337:
Thanks! :)

[magnus]

So for us that did manual edits Add the new search_post edit PLUS re import and overwrite?

You can get away with not overwriting the php/js files, but you'll need to re-import and perform the template edits. (Be sure to disable the automatic template edits after re-importing)

[rjmjr69]

You can get away with not overwriting the php/js files, but you'll need to re-import and perform the template edits. (Be sure to disable the automatic template edits after re-importing)


That worked just fine.

Here is a snap shot of what I am talking about for WOL. The username appears Its just I was using FF and my username blinks but it does appear

https://vborg.vbsupport.ru/


And here is what happens with the thread decorations

https://vborg.vbsupport.ru/external/2007/04/11.jpg

[Stoebi]

Hi,

great hack magnus. Thank you very much :)
I've only problems with vb codes boxes (attached).


Regards, Stoebi

[magnus]

That worked just fine.

Here is a snap shot of what I am talking about for WOL. The username appears Its just I was using FF and my username blinks but it does appear

http://i101.photobucket.com/albums/m75/rjmjr69/WOL.jpg
This should be an easy fix. I'll add it to the list.

And here is what happens with the thread decorations

https://vborg.vbsupport.ru/external/2007/04/11.jpg
Hrm. That looks like a template editing typo in threadbit, IMHO. This hack doesn't modify thread titles (or prefixes) -- if you recall, all that was done was the adding of an <img /> tag.

If you've checked and can't find any typos, copy and paste your threadbit template into a .txt file so I can take a look at it.

[rjmjr69]

This should be an easy fix. I'll add it to the list.


Hrm. That looks like a template editing typo in threadbit, IMHO. This hack doesn't modify thread titles (or prefixes) -- if you recall, all that was done was the adding of an <img /> tag.

If you've checked and can't find any typos, copy and paste your threadbit template into a .txt file so I can take a look at it.

Thank you for fixing this issue.
. I love this hack I can't tell you enough times This thing ROCKS.... I wish I could vote more than once for MOTM.................

[Alien]

Very nice job on this.. Thanks!

/me nominates.

[rjmjr69]

Thanks for the support the problem was found and fixed in minutes By MAGNUS... Your the man thank you very much............. Great work

[Cybertims]

can it be set to show last post instead of first post? cheers

[rjmjr69]

can it be set to show last post instead of first post? cheers
Better yet how about FIRST AND LAST? That would be the coolest

[magnus]

Yea, it could be set to lastpost pretty easily. In fact, I'll make it a toggle for the next release.

In the meantime, simply edit the threadbit template and replace all instances of $thread[firstpostid] with $thread[lastpostid] -- that'll do it. :P

[rjmjr69]

So would it be possible to display both? The first and last post? That would make it real easy to check out a post....... IMO

[rjmjr69]

Yea, it could be set to lastpost pretty easily. In fact, I'll make it a toggle for the next release.

In the meantime, simply edit the threadbit template and replace all instances of $thread[firstpostid] with $thread[lastpostid] -- that'll do it. :P


I have three instances of this in my template one being at the very top of the template should I also change that one?

[Bad Bunny]

Looks awesome! Good work.

[apdcanari]

Hello,

3.5 please ?

Good hack :up:

Thanks,

C?dric ;)

[Get Shorty]

Awesome. I'll be keeping an eye on this and installing after it has more testing. :)

[dbirosel]

How does this perform query wise? Will this add heavy load to my server? How many queries does it add?

[VaaKo]

I did everything as you instructed but still I can't see the plus sign in forumdisplay.

[VaaKo]

Nevermind, it worked!

/me clicks install!

[taxick]

This Hack rocks :)

Thx - This is the best hack for long time :)

Installed

Nominate for MOTM

[TheMilkCarton]

Works great!!

Should definitely be Nominated for MOTM. :)

I'm guessing there are no options to configure? I would like to see a "Forum Exclude" in the future, so that you could block certain forums from using this. The First/Last post toggle also sounds like a good idea.. or maybe somehow display +/- toggles for both? :) I guess that could be really server intensive though..

Since this is in Beta I'll try my best to test it out. I haven't had any problems yet.

[magnus]

How does this perform query wise? Will this add heavy load to my server? How many queries does it add?

It doesn't "add" any queries. The only queries are when someone clicks to expand thread, the same query that is run if someone was to click the thread anyway.

Works great!!

Should definitely be Nominated for MOTM.

I'm guessing there are no options to configure? I would like to see a "Forum Exclude" in the future, so that you could block certain forums from using this. The First/Last post toggle also sounds like a good idea.. or maybe somehow display +/- toggles for both? I guess that could be really server intensive though..

Since this is in Beta I'll try my best to test it out. I haven't had any problems yet.

I like the idea of an exclusion list, I'll add that. Thanks. :)

Also, it's not really in Beta. I always enable "Beta status" for my hacks, because I'm always tinkering. Once I stop updating the modifications, I remove the Beta status. :)

[magnus]

Update:
1.2.0

New AdminCP configuration options:

Ability to select first or last post to be displayed.
Ability to disable on a per forum basis.
Option to update thread views when expanded.
Option to disable automatic template editing with a single click.

Tweaked a couple plugins to prevent unnecessary checking.


-
Template edits have changed! If you're not using automatic template edits, please review the changes in this post (https://vborg.vbsupport.ru/showpost.php?p=1230578&postcount=5).

DO NOT DISABLE TEMPLATE EDITING BY DISABLING PLUGINS! THIS METHOD IS NO LONGER EFFECTIVE! USE THE NEW ADMINCP OPTION!

Otherwise, just import and overwrite as usual.

[magnus]

only thread message version (1.2.0) :)

?? Huh?

[dbirosel]

?? Huh?
I'm assuming he has removed the avatar, title and signature and only provided the post message when someone expands.

[magnus]

Ah. :p

[Lionel]

Can it also update the number of unread posts for user once you click on it?

[dbirosel]

Can it also update the number of unread posts for user once you click on it?
I think i see what your saying here. Since you viewed the thread, it shouldn't be seen in the "New Posts" area right?

[Lionel]

I think i see what your saying here. Since you viewed the thread, it shouldn't be seen in the "New Posts" area right?

That's correct.

[Strike3ForumsMH]

Very cool hack here. One question though and I apologize if this has been addressed, but is there anyway for it to call for the style's postbit when displaying the first or last post? Or if not that, where could I go to modify what it displays by default?

Thanks for the release magnus.

[magnus]

Very cool hack here. One question though and I apologize if this has been addressed, but is there anyway for it to call for the style's postbit when displaying the first or last post? Or if not that, where could I go to modify what it displays by default?

Thanks for the release magnus.

Edit the template vbpost_postbit to look however you like.

[anywares]

Truly a work of art


[read: shamelessly rip]


LOL!!

*Clicked install

[ragtek]

it would be very nice if i could have the first AND the last posting:)

[magnus]

it would be very nice if i could have the first AND the last posting:)

it wouldn't be impossible, but how would you like it displayed?

[ragtek]

hmm one icon with a 1(first:D ) and the + maybe?

[apdcanari]

3.5 please :confused:

[YLP1]

This may be a dumb question but if you have a protected forum (for say admins only), does this mod use the forum's permissions or could someone who would not have permission to see a forum or view topics within a forum be able to use this mod to view posts in hidden or protected forum?

Thanks in advance.

[aggiefan]

i really like this mod and dont know if its possible to do this or not but i think it would be even more useful if a basic quick reply was added in so you dont even have to click on the thread to respond.

[dbirosel]

Here's a demo. woot!


http://www.caraudiojunkyard.com/forum/cajunkyard-introductions/

[dbirosel]

Suggestion: In some way, have a button or link that says Reply?

[YLP1]

I was thinking this wasn't working but realized that it appears on the forum display and not on the index (forum list page). I mean DUH! I can be ditz sometimes.

I never use the forumdisplay to look at posts, I always click on the last post icon on the index page. Is there a way to add this nifty feature to the forum list page?

Thanks in advance.

[dbirosel]

I was thinking this wasn't working but realized that it appears on the forum display and not on the index (forum list page). I mean DUH! I can be ditz sometimes.

I never use the forumdisplay to look at posts, I always click on the last post icon on the index page. Is there a way to add this nifty feature to the forum list page?

Thanks in advance.
That would be sweet to have this mod on the forumhome. Where when they click the expand, it will show the latest 5 threads?

[YLP1]

That would be sweet to have this mod on the forumhome. Where when they click the expand, it will show the latest 5 threads?
Oh yessssss indeed! I have been looking for a mod to display like the last 5 or 6 threads! This is definitely on my wish list!!! I could see this mod easily taking the MOTM!


One other question, how do I change the font style of the expanded post to use the small font style as designated by the style?

[magnus]

You can define how the posts looks, add a reply button and the like simply by editing the vbpost_postbit template.

[dbirosel]

You can define how the posts looks, add a reply button and the like simply by editing the vbpost_postbit template.
Yea thanks, but some of us here don't know much about coding or designing. It would be great if you can have that as a new addition. At least a reply button or link, that will quote there message.

[dbirosel]

I'll be adding it regardless, but don't you think adding a reply button would be a good addition to your product anyway? :)

I'm also trying to figure out how to make this product more obvious, without being annoying. I don't think anyone has the slightest clue I added this product, and an announcement or post about it wouldn't do much good. haha
What i did was mass PM everyone about it and directing them to this tutorial:

http://www.caraudiojunkyard.com/forum/how-use-our-forums/1031-there-easier-way-viewing-thread.html

[TheMilkCarton]

I had another idea about adding an "Exclude Usergroups" option. Not sure if you'll like it as much as my "Exclude Forums" idea, but I thought I'd suggest it anyway. :)

I just thought that this might get pretty server-intensive if all guests can use it, so I'd like to make it an incentive to sign up! And that's another thing, dbirosel, I can't PM guests to tell them about it, so I might as well just not let them use it. :)

[dbirosel]

I had another idea about adding an "Exclude Usergroups" option. Not sure if you'll like it as much as my "Exclude Forums" idea, but I thought I'd suggest it anyway. :)

I just thought that this might get pretty server-intensive if all guests can use it, so I'd like to make it an incentive to sign up! And that's another thing, dbirosel, I can't PM guests to tell them about it, so I might as well just not let them use it. :)
Earlier in this thread, that this can't be server-intensive. He said it should run, just like how it should when regularly viewing a thread.

[Slave]

Wonderful hack, thank you!

A few suggestions ..

"View next/previous post in thread" links .. perhaps just << and >> links to enable a whole thread to be read from the forumdisplay page :)

Quote/reply buttons .. which would take you to the advanced post page

Ability to edit the number of posts to show in Admin CP .. so instead of just one, perhaps 2 or 3 etc ..

Ability to pick "First unread post" in the Admin CP as well as "First post" and "Last Post" ..

Edit button (if poster) .. yes I want the world!! :D

[magnus]

Ability to pick "First unread post" in the Admin CP as well as "First post" and "Last Post" ..
I really like this idea.

Not to devalue your other ideas, but those have all already been mentioned and are being considered.. but the one above, that's gold. Thanks! :)

[4x4 Mecca]

I've edited the postbit just to show the user name, and nothing else on the left, changed the column width, and made attachments not show up, rather a message saying to view the thread to see attachments. Also there is an edit button and a reply button
http://www.4x4mecca.com/forum/forumdisplay.php?f=36

Magnus, if you want this removed, I'll do it, just PM me :)

<table id="post$post[postid]" cellpadding="10" cellspacing="0" border="0" width="100%" align="center">
<tr valign="top">
<td class="alt2" width="64">

<div id="postmenu_$post[postid]">
<if condition="$show['profile']">
<a class="smallfont" href="member.php?$session[sessionurl]u=$post[userid]">$post[musername]</a>
<script type="text/javascript"> vbmenu_register("postmenu_$post[postid]", true); </script>
<else />
$post[musername]
</if>
</div>
</td>
<if condition="$show['moderated']">
<td class="alt2" id="td_post_$post[postid]" style="border-right: $stylevar[cellspacing]px solid $stylevar[tborder_bgcolor]">
<else />
<td class="alt1" id="td_post_$post[postid]" style="border-right: $stylevar[cellspacing]px solid $stylevar[tborder_bgcolor]">
</if>



<!-- message -->
<div id="post_message_$post[postid]">$post[message]</div>
<!-- / message -->

<if condition="$show['attachments']">
_______________<p>
<b>*** Please View Thread for Attachments ***</b>
</if>

</div>
<!-- / attachments -->
</if>

<if condition="$show['postedited']">
<!-- edit note -->
<div class="smallfont"> <hr size="1" style="color:$stylevar[tborder_bgcolor]" />
<em>
<phrase 1="$post[edit_username]" 2="$post[edit_date]" 3="$post[edit_time]">$vbphrase[last_edited_by_x_on_y_at_z]</phrase>.
<if condition="$post['edit_reason']">$vbphrase[reason]: $post[edit_reason]</if>
</em>
</div>
<!-- / edit note -->
</if>
<!-- controls -->

<if condition="$post['editlink']">
<img style="display: none" id="progress_$postid" src="$stylevar[imgdir_misc]/progress.gif" alt="$vbphrase[loading_editor_please_wait]" />

<a href="$post[editlink]" name="vB::QuickEdit::$post[postid]">
<img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
</if>

<if condition="$post['replylink']">
<a href="$post[replylink]" rel="nofollow"><img src="$stylevar[imgdir_button]/reply_small.gif" alt="$vbphrase[reply_with_quote]" border="0" /></a>
</if>

<if condition="$show['quickreply'] AND !$show['threadedmode']">
<a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<!-- / controls -->

</td>
</tr>
</table>

<!-- post $post[postid] popup menu -->
<div class="vbmenu_popup" id="postmenu_$post[postid]_menu" style="display:none">
<table cellpadding="4" cellspacing="1" border="0">
<tr>
<td class="thead">$post[username]</td>
</tr>
<if condition="$show['profile']">
<tr><td class="vbmenu_option"><a href="member.php?$session[sessionurl]u=$post[userid]">$vbphrase[view_public_profile]</a></td></tr>
</if>
<if condition="$show['pmlink']">
<tr><td class="vbmenu_option"><a href="private.php?$session[sessionurl]do=newpm&amp;u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[send_private_message_to_x]</phrase></a></td></tr>
</if>
<if condition="$show['emaillink']">
<tr><td class="vbmenu_option"><a href="sendmessage.php?$session[sessionurl]do=mailmember&amp;u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[send_email_to_x]</phrase></a></td></tr>
</if>
<if condition="$show['homepage']">
<tr><td class="vbmenu_option"><a href="$post[homepage]"><phrase 1="$post[username]">$vbphrase[visit_xs_homepage]</phrase></a></td></tr>
</if>
<if condition="$show['search']">
<tr><td class="vbmenu_option"><a href="search.php?$session[sessionurl]do=finduser&amp;u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[find_more_posts_by_x]</phrase></a></td></tr>
</if>
<if condition="$post['userid'] AND $show['member']">
<tr><td class="vbmenu_option"><a href="profile.php?$session[sessionurl]do=addlist&amp;userlist=buddy&amp;u=$post[userid]"><phrase 1="$post[username]">$vbphrase[add_x_to_buddy_list]</phrase></a></td></tr>
</if>
</table>
</div>
<!-- / post $post[postid] popup menu -->

[dbirosel]

how do you add a reply button?

[magnus]

Magnus, if you want this removed, I'll do it, just PM me :)

I'd never ask you (or anyone) to not provide any customizations. That's the whole point of vBulletin.org -- to share ideas. By all means, share whatever you think anyone could benefit from.

As a sidenote, you no longer need to include <!-- vbpost ok --> at the top of your templates. I've phased that check out in 1.2. :)

[magnus]

how do you add a reply button?

Just view your original postbit_legacy template, find the reply button block of code, cut and paste. :)

The vbpost_postbit template is nothing more than a copy/paste of the default postbit_legacy with a few visual modifications. In fact, you could just cut and paste the entire default postbit_legacy into vbpost_postbit if you so desired.

[StuntFactoryX]

ive been watching this for a few days. in the early posts there were reports of alot of database errors and i seen you guys working hard to sort out the bugs. the current version close to stable and bug free?

[4x4 Mecca]

I was doing that, and I replaced my default postbit legacy! lol, big error, I fixed it most of the way, but it was pretty customized. Thanks again for the mod magnus.

[magnus]

ive been watching this for a few days. in the early posts there were reports of alot of database errors and i seen you guys working hard to sort out the bugs. the current version close to stable and bug free?
No bugs reported.

[dbirosel]

No bugs reported.
x2, it's running stable over at our forums.

[Coders Shack]

when making the manual edits i get:
The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected '\"', expecting T_STRING or T_VARIABLE or T_NUM_STRING in /var/www/vhosts/site.com/httpdocs/forum/includes/adminfunctions_template.php(3596) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

when i add these two:<tr <if condition="!in_array($forumid, $ajax_firstpost_excluded)">id="vbpostrow_$thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>]"</if>> <if condition="!in_array($forumid, $ajax_firstpost_excluded)"><img id="vbpostimg_$thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>]" src="$stylevar[imgdir_button]/expand.gif" onclick="return vbpost_get($thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>])" onMouseOver="this.style.cursor='pointer';" /></if>

[magnus]

when making the manual edits i get:

Did you disable Automatic Template Edits in the Collapsable First Post using AJAX Options from the AdminCP?

[Coders Shack]

Did you disable Automatic Template Edits in the Collapsable First Post using AJAX Options from the AdminCP?
yes

[TheBlackPoet]

this is tight baby!!! good job..... rated excellent!!

[dbirosel]

Since we viewed the thread by expanding the thread. Can we have the newpost icon removed to show that we already read it? Same for the newpost icon on the forum home? Also, removing the thread from the New Posts page.

[Coders Shack]

ok was still unable to make the manual edits so i found a way to get the replacements to work.

also the only thing this is missing i a way to make a reply straight from the forumdisplay :D

[rjmjr69]

when making the manual edits i get:
The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected '\"', expecting T_STRING or T_VARIABLE or T_NUM_STRING in /var/www/vhosts/site.com/httpdocs/forum/includes/adminfunctions_template.php(3596) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

when i add these two:<tr <if condition="!in_array($forumid, $ajax_firstpost_excluded)">id="vbpostrow_$thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>]"</if>> <if condition="!in_array($forumid, $ajax_firstpost_excluded)"><img id="vbpostimg_$thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>]" src="$stylevar[imgdir_button]/expand.gif" onclick="return vbpost_get($thread[<if condition="$vbulletin->options['ajax_firstpost_firstlast']">lastpostid<else />firstpostid</if>])" onMouseOver="this.style.cursor='pointer';" /></if>

I'm getting this same exact problem after upgrading. I shut down the autotemplate edit as I had to the first time too. Any idea?

Is that the portion of the code that updates the post view amount? If not this feature is not working for me.

[magnus]

when making the manual edits i get:
I'm getting this same exact problem after upgrading. I shut down the autotemplate edit as I had to the first time too. Any idea?

My apologies, that was my fault. I've updated the template edits with new, tested, conditionals. That's what I get for not testing. Sorry!

[rjmjr69]

My apologies, that was my fault. I've updated the template edits with new, tested, conditionals. That's what I get for not testing. Sorry!

Still does not work Now I get errors on both lines


Can you look and see if you can figure it out please...
63427

[magnus]

@rjmjr69:
Attached is your modified threadbit. I pasted this over my own threadbit and it tested fine.

[rjmjr69]

Even with your edit I get these errors still

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 15

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

[magnus]

Did you upload the new files and overwrite the old ones? (as well as reimport the new product xml and disable automatic template edits via the AdminCP)

[TheMilkCarton]

This is probably impossible, or at least really hard, but I thought I'd suggest it anyway.

In addition to allowing us to select among First post, Last post, or First Unread (if you add this to a later update), what about a "User Selectable" option which would then put the "First, Last, or First Unread" options in everyone's UserCP options. Another admin at my site suggested it, so don't blame me. :) I think it's a good idea, but maybe not worth the effort to the developer.

And here I am suggesting really hard things, and I haven't even gotten around to adding a "Reply" button to this mod. :)

[magnus]

In addition to allowing us to select among First post, Last post, or First Unread (if you add this to a later update), what about a "User Selectable" option which would then put the "First, Last, or First Unread" options in everyone's UserCP options. Another admin at my site suggested it, so don't blame me. :) I think it's a good idea, but maybe not worth the effort to the developer.

Too late. Already working on it. :)

This was my original plan, I just wanted to get the backend solid first.

[TheMilkCarton]

Nice!! Great minds think alike. hahah. :rolleyes:

[dbirosel]

Woot!! I can't wait for the next update. This mod has a lot of potential to become MOTM

[apdcanari]

Hello,

3.5 please ? I speak french.

Thanks,

C?dric:rolleyes:

[magnus]

Hello,

3.5 please ? I speak french.

Thanks,

C?dric:rolleyes:

This hack is for 3.6. I haven't tested it on 3.5, but I don't see why it wouldn't work.

It would take 5 minutes for you to try it.

[rayw]

Fantastic work magnus, thank you very much. Working fine on my forum. :) Rated excellent and hanging out for the next version.

Cheers!

[akulion]

nice
I also got the template edit errors


The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 14

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


but it still seems to work...so ill just say "if it works dont touch it lol

[BobbyBig]

Holy... that makes me want to have sex with you :)
Nominated.
Thanks.

[magnus]

nice
I also got the template edit errors


The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 14

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


but it still seems to work...so ill just say "if it works dont touch it lol

Did you perform the template edits manually, or were they automatic? If they were manual, did you perform them BEFORE you imported the product or after? Are you using 3.6.5?

I'd like to try and track this down, since I can't seem to replicate it and this is the third report. It seems to be scattered, some people get an errors -- other's don't. There has to be a common link somewhere..

[rayw]

Just found a little problem I think.

If you move a thread to a different forum leaving a redirect, the redirect appears with a + next to it still but when you click on it, it doesn't open anything. You just get that little icon spinning in circles over and over again.

Is it possible to remove the plus from the redirect or fix it so that it will still display the contents. Doesn't bother me really but I thought I would make you aware of it.

Cheers! :)

[rjmjr69]

Still having issues. Do you happen to have the original template edits you had posted?

[magnus]

Still having issues. Do you happen to have the original template edits you had posted?

What's the issues? When do you receive the error?

[magnus]

Just found a little problem I think.

If you move a thread to a different forum leaving a redirect, the redirect appears with a + next to it still but when you click on it, it doesn't open anything. You just get that little icon spinning in circles over and over again.

Is it possible to remove the plus from the redirect or fix it so that it will still display the contents. Doesn't bother me really but I thought I would make you aware of it.

Cheers! :)


Noted. Thanks.

[rjmjr69]

What's the issues? When do you receive the error?


The original issue. You sent me a redone template that still does not work. I get those errors trying to alter it.

[JimmDaBimm]

Ajax ftw->installed

Thank you ^^

[magnus]

To anyone experiencing the conditional errors when evaluating the templates, please try the following.

In your AdminCP > vBulletin Options > Collapsable First Post using AJAX Options:

Set the Forum Exclusion List to 0 (zero).

Now, resubmit the template modifications and see if you still receive the error. I'm trying to track down what would be causing this error for some of you, but I can't seem to replicate it on my development forum unfortunately.

This is what's holding up the next release, as I'd like to have this resolved before I put another version out there.

Thanks!

[magnus]

Update:
1.2.1 BETA : PRIVATE BETA. NOT RELEASED.

Will no longer show expand icon next to thread redirects.
Added ability to display first unread post.
Completely revamped the automatic template editing system. Should now be able to make template edits to even the most modified templates as well.
Fixed a couple non-breaking typos.
Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.
Added a hover title to the expand icon to inform the user what they can expect when clicking it.

THIS VERSION IS NOT AVAILABLE FOR PUBLIC DOWNLOAD!
-
I NEED TESTERS!

While this isn't a major revision, it hopefully addresses the few sporatic issues a few users have been reporting. I'm hoping the alleviate the need to manually edit templates with my revamped automatic template editing system. I will not be releasing any new features until these problems are resolved!

The pre-requisites for testers are as follows: Previous automatic template edits did not work for you.
(optional) You receive a conditional error when applying template edits manually.

If you meet any of the above criteria and wish to lend a hand, let me know. Thanks!

THIS VERSION IS NOT AVAILABLE FOR PUBLIC DOWNLOAD!

[Tralala]

Just installed this... working great. (Tested on Safari.)

Awesome work... thanks, magnus!

A few issues/suggestions:

I see the expand/collapse button appears next to Subscribed Threads in the User CP. But the button doesn't work. If at all possible, could it be made to work? And if not, is there a way to remove the button from appearing next to those threads in the User CP? Since the button doesn't work, after all.

I'd love to see some more options in AdminCP, like the ability to turn off avatars in the expanded post. That'd be a lot easier than manually going in and editing vbpost_postbit.

I'd also like to see an option for the button to only appear next to new/unread threads, and not others. And when the button is clicked, that the status (of the very first post, at least, or whatever post is being displayed) gets marked as "read."

[magnus]

I see the expand/collapse button appears next to Subscribed Threads in the User CP. But the button doesn't work. If at all possible, could it be made to work? And if not, is there a way to remove the button from appearing next to those threads in the User CP? Since the button doesn't work, after all.
Good catch, easy fix. Thanks!

I'd love to see some more options in AdminCP, like the ability to turn off avatars in the expanded post. That'd be a lot easier than manually going in and editing vbpost_postbit.
Hrm. Personally, I feel this is unneeded because editing the template is so simple. However, it seems the majority of people here want specific template modifications (ie. quote, reply, edit) so this may be a way to please everyone.

I'll see what I can do.

I'd also like to see an option for the button to only appear next to new/unread threads, and not others. And when the button is clicked, that the status (of the very first post, at least, or whatever post is being displayed) gets marked as "read."
This is similar to something that was brought up previously that I've been working on. vBulletin provides the following functions:

mark_thread_read();
mark_forum_read();

There's no specific way to mark a POST as read, so unless you want the entire THREAD marked as read, I don't really see a way to do this without basically adding an new post database table to tracking the read status of each post.

What I have done, though, is added the ability to select "First Unread Post" to be displayed. So, when clicked the user will see the first unread post since their last visit. There's also an option in the AdminCP now to Mark Thread as Read when this post is viewed. So, it's configurable to that extent.

[Tralala]

That sounds great, magnus. Thanks so much for your reply and consideration! Looking forward to your updates.

In the meantime I have gone in and tweaked vbpost_postbit to my liking. Mainly just simplifying it, removing the extras I didn't think this needed (location, post count, user title, etc.) Looking great.

Another minor request. When hovering over the button, right now I am seeing the default/standard thread preview popup. (Same as if I'd hover over the thread title itself.) I think it would make more sense if the popup said this instead:

"Click here to see the _x_ post"

(where x = "first," or "last," or "first unread," depending on the Admin CP or User CP settings for this hack.)

So users can better understand what's going on with this new feature.

[magnus]

Another minor request. When hovering over the button, right now I am seeing the default/standard thread preview popup. (Same as if I'd hover over the thread title itself.) I think it would make more sense if the popup said this instead:

"Click here to see the _x_ post"

(where x = "first," or "last," or "first unread," depending on the Admin CP or User CP settings for this hack.)

So users can better understand what's going on with this new feature.
Good idea. Just added that real quick. :up:

[ragtek]

hrhr
waiting vor update*g*

[rjmjr69]

To anyone experiencing the conditional errors when evaluating the templates, please try the following.

In your AdminCP > vBulletin Options > Collapsable First Post using AJAX Options:

Set the Forum Exclusion List to 0 (zero).

Now, resubmit the template modifications and see if you still receive the error. I'm trying to track down what would be causing this error for some of you, but I can't seem to replicate it on my development forum unfortunately.

This is what's holding up the next release, as I'd like to have this resolved before I put another version out there.

Thanks!

Still getting these errors when setting forum to 0

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 15

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


I would be willing to do your beta for you seeing how I am one of the people having this issue

[magnus]

Still getting these errors when setting forum to 0

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/adminfunctions_template.php(3596) : eval()'d code on line 15

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


I would be willing to do your beta for you seeing how I am one of the people having this issue

Great! I'll send you a copy via PM. Also, before installing the beta -- try the attached threadbit. See if that resolves the errors.

[rjmjr69]

Great! I'll send you a copy via PM. Also, before installing the beta -- try the attached threadbit. See if that resolves the errors.


Ok that template now works fine but it still does not update the post count.

[magnus]

Post count? What post count? I'm glad the errors are gone, but could you try the Forum Exclusion List and tell me if it's actually working now? Just put any active Forum ID and see if the expand/collapse icons still display.

[rjmjr69]

I'm sorry the THREAD VIEW count is not moving. The beta installed without a hitch. Still no thread view count going up but it did install without any issues and is working.

Thanks

[magnus]

So far so good. We should be ready for a release soon. Yay! :p

[magnus]

Ok, for those receiving errors when modifying the templates manually. See the original post (https://vborg.vbsupport.ru/showpost.php?p=1230578&postcount=5) for updated template modifications. The only modifications were to the threadbit template. Nothing else has changed.

[Slave]

If a thread is also a poll, how about having an option of either showing the poll or posts? .. maybe make it so clicking the poll icon shows the poll?

Have a think :)

[apdcanari]

This hack is for 3.6. I haven't tested it on 3.5, but I don't see why it wouldn't work.

It would take 5 minutes for you to try it.

Ouip, but doesn't work in 3.5 (queries).

C?dric :rolleyes:

[magnus]

Ouip, but doesn't work in 3.5 (queries).

C?dric :rolleyes:

Good to know. I've released a vB3.5 compatible version. You can find it here (https://vborg.vbsupport.ru/showthread.php?t=145812).

[Domski]

Nevermind me.... i put the images in the ~/images/buttons folder and not the ~/images/MY TEMPLATE/buttons

[Mark.B]

Nice work.

One thing I've noticed, is that the vB drop down menu that should pop up when you click on the username, only works in Firefox and not IE...in IE it just takes you to the full profile page.

I've tried copying the original code from postbit_lagacy and it still doesn't work.

Anyone know why this is?

[magnus]

Nice work.

One thing I've noticed, is that the vB drop down menu that should pop up when you click on the username, only works in Firefox and not IE...in IE it just takes you to the full profile page.

I've tried copying the original code from postbit_lagacy and it still doesn't work.

Anyone know why this is?

Nice find. I just verified it on my setup, too. I'll take a look at it.

[Mark.B]

I'm also finding that the exclude forums feature isn't working, I have used manual template edits but I can't get that to work. The admin panel stores the forum IDs but the feature still operates in those forums.

[GrendelKhan{TSU]

AWESOME!!

installed. working great 3.6.0



FYI: couldn't do the automatic though...didn't work. I think its because if you vbplaza has slight change in the div tag for:

$thread[title_editable]
<div>


(that's the only difference I noticed)

[GrendelKhan{TSU]

ps. any chance for a vbadvanced cmps module? :)

[subnet_rx]

great hack, waiting for 1.2.1 to come out.

[magnus]

I'm also finding that the exclude forums feature isn't working, I have used manual template edits but I can't get that to work. The admin panel stores the forum IDs but the feature still operates in those forums.

Yea, I was worried about that. It works fine with the automatic template edits, but for some reason the array isn't being passed when using manual edits. The next release should allow you to successfully use the automatic template edits, which in turn, will allow the forum exclusion to work correctly as well.

I think I can probably get 1.2.1 out today.

[magnus]

AWESOME!!

installed. working great 3.6.0



FYI: couldn't do the automatic though...didn't work. I think its because if you vbplaza has slight change in the div tag for:

$thread[title_editable]
<div>


(that's the only difference I noticed)


Yea, rjmjr69 uses vBPlaza and he beta tested v1.2.1. The automatic template edits are working for him now. :)

[magnus]

ps. any chance for a vbadvanced cmps module? :)

I don't understand, what would a module of this do for vBA CMPS?

[magnus]

Update:
1.2.1

Will no longer show expand icon next to thread redirects.
Added ability to display first unread post.
Completely revamped the automatic template editing system. Should now be able to make template edits to even the most modified templates as well.
Fixed a couple non-breaking typos.
Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.
Added a hover title to the expand icon to inform the user what they can expect when clicking it.


-
I would seriously suggest removing any manual template edits you may have performed for the previous versions (except modified vbpost_postbit templates). This new version employs advanced automatic template editing logic which should have absolutely no problem performing the edits to modified templates, except in the most rare circumstances (note: I've yet to find one).

To upgrade, simply overwrite the existing files and import the product as usual.

[TTG]

Updated to 1.2.1 and now have two ajax icons alongside latest posts ?

[category]

clicks install also is there anything that can make the user column where they put avator smaller and all their info thinner

[magnus]

Updated to 1.2.1 and now have two ajax icons alongside latest posts ?

You didn't remove the manual template edits. Look for expand.gif in your threadbit template, and remove that line.

[magnus]

clicks install also is there anything that can make the user column where they put avator smaller and all their info thinner

You can edit the vbpost_postbit template to look however you like.

[Mark.B]

Couple of points I have found on the new release which I hope are helpful. (I am now on automatic template edits)

1) I can't seem to make it go to the first unread post, it still does the first post in the thread for me.

2) Although excluding certain forums works in forumdisplay, it doesn't work in search_results.

3) Guests viewing thread lists that do not have rights to view posts still get the icon, but when they click the icon it just gives the "loading" gif permanently. With manual edits I was able to fix this using a simple template conditional, however with auto-edits it's going to need something in the plugin code. Again would be better if the icon was hidden.

[magnus]

Couple of points I have found on the new release which I hope are helpful. (I am now on automatic template edits)

[QUOTE]1) I can't seem to make it go to the first unread post, it still does the first post in the thread for me.
Are you sure there's a post in the thread marked as unread? It's weird that it would go to the first post because if you have 'First Unread Post' set and there is no unread posts, it defaults to the Last Post.

I'll look at it.

2) Although excluding certain forums works in forumdisplay, it doesn't work in search_results.
This is known, I'm trying to find a way to filter search results through the exclusion filter.

3) Guests viewing thread lists that do not have rights to view posts still get the icon, but when they click the icon it just gives the "loading" gif permanently. With manual edits I was able to fix this using a simple template conditional, however with auto-edits it's going to need something in the plugin code. Again would be better if the icon was hidden.
Never thought about that. Easy fix. I'll take care of it.

[Mark.B]

Are you sure there's a post in the thread marked as unread? It's weird that it would go to the first post because if you have 'First Unread Post' set and there is no unread posts, it defaults to the Last Post.


Yes, I've done quite extensive testing with it.

As it happens, I cannot make it do "last post" either, it always does first post no matter what the admin cp setting.

[Mark.B]

Aha...got it.

It works in forumdisplay but not in search_results.

In search_results it always goes to the first post regardless of the admin setting.

[Mark.B]

A small tweak that is really very minor but neatens things up a bit.....

Adding:

class=\"inlineimg\"

into the automatic template code for threadbit where the image is displayed will make the image line up neatly with any "view first unread" default vB images that may be next to it.

[magnus]

Aha...got it.

It works in forumdisplay but not in search_results.

In search_results it always goes to the first post regardless of the admin setting.

Yes, this is correct. By design, it will always return the first post in search_results. The information available in FORUMDISPLAY isn't necessarily availble in the search_results query. It's not that it can't be done, I'm just trying to keep the modification as evasive as possible when it comes to query manipulation.

I haven't written off the idea, I just won't release it until I know for certain it won't cause any future hiccups. :p

[magnus]

A small tweak that is really very minor but neatens things up a bit.....

Adding:

class=\"inlineimg\"

into the automatic template code for threadbit where the image is displayed will make the image line up neatly with any "view first unread" default vB images that may be next to it.

Good idea, thanks.

[glorify]

You can edit the vbpost_postbit template to look however you like.

Is that for legacy as well?

[magnus]

Is that for legacy as well?
There is no vbpost_postbit_legacy. There is only 1 template. You design it to look however you like. I opted to release it looking like the normal 'legacy' template.

[rayw]

Upgraded to 1.2.1 and everything appears to be working great.

Thanks a lot for this. :)

[Slave]

Installed 1.2.1 .. seems to be working :) (I've always used auto templates)

I've now got it set to show the first unread post .. but I notice that when you've already read the thread and you have no new posts it still says "Click here to read the first unread post" any chance of having that as "Click here to read the last post"? .. and when a post is showing to have it say "Click here to close this post" .. It would just make it a bit cleaner :)

Any luck with the forward/back links for the post? (to show the next post without having to go into the thread) .. or are you expecting us to add that ourselves?

Not sure you saw my idea about polls as you didn't respond? .. thanks :)

[subnet_rx]

What does this mod do to views? Are views still accurately recorded when a post is viewed using this addon?

[magnus]

What does this mod do to views? Are views still accurately recorded when a post is viewed using this addon?
It's a toggle in the AdminCP. You can either have it track views or not.

[magnus]

Installed 1.2.1 .. seems to be working :) (I've always used auto templates)

I've now got it set to show the first unread post .. but I notice that when you've already read the thread and you have no new posts it still says "Click here to read the first unread post" any chance of having that as "Click here to read the last post"? .. and when a post is showing to have it say "Click here to close this post" .. It would just make it a bit cleaner :)

Any luck with the forward/back links for the post? (to show the next post without having to go into the thread) .. or are you expecting us to add that ourselves?

Not sure you saw my idea about polls as you didn't respond? .. thanks :)

The forward/back links will be a bit tricky, I'll put it under the future development category.

Polls, I'll take a look at.

I'll also make appropriate changes to the hover text in the next release. :)

[blastup]

i got some problems.. when i click on the expand button.. it don't show anything.. i double click it.. it could now edit.. the threads title.. that is some wierd bug.. check out http://blastup.com/forumdisplay.php?f=11 help would be appreciated. thanx

[ragtek]

i like your hack very much

now i have added a toolbox to the link so the 1. post(saved in the link title tag) is shown on mouseover
the last is shown with your hack

its realy fine

[magnus]

i got some problems.. when i click on the expand button.. it don't show anything.. i double click it.. it could now edit.. the threads title.. that is some wierd bug.. check out http://blastup.com/forumdisplay.php?f=11 help would be appreciated. thanx

I visited your link, but apparently the hack is not loaded. The problems are you describing are indicative of not loading the JavaScript.

Verify the following:

That vbulletin_vbpost.js and jquery.js both reside in your clientscript directory.
That Automatic Template Editing is enable in the AdminCP.
That the JavaScript(s) are being properly loaded. Click on a forum, select "View Source" and search for the above JavaScript files.

[blastup]

yea it was the same thing before.. .. i don't know what is wrong... i checked everthing .. everthing is uploaded. js are in the source.. help?

[beduino]

Hi,
first of all: tks for your work and support here.

And ... the 'mystery' ;)
I install your lovely hack and don't work - apparently... I read the first posts and begin a manual edition in templates. Nothing happens. Then ... i resolve see in other set of templates [called 'vB Brasil New'] and already work.

Then i see the location of images [ (+).gif etc ] and make the correct upload.
And the mystery begun ...

http://www.vb-brasil.org/mystery.gif

I can't ripped out the duplicate images!!! I look in my edited templates and is fine [no php duplicated]...

How can i solve this mystery???? :D

All the best
And tks again
Beduino
www.vb-brasil.org
skin VB BRASIL
[vB Brasil New is ok...]

[magnus]

You have duplicated images because you've applied manual edits without disabling the automatic ones. In essence, you're editing the templates TWICE.

You need to pick one or the other. I'd recommend the automatic edits.

[blastup]

so how should i fix mine? should i do manuel edits?

[magnus]

so how should i fix mine? should i do manuel edits?
No, all of your edits are performed correctly. The JavaScript just isn't being loaded. I'd attribute it to a problem with your style.

Do you still have the Default Style? Try it. If it works, then you know the problem lies with your modified style. Run it through the W3C XHTML Validator (http://validator.w3.org/). Fix as many problems as you can and see if that helps.

[beduino]

Hi Magnus,
works fine - i re-done all mods in templates and the mystery ... you solved.
Tks a lot
Beduino

[LockeAG]

I found a BUG.....

It's a really strange behavior, when I active the Plugin , USERGROUPS that I add have this problem when trying to access to their CP.

Fatal error: Call to undefined function: fetch_coventry() in /hsphere/local/home/#/#/Forum/usercp.php(500) : eval()'d code on line 16

The normal USERGROUPS (7,6,5,4,3,2,1) have no problems.

See'a

[ragtek]

i have a problem

in the forumdisplay it works fine(i have set up to read the last post) but in the search i see the first

[magnus]

I found a BUG.....

It's a really strange behavior, when I active the Plugin , USERGROUPS that I add have this problem when trying to access to their CP.

Fatal error: Call to undefined function: fetch_coventry() in /hsphere/local/home/#/#/Forum/usercp.php(500) : eval()'d code on line 16

The normal USERGROUPS (7,6,5,4,3,2,1) have no problems.

See'a

I've tested this on my development forum. I created a new usergroup (ID: 9) based off standard "Registered Users" permissions. I cannot replicate this problem. Everything appears to be working fine.

As a test, try using the default style. See if you still receive the error. The function fetch_coventry() is found in /includes/functions_bigthree.php -- and I've hooked into the usercp to include it. So, I can't see why one usergroup could use it and another cannot.

[magnus]

i have a problem

in the forumdisplay it works fine(i have set up to read the last post) but in the search i see the first

This is by design.

Search results will always return the first post. I have it this way for temporary simplicity. Search doesn't use the same SQL queries as FORUMDISPLAY -- so the same information isn't available without adding extra queries. Until I can find a cleaner, saner way to allow for different post viewing configurations on the search page, I've defaulted it to First Post.

[ragtek]

alright
thx 4 info

[LockeAG]

Ok , Curiously , I Optimize and Repair Tables and all is working like charm, I would like to understand the problem but , Whatever , everything is working ok.

Thanks Magnus!

[@ngel]

This is by design.

Search results will always return the first post. I have it this way for temporary simplicity. Search doesn't use the same SQL queries as FORUMDISPLAY -- so the same information isn't available without adding extra queries. Until I can find a cleaner, saner way to allow for different post viewing configurations on the search page, I've defaulted it to First Post.

How can it be defaulted to the last post?

[LockeAG]

Another curious thing I found... when you colapse the post and if you have the Spoiler SHOW/HIDE method it will open in showing the spoiler, how can I fix this ?

thanks!

see'a

[magnus]

Another curious thing I found... when you colapse the post and if you have the Spoiler SHOW/HIDE method it will open in showing the spoiler, how can I fix this ?

thanks!

see'a

Make the same modifications to vbpost_postbit that you had to make to your postbit or postbit_legacy for the spoiler modification.

[Tralala]

Thanks for the AdminCP setting for: first post, last post, or first unread post.

It might be nice to see that as an individual user preference, too (set within the UserCP.)

Also, it might be nice to have separate preferences for threads in UserCP vs. threads in forumhome. Because personally for threads in ForumHome I'd rather see "first post" and for threads in UserCP I'd like to see "first unread."

---

I have just applied the update and now, going to UserCP on my forum resulted in an error:
Fatal error: Call to undefined function: fetch_coventry() in /home/.odell/myname/myforum.com/forums/usercp.php(500) : eval()'d code on line 30

I presume this has something to do with this new feature:
Included JavaScript in USERCP_SHELL to allow expand/collapse of subscribed threads.

Perhaps my UserCP_Shell template wasn't properly modified by the product? Is that Javascript something I can try manually inserting?

[Lea Verou]

It's a pity that such a nice mod has such a lame thread title. :p

Probably will install at July :)

[@ngel]

How can it be defaulted to the last post?


Any ideas on this? :confused:

[magnus]

It's a pity that such a nice mod has such a lame thread title. :p

Probably will install at July :)
I try to be descriptive. Would you rather it be called: ExpanjaX! v1.0 Beta 9 Release [Special Edition] ?

[magnus]

It might be nice to see that as an individual user preference, too (set within the UserCP.)
That's the eventual plan.

Also, it might be nice to have separate preferences for threads in UserCP vs. threads in forumhome. Because personally for threads in ForumHome I'd rather see "first post" and for threads in UserCP I'd like to see "first unread."
Noted.

I have just applied the update and now, going to UserCP on my forum resulted in an error:


I presume this has something to do with this new feature:


Perhaps my UserCP_Shell template wasn't properly modified by the product? Is that Javascript something I can try manually inserting?
A previous person had this problem and resolved it here (https://vborg.vbsupport.ru/showpost.php?p=1238317&postcount=225). Let me know if that works for you, too.

[magnus]

Any ideas on this? :confused:
Wait for a future release.

[Lea Verou]

I try to be descriptive. Would you rather it be called: ExpanjaX! v1.0 Beta 9 Release [Special Edition] ?
No but "Collapsable First Post using AJAX (or Last Post!) in Forumdisplay" would be better I think :p

[magnus]

No but "Collapsable First Post using AJAX (or Last Post!) in Forumdisplay" would be better I think :p

But it's also in USERCP and search_results.. :p

So, rather than pigenholing myself, I can be ambiguous and leave it as it.

[ragtek]

in usercp?

[LockeAG]

Make the same modifications to vbpost_postbit that you had to make to your postbit or postbit_legacy for the spoiler modification.

But this is a TAG , this spoiler code , doesn't touch the posbit's templates!

[magnus]

But this is a TAG , this spoiler code , doesn't touch the posbit's templates!

Provide me a link to the modification. I'll look at it.

[Realturktiger]

awesome .............installed !

[Tralala]

A previous person had this problem and resolved it here (https://vborg.vbsupport.ru/showpost.php?p=1238317&postcount=225). Let me know if that works for you, too.

I just tried it... repaired/optimized tables... but it had no effect. Still got an error when going into the UserCP. (The mod works inside the forums themselves though.)

[LockeAG]

Provide me a link to the modification. I'll look at it.
thanks .. this is the bbcode I use:

<div style="margin:5px 20px 20px 20px">

<div class="smallfont" style="margin-bottom:2px"><b>Spoiler:</b>

<input type="button" value="Show" style="width:45px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display != '') { this.parentNode.parentNode.getElementsByTagName('d iv')[1].getElementsByTagName('div')[0].style.display = '';this.innerText = ''; this.value = 'Hide'; } else { this.parentNode.parentNode.getElementsByTagName('d iv')[1].getElementsByTagName('div')[0].style.display = 'none'; this.innerText = ''; this.value = 'Show'; }">
</div>
<div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
<div style="display: none;">{param}</div></div></div>

based on this one: https://vborg.vbsupport.ru/showthread.php?t=110598&highlight=spoiler

Thanks again for your help , if you need help with design (icons, logos, templates, css or whatever) , I for sure will give you a hand!

see'a

[magnus]

I just tried it... repaired/optimized tables... but it had no effect. Still got an error when going into the UserCP. (The mod works inside the forums themselves though.)

As a test, could you create a new plugin with the following information:


Product: Collapsable First Post using AJAX
Hook Location: usersub_start
Title: Include functions_bigthree.php
Execution Order: 5
Plugin PHP Code::
require_once(DIR . '/includes/functions_bigthree.php');
Plugin is Active: Yes


.. let's see if that fixes it.

[Tralala]

.. let's see if that fixes it.

It did not. :(

[magnus]

It did not. :(
Uh... ok. Well, enough messing around, change the Hook Location for the plugin above to usercp_start (instead of usersub_start). Let's just nip this sucker right in the bud..

[Tralala]

Uh... ok. Well, enough messing around, change the Hook Location for the plugin above to usercp_start (instead of usersub_start). Let's just nip this sucker right in the bud..


Okay, well, now I no longer get the error... the UserCP page loads fine... which is obviously a step in the right direction. :up:

But, unfortunately, I'm back where we started in that the expand/collapse button that appears in the title of the subscribed threads doesn't actually do anything. Clicking on it has no effect. It still works fine in the regular forum view, though.


I do also see the same thing that was mentioned earlier, with regards to spoilers and my particular spoiler BB code. When clicking on the expand/collapse button in regular forum view, if the post that is revealed has a spoiler in it, the state of that spoiler is set to "show" instead of "hide." The spoiler button works fine, mind you. It's just that it should default to "hide" the spoilerized text rather than show it... just like it appears in the regular post.

Here is my BB replacement code, if that helps any:

<div style="margin:5px 20px 20px 20px">
<div class="smallfont" style="margin-bottom:2px">
<input type="button" value="Show" style="width:50px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.value=='Show') {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display = '';this.value='Hide';} else {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display='none'; this.value='Show';}">
</div>
<div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
<div style="display: none;">{param}</div>
</div>
</div>

FWIW, I am running vBulletin 3.6.4 on this particular forum.

[magnus]

Okay, well, now I no longer get the error... the UserCP page loads fine... which is obviously a step in the right direction. :up:

But, unfortunately, I'm back where we started in that the expand/collapse button that appears in the title of the subscribed threads doesn't actually do anything. Clicking on it has no effect. It still works fine in the regular forum view, though.


I do also see the same thing that was mentioned earlier, with regards to spoilers and my particular spoiler BB code. When clicking on the expand/collapse button in regular forum view, if the post that is revealed has a spoiler in it, the state of that spoiler is set to "show" instead of "hide." The spoiler button works fine, mind you. It's just that it should default to "hide" the spoilerized text rather than show it... just like it appears in the regular post.

Here is my BB replacement code, if that helps any:

<div style="margin:5px 20px 20px 20px">
<div class="smallfont" style="margin-bottom:2px">
<input type="button" value="Show" style="width:50px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.value=='Show') {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display = '';this.value='Hide';} else {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display='none'; this.value='Show';}">
</div>
<div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
<div style="display: none;">{param}</div>
</div>
</div>

FWIW, I am running vBulletin 3.6.4 on this particular forum.

Would it be possible for you to make me a temporary account on your forum and PM me the details? I'd like to check this out first hand if possible.

[Tralala]

Would it be possible for you to make me a temporary account on your forum and PM me the details? I'd like to check this out first hand if possible.

Sure. I'm assuming you'll need it to be an admin account? Happy to send you details via PM.

I'd just want to time it appropriately so I enable the mod during the precise time you're available to log in. (If I leave it on, I'll get a slew of questions from my members dying to know about the new feature, and I'm just not ready for that. :D )

[aggiefan]

I had to disable this because some of our users (actually a very small few were getting an error when they tried to access the usercp)

Fatal error: Call to undefined function fetch_coventry() in C:\AGGIEFANS\WEB\forums\usercp.php(500) : eval()'d code on line 16


Any clue to what this is? We have the latest version installed so im guessing its not a issue thats been fixed.

It was also documented here which is where i found out that it was this addon which was causing it: http://www.myhattiesburg.com/forums/showthread.php?p=233020

[magnus]

Ok, apparently this is less isolated than I thought. I'm going to dive into this with force tomorrow and get a fix out.

Sorry guys!

[nymyth]

this is sweetass...thanks a lot for this....having no problems so far

Peace

[beduino]

Hi Magnus!
A suggestion, maybe useful.
If you remember [a few posts before] i talk about a 'mystery' - whith 2 images [+] etc.
The problem [as you said] is fixed, but this make me a ideia.
A hack [new one] with the first AND the last post. :D
Then the user with click in first [+] see the first post and, click in second [+] read the last post.

It's sound possible? Or useful?
[your hack is working here (http://www.vb-brasil.org/forums/) ]
A great day,
Joao Barroca
aka beduino

[LockeAG]

Hey Magnus I will wait for the correction for the Usergroups and then we can continue with the little issue of the SPILER TAG...

Thanks again!