View Full Version : Forum Display Enhancements - Collapsable First Post using AJAX (or Last Post!)
wolfe
05-03-2007, 08:51 PM
is it possible to change the layout that shows when you click on expand like just displaying title and text no avatar etc
Mark.B
05-03-2007, 09:49 PM
is it possible to change the layout that shows when you click on expand like just displaying title and text no avatar etc
Just edit the vbpost_postbit template, and remove the avatar section, you can then move the username and title code into the other section.
l3it3r
05-03-2007, 09:58 PM
I installed, did the edits, imported, no errors, but nothing happens. Have the .js in the right spots and everything.. is there something else to look for?
magnus
05-04-2007, 01:04 AM
I installed, did the edits, imported, no errors, but nothing happens. Have the .js in the right spots and everything.. is there something else to look for?
Elaborate on "nothing happens" please..
Lea Verou
05-04-2007, 12:56 PM
But it's also in USERCP and search_results.. :p
So, rather than pigenholing myself, I can be ambiguous and leave it as it.
Yes but as it is I understood that you meant on showthread and I thought "how useless!" when I saw the title. It was out of sheer luck that I clicked on the title to figure out what it was. And it's a pity cause it's a wonderful idea!
magnus
05-04-2007, 01:33 PM
Yes but as it is I understood that you meant on showthread and I thought "how useless!" when I saw the title. It was out of sheer luck that I clicked on the title to figure out what it was. And it's a pity cause it's a wonderful idea!
Like I said, I'm open to ideas. :)
I'm a programmer, not a marketer unfortunately.
You're right, though. The name is pretty bland and uninteresting..
How to disable the avatar and signature of the user? There must be a option to do this in future versions.
magnus
05-04-2007, 07:22 PM
How to disable the avatar and signature of the user? There must be a option to do this in future versions.
Edit the vbpost_postbit template to look however you want.
morpheusXIIX
05-04-2007, 11:57 PM
have you thought of adding the option to show "all unread posts"? or would that be too intensive to run?
Tralala
05-05-2007, 12:07 AM
have you thought of adding the option to show "all unread posts"? or would that be too intensive to run?
My first thought on that is... why bother? At that point, why wouldn't the user just go into the thread itself?
I'm thinking this AJAX display is meant to be a preview, not a complete replacement for forum navigation.
skooby
05-05-2007, 01:27 AM
Awesome mod :)
l3it3r
05-05-2007, 12:39 PM
Elaborate on "nothing happens" please..
The + shows up next to all the threads, click on it, nothing happens, no errors, nothing. I uninstalled, reinstalled. still nothing. :confused:
magnus
05-05-2007, 01:49 PM
The + shows up next to all the threads, click on it, nothing happens, no errors, nothing. I uninstalled, reinstalled. still nothing. :confused:
First, verify that the files vbulletin_vbpost.js and jquery.js are in your [b]/clientscript/[b] directory. If the are, then do the following:
Activate the mod. Browse to your forumdisplay page. In your browser, right click. Select View Source. Copy and paste the entire source to a .txt file.
Attach the text file to a post here, or give it to me in a PM. I need to look at it.
BANDiT600
05-05-2007, 04:28 PM
My options sets to show last post, but... When I edit any post of the thread and next try to see last post it shows me last edited post, not the last one... It happens in serach results.
BANDiT600
05-05-2007, 04:31 PM
"by createdate" change to "order by id"???
Not good that this mod doesn't show last post in search result!!!
But thanks anyway...
/me installed...
BANDiT600
05-05-2007, 05:38 PM
And another little bug with alignment of "subscribed" and other icons, see screenshot!
With AJAX:
64017
Without AJAX:
64016
Timelord
05-06-2007, 05:10 AM
Hi Magnus! First of all, I just wanted to say this is a great idea, and from what I've seen, you've implemented it very well. However, I cannot get this to work on my forums. I have determined that it is because of the style I am using, as I have tested it under the default vBulletin style and it works there. However on the style I am using, a slightly modified version of Chestnut (by Allan), no [+] boxes appear to the left of the thread titles. I have attempted manually editing all the templates and letting it do it automatically, both times to no avail. I'm not sure what it is that's causing it but it would seem to relate directly to my style. Is there anything you can suggest that might fix this?
Thanks very much!
Dr. Bantham
05-06-2007, 11:55 AM
This looks like a wonderful mod, but it is not working for me. The graphic appears in my default template, but clicking on it results in opening the full thread as normal. I suspect this is a conflict with the following mod:
Change Forum Cell Colour on Mouseover (https://vborg.vbsupport.ru/showthread.php?t=127515)
I really enjoy using the first mod, but would compromise highlighting the cell only without the zoned click selection if absolutely necessary. I am assuming this is the problem, however.
UPDATE
I reinstalled and used manual template edits, as I assumed this could possibly remedy my issue. This resulted in no graphic and no effect. I then realized that the images/buttons directory had to be uploaded to the custom image folder I had set up for my template. End result: same as original installation for default template (clicking on the image results in opening the full thread as normal).
magnus
05-06-2007, 02:17 PM
Wait, the full thread opens, with replies and everything? That's.. odd. I don't even see how that's possible. Either way, I'd need to see it, in action, on the forum in question before I could even begin to fathom a fix.
magnus
05-06-2007, 02:19 PM
Hi Magnus! First of all, I just wanted to say this is a great idea, and from what I've seen, you've implemented it very well. However, I cannot get this to work on my forums. I have determined that it is because of the style I am using, as I have tested it under the default vBulletin style and it works there. However on the style I am using, a slightly modified version of Chestnut (by Allan), no [+] boxes appear to the left of the thread titles. I have attempted manually editing all the templates and letting it do it automatically, both times to no avail. I'm not sure what it is that's causing it but it would seem to relate directly to my style. Is there anything you can suggest that might fix this?
Thanks very much!
You need to upload the image files included in the zip to your style's (chestnut) specific image directory as well. No reason to use manual edits, as the automatic ones will work just fine once the image files are put into the proper directories.
Dr. Bantham
05-06-2007, 02:38 PM
Wait, the full thread opens, with replies and everything? That's.. odd. I don't even see how that's possible. Either way, I'd need to see it, in action, on the forum in question before I could even begin to fathom a fix.What was happening was that the previous mod's mouse click reaction was taking presedence over your mod, as it was effective for the entire table cell. I removed the following snippet from threadbit template and everything works fine:onclick="window.location.href='<if condition="$show['gotonewpost']">showthread.php?$session[sessionurl]goto=newpost&t=$thread[threadid]<else />showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]</if>';"This was the offending code from the previous mod. I now get the benefit of your mod while only sacrificing the regional cell click sensitivity for the previous mod. The cell color still changes as I still wished it to. Brilliant mod!
magnus
05-06-2007, 03:07 PM
What was happening was that the previous mod's mouse click reaction was taking presedence over your mod, as it was effective for the entire table cell. I removed the following snippet from threadbit template and everything works fine:onclick="window.location.href='<if condition="$show['gotonewpost']">showthread.php?$session[sessionurl]goto=newpost&t=$thread[threadid]<else />showthread.php?$session[sessionurl]t=$thread[threadid]$thread[highlight]</if>';"This was the offending code from the previous mod. I now get the benefit of your mod while only sacrificing the regional cell click sensitivity for the previous mod. The cell color still changes as I still wished it to. Brilliant mod!
Ahh.. there was another onclick event. Yea, that would definately bugger things up. Glad you figured it out, and thanks for posting the fix. I'm sure it will benefit someone else!
l3it3r
05-06-2007, 03:40 PM
Did you receive my PM with the forumdisplay? The mod is still installed, and the + is still there, but not functioning. And there are still no other errors. .js are in place, etc.
magnus
05-06-2007, 04:47 PM
Did you receive my PM with the forumdisplay? The mod is still installed, and the + is still there, but not functioning. And there are still no other errors. .js are in place, etc.
I replied to your PM on 05. May 2007 @ 19:12. I verified it was sent, as there's a copy in my Sent Items folder.
daloosaa
05-06-2007, 09:47 PM
Works fine! You did a good job, magnus.
l3it3r
05-07-2007, 01:19 AM
I replied to your PM on 05. May 2007 @ 19:12. I verified it was sent, as there's a copy in my Sent Items folder.
My apologies, I don't have the notifications setup for vbulletin.org
I set it to last post. It works. so you're right. I'll look into it further tomorrow as I have much to do right now.
thanks!
sensimilla
05-07-2007, 08:24 AM
What if neither automated file edits or manual file edits dont work for me ?
Only default vbulletin template is working with it.. ?
TIA, great hack
magnus
05-07-2007, 10:31 AM
What if neither automated file edits or manual file edits dont work for me ?
Only default vbulletin template is working with it.. ?
TIA, great hack
Be sure to copy the images included in the zip to you custom style's image directory.
dbembibre
05-08-2007, 09:20 AM
work perfect in my forum, the only problem is that is incompatible with Plugin Based Template cache, because i need set off.
dbembibre
05-08-2007, 09:58 AM
work perfect in my forum, the only problem is that is incompatible with Plugin Based Template cache, because i need set off.
I solver set to NO Enable Automatic template editing and make the template changes manually.
Good work, the mod is amazing :up: :D
deepak7
05-08-2007, 01:38 PM
Is there any statistic about % of people that uses javascript plugin?
I had a javascript menu on my site and some people complained they cannot see the menu (and they did not understand why).
My real question is what if I install this and the users can't run js?
Any error? (Display or anything else).
Regards
magnus
05-08-2007, 01:53 PM
Is there any statistic about % of people that uses javascript plugin?
I had a javascript menu on my site and some people complained they cannot see the menu (and they did not understand why).
My real question is what if I install this and the users can't run js?
Any error? (Display or anything else).
Regards
If they can't run JavaScript, nothing will happen when they click the [+] icon. No popups, no alerts. Just.. nothing.
mshadows
05-08-2007, 08:48 PM
Omg, one of the best hacks I've seen yet to date. Well done on this, I am definitely using it.
*Marks as installed*
dragonlove
05-09-2007, 01:24 AM
Excellent hack, thank you!
dragonlove
05-09-2007, 02:33 AM
ps. any chance for a vbadvanced cmps module? :)
Mean that it doesn't work with vBAdvanced portal , on the portal we can't use this function, how can we do this?????
egyptsons
05-09-2007, 09:18 AM
Thanks for the Hack but I want to ask
Is this Hack will causes a high load on server if the forums big?
dbembibre
05-09-2007, 09:49 AM
I have a Big board with more than 1000 constant users and no load issues because this mod not add extra queries
magnus
05-09-2007, 10:25 AM
Thanks for the Hack but I want to ask
Is this Hack will causes a high load on server if the forums big?
No, as pointed out by dbembibre above, there are no extra queries. The same query is run whether a user clicks on the thread and views the whole thing, or if they click on the expand icon.
GrendelKhan{TSU
05-11-2007, 09:12 AM
ok.. I bit confused:
I installed 1.2.0 and had to do manual edits as the automatic ones didn't work.
now I want to upgrade, so I can get the new features and the "auto" template edits but I'm not sure what I have to do/undo first and then upload/do for the upgrade.
just upgrading won't work right?
magnus
05-11-2007, 10:06 AM
ok.. I bit confused:
I installed 1.2.0 and had to do manual edits as the automatic ones didn't work.
now I want to upgrade, so I can get the new features and the "auto" template edits but I'm not sure what I have to do/undo first and then upload/do for the upgrade.
just upgrading won't work right?
Remove any manual template edits you've done, then just import the new version over the old one. Automatic template editing is enabled by default.
Saudi Zoom
05-11-2007, 11:34 AM
Installed and it's work great, But there is a small error
When i set the "Display First/Last Post" to (Last Thread) and go to forum/search.php?do=getdaily , And clicking onCollaps button it goes to the first thread!
Great job, Thank you
magnus
05-11-2007, 01:14 PM
Installed and it's work great, But there is a small error
When i set the "Display First/Last Post" to (Last Thread) and go to forum/search.php?do=getdaily , And clicking onCollaps button it goes to the first thread!
Great job, Thank you
This has been discussed. It's by design, not a bug. The framework for displaying the last post isn't readily available within the available search hooks (without semi-extensive modifications). I'm working on a non-cludgy way to implement it.
Search results, regardless of settings, will always be first post. This is normal.
Mastar
05-11-2007, 05:21 PM
Sorry to say that this is not compatible with Vb3.6.6.... It gives a fatal error, until I disable it.
Gryphon
05-11-2007, 05:28 PM
It is working fine for me on 3.6.6.
It would help the author to know the error.
magnus
05-11-2007, 06:11 PM
Sorry to say that this is not compatible with Vb3.6.6.... It gives a fatal error, until I disable it.
I haven't upgrade to 3.6.6. I can't address the problem if I don't know the error.
Mastar
05-11-2007, 06:20 PM
I haven't upgrade to 3.6.6. I can't address the problem if I don't know the error.
Fatal error: Call to undefined function: fetch_coventry() in /home/mysite/public_html/forums/usercp.php(499) : eval()'d code on line 16
perfphysio
05-11-2007, 07:55 PM
This hack is awesome. Works fine in 3.6.6
tehQspm
05-11-2007, 08:05 PM
Fatal error: Call to undefined function: fetch_coventry() in /home/mysite/public_html/forums/usercp.php(499) : eval()'d code on line 16I just noticed that too this morning. So far it only seems to come up whenever someone tries to get to the UserCP. It doesn't appear to break on anything else.
Have disabled it for now.
magnus
05-12-2007, 04:59 PM
There's a fix for the above error in previous posts of this thread. I'll incorporate it in a new release as soon as I can, but since it's Mother's Day weekend it will have to wait until I get back in town. :)
RemiAlone
05-12-2007, 11:29 PM
Installed it on 3.6.6. and it works fine.
Don't forget to upload the buttons to your custom style. :P
Sushubh
05-15-2007, 11:36 PM
i am using this on a forum with vbseo installed. whenever i try to open the first post... i get the 404 page!
forum: http://broadbandforum.in
magnus
05-15-2007, 11:46 PM
i am using this on a forum with vbseo installed. whenever i try to open the first post... i get the 404 page!
forum: http://broadbandforum.in
You haven't uploaded the vbpost_ajax.php file to your forum's root directory.
Sushubh
05-15-2007, 11:53 PM
damn. stupid me. thanks mate!
cupra
05-17-2007, 09:31 PM
great work, installd!
installed. worked super fine!
BadgerDog
05-21-2007, 01:18 PM
Installed on v3.6.7PL1...
Edit: Had to uninstall after users complained that there were graphics pic display issues when they view posts using this mod. I checked and could duplicate it. Basically, when one clicks the "+" sign and if the post has pics displayed side by side like this:
PIC PIC
PIC PIC
The post displayed with this mod didplays them like this:
PIC
PIC
PIC
PIC
If you display the same post by just clicking it normally, then they display properly as they always have.
Unfortunately, had to un-install because of this. Nice mod though...
Thanks....
Regards,
Badger
magnus
05-21-2007, 02:57 PM
Installed on v3.6.7PL1...
Edit: Had to uninstall after users complained that there were graphics pic display issues when they view posts using this mod. I checked and could duplicate it. Basically, when one clicks the "+" sign and if the post has pics displayed side by side like this:
PIC PIC
PIC PIC
The post displayed with this mod didplays them like this:
PIC
PIC
PIC
PIC
If you display the same post by just clicking it normally, then they display properly as they always have.
Unfortunately, had to un-install because of this. Nice mod though...
Thanks....
Regards,
Badger
Sounds like you're not using default templates. Appears to me you need a nowrap="nowrap" option somewhere.
BadgerDog
05-21-2007, 04:26 PM
Sounds like you're not using default templates. Appears to me you need a nowrap="nowrap" option somewhere.
"threadbit" "search_results" and "forumdisplay" have never been touched... they are the default v3.6.7PL1
Where would I need nowrap="nowrap", given that?
Thanks....
Appreciate the feedback... :)
Regards,
Badger
BozzaJos
05-21-2007, 07:00 PM
Ow my god.. I installed this hack but when I went to my forum (called forum.php, I've got vbadvanced installed) I got this error message at the top of my forum (above the banner):
Warning: exec() has been disabled for security reasons in /forum.php(536) : eval()'d code on line 51
When I click on a section it's gone, guess it only shows it @ forum.php. Big problem is, when I uninstalled it, it still shows the error message! How the hell do I get rid of it?
I hope someone can help me! Thanks in advance...
magnus
05-22-2007, 12:45 AM
Ow my god.. I installed this hack but when I went to my forum (called forum.php, I've got vbadvanced installed) I got this error message at the top of my forum (above the banner):
Warning: exec() has been disabled for security reasons in /forum.php(536) : eval()'d code on line 51
When I click on a section it's gone, guess it only shows it @ forum.php. Big problem is, when I uninstalled it, it still shows the error message! How the hell do I get rid of it?
I hope someone can help me! Thanks in advance...
Ok, first things first:
If you've uninstalled the hack and still receive the errors, it's safe to assume this hack isn't the culprit.
This hack does not utilize the exec() (http://www.php.net/function.exec) function.
For the life of me, I can't fathom anyway that this hack would hook into vBadvanced. It's very static on where it hooks into.
My money is on another hack causing this problem or a vBadvanced configuration error. I personally do not use vBadvanced, so my knowledge on such is limited to non-existent.
magnus
05-22-2007, 12:46 AM
"threadbit" "search_results" and "forumdisplay" have never been touched... they are the default v3.6.7PL1
Where would I need nowrap="nowrap", given that?
Thanks....
Appreciate the feedback... :)
Regards,
Badger
I'll be upgrading to 3.6.7 later this week. I'll attempt to duplicate the problem and provide a fix.
StrifeX
05-22-2007, 03:51 AM
Great idea, very innovative and original!
BozzaJos
05-22-2007, 08:33 AM
Ok, first things first:
If you've uninstalled the hack and still receive the errors, it's safe to assume this hack isn't the culprit.
This hack does not utilize the exec() (http://www.php.net/function.exec) function.
For the life of me, I can't fathom anyway that this hack would hook into vBadvanced. It's very static on where it hooks into.
My money is on another hack causing this problem or a vBadvanced configuration error. I personally do not use vBadvanced, so my knowledge on such is limited to non-existent.
Thanks for the quick response mate. I just know for sure that installed this hack caused the error message. One minute before I installed it I was browsing my site without any error messages. Next minute I decided to install this hack and one second later I got the error message. Sounds like too much of a coincidense to me.
My PHP skills are really limited. Do you perhaps know what this error message is and how to get rid of it?
BadgerDog
05-22-2007, 09:50 AM
I'll be upgrading to 3.6.7 later this week. I'll attempt to duplicate the problem and provide a fix.
Thank you Sir.... :)
Appreciate that ...:up:
If I can help testing at all, please let me know...
Regards,
Badger
magnus
05-22-2007, 02:26 PM
Thanks for the quick response mate. I just know for sure that installed this hack caused the error message. One minute before I installed it I was browsing my site without any error messages. Next minute I decided to install this hack and one second later I got the error message. Sounds like too much of a coincidense to me.
My PHP skills are really limited. Do you perhaps know what this error message is and how to get rid of it?
Not really, there's not much I can tell you other than find the code trying to call an exec() function.
This modifications requires no code changes. If you uninstall it and delete the files, the hack is gone, period. If you are still receiving errors, the problem lies elsewhere -- it cannot be this modification.
Apparently, it lies within a vBadvanced modification or vBadvanced itself. I'd start there.
BozzaJos
05-22-2007, 03:27 PM
I'm positive it happened while installed this hack. Perhaps it's coz I've got vbadvanced installed, modified my forum files so they stay within the vbadvanced columns and coz I've renamed index.php to forum.php. I don't know what it is but I do know that it's been 3 weeks since it was the last time I changed something to my forum and now that I did it's given this error. If I check my forum @ 15:00 and everything is correct and then I installed your mod @ 15:01 and suddenly I get the error, I just don't see any other explanation than it's your mod who did it.
Btw, it's not that bad. I found out that it's only showing the message to admins but it's still a weird error lol. Unfortunately, I know nothing about php or this error message so I don't have a clue how to fix it.
magnus
05-22-2007, 09:31 PM
If I check my forum @ 15:00 and everything is correct and then I installed your mod @ 15:01 and suddenly I get the error, I just don't see any other explanation than it's your mod who did it.
There could be a dozen other explanations.
Warning: exec() has been disabled for security reasons in /forum.php(536) : eval()'d code on line 51
Line 536 of index.php (forum.php) is:
($hook = vBulletinHook::fetch_hook('forumhome_complete')) ? eval($hook) : false;
The plugin causing your error is using the forumhome_complete hook. My hack does not use this hook.
Check in Plugins & Products > Plugin Manager. Sort by Hook Location. Look for any plugins hooked into forumhome_complete -- one of those is the problem. Make note of each product name, then using the Product Manager, disable each of the noted hacks one at a time; checking to see if the error disappears. Once it does, you now know which hack is the culprit.
Let us know.
Barakat
05-22-2007, 09:34 PM
i saw that at the german vb but i could not find it there ,,,,
thanks a lot for releasing it here .
magnus
05-22-2007, 09:41 PM
i saw that at the german vb but i could not find it there ,,,,
thanks a lot for releasing it here .
Wait, where did you see this released? What German VB? I never authorized any translations or external releases. Could you let me know what site, please?
Barakat
05-23-2007, 10:50 AM
no its not an external release but they are useing your hack on thier site ...
its so nice
http://www.vbhacks-germany.org/forumdisplay.php?f=109
magnus
05-23-2007, 10:58 AM
no its not an external release but they are useing your hack on thier site ...
its so nice
http://www.vbhacks-germany.org/forumdisplay.php?f=109
Oh, woops. I misunderstood, sorry! ;)
Advocate1
05-25-2007, 02:23 PM
Hi, you've created nice hack!
Is there any way to limit chars or words in $post[message] @ vbpost_postbit?
e39m5
05-25-2007, 08:56 PM
Advocate1's suggestion brings up a good point, but I think it is something that should be user defined in the CP rather than admin defined. It really gets into user preference and usability. I also don't believe an update like this would affect loading time or bandwidth usage.
e39m5
Bonee70
05-31-2007, 11:43 PM
Hmmm, when I click on the icon nothing happens.
Mousover shows me "Click here to read last post" ...
http://www.the-european-football-league.co.uk/forum/forumdisplay.php?f=13
magnus
06-01-2007, 04:57 PM
Hmmm, when I click on the icon nothing happens.
Mousover shows me "Click here to read last post" ...
http://www.the-european-football-league.co.uk/forum/forumdisplay.php?f=13
You didn't upload the vbulletin_vbpost.js or jquery.js to your clientscript folder. Re upload all of the product files to the proper locations.
Bonee70
06-01-2007, 09:11 PM
Thx Magnus, sometimes I just have hot air in my head.... working fine now!
SemperFideles
06-04-2007, 07:26 AM
OK, first of all, really great MOD!
I have only one problem:
1. I set the option to view the Last Post when the user clicks the + sign.
2. When I'm in forum display, the + sign pulls up the Last Post.
3. When I use the Today's Posts or New Posts features (which uses search.php), the + sign works but it displays the First Post
Is there a way to fix the search results? Does the search results even use the threadbit template? I can't even find in the templates where your Product has modified the Templates. I tried manually editing them as indicated in your instructions and the + sign appeared but didn't work. I unedited the files and wen back to automatic updating of the Templates and it works but as indicated above.
SemperFideles
06-04-2007, 07:48 AM
Incidentally, I agree with others that it would be awesome if there could be two plus signs - one for the first post to dropdown and another for the last post to dropdown.
magnus
06-04-2007, 11:51 AM
Is there a way to fix the search results? Does the search results even use the threadbit template? I can't even find in the templates where your Product has modified the Templates. I tried manually editing them as indicated in your instructions and the + sign appeared but didn't work. I unedited the files and wen back to automatic updating of the Templates and it works but as indicated above.
This is by design. The search results SQL doesn't contain all the necessary information to display anything other than the first post, so regardless of what you've selected within the AdminCP, anything involving the search results will always display first post.
It's something that may possibly be worked in later. If you wish to change the template layout, the template you're looking for is vbpost_postbit. As for trying to find changes made by the automatic template edits, you can't. They are done on-the-fly.
hmm... I've installed everything as it was instructed, but it doesn't work!
I don't even see the "+" signs...
http://latforums.lv/forum1.html
I'm using Aria skin and vBSEO,
maybe it has something to do with it?
magnus
06-04-2007, 04:37 PM
hmm... I've installed everything as it was instructed, but it doesn't work!
I don't even see the "+" signs...
http://latforums.lv/forum1.html
I'm using Aria skin and vBSEO,
maybe it has something to do with it?
No, I checked your site. It's working. You just haven't uploaded the images to the correct folders.
On your forum, it looks like they should be uploaded to the /17_lat/ directory.
Once done correctly, you should be able to access both images at:
http://latforums.lv/17_lat/expand.gif
http://latforums.lv/17_lat/expand_collapsed.gif
https://vborg.vbsupport.ru/external/2007/06/4.png
Thank You! :)
magnus
06-04-2007, 10:25 PM
best. picture. ever.
:)
Evaporate
06-06-2007, 06:02 PM
Brilliant.
Simple but effective. I haven't tried it with lots of traffic yet but should I guess actually reduce database load.
SemperFideles
06-08-2007, 04:38 AM
This is by design. The search results SQL doesn't contain all the necessary information to display anything other than the first post, so regardless of what you've selected within the AdminCP, anything involving the search results will always display first post.
It's something that may possibly be worked in later. If you wish to change the template layout, the template you're looking for is vbpost_postbit. As for trying to find changes made by the automatic template edits, you can't. They are done on-the-fly.
I'm sorry magnus to bother you if you covered it previously. I tried searching for the term I was using.
When I click on Today's Posts, the results display not only the title of all the threads (if I click on the thread titles I'm taken to the first post). But, each thread listing also contains a clickable icon to "View Last Post".
Thus, it seems that the search results are, in fact, returning the Thread ID and Post ID of bost the first and last posts for each thread in the list. I'm not sure I understand, then, when you say that it doesn't contain "necessary information" to display anything other than the first post.
When I click on a particular forum for instance, it seems like the only thing I see are the thread title (which I can click on for the first post) and a clickable icon to "View Last Post". Thus, like search results, the forum listing seems to contain thread id and post id for each thread.
Why, on the one hand, does the forum listing contain the information needed while, on the other, the search results do not?
magnus
06-08-2007, 01:57 PM
I'm sorry magnus to bother you if you covered it previously. I tried searching for the term I was using.
When I click on Today's Posts, the results display not only the title of all the threads (if I click on the thread titles I'm taken to the first post). But, each thread listing also contains a clickable icon to "View Last Post".
Thus, it seems that the search results are, in fact, returning the Thread ID and Post ID of bost the first and last posts for each thread in the list. I'm not sure I understand, then, when you say that it doesn't contain "necessary information" to display anything other than the first post.
When I click on a particular forum for instance, it seems like the only thing I see are the thread title (which I can click on for the first post) and a clickable icon to "View Last Post". Thus, like search results, the forum listing seems to contain thread id and post id for each thread.
Why, on the one hand, does the forum listing contain the information needed while, on the other, the search results do not?
There's no (easily) available way to pull the first unread postid within search. So, to prevent accidental breakage, search results were restricted to firstpostid. Yes, they can display lastpostid. It was just simpler, at the time, to just force forstpostid. My logic was that someone searching was looking for something specific, and generally, that information would be found in the first post.
If you want lastpostid results within search, edit the Make changes to 'threadbit' template plugin.
FIND:
if (THIS_SCRIPT == 'search')
{
$postidtype = 'firstpostid';
$titlephrase = $vbphrase['first_post'];
}
REPLACE WITH:
if (THIS_SCRIPT == 'search')
{
$postidtype = 'lastpostid';
$titlephrase = $vbphrase['last_post'];
}
This will only work for firstpostid and lastpostid. It will not work for the first unread post.
Quickness
06-08-2007, 02:12 PM
Thanks for this awesome mod -- clicks install
macshrine
06-18-2007, 10:23 PM
Love it, great job! :)
Terrasoft
06-29-2007, 07:11 AM
Its weird, the hack works great but not in the search feature. The pluses are there, but when they are clicked on...nothing happens. I installed it and had to do the manual template edits and nothing...any suggestions?
magnus
06-29-2007, 10:37 AM
Its weird, the hack works great but not in the search feature. The pluses are there, but when they are clicked on...nothing happens. I installed it and had to do the manual template edits and nothing...any suggestions?
You're using the latest version and you had to use manual template edits? That's weird..
Browse to your search page, click view source, and make sure the javascript is being loaded. That's the culprit 99.9% of the time, especially with manual edits.
Terrasoft
06-29-2007, 11:44 AM
Hmm let me check that then. Ill also try turning manual edits off and let it work from there.
So yeah, I am still having this error even though it calls the javascript and all the correct automatic templates are being run. Any clue?
Terrasoft
06-29-2007, 01:00 PM
I wonder, Im using the thread prefix hack which also requires you to edit the threadbit template, would this affect it in any way?
Very very very goooood! :D
Magnumutz
06-30-2007, 06:07 AM
Very nice... I just installed and i , and my users, love it.
*Clicks Install*
Terrasoft
07-01-2007, 08:40 PM
Magnus, with the PM I sent you...I gave you a name of a hook that was being run under search_results_query_thread under the Thread Prefixes hack. Well I just tried disabling that hook and now it works perfectly, however if possible...itd be awesome to be able to use both of those hooks as the prefix in the search area is an extremely useful resource as well.
keyness
07-01-2007, 09:30 PM
That's a great mod! Thank you!
MDK-Indy
07-02-2007, 01:37 AM
Nice Hack :up:
But i have a error.
If i klick at the "+" then open the Ajax window and approx. after 1 sec change the view to the completely Thread.
Whats wrong?
Greeting Indy
nymyth
07-02-2007, 03:59 PM
2 quick fixes ( you dont have to follow them to have it working) - I made these changes to get a valid XHTML 1.0 Transitional.
1. In the plugin "Make changes to 'threadbit' template"
Look for this:
$vbulletin->templatecache['threadbit'] = preg_replace($find, $match[0] . $match[1] . ' ".(($thread[\'open\'] != 10) ? ("<img id=\"vbpostimg_$thread[' . $postidtype . ']\" src=\"$stylevar[imgdir_button]/expand.gif\" onclick=\"return vbpost_get($thread[' . $postidtype . '])\" onMouseOver=\"this.style.cursor=\'pointer\';\" title=\"' . construct_phrase($vbphrase['click_here_to_read_the_x'], $titlephrase) . '\" />") : (""))."', $vbulletin->templatecache['threadbit']);
replace with:
$vbulletin->templatecache['threadbit'] = preg_replace($find, $match[0] . $match[1] . ' ".(($thread[\'open\'] != 10) ? ("<img id=\"vbpostimg_$thread[' . $postidtype . ']\" src=\"$stylevar[imgdir_button]/expand.gif\" onclick=\"return vbpost_get($thread[' . $postidtype . '])\" alt=\"' . construct_phrase($vbphrase['click_here_to_read_the_x'], $titlephrase) . '\" />") : (""))."', $vbulletin->templatecache['threadbit']);
I took out the onMouseOver and changed TITLE to ALT.
magnus
07-02-2007, 05:16 PM
Nice Hack :up:
But i have a error.
If i klick at the "+" then open the Ajax window and approx. after 1 sec change the view to the completely Thread.
Whats wrong?
Greeting Indy
I'll need to see an example of what's happening to better understand what needs to be looked at.
baghdad4ever
07-02-2007, 06:12 PM
thanks magnus
can you make it apear only to members not to guest??
is it make load on server or not???
tokenyank
07-04-2007, 11:28 AM
Hey Magnus, I love this hack and have had it on for a few days now so I'm sad to report that I've had to take it off...
I've been getting reports of people getting:
Fatal error: Call to undefined function: fetch_coventry() in /home/mumsonli/public_html/forums/usercp.php(499) : eval()'d code on line 18
errors.
Their user groups are members and super mods whilst admin and mods do not get the error..
This manifests when you want to change your usertitle, when you click save, you get the above error, but what you've just 'saved' has saved anyway so the information is still being written to the DB despite the fatal error.
I've tried both the creation of the plugin and the repair of database as suggested back in May but to no avail. Unfortanatly, I've had to disable it and hope for a fix, though considering that this seems to affect the minority, I'm not holding my breath! :(
Thanks anyway!
tokenyank
07-04-2007, 11:34 AM
Curiouser and curiouser!
Ok, with product enabled, error triggered.
Product disabled, error goes away but drop down still works! :confused:
In my product management, I've disabled your mod, simply because I didn't want to unisntall it should a fix come out. Thinking that disabling it would make it unusable (the clue is in the name! :) ) AND since the error went away, I thought all was good... Until I checked active topics and the + is still there and it is still clickable and it still shows the posts it was supposed to
So, I have an error that is intermittent not only for me, but for those that installed it, AND when disabled still runs!
You code hardcore mate! ;)
Seriously though, ermm... What's the story? :P
magnus
07-04-2007, 03:38 PM
tokenyank, be sure you're disabling the entire product not just a plugin. If you're disabling a product and it's still active, suffice to say, you've got a larger problem elsewhere. The processing of plugins/hooks/etc. is handled exclusively by the core of vBulletin.
As for the original problem you're having, a few others have reported the same error however it's completely random (so far) as to who is affected. It's one of those things I can't really track down unless I could replicate the error and attempt to debug it.
It has no rhyme or reason, it's across a couple different vB versions, different mods installed on each forum -- no discernable pattern. I'll keep looking, though.
tokenyank
07-04-2007, 03:52 PM
I figured it was intermitten as it has been installed for days now and this is the first time a member said anything.
And, since it doesn't effect me, I never caught it so I can't say for certain that it hasn't always existing, but I'm pretty sure that it didn't.
The only other AJAX thing I have installed is ajaxReg - Ajax Registration, with instant field checking (https://vborg.vbsupport.ru/showthread.php?p=1282214). But since they don't share any templates or whatever, I doubt there's a conflict.
alessai
07-04-2007, 05:39 PM
have a suggestion :
an option to make this hack work in certian grups only because the thing i use hack that limit the views for the visitors and the problem through this hack they can see the thred and the limition hack doesnt catch them
raiderlax
07-05-2007, 06:12 AM
Doesn't work for me for vb 3.6.7 ?
raiderlax
07-05-2007, 06:13 AM
Doesn't work for me for vb 3.6.7 ?
magnus
07-05-2007, 04:26 PM
Doesn't work for me for vb 3.6.7 ?
1/ No reason to double post.
2/ It's been tested on 3.6.7 and shown to work fine.
3/ I can't really help you if I don't know the problem, can I?
raiderlax
07-05-2007, 06:23 PM
1/ No reason to double post.
2/ It's been tested on 3.6.7 and shown to work fine.
3/ I can't really help you if I don't know the problem, can I?
Hey sorry about the double post, don't know how that happened,
anyways I installed it on my forum www.talkfitness.org and nothing shows up on the showthread, what should I do?
magnus
07-05-2007, 06:52 PM
Hey sorry about the double post, don't know how that happened,
anyways I installed it on my forum www.talkfitness.org and nothing shows up on the showthread, what should I do?
Well, off the bat, it doesn't appear you've actually installed the modification. The files jquery.js and vbulletin_vbpost.js are not present in your /clientscript/ directory. Nor are any of the associated image files located in the correct directories.
So, either you didn't install the modification correctly or you removed it. Both which prevent me from being able to find out what the problem is based off the description of "nothing shows up".
jasculs
07-06-2007, 05:25 AM
The mod is great!
However it doesn't work with the "Hide Links From Guest" mod:
https://vborg.vbsupport.ru/showthread.php?t=123415
Guests are able to see the links in the ajax post. Anything I can do to make it work?
magnus
07-06-2007, 10:47 AM
The mod is great!
However it doesn't work with the "Hide Links From Guest" mod:
https://vborg.vbsupport.ru/showthread.php?t=123415
Guests are able to see the links in the ajax post. Anything I can do to make it work?
Right off the bat, I'd say you'd just need to run whatever regular expression match/replace he's probably using against the returned message value.
It's something I can look at when I get some time.
jasculs
07-06-2007, 01:16 PM
Right off the bat, I'd say you'd just need to run whatever regular expression match/replace he's probably using against the returned message value.
I don't quite understand really. Anyway you can give an example. Would that require a plugin for me to add? I'm ok with finding things in the code, but I'm not sure what I should look for as far as a regular expression match/replace.
magnus
07-06-2007, 02:37 PM
In one of the plugins for the link hack, you'll most likely find a bit of code that does all the processing you're looking for. Something that uses a regexp to match for http then replaces it with the specified phrase.
Taking that bit of code, and placing it in vbpost_ajax.php where the message text is retrieved should yield the desired result.
Invalid ID
07-06-2007, 02:53 PM
Amazing
jasculs
07-06-2007, 03:52 PM
In one of the plugins for the link hack, you'll most likely find a bit of code that does all the processing you're looking for. Something that uses a regexp to match for http then replaces it with the specified phrase.
Taking that bit of code, and placing it in vbpost_ajax.php where the message text is retrieved should yield the desired result.
Would what your talking about be in this plugin somewhere? This is the plugin that hides the links in the posts. If it is in here can you point it out for me and maybe tell me where to put in the vbpost_ajax.php file? I would really appreciate it.
if (ereg("(showthread)", $GLOBALS[vbulletin]->scriptpath))
{
if ($this->registry->options['hlfg_global'])
{
$groups = explode(',',$this->registry->options['hlfg_groups']);
if ($this->registry->options['hlfg_posts'] AND !$this->registry->userinfo['userid'] OR $this->registry->options['hlfg_posts'] AND (is_member_of($this->registry->userinfo, $groups) OR $groups[0] == 0))
{
if (!$forum['forum_hlfg'])
{
$pattern = '/(<a.*?<*a>)/';
$message_array = preg_split($pattern, $this->post['message'], 65535, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
if ($this->registry->options['hlfg_misc'] == '')
{
$this->registry->options['hlfg_misc'] = "\e";
}
$ugids = explode(',',$this->registry->options['hlfg_ugids']);
if ($ugids[0] == '')
{
$ugids[0] = '0';
}
foreach($message_array as $message_key => $message_value)
{
if (!preg_match("/" . $this->registry->options['hlfg_misc'] . "/", $message_value) AND (!strstr($this->registry->options['hlfg_users'], $post[musername])) AND ($post['userid'] != $this->registry->userinfo['userid'] OR !$this->registry->options['hlfg_own']) AND (!is_member_of($post['usergroupid'], $ugids)))
{
$message_array[$message_key] = preg_replace("!<a[^>]*(http|www|mailto)(.*)</a>|\b[A-Z0-9._%-]+@[A-Z0-9._%-]+\.[A-Z]{2,4}\b!siU", $this->registry->options['hlfg_info'], $message_value);
}
}
$this->post['message'] = implode("", $message_array);
}
}
}
}
magnus
07-06-2007, 05:14 PM
Yep, that looks like it. I had hoped it would've been contained within a function, as that would've been ideal -- however, that will work.
Try this:
Open up vbpost_ajax.php, look for:
//if ($_SERVER['REQUEST_METHOD'] == 'POST' AND
Above it, paste the following:
if ($vbulletin->options['hlfg_global'])
{
$groups = explode(',',$vbulletin->options['hlfg_groups']);
if ($vbulletin->options['hlfg_posts'] AND !$vbulletin->options['userid'] OR $vbulletin->options['hlfg_posts'] AND (is_member_of($vbulletin->userinfo, $groups) OR $groups[0] == 0))
{
if (!$foruminfo['forum_hlfg'])
{
$pattern = '/(<a.*?<*a>)/';
$message_array = preg_split($pattern, $post['message'], 65535, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
if ($vbulletin->options['hlfg_misc'] == '')
{
$vbulletin->options['hlfg_misc'] = "\e";
}
$ugids = explode(',',$vbulletin->options['hlfg_ugids']);
if ($ugids[0] == '')
{
$ugids[0] = '0';
}
foreach($message_array as $message_key => $message_value)
{
if (!preg_match("/" . $vbulletin->options['hlfg_misc'] . "/", $message_value) AND (!strstr($vbulletin->options['hlfg_users'], $post[musername])) AND ($post['userid'] != $vbulletin->userinfo['userid'] OR !$vbulletin->options['hlfg_own']) AND (!is_member_of($post['usergroupid'], $ugids)))
{
$message_array[$message_key] = preg_replace("!<a[^>]*(http|www|mailto)(.*)</a>|\b[A-Z0-9._%-]+@[A-Z0-9._%-]+\.[A-Z]{2,4}\b!siU", $vbulletin->options['hlfg_info'], $message_value);
}
}
$post['message'] = implode("", $message_array);
}
}
}
Keep in mind I haven't had a chance to test this, so I'd suggest backing up your original vbpost_ajax.php. Let me know if that works, if not, when I get some free time I'll install the links hack on my test forum.
jasculs
07-06-2007, 05:21 PM
That worked except it blocked the links for everyone, not just guests. Anyway I can add a condition or something so it just blocks it for unregistered users only? Thanks for the help.
alessai
07-06-2007, 05:22 PM
magnus.... could yo see my suggestion ? and is it possible?
magnus
07-06-2007, 07:04 PM
magnus.... could yo see my suggestion ? and is it possible?
I need more information before I could even remotely begin to address your question. For example, a link to whichever modification you're trying to use in conjuction with this one.
magnus
07-06-2007, 07:10 PM
That worked except it blocked the links for everyone, not just guests. Anyway I can add a condition or something so it just blocks it for unregistered users only? Thanks for the help.
Here, FIND:
if ($vbulletin->options['hlfg_global'])
REPLACE with:
if ($vbulletin->options['hlfg_global'] && !$vbulletin->userinfo['userid'])
That should do it.
jasculs
07-06-2007, 07:21 PM
You are seriously the best. I'll be sure to make a donation soon. Thanks!
alessai
07-06-2007, 10:35 PM
I need more information before I could even remotely begin to address your question. For example, a link to whichever modification you're trying to use in conjuction with this one.
:) here is the problem i use more than one (and 2 of them are not here) ,,, so my suggestion is to add an option to choose which groups can use this feature :up:
AcidX
07-10-2007, 11:27 PM
Works just great! Installed.
Damn I love AJAX! ;)
cuphongle
07-12-2007, 05:49 AM
after i uninstalled it, my "what's going on" on the forum page is slanted to the right.
here's the image
http://i17.tinypic.com/4ke21sg.jpg
magnus
07-12-2007, 10:42 AM
after i uninstalled it, my "what's going on" on the forum page is slanted to the right.
here's the image
http://i17.tinypic.com/4ke21sg.jpg
This modification has absolutely no effect on the area you're having problems with whether installed or uninstalled.
baghdad4ever
07-14-2007, 08:34 PM
installed
but can i make the hack apear only to Registered Users
and doesnt apear to Unregistered
GrendelKhan{TSU
07-20-2007, 03:13 AM
weird...had the original vefsion installed on my vb3.6.0 board...
but I FINALLY got around to updating it...and so updated this as well.
problem is: for some reason the FIRST UNREAD and LAST post choices don't seem to work. FIRST post works. I want to use Last post.
:( any suggestions?
EDIT: nevermind. working now. ghost in the machine +_+ heh
raiderlax
07-23-2007, 06:03 AM
Well, off the bat, it doesn't appear you've actually installed the modification. The files jquery.js and vbulletin_vbpost.js are not present in your /clientscript/ directory. Nor are any of the associated image files located in the correct directories.
So, either you didn't install the modification correctly or you removed it. Both which prevent me from being able to find out what the problem is based off the description of "nothing shows up".
Hi, sorry, I have installed it back now, it looks like it's installed correctly, but when you go to expand it it just keeps circling and doesn't actually open it.
See on my site, thanks.
magnus
07-23-2007, 12:02 PM
Hi, sorry, I have installed it back now, it looks like it's installed correctly, but when you go to expand it it just keeps circling and doesn't actually open it.
See on my site, thanks.
The file vbpost_ajax.php is not located in your forum's root directory. When uploaded properly, it should be found at http://talkfitness.org/vbpost_ajax.php
raiderlax
07-23-2007, 06:58 PM
Wow, man thanks alot it works awesome now :)
Coldhands
08-08-2007, 04:21 PM
Is it possible to condense the clientscript/jquery.js file? Is every function in that library being used for this hack or is there a lot of fat in this code?
What functions in clientscript/jquery.js can we do without?????? I'm just sayin, 61k of js is a lot just to show the first post.
magnus
08-08-2007, 05:38 PM
Feel free to edit whatever you like from the jquery.js file. I can't distribute it if I modify it.
Coldhands
08-08-2007, 10:55 PM
I've deleted my post, in hopes of eliminating all evidence that I am in fact retarded. :tin-foil-hat:
Coldhands
08-08-2007, 11:55 PM
Feel free to edit whatever you like from the jquery.js file. I can't distribute it if I modify it.
I think you may be misinterpreting the license (http://docs.jquery.com/Licensing), not that the jquery police would be knocking on your door anytime soon. :D
JQuery offers a compressed version that you can download from the Google Gods here >> http://code.google.com/p/jqueryjs/downloads/detail?name=jquery-1.1.3.1.pack.js
jquery-1.1.3.1.pack.js works the same as the clientscript/jquery.js in the download for this hack, but it's only 1/3 the size. Just rename jquery-1.1.3.1.pack.js to jquery.js and overwrite the clientscript/jquery.js that came with this hack.
The js file in the download is made for humans to read, develop and debug; the code I linked to is for production. If you're feeling saucy, you could even trim that one down a bit. When you go through 300 gigs a month, every little bit counts.
P.S. Thanks for the great hack and quick response Magnus. :up:
mtlcore
08-09-2007, 01:09 AM
Nice hack dude.
One thing though, I install it, works fine on Default template. Doesn't show up on my custom template. Even did the template edits (turned off auto edits too). Still nothing. :(
magnus
08-09-2007, 11:00 AM
Nice hack dude.
One thing though, I install it, works fine on Default template. Doesn't show up on my custom template. Even did the template edits (turned off auto edits too). Still nothing. :(
You're probably using a custom image directory. You'll need to copy the images to that dir as well.
magnus
08-09-2007, 11:01 AM
I think you may be misinterpreting the license (http://docs.jquery.com/Licensing), not that the jquery police would be knocking on your door anytime soon. :D
JQuery offers a compressed version that you can download from the Google Gods here >> http://code.google.com/p/jqueryjs/downloads/detail?name=jquery-1.1.3.1.pack.js
jquery-1.1.3.1.pack.js works the same as the clientscript/jquery.js in the download for this hack, but it's only 1/3 the size. Just rename jquery-1.1.3.1.pack.js to jquery.js and overwrite the clientscript/jquery.js that came with this hack.
The js file in the download is made for humans to read, develop and debug; the code I linked to is for production. If you're feeling saucy, you could even trim that one down a bit. When you go through 300 gigs a month, every little bit counts.
P.S. Thanks for the great hack and quick response Magnus. :up:
I'll look at that, thanks. :)
cheekymonk3y
08-12-2007, 12:21 AM
You're probably using a custom image directory. You'll need to copy the images to that dir as well.woot, that fixed mine as well, you should change it if you can to just look in the parent image directory instead of the style's directories. :P
magnus
08-12-2007, 03:26 PM
woot, that fixed mine as well, you should change it if you can to just look in the parent image directory instead of the style's directories. :P
It properly uses the $stylevar[imgdir_{x}] variables. Changing it to anything other would cause breakage for others.
utw-Mephisto
08-18-2007, 02:06 PM
I installed it on a test forum and the "+" doesn't show .. I don't have ` custom image folder tho and I cross checked that all files are on the server :(
RaceJunkie
08-18-2007, 02:09 PM
When I do a search for new posts and the results are returned,(Don't know the actual template) I click on the + and it shows the first post instead of last. In FORUMDISPLAY when I click the + the last post is showed like it should be. I have it set to show Last post. Has this been a problem for anyone else?
Thanks for this great mod.
utw-Mephisto
08-18-2007, 02:25 PM
I installed it on a test forum and the "+" doesn't show .. I don't have ` custom image folder tho and I cross checked that all files are on the server :(
I even reverted all templates now - same problem :(
magnus
08-20-2007, 11:15 AM
I even reverted all templates now - same problem :(
Are you using the default templates?
What version of vBulletin are you using?
If you can answer yes to 1 and 3.6.x to 2, I'll need your forum URL before I can do much more.
magnus
08-20-2007, 11:16 AM
When I do a search for new posts and the results are returned,(Don't know the actual template) I click on the + and it shows the first post instead of last. In FORUMDISPLAY when I click the + the last post is showed like it should be. I have it set to show Last post. Has this been a problem for anyone else?
Thanks for this great mod.
Read through this thread. You'll find the information you're looking for.
Coldhands
08-20-2007, 04:29 PM
Okay, well, now I no longer get the error... the UserCP page loads fine... which is obviously a step in the right direction. :up:
But, unfortunately, I'm back where we started in that the expand/collapse button that appears in the title of the subscribed threads doesn't actually do anything. Clicking on it has no effect. It still works fine in the regular forum view, though.
I do also see the same thing that was mentioned earlier, with regards to spoilers and my particular spoiler BB code. When clicking on the expand/collapse button in regular forum view, if the post that is revealed has a spoiler in it, the state of that spoiler is set to "show" instead of "hide." The spoiler button works fine, mind you. It's just that it should default to "hide" the spoilerized text rather than show it... just like it appears in the regular post.
Here is my BB replacement code, if that helps any:
<div style="margin:5px 20px 20px 20px">
<div class="smallfont" style="margin-bottom:2px">
<input type="button" value="Show" style="width:50px;font-size:10px;margin:0px;padding:0px;" onclick="if (this.value=='Show') {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display = '';this.value='Hide';} else {this.parentNode.parentNode.getElementsByTagName(' div')[1].getElementsByTagName('div')[0].style.display='none'; this.value='Show';}">
</div>
<div class="alt2" style="margin: 0px; padding: 6px; border: 1px inset;">
<div style="display: none;">{param}</div>
</div>
</div>
FWIW, I am running vBulletin 3.6.4 on this particular forum.
Would it be possible for you to make me a temporary account on your forum and PM me the details? I'd like to check this out first hand if possible.
Any word on the spoiler fix? I'm having the same problem, and I don't want to use the hack until I've found a work around to the spoiler bug. A lot of my board's first posts contain spoilers due to punchlines and large amounts of text (and the occasional nsfw pic:erm:). Has anyone fixed / found a different spoiler hack that plays nice?
TIA,
C
JadedSouls
08-22-2007, 12:32 AM
I love this mod! Thank you so much...
Installed it right away..
morpheusXIIX
08-31-2007, 11:49 AM
I just updated this hack, now the +/- box shows on a black line above the thread title instead of on the same line. Any idea how to revert this?
yoyoyoyo
09-12-2007, 08:59 PM
thanks much!
Mr.Danko Jones
09-21-2007, 05:18 AM
Cool mod but it doesn't seem to be expanding on my board. See my .sig. Please let me know what I am doing wrong.:)
dethfire
09-21-2007, 11:21 AM
I put the +- icons in the column where the thread emotes should be, I think it looks and functions better. Demo at http://www.physicsforums.com
muratksk
09-21-2007, 12:40 PM
thanks :)
nnjj.net
09-21-2007, 09:02 PM
hope to see it for 3.6.8
magnus
09-22-2007, 04:26 AM
hope to see it for 3.6.8
It works fine in 3.6.8.
Trana
09-23-2007, 02:04 AM
Has anyone tried to use this hack with the latestpost module in VBA CMPS?
Mr.Danko Jones
09-28-2007, 12:45 AM
It works fine in 3.6.8.
Not for me either.
magnus
09-28-2007, 12:47 AM
Not for me either.
Can't help you if I don't know the problem.
i would to suggest integrate this awesome mod into vBAdvanced CMPS Recent Threads threadbit
/me Marks as installed and nominates for MOTM
magnus
09-28-2007, 11:05 AM
Not for me either.
After looking at your forum, it appears you haven't uploaded all the files correctly. Specifically, the file vbpost_ajax.php is missing from your forum root directory.
BIGman2
10-02-2007, 03:49 PM
Hi this is superb hack which I really need to have but I have a problem.
I installed it and when I go to the threads and click on the + Nothing happens...
Any suggestions?
magnus
10-02-2007, 05:14 PM
Hi this is superb hack which I really need to have but I have a problem.
I installed it and when I go to the threads and click on the + Nothing happens...
Any suggestions?
I would need a link to your forum in order to tell you exactly what's wrong. But, most likely it's due to the vbpost_ajax.php file not being located in your forumroot.
BIGman2
10-03-2007, 10:03 AM
My forum is turned off so it won't help you,
The vbpost_ajax.php is in the forum root...the board located in the main directory not in /forum or something else.
magnus
10-03-2007, 10:23 AM
My forum is turned off so it won't help you,
The vbpost_ajax.php is in the forum root...the board located in the main directory not in /forum or something else.
Well, sadly there's only so much I can do then. Basically, just verify that you can access the following URLs without getting a 404.
http://yoursite/vbpost_ajax.php
http://yoursite/clientscript/jquery.js
http://yoursite/clientscript/vbulletin_vbpost.js
Also, verify that you're using the default vBulletin style.. to rule out any style related issues.
bandanafz1
10-03-2007, 01:10 PM
Great Mod, many thanks... works really slick.
Only problem I have is that I have also added the Who Has Read This Post (https://vborg.vbsupport.ru/showthread.php?t=122594) mod.
If I click the thread title to view the message in full the registers the fact that the message has been read. However with the collapsible thread, this does not register the fact that the messages have been read by the user.
Most of my messages do not contain replies, it is basically a read only board for disseminating information so whilst the collapsible threads are really useful for readers, I as the admin want to see what is getting most interest.
Would it be very easy to incorporate some form of interoperability between the mods? possible switchable for those that hadn't installed the Who Has Read mod.
Many thanks... great work!
Edit> Actually did wonder if setting update read count might help but it unfortunately doesn't, presumable it is the step of open the thread view that initiates the steps to register that the user has read the message.
magnus
10-03-2007, 07:15 PM
Great Mod, many thanks... works really slick.
Only problem I have is that I have also added the Who Has Read This Post (https://vborg.vbsupport.ru/showthread.php?t=122594) mod.
If I click the thread title to view the message in full the registers the fact that the message has been read. However with the collapsible thread, this does not register the fact that the messages have been read by the user.
Most of my messages do not contain replies, it is basically a read only board for disseminating information so whilst the collapsible threads are really useful for readers, I as the admin want to see what is getting most interest.
Would it be very easy to incorporate some form of interoperability between the mods? possible switchable for those that hadn't installed the Who Has Read mod.
Many thanks... great work!
Edit> Actually did wonder if setting update read count might help but it unfortunately doesn't, presumable it is the step of open the thread view that initiates the steps to register that the user has read the message.
Keeping in mind that this untested, go ahead and try this.
In vbpost_ajax.php:
FIND
//if ($_SERVER['REQUEST_METHOD'] == 'POST' AND
if ($vbulletin->GPC['ajax'])
{
eval('print_output("' . fetch_template('vbpost_postbit') . '");');
}
else
{
eval('print_output("' . fetch_template('vbpost_postbit') . '");');
}
}
?>
Add ABOVE:
if ($vbulletin->userinfo['userid'])
{
$time = TIMENOW;
$ipaddress = IPADDRESS;
$threadid = $threadinfo[threadid];
$userid = $vbulletin->userinfo['userid'];
$db->query_write("
REPLACE INTO " . TABLE_PREFIX . "whoread
(userid, threadid, dateline, ipaddress)
VALUES
($userid, $threadid, $time, '$ipaddress')
");
}
Let me know if that works for you.
ragtek
10-03-2007, 07:38 PM
in my search the posbit images have no id's so it wount work
<img id="vbpostimg_" src="images/bgold/buttons/expand.gif" onclick="return vbpost_get()"
bandanafz1
10-03-2007, 08:52 PM
Keeping in mind that this untested, go ahead and try this.
In vbpost_ajax.php:
FIND
//if ($_SERVER['REQUEST_METHOD'] == 'POST' AND
if ($vbulletin->GPC['ajax'])
{
eval('print_output("' . fetch_template('vbpost_postbit') . '");');
}
else
{
eval('print_output("' . fetch_template('vbpost_postbit') . '");');
}
}
?>
Add ABOVE:
if ($vbulletin->userinfo['userid'])
{
$time = TIMENOW;
$ipaddress = IPADDRESS;
$threadid = $threadinfo[threadid];
$userid = $vbulletin->userinfo['userid'];
$db->query_write("
REPLACE INTO " . TABLE_PREFIX . "whoread
(userid, threadid, dateline, ipaddress)
VALUES
($userid, $threadid, $time, '$ipaddress')
");
}
Let me know if that works for you.
Many thanks, will try tomorrow when I get time.
bandanafz1
10-04-2007, 12:38 PM
Magnus,
I have tried your update and yes it now registers the read message against the user.
Many thanks for this, both your mod and the who has read mod are ideal for my board.:up:
hichew
10-17-2007, 04:35 AM
i tried this on my forum... and it's a mess.... my db server load jump to 1700 !!! :eek:
anybody use this mod and optimize the code?
i do like this mod..
my post table is 11 gig
dbembibre
10-17-2007, 10:05 AM
i tried this on my forum... and it's a mess.... my db server load jump to 1700 !!! :eek:
anybody use this mod and optimize the code?
i do like this mod..
my post table is 11 gig
I have a Big board with more than 1000 constant users and no load issues because this mod not add extra queries
The same query is run whether a user clicks on the thread and views the whole thing, or if they click on the expand icon
magnus
10-17-2007, 10:28 AM
i tried this on my forum... and it's a mess.... my db server load jump to 1700 !!! :eek:
anybody use this mod and optimize the code?
i do like this mod..
my post table is 11 gig
I couldn't have said it better than dbembibre did above me. By default, this does not add any additional load on the server.
hichew
10-17-2007, 08:25 PM
ahhh.. seems like this not the problem.
i think the "Welcome headers - Improve community registration rates" is the problem.
let me try it again, and get back to you guys.
thank you
yoyoyoyo
10-30-2007, 09:50 PM
this is not working on my new forum - I tried it with and without the automatic template edits. When I click on the + it does not open the post with ajax, it acts as if you clicked the post and takes you to the thread itself. I had it working in another forum, with pretty much all of the same mods installed and can't imagine what the conflict might be now. I double-checked and all of the files are uploaded to the proper places...
any idea where to start looking?
afmarko99
10-30-2007, 10:20 PM
Simple but so awesome. This brings a whole new way to surf my forums.
Thanks a ton.
yoyoyoyo
10-31-2007, 05:15 PM
I did some testing and on my forum this does work for guests who are not logged in, but if you are logged in and click on the + then the graphic ajax thingy starts spinning but then it takes you to the actual post. Any ideas on how to fix that?
Booost This
11-04-2007, 04:42 AM
I just installed it on my forum, followed the directions and no dice. I don't even get the (+/-) signs.
Any clue? I don't think it can be that hard to screw up the install? It said everything installed ok?
gforce75
11-04-2007, 03:18 PM
5 stars in my book! Works perfect. Demo links also check it ...
http://myffnet.com/forum/forumdisplay.php?f=127
Trana
11-23-2007, 03:23 AM
Has anybody gotten this to work in the VBA CMPS recentposts module?
Thanks!
Jaxel
11-23-2007, 05:54 AM
This mod is GREAT! But it completely kills the AJAX title editing on my forum. I cant do inline title editing with this script. The form field for the edit comes up, but when I change the title, I get a JavaScript error. It also breaks the locking mechanism... anyone else have these issues?
Newfarm
11-24-2007, 03:21 PM
Have / had the "undefined function: fetch_coventry() " issue as well, added the custom plugin that hooked into usercp. Now it doesn't crash anymore, but it doesn't work for subscribed threads either. Great little hack though :)
vitrag24
11-24-2007, 05:26 PM
does it increases loading time & load on server?
anyways,nice mod.
Jaxel
11-24-2007, 07:54 PM
ANyone who has this mod installed on their forums... would you mind checking to see if your AJAX title editing and locking is working correctly?
Mark.B
11-24-2007, 07:59 PM
ANyone who has this mod installed on their forums... would you mind checking to see if your AJAX title editing and locking is working correctly?
Yup I've been using this for many months and those features are all fine.
vitrag24
11-25-2007, 11:32 PM
does it increases loading time & load on server?
anyways,nice mod.
reply this query please.
thanks.
AWJunkies
11-28-2007, 02:39 AM
This is an awesome mod I love it. I found a place that the icon shows up but the function does not work. usercp.php file under new subscribed threads. is there a way to get this to work as well? Also if the thread is an event it grabs the first post and not the event which is technically the first post. Is there a way to fix this to work to grab event details instead of post below it?
supramati
11-28-2007, 02:51 AM
I Just loved it! Thanks a lot!
Jaxel
11-28-2007, 04:28 PM
Yup I've been using this for many months and those features are all fine.
Thats weird... I disabled all other mods on my forums and defaulted to the original templates and it still doesnt work for me.
mulesnx
12-08-2007, 07:26 AM
Has anyone got this working with vbadvanced? Is it really hard to do this?
adam75south
01-04-2008, 09:37 PM
i installed the mod on my board, but only works with the default template. the rest it doesn't hurt, but just doesn't show up. guess i'll just do the manual edit.
magnus
01-05-2008, 03:01 AM
i installed the mod on my board, but only works with the default template. the rest it doesn't hurt, but just doesn't show up. guess i'll just do the manual edit.
It's strange it didn't work on a custom template. The only way I would assume it didn't work is if the custom template is rather heavily modified. Either way, yes, manual edits would be your only option at that point. It's not really a big deal, it's a quick/simple edit.
adam75south
01-05-2008, 09:42 PM
ok my problem was the default button location for my main style was different...so i uploaded the buttons in that directory. the plus signs show up now, the post drops down....but i have an error showing up.
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
15
not really sure what that means. when i went to class_postbit.php and looked at line 15 it said "exit"
if (!isset($GLOBALS['vbulletin']->db))
{
exit;
}
the good news is it shows up in both firefox and IE and not just one of em.
i attached a screenshot for you.
any ideas would be greatly appreciated...and if it's already been addressed then i'm sorry, i jumped to the last page.
magnus
01-07-2008, 11:17 AM
ok my problem was the default button location for my main style was different...so i uploaded the buttons in that directory. the plus signs show up now, the post drops down....but i have an error showing up.
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
15
not really sure what that means. when i went to class_postbit.php and looked at line 15 it said "exit"
if (!isset($GLOBALS['vbulletin']->db))
{
exit;
}
the good news is it shows up in both firefox and IE and not just one of em.
i attached a screenshot for you.
any ideas would be greatly appreciated...and if it's already been addressed then i'm sorry, i jumped to the last page.
Ok, according to that error it's having trouble with line 296 in class_postbit.php.
($hook =& vBulletinHook::fetch_hook('postbit_display_complet e')) ? eval($hook) : false;
So it's apparently having issue with something hooked into postbit_display_complete. Thing is, my modification does not use this hook. The problem isn't directly linked to this modification, there may be a conflict issue with another hack you're using, one that modifies the postbit in some way.
In the meantime, try this. Browse to AdminCP > Collapsable First Post using AJAX Options. Look for Forum Exclusion List, in the text field put 0. Save it, and see if that fixes it. Honestly, I don't think it will, but it can't hurt.
Xeonspider
01-07-2008, 02:09 PM
Now I recived this warning but hack working...
Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(296) : eval()'d code on line 21
magnus
01-07-2008, 03:58 PM
Now I recived this warning but hack working...
Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(296) : eval()'d code on line 21
I'm sorry, but this is the first I've seen you post in this thread so I really don't know what's going on. Were you having the same problem as adam75south above?
masterweb
01-07-2008, 05:16 PM
I had some problems due my custom stile, but now it works at 100 %. Thanks a lot mate!
adam75south
01-08-2008, 04:51 PM
i tried adding the 0 but the warning is still there.
like i said, it works, just has the warning.
here's a list of all the mods i have on the board. although most were added after yours.
Add Search titles only check box 1.0.0 This mod adds Search titles only check box in search popup menu in navbar & in forumdisplay.
AJAX Preview For New/Edit Thread/Reply/PM 1.3 Shows preview of the message you are writing without leaving the page.
Collapsable First Post using AJAX 1.2.1 Adds a collapsable first post preview using AJAX for each thread on FORUMDISPLAY, search_results and USERCP_SHELL.
Group Leader PM Notification 2.1 Notify the group leader of join requests as well as inform the users of their join request status upon moderation.
GTPrivate Message Quickreply 1.0.1 Adds quickreply when viewing a private message. Brought to you by MyGTBlog Services - http://mygtblog.org.
GTPrivate Messages Enhanced Listing. Brought to yo 1.1.1 Adds private messages preview on pm list display
Latest Post on Forum Home 2.0 This will show the latest posts on forumhome
Miserable Users 2.12 A way to really annoy anyone you don't want visiting your forum.
nCode Image Resizer 1.0.1 Automatically resize posted images
One-touch Ban & Spam Cleanup 1.1 Bans a user, deletes all their threads, posts and PMs
Optimize Tables 1.0.0 This modification allows you to optimize all needed tables by a scheduled task.
passiveVid 1.1.1 Automaticlly turns video links like youtube, myspace videos, google vidoes into the video players.
ShowProfileFieldInPostBits 1.0 EMiN3M Show Profile Field In Post Bits
Yet Another Mass Private Message System 1.0.1 Allow Admin to send mass Private Message to users
Zoints: Timed Sticky 1.2.6 This hack lets you sticky threads for a certain amount of time
adam75south
01-08-2008, 06:11 PM
I just tried disabling the profile fields in postbit to see if that was the conflict but still got the warning. Do I need to completely uninstall it to see?
To the other guy with the same problem can you post your mods as well?
magnus
01-08-2008, 08:23 PM
I just tried disabling the profile fields in postbit to see if that was the conflict but still got the warning. Do I need to completely uninstall it to see?
To the other guy with the same problem can you post your mods as well?
Do you receive the error only when trying to expand/collapse using the icon, or does it also display when you click the thread to view it?
adam75south
01-08-2008, 09:00 PM
only when i expand.
if i get around to it i'll start uninstalling my mods until i find the one it's conflicting with.
and it's on all of my skins, not just my custom skin.
magnus
01-08-2008, 10:11 PM
You don't need to uninstall the hacks. Just disable. This will retain any settings, etc.
Cristi_XP
01-11-2008, 12:31 PM
I just installed it on my forum, followed the directions and no dice. I don't even get the (+/-) signs.
Any clue? I don't think it can be that hard to screw up the install? It said everything installed ok?
same thing to me ...
magnus
01-11-2008, 06:50 PM
same thing to me ...
You're most likely using a custom style with a custom image directory. Make sure you've uploaded the images to your custom image directory.
Cristi_XP
01-12-2008, 08:29 AM
you where right...that solved it ! Thank you! :)
another error when i am trying to acces usercp
Fatal error: Call to undefined function: fetch_coventry() in path/usercp.php(503) : eval()'d code on line 43
magnus
01-12-2008, 01:42 PM
you where right...that solved it ! Thank you! :)
another error when i am trying to acces usercp
Fatal error: Call to undefined function: fetch_coventry() in path/usercp.php(503) : eval()'d code on line 43
A handful of people have experienced this problem and unfortunately no one has really stuck around long enough to help resolve it. I cannot replicate this in any of my test scenarios.
First off, what version of vBulletin are you using?
Cristi_XP
01-12-2008, 02:49 PM
vbulletin 3.6.8
Mark.B
01-13-2008, 11:39 PM
I've been using this for a while and it works well, only thing I have spotted is that when enabled (either with automatic edits or manual ones), it pushes things like the attachment "paperclip" from the top of the table cell to the bottom.
Where this can look a bit of a mess is when combined with a thread rating...they get sort of squashed up together for some reason.
Using manual edits I moved the code and thought I'd cracked it, it was fine in Firefox but then the hack didn't show at all in IE so I put it back how it was.
Minor, but niggly.
magnus
01-14-2008, 01:15 PM
Automatic or manual edits are irrelevant in display issues. You can simple edit the template to make it look however you want. Look for vbpost_postbit in your templates and edit away. :P
Mark.B
01-14-2008, 03:07 PM
Automatic or manual edits are irrelevant in display issues. You can simple edit the template to make it look however you want. Look for vbpost_postbit in your templates and edit away. :P
Hi magnus.
It's not the actual postbit preview box that is the issue...it's the placing of the little "expand" image in the threadbit that's the issue. When it's there, any attachment icons get pushed down to the bottom right rather than top right, this then seems to impact on any threadrating icons by squashing them up next to everything else.
I managed to stop this happening in Firefox but then the expand icon didn't show up at all in IE on getnew/getdaily (which is where it's most needed on my site), but was still ok on forumdisplay.
As I say, it works fione, it's just altering some formatting somewhere in threadbit, and try as I might I can't work out what.
Mark.B
01-14-2008, 03:56 PM
I think I may have cracked it....the manual code needs putting in a different place.....just testing now.
magnus
01-14-2008, 07:28 PM
Ah, I think I know what you're talking about. Try adding style="display: block;" to the <img> tag displaying expand.gif.
Let me know if that fixes it.
adam75south
01-14-2008, 08:06 PM
A handful of people have experienced this problem and unfortunately no one has really stuck around long enough to help resolve it. I cannot replicate this in any of my test scenarios.
First off, what version of vBulletin are you using?
sorry, i've been busy. i'll definitely post back up if i get around to finding which mod is conflicting with this one. i've just kept it disabled for now.
i'm 3.6.8 PL2 in case i didn't add it in any of my posts above.
Trana
01-15-2008, 12:51 AM
Still no one has this working in CMPS?
Mark.B
01-19-2008, 07:08 PM
Ah, I think I know what you're talking about. Try adding style="display: block;" to the <img> tag displaying expand.gif.
Let me know if that fixes it.
Thanks...doesn't fix it though. It puts the expand.gif onto a line of it's own, seems to add a line break.
exportforce
01-27-2008, 01:09 PM
Could you please add a "next post" and "previous post" Button? So I can skip through all posts, without goin in ?
Would be awesome.
SBlueman
01-28-2008, 01:49 AM
i would to suggest integrate this awesome mod into vBAdvanced CMPS Recent Threads threadbit
* IrPr Marks as installed and nominates for MOTM
I second this and would love to see it work for the News Archive module as well.
tobias_t
01-28-2008, 04:11 PM
Sorry in case this has already been asked, but is it possibly to make it so that expanding a thread marks it as read when there is only a single post in it?
PoetJA-1975
01-30-2008, 02:12 PM
Very nice = Thanx ;)
Jacquii.
crucialjames
01-30-2008, 11:26 PM
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
15
I tried to find this error in the previous 32 posts and didn't find it. I'm using 3.6.8 and when manually and automatically trying to use this script I get this after clicking on the +
magnus
01-31-2008, 10:49 AM
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
15
I tried to find this error in the previous 32 posts and didn't find it. I'm using 3.6.8 and when manually and automatically trying to use this script I get this after clicking on the +
In AdminCP > vBulletin Options > Collapsable First Post using AJAX Options, set Forum Exclusion List to 0.
Let me know if that fixes it for you.
In AdminCP > vBulletin Options > Collapsable First Post using AJAX Options, set Forum Exclusion List to 0.
Let me know if that fixes it for you.
I have the same error. I was try to put at Forum Exclusion 0 but it's still show me that error. :(
I just noticed that if i disable this hack https://vborg.vbsupport.ru/showthread.php?t=150761 everything is working fine.
exportforce
02-02-2008, 10:19 PM
Could you please add a "next post" and "previous post" Button? So I can skip through all posts, without goin in ?
Would be awesome.
@Magnus
Could you please agree or disagree on this?
Would be awesome if you could do this :)
magnus
02-03-2008, 04:12 PM
@Magnus
Could you please agree or disagree on this?
Would be awesome if you could do this :)
I'm not sure I'm 100% clear on what you're asking for, but from what it sounds like, it sounds like you want to read the entire thread a post at a time.
Honestly, this really isn't within the scope of this modification and I can't see this being popular enough to warrant the additional coding. Sorry.
magnus
02-03-2008, 04:13 PM
I have the same error. I was try to put at Forum Exclusion 0 but it's still show me that error. :(
I just noticed that if i disable this hack https://vborg.vbsupport.ru/showthread.php?t=150761 everything is working fine.
Now we're getting somewhere! :)
Anyone else with this problem using the above (or similar) modification? We may be able to track this down..
exportforce
02-03-2008, 06:54 PM
Nope not all at a time, only post by post.
A button "Next post" and "last post" so I can go through one by one :)
baz_kingfish
02-03-2008, 07:27 PM
hmmm...downloaded this hack, uploaded the files to their respective forum directories, imported the XML, went to AdminCP and set options as follows: Display Post = FirstPost, Update Views = YES, Exclusions = NULL (tried 0 as well), and Automatic Template update = YES.
Go into forum and plus/minus signs are there next to the threads, and on some threads when I click the +/- it expands and colapses perfectly, and on other threads I get a little spinning RED arrow, and still on other threads I get NADA?
Just checked in UserCP and get the same type of things...some work, some red circle, some NOTHING.
Using vB version 3.6.8 with default styles...:confused: Please help.
Other plugins and products installed are as follows: (in relative order installed)
Post Thank You Hack - https://vborg.vbsupport.ru/showthread.php?t=165673
Default Avatar thread - http://www.vbulletin.com/forum/showthread.php?p=1499414#post1499414
PM Button On Postbit - https://vborg.vbsupport.ru/showthread.php?t=100822&highlight=SendPM
Just Joined Product Add-on - https://vborg.vbsupport.ru/showthread.php?t=168748&highlight=default+avatar&page=2
Row Mouse Over - https://vborg.vbsupport.ru/showthread.php?t=150148&highlight=rowmOVA
Collapsible First Post - https://vborg.vbsupport.ru/showthread.php?p=1435585&posted=1#post1435585
Welcome Headers - https://vborg.vbsupport.ru/showthread.php?t=119572&highlight=addon
Thanks,
KF
magnus
02-04-2008, 01:23 AM
hmmm...downloaded this hack, uploaded the files to their respective forum directories, imported the XML, went to AdminCP and set options as follows: Display Post = FirstPost, Update Views = YES, Exclusions = NULL (tried 0 as well), and Automatic Template update = YES.
Go into forum and plus/minus signs are there next to the threads, and on some threads when I click the +/- it expands and colapses perfectly, and on other threads I get a little spinning RED arrow, and still on other threads I get NADA?
Just checked in UserCP and get the same type of things...some work, some red circle, some NOTHING.
Using vB version 3.6.8 with default styles...:confused: Please help.
Other plugins and products installed are as follows: (in relative order installed)
Post Thank You Hack - https://vborg.vbsupport.ru/showthread.php?t=165673
Default Avatar thread - http://www.vbulletin.com/forum/showthread.php?p=1499414#post1499414
PM Button On Postbit - https://vborg.vbsupport.ru/showthread.php?t=100822&highlight=SendPM
Just Joined Product Add-on - https://vborg.vbsupport.ru/showthread.php?t=168748&highlight=default+avatar&page=2
Row Mouse Over - https://vborg.vbsupport.ru/showthread.php?t=150148&highlight=rowmOVA
Collapsible First Post - https://vborg.vbsupport.ru/showthread.php?p=1435585&posted=1#post1435585
Welcome Headers - https://vborg.vbsupport.ru/showthread.php?t=119572&highlight=addon
Thanks,
KF
I'm willing to bet the Post Thank You hack is conflicting. Try setting that modification to disabled (no need to uninstall it). Let me know if that fixes it.
exportforce
02-04-2008, 09:14 AM
thx-mod is not conflicting, have it too :)
baz_kingfish
02-04-2008, 01:06 PM
Magnus,
Thank your for responding. Exportforce is correct, disabling the TY hack did not fix the problem. But I do have more info for you to consider. We migrated our forum to vB from Snitz using the vB import tools. I got to wondering if somehow the posts that were migrated somehow got set to the same time stamp or something and your hack possibly could not tell which one was first. So, I went into the AdminCP and changed the Hack setting to "Last Post", and everything works fine!!! I set it to "First Unread Post" and again, works fine. But when I changed it back to "First Post", the intermitent working/non-working problem I described in my post above occurred again.
The good news: I can leave it on "Last Post" without confusing my users.
The bad news: There is still a Gremlin! :(
I hope this additional information helps you identify the problem as this is a terrific feature! :up:Thanks,
KF
magnus
02-04-2008, 03:47 PM
Magnus,
Thank your for responding. Exportforce is correct, disabling the TY hack did not fix the problem. But I do have more info for you to consider. We migrated our forum to vB from Snitz using the vB import tools. I got to wondering if somehow the posts that were migrated somehow got set to the same time stamp or something and your hack possibly could not tell which one was first. So, I went into the AdminCP and changed the Hack setting to "Last Post", and everything works fine!!! I set it to "First Unread Post" and again, works fine. But when I changed it back to "First Post", the intermitent working/non-working problem I described in my post above occurred again.
The good news: I can leave it on "Last Post" without confusing my users.
The bad news: There is still a Gremlin! :(
I hope this additional information helps you identify the problem as this is a terrific feature! :up:Thanks,
KF
Hrm.. that is very strange. Have you tried rebuilding your counters?
AdminCP > Maintenance > Update Counters
Try rebuilding anything having to do with threads/posts.
It's odd that, of all things, the default behaviour is the one acting up..
baz_kingfish
02-04-2008, 04:45 PM
That did it! :up: Not sure which one :D...but I ran all of the counter/rebuild updates for threads, forums, and posts. The only issue now is dealing with the members being disappointed about their Post Count being reduced. yeah, I know I can hard plug them in, but they'll just get wiped out the next time I have to rebuild!
Magnus,
I know there have been alot of post regarding "First Post" vs "Last Post" which is why I am sure you put the option in the AdminCP, but I've got an idea about that. What if your hack provided for the + sign on the left to show the "First Post/First Unread", and then somehow get the little arrow icon in the "Last Post" field/box to the right side of the thread name to perform the EXACT same functionality, but show the "Last Post". This would allow the user to view BOTH before entering into the thread. vB is already showing the last post in that field, it just needs to somehow get thrown into your hack display table on click. Then you could simply provide a "GoTo" button if they wanted to go to the last post like is currently the case when you quick that little blue arrow.
Just a thought...is that possible?
I love the hack..donation is forthcoming...
KF
magnus
02-04-2008, 06:53 PM
That did it! :up: Not sure which one :D...but I ran all of the counter/rebuild updates for threads, forums, and posts. The only issue now is dealing with the members being disappointed about their Post Count being reduced. yeah, I know I can hard plug them in, but they'll just get wiped out the next time I have to rebuild!
Glad it turned out to be something simple! :)
Magnus,
I know there have been alot of post regarding "First Post" vs "Last Post" which is why I am sure you put the option in the AdminCP, but I've got an idea about that. What if your hack provided for the + sign on the left to show the "First Post/First Unread", and then somehow get the little arrow icon in the "Last Post" field/box to the right side of the thread name to perform the EXACT same functionality, but show the "Last Post". This would allow the user to view BOTH before entering into the thread. vB is already showing the last post in that field, it just needs to somehow get thrown into your hack display table on click. Then you could simply provide a "GoTo" button if they wanted to go to the last post like is currently the case when you quick that little blue arrow.
That's not a bad idea, I'll look into that.
I appreciate the donation, thank you. ;)
baz_kingfish
02-04-2008, 07:17 PM
np.
It's a great function you created, and I know you have put alot of work into supporting it and making it even better. I'll donate again when you implement my suggestion! :D Please email me if you get it working and upload an update.
Cheers,
KF
haris_led
02-06-2008, 05:47 AM
Now we're getting somewhere! :)
Anyone else with this problem using the above (or similar) modification? We may be able to track this down..
i have the same problem. when passivevid is enabled, i get
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
39
:(
binevi
02-11-2008, 10:52 PM
Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(296) : eval()'d code on line 209
unfortunately i got same problem too
im using vb. 3.7
falguni1
02-12-2008, 05:36 AM
very nice mod.
falguni1
02-12-2008, 05:37 AM
can you make for 3.7 beta3 and 4.
Kiint
02-12-2008, 09:29 AM
Just installed this on version 3.6.8, love the search functionality that's a great idea and love how you can select which forums you want this to appear in.
*Clicked Installed*
I'm currently asking my users if they want to keep this functionality and to which view they would prefer (opened a poll) I'm sure they will want to keep it even if it's just for the search results.
Installation went like a dream, uploaded files, ran xml file, configured through options, worked first time....but with one little problem of the images not showing....had to copy the button images to my custom style folder (error on my part, but may want to clarify that for beginners).
Thanks for a great mod.
binevi
02-12-2008, 06:02 PM
can you make for 3.7 beta3 and 4.
i've installed that mods to my forum( im using 3.7.4). But as i said i hade an error only. but it works normally except that
magnus
02-12-2008, 09:55 PM
The foreach() error experienced by a few seems to be related to various YouTube (and other video site) embedding hacks. I, personally, do not use any hacks with this functionality -- however, now that we've found a common link, I'll install one of the known offenders into my sandbox and see if I can replicate/fix the error.
magnus
02-14-2008, 02:42 PM
i have the same problem. when passivevid is enabled, i get
Warning
: Invalid argument supplied for foreach() in
/includes/class_postbit.php(296) : eval()'d code
on line
39
:(
Ok, here's a fix. This is for passiveVid - (YouTube, Myspace, Google...) Not BBCODE :D (https://vborg.vbsupport.ru/showthread.php?t=150761) users ONLY.
In AdminCP > Plugins & Products > Plugin Manager, look for passiveVid - Showthread Replacement under Product : passiveVid and select [Edit].
FIND:
foreach ($passiveVid as $k => $v) {
if ( $this->registry->options['passiveVid_sites'] & $v['id'] ) {
$this->post['message'] = preg_replace_callback($v['string'],create_function('$matches',$v['replacement']),$this->post['message']);
}
}
REPLACE WITH:
if ($passiveVid) {
foreach ($passiveVid as $k => $v) {
if ( $this->registry->options['passiveVid_sites'] & $v['id'] ) {
$this->post['message'] = preg_replace_callback($v['string'],create_function('$matches',$v['replacement']),$this->post['message']);
}
}
}
Disclaimer:
Note that this was tested on my development board. I do not actively use passiveVid (or any video embedding tools) so I cannot be held responsible for any undesired effects that may occur as a result of making these changes.
That being said, the changes simply check for the existence of a variable. There are no destructive functions being added or implemented, however, I just like to cover my rear. :)
Bubble #5
02-14-2008, 07:29 PM
Looking forward to a 3.7 compatible version :up:
magnus
02-14-2008, 08:59 PM
Have you tested it with 3.7? I had reports of it working fine. I, personally, do not use 3.7 nor do I have a sandbox for it (yet). I generally wait for RC/Gold/Final versions before porting things over.
Mark.B
02-14-2008, 09:48 PM
Have you tested it with 3.7? I had reports of it working fine. I, personally, do not use 3.7 nor do I have a sandbox for it (yet). I generally wait for RC/Gold/Final versions before porting things over.
I have it on 3.7 Magnus, and it seems to be ok.
young coder
02-21-2008, 08:30 AM
hi
Thanks for this great product
I want to know how to make it expand by Default and click the collapse icon to collapse
I want to invert the usage simple i want the usage to be
click the collapse icon [-] to collapse , and the expand icon [+] in front of the thread title to expand
beduino
02-25-2008, 12:41 PM
Fine support :)
tks
joao barroca
aka beduino
Ok, here's a fix. This is for passiveVid - (YouTube, Myspace, Google...) Not BBCODE :D (https://vborg.vbsupport.ru/showthread.php?t=150761) users ONLY.
In AdminCP > Plugins & Products > Plugin Manager, look for passiveVid - Showthread Replacement under Product : passiveVid and select [Edit].
FIND:
foreach ($passiveVid as $k => $v) {
if ( $this->registry->options['passiveVid_sites'] & $v['id'] ) {
$this->post['message'] = preg_replace_callback($v['string'],create_function('$matches',$v['replacement']),$this->post['message']);
}
}
REPLACE WITH:
if ($passiveVid) {
foreach ($passiveVid as $k => $v) {
if ( $this->registry->options['passiveVid_sites'] & $v['id'] ) {
$this->post['message'] = preg_replace_callback($v['string'],create_function('$matches',$v['replacement']),$this->post['message']);
}
}
}
Disclaimer:
Note that this was tested on my development board. I do not actively use passiveVid (or any video embedding tools) so I cannot be held responsible for any undesired effects that may occur as a result of making these changes.
That being said, the changes simply check for the existence of a variable. There are no destructive functions being added or implemented, however, I just like to cover my rear. :)
inciarco
03-01-2008, 08:30 PM
Hello.
I have Installed this Mod in vB 3.6.7 PL1 and Works Ok and also don't Interfere with other Mods.
I've Found what seems to be a Bug of this Mod in vB 3.6.8 PL2:
When seeing the FORUMDISPLAY Template, this Mod Interferes with the AJAX Functionality of other Mods such as MGC ChatBox EVO, Mood Manager, and Even with the AJAX Functionality of vBulletin in the Matter of Editing the Titles of the Threads directly in the FORUMDISPLAY View (If You're Moderator or Administrator, if You Double Click on the Title of the Thread listed in this View, the Cell will Turn into a TextBox were You can Edit the Title and the Press Enter to Apply the Changes); all of this Mods and Other AJAX Functionalities different than this Mod ones, will Not Function and will Create an Error Page Message quietly Displayed in the Status Bar of the Internet Explorer Navigator!! :confused: :(
When Disabling this Mod all AJAX Functionalities of the Other Mods and of vBulletin in this Template View return to Normal, so the Code Error is in This Mod!! :rolleyes:
Once I Detected a Similar Error in other Mod, and was Because of the JavaScript File that Served the Purposes of that other Mod, so the JavaScript Files of this Mode are Perhaps the First Source the Coders Should Check to Correct this Bug!! :rolleyes:
Check that Solution in: "Ajax Fisheye Menu (https://vborg.vbsupport.ru/showthread.php?p=1375877#post1375877)", perhaps it could Help.
Would be Nice that other Forumers that Use this Mod in vB 3.6.8 PL2, and of course the Author magnus, could Confirm if this Error is also Happening in their Boards; other possible source for the Error (perhaps in Addition with the Java Script Files), could be in the Plugins interfering with one or more of the other Mods affecting also the AJAX Functionality of vBulletin that I mentioned!! :rolleyes:
I Hope You Can Fix this Problem. I had to Disable this Mod in my vB 3.6.8 PL2 Board, because I had to Choose between the Great Features of it and the Other Mods and Even the AJAX Functionality of Editing the Titles of the Threads Fast!! :(
My Best Regards!! ;)
:)
magnus
03-01-2008, 09:41 PM
Hello.
I have Installed this Mod in vB 3.6.7 PL1 and Works Ok and also don't Interfere with other Mods.
I've Found what seems to be a Bug of this Mod in vB 3.6.8 PL2:
When seeing the FORUMDISPLAY Template, this Mod Interferes with the AJAX Functionality of other Mods such as MGC ChatBox EVO, Mood Manager, and Even with the AJAX Functionality of vBulletin in the Matter of Editing the Titles of the Threads directly in the FORUMDISPLAY View (If You're Moderator or Administrator, if You Double Click on the Title of the Thread listed in this View, the Cell will Turn into a TextBox were You can Edit the Title and the Press Enter to Apply the Changes); all of this Mods and Other AJAX Functionalities different than this Mod ones, will Not Function and will Create an Error Page Message quietly Displayed in the Status Bar of the Internet Explorer Navigator!! :confused: :(
When Disabling this Mod all AJAX Functionalities of the Other Mods and of vBulletin in this Template View return to Normal, so the Code Error is in This Mod!! :rolleyes:
Once I Detected a Similar Error in other Mod, and was Because of the JavaScript File that Served the Purposes of that other Mod, so the JavaScript Files of this Mode are Perhaps the First Source the Coders Should Check to Correct this Bug!! :rolleyes:
Check that Solution in: "Ajax Fisheye Menu (https://vborg.vbsupport.ru/showthread.php?p=1375877#post1375877)", perhaps it could Help.
Would be Nice that other Forumers that Use this Mod in vB 3.6.8 PL2, and of course the Author magnus, could Confirm if this Error is also Happening in their Boards; other possible source for the Error (perhaps in Addition with the Java Script Files), could be in the Plugins interfering with one or more of the other Mods affecting also the AJAX Functionality of vBulletin that I mentioned!! :rolleyes:
I Hope You Can Fix this Problem. I had to Disable this Mod in my vB 3.6.8 PL2 Board, because I had to Choose between the Great Features of it and the Other Mods and Even the AJAX Functionality of Editing the Titles of the Threads Fast!! :(
My Best Regards!! ;)
:)
I'm sorry, but I cannot seem to replicate this action. I have absolutely no problems whatsoever with any default AJAX functionality while having this modification enabled.
All testing was done on vBulletin 3.6.8 PL2.
It's entirely possible that there's a conflict with another modification, but unfortunately, it's extremely difficult for me to track that down as it's a guarantee that we do not use the same modifications. The only modification used on my forum not coded by myself is vBSEO.
inciarco
03-01-2008, 11:33 PM
I'm sorry, but I cannot seem to replicate this action. I have absolutely no problems whatsoever with any default AJAX functionality while having this modification enabled.
All testing was done on vBulletin 3.6.8 PL2.
It's entirely possible that there's a conflict with another modification, but unfortunately, it's extremely difficult for me to track that down as it's a guarantee that we do not use the same modifications. The only modification used on my forum not coded by myself is vBSEO.
OK. I Appreciate Your Help. If I Get it to Work by Making Tests on Changing the Plugins, I'll Share the Answers With You!! ;)
What Really Worries and Confuses me, is that I Have Installed in my vb 3.6.8 PL2 Forum almost All the Mods I've Installed in my vB 3.6.7 PL1 Forum (were the Mod is Working without a Problem)!! :confused: :(
My Best Regards!! ;)
:)
dethfire
03-03-2008, 03:22 PM
Will there be any new developments?
magnus
03-03-2008, 04:24 PM
Will there be any new developments?
.. as in? Everything works.
vBulletin® v3.8.12 by vBS, Copyright ©2000-2025, vBulletin Solutions Inc.