Add-On Releases - CES Site News [Archive]

thincom2000

01-23-2007, 10:00 PM

CES Site News
Version: 1.6.3
vBulletin 3.7.x, 3.8.x supported

*** NEWS ***
5/15/2008 - v1.6.3 released
5/5/2008 - v1.6.2 released
5/2/2008 - v1.6.1 released
4/17/2008 - v1.6.0 released
11/7/2007 - v1.5.1 released
9/9/2007 - v1.5.0 released
4/12/2007 - v1.4.1 released
4/5/2007 - v1.4.0 released
4/1/2007 - 4/2/2007 - v1.3.1 through v1.3.2 released
3/30/2007 - v1.3.0 released
3/23/2007 - 3/26/2007 - v1.2.0 through v1.2.4 released
3/14/2007 - v1.1.1 released
3/12/2007 - v1.1.0 released
2/9/2007 - v1.0.8 released
1/29/2007 - v1.0.7 released
1/23/2007 - 1/27/2007 - v1.0.0 through v1.0.6 released

Known Issues:
- none

What It Does:
This allows you to turn one of your forums into a news blog.

Live Installation: http://www.crackedeggstudios.com/news.php
This site is usually an update or two ahead of what's available in this thread, because that's where we do all our testing.

Products to Install: 1
Plugins Included: 14
Files to Upload: 7
Files to Edit: 0
New Templates: 8
Template Edits: 0

Mod Features:
- adds options to the Forum Manager
- uses forum permissions
- threads in the given forum become articles
- pull articles from other forums
- full-text articles are displayed in a customized forumdisplay
- post replies are added as comments
- set number of articles and comments per page
- turn on/off announcements in news display
- turn on/off attachments in news display
- turn on/off last comment in news display
- ajax quick edit in news display (basically, quick edit in forum display)
- display articles on every comments page
- limit size of article preview
- additional BB-Code tags for articles

BB-Code Tags:
value
Placing this anywhere in an article overrides the preview limit for that article only. Multiple tags are cumulative. A "Read More..." link will appear if this tag is used.

[preview]value
Placing this anywhere in an article defines text that will only show on Newsdisplay. Text contained in this tag completely replaces the post text on Newsdisplay. Multiple [preview] tags are cumulative. A "Read More..." link will appear if this tag is used.

value
Placing this anywhere in an article defines text that will only show on Shownews. Text contained in this tag does not replace the post text on Shownews. It only hides text from Newsdisplay.

*** Changelog ***
As of Version 1.6.3:
- bug fix: preview functions do nothing since alias support added
- bug fix: preview functions never worked on editpost or newthread
- bug fix: inconsistent postbit after quick edit
- updated files: news.php, shownews.php, ces_news_bbcode.php,
ces_news_quick_edit.js

As of Version 1.6.2:
- bug fix: more database errors in vB 3.6.x
- bug fix: post controls hide on news display in IE7
- bug fix: threadbit and postbit widths inconsistent
- updated templates: ces_news_postbit, ces_news_threadbit
- updated files: shownews.php

*** Screenshots ***
1. New Forum Manager Option
2. Site News Settings
3. News Articles (forumdisplay)
4. Comments (showthread)

vspro

01-24-2007, 02:06 AM

why?
I want download file it. and I want see demo

thincom2000

01-24-2007, 02:13 AM

I'll upload screenshots in a few minutes :D

TheBlackPoet

01-24-2007, 02:26 AM

i must be using 3.62? or 3 ... it wont let me install.. other hacks i can still install, but this one is being a skank.... i'd like to check it out, if you code it to accept my settingss

thincom2000

01-24-2007, 02:35 AM

Okay, I didn't think people would be PREVENTED from installing it if they had lower, I will downgrade the version requirement to 3.6.0 for the next update. I already found an annoying visual error with the SHOWNEWS template, so it will be soon!

Invalid ID

01-24-2007, 02:58 AM

Waiting for the Demo :)

P.Jackson

01-24-2007, 08:22 AM

Same :)

beduino

01-24-2007, 08:24 AM

Looks great :) Waiting for the changes.
Beduino

Staxed

01-24-2007, 10:59 AM

sounds interesting....how are those screenshots and demo coming along??

vspro

01-24-2007, 11:55 AM

it not pro.
But I like it

Brandon Sheley

01-24-2007, 03:14 PM

demo please :)
sounds interesting

dlee

01-24-2007, 03:18 PM

Demo and I'll install!

Qwest

01-24-2007, 06:00 PM

I highly recommend you integrate this hack (https://vborg.vbsupport.ru/showthread.php?t=108222) into it so it updates all the services to give you the blog and ping effect ;)

nonamer69

01-24-2007, 06:50 PM

what is CES?

gersforum@gmail

01-24-2007, 07:04 PM

Demo?

tteal

01-24-2007, 07:50 PM

Demo? Screen shot?

trancetopia

01-24-2007, 08:18 PM

Ok i've installed this on my forum but if I choose any forum to be a news forum, I get a page 404 error. I turn the news system off for the forum and it works again.

I'm interested to see what this is supposed to do.

Any idea why i'd get a 404 on any forum this is activated for?

Thanks

trancetopia

01-24-2007, 08:29 PM

Oops didn't upload the news.php file.

I get the following error when trying to view the "news activated" forum:

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT user.avatarid, user.avatarrevision, avatarpath, NOT ISNULL(customavatar.userid) AS hascustom, customavatar.dateline,
customavatar.width, customavatar.height
FROM user AS user
LEFT JOIN avatar AS avatar ON avatar.avatarid = user.avatarid
LEFT JOIN customavatar AS customavatar ON customavatar.userid = user.userid
WHERE user.userid =;

MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 6

thincom2000

01-24-2007, 09:58 PM

I highly recommend you integrate this hack (https://vborg.vbsupport.ru/showthread.php?t=108222) into it so it updates all the services to give you the blog and ping effect ;)

If that hack already automatically updates services when a new thread or post is created, it should require no integration.

Oops didn't upload the news.php file.

I get the following error when trying to view the "news activated" forum

Please give me a little more information. The SQL error was good, but where was the link you clicked for example?

Mr_Snob

01-25-2007, 12:07 AM

dont work for me.
when i click like sitename.com/news.php?f=2 its give error
Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT user.avatarid, user.avatarrevision, avatarpath, NOT ISNULL(customavatar.userid) AS hascustom, customavatar.dateline,
customavatar.width, customavatar.height
FROM user AS user
LEFT JOIN avatar AS avatar ON avatar.avatarid = user.avatarid
LEFT JOIN customavatar AS customavatar ON customavatar.userid = user.userid
WHERE user.userid =;

MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 6
Error Number : 1064

thincom2000

01-25-2007, 12:13 AM

I cannot replicate this error on my installation.

Also that SQL code is not mine. What products do you have installed that use forumdisplay hooks?

Mr_Snob

01-25-2007, 12:15 AM

I cannot replicate this error on my installation.

Also that SQL code is not mine. What products do you have installed that use forumdisplay hooks?

(Hook) : forumdisplay_complete

Forum Display Stats Cache Serialized
Separate Sticky and Normal Threads
Zoints Thread Tags (Forum display)

(Hook) : forumdisplay_start

Cyb - Sticky-Closed-Poll Prefixes
Do not show who's online for guests (2/3)
Echo the Javascript Inline Subscription Management
Forum Statistics (2)
Separate Sticky and Normal Threads
thread visitor counts

thincom2000

01-25-2007, 12:24 AM

Please list the products. Some of those are plugin names and I can't find them on here without knowing the product.

Or we can save some time if you feel comfortable giving me a temp admin account to figure out what plugin is causing the error.

trancetopia

01-25-2007, 07:17 AM

Ok - i've found what is causing the avatar query problem for me at least. It's the avatar thread mod that puts the avartar of the thread starter next to the thread title in forumdisplay.

trancetopia

01-25-2007, 07:24 AM

I have found a little bug. The link for the post icon for the thread is broken. Here is what it's trying to display:

http://www.littlewales.com/images/greenfox/statusicon/post_.gif

You can see it here:

http://www.littlewales.com/news.php?f=202

thincom2000

01-25-2007, 04:33 PM

Thanks. That little bug was actually on a low priority but I have fixed it for the next update. ;)

trancetopia

01-25-2007, 06:19 PM

Thanks. That little bug was actually on a low priority but I have fixed it for the next update. ;)
Excellent - many thanks.

I've just found another little problem. If you take a look at the same thread/forum:

http://www.littlewales.com/news.php?f=202

I've attached an image but I think the formatting is missing a </tr><tr> somewhere.

trancetopia

01-25-2007, 06:25 PM

I'd also like to make a request - hope you don't mind.

Would it possible to have an option at forum level to select to display attachements or not.

And here is why:

I have some custom image positioning bbcode so I can really make the news article stand out. I'd like to attach the images I want to use with the thread and use them positioned within the post so having the ability to hide what is attached would really enhance the appearance of the article.

Would this be possible?

Thanks.

thincom2000

01-25-2007, 08:35 PM

Sure that should be simple, just adding another setting. Will be in the next update.

I've just found another little problem. If you take a look at the same thread/forum:

http://www.littlewales.com/news.php?f=202

I've attached an image but I think the formatting is missing a </tr><tr> somewhere.

I'm not seeing the image in your forum level. Please note that html, bbcode, img code, and smilies are not being parsed on the forum level in version 1.0.1 (I have fixed this in the next update).

Also, I get a 404 when I try to view the thread, and session data is appearing in your sites URLs (this should be a problem elsewhere). Have you uploaded shownews.php?

EDIT: Seems to be working now. Thanks for pointing this out.

thincom2000

01-26-2007, 05:50 PM

If anyone has found any more bugs, please report them so I can include them in the next update later tonight. :rolleyes:

trancetopia

01-26-2007, 07:59 PM

I've haven't noticed anything after the last update.

Would there be any chance of adding the option to hide the attachements only when viewing the article?

thincom2000

01-27-2007, 12:07 AM

Do you mean on the Comments page?

There is already the option to hide attachments at the forum level.

trancetopia

01-27-2007, 07:44 AM

Oh yes - i've only just noticed the new option - brilliant! Thanks.

I'm not sure if this is working but please correct me if i'm wrong. I have the new option chosen but looking at the same link I posted previously:

http://www.littlewales.com/news.php?f=202

The thumbnail area is still visible for the article.

thincom2000

01-27-2007, 02:27 PM

It is working fine on my installation. Please make sure you have reverted the templates and uploaded the newest version of news.php.

Also note that "yes" shows the attachments on NEWSDISPLAY while "no" hides them.

thincom2000

01-28-2007, 03:47 AM

*bump*

Just bringing this to the top of list again because the new version is much much better than the previous one, in terms of performance at least. :D

TheMilkCarton

01-28-2007, 08:40 AM

I'm not sure why, but when I upload everything and install the product, it keeps trying to access mydomain/news.php instead of mydomain/forums/news.php like it should be.....

Is this a bug in your code? Everything was obviously installed right.. the install was very simple.

I mean, I even put a copy of news.php and shownews.php in the site root despite what your instructions say to do, and I just get a bunch of PHP errors.

Am I missing something?

thincom2000

01-28-2007, 11:43 PM

You're right. This was a bug in the code. Thanks for reporting this, I will include it in the next update.

TheMilkCarton

01-28-2007, 11:56 PM

That's sad to hear. I was hoping it was my fault. :)

Is there any straightforward way of fixing it? I'd really like to try the system out.

thincom2000

01-29-2007, 10:09 AM

I was just surprised no one had noticed it earlier.

Also a little surprised because the files were originally copies of unmodified forumdisplay.php and showthread.php (now quite modified), did you have to change those?

thincom2000

01-31-2007, 03:00 AM

*bump*

I've made some very slight updates to the mod again. I would have released 1.0.8 already, but I would really like some more input for more features, any bugs I've missed, etc. before releasing such a minor update.

TheMilkCarton

02-05-2007, 02:33 PM

Still doesn't work.

It still tries accessing "mydomain.com/news.php" instead of "mydomain.com/forums/news.php"

It works now if I manually enter "mydomain.com/forums/news.php" into my browser. But there are lots of graphical errors. "Posted by:" and "Comments:" use an Alt1 or Alt2 style, but they're on a thead style background, so it's unreadable.

When I click on Comments to view the thread it sends me to "mydomain.com/shownews.php?t=24" for example, instead of "mydomain.com/forums/shownews.php?t=24". So I manually enter the "forums" into the URL and is has the same graphical errors. "Posted by:" "Comments:" etc. are unreadable.

Also, in shownews.php it says "Comments:2" on every single post, and it shouldn't really say it at all, only on news.php.

When viewing news.php, your hack is incompatible with Allow Usergroups to Post HTML (https://vborg.vbsupport.ru/showthread.php?t=96926) hack. I have it set up so that admins can post HTML in any forum they want, but HTML doesn't parse when viewing news.php.

Sorry, I'm uninstalling this because it's not usable at all. It at least works this time around, though. I tried it a week ago with no luck. At least you're making progress!

Good luck.

RFViet

02-05-2007, 02:44 PM

installed, just for future use !!!

thincom2000

02-05-2007, 09:49 PM

TheMilkCarton, sorry nothing worked for you. All of the features you mentioned not working on your forum work without fail on mine. However it is unlikely this is all due to conflicts with other products. The only reason I can think that your pages still weren't forwarding properly was because you don't have $vboptions[bburl] properly set in your AdminCP.

As for not parsing HTML, HTML does indeed parse if the forum allows - this may also be a result of not having your bburl properly set. I am unfamiliar with the hack of which you speak, but news.php uses forumdisplay hooks rather than showthread/postbit hooks, so the hack would need to be tweaked to work correctly with it. You may not know this, but that hack is a 3.5.x hack (this is a 3.6.x addon), and in 3.6.0, vBulletin Usergroup Permissions include an option to allow HTML by default.

As for the comment numbers appearing on every single page... well, that just shouldn't be happening. Sounds like you were using either v1.0.5 or earlier shownews.php with a v1.0.7 product installed (a number of plugins were hardcoded since then), or you were using showthread.php somehow.

Your readability issues just have to do with your forum's style. In my forum, it's possible to mix and match classes quite easily. You may have had to do some manual tweaking with the <span> tags.

Sorry, I'm uninstalling this because it's not usable at all. It at least works this time around, though. I tried it a week ago with no luck. At least you're making progress!

Speaking of making progress, I think this mod is as complete as it's going to get. There have been no confirmed bugs since the last release, and there's actually a lot you can do with it. It's unfortunate that you had to uninstall.

In a few days I was going to release a Download Forum mod that was basically just an extension of this with the word "Article" changed to "Download" and a few interface changes.

TheMilkCarton

02-06-2007, 05:23 PM

You're right. This was a bug in the code. Thanks for reporting this, I will include it in the next update.
You confirmed that this was in fact a bug, but now you're saying I don't have $vboptions[bburl] set properly? Everything is set fine.

As for not parsing HTML, HTML does indeed parse if the forum allows - this may also be a result of not having your bburl properly set. I am unfamiliar with the hack of which you speak, but news.php uses forumdisplay hooks rather than showthread/postbit hooks, so the hack would need to be tweaked to work correctly with it.
This seems to be the problem. However, I'm not sure there would be any reason to tweak the HTML hack to display HTML in forumdisplay, since the only use would be for your hack. Can't you incorporate the showthread hooks into news.php?? As for shownews.php using showthread AND postbit hooks... The actual posts do NOT have postbits when viewing replies in shownews.php and was wondering if this was intentional?? It makes it very hard to see who posted the reply as there is only a very small "Posted By" in the top of the post (which ends up being unreadable white text on a white background), instead of a very large Username and Avatar in the postbit.

You may not know this, but that hack is a 3.5.x hack (this is a 3.6.x addon), and in 3.6.0, vBulletin Usergroup Permissions include an option to allow HTML by default.
I'm running 3.6.4 and the only options for HTML in Usergroup Permissions is under "Signatures". The HTML hack I'm using is still very much needed to enforce HTML permissions per Usergroup.

As for the comment numbers appearing on every single page... well, that just shouldn't be happening. Sounds like you were using either v1.0.5 or earlier shownews.php with a v1.0.7 product installed (a number of plugins were hardcoded since then), or you were using showthread.php somehow.
Wrong again. I completely uninstalled and re-downloaded and installed your hack after you posted about a "small update" a few days ago. The small update at least got it running on my forums, since it didn't work at all before.

Your readability issues just have to do with your forum's style. In my forum, it's possible to mix and match classes quite easily. You may have had to do some manual tweaking with the <span> tags.
Uh, well.. if you're releasing a hack, you might want to make it so that it works on others' forums.. not just yours. That's why I've been posting in this thread letting you know all the problems I've been having. In shownews.php, there's no logic in having Alt1 text in a Thead table cell, it should all just be one or the other.

Sorry if this post is coming across as harsh.. I had posted several days ago about a few of these problems and you had admitted there was a bug and that a fix was on the way, but now you're saying there's absolutely nothing wrong with your hack and it's all my fault, so what gives?

You wanted feedback and I gave it. Instead of first dismissing my bugs as user error, could you please look into it? Just because I have a low postcount and just recently joined doesn't mean I'm incompetent. Your hack didn't even work on my forum until your most recent update, so is it out of the realm of possibility that your product still has bugs?? I have a working forum with a non-working hack, and that's confirmed enough for me.

I apologize in advance for the tone of this post. It's probably coming across more harsh than I mean it to.

thincom2000

02-07-2007, 05:01 PM

The bug I confirmed was that some redirects used $vboptions[bburl] while others did not. I thus changed all the redirects to match. The paths are not hardcoded, so the only way you would still have redirect issues is if news.php and shownews.php are not in the $vboptions[bburl] directory as you have it set.

The actual posts do NOT have postbits when viewing replies in shownews.php and was wondering if this was intentional?? It makes it very hard to see who posted the reply as there is only a very small "Posted By" in the top of the post (which ends up being unreadable white text on a white background), instead of a very large Username and Avatar in the postbit.

What you are describing is the template for the article being used on the rest of the comments. This should not be happening since the posts SHOULD have their own postbits, however, if you are not missing any plugins, it may be the result of a postbit check the script runs (that I have removed for 1.0.8) even though this did not cause any problems during testing.

In shownews.php find the line:
$lastcheck = ($lastfetchtype == $fetchtype) ? true : false;

and change it to:
// $lastcheck = ($lastfetchtype == $fetchtype) ? true : false;

I apologize for the alt1 / thead issues, this is easily fixed by a template modification. Just pick 1 or the other, as you said.

As for incorporating the showthread hooks into news.php, this would require including class_postbit.php, which is completely unnecessary on that page.

You seem to be right about the Allow HTML permission. I confused this with the Forum Permissions Allow HTML field, which is much more general. As news.php currently stands, the bbcode_parse_start hook is called, so it is compatible with the hack in that way. Unfortunately, the reason it's not parsing is because the hack uses $post, whereas on news.php, much like on forumdisplay.php the array used is $thread. Original versions of my hack had used $post, but it conflicted with many more hacks that way.

You can modify news.php to work with the Allow Usergroups to Post HTML by doing the following edits...

Find:
$thread['message'] = $bbcode_parser->parse($thread['pagetext'], $foruminfo['forumid']);

$post = $thread;

Replace with:
$post = $thread;
$post['message'] = $bbcode_parser->parse($post['pagetext'], $foruminfo['forumid']);

TheMilkCarton

02-07-2007, 05:28 PM

Awesome. I'll give all those modifications a shot when I see 1.0.8 released. :)

I might just test this hack out on a clean and shiny Test forum, and try to narrow down which one of my bajillion hacks is causing all these problems with it.

*keeping my fingers crossed*

Thanks for all your help. You made modifying that news.php to work the HTML hack look like a piece of cake. :up:

thincom2000

02-07-2007, 06:00 PM

I doubt your white on white "Posted by:" has anything to do with combining alt1 and thead classes since that would just mean one of those classes is foolishly white on white itself.

This is likely caused by a conflicting setting in the Usergroup Manager:

Username HTML Markup (Specify an opening and closing HTML tag with which to display the names of users in this group. This applies to names that appear on Logged-in Users, Who's Online, Users Browsing Forum, Users Browsing Thread, Posts, Member List etc.)

If this is set to white, that's why usernames are appearing that way. A template edit to change $post[musername] to $post[username] would fix this problem.

Chadi

02-14-2007, 07:58 PM

Is there a way to allow comments that do not count as posts?

Also, how do I modify the background color (or even remove) under my name when viewing the news forum?

Thank you

thincom2000

02-14-2007, 11:22 PM

Chadi

02-14-2007, 11:29 PM

Just got this email notification:

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > 1171502620 AND open <> 10, 1, 0)) AS newthread

FROM thread AS thread

WHERE forumid = 72
AND visible = 1

1171499020;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1171499020' at line 9 Error Number : 1064
Date : Wednesday, February 14th 2007 @ 07:23:40 PM
Script : http://www.talkjesus.com/news.php?f=72
Referrer :
IP Address : 66.249.65.3
Username : Unregistered
Classname : vb_database

Chadi

02-14-2007, 11:30 PM

That's a template edit. Just modify the class for the tag surrounding $post[musername].

For making comments not increase post counts, you can accomplish this with a vBulletin stock feature.

Open your news forum in AdminCP -> Forums & Moderators -> Forum Manager. Under "Enable / Disable Features," there is an option "Count Posts Made in this Forum Towards User Post Counts." Set this to no.

If on the other hand, you just don't want comments in the news to be returned as post search results or something, that is beyond the scope of this mod, since it was designed as an alternative to journal hacks that didn't count comments as posts.

Ok, but I only wanted my posts to count, but not the comments. Is this possible?

Can you please clarify which template? I tried both news_threadbit and news_postbit

Posted by <b><span id="postmenu_$post[postid]" class="alt2"><if condition="$show['profile']"><a href="member.php?$session[sessionurl]u=$post[userid]">$post[musername]</a>

I changed alt1 to alt2, nothing changed

thincom2000

02-15-2007, 12:14 AM

Odd. What do you have set for your Usergroup markup?

And in response to that email notification, a big fat question mark. News.php is almost exactly the same as forumdisplay.php (except you can't sort the news, it's always chronological -- this was done to save some queries), with modifications basically only around the threadbit_display hook. If you get another one of those, let me know.

Chadi

02-15-2007, 12:21 AM

My admin group (myself) is red colored only, thats the only markup but the thing I'm trying to get rid of is not the font color in the news view, but the background itself which it is not doing between alt1 and alt2 in both templates I mentioned

thincom2000

02-15-2007, 04:29 PM

Ok, but I only wanted my posts to count, but not the comments. Is this possible?

I don't believe it's possible to give the thread starter an increase in post count and not those who reply. That's just the way vBulletin currently works. You could do this manually by adding another plugin, but it would add 1 query to newthread.php when you click submit. If you don't mind that, I'll write it up for you.

My admin group (myself) is red colored only, thats the only markup but the thing I'm trying to get rid of is not the font color in the news view, but the background itself which it is not doing between alt1 and alt2 in both templates I mentioned.

What are the background colors for your thead and normal classes?

<td colspan="2" class="thead">
<div class="normal">
<if condition="!$show['announcement']">
Posted by <b><span id="postmenu_$post[postid]" class="alt1">

P.S. If you are having CSS problems with one template, then you most likely should edit both news_threadbit and news_postbit since they should visually look the same (though functionally they are different), and thus you would be having problems with both.

Chadi

02-15-2007, 05:46 PM

main css shows this:

alt1
background = #E4E6F5
font = #4D528C

alt2
background = #F5F5FF
font = #4D528C

Eagle Creek

02-16-2007, 01:52 AM

And uuhm.. there's no <table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center"> in postbit legacy. Only in postbit.

thincom2000

02-16-2007, 10:22 PM

In postbit_legacy it's:
<table id="post$post[postid]" class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="0" border="0" width="100%" align="center">

It's the first line in both cases anyway and means exactly the same thing.

Chadi

02-24-2007, 04:11 PM

I have this mod installed for RSS Feeds:
https://vborg.vbsupport.ru/showthread.php?t=118004

The strange problem is, trying to add a "news" thread in my CES mod is redirecting to the above hack:
https://vborg.vbsupport.ru/showthread.php?t=137365

So, clicking the actual forum link "Forum News Blog" shown here http://www.talkjesus.com/press-stand/ redirects to the RSS hack, here http://www.talkjesus.com/news.php?f=72

I'm not sure if this is a conflict with vbseo, but any help is appreciated

thincom2000

02-25-2007, 04:27 PM

The first thing that comes to mind is that both hacks use a file called news.php.

Have you renamed either file? Or did you overwrite this hack's news.php with the RSS news.php?

Chadi

02-25-2007, 05:53 PM

Yes, both use news.php in root folder. Can you please explain how I can do a workaround on yours?

My suggestion is that programmers of these hacks should use their hack name, abbreviated at least in the filenames such as :

newsrss.php
or
newsces.php

This would avoid once in a blue moon conflicts ;)

thincom2000

02-25-2007, 06:40 PM

You could rename my file to newsces.php if you wish, but you would need to edit news.php and shownews.php, search for all occurrences of news.php and replace with newsces.php

Then in all the templates for this hack, do the same.
Also check the plugins.

Chadi

02-25-2007, 11:53 PM

Thank you for your help. Now, after I left and came back I got one of the common mysql error messages emailed to me, although I cannot duplicate it. I am able to enter the forum, able to create new thread. I did however get a 'page not found' when I clicked on comments link on any of the posts I've made.

Database error in vBulletin x:

Invalid SQL:

SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > 1172448717 AND open <> 10, 1, 0)) AS newthread

FROM thread AS thread

WHERE forumid = 72
AND visible = 1

1172445117;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1172445117' at line 9 Error Number : 1064
Date : Sunday, February 25th 2007 @ 06:11:58 PM
Script : http://www.talkjesus.com/newsces.php?f=72
Referrer :
IP Address : xx.xxx.65.147
Username : Unregistered
Classname : vb_database

Also, is this actually like a 'blog' in a way, news blog so to speak? I'm just curious if that's the intention of the hack. I'm just testing it out in the meantime.

thincom2000

02-26-2007, 12:04 AM

You need to rename shownews.php to shownewsces.php apparently.

And yes, that was the intention of the hack, except I wanted anyone with permission to be able to post an entry in the same blog, and I wanted them to count as posts.

EDIT: To make that Database error stop:

In newsces.php, find:
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
Replace with:
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$visiblethreads
$globalignore
$limitothers
$hook_query_where
");

EDIT: These fixes, among others for bugs that I JUST discovered today, will be included in the next release 1.1.0.

Chadi

03-06-2007, 12:23 PM

Still getting these errors:

Database error in vBulletin 3.6.x:

Invalid SQL:

SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > 1173188048 AND open <> 10, 1, 0)) AS newthread

FROM thread AS thread

WHERE forumid = 72
AND visible = 1

1173184448;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '1173184448' at line 9 Error Number : 1064
Date : Tuesday, March 6th 2007 @ 07:34:08 AM
Script : http://www.talkjesus.com/newsces.php?f=72
Referrer :
IP Address : xxx.6.87.36
Username : Unregistered
Classname : vb_database

thincom2000

03-06-2007, 01:42 PM

Did you remove $datecut from that query?

dizzy100

03-06-2007, 01:48 PM

I tried this hack out too. I get exactly the same issues as others are reporting i,e, trying to find news.php in my webserver root when my vbulletin forum is in forums/ and yes the white text over the username as well. Rather weird.

Apart from these teething issues it seems a great hack. I wonder if we could have an option to only show the first X amount of words or letters (as a spoiler) with a link to the full article. Long news takes up an enormous amount of space using this hack :)

Still testing but pretty pleased with what i have seen (if i can get both the new option, if possible, and the two bugs squashed).

Chadi

03-06-2007, 04:07 PM

Did you remove $datecut from that query?

I did not modify anything, just installed the hack only. How would I resolve this?

thincom2000

03-07-2007, 01:22 AM

Please see post #63 (https://vborg.vbsupport.ru/showpost.php?p=1190722&postcount=63). That should solve the issue.

Chadi

03-10-2007, 10:46 PM

Can someone please explain how to get the COMMENTS box (bottom) to be even width with the above news listing? It is too wide.

Also, how do I remove that extra purple space between the comments box and the new reply button?

My news_comments template is untouched:

<if condition="$counter == 0">
<table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
</if>
<tr>
<td class="tcat" align="$stylevar[left]"<if condition="$vboptions['legacypostbit']"> colspan="2"</if>>
$vbphrase[news_comments]
</td>
</tr>
<if condition="$counter == 0">
<tr>
<td class="alt1" align="$stylevar[left]"<if condition="$vboptions['legacypostbit']"> colspan="2"</if> valign="top">
$vbphrase[no_comments_in_this_article]
</td>
</tr>
</table>
</if>

thincom2000

03-11-2007, 01:15 AM

You should check your settings for the style you are using. My guess is it has to do with variances in your settings for form/etc. widths.

Chadi

03-11-2007, 01:19 AM

Sorry, where should I look in the styles exactly? I don't want to mess anything up :)

thincom2000

03-11-2007, 03:01 AM

dizzy100

03-11-2007, 08:19 AM

thincom2000

03-11-2007, 08:29 AM

SnitchSeeker

03-11-2007, 04:04 PM

Anxious to see a demo. How's that coming along? I just want to see what this looks like when the thread has posts and how it looks from a regular user's pov.

More screenshots would work too I guess.

This might be just what i am looking for but i won't install until I can see a bit more about it.

thincom2000

03-11-2007, 05:28 PM

Live demo: http://www.crackedeggstudios.com/news.php

dizzy100

03-11-2007, 06:26 PM

Yes, this hack is still supported, I must have just missed your post in there. I'm a bit confused as to why it is looking in your web server root.

Do you have $vbulletin->options['bburl'] set to your domain name instead of your board url?
For the white text over the username, could you please link to your news section so I can look at that?

Regarding your suggestion for only showing X words or letters, that sounds like a doable addition for the next update, and thank you for suggesting it because I've been holding 1.1.0 back until I could add to the feature list (had been mainly bug fixes).

As regards the $vbulletin>options['bburl'] im not sure where to check on that ? But this is the only hack ive installed (have 20+ enabled) that does this ?

Glad you appreciate ideas. I think a limited wordage per news with a read more link would be great. And if possible, a bbcode tag to add to override that limit. So say you set a limit of 50 words per article but on one article 50 won't cut it (needing more), you add a bbcode tag that overrides that 50 words with a user defined word limit for that article. What do you think ?

thincom2000

03-11-2007, 06:42 PM

I will remove the references to the bburl in 1.1.0, but you really should not have any problems there UNLESS AdminCP -> vBulletin Options -> Site Name / URL / Contact Details -> Forum URL is NOT set to your forum base directory and is instead set to your webserver root.

I'm pretty sure bb-codes weren't originally designed to do that. Doing what you suggest with a tag (overriding a vbulletin setting) may prove impossible without serious file edits, unless it was the tag itself that acted as a setting. :)

dizzy100

03-11-2007, 06:48 PM

My forum url is set correctly so its not that :( I know locally i edited your plugin and removed that bburl code in it and it worked well after that.

As regards bbcode, i actually meant a tag. Could you not get the plugin to look at the body of the text and if a tag exists break there instead of the default in the admincp option of your plugin ? Would seem the likely solution.

So check if $tag exists else $mydefaultbreaksetting ?

thincom2000

03-11-2007, 06:56 PM

Ah yes, much easier if not bbcode related. Maybe using the hook threadbit_display...

dizzy100

03-11-2007, 07:02 PM

Great, really looking forward to it as i can't use it till that addition as my news is just too big :) But i'll keep an eye open as i loved the hack and it worked very well apart from the small issues with path i had.

Thanks thincom2000, look forward to the update. I'll mark as installed so i catch it when its done :)

Chadi

03-12-2007, 01:51 AM

AdminCP -> Styles & Templates -> Style Manager -> All Style Options -> Sizes and Dimensions -> Main Table Width.

If this is a value larger than you might have specified maybe in the showthread template or something, that's what's causing your problem. I know whenever I change the layout of my site and then nothing matches in width anymore, Main Table Width is usually the culprit.

I never changed the layout settings ever on this style actually.

If your not 100% sure how to correct this (I'm 100% confident it is the hack settings, but I'm not blaming you lol) perhaps you can explain how to remove the comments area (box and button). I don't mind leaving the option off.

thincom2000

03-12-2007, 06:34 AM

It's your current value for Spacer Size. Your value of 15 is compressing the first post table by 15 on each side. I would recommend either setting Spacer Size to 0, or if that makes your forum look horrid, could you post the 10 lines above and below $firstbit in your SHOWNEWS template?

Then I'll try to figure out how to rearrange $spacer_open and $spacer_close for your case, since I am using a modified version of the template.

Chadi

03-12-2007, 04:56 PM

Thanks for your reply. I'd rather not modify the style's layout and everything looks fine except the comments area in this hack. I love the hack and wish to resolve this with your good support :)

This is the the portion of the unmodified shownews template

<if condition="$vboptions['allowthreadedmode']">
<td class="vbmenu_control" id="displaymodes" nowrap="nowrap">
<a href="$show[nojs_link]#goto_displaymodes">$vbphrase[display_modes]</a>
<if condition="$show['popups']">
<script type="text/javascript"> vbmenu_register("displaymodes"); </script>
</if>
</td>
</if>
</tr>
</table>



$spacer_close


<if condition="$show['reputation']">
<script type="text/javascript" src="clientscript/vbulletin_ajax_reputation.js?v=$vboptions[simpleversion]"></script>
</if>

$firstbit

$similararticles

<div id="posts"><if condition="$postbits == ''">$news_comments<else />$postbits</if><br />

<div id="lastpost"></div></div>


$spacer_open



<table cellpadding="0" cellspacing="0" border="0" width="100%">
<tr valign="top">
<if condition="$show['largereplybutton']">
<td class="smallfont"><a href="newreply.php?$session[sessionurl]do=newreply&noquote=1&p=$LASTPOSTID" rel="nofollow"><if condition="$show['closethread']"><img src="$stylevar[imgdir_button]/reply.gif" alt="$vbphrase[reply]" border="0" /><else /><img src="$stylevar[imgdir_button]/threadclosed.gif" alt="$vbphrase[closed_article]" border="0" /></if></a></td>
<else />

Chadi

03-12-2007, 08:14 PM

Just noticed something today:

When viewing the news submission (main news page) it does not show the inline thumbnail attachments unless you view each specific news thread. Is there a possible way to get them to show on the main page?

thincom2000

03-12-2007, 09:04 PM

Just updated v1.1.0 with the attachments fix. You'll notice in the Changelog that I also included all the other things that have been suggested in the past week or so (or more). If you downloaded v1.1.0 already you only need to replace the updated news.php file.

Chadi

03-12-2007, 09:18 PM

Ok, this is happening again. I've just upgraded and its conflicting with RSS Newsfeed hack (remember a few weeks ago I mentioned the conflicting same filenames).

Before upgrading, I changed news.php to newsces.php
shownews.php to shownewsces.php

I edited each file to find any area that shows news.php or shownews.php and added the 'ces' to each.

Now, I am getting directed to the RSS feeds page instead again. Did I miss something else?

I searched all templates for news.php (which would bring up shownews.php by default too)
and found nothing aside the rss feeds link, which is properly news.php

thincom2000

03-12-2007, 09:37 PM

There is a new setting in the AdminCP for when you rename the files.

Chadi

03-12-2007, 09:41 PM

Thank you. Now getting database errors :P

Database error in vBulletin 3.6.5:

Invalid SQL:

SELECT
post.*, post.username AS postusername, post.ipaddress AS ip, IF(post.visible = 2, 1, 0) AS isdeleted,
user.*, userfield.*, usertextfield.*,
icon.title as icontitle, icon.iconpath,
avatar.avatarpath, NOT ISNULL(customavatar.userid) AS hascustomavatar, customavatar.dateline AS avatardateline,customavatar.width AS avwidth,customavatar.height AS avheight,
deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason,
editlog.userid AS edit_userid, editlog.username AS edit_username, editlog.dateline AS edit_dateline,
editlog.reason AS edit_reason,
postparsed.pagetext_html, postparsed.hasimages,
sigparsed.signatureparsed, sigparsed.hasimages AS sighasimages,
sigpic.userid AS sigpic, sigpic.dateline AS sigpicdateline, sigpic.width AS sigpicwidth, sigpic.height AS sigpicheight,
IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid, infractiongroupid

, attach.info_hash, attach.size, attach.comment, attach.created_by, attach.announce_list, attach.completed_by,
attach.completed, attach.seeders, attach.leechers, attach.ulspeed, attach.dlspeed,
attach.dateline AS attachdate, attach.thumbnail_dateline, attach.filename, attach.filesize,
attach.visible AS attachvisible, attach.attachmentid, attach.counter,
IF(attach.thumbnail_filesize > 0, 1, 0) AS hasthumbnail, attach.thumbnail_filesize,
attachmenttype.thumbnail AS build_thumbnail, attachmenttype.newwindow
, journals.journaldesc, journals.journal_id
FROM post AS post
LEFT JOIN user AS user ON(user.userid = post.userid)
LEFT JOIN userfield AS userfield ON(userfield.userid = user.userid)
LEFT JOIN usertextfield AS usertextfield ON(usertextfield.userid = user.userid)
LEFT JOIN icon AS icon ON(icon.iconid = post.iconid)
LEFT JOIN avatar AS avatar ON(avatar.avatarid = user.avatarid) LEFT JOIN customavatar AS customavatar ON(customavatar.userid = user.userid)
LEFT JOIN deletionlog AS deletionlog ON(post.postid = deletionlog.primaryid AND deletionlog.type = 'post')
LEFT JOIN editlog AS editlog ON(editlog.postid = post.postid)
LEFT JOIN postparsed AS postparsed ON(postparsed.postid = post.postid AND postparsed.styleid = 19 AND postparsed.languageid = 1)
LEFT JOIN sigparsed AS sigparsed ON(sigparsed.userid = user.userid AND sigparsed.styleid = 19 AND sigparsed.languageid = 1)
LEFT JOIN sigpic AS sigpic ON(sigpic.userid = post.userid)
LEFT JOIN attachment AS attach ON(attach.postid = post.postid)
LEFT JOIN attachmenttype AS attachmenttype USING (extension)
LEFT JOIN journals AS journals ON (journals.journalist_id=post.userid)
WHERE post.postid IN (0,71157,71157)
ORDER BY post.dateline;

MySQL Error : Unknown column 'attach.info_hash' in 'field list'
Error Number : 1054
Date : Monday, March 12th 2007 @ 05:40:41 PM
Script : http://www.talkjesus.com/shownewsces.php?t=12192
Referrer : http://www.talkjesus.com/
IP Address : xxx.xxx.149.108
Username : Chad
Classname : vb_database

thincom2000

03-12-2007, 09:51 PM

Haha, whoops. That's my shownews. Product version has been added to the zip instead (I hope). Sorry about that.

Chadi

03-12-2007, 09:59 PM

Excellent :)

Works now. Thanks for a great hack, also great support

5 stars!

ninjamaster

03-13-2007, 07:34 AM

thanks for this :)

dizzy100

03-13-2007, 07:52 AM

Outstanding work and works really well. However the bbcode tags are quite dangerous :)

I wasn't sure about a numeric value so assumed you meant this is the txt we wish to have as our teaser and this isn't.

Submitting that deleted this is the text we wish to have in our teaser and just leaves and this isn't in both the body and the teaser (so effectively deleted the text within the bbcode that you can't get back :)).

Now if you use it as it should be 28 so it only shows the first 28 words thats fine and it works well. However the danger is using it somewhere in the body of your text without closing the bbcode and deleting all text within it :) BBcode, by its nature, usually encapsules something and i think we'll all assume to encapsule the text we wish to use as a teaser.

think a better solution would be to approach this (if possible) as i tried on my first attempt. I.e. have the bbcode open where you wish to start to new teaser (cancelling the default for that article) and then closing it where you wish it to end. Then thats the new teaser (much easier than trying to work out how many words your new teaser needs). What do you think ?

Everything else appears to work perfectly, including paths, comment box size and even that pesky white line in the username :) Outstanding.

thincom2000

03-13-2007, 08:04 AM

dizzy100

03-13-2007, 09:27 AM

Um... although the text may APPEAR to be deleted, it should still be there when you edit the post... Also if you don't close the tag, I'm pretty sure vBulletin just doesn't parse it. That has been my experience, anyway.

When you said "dangerous," I thought for a moment you had somehow installed my [anything] tag which isn't included with this hack, and a spammer having permissions to use it messed up your entire board.

The purpose of [preview] is just to override the AdminCP setting with a new value, and was not meant to be used as BB-code (it just makes use of the BB-code parser because then I don't have to write code myself to parse it out). I, for one, abhor typing in a "short article" for a preview, and then typing a different article for the actual article. So that's why it just shows the first numeric_value words of the article.

No it definitely deleted them :) Try it locally and re-edit after you've done the steps i highlight above. That text is now gone completely, including the bbcode :) I tried it several times and all with the same effect. The text is missing in the main view and the teaser and isn't now available to edit either, hence why i said dangerous :) Imagine writing a long article, wrongly using what you thought was a bbcode (because you even called it a bbcode) and then hitting save. You have now lost half your article.

I still think if its a bbcode it should act as one or it will certainly cause confusion. Failing that a simple tag of something like ----more---- and it will splt to a readmore link there. This isn't a great solution you have provided (sorry im just offering constructive feedback) and will most certainly lead to confusion. You're probably better to parse it using your own tag or really do a full bbcode.

I'll try the bbcode again on my test posts to make sure it wasn't me, but im 100% confident i can reproduce that effect each and every time .

I'll get back to you soon.

Please don;t see this as a nag, its really not. I love this hack and it does pretty much most of what i require. Your efforts are very much appreciated.

dizzy100

03-13-2007, 09:30 AM

OK i can confirm 100% it does delete the text when the bbcode is applied as a bbcode.

to test this wrap your tags around some text and save. You'll notice that text has disappeared in both post view and teaser view. Click edit and both the bbcode and the text you wrapped the bbcode around is gone completely (in both wysiwyg view and bbcode view).

I can duplicate it each and every time.

SnitchSeeker

03-13-2007, 11:24 AM

There are some errors in your demo that make me leary of installing it. It looks GREAT! But I am nervous that it might mess up some of my settings since I have such a HUGE news section (thousands of threads, 5-10 new daily).

The errors I spotted were all dead or bad links. For example, click "Comments (0)" link in an article and I get a 404. Same goes for several other links. Is this because I am a guest or are you also experiencing this?

I must say this looks really GREAT so far in spite of the errors. I hope you can work out any bugs it may have and that I will be able to use it. I'll wait a bit to see your responses.

SnitchSeeker

03-13-2007, 12:33 PM

I have taken a closer look at your site/demo and really like what I see. Still, there are a few things that I can't figure out so maybe you can help me with them.

1) Do any of your news articles use the preview limit? I believe it is supposed to be possible to show only the first X words on the main news page and force users to click on the article to read the rest.

2) Does it use a seperate template so that I can easily customize the look of the news page? For example, I would like the headlines to be bigger (and in H2 tags), the [quote] button not to show up or to be a [comment] button, the "Last Comment" text to be clickable (currently it seems users have to click the tiny arrow at the end of the text), etc.

3) I am really looking for something that can make my news forum look more like this site's news (http://www.hpana.com). When you're in a news article (http://hpana.com/news.19801.html), it doesn't show comments until you choose to view them. Ideally it would be cool to have that as a cookie setting (view or hide comments).

Even if I can't do all these things with your mod, maybe I can customize it to do them for my forum.

I mainly want to know what specifically this mod includes and what of the above it doesn't so I know how much work it will be to get it to do what I need.

Thanks! :)

thincom2000

03-13-2007, 02:01 PM

I am unable to duplicate the 404 error you describe.

None of my articles currently use the preview limit although it is entirely possible to do this.

It uses 7 new templates in all, the article body itself uses 1 on Newsdisplay and another on Shownews. You can eliminate the Quote button by editing the templates, however, if you want to change it to "Comment," you would have to modify your forum's images. You can make the "Last Comment" text clickable by editing (translating) that phrase for your forum.

You would have to find your own javascript for show/hide of comments. This not possible with vBulletin's vbcollapse feature since each comment uses a new table. You should then edit your SHOWNEWS template to include the changes you want.

As for the [preview] tags eating unsupported preview text, the tags never disappear for me when I try to edit, even with text between. This may be because you are using the WYSIWYG editor, in which case you should not be able to modify any BB-code after submission. Switch to the Standard editor and you should see it again.

As for the practical use of the [preview] tag, I will change the name to [previewlength] for the next update, and add a [more] tag which will encapsulate the text that hides on preview for the next update. How's that?

dizzy100

03-13-2007, 02:21 PM

As for the practical use of the [preview] tag, I will change the name to [previewlength] for the next update, and add a [more] tag which will encapsulate the text that hides on preview for the next update. How's that?

Ah yes your correct. I just checked this and low and behold, theres the text when the wysiwyg editor isn't enabled. Worried me silly that :) I use the wysiwyg editor always so i never noticed anything out of place there.

A better approach would be to have a bbcode type tag that just cuts the length for the teaser but still displays for the body too. This way you don't have to write a lead in teaser and a body, you just use the same content (we could even then assign it a button).

I think this is stable enough for me to install now and again i thankyou for your hard work. Awesome mod.

**Clicks install**

dizzy100

03-13-2007, 02:43 PM

What templates does this mod use ? I need to edit them as they are now 100% correct for vbulletins default style (top by the reply pushes out slightly and a few other minor cosmetic issues).

thincom2000

03-13-2007, 04:46 PM

NEWSDISPLAY
news_threadbit
SHOWNEWS
news_postbit
news_comments
shownews_similararticles
shownews_similararticlebit

SnitchSeeker

03-13-2007, 08:00 PM

I am unable to duplicate the 404 error you describe.
http://www.crackedeggstudios.net/showthread.phps=a6a1bb862ab14c7b161966f4a47c8c53&?t=373

That's a link from thread #72 (http://www.crackedeggstudios.net/showthread.phps=a6a1bb862ab14c7b161966f4a47c8c53&?t=373) if you click the commments link: "Comments (2)" (http://www.crackedeggstudios.net/showthread.phps=a6a1bb862ab14c7b161966f4a47c8c53&?t=373)

Downloads back online (http://www.crackedeggstudios.net/showthread.phps=a6a1bb862ab14c7b161966f4a47c8c53&?t=381) thread #76 is also a 404 for me.

There were others but I can't remember where right now.

You would have to find your own javascript for show/hide of comments. This not possible with vBulletin's vbcollapse feature since each comment uses a new table. You should then edit your SHOWNEWS template to include the changes you want.
Actually I was more thinking of a different page (maybe the same url followed by /comments ). I use vbseo so all my urls are, well, seo'd. I can figure this one out I guess, but how about simply using a type of show/hide on the main page? Where the default (or defined) amount of preview words are shown and then a link for (full story) which opens the rest of the story on the same page (javascript or ajax) instead of taking you to the thread page with comments? That would be wicked!!
As for the [preview] tags eating unsupported preview text, the tags never disappear for me when I try to edit, even with text between. This may be because you are using the WYSIWYG editor, in which case you should not be able to modify any BB-code after submission. Switch to the Standard editor and you should see it again.

As for the practical use of the [preview] tag, I will change the name to [previewlength] for the next update, and add a [more] tag which will encapsulate the text that hides on preview for the next update. How's that?That sounds great! The "more" text could be shown when people click a "more" link from the main news page like I described above, right? Or would it just take you to the thread?

SnitchSeeker

03-13-2007, 09:04 PM

Oh, I just thought of something important (in my case at least).

Does this support vbSEO? Will vbseo work with this mod? If not I can't use it I'm afraid. :(

thincom2000

03-14-2007, 12:23 AM

I don't have vbSEO so I don't know. Also I have no idea how you got the session data to appear in those URLs, especially being a guest. What browser are you using?

SnitchSeeker

03-14-2007, 12:07 PM

Internet explorer 6.

As for vbseo I'll check with them.

thincom2000

03-14-2007, 05:00 PM

As for vbSEO, if you needed any plugins for forumdisplay or showthread, you should be able to use them for this. This hack just adds a second forumdisplay (NEWSDISPLAY) and showthread (SHOWNEWS) that use different templates. I don't see why it wouldn't work, although I have no way of testing it personally.

SnitchSeeker

03-15-2007, 09:56 AM

I'm sure it would still work for the rest of my forums but I'm less sure about if it would work for the news section after I switch to your templates. For example, it doesn't work on the firstpost template I use to show first post on all pages in the new forum. But that is only for one post, not the whole forum, so I can live with it. If this modifies my whole forum (the news one only of course) than I am afraid it might not "seo" the threads and such which is where I get most of my google traffic so that would be bad.

I'm posting a question about it over there and we'll see what they say.

Danisty

03-18-2007, 10:29 PM

Okay, I don't know much about this kind of stuff, so if you don't mind answering a couple of questions...

Can this hack pull from multiple forums? Also, is there any way to make it so each forum it pulls from has it's own news page?

Can this hack pull from forums that aren't viewable by guests or even registered members? I basically want an articles hack, but I don't like any of them that I've seen. I'd like it so members never even knew these articles were pulled from a forum, so it would be best if I could turn the forum off for everybody except the usergroup that would be writing the articles. Then registered members and guests would just see it as an articles page that matches the layout of the forum, but doesn't look exactly like a forum. Am I making sense?

thincom2000

03-19-2007, 01:15 AM

Danisty

03-19-2007, 03:17 AM

This mod does not do exactly what you describe. It sounds like you are looking for an RSS-type feed.

This mod alters a forum of choice so that the first post of each thread becomes an article. The articles are pulled from threads, but only to the FORUMDISPLAY of that particular forum. The FORUMDISPLAY by no means really looks like a forum anymore as a result because the text of the recent articles displays there.

Clicking on an article title, clicking a "Read More" link (if you have a preview limit set), clicking the comments link, or clicking to view the last comment will all bring up a page similar to SHOWTHREAD, which displays the article at the top, and comments below. If you wanted to disable comments, you could just remove those links from the NEWSDISPLAY template, and

This hack makes use of forum permissions, because technically the news is still a forum, merely presented differently. So you could disable replies to threads, and set particular usergroups that are permitted to create threads (articles) per forum.Yeah, I haven't been able to find a mod that does do exactly what I want. I was thinking about using this and just eliminating the ability to respond to threads and setting it so the entire article shows on the news page, but I would want to be able to make multiple news pages for the different categories. I could make the categories page with no problems and link to the individual news pages, but I don't even know if that's possible.

I haven't been able to figure out RSS feeds either. I've looked at all the threads I can find both here and at vbulletin.com and it seems like I won't be able to do exactly what I want. From what I could tell, RSS feeds require you to allow guests to view the forum you're feeding. I want to hide that from everyone so nobody knows the articles page is powered by vbulletin. I want it to look different because otherwise there would be no point in having an articles section like this.

thincom2000

03-19-2007, 05:20 PM

You could create multiple news forums to act as your "Categories." Each news forum would handle different articles. You could then link to each forum from your Category listing page.

Chadi

03-19-2007, 10:53 PM

I never changed the layout settings ever on this style actually.

If your not 100% sure how to correct this (I'm 100% confident it is the hack settings, but I'm not blaming you lol) perhaps you can explain how to remove the comments area (box and button). I don't mind leaving the option off.

Please help me on this issue, thanks

thincom2000

03-19-2007, 10:55 PM

This was fixed in the newest version.

Chadi

03-19-2007, 10:58 PM

Unfortunately not for me and I did upgrade today (currently shows 1.1.1)

thincom2000

03-19-2007, 11:36 PM

Have you reverted your templates?

Chadi

03-19-2007, 11:38 PM

I have not done anything at all, yet. Should I revert them? I made custom settings to simply remove background color on the username and "comments" text only

thincom2000

03-19-2007, 11:48 PM

Revert the templates, all those issues were fixed in 1.1.0.

Chadi

03-20-2007, 02:17 AM

reverted all, still messed up

thincom2000

03-20-2007, 02:28 AM

The sizes are correct now. The rest is a problem in your CSS, your "page" class is blue meanwhile you have your background set to white. This is also why you have a blue bar at the very bottom of your site before the "Contact Us," etc. menu.

Chadi

03-20-2007, 02:30 AM

It must be a part of the hack somewhere because it was not there before and the blue is only behind the comments field, which indicates some code in the template pulling that up.

Which template would I edit for this area?

thincom2000

03-20-2007, 02:55 AM

You have to edit the CSS. Go to Style Manager -> All Style Options. Scroll down to page background, and make sure that matches the rest of your site. I try to keep a lot of my backgrounds transparent, so that there's never a conflict with something underneath. If you have the time, I would recommend going through the CSS and doing this where you can. It will keep your style simpler and much easier to manage.

Chadi

03-20-2007, 03:02 AM

Please see attached. Its not my css at all.

The color (blue) in comments background area is:

#B7BCE2

The only time this is mentioned in the Main CSS is body background color

I'm 100% sure its something obviously in the mod's template somewhere

If you tell me which template it is, I will copy/paste it even though I reverted all

thincom2000

03-20-2007, 04:45 AM

In template SHOWNEWS, find and remove:

$spacer_close


Find and remove:

$spacer_open


In templates shownews_similararticles and news_comments, find and remove:
$spacer_open
Find and remove:
$spacer_close

Some of those had been added to make all the tables the same size on your forum. Hopefully removing the ones that were there already will bypass the earlier problem.

thincom2000

03-24-2007, 12:13 AM

New version released. Added the BB-Codes you wanted. Also got rid of the unnecessary $spacer_open/$spacer_close (mentioned in last post). Enjoy it.

dizzy100

03-24-2007, 03:52 AM

Upgraded to the latest version but now get

Fatal error: Call to a member function parse() on a non-object in C:\xampplite\htdocs\news.php on line 893

When entering any forum that is news enabled.

I also found a bug in the old release (not sure if its addressed in this one) where f you soft delete an article it remains visiable on the front page of the news with the read more tag. However clicking the readmore tag brings up the "this thread in invalid" error box.

UPdate: De-installed the product and re-installed, resetting my settings. The news functioned as it should then until i added a Limit News Preview to How Many Words? option and then the same error as above came up.

thincom2000

03-24-2007, 04:14 AM

Okay, I tried to fix the soft-delete bug you found. Not sure if it worked, since I only ever hard-delete, so let me know. The fatal error should also be gone. It was a result of copy & paste from a plugin to hard-coding it, and some class references had changed in the process.

dizzy100

03-24-2007, 07:54 AM

Thanks that got it for the php error.

However soft delete still persists to display after the fix.

thincom2000

03-24-2007, 04:18 PM

I am not getting an "invalid thread id" error after soft-delete. I can still access the thread normally.

thincom2000

03-25-2007, 04:13 AM

I'm pretty sure I fixed the soft-delete this time. Had to modify two queries and add a conditional. Added some overdue and new phrases.

TheMilkCarton

03-25-2007, 09:59 PM

Is this still not working well? I go to the demo site and get database errors.

thincom2000

03-25-2007, 10:24 PM

Yes, this hack is working flawlessly as much as I can tell. The database error you saw was a conflict created by a plugin I had written for another page that isn't part of this hack. There's a workaround, so no worries if you manage to install the same plugin I haven't released yet. ;)

TheMilkCarton

03-26-2007, 12:18 AM

Well, installed (again) on my forum and I get a database error. This is maybe my 3rd or 4th attempt at using this. :mad:

Uninstalled (again)

thincom2000

03-26-2007, 12:44 AM

It really doesn't help if you don't tell me what the database error is.

TheMilkCarton

03-26-2007, 01:02 AM

Invalid SQL:

SELECT post.*, thread.*, post.iconid AS miconid, post.attach,
icon.title as icontitle, icon.iconpath,
attach.dateline AS attachdate, attach.thumbnail_dateline, attach.filename, attach.filesize, attach.visible AS attachvisible,
attach.attachmentid, attach.counter,
IF(attach.thumbnail_filesize > 0, 1, 0) AS hasthumbnail, attach.thumbnail_filesize,
attachmenttype.thumbnail AS build_thumbnail, attachmenttype.newwindow,
user.lastactivity, user.lastvisit, user.options, user.usertitle, user.homepage,
IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid, user.usergroupid,
user.membergroupids
FROM tmc_thread AS thread
LEFT JOIN tmc_post AS post ON (post.postid = thread.firstpostid)
LEFT JOIN tmc_icon AS icon ON (post.iconid = icon.iconid)
LEFT JOIN tmc_attachment AS attach ON(attach.postid = post.postid)
LEFT JOIN tmc_attachmenttype AS attachmenttype USING (extension)
LEFT JOIN tmc_user AS user ON (post.userid = user.userid)
WHERE thread.forumid = 35
AND visible IN (0,1,2)
ORDER BY thread.dateline DESC
LIMIT 0,10;

MySQL Error : Column 'visible' in where clause is ambiguous
Error Number : 1052
Date : Sunday, March 25th 2007 @ 08:13:25 PM
Script : -----------------/forums/news.php?f=35
Referrer : -----------------/forums/showthread.php?t=238&goto=nextnewest

I obscured the URL if you're wondering why there are crazy dashes. :)

thincom2000

03-26-2007, 01:40 AM

Okay, I'm not sure why you don't want us visiting your site... but here goes:

I was unable to duplicate the error on my forum. We are probably running different MySQL server versions. That doesn't mean I haven't attempted to fix the error.

I have gone through news.php and specified any ambiguous fields. I have also added some hook locations and variables that I had previously removed; hopefully this will avoid possible ambiguities between thread counts and threads displayed in the future.

TheMilkCarton

03-26-2007, 03:35 AM

Have you tested this hack out with forums that have been marked invisible? Not sure if it had anything to do with the error, but the forum I got the database error on was set to invisible.

And I'm not ready for any traffic yet, so sorry if that's a problem. :)

As for MySQL version: MySQL Version 4.1.21-standard copied from my AdminCP

I really wanted this hack to work.. I really like the idea of seeing the thread from forumdisplay. Maybe I'll have to break down and buy GARS. :)

thincom2000

03-26-2007, 04:19 AM

I think the forum being invisible just prevents users from seeing it on the forum home or wherever, so this shouldn't be an issue. I'm pretty sure the changes I made should fix at least THAT database error you were having.

My MySQL version is 5.0.27 so I can sometimes overlook some things that may be problematic for older versions of MySQL if they don't give me errors.

TheMilkCarton

03-26-2007, 06:04 AM

Yay. It works. Still have a glaring graphical error, but I'll just have to look through the templates. But I'm glad to see that whole Comments text thing was worked out.

One huge problem though.. :) It doesn't obey the default order I had set in the Forum Manager. I set all threads to sort by title, and this does it by date.

Will it be easy to add default sorting options back in? :) Thank you! This is looking very promising.

Make that two graphical errors. When viewing the articles in news.php there is a large gap between the tr with the post, and the tr with the "Edit" and "Quote" buttons. There's an extra <tr> </tr> and it's taking on my tborder properties I believe. The other error is in shownews.php, where it looks like the entire article is pushed 10px over to the right.. but the comments are fine though. Edit: The comments are in the correct place UNTIL you post in them, and then they move over 10px to the right with the news article.

Ok, make that 3 errors. When a comment is posted the cellspacing is way off from what it should look like in a regular thread.

-----------

Fix for one of your templates: In news_threadbit there was an extra set of <tr> <td></td></tr> that were empty. Also you have "<if condition="$show['attachments']">" inside of the <tr> tag, you should put the if condition on the outside, since the empty <tr> will show even when there's no attachment. This looked really ugly on my forum, since my tborder was very dark and my alt1 was very light.

And this also just might be personal opinion, but you don't need a "<tr> <td>" wrapped around the "edit note" because it just creates an empty box when there is no edit note. If you really want a box there, you should put it inside the if condition for $show "postedited" so that the box doesn't show up all the time.

EDIT: I get an error when I try limiting the words that show on Newsdisplay. I can't use the BBcode or the method in vB options, I get Fatal error: Call to a member function on a non-object in ...snip.../forums/news.php on line 880

I also get a really messed up table (in Newsdisplay) when a forum that I've designated as a News forum has a description. The Forum name and Description will be stretched across the entire screen, cutting my table in half between the navbar and the first news article.

I've double checked this. I deleted the description from one of the "News" forums and the problem disappears. I thought it had something to do with enabling Announcements (as that's where announcements would show on the news display) but turning them off didn't do anything.

Geez.. Sorry to turn this into such a long post.... Just trying to help out. :) If you could at least figure out the source of the "Fatal Error" that would be great. I can probably figure out the rest on my own, it's probably just problems with the templates.

thincom2000

03-26-2007, 10:16 AM

Most of the issues you are having with the templates are actually there on purpose to help with spacing problems some other forums were having. If you are having issues with your own style and CSS go ahead and change the templates to whatever works for you. Unfortunately if you are not posting your forum URL, I can't help you figure out some of those template issues or include any related fixes in the next update, since it would just be hit or miss otherwise. Too bad, the forum description explosion sounds really crazy.

Strange that the fatal error came back, this was fixed in the previous version. I will look into that.

EDIT: Found a few other buggeries in the process of fixing your fatal error. Included in today's fix, which I just uploaded.

thincom2000

03-26-2007, 11:23 AM

One huge problem though.. :) It doesn't obey the default order I had set in the Forum Manager. I set all threads to sort by title, and this does it by date.

Will it be easy to add default sorting options back in? :)

This has been intended functionality since v1.0.0. You may have noticed that the Forum Search menus have also been removed from News(forum)display. The mentality behind this was that the Forum Search options added about 3 queries to the page (although looking back on it now this may just be sticky threads that do this - and you can't sticky the news anyway -> that's what announcements are for!), and developing it we felt that news was a much more "chronologically" dependent.

If this feature is that important to you, I will consider adding it back to version 1.3.0 later this week, with a little coding trick so that it skips the queries if we are sorting chronologically and as much as possible in other cases.

TheMilkCarton

03-26-2007, 04:24 PM

OK, it works now. However, if the article is under the word limit it still displays "... Read more..." Is this normal?

Also, while in Newsdisplay, I notice that there is the typical icon legend at the bottom, but the icons don't actually show up anywhere in the articles.... I may have inadvertently deleted this from the template.. but I'll have to look into that.

I've also been trying to find where in the templates you were compensating for the display problems in other forums.. but I still can't find where you've moved the news postbit and the comment postbit 10px or so over to the right. I'll just have to search through the code more, unless you happen to know offhand where it is. :)

About the article sort order, it is kind of important.. as not all of my articles are News based, and need to be in alphabetical order... Won't it be easy to add a On/Off in the CES Site News options saying something like "Obey Default Sort Field and Default Sort Order?" That way if it's set to no it just defaults to chronological and saves on queries? Not sure how easy that would be though. :)

thincom2000

03-26-2007, 06:15 PM

OK, it works now. However, if the article is under the word limit it still displays "... Read more..." Is this normal?

This should not be happening, but quickly thinking it over I know where the problem lies. I will fix this for v1.3.0.

while in Newsdisplay, I notice that there is the typical icon legend at the bottom, but the icons don't actually show up anywhere in the articles....

You did not delete anything from the templates. The icons will be fixed in v1.3.0.

I've also been trying to find where in the templates you were compensating for the display problems in other forums.. but I still can't find where you've moved the news postbit and the comment postbit 10px or so over to the right.

Check your templates spacer_open and spacer_close. Also check the Main Table Width and Spacer Size in your CSS definitions.

About the article sort order, it is kind of important.. as not all of my articles are News based, and need to be in alphabetical order...

I was able to bring the sort orders back without bringing back the queries I removed with some tricky JOINs. Looking at it now, I don't know why vBulletin has those extra queries in forumdisplay.

Sort order and the ability to search a news forum from Newsdisplay will appear in v1.3.0.

TheMilkCarton

03-26-2007, 06:26 PM

Nice job. :)

I've gone over the template a million times and I've gotten rid of the spacers, moved them around and the news and comment postbits still jut off 10px to the right.

I have a table width of 800px, spacer of 10px, and everything is fine in my normal postbit in showthread, but in shownews there is 20px padding on the left and 10 px padding on the right. This causes the postbit to actually come off the page by 10px on the right side.

I'm going to try comparing source code between shownews and showthread and see where that goes.

Can't wait for 1.3.0 :D

Edit: Comparing the source code, I first noticed that this somehow breaks my RSS feed for my News forum... Clicking RSS up in the URL bar leads me to a blank page if I'm in a forum with your hack, but it works normally in the others. It might not break the feed per-se, but something's not right.

salami1_1

03-26-2007, 06:32 PM

Hi,

I got your plugin working at:
http://www.samsunguniverse.com/forum/news.php?f=6

but I really would like to have blog like news included on:
http://www.samsunguniverse.com/index.php
under 'Samsung news' and then not in vbb style. But I still want the messages there also to appear in the forum as it does now.

Is there anyway to do this? I know some php code but divinginto vbb codes.
Thanks for the help!

Steve

thincom2000

03-26-2007, 06:39 PM

I have a table width of 800px, spacer of 10px, and everything is fine in my normal postbit in showthread, but in shownews there is 20px padding on the left and 10 px padding on the right. This causes the postbit to actually come off the page by 10px on the right side.

I'm going to try comparing source code between shownews and showthread and see where that goes.

There is nothing in the source code that would do that. It seems that there is still a $spacer_open somewhere and no $spacer_close. I will look into this.

this somehow breaks my RSS feed for my News forum... Clicking RSS up in the URL bar leads me to a blank page if I'm in a forum with your hack, but it works normally in the others. It might not break the feed per-se, but something's not right.

This issue has come up before. You need to rename news.php to something else. Then set the new filename in the AdminCP (this problem is why the setting was created) and everything should work fine.

TheMilkCarton

03-26-2007, 06:43 PM

I already did that though... because I didn't want it named news.php or shownews.php. I wasn't aware this was to fix RSS.

How ironic. I'm going to disable this plugin and see if I still have the problem.

There is nothing in the source code that would do that. It seems that there is still a $spacer_open somewhere and no $spacer_close. I will look into this.
I meant that comparing source codes would help me figure out what was missing in the templates. :)

Edit: It just acts very strangely when I have the forums turned off. :) However, in news and shownews.php I don't get a dropdown box like I should when clicking on the RSS button. It takes me to the same RSS feed I would get if I clicked on the RSS button the main forums. In shownews and news.php it should be giving me a dropdown to select the RSS feed for that specific forum. I'm not really worried about this though... I'm not even sure I'm going to keep RSS enabled anyway :)

thincom2000

03-26-2007, 07:03 PM

I really would like to have blog like news included on:
http://www.samsunguniverse.com/index.php
under 'Samsung news' and then not in vbb style. But I still want the messages there also to appear in the forum as it does now.

Is there anyway to do this? I know some php code but divinginto vbb codes.

There is actually a way built into news.php to do something similar to this. First, you would have to make your own template so that it looks the way you want. Let's call it news_threadbit_main. You might have newsdisplay_main also (but this might take you some time).

In your .htaccess file, add new rewrite rule. If the rewrite engine is not yet on just say "RewriteEngine On"

In this case, your new rule would be:
RewriteRule ^index.php$ news.php?do=main&f={FORUMID} [L,QSA]

Create a plugin at cache_templates:
if ((THIS_SCRIPT == 'newsdisplay') AND (MAINNEWS == true))
{
$globaltemplates[] = 'news_threadbit_main';
$globaltemplates[] = 'newsdisplay_main';
}

Create a plugin at global_start:
if ((THIS_SCRIPT == 'newsdisplay') AND (MAINNEWS == true))
{
$vbulletin->templatecache['news_threadbit'] = $vbulletin->templatecache['news_threadbit_main'];
$vbulletin->templatecache['NEWSDISPLAY'] = $vbulletin->templatecache['newsdisplay_main'];
}

Hope that helps!

TheMilkCarton

03-26-2007, 09:29 PM

I almost got everything sorted out.... I keep adding spacer_open and spacer_close everywhere and shownews is almost looking right now. Whenever there are no comments, the "No Comments" box stretches to 100% width though, so now I need to figure out where to put more spacer_open and closes.

I think I read somewhere in this thread where someone was having problems, so you "fixed" the spacer stuff in your next release.. Well I definitely think that person had something wrong with their board, since I haven't touched my spacer templates, and maybe you should look into fixing it back the way you had it.. Just a suggestion though. :)

Edit: I had to add another spacer into the news_comments template so that articles with no comments would show correctly.

I also had to completely comment out the "Forum Description" type stuff in my navbar. It was really acting up with forums that had descriptions in news and shownews.

I also noticed a bunch of extra whitespace at the bottom of the popup when you click on the poster's name... sure it's easy for me to fix in the template though. :)

thincom2000

03-26-2007, 10:03 PM

However, in news and shownews.php I don't get a dropdown box like I should when clicking on the RSS button. It takes me to the same RSS feed I would get if I clicked on the RSS button the main forums. In shownews and news.php it should be giving me a dropdown to select the RSS feed for that specific forum. I'm not really worried about this though...

I'm unfamiliar with the "RSS button" of which you speak. Is this another hack, or vBulletin's stock RSS Feeds feature?

Also, you mentioned Main Table Width is 800. What is your Form Width?

I also had to completely comment out the "Forum Description" type stuff in my navbar. It was really acting up with forums that had descriptions in news and shownews.

If you're not ready to post a link, maybe a screen shot? I would like to look into this since it makes absolutely no sense.

thincom2000

03-27-2007, 06:07 AM

Anyway I found the source of the spacer problems and that fix is included for sure this time. As for the forum description, that is handled like any other forum, so I don't see the reason you are having problems. Maybe once you switch to the updated 1.3.0 templates it will go away, since apparently there are a bunch of template changes I never released.

thincom2000

03-27-2007, 04:12 PM

Found another bug. Not sure if it was in 1.2.4 or just appeared in the process of updating the product, but when an article has more than 1 attachment, only the first attachment shows on Newsdisplay.

If this was not the case in earlier versions, don't worry about it, because it has been fixed in the next update.

thincom2000

03-28-2007, 10:05 AM

Have you tried adding a forum description on one of your own news forums to test it out?

And just being nosy... is 1.3.0 coming along well? :) I'm very excited for all your changes

All of the forums on my site have Forum Descriptions working without problems...

Version 1.3.0 is coming along very well. I hope to sit on the release another day or so to sort out any bugs I may not have noticed yet and to think of any other features to add. As of yesterday working on 1.3.0 resulted in the discovery of another Forumdisplay optimization that I will release soon as well.

thincom2000

03-28-2007, 11:42 PM

I didn't realize it did that. Of course I'll add the Who's Online Location.

thincom2000

03-28-2007, 11:49 PM

Here's the Changelog so far for v1.3.0. If you want anything to make it into this update that you don't already see here, let me know.

As of Version 1.3.0:
- simplified threadbit processing with function calls
- simplified comment header code
- fixed thread icons
- fixed spacer problems on Shownews
- fixed bug on Newsdisplay where only 1 attachment would show
- added forum sorting tools to Newsdisplay
- added attachment paperclip & count to Newsdisplay
- added new hook locations (integration with CES Pre-Processing Hooks)
- added Who's Online Locations
- added missing phrases
- added template group for easier template editing
- renamed all templates
- templates ready with forum headers (integration with vbWiki Pro)
- moved search tools from above comments to above article on Shownews
- updated files: news.php, shownews.php, ces_news_functions.php

thincom2000

03-29-2007, 02:31 AM

No you don't. But if you do install Pre-Process Hooks (which I recommend, so far I've been able to take 1 query out of showthread, and next update - found 1 to take out in forumdisplay while making 1.3.0), you don't need to edit the 1.3.0 files. Also the Pre-Process Hooks reduce tons of queries in Event Forums if you have that mod or were considering it.

To answer your question about the sorting: default sort order and sort options both work.

thincom2000

03-29-2007, 03:18 AM

I would honestly wait on the Pre-Process Hooks install until I add the forumdisplay_preprocess hook to the product and install instructions.

thincom2000

03-30-2007, 04:20 AM

Wow, I remember that. I'm surprised I still hadn't fixed it.

thincom2000

03-31-2007, 01:49 PM

Version 1.3.0 has been released. There's a lot of changes in this version. If you find anything else, let me know.

EDIT: I have already fixed the Quick Reply/Multiquote bug for the next update, but I would like to hold it back until some people can confirm they haven't found any others.

thincom2000

04-02-2007, 03:32 AM

I don't know why you needed to do that. I hardcoded the spacer into the comments template...

thincom2000

04-02-2007, 10:56 AM

Okay for some reason the Inline Mod class is breaking on Internet Explorer and causing a whole bunch of problems. I will try to figure it out even though I don't think I ever touched that stuff in the first place.

EDIT: Fixed this issue. Your cookies error is most likely a direct result of the array_slice() warning because by outputting the warning the headers were sent. I know why this came up and I'll correct it for next fix. Haha, I just wish I had seen your post before releasing 1.3.1 or I could have actually made it a worthwhile update.

On the other hand that Postbit Switch Glitch on Quick Edit is quite the bugger. I had quick edits turned off on my forum so I never noticed this before. I've followed Quick Edit through vBulletin's code and still have no idea where this switch is taking place.

If somebody knows where the vB_Ajax_Init class is defined, that would get me on the right track. If you don't know off hand don't waste your time because it seems to be pretty well hidden.

thincom2000

04-02-2007, 10:53 PM

I don't understand your redirect issue. I have disabled my news forum, it displays as a regular forum, and all the links still work...

thincom2000

04-03-2007, 12:48 AM

I don't know why there was an issue with that. The way the hack was configured, any thread or forum could be viewed as news by using news.php or shownews.php. I have fixed this behavior for 1.3.2 so that if it's not a news forum or article, it redirects to the appropriate forumdisplay or showthread page.

Right now I'm trying to fix the array_splice() error you reported.

thincom2000

04-03-2007, 01:51 AM

Sorry I took so long to post a fix tonight. In the process of making all these changes, I hit the PHP Memory Limit for my server and it took me a while to figure out where the conflict was that I even needed to increase it beyond "No Limit."

Brandon Sheley

04-03-2007, 03:26 AM

was there ever a live demo posted ? I search a few pages back but didn't see one.

thanks thincom2000

-Bs

thincom2000

04-03-2007, 03:49 AM

The link to the live "demo" is in the first post. Not really a demo, but that's my forum with it installed and working. Please note that what you see in the demo can sometimes be an update ahead of what you can download here, because well I need to test things first.

thincom2000

04-04-2007, 03:33 AM

On the other hand that Postbit Switch Glitch on Quick Edit is quite the bugger. I had quick edits turned off on my forum so I never noticed this before. I've followed Quick Edit through vBulletin's code and still have no idea where this switch is taking place.

For now, unless someone knows where in the code this happens, my "fix" will just to avoid the glitch by disabling Quick Edit in the first post (article) of News forums. This will be in the next update, but this time I'll wait to release so you can list the 12,000 errors you find first, TheMilkCarton. :)

EDIT: Found it and fixed it by updating a plugin. That was a really convoluted search, though.

dizzy100

04-04-2007, 10:01 AM

I've been putting of updating this on my live website as it worked well (earlier version) with Andreas sidebars hack.

However now you seem to have moved or done something with $spacer as i tested it on my local machine and the postbit is breaking out of the style and pushing everything to the right.

What did you remove from postbit ?

dizzy100

04-04-2007, 10:26 AM

OK found the problem i think

Its in ces_news_comments

removing

<div style="width:$stylevar[outerdivwidth]; text-align:$stylevar[left]">
<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

Fixes the problem.

What was that included for ?

thincom2000

04-04-2007, 11:02 AM

That is $spacer hardcoded, so removing it should make no difference.

If you still have a showthread_postbit_create plugin, then that may be the cause. Remove that plugin if it still exists. Also, try removing $post[news_comments] from your postbit template.

Another cause may be if you have not uploaded the most recent shownews.php.

dizzy100

04-04-2007, 11:42 AM

Mmm i don't see $post[news_comments] in the ces_news_postbit template, haven;t got a plugin that is either called or hooks to showthread_postbit_create and i did upload the latest php files.

The only way i can get the layout right is to remove the div.

Ironically if i replace the ces_news_comments with one of the older ones (i think it must have been version 1.1.1 or slightly later) that displays fine also.

So its the DIV causing me issue and removing it means everything seems to display perfectly.

So theres no downside to removing the DIV ? If so i'll just do that and upgrade my live site.

thincom2000

04-04-2007, 03:31 PM

There's no downside unless you use a Spacer Size of greater than 0 in your style's CSS settings. When this is more than 0, the divs keep it the same size as the post it's over. Strangley enough the issue you describe as being caused by the divs was solved in this subversion by adding the divs. :confused:

Could just be discrepancies between various vBulletin styles.

dizzy100

04-04-2007, 03:39 PM

Its highly possible.

I know Andreas Ultimate Side Columns plugin has had issues with spacers and i had to create a plugin for that to keep it from doing that very thing i reported in a previous post to regular forum postbits so its more likely that plugin affecting this one than the other way around.

However your modification remained unaffected on the older version and it was only on upgrading did it start to behave against that module.

I used a modified version of the default theme.

Anyway no harm done and as long as i can upgrade by removing that DIV i'm a happy camper.

BTW, i'm amazed how much work you put in to this and the level of support you do and yet we only have 29 installs. This is one superb module and my users love it.

dizzy100

04-04-2007, 04:07 PM

One thing i miss on the old version was you had a kind of seperator on the threadbit between the last comment, edit and quote buttons and the actual content.

As before when my lead in picture was quite large, the layout would sort itself out nicely. Now however, it pushes that quote button etc of to one side.

OR Better still, edit and quote to be removed entirely as i think they belong only in the postbit and not the threadbit.

Where was that and how can i put it back in ?

thincom2000

04-04-2007, 04:36 PM

In older versions the postbit and threadbit were tables with multiple rows. I actually received complaints about the very separators you're talking about, which was actually just your tborder background color showing between cells.

Since there were complaints, I eliminated the extra table rows by changing them to divs. You can easily experiment and change them back.

dizzy100

04-04-2007, 04:37 PM

No problems, i guess its a case of not being able to please everybody :)

One bug ive found is the WOL plugins arn't working.

I'm still seeing

Unknown Location
/forums/shownews.php?p=8465

thincom2000

04-04-2007, 04:48 PM

I can confirm that the Who's Online Locations stopped working in the most recent version for some reason.

Fixed for next update.

dizzy100

04-04-2007, 05:00 PM

no problems, as long as you know :)

Tannim

04-04-2007, 06:24 PM

Ok, this is a huge thread ..

What I want to do is have multiple forums (categories and sub forums) threads listed as news. Is this possible with this mod?

thincom2000

04-04-2007, 10:57 PM

Yes. But if you want subforums of a News forum as news, you need to link to it somewhere else because as is the Newsdisplay template can't handle subforums under them.

To fix this, just copy & paste the
<if condition="$show['forumslist']">

...

</if>
segment of your FORUMDISPLAY template into your ces_newsdisplay template.

I am adding this for the next version, as well as the ability to have parent News forums pull threads from their children.

TheMilkCarton

04-04-2007, 11:25 PM

I can confirm that the Who's Online Locations stopped working in the most recent version for some reason.

Fixed for next update.

Actually, WOL was never working in any of the updates. Even the one that you reported the fix in.

I forgot about mentioning that.. whoops. :)

Everything works now, although to update the template for IE I had to open the XML file and manually copy the code over. I've had to customize your templates so I guess Allowing Overwrite doesn't work when importing an updated XML file?

So, from now on can you include a text file with the template changes whenever you update templates?

thincom2000

04-04-2007, 11:50 PM

If you have made template edits, you need to Revert templates after importing the XML with Allow Overwrite for them to be updated.

Also, I remember WOL working for me for a time, at least in an early version of 1.3.0. They might have gotten screwed up before the final release in this thread. :rolleyes:

dizzy100

04-11-2007, 08:17 PM

I've found a serious bug. Some of the comments within a thread do not display with this hack enabled.

I noticed it after a member posted a comment that would have been on page 3. I couldn't find the comment anywhere in that thread so disabled the news module to see why. The comment was there and nothing appears to be wrong with it, displaying normally within the vbulletin default view.

Concerned with this i re-enabled the CES news plugin and sorted by most comments first, looking at where the last comment in some of my longer threads ended. Then i turned of the CES and again looked at the same threads and have seen comments i haven't seen before listed there. So my poor members have been posting comments that simply haven't been showing up whilst using this mod.

Until a fix can be sorted i have disabled this on both forums i use it on. I love the mod, but not at the expense of my users comments.

thincom2000

04-12-2007, 04:36 AM

Okay, I have confirmed the problem you reported. Thanks. Working on a fix.

thincom2000

04-13-2007, 12:32 AM

I noticed it after a member posted a comment that would have been on page 3. I couldn't find the comment anywhere in that thread so disabled the news module to see why. The comment was there and nothing appears to be wrong with it, displaying normally within the vbulletin default view.

This bug seems to have existed since the mod was released in January, and remained unnoticed until now. This has been fixed in the newest update, along with some other tweaks to the features added in this subversion.

AzH

04-18-2007, 09:44 PM

INstalled. Thanks. Demo: http://lurkingmastermind.com/forums/news/

thincom2000

04-29-2007, 03:56 PM

Is there a particular reason you have the previews all blank?

If this isn't some preview length glitch, you may want to at least include a summary by using [preview], or modify the ces_news_threadbit template so you don't have empty boxes everywhere.

thincom2000

05-18-2007, 04:28 PM

I just started going through my site for XHTML Transitional validity. I will be posting another update soon since there seem to be a number of validation errors in this mod.

I will also be updating the templates with 3.6.6's new template hooks.

Demo16

06-01-2007, 01:17 PM

Great mod!!
I have only 2 problems (see attachment):

1 - The "comment" bar is at the left not center
2 - Not registered users doesn't see anything (permissions are ok)

thincom2000

06-01-2007, 02:46 PM

Strange that Unregistered users do not see anything for you. I have noticed this on some other sites and thought it may have something to do with the settings for previewlength. I am running this mod as my site's main page, and do not seem to be having any problems... Please report your other settings.

Demo16

06-01-2007, 09:03 PM

what other settings? and about point 1?

thincom2000

06-02-2007, 03:18 PM

Unregistered users are seeing blank because you have default Forum Permissions set where Unregistered Users cannot view Thread Content. AdminCP -> Forums & Moderators -> Forum Permissions -> Forum Viewing Permissions -> Can View Thread Content. Make sure this is set to yes for all Usergroups in News forums. I will add a plugin to override AdminCP settings in the next release.

For your other issue, have you modified the ces_news_comments template? There is no case that I have tested where you can have a disembodied Comments header without the corresponding "No Comments" message.

Demo16

06-02-2007, 10:17 PM

Permission are ok I see only Thread content when in shownews page.

Here http://www.dpcgamers.com/forum_it/news.php?f=47 I can't see anything
Here http://www.dpcgamers.com/forum_it/shownews.php?t=164 I can see content

For the ces_news_comments template....I don't have the file. What you mean?

I have only this files:

In forum/
-------------------------
- upload: news.php
- upload: shownews.php

In forum/plugins/announcements/
-------------------------
- upload: announcementdata_postsave.php

In forum/includes/
-------------------------
- upload: ces_news_functions.php
- upload: ces_news_bbcode.php

and I've leave them as they were.
One more thing I have the latest vb version the (vBulletin 3.6.7 PL1)
bye

Demo16

06-04-2007, 08:43 PM

So what do you think is the problem?

thincom2000

06-05-2007, 05:50 AM

Okay I think I have discovered the problem.

Do you have thread previews disabled on your forum?

AdminCP -> vBulletin Options -> Forum Display Options -> Length of Thread Preview Text

Demo16

06-05-2007, 03:53 PM

It's set to 150

thincom2000

06-05-2007, 05:20 PM

Hm... setting the Thread Preview length to 0 was the only way I could reproduce what you reported other than setting the permissions for Can View Thread Content to no...

Do you have any other mods installed that use Thread Preview?
Also, what other mods do you have installed that use forumdisplay hooks?

For example there was an AJAX Preview that I considered using for a while.

thincom2000

06-08-2007, 03:56 PM

Try this file edit and let me know if it solves the problem... It did for me, but you may have something else conflicting.

In news.php find:
// disable thread preview if we can't view threads
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewthreads']))
{
$vbulletin->options['threadpreview'] = 0;
}

Replace with:
// disable thread preview if we can't view threads
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewthreads']))
{
$vbulletin->options['threadpreview'] = 0;
}
else
{
$vbulletin->options['threadpreview'] = 1;
}

Demo16

06-14-2007, 04:47 PM

Sorry thin I was out of my home since today. Ok I'll try it tomorrow tnx

Chadi

07-24-2007, 08:00 PM

I do not know what happened, but suddenly the main page of CES News is all blank, unless you click on each individual post

http://www.talkjesus.com/newsces.php?&f=72

I'm using v1.4.1

thincom2000

07-25-2007, 02:46 AM

Okay thank you for reporting this. I had first seen this on your forum and thought maybe you configured it like this on purpose. This could be happening because you may have thread previews disabled.

In news.php find:
PHP Code:
// disable thread preview if we can't view threads
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewthreads']))
{
$vbulletin->options['threadpreview'] = 0;
}

Replace with:
PHP Code:
// disable thread preview if we can't view threads
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewthreads']))
{
$vbulletin->options['threadpreview'] = 0;
}
else
{
$vbulletin->options['threadpreview'] = 1;
}

In CES News, the threadpreview setting is treated as a 0 = off, 1 = on value.

Please let me know if this fixes the problem. If it does, I can upload a new version with a few optimizations.

Chadi

09-02-2007, 06:11 PM

This seemed to have happened before. I am using the highslide hack here https://vborg.vbsupport.ru/showthread.php?t=139167

When viewing the actual blog post on my site, it does not show the attachments at all, unless I'm viewing the blog main page, which it shows the attachments plus the highslide correctly.

How do I fix this in the news mod?

thincom2000

09-03-2007, 04:04 PM

Hm... I tried installing highslide to test this. I am not seeing the bug you have described. First, make sure you are using the most recent version of that hack. The newest one requires no file or template edits, so you should undo any you may have done for the old version.

If this does not help, perhaps this is a result of one of the few small fixes on my site. I will have to package my current version early this week anyway since I have long delayed releasing it.

Chadi

09-03-2007, 05:09 PM

All my hacks are always up to date actually. Yours also and the highslide one as well.

Chadi

09-03-2007, 06:50 PM

This is happening again. Getting the purple background behind the comments area.

Also, replies made are not showing up as comments, which still shows "0" even though replies were made to the blog post. Am I missing something?

the news_comments template is default, showsnews is also default

thincom2000

09-03-2007, 08:56 PM

Hm... I checked your site and the only thing that appears to be out of order in my browser is the purple background.

In the news_comments template add class="page" to the first div. This should fix the problem. I will include this in the next release (even though I thought it was there already for a very long time ???).

Ba$im

09-03-2007, 08:59 PM

Its look like very nice
I wil try it soon

thanks for gr8 job

Chadi

09-03-2007, 09:25 PM

Now it shows another purple bar below the comments box.

http://www.talkjesus.com/shownewsces.php?t=15408

I also did as you said

<div class="page" style="width:$stylevar[outerdivwidth]; text-align:$stylevar[left]">
<div style="padding:0px $stylevar[spacersize]px 0px $stylevar[spacersize]px">

Also, the highslide does not work still when viewing the blog post itself, only in blog main page.

thincom2000

09-04-2007, 02:08 PM

Aha, progress. Trust me, the purple box has gotten smaller. Somewhere in your templates there is an extra <br> tag. Check your news_comments template again. If there is a <br> tag at the end, remove it.

As for highslide breaking, the only explanation I can give is that your current version shownews.php is based on showthread.php from vBulletin 3.6.7. When I release the one updated for 3.6.8 this week, it should hopefully solve that issue.

thincom2000

09-09-2007, 07:46 PM

Version 1.5.0 has finally been released. This version includes the changes that were made to showthread and forumdisplay since 3.6.7, including template hooks and the like. This should fix a number of issues users have been having since then, and several bugs that occurred in some configurations have been fixed.

Chadi

09-10-2007, 01:14 AM

Just upgraded to latest 1.5.0 version

Something is still not right. There is a forum blog post I made on 09/02/2007. It shows up first in the list, even though newer blog posts have been made after, twice. Why is that? It is also the only one with actual comments made (since I finally enabled that option for members). Is that the reason?

thincom2000

09-10-2007, 01:16 AM

The default sort order for your forum may be set to "Number of Replies", "Last Post Time", or something (I'm pretty sure the second one is the default order for any forum). I'm pretty sure for most news forums, you want the forum's default sort order to be "Thread Start Time," but you have to configure this yourself when you create the forum.

Also, I just noticed your comments header does not look quite right when there are no comments. Did you remember to revert this template? Actually, did you revert any of the templates? Because when selecting Hybrid or Threaded Mode in your News forums very weird things happen. Make sure to check the readme for the templates that have been changed.

blastup

10-28-2007, 02:30 PM

on my forum.. it displayed a blank? on http://millionwebmasters.com/news.php?f=2 ... idk why.. would vbseo or vbadvanced cmps cause errors on this.. please help me asap thanx

thincom2000

10-28-2007, 04:23 PM

Well I checked it out and everything seemed fine. There's no way to navigate there from the rest of the site but that may be because you're still testing.

blastup

10-29-2007, 05:35 PM

dame lol i replaced it with another news program that i found lol.. but it displayed blank for me before.. for your program.. i would really like your program better if it worked.. i dont know what caused the error.. but i think maby with my vbadvanced cmps or my vbseo that caused the error but i dont know.. what do you think would cause a blank page? let me know asap thanx cuz i would really like your program

thincom2000

10-31-2007, 06:06 AM

You would have to check your error logs and see what happened or show me a setup that can reproduce it. Again I didn't see any errors in the mod when I browsed your site last time you installed it.

blastup

10-31-2007, 01:04 PM

um that was another program not from yours.. on news.php ...becuase yours dosent show up on my site so i switched it... ill try to see what happend.. then till you later

SBlueman

10-31-2007, 11:54 PM

Is there a way to integrate:

* Thread Prefixes
* Zoints Topic Tag

And also is there any way to display the news in a vbadvanced news module with pagination?

thincom2000

11-01-2007, 04:33 AM

For the first two, there should only be the issue of editing any templates. All the hooks from showthread and forumdisplay are the same in this mod, so any plugins should affect it in the same way.

As for the vbBAvanced module, I have never been a fan of vBA, so I'm not sure how it really works. If you have "Grab articles from child forums?" enabled for a forum, or any values filled for "Other forums to grab articles from.", then that particular forum should be functioning similarly to what you may want - that forum will include articles from its children, etc, in its pagination.

Chadi

11-04-2007, 10:43 PM

This is not working right with highslide mod that I've installed.

It shows highslide image view on the blog main page, but not the submission (post) directly.

Example:
http://www.talkjesus.com/newsces.php?f=72 (works)

Ewample:
http://www.talkjesus.com/shownewsces.php?t=16696 (highslide image missing)

thincom2000

11-05-2007, 06:29 PM

It may be an incompatibility resulting from some support for another hack I released...
Do you have CES Pre-Process Hooks (or whatever they are called now) installed?

It's likely one of the conditions that checks for it isn't parsing properly.

Chadi

11-05-2007, 06:34 PM

I've attached what I see in plugins area. Not sure what else you want me to look for.

thincom2000

11-07-2007, 03:59 AM

Fixed your issue and some other template stuff. ZIP updated.

Chadi

11-07-2007, 11:24 AM

Thanks for the effort, but unfortunately it still does not show the image attachments on specific post view instead of blog home

http://www.talkjesus.com/shownewsces.php?t=16696

Blog home (works fine)
http://www.talkjesus.com/newsces.php?f=72

thincom2000

11-07-2007, 03:43 PM

There was a typo in shownews.php, I have reattached the ZIP (no version number change). Just replace the shownews.php file and all should be well.

Chadi

11-07-2007, 04:51 PM

Awesome brother thanks! Your an amazing and speedy programmer!

emtee

11-08-2007, 12:26 AM

This is a great hack, but there is a bug/problem: the news displayed is not in the same order when the forum is in forum mode. I want the news display exactly like it were in forum mode (latest news or news with latest comments are to be shown first).

Can you tell me how to fix it? Thanks a lot!!!

thincom2000

11-08-2007, 06:15 AM

It functions like a normal forum in terms of sort order. The default is different if you don't set one, but this is considered a feature, not a bug, in order to keep recent news at the top (prioritizing the news itself over the comments). However, you can set the desired behavior in the Forum Manager by modifying the Default Sort Order.

emtee

11-08-2007, 10:24 AM

thincom2000

11-08-2007, 04:03 PM

I set Sort by Last Post Time with order Descending, but the latest news not yet replied supposed to be showned first, but it's not. Instead, it's somewhere in another page in the middle. That means Last Thread with no reply has lower priority than the thread with latest comment, doesn't it? Is it supposed to be like that?

Sort by Last Post Time Descending shows the thread with the most recent start time (if replies = 0) or reply (if replies > 0) first, followed by the second most recent and so on.

"Latest news not yet replied" would be Sort by Number of Replies, Ascending. This would show threads with 0 replies first, 1 reply second, etc. Where more than 1 thread has X number of replies, I believe it would sort only those threads by Thread Start Time Descending, since that is default with this mod.

As you can see the Last Thread with no reply should have lower priority only if Sort by Number of Replies is set to Descending, or if that is not even the sort order at all. I'm not sure I understand exactly what you wanted to achieve, but glad you were able to do it.

HybridIllusions

11-24-2007, 09:27 PM

Is there a way to make this a feed? vBulletin and my main site as linked, but not as one. The main site doesn't use vBulletin, but can use vBulletin functions is what I mean.

Is there a way to use this like a feed? I wish ot use this as a news system on my website via feed.

TonyComix

11-25-2007, 09:50 PM

Well I did all the instruction to install it, but when I post something, I don't see it in the front page in the forum. When I go to news.php it says:

Invalid Forum specified. If you followed a valid link, please notify the administrator

I made sure everything was installed, but nothing.

Everything else works, except for all the things like news.php and displaynews.php ( or something like that ) and displaying news at the top of forum home.

Help?

Saviour

11-25-2007, 10:01 PM

LOL!

This is really no different than using the RSS feed in vbulletin. One more thing...the demo link retrieves a database error.

TonyComix

11-25-2007, 10:05 PM

LOL!

This is really no different than using the RSS feed in vbulletin. One more thing...the demo link retrieves a database error.

it was working yesterday, in fact, it was working a few hours ago.

thincom2000

11-28-2007, 05:58 AM

Well I did all the instruction to install it, but when I post something, I don't see it in the front page in the forum. When I go to news.php it says:

Invalid Forum specified. If you followed a valid link, please notify the administrator

This is really a modified version of forumdisplay and showthread. I could have done the whole mod with plugins but decided to give server memory a break and just hardcoded them as their own files. Basically that means you need to have the forumid in the url like you do in forumdisplay. This will only work for the forums you set in the AdminCP.

If you are trying to do something like my demo where the page is main.php, this is done with ModRewrite.

In your .htaccess file add the following line to your rewrite rules:
RewriteRule ^main.php$ news.php?f=XXXXX&do=main [L,QSA]

Where the XXXXX is replaced by the forumid you want for your main news page.

Chadi

12-19-2007, 02:05 AM

Checked my blog today and suddenly getting this error

Fatal error: Using $this when not in object context in /home/user/public_html/includes/ces_news_functions.php(51) : eval()'d code on line 1

thincom2000

12-19-2007, 09:11 AM

I'm sorry but I don't own a vBulletin Blog license and hence can't support it. I would recommend just wrapping the call to that file in a condition that says

if (THIS_SCRIPT == 'newsdisplay' OR THIS_SCRIPT == 'shownews')

Not sure why I didn't do so already. In any case, there will likely be some issues with 3.7 so I'll be releasing an update shortly.

Chadi

12-19-2007, 12:04 PM

Where do I edit this? I don't own vb blog either, I just call your hack 'blog' because I use is as a blog per se.

thincom2000

12-19-2007, 06:34 PM

In that case, adding the condition probably wouldn't make a difference. Have you installed any new mods recently, or upgraded to vB 3.7?

I have checked the file you mentioned, and it doesn't use $this anywhere.

Chadi

12-19-2007, 06:42 PM

Yes, goldbrick media player
https://vborg.vbsupport.ru/showthread.php?t=150491

thincom2000

12-20-2007, 01:57 AM

Yes it seems the issue is with that mod's postbit_attachment.php plugin file. I plan to install that mod shortly. When I do I'll let you know what changes need to be made. In the mean time I recommend disabling it.

Chadi

12-21-2007, 10:56 PM

Unfortunately he claims it is not goldbrick

https://vborg.vbsupport.ru/showthread.php?t=150491&page=87

But I hope you can help at least. I do not have the expertise to trace the problem :)

Chadi

12-31-2007, 02:11 AM

Please help me out on this. I'd really appreciate it.

thincom2000

12-31-2007, 05:12 AM

Replace goldbrick's postbit_attachment plugin file with this:

<?php
/**
* Enables attachments to use Goldbrick
*
* @active true
* @version $Revision: 87 $
* @modifiedby $LastChangedBy: digitallyepic_nix $
* @lastmodified $Date: 2007-10-21 22:21:30 -0700 (Sun, 21 Oct 2007) $
*/
global $vbulletin;
$forumid = $vbulletin->GPC['forumid'];

if ($vbulletin->forumcache[$forumid]['gb_enabled'])
{
if ($attachment['visible'] AND $vbulletin->options['gb_enabled'] AND $vbulletin->options['gb_attach'])
{

$vbulletin->input->clean_array_gpc('r', array(
'gb_options_on' => TYPE_BOOL,
'gb_title' => TYPE_NOHTML,
'gb_width' => TYPE_UINT,
'gb_height' => TYPE_UINT,
'gb_autoplay' => TYPE_BOOL,
'gb_loop' => TYPE_BOOL
));

if ($vbulletin->GPC['gb_options_on'])
{

$gb_options = array(
'use' => $vbulletin->GPC['gb_options_on'],
'title' => $vbulletin->GPC['gb_title'],
'width' => $vbulletin->GPC['gb_width'],
'height' => $vbulletin->GPC['gb_height'],
'autoplay' => $vbulletin->GPC['gb_autoplay'],
'loop' => $vbulletin->GPC['gb_loop']
);
}

require_once(DIR . '/goldbrick/includes/functions_public.php');

$find = addslashes('</td> </tr>');

$replace = addslashes('</td> </tr>
<tr>
<td colspan=\"2\">$attachment[goldbrick]</td>
</tr>');

$vbulletin->templatecache['postbit_attachment'] = str_replace($find, $replace, $vbulletin->templatecache['postbit_attachment']);

$info = goldbrick_process_attachment(
$attachment['attachmentid'],
$vbulletin->userinfo['userid'],
$post['postid'],
$attachment['attachmentextension'],
$gb_options
);

eval('$attachment[goldbrick] = "' . fetch_template('gb_player') . '";');
}
}?>