Major Additions - QuoteIt! - Quote Database [Archive]

Cap'n Steve

01-01-2007, 10:00 PM

QuoteIt! version 3.1

I'm no longer able to put very much time into this mod, so I've set up a Subversion repository at http://www.vbulletinprogramming.com/projects/quoteit/ to allow others to help out. You can use the login "vbuser" with the password "vbulletin" to edit files. If someone would like to completely take over the mod, please contact me.

QuoteIt! allows you to have a database of quotes integrated with your forum. Users submit quotes that can then be voted on by the other users, using your choice of two rating systems. The average installation will show a random quote on the forum home page, but you can include it on any vBulletin page or on your portal home page.

If you'd like to see a demo, go to forums.monkeycrap.com (http://forums.monkeycrap.com).

Features:

Random Quote
- a random quote can be shown on any vBulletin powered page
- the administrator can set a default rating threshold that quotes must meet before showing up as the random quote
- a new random quote can be chosen at a specific interval of time, to reduce server load

Quote Database
- quotes can be searched, filtered, and sorted by many different criteria
- quotes have a "context" field that can be turned on or off to include more information about the quote
- quotes can be embedded in posts with bbcode
- each post and private message now has a "Submit to Quotes" link that allows users to quote things said on your forum more easily

Quote Ratings System
- quotes can be rated either plus/minus or on a scale from 1 to 5
- quotes below a certain total score or average score can be filtered out

Quote Management
- quotes can either be automatically approved or moderated
- the quote moderation que is like the que for posts, enabling the moderation of several quotes at once
- usergroup permissions are used for adding, editing, deleting, rating and viewing quotes
- most actions use AJAX to avoid page reloads

Don't forget to click install (https://vborg.vbsupport.ru/vborg_miscactions.php?do=installhack&threadid=135297)!

Currently known problems are listed here.

The files needed to edit the included images are attached to this post.

This hack is based on QuoteIt! 1.2, originally by magnus. The "submit post" feature was inspired by an addon by CtrlAltDel.

Older versions (no longer in development): QuoteIt! 3 for vBulletin 3.5.x | QuoteIt! 2.03 for vBulletin 3.0.x

Cap'n Steve

01-02-2007, 07:35 AM

These are the currently know issues with this modification:

Row colors are sometimes messed up in Internet Explorer 6.
Rebuilding languages will reset some QuoteIt! options.
In Internet Explorer, the closing quotation mark is missing from the random quote and quote bbcodes.
Quotes deleted with AJAX are sometimes visible until the page is refreshed.
The table border is wrong in some styles.

Cap'n Steve

01-02-2007, 07:37 AM

Here are the Photoshop (PSD) files used to make the graphics included in this modification. The stars used in the 1 to 5 rating system come from the official vBulletin graphics kit on vbulletin.com (http://vbulletin.com).

Mr_Snob

01-02-2007, 07:45 AM

very exellent work!
thenk yu ;)

Veer

01-02-2007, 07:46 AM

Looks Great... Clicks Install
But Hack file not found in Mod option.

Cap'n Steve

01-02-2007, 07:50 AM

You were too fast for me. It's there now.

Saskia

01-02-2007, 12:42 PM

When I go to quotes.php it redirects me to quotes.php?do=list and keeps on redirecting me there without opening any contents.

PS: Awesome that you finally got around to porting it. I greatly appreciate it!

Oddjob

01-02-2007, 02:59 PM

buileminh

01-02-2007, 03:18 PM

This so nice! Installed :)

projectego

01-02-2007, 03:39 PM

Awesome!

/me clicks install

Saskia

01-02-2007, 05:06 PM

I also noticed that it breaks my PM inbox page, so I uninstalled it for the time being until it becomes slightly more stable.

Good job so far though!

Cap'n Steve

01-02-2007, 08:37 PM

What version of vbulletin do you have? Are there any quotes in the database? What error do you get when viewing private messages?

Cap'n Steve

01-03-2007, 12:33 AM

The PM bug is fixed, but I still can't reproduce the redirect problem. Any information would be helpful.

jluerken

01-03-2007, 07:49 AM

Hi,

when I try to import the product I get the following error message

Fatal error: Cannot redeclare class vs_hhr_engine in Unknown on line 0

Firen

01-03-2007, 10:33 AM

It's late here so I may have missed something. But is there a way to delete quotes? I put one in there to test it out, but want to delete it. Can anyone help please?
Very nice hack by the way! :)

Saskia

01-03-2007, 11:52 AM

What version of vbulletin do you have? Are there any quotes in the database? What error do you get when viewing private messages?
I'm running vB 3.6.4. There weren't any quotes in the database yet, but I can't get to the page that will allow me to add them. Call me blonde but I didn't find the appropriate option in the AdminCP to add links through there. Is there an option for that? (If not, that would be a nice addition.)

jluerken

01-03-2007, 01:38 PM

I managed to install the hack now and its great but its messing up the "Quick Language Chooser". After installing it its adding nonsense to the language chooser.

After uninstalling its fine again so I think it has something to do with this hack.

BEFORE INSTALLATION:
https://vborg.vbsupport.ru/

AFTER INSTALLATION:
https://vborg.vbsupport.ru/

If I open the Language Manager in the AdminCP there is no third language.
When I edit one of the languages that are installed and simply press on save
the field is correct again.

I can life with that but I still think that there is a problem with this hack :-)

Rick

01-03-2007, 02:50 PM

Would you be interested in making another hack based on this same prinicple, but with photos instead of quotes??

It would be great to let users submit photos to be voted on:D

Calash

01-03-2007, 03:09 PM

The PM bug is fixed, but I still can't reproduce the redirect problem. Any information would be helpful.

This happens when there are no quotes in the database and you try to go to the page, it just loops you trying to go to quotes.php?do=list over and over.

The only fix I could find was to manually type into the url /quotes.php?do=addquote

Then I added one in there, now it worked.

I am getting javascript issues when I click the edit button, and I can not get a random quote to show up on forum home.

Edit - I am also getting the language dropdown bug as listed above, but I only have 1 language installed to begin with. Selecting the "--a" option takes me to the "Who is Online" list.

Brew

01-03-2007, 09:04 PM

I get this error when trying to install:

Fatal error: Cannot redeclare cache_templates_with_file_cache() (previously declared in /path/public_html/forums/template_cache.php:2) in /path/public_html/forums/template_cache.php on line 2

version vB3.64

Any ideas what I should do?

Thanks!

Brew

01-03-2007, 09:20 PM

BuRuNDi

01-03-2007, 11:02 PM

Hello,

I got two problems

1- Can't enable the categories option
2- The random quote doesn't show up in the forum home

Cap'n Steve

01-04-2007, 01:38 AM

Firen - There's a delete link on each quote. Make sure you give yourself permission to do that through the Usergroup Manager.

jluerken - That class must be part of another product, I don't know what would cause that error though.

Rick - You could use the [img] bbcode in quotes to do that if you wanted. It's not a great solution, but it should work.

BuRuNDi - What exactly is the problem with categories? Have you added a category?

To everyone who has a problem with the random quote, make sure you did the template edit right and make sure you have the random quote enabled in the options.

The redirect problem should be solved. I don't have the slightest clue what's causing it to add to the Quick Language Chooser, but I'll keep looking.

Cap'n Steve

01-04-2007, 06:50 AM

Reporting quotes and notifying users of quote approval via PM are working now.

I am getting javascript issues when I click the edit button

What specifically are you doing, what's the error, and what browser are you using?

Calash

01-04-2007, 12:23 PM

I am getting a new error with the most recent download

http://www.necrotania.com/vb/quotes.php

Getting a 500 Service error.

Edit: The 500 error went away when I forced a quote into the database.

I still get the Javascript error, and the addition to the language bar. Also it just does not look right with the current skin.

Here is the javascript error

Line: 283
Char: 5
Error: 'agent.handler.responceXML.documentElement' is null or not an object
Code: 0
URL: http://www.necrotania.com/vb/quotes.php

When I am on quotes.php and see the sample quote there is a "Delete this Quote" link followed by an Edit button. When I press the edit button the error shows up.

Browser is IE6. I have not tested from home yet where I have IE7

jluerken

01-04-2007, 01:34 PM

I managed to install the hack now and its great but its messing up the "Quick Language Chooser". After installing it its adding nonsense to the language chooser.

After uninstalling its fine again so I think it has something to do with this hack.

BEFORE INSTALLATION:
http://www.clanforums.com/gallery/files/3-quote_uninstalled.jpg

AFTER INSTALLATION:
http://www.clanforums.com/gallery/files/3-quote_installed.jpg

If I open the Language Manager in the AdminCP there is no third language.
When I edit one of the languages that are installed and simply press on save
the field is correct again.

I can life with that but I still think that there is a problem with this hack :-)

I found out that when I open the Language Manger and correct the problem it turns off the Hack. There is definetly a problem with v.3.0 :(

Amiga Harrison

01-04-2007, 03:23 PM

I'm getting some strange behaviour with QuoteIt! on my forum.

I'm running the newest version of this on vB 3.6.4

The first is the Quote Filtering Options. In Firefox if I move the mouse over any of the Categories listed in the selection box I get a popup alert box appear showing that categories description. I cannot select any of the categories in the list as each time I move the mouse over any of them this popup box appears. However in Opera this doesn't happen and I can select categories from this list without a problem.

The second problem is editing a quote entry. Again this is in Firefox and I haven't yet tested this in another bowser. When I click on the edit quote button nothing happens. If however I select to open the link in a new tab or window then it will load the editing window.

Then once I have finished editing a quote and save it I get the following error:

Found
The document has moved here.

Additionally, a 500 Internal Server Error error was encountered while trying to use an ErrorDocument to handle the request.

nelstaresthero

01-04-2007, 08:16 PM

none of my pictures work, i tried re-installing and manually dropped them in their respective locations on the server with no luck...

suggestions?

Amiga Harrison

01-05-2007, 12:18 AM

none of my pictures work, i tried re-installing and manually dropped them in their respective locations on the server with no luck...

suggestions?

Do you mean the pictures that come with QuoteIt! ? The quotation marks, submit button etc? Are you using a custom template with it's own set of images on your forum? If so you will need to copy the QuoteIt! images into the relavant places within your custom templates image directory.

Cap'n Steve

01-05-2007, 03:46 AM

nelstaresthero - Amiga's right. Each style has its own images directory. You could right-click the broken image and select properties to find out where it is.

jluerken - What did you do to correct the problem that uninstalled the hack? When I select "Rebuild All Languages", just the problem goes away.

Calash - Your problem is that responseXML is spelled wrong. I don't know how that happened though, since it's not like that in any of my files. Just reupload all the files.

everyone getting the 500 server error - I've made a change to the redirects. If it still doesn't work, you need to talk to your host because your server is sending an extra status code.

Anyway, the popup on the categories list is fixed and the Quick Language Chooser should be, too.

jluerken

01-05-2007, 06:34 AM

jluerken - What did you do to correct the problem that uninstalled the hack? When I select "Rebuild All Languages", just the problem goes away.

No the problem is not gone then. Enabling, Disabling the hack brings the problem with the language choose also up again.
Please check this again, there is something wrong with the hack..

Cap'n Steve

01-05-2007, 07:13 AM

You need to install the latest version.

efil

01-05-2007, 08:24 AM

Hi,
I have some problems with this mod,

1.My forum is in hebrew (rtl) and i don't get the Quote in the frame (see pic 1). also the I need the table above the Quote to locate to the right side. (see pic 2).
2. Some options In admincp can not be save.

Calash

01-05-2007, 09:29 AM

I am still getting the Javascript error. I may have misspelled it when I copied the error code to the forum.

I am also getting the language bar error listed above. Rebuilding the languages did fix it for me for the moment.

The 500 error is gone, it takes me to a screen to enter a new quote.

jluerken

01-05-2007, 12:51 PM

I am also getting the language bar error listed above. Rebuilding the languages did fix it for me for the moment.

I have the same error like efil is posting above. The template is not correct.

Calash can you please turn on the random quote and turn off the random quote in the hack a few times? Afterwards please take a look at the language chooser. The error must be there again :(

MaestroX

01-05-2007, 01:56 PM

I'm having a problem, anytime I go to quotes.php the page is blank. Any ideas?

soulplayer

01-05-2007, 02:34 PM

Hy,

I'm having this problem:

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT * FROM vb3quoteratings
WHERE quoteid IN () AND userid = 5;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND userid = 5' at line 2 Error Number : 1064
Date : Friday, January 5th 2007 @ 05:26:54 PM
Script : http://www.xeonix.be/forum/quotes.php
Referrer : http://www.xeonix.be/forum/quotes.php?do=list
IP Address :XXXXXXXX
Username : bulbaz0r
Classname : vb_database

The plugin works, but I'm still getting this error in my mail...

TwinsForMe

01-05-2007, 06:16 PM

I'm getting the following error when Importing product-quoteit.xml via the Add/Import Product". And yes, I have allowed overwrite.

Database error in vBulletin 3.6.4:

Invalid SQL:

INSERT INTO vb3_datastore
(title, data) VALUES
("quote_settings", "a:14:{s:13:\"enablecontext\";s:1:\"1\";s:14:\"moderatequotes\";s:1:\"1\";s:16:\"numbertomoderate\";s:2:\"25\";s:9:\"allowhtml\";i:0;s:11:\"allowbbcode\";i:1;s:12:\"allowsmilies\";i:1;s:11:\"allowimages\";i:0;s:15:\"allowlinebreaks\";i:1;s:13:\"continuousids\";i:1;s:12:\"saveascookie\";i:0;s:11:\"upgradedate\";i:1168027704;s:16:\"enablecategories\";i:1;s:14:\"showunapproved\";i:1;s:12:\"reportemails\";s:0:\"\";}");

MySQL Error : Duplicate entry 'quote_settings' for key 1
Error Number : 1062
Date : Friday, January 5th 2007 @ 01:08:28 PM
Script : http://www.newtestboard.twinshock.net/forums/admincp/plugin.php?do=productimport
Referrer : http://www.newtestboard.twinshock.net/forums/admincp/plugin.php?do=productadd
IP Address : XXXXXXXXX
Username : XXXXXXXXXXXXXX
Classname : vb_database

TwinsForMe

01-05-2007, 08:23 PM

So I manually inserted the new fields into the tables and it seems to work fine.

How do I reduce the size of the quote area? It is takes up most of my screen.

Amiga Harrison

01-06-2007, 12:15 AM

When uploading the files for QuoteIt! I noticed a file called quotemod.php was included that went into the modcp directory.

But on going into the modcp control panel there is no entry listed for quote moderation. How come?

If I directly link to the quotemod.php file it does load the moderators quote moderation screen. Should this therefore be linked from the modcp?

Also I have two other errors.

1, In firefox I can still not click the edit quote buttons directly. I need to middle click them to load the edit screen in a new tab. (I mentioned this problem before).

2, The other problem is a database error. If I select a quote category that currently doesn't have any quotes in it, I receive the following database error message:

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT * FROM quoteratings
WHERE quoteid IN () AND userid = 1;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND userid = 1' at line 2
Error Number : 1064
Date : Friday, January 5th 2007 @ 07:21:00 PM
Script : forumurl/quotes.php?s=&all=&perpage=25&category%5B%5D=1&totaloperator=&total=&averageoperator=&average=&votesoperator=&votes=&do=list
Referrer : forumurl/quotes.php

Cap'n Steve

01-06-2007, 03:53 AM

The database error should be fixed, as well as the Quick Language Chooser (I mean it this time). The Quote Filtering Options currently gets squeezed to the side in Firefox with some styles. If anyone good with CSS knows how to fix it, I'd appreciate the help because I can't seem to get it right without messing up the search box.

efil - What do you mean some options won't save? To arrange everything right to left, try editing the css files and switching left and right in those.

MaestroX - Do you have any quotes in the database? Make sure you download the latest version. If it still doesn't work then your server might have a problem with redirects.

Amiga Harrison - Thanks for catching that, it should be there now. It appears at the bottom of this list, though, and make sure you give yourself permission to approve quotes.

TwinsForMe - It uses the table width for whatever style you're using. You could adjust that or edit one of the css files.

everyone with problems editing quotes - Make absolutely sure you have the latest .js files on your server. If it still doesn't work, please post the exact error. In Firefox, it'll be under Tools -> Javascript Console; in Internet Explorer, there's probably an icon that you have to double-click on the bottom-left of the window.

I have the same error like efil is posting above
Which error is that?

jluerken

01-06-2007, 07:38 AM

Which error is that?

The templates on quotes.php are not shown correctly. There is a column missing of the filter setting and I still have the problem that the product messes up my language chooser.

MaestroX

01-06-2007, 08:20 AM

Thanks for your help so far Cap'n Steve. 'm still having trouble, I just installed your latest version and still the same problem. I've checked the DB and the field are there. There wasn't any quotes in there so I inserted one but still no luck. (also my server handles redirects fine)

Any ideas?

Also if possible, would it be possible to add quotes from the admincp? That would be great for my needs :)

Just thought of something nifty, you have the $showrandomquote function, how about showing a random quote from a certain category?

Amiga Harrison

01-07-2007, 12:06 AM

everyone with problems editing quotes - Make absolutely sure you have the latest .js files on your server. If it still doesn't work, please post the exact error.

I have the latest QuoteIt files on my server including the .js files but am still getting an error for the editing quotes button. The javascript error it returns when clicked is:

Error: agent.handler.responseXML has no properties
Source File: http://url/clientscript/quoteit_moderation.js
Line: 282

I also still have a problem when selecting a category without any quotes in it. I am not getting the DB error any longer so thank you for fixing that problem, it does now show the correct"No quotes matched your search" message. But then after this the auto redirect gets the url wrong. Instead of redirecting to http://siteurl/quotes.php it is trying to go to http://siteurl/siteurl/quotes.php

And one final small error. When adding a new quote the context text box is very small and aligned to the left of the page.

Cap'n Steve

01-07-2007, 08:07 AM

The bad redirect should be fixed and several things should look better in Firefox.

MaestroX - Have you approved the quote you added? Try going to quotes.php?do=view&quoteid=1 and tell me if the quote shows up. You can import a file full of quotes through the admincp if you'd like. Good idea about the categories, I'll put that in 3.1.

Amiga Harrison - What version of Firefox are you using? Have you changed any of the default settings regarding timeouts or something similar? Try holding shift and hitting refresh before editing a quote. I know that editing quotes works on Firefox 1.5 and 2, so I'm not sure what problem you're having. :/

zetetic

01-07-2007, 11:28 AM

Hey Cap'n Steve.

I've been using this hack for a long time. Great work. I'm having trouble upgrading, though. I recently upgraded my forum from 3.0.6 -> 3.6.4 and upgraded to the 3.5.x version of QuoteIt 2.0 at the same time. However, when I just tried to upgrade to QuoteIt 3.0 (downloaded just now) I got this db error when attempting to import the product:

Invalid SQL:

DELETE ratings.* FROM quoteratings AS ratings
LEFT JOIN quotes AS quotes ON quotes.quoteid = ratings.quoteid
WHERE quotes.quote IS NULL;

MySQL Error : Not unique table/alias: 'ratings'

That seemed to be just a clean-up operation, so I decided to remark it out. However when I tried the import again I got the same db error TwinsForMe mentions above:

Invalid SQL:

INSERT INTO datastore
(title, data) VALUES
("quote_settings", "a:14:{s:13:\"enablecontext\";s:1:\"0\";s:14:\"moderatequotes\";s:1:\"0\";s:16:\"numbertomoderate\";s:1:\"5\";s:9:\"allowhtml\";i:0;s:11:\"allowbbcode\";i:1;s:12:\"allowsmilies\";i:1;s:11:\"allowimages\";i:0;s:15:\"allowlinebreaks\";i:1;s:13:\"continuousids\";i:1;s:12:\"saveascookie\";i:0;s:11:\"upgradedate\";i:1168175936;s:16:\"enablecategories\";i:1;s:14:\"showunapproved\";i:1;s:12:\"reportemails\";s:0:\"\";}");

MySQL Error : Duplicate entry 'quote_settings' for key 1

GrabAssGirl

01-07-2007, 12:22 PM

What the heck is going on with the quotation images? They don't line up with the quote. Is there anyway to fix it? It's doing it on your "demo site" forums.monkeycrap.com as well.

Bubble #5

01-07-2007, 02:03 PM

Thank you for all of your hard work Steve, Looks like a very promising hack. A+ :)

Defkalion

01-07-2007, 03:58 PM

Hi,

I installed the module on my 3.6.4 version, and immediately after the import in the Plugins admin cp, I refreshed the page and now my whole portal does not display! Instead I get the following error when I type the URL for the admincp:

Warning: Invalid argument supplied for foreach() in /includes/functions.php on line 3553

And the main portal page is just blank.

Is there a way to disable the module now that I do not have access to the admin cp? Any help would be appreciated. Thanks.

Calash

01-07-2007, 05:37 PM

Here is the Java Error I am getting

CtrlAltDel

01-07-2007, 06:08 PM

nice upgrade steve

thepub

01-08-2007, 12:39 AM

not working and I just typed a long post explaining what the heck was going on and somehow lost it *grrr* I am having trouble installing this and there is no Quote it maintenance thing in my admin cp. Also, if I revert my templates (as suggested) to upgrade the quoter then I lose all of my other hacks and addins, is this the only way to do it?

thepub

01-08-2007, 12:44 AM

I tried to import the product and got an error message saying:

Database error in vBulletin 3.6.2:

Invalid SQL:

INSERT INTO datastore
(title, data) VALUES
("quote_settings", "a:14:{s:13:\"enablecontext\";s:1:\"0\";s:14:\"moderatequotes\";s:1:\"1\";s:16:\"numbertomoderate\";s:1:\"0\";s:9:\"allowhtml\";i:0;s:11:\"allowbbcode\";i:1;s:12:\"allowsmilies\";i:1;s:11:\"allowimages\";i:0;s:15:\"allowlinebreaks\";i:1;s:13:\"continuousids\";i:1;s:12:\"saveascookie\";i:0;s:11:\"upgradedate\";i:1168224147;s:16:\"enablecategories\";i:1;s:14:\"showunapproved\";i:1;s:12:\"reportemails\";s:0:\"\";}");

MySQL Error : Duplicate entry 'quote_settings' for key 1
Error Number : 1062
Date : Sunday, January 7th 2007 @ 09:42:28 PM
Script : http://www.theneighborhoodpub.com/admincp/plugin.php?do=productimport
Referrer : http://www.theneighborhoodpub.com/admincp/plugin.php?do=productadd
IP Address : (deleted by thepub)
Username : (deleted by thepub)
Classname : vb_database

can you tell me what this means and why it's happening?

Cap'n Steve

01-08-2007, 12:52 AM

Is there a way to disable the module now that I do not have access to the admin cp? Any help would be appreciated. Thanks.

Add this to includes/config.php:
define('DISABLE_HOOKS', 1);

Cap'n Steve

01-08-2007, 03:12 AM

All installation database errors should be fixed. The closing quotation mark is hidden in Internet Explorer on the random quote and the quote bbcodes until it learns to stop wandering off.

thepub - You should only revert the QuoteIt! templates, and you only need to do that if you customized them in an earlier version.

Calash - What version of IE is that? Check under Help -> About. Also, try shift + refresh and see if that changes anything.

Defkalion - Do you have any other mods installed? If you could post the code on and around that line number, that might help, since it seems to be different in older versions.

The latest version I can download is 3.6.1, can anyone confirm that this works on newer versions?

Defkalion

01-08-2007, 08:28 AM

Ok I did a rebuild of the bitfields and now everything seems to be ok.

Many thanks for your quick reply Steve.

GrabAssGirl

01-08-2007, 09:22 AM

Can you tell me why the quotations are located so far apart. The image on the right is located almost outside the quoteIt box. It's even doing this on your "live demo" site. Is there any way for me fix this? (don't know if this will work, but here's an image of what I am talking about...

https://vborg.vbsupport.ru/external/2007/01/17.gif

GrabAssGirl

01-08-2007, 09:24 AM

or, is there anyway to just do away with the images and have nothing but the quote there?

Calash

01-08-2007, 10:53 AM

Both IE6 and IE7. Firefox does not throw a visible error but the edit button does not work.

I am also having the issue with the quotes being spaced way too much, but that appears to be a skin issue so I am going to work to resolve that via editing the templates.

I am also having a problem getting the vBadvanced module to work. The block just will not show up no matter what I do and I am not sure how to get any error messages to help diagnose the problem.

zetetic

01-08-2007, 10:55 AM

All installation database errors should be fixed.
Doh! I got impatient yesterday so I dumped the quotes table to a flat file, then uninstalled and reinstalled QuoteIt. Unfortunately I can't seem to get the QuoteIt file import to work. I keep getting this error: "Invalid Query: Column Count Doesn't Match Value Count At Row 1".

Exactly what format does a file have to be in? I'm trying just quote, author, userid, context separated by semicolons. Sorry, I know just enough to be dangerous!

The latest version I can download is 3.6.1, can anyone confirm that this works on newer versions?
The clean install went fine on 3.6.4, but I can't be sure it worked until I get the import done.

thepub

01-08-2007, 11:58 AM

can you help me about the error message I got when I tried to import the product? I posted it above. Thanks!

thepub

01-08-2007, 12:14 PM

ok I was able to install and the big error message went away, but now I get this error message Warning: Invalid argument supplied for foreach() in /includes/functions.php on line 3542 and my board disappeared. I disabled the quoter and it came back. :confused:

thepub

01-08-2007, 12:19 PM

Warning: Unknown(/home/theneigh/public_html/includes/functions_quoteit.php): failed to open stream: No such file or directory in /index.php(63) : eval()'d code on line 2
Fatal error: (null)() [function.require]: Failed opening required '/home/theneigh/public_html/includes/functions_quoteit.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/theneigh/public_html/index.php(63) : eval()'d code on line 2

this is what I get when I go to board

BaconDelight

01-08-2007, 05:12 PM

This is mostly working, but when I enable editing/deleting for a user group, the random quotes display fails to parse BBCode.

MaestroX

01-08-2007, 06:10 PM

MaestroX - Have you approved the quote you added? Try going to quotes.php?do=view&quoteid=1 and tell me if the quote shows up. You can import a file full of quotes through the admincp if you'd like. Good idea about the categories, I'll put that in 3.1.

My quote I put in the database came up, yay! From there I tried to add a quote and was successful but then redirected to my forum home. Anytime I try to access quotes.php I get redirect to my forum home. I get the message ""Your quote has been submitted.".

Hope you can help,

Thanks

BaconDelight

01-08-2007, 09:33 PM

This is mostly working, but when I enable editing/deleting for a user group, the random quotes display fails to parse BBCode.
Sorry to poke again, but I'm hoping to pop this into my live board tonight and would like this to be working.

Thanks!

Amiga Harrison

01-09-2007, 12:02 AM

The page redirect is now working correctly for me and returning back to the correct page. So thanks for fixing that.

I am still getting the edit quote error. I tested it in IE and Opera and it doesn't work in those either.

In IE7 the page returns the same error as someone else posted above.

Line: 283
Char: 5
Error: 'agent.handler.respondeXML.documentElement' is null or not an object
Code: 0
URL: http://forum.classicamiga.com/quote.php

And in Opera I get the following errors:

JavaScript - http://forum.classicamiga.com/quotes.php
Unknown thread
Error:
name: TypeError
message: Statement on line 282: Could not convert undefined or null to object
Backtrace:
Line 282 of linked script http://forum.classicamiga.com/clientscript/quoteit_moderation.js
var author = (agent.handler.responseXML.documentElement.getElem entsByTagName("author"))[0].firstChild.data;
At unknown location
[statement source code not available]

The edit foes however work in all three browsers if I select to open the edit link in a new window or tab. Therefore is this an AJAX error?

There are also a lot of layout problems:

When submitting a new quote (in IE, Firefox or Opera) all of the text entry fields are justified to the right and the titles and information about each field is bunched up on the left. This leaves a huge space between the two. Are you just using float left and float right css for this? I much preferred the way it was laid out before this change with the information text above the entry fields.

Also the text entry field for the context field is only set to a size of 25 which is way too small to even display the default information automatically entered into the field. Where is this fields size set?

And finally IE7 has a lot of bad layout problems. When viewing the list of existing quotes the list expands futher to the right than the browser window and goes beyond the right hand edge of the forum template. This makes everything on the right of the quotes hidden off the right of the page including the voting and editing buttons. This doesn't happen in Firefox or Opera where the page looks fine and works as expected.

thepub

01-09-2007, 01:29 AM

Sorry to poke again, but I'm hoping to pop this into my live board tonight and would like this to be working.

Thanks!

ditto for me too.

Cap'n Steve

01-09-2007, 03:45 AM

GrabAssGirl - The closing quote is now hidden in Internet Explorer on the random quote. It seems to want to start in the top right corner no matter what I do. :o The images are in the quote_listbit template if you want to remove them completely.

Calash - I've enabled editing quotes on my forum. Register on monkeycrap.com (http://forums.monkeycrap.com), add a quote and then try editing it. I've tested editing with all those browsers, so it must be either a server or browser setting that's causing problems.

Amiga Harrison - Try the thing I posted above about editing. If the labels were above the fields before, then that was an error. If you want to change this or the size of the inputs, it's set in the quote_manager template. I don't get any of the other errors you're seeing. Do you have a link or a screenshot?

zetetic - When you say you dumped them to a flat file, do you mean through phpMyAdmin? The quote importing just takes a text file with each field separated by whatever character you specify. If you could post the options you filled in at the quote importing screen and at least the first line of the file, that might help.

thepub - Is your functions_quoteit.php in the directory it says? It seems to be having trouble finding it. If you could post a few lines from includes/functions.php from around line 3542 I could get a better idea of what the issue is.

MaestroX - Is this page on the Internet, a link would be helpful. You can also try reuploading all the files and reinstalling the product.

Cap'n Steve

01-09-2007, 04:35 AM

BBcode in the random quote should be fixed now, also.

MaestroX

01-09-2007, 07:27 AM

MaestroX - Is this page on the Internet, a link would be helpful. You can also try reuploading all the files and reinstalling the product.

Yeah, my test forum are http://area51.music-web.org/forum/index.php. I'll also try reuploading all the files and reinstalling the product :)

Edit: All problems seem to be fixed, thanks for the great support :)

p.s. Also I'm waiting for the random quote by category and this mod will be perfect!

thepub

01-09-2007, 01:06 PM

double post.

thepub

01-09-2007, 01:29 PM

ok, I went through and out everything in again and paid close attention to where what was going and figured out a couple of my mistakes along the way. I now have the quoter on my forum index, but there is nothing in it. When I submit a test quote it doesn't show up, all there are is some ""'s

It looks nothing like the one you posted on your demo site.

dcsbclan

01-09-2007, 02:07 PM

First off great mod Steve! :D Clicked installed and nominated.

The public part i all working fine, but setting options in the admin panel isnt working. For example when i go to the parsing option I set all to yes then hit save, and the page reloads with all no and it doesnt save the settings. Have tried it in both IE7 and Opera to check it wasnt opera's cookies settings showing it wrong or something and it happens on both. I went through trying to chmod some of the files to 777 instead of 644 just to test, and when i change quoteadmin.php to anything other than 644 I get an error in teh admin cp.

Any suggestions?

Edit: Im running vb3.6.4

BaconDelight

01-09-2007, 03:38 PM

BBcode in the random quote should be fixed now, also.
Nope, same issue. BBcode works if a user does not have edit/delete permission. And it works on the show all quotes list, even with edit/delete permission. But in the random quote display, if a user has edit/delete permission, BBCode is not parsed.

I completely uninstalled 3.01 and installed 3.02. All templates are unedited.

EDITED TO ADD: I stand corrected. Now, with 3.02, BBCode doesn't work at all in the random quote display, whether the user has editing permission or not.

BaconDelight

01-09-2007, 08:04 PM

I don't know if this is helpful or not, but I compared the resulting html source code for the random quote display (where BBCode fails) to the same for the full quote list (where BBCode works)

I noticed this difference. In the random display, you see this right before the text of the quote:

<span class="quotetext" id="quotetext1-">

Whereas in the full quote list, it's:

<span class="quotetext" id="quotetext1-0">

Again, I have no idea if that's relevant, but perhaps it points to where the BBCode parsing is breaking down.

Cap'n, if you'd like to look at my installation, PM me and I'll point you to it.

thepub

01-09-2007, 08:17 PM

Cap'n, if you'd like to look at my installation, PM me and I'll point you to it.

mine too! mine too! *jumping up and down* My members are snippy about the quoter not working lol!

Amiga Harrison

01-09-2007, 09:03 PM

I've taken a look at the templates and sorted out the text field sizes so that's sorted.

I still have the layout issues in IE, and have now tested it using both IE6 and 7 and get the same results. I've PM'd you the details to look at my site.

zetetic

01-09-2007, 11:41 PM

zetetic - When you say you dumped them to a flat file, do you mean through phpMyAdmin? The quote importing just takes a text file with each field separated by whatever character you specify. If you could post the options you filled in at the quote importing screen and at least the first line of the file, that might help.
Yes, dumping from phpmyadmin. I still have a copy of my old db running on my test server, so I can export another copy of the quotes table as necessary. I tried numerous combinations of export format, separator and field order but can't seem to get anything to import.

Cap'n Steve

01-10-2007, 02:40 AM

thepub - Did you approve the quote? Does it show up when you go to the main quotes.php page? Have you changed either the total threshold or average threshold?

dcsbclan - Try reuploading all the files and reimporting the product.

Amiga Harrison - It's definitely caused by using the [quote] bbcode in a quote. I'm probably just going to end up disabling that bbcode, since I'm not sure how useful that is within a quote anyway.

zetetic - If the backup was created with phpMyAdmin, you should use phpMyAdmin to restore it. You could also run the queries through your admincp, but using phpMyAdmin would be the easiest option.

Still working on the bbcode in the random quote...

Cap'n Steve

01-10-2007, 07:08 AM

BBCode should be fixed for good now. You might have to save the Quote Parsing Options once for it to take effect.

You can now choose a category for the random quote.

jluerken

01-10-2007, 08:02 AM

Cap'n Steve did you solve the issue with the language chooser?

zetetic

01-10-2007, 08:29 AM

zetetic - If the backup was created with phpMyAdmin, you should use phpMyAdmin to restore it. You could also run the queries through your admincp, but using phpMyAdmin would be the easiest option.
Ah, of course. Thanks!

dt~

01-10-2007, 09:08 AM

Hi,

problems:

- I'm getting "No quotes matched your search." on forumhome after upgrading to 3.03. It was showing correctly in 3.02. Yes I did run fix old quotes and set everything up correctly. The quotes show in quotes.php

- I can't edit quotes. Nothing happens when I click the edit button. I'm using the latest version of firefox.

- Some settings in the admin cp don't save when you change them, like "Enable Context".

thepub

01-10-2007, 12:54 PM

thepub - Did you approve the quote? Does it show up when you go to the main quotes.php page? Have you changed either the total threshold or average threshold?

I don't have quotes moderated in my admincp and there are no quotes when I go to the quotes.php page. There are 3 pages of what should be quotes but they are blank. I haven't changed anything other than following the installation instruction completely.

BaconDelight

01-10-2007, 02:24 PM

BBCode should be fixed for good now. You might have to save the Quote Parsing Options once for it to take effect.

You can now choose a category for the random quote.
Success! Thanks, my users loved the old version, they'll adore the update.

dcsbclan

01-10-2007, 02:29 PM

dcsbclan - Try reuploading all the files and reimporting the product.
No luck :/

./Matt

MaestroX

01-10-2007, 04:46 PM

You can now choose a category for the random quote.

Great! thankyou

BaconDelight

01-10-2007, 04:56 PM

Hmm, 3 more issues.

1) Edit doesn't work. I click the edit button, nothing happens. This is true on both IE and Firefox and is true either in random quote or on the full quote list. Ajax editing of posts is working on the board

2) The formatting of the quote list and random quote is wacky on IE. There's a huge blank space between the quote and the author.

3) Deleting from the random quotes display doesn't work. I get a popup box with OK and Cancel buttons, but no other text. If I hit OK, the random quote display disappears from view (returns after a refresh) and the quote has not been deleted. and I get this sql error

Invalid SQL:

DELETE quotes.*, ratings.*, guestratings.* FROM quotes AS quotes
LEFT JOIN quoteratings AS ratings ON quotes.quoteid = ratings.quoteid
LEFT JOIN guestquoteratings AS guestratings ON quotes.quoteid = guestratings.quoteid
WHERE quotes.quoteid IN (1);

MySQL Error : Not unique table/alias: 'ratings'
Error Number : 1066

Deleting seems to work from the full quote list.

apokphp

01-10-2007, 07:46 PM

I'm having some of the same problems as others.

1) Most changes made in the QuoteIt! Options are not saving. After making the changes, then clicking "Save", it defaults back to the original setting.

The ONLY button options that do save are

Show Quote Count
Enable Quote BBCodes
Show Quote Stats
Use Alternate Query for Quotes
Cache Posts with Quotes

No other button options will save.

2) On the ForumHome display, if there are no quotes, it has the link "Add a Quote". But if there is a quote, it says "No quotes matched your search".

3) The quotes page displays the quotes in large font. How can this be decreased (really a moot issue if the first 2 issues above cannot be resolved though).

(I'm using QuoteIt! 3.03 and vb 3.6.2)

zetetic

01-10-2007, 11:23 PM

Yeah, the few options I've tried to change didn't save either.

QuoteIt! 3.0.3 and vb 3.6.4

Cap'n Steve

01-11-2007, 07:18 AM

Random quote problems fixed. To change the style you'll need to edit the css files. It's pretty simple and there's lots of tutorials on the Internet. The deletion error might be fixed; if you're still getting this, please let me know what version of mySQL you have.

jluerken - Yes, that should have been fixed a few versions ago, is it still showing up on your forum?

thepub - Try a reupload and reinstall, then please give me a link to your forum.

everyone with editing problems - I've enabled editing quotes on my forum. Register on monkeycrap.com (http://monkeycrap.com), add a quote and then try editing it. I've tested editing with all those browsers, so it must be either a server or browser setting that's causing problems.

everyone with problems saving options - Run this query (replacing $TP with your table prefix) and tell me what it says:
SELECT * FROM $TPdatastore where title = "quote_settings"

If nothing shows up after the first query, run this one (replacing $TP with the table prefix again):
INSERT INTO $TPdatastore (title, data) VALUES ("quote_settings", "")

zetetic

01-11-2007, 11:11 AM

The query resulted in this data field:

a:11:{s:14:"moderatequotes";i:0;s:16:"numbertomoderate";i:0;s:13:"enablecontext";i:1;s:17:"enableguestvoting";i:0;s:13:"requireauthor";i:1;s:10:"softdelete";i:0;s:16:"enablecategories";i:0;s:13:"continuousids";i:0;s:14:"showunapproved";i:0;s:12:"saveascookie";i:0;s:12:"reportemails";s:0:"";}

...and "2" in the "unserialize" column.

Calash

01-11-2007, 11:21 AM

The edit issue is definetly not a browser problem. I have run tests using Firefox, IE6 and 7 on 2 systems and a virtual PC, clearing cookies and cache to make sure it is fine.

Firefox does not throw an error, but it does not do anything, IE 6 and 7 throw the error listed above.

Here is a list of my mods. It may help if other people who have the same problem post a list of theres to see if we have a common element.

FlashChat Integration 3.08 Integration of Flashchat and vBulletin 3.6
Members who are using flashchat 4.37 Display members who are currently chatting in Flashchat.
Members who have visited the forum 4.39 Display members who have visited the forum.
Mini Navbar 1.0.4 Places a breadcrumb from the navbar on the bottom of a thread
My Smilies VB 1.02 Custom user-uploaded smilies
Restrict URLS 0.1 Restricts users from posting URLs until they have an admin defined number of posts.
Smilies in Quickreply 3.6.x Show Smilies in Quickreply.
vB Spell 0.10.2b vB Spell allows you to provide a spell checking window through your editor interface.
vbgooglemap Member Edition by StonyArc 2.5.2 Display user location based on Google Maps API
Zoints Profile System 2.1.4 The Zoints client forum profile linking system.
Zoints SEO 2.2.2 The Zoints Search Engine Optimization Package
Zoints Thread Tags 1.2.1 The Zoints thread tagging system
[Sniper] - Mood Manager 1.2.3 Allows users to manage there mood

I am also still having the language bar issue. It goes away when I rebuild, but eventually comes back after editing the settings.

Calash

01-11-2007, 12:15 PM

Ok, I figured out something.

I can not edit a post when the account I am using has Delete Own, Delete Others or Approve permissions in the primary group (Did not test other groups). With these 3 disabled I can click the edit button and get to the edit page. I am still seeing a Javascript error, but it disappears before I can see what the error is about. I see this same quick error when I test on your site.

thepub

01-11-2007, 01:34 PM

thepub - Try a reupload and reinstall, then please give me a link to your forum.

same problem after reupload. Here's link to my forum http://www.theneighborhoodpub.com/index.php if you need assistance you can pm Jenn

apokphp

01-11-2007, 05:19 PM

everyone with problems saving options - Run this query (replacing $TP with your table prefix) and tell me what it says:
This is the result:

An error occurred while attempting to execute your query. The following information was returned.
error number: 1146
error desc: Table 'onlin19_vb.$TPdatastore' doesn't exist

thepub

01-11-2007, 05:41 PM

zetetic

01-11-2007, 08:31 PM

apokphp: Replace $TP with your table prefix and try the query again.

dcsbclan

01-11-2007, 11:51 PM

I just want to say that I can't imagine being a coder because when you make a hack, addin, etc...it seems that you get 300 posts of whats wrong with it and not very many posts about how wonderful it is (at least not right away). With that said I do want to say thank you for making this incredible product, I know that when it finally gets working on my forum my community will be ecstatic. Thank you for caring about your work enough to help people with the errors and your time in making this.
I fully agree, people jump quicker on the bits that dont work.

a:24:{s:15:"averageoperator";s:0:"";s:13:"totaloperator";s:0:"";s:11:"ageoperator";s:0:"";s:13:"votesoperator";s:0:"";s:7:"average";s:0:"";s:5:"total";s:0:"";s:3:"age";s:0:"";s:4:"days";s:0:"";s:9:"allowhtml";i:0;s:11:"allowbbcode";i:1;s:12:"allowsmilies";i:1;s:11:"allowimages";i:1;s:15:"allowlinebreaks";i:1;s:14:"moderatequotes";i:0;s:16:"numbertomoderate";i:0;s:13:"enablecontext";i:0;s:17:"enableguestvoting";i:0;s:13:"requireauthor";i:1;s:10:"softdelete";i:0;s:16:"enablecategories";i:0;s:13:"continuousids";i:0;s:14:"showunapproved";i:0;s:12:"saveascookie";i:0;s:12:"reportemails";s:0:"";}

Cap'n Steve

01-12-2007, 04:03 AM

Thanks for sticking with me guys, I've had this on my live forum for about three months and only got a few bugs reported. And I swear the editing works in all those browsers when I do it.

thepub - Did you have the old version of QuoteIt! installed? It looks like you need to revert your quote_listbit and quote_randomquote templates.

apokphp - You need to replace $TP with your table prefix (or delete it if you don't have one) and try it again.

Calash - I don't see the quick language chooser on the forum in your signature, is it still happening there?

everyone with editing problems - Edit clientscript/quoteit_moderation.js. Find this:
var author = agent.handler.responseXML.documentElement.getEleme ntsByTagName('author')[0].firstChild.data;

Above that, add this:
alert(agent.handler.responseText);

Then let me know what the popup says when you try to edit a quote (you might want to post a screenshot of it).

everyone with option saving problems - Try running this query and see if that fixes it (replace $TP with your table prefix):
UPDATE $TPdatastore SET unserialize = 0 WHERE title = "quote_settings"

Firen

01-12-2007, 04:30 AM

I just tried adding the extra code to get the editing to work. This is the error message I got:

58873

yonglvnv

01-12-2007, 07:24 AM

everyone with option saving problems - Try running this query and see if that fixes it (replace $TP with your table prefix):
UPDATE $TPdatastore SET unserialize = 0 WHERE title = "quote_settings"
Return code was "Affected Rows: 1 (0s)"
This worked for me, now able to save settings. thanks.

Cap'n Steve

01-12-2007, 07:46 AM

A new version has been uploaded. The Quick Language Chooser should be fixed on all versions finally, and editing quotes is probably fixed (I hope).

yonglvnv

01-12-2007, 10:01 AM

Great mod! Thanks and new version installed. I can confirm language selection issue is gone (for me), and no error message displayed when importing the xml file. I just have a problem with formating when displaying from a vba block. And that is, everything, including collapse icon, is aligned to the left and in the next line.(see attached). In addition, there seems to be no spacing between this block and one below it. Otherwise, everything looks great, including edit and delete function. Which template and where can I modify to change the alignment? Thanks, it's a great mod!

zetetic

01-12-2007, 11:31 AM

It's looking great, Cap'n Steve. I ran the query to fix the problem saving options and that worked, then I installed the latest version and everything else seems to work too. I don't have time to test it thoroughly, but right now I'd say it looks great.

Thanks for all your hard work!

Oh, one thing. Did you mean to move "Random Quote Options" under "Quote Display Options" in the acp? I can change it on mine, but just wondering if it was an accident.

dcsbclan

01-12-2007, 02:09 PM

Calash

01-12-2007, 02:10 PM

The Language bar comes back whenever I edit the QuoteIT settings. It goes away by rebuilding the languages. I will leave it there for the moment.

Attached is the popup you asked for. It matches what was already posted.

BaconDelight

01-12-2007, 02:44 PM

All working now Steve! Thankyou for putting up with us and sticking with getting it working.

Edit: Is there a page to view all quotes without having to have them displayed on your forum? All I get when I go to quote.php is to add a quote.
quotes.php?do=list

I'll update to the latest version in a minute here and let you know how it's working.

Thanks for the efforts, Cap'n

BaconDelight

01-12-2007, 02:50 PM

Edit's working great. Delete is working-ish (it deletes, no database error, but the pop up confirmation box is still blank except for the OK and Cancel buttons).

Formatting is still ugly on IE, but I suppose I can mess with the template/css until it's right.

And one minor issue, not a big deal at all as it's a total edge-case, but if you are in the list view and there's only 1 quote in the database, after you delete it a message pops up that says "no quotes matched your search" and the quote remains displayed. I thought it meant the quote wasn't deleted, but a refresh showed that it was gone, it just was unable to refresh the view with an empty database. Like I said, not a big deal at all sicne it's unlikely any of us will be deleting ALL the quotes in a live install, but as a sometimes-programmer myself I know that those little edge-case bugs irritate me in my own code so I thought I'd let you know.

Once I get the IE formatting sorted out I'm going live with this. My users will be thrilled, thanks!

glowinggal

01-12-2007, 04:24 PM

only thing stoppping me from installing this in particular is not being able to put quotes into categories :)

BaconDelight

01-12-2007, 05:04 PM

Here's what I mean when I say the formatting on IE is ugly. I've uploaded 2 screen shots, one from Firefox one from IE. Notice how the IE one is about 50% taller, the quote extends all the way to the right margin, and the author is shifted well to the right. It just looks sloppier than the Firefox equivalent.

I figure I can create separate classes and modify the template to detect the browser and use the appropriate class, but I'm a little fuzzy on the workings of css for manipulating formatting, so any help in that area would be greatly appreciated.

dcsbclan

01-12-2007, 05:21 PM

only thing stoppping me from installing this in particular is not being able to put quotes into categories :)
You can.

When i try to go to quotes.php?do=list I just get redirected to quotes.php?do=addquote. Also when I do add a quote I just get redirected to the forum homepage.

BaconDelight

01-12-2007, 05:33 PM

but I'm a little fuzzy on the workings of css for manipulating formatting, so any help in that area would be greatly appreciated.Nevermind, I think I've got it.

soulface

01-12-2007, 06:09 PM

the language problem still exists. also getting this db error when changing the option 'Random Quote Frequency' from Every time to hourly, daily, weekly, monthly

Database error in vBulletin 3.6.4:

Invalid SQL:

INSERT INTO cron
(weekday, day, hour, minute, filename, loglevel, title) VALUES
(-1, -1, -1, "a:1:{i:0;i:0;}", "./includes/cron/randomquote.php", 0, "QuoteIt! Quote Randomizer");

MySQL Error : Unknown column 'title' in 'field list'
Error Number : 1054
Date : Saturday, January 13th 2007 @ 02:05:21 AM
Script : http://***********/forum/admincp/quoteadmin.php?do=saveoptions
Referrer : http://***********/forum/admincp/quoteadmin.php?do=options
IP Address : *********
Username : Eros
Classname : vb_database

Firen

01-12-2007, 09:04 PM

I'm back to square one. I still can't get the edit button to work. I've installed the updated Quote It! and the Edit button won't do anything. Everything else works fine though. :)

Cap'n Steve

01-12-2007, 10:49 PM

yonglvnv - That's strange, could you post a link to the page?

zetetic - Yes, I figured there were enough options to give it its own section.

dcsbclan - You have some quotes already added and approved? They show up as a random quote?

Calash - How many languages do you normally have? Did you upload the newest files?

BaconDelight - If it helps, clientscript/vbulletin_css/quoteit_main.css is used by all browsers, quoteit_ie_all.css is used by all versions of Internet Explorer, and quoteit_ie_lt_7.css is used by Internet Explorer 6 and below. It was a nightmare trying to get it to look decent on all browsers, depending on what kind of people use your forum, you might only have to worry about Internet Explorer.

Firen - Do you still get that error you posted when you add that line to quoteit_moderation.js? Make sure you've uploaded all the latest files.

soulface - I'll have a new version up later tonight.

yonglvnv

01-13-2007, 03:22 AM

Thanks, sent you a pm.

Cap'n Steve

01-13-2007, 07:49 AM

yonglvnv - For some reason, all the external files aren't getting included. Does $headinclude show up in your adv_portal template? Anyway, this should work for a temporary fix; in adv_portal find this:
</head>

Above that, add:
<if condition="$quoteitoptions['ratings'] OR $quoteitpermissions['canmoderatequotes'] OR $quoteitoptions['enablecategories'] OR $quoteitpermissions['canreportquotes']">
<script type="text/javascript" src="clientscript/quoteit_common.js"></script>
</if>
<if condition="$quoteitoptions['ratings'] AND $quoteitpermissions['canratequotes']">
<script type="text/javascript" src="clientscript/quoteit_voting.js"></script>
</if>
<if condition="$quoteitpermissions['canmoderatequotes']">
<script type="text/javascript" src="clientscript/quoteit_moderation.js"></script>
</if>

soulface

01-13-2007, 10:13 AM

ok the db error is fixed now. working fine. but what abt the language problem ? its still exists. when i rebuild the language. then language bar disappeared. but then QuoteIt options get disabled. when i enable them. the language bar again shows up....

zetetic

01-13-2007, 12:45 PM

zetetic - Yes, I figured there were enough options to give it its own section.
That makes sense. I just think the option to turn the hack on/off should be at the top to be consistent with vBulletin. Anyway it's a minor point. Thanks for all your work on this great add-on!

Mum

01-13-2007, 08:23 PM

Don't have permissionsl, followed the instructions 'NOTE: If you get errors stating that you don't have permission to view the page on either the "Moderate Quotes" page or the main quotes page, you should rebuild the bitfields by going to www.yourdomain.com/admincp/index.php?do=buildbitfields' but didn't change anything, still can't moderate comments. Have uninstalled. Running 3.6.4

BaconDelight

01-13-2007, 09:07 PM

BaconDelight - If it helps, clientscript/vbulletin_css/quoteit_main.css is used by all browsers, quoteit_ie_all.css is used by all versions of Internet Explorer, and quoteit_ie_lt_7.css is used by Internet Explorer 6 and below.Yeah, I've got it very nearly presentable. Good enough that I've gone live.

Another little issue - if you put in a search term that it can't find, the redirect is wrong. Instead of pointing to http://www.[domain].com/[forum]/quotes.php, it redirects to http://www.[domain].com/quotes.php

zetetic

01-14-2007, 12:05 AM

I discovered that today too, BaconDelight. I spent an hour or two trying to track down the root of that problem with no success - even changing every

$vbulletin->url = 'quotes.php?'

to

$vbulletin->url = $vbulletin->options['bburl'] . '/quotes.php?'

in both the quotes.php and functions_quoteit.php files. That didn't break anything (that I noticed), but it didn't fix the problem either.

Cap'n Steve

01-14-2007, 01:23 AM

Hmm. It used to be like that, until I discovered it was redirecting to domain.com/domain.com/forums/quotes.php. Maybe they changed something again, I'll take a look.

yonglvnv

01-14-2007, 01:49 AM

jluerken

01-14-2007, 10:04 AM

Hi,

I wanted to upgrade from 3.0 to 3.07 and I am getting this error message:

Database error in vBulletin 3.6.4:

Invalid SQL:

ALTER TABLE vb3_quotes
MODIFY COLUMN date INT (10) UNSIGNED NOT NULL DEFAULT;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 2
Error Number : 1064

zetetic

01-14-2007, 06:59 PM

The 'delete' function seems to behave strangely. When I click delete on a quote an empty confirmation box pops up, and when I click "ok" the quote disappears, but the quote-box header remains. I have to refresh to get a new random quote.

zetetic

01-14-2007, 09:54 PM

Sorry to keep piling them on, but I found another one Cap'n.

While I was working on the templates instead of disabling the hack I just made it non-viewable to the registered users usergroup, and that worked fine. However, when I went to make it non-viewable to unregistered/not logged in usergroup, I got this error upon saving the settings:

Invalid SQL:
INSERT INTO cron
(weekday, day, hour, minute, filename, loglevel, title) VALUES
(-1, -1, -1, "a:1:{i:0;i:0;}", "./includes/cron/guestquotes.php", 1, "QuoteIt! Guest Voting Cleanup");

MySQL Error : Unknown column 'title' in 'field list'

I went back in and selected 'no' for all the other options and it saved fine.

dcsbclan

01-14-2007, 11:53 PM

Alien

01-15-2007, 02:04 AM

Hey!

It's awesome to see this updated, and so much hard work going into answering all these questions..

I have a small one of my own. I'm running 2.1 of this on 2 different sites (and it's working on vBulletin 3.6.4).. Do I have to upgrade to the vB 3.50/QuoteIt 3.05 version BEFORE upgrading to this QuoteIt 3.07+ version? I attempted to upgrade directly from QuoteIt 2.1 to THIS LATEST version and I get this error message:

Database error in vBulletin 3.6.4:

Invalid SQL:

ALTER TABLE quotes
MODIFY COLUMN quoteid INT (10) UNSIGNED NOT NULL AUTO_INCREMENT;

MySQL Error : Duplicate column name 'quoteid'

Cap'n Steve

01-15-2007, 02:11 AM

I finally gave in and renewed my license because my test server wasn't cutting it, but then my host chose that moment to go down. Never buy hosting from fuitadnet.com

yonglvnv - Don't worry, I haven't forgotten about vBadvanced, I'm still trying to sort out that weirdness.

jluerken - That'll be fixed in a little while.

zetetic - The database error should be fixed in the latest version. Make sure you upload all the 3.07 files. The delete problem means that the phrase must not be getting passed to the Javascript. Got a link?

everyone with no permission errors - If you're getting errors approving quotes, make sure you gave yourself permission in the usergroup manager. If you're getting errors viewing quotes, let me know what the QuoteIt! Permissions are for your usergroup. A link might help, too.

Cap'n Steve

01-15-2007, 02:14 AM

Alien - Could you find out what version of mySQL you have? That's kind of a strange error, I don't see how modifying a column creates a duplicate.

Alien

01-15-2007, 02:17 AM

Here you go: 4.1.21

yonglvnv

01-15-2007, 06:03 AM

Thanks, this mod is worth the wait.

Cap'n Steve

01-15-2007, 07:45 AM

I've uploaded 3.08, which should fix the database errors during installation.

Alien - Wonderful, the exact same version I have. I haven't found a workaround, but I've hidden the installer errors, so you should hopefully be able to install without a problem. Let me know if there are any further errors.

jluerken

01-15-2007, 01:02 PM

Alien

01-15-2007, 01:27 PM

Hay Cap'n!

v3.08 allowed the upgrade to go through without error.

Right after install I edited the QuoteIt options but left things as they were.

Then, I clicked on "Moderate Quotes" to take a look (I know we were up to date and there were no quotes to moderate), and I get this error:

Invalid SQL:

SELECT quotes.*, user.username, categories.title AS category FROM quotes AS quotes
LEFT JOIN user AS user ON user.userid = quotes.userid
LEFT JOIN quotecategories AS categories ON quotes.categoryid = categories.categoryid
WHERE quotes.approved = 0 LIMIT 5;

MySQL Error : Unknown column 'quotes.categoryid' in 'on clause'
Error Number : 1054

I also clicked on "Manage Categories" (i know we haven't made any categories yet, as 2.1 didn't have this correct?" and I get this error:

Invalid SQL:

SELECT category.*, COUNT(quotes.quoteid) AS count FROM quotecategories AS category
LEFT JOIN quotes AS quotes ON quotes.categoryid = category.categoryid
GROUP BY category.categoryid ORDER BY category.displayorder ASC;

MySQL Error : Unknown column 'quotes.categoryid' in 'on clause'
Error Number : 1054

Help! :)

soulface

01-15-2007, 06:19 PM

Cap'n Steve,

v 3.08 still contains the language Chooser bug.
Enabling the random quote options now does not make wrong entries in the language chooser, it simply turns it off :(

Editing a language makes the language chooser visible again but turns off the random quote option. This can be reproduced at any time :D

Can you please take a look at this again?

Yes this bug still exists. also..

after many testing on my test forum, today i install this on my live forum. which had the old version from vb3.5. so after the update, all quotes add dates showing todays date (January 16th, 2007) screenshot attached bellow...

yonglvnv

01-15-2007, 07:06 PM

Cap'n Steve,
had a weird situation. After upgrading to 3.8, QuoteIt disappeared from vba cmps page. Completely uninstalled the 3.8 and reinstalled QuoteIt and was locked out of my admincp. The error on blank admin page and top of all my website pages were "Warning: Invalid argument supplied for foreach() in /includes/functions.php on line 3553" which is "foreach ($_FIELDNAMES AS $field => $bitvalue)" in functions.php file. Ended up disabling all hooks through my config.php file so I can sign back in to admincp page to disable this mod. I'm also seeing some error messages when doing a fresh install of QuoteIt. Trying to install 3.7 gave me the same error. Do you think uninstall didn't clean up everything?

Cap'n Steve

01-16-2007, 07:26 AM

Still looking at the language chooser and vBadvanced bugs.

yonglvnv - It's not reading the permissions for some reason. Did you still have includes/xml/bitfield_quoteit.xml on the server?

soulface - That's right. The date wasn't stored in earlier versions so it uses the date you installed it as the default date.

Alien - I was afraid of that. I have no idea what your problem is, but it's not modifying or adding columns. I'll keep searching for the reason behind that, but until then you have two options: Try and get your host to upgrade MySQL (I'm not sure if that will help) or modify the tables yourself through phpMyAdmin. Here's the structure for each table (column name is on the left, definition after the =>):

quotes
quoteid => INT (10) UNSIGNED NOT NULL AUTO_INCREMENT
quote => MEDIUMTEXT NOT NULL
author => VARCHAR (100) DEFAULT NULL
userid => INT (10) UNSIGNED NOT NULL DEFAULT 0
approved => TINYINT (1) UNSIGNED NOT NULL DEFAULT 0
votes => INT (10) UNSIGNED NOT NULL DEFAULT 0
rating => INT (10) NOT NULL DEFAULT 0
average => FLOAT (3, 2) NOT NULL DEFAULT 0.00
context => VARCHAR (250) DEFAULT NULL
date => INT (10) UNSIGNED NOT NULL DEFAULT 0
views => INT (10) UNSIGNED NOT NULL DEFAULT 0
categoryid => INT (10) UNSIGNED DEFAULT NULL
postid => INT (10) UNSIGNED DEFAULT NULL

quoteratings
userid => INT (10) UNSIGNED NOT NULL
quoteid => INT (10) UNSIGNED NOT NULL
rating => TINYINT (1) NOT NULL

guestquoteratings
ip => VARCHAR (15) NOT NULL
quoteid => INT (10) UNSIGNED NOT NULL
date => INT (10) UNSIGNED NOT NULL
rating => TINYINT (1) NOT NULL

quotecategories
categoryid => INT (10) UNSIGNED NOT NULL AUTO_INCREMENT
title => VARCHAR (64) NOT NULL
description => VARCHAR (250) DEFAULT NULL
public => TINYINT (1) NOT NULL DEFAULT 1
displayorder => SMALLINT (5) SIGNED NOT NULL DEFAULT 0

Here are the keys (table name on the left, keys after the =>):
quotes => PRIMARY KEY (quoteid), KEY (approved), KEY (rating), KEY (average)
quoteratings => PRIMARY KEY (quoteid, userid)
guestquoteratings => PRIMARY KEY (quoteid, ip)
quotecategories => PRIMARY KEY (categoryid)

And finally, these columns need to be added to other tables:

user
quoteitoptions => INT(10) UNSIGNED NOT NULL DEFAULT 0
lastquotesvisit => INT(10) UNSIGNED NOT NULL DEFAULT 0
quotecount => INT(10) UNSIGNED NOT NULL DEFAULT 0

usergroup
quoteitpermissions => INT(10) UNSIGNED NOT NULL DEFAULT 2567

Calash

01-16-2007, 05:12 PM

The latest download has resolved the issue with the edit button, it now does an AJAX edit.

I still have the language bar issue. Normally I only have 1 language (English) and the drop down selection is not visible. When I install QuoteIT the drop-down shows up and has a random selection (I have seen A, E, and blank). I will leave it up so you can take a look.

I am also having issues with the vBadvanced module. I set it up per the instructions but it does not show up. I have not had time to trouble shoot yet, but if you can give me some common problem areas to look at it would help :)

Thank you for making the mod...it is something I thought I was going to lose when I moved to vB.

Alien

01-17-2007, 01:44 PM

Calash

01-17-2007, 01:58 PM

The vBadvamced module problem seems to be related to permisisions. If I edit the get_random_quote() function and remove the "canviewquote" check it works fine. I need to fix the layout but that is a skin issue and not a QuoteIT issue.

May be off on the names, I am at work ATM.

Alien

01-17-2007, 02:04 PM

Okay, added the entries above and so far so good without mysql errors in the admincp..

I'll also upgrade to the latest version you posted shortly.

zetetic

01-17-2007, 02:08 PM

Sorry Cap'n, I haven't had a chance to work on this for the last couple days so I can't give any feedback about the current revision. However, would you mind updating the filename or OP with the current rev number when you release new revisions? I'd like to make sure I grab the latest.

Thanks again for all your work on this.

thepub

01-17-2007, 03:04 PM

so I have to reinstall in order to get the edit button to look normal? I finally got it installed and showing, but it's very large on the forum index and the edit button looks like an edit button on the board.

thepub

01-17-2007, 03:38 PM

this may be the dumbest question ever but where exactly is the modules/moderate.php at so I can edit the file according to the vbadvanced installation instructions?

zetetic

01-18-2007, 12:30 AM

The modules directory should be in your forum root. So like yoursite.com/forum/modules/

Cap'n Steve

01-18-2007, 04:58 AM

zetetic - It's at the top, right under the title, but the easiest way to check is to go to "Manage Products" in your admincp and then there'll be a "Check Version" option in the list next to QuoteIt!

thepub - That module and the directory itself come with vBadvanced. I'm not sure what you mean about the edit button. The actual image is too large? You'll have to edit the quote_listbit template to change the size.

yonglvnv

01-18-2007, 06:35 AM

Still looking at the language chooser and vBadvanced bugs.

yonglvnv - It's not reading the permissions for some reason. Did you still have includes/xml/bitfield_quoteit.xml on the server?

Just checked, yes it was. Will delete and reinstall again. Thanks!

UPDATE: Quote IT 3.08 still doesn't show on my vba module, but it shows again when I downgrade to 3.07. Some parts of formatting is still off as I posted before, otherwise, I'm happy with 3.07. Could you help?

Firen

01-18-2007, 07:40 AM

I've reinstalled the latest version, but I still can't seem to get the edit button to work.

yonglvnv

01-18-2007, 07:47 AM

Cap'n Steve, played around with it a bit with 3.07, I finally got the formatting thing kind of figured out and everything looks like where they are supposed to be. Anyway to get rid of blank lines over and below the quotes and make the actual quotes a bit wider to take up less lines? Basically want to compact the height as much as possible.

Cap'n Steve

01-18-2007, 08:32 AM

The new version is up. vBadvanced problems should be fixed, although it's still ugly in some styles, so I recommend you use quotesideblock.php as the module even if it's going to be used in the center block. Quick Language Chooser should also be fixed, but you must save your QuoteIt! Options first.

Firen - Did you redo that edit to clientscript/quoteit_moderation.js that I posted a while ago? Does it say anything?

yonglvnv - The margins are set in clientscript/vbulletin_css/quoteit_main.css, look for the .quote and .quotetext lines. If you're using Internet Explorer, the spacing is one of the things I couldn't quite get right, that's set in the other css files.

soulface

01-18-2007, 10:15 AM

YES! Quick Language Chooser bug is fixed! also the CMPS module. working fine...

one question, i want to use tahoma as the font of Quotes, Auther name & context text. how do i do that ?

thepub

01-18-2007, 12:47 PM

I mean the size of the quoter is very large on my board in comparison to the demo you posted.

www.theneighborhoodpub.com take a look for yourself. I cannot get tit to show on the main page so you will have to click on forums to view it.

Firen

01-18-2007, 07:46 PM

Firen - Did you redo that edit to clientscript/quoteit_moderation.js that I posted a while ago? Does it say anything?

Nope. It doesn't do anything. Not even an error message. Very weird.

thepub

01-18-2007, 09:49 PM

edit button is working and quoter is working except it still is not showing up on the main page of my forum and I set it up to do so according to the module and instructions. I'm getting there lol!

Cap'n Steve

01-19-2007, 02:24 AM

Firen - Could you give registered users permission to edit their own quotes for a minute on your site? I'll take a look at it.

thepub - It looks normal to me. It should be using the width used by the style. You are missing the images though, you might want to upload those to whatever images directory the style uses. To get it working in vBadvanced, there's one extra instruction in the latest version. You should also make sure the random quote is enabled. If it still won't work, you can post a screenshot of the module settings and your QuoteIt! options.

soulface - In quoteit_main.css, find these three lines:
.quotetext {
.author {
.context {

below each one, add this:
font-family: Tahoma;

Firen

01-19-2007, 02:30 AM

Firen - Could you give registered users permission to edit their own quotes for a minute on your site? I'll take a look at it.
All set up. Thank you for checking it out for me. :)

Cap'n Steve

01-19-2007, 02:53 AM

It worked fine for me. Try doing a shift + refresh to make sure your browser gets the latest files.

Firen

01-19-2007, 03:16 AM

Hmmm, I did shift + refresh twice, and i'm still having a problem.
Here's the error message that I got:

59266

Don't suppose it's something to do with the fact that i'm using Safari? Just a thought. Might test it on firefox and see what happens.

ETA: I just tried in Firefox and got the same error message. Could it be an admin problem perhaps?

Cap'n Steve

01-19-2007, 03:58 AM

jluerken

01-19-2007, 07:42 AM

Cap'N Steve the language Chooser bug seems to be fixed. I will do some more testing and turn back to you if needed. Thanks in advance!

Firen

01-19-2007, 07:49 AM

That's from the edit you did to quoteit_moderation.js. If you hit enter (since the ok button is off screen) it'll continue just fine. Reupload the default clienscript/quoteit_moderation.js and try again.

EDIT: In case you want to do a full refresh, it's probably some key other than shift on a Mac.

Still not working. Although the other Administrator just tried it and had no problems. I just can't work it out. I am the main Admin (my user ID is 1), so I don't know if that's it. I'm totally stumped.

I'm determined to work it out though. :)

efil

01-19-2007, 08:02 AM

YES! Quick Language Chooser bug is fixed! also the CMPS module. working fine...

one question, i want to use tahoma as the font of Quotes, Auther name & context text. how do i do that ?

Were can i see the Quick Language Chooser?

thepub

01-19-2007, 08:18 PM

The BB code's and smileys show when I am viewing all quotes, but not on the quoter itself (like on a forum index or whatever)

BaconDelight

01-19-2007, 08:44 PM

The BB code's and smileys show when I am viewing all quotes, but not on the quoter itself (like on a forum index or whatever)
I was having the same problem after upgrading to 3.09, but going into the admicp and re-saving the Quote Parsing Options seems to have done the trick.

Cap'n Steve

01-19-2007, 10:45 PM

efil - If you have more than one language it's at the bottom of the page, next to the style chooser.

thepub - Yes, try saving the options again. For your images problem, using your red-gray style as an example, it's looking for the images in images/styles/redgray/ so you need to upload them there. It'll be a different folder for each style.

Firen - Does it do anything? Sometimes you have to wait a little while. Try it on my site.

Neutral Singh

01-19-2007, 11:00 PM

I would like to show these quotes in the first post of a new topic made by any member. I have tried some variations but... how can i modify the plugin so that it shows the quotes in the postbit / postbit legacy templates as well... TIA

Firen

01-19-2007, 11:02 PM

Firen - Does it do anything? Sometimes you have to wait a little while. Try it on my site.

Well, I waited, and nothing. LOL I don't know if this is making you as nuts as it's making me!

Cap'n Steve

01-19-2007, 11:56 PM

Neutral Singh - If you follow the instructions for adding a quote to any page, you should be able to put it above the thread in the showthread template. If you want it to look like the first post in a thread, I'm not sure exactly how. There must be a variable to tell if a post is first or not, I'll look around.

Firen - Did you try it on the site in my profile? I can't test it in Safari, but it works in Konqueror so it should be fine.

zetetic

01-20-2007, 01:48 AM

Neutral Singh

01-21-2007, 01:26 AM

Neutral Singh - If you follow the instructions for adding a quote to any page, you should be able to put it above the thread in the showthread template. If you want it to look like the first post in a thread, I'm not sure exactly how. There must be a variable to tell if a post is first or not, I'll look around.

Thanks for your reply. I want to show the quote in the postbit template as special section highlighting some quotes from members. I have set the plugin as global but still its not showing up. I dont know how to show the quote in a posbit? Please guide me.:confused:

Thanks

Cap'n Steve

01-24-2007, 08:07 AM

Neutral Singh - Sorry that took so long, try this plugin. Make sure you import it as a plugin, not as a product.

El_Muerte

01-24-2007, 08:44 AM

is it just me or is the admincp part completely fubar?
saving the options has abolute no effect

also, why the (aweful) non standard template+css usage

Cap'n Steve

01-25-2007, 02:40 AM

TheBlackPoet

01-25-2007, 03:27 AM

i dont want to sound unappreciative.... because i do appreciate your good work..., but..... i upgraded to this new version and i was forced to lose the 100+ quotes from the old hack.., anyway, after it installed, it was jacked up... the right quotation mark was all up in my shoutbox!!... suffice it say... i uninstalled 3.0 and was going to go back to your old version... no good.. it wont install..

my "Quotes" moderator is pissed because i lost all her work and now, i have no quotes hack at all...

Cap'n Steve

01-25-2007, 04:57 AM

What exactly did you do? Upgrading shouldn't affect the quotes you already have.

Ole_Chilli

01-25-2007, 06:25 PM

CApn Steve is there any way to make this hack combined with the Marquee system hack

El_Muerte

01-25-2007, 06:30 PM

Try a reimport if your options aren't saving. What specifically don't you like about the templates. People complained about the tables before, so I worked for quite a while on a table-less style, discovered that it wasn't feasible, and settled on about 3 tables. If by standards you're talking about validation, it's not really realistic to have a 100% valid XHTML page.

reimporting doesn't do anything.

the problem with the template+css is that it doesn't fit in with the default vbulletin style, it doesn't respect things like cellspacing and cellpadding. There's also a lot of useless margin and padding going on in the css.

thepub

01-25-2007, 08:43 PM

for some reason I cannot get the quoter to appear in all forum despite me changing the hook to global start. Also, on the forum index, the quoter shows BB codes but on my homepage (vba) it doesn't show the BB codes any idea how to fix it?

Cap'n Steve

01-26-2007, 02:26 AM

Ole_Chilli - You'd probably just have to edit some of the quote templates. I've never used that hack though, so you might want to ask its creator.

El_Muerte - It doesn't use cellspacing or cellpadding because it's all one cell. It still uses the vBulletin alternating colors and width. If you can clean up the CSS, please do. That gave me a huge headache.

Cap'n Steve

01-26-2007, 03:33 AM

thepub - One thing I neglected to mention in the instructions: Make sure the execution order on the new plugin is set higher than five.

El_Muerte - Run this query (replacing $TP with your table prefix) and tell me what it says:
SELECT * FROM $TPdatastore WHERE title = "quote_settings"

thepub

01-26-2007, 01:03 PM

thepub - One thing I neglected to mention in the instructions: Make sure the execution order on the new plugin is set higher than five.

Thanks! Can you tell me where and how I would do this? :confused:

El_Muerte

01-26-2007, 05:08 PM

El_Muerte - Run this query (replacing $TP with your table prefix) and tell me what it says:
SELECT * FROM $TPdatastore WHERE title = "quote_settings"

I don't use the default datastore, I use the APC datastore class. Maybe that's the issue?

Cap'n Steve

01-26-2007, 10:52 PM

thepub - Just edit the plugin that you moved to global_start.

El_Muerte - Possibly. Do you know if it unserializes things automatically?

El_Muerte

01-27-2007, 08:55 AM

yes I think it does. It calls register in the Datastore class without a 3rd argument, so the auto detect will be used.

Why don't you simply address the datastore through the api:

// get data, only needed once
$vbulletin->datastore->fetch(array("mykey"));
// read data from:
$vbulletin->mykey;

// store data:
build_datastore("mykey", $mydata, 2); // 2 means automatically detect for unserialization

TheBlackPoet

01-29-2007, 03:42 AM

well capt... i am going to be the first to admit my mistake..... i ASSUMED... that the quote hack i already had.., was the same code... so as i went through each template, and saw that the comment was in the template code, i didnt bother to paste over it.. (tryign to save time).... then to top it off... i tried to do something else.. broke the site.. but i got it back.....

long story short...., your hack work great now.... i uninstalled all the code from the older hack... and re-installed the 3.0... it works fine...

my own lesson?? read the damn instructions!!!!

INSTALLED

Cap'n Steve

01-29-2007, 08:36 AM

Version 3.1 has been released. It has some minor bug fixes, including compatibility with datastore caching, better redirection, and better support for vBadvanced and global random quotes.

Why don't you simply address the datastore through the api

Well, because I didn't know about that. :o

thepub

01-29-2007, 12:11 PM

thepub - Just edit the plugin that you moved to global_start.

I changed it and while it showed on all forums, the quoter's look changed and I wasn't able to vote or edit quotes any longer :confused:

Cap'n Steve

01-29-2007, 08:13 PM

What did you change? I've updated the instructions in the latest version, try that.

thepub

01-29-2007, 09:18 PM

What did you change? I've updated the instructions in the latest version, try that.

I changed the execution number to something higher than 5 like you said. Do I need to reinstall it again? :confused:

Cap'n Steve

01-30-2007, 03:12 AM

That would be easier. I've changed it so it's just another file import now.

thepub

01-30-2007, 12:14 PM

That would be easier. I've changed it so it's just another file import now.

aww heck...ok I'll report back if it doesn't work lol!

thepub

01-30-2007, 01:26 PM

ok reinstalled... only one of the quotation marks show on the homepage and still no bb codes. Quoter shows on forum index but not in forums like I'd like. If I change the hook to global start it will only show on the homepage and nowhere else. I changed it to forum start and it at least shows on homepage and forum index.

Cap'n Steve

01-31-2007, 04:27 AM

I just uploaded 3.11 to fix a few minor bugs that could cause a database error.

thepub - You shouldn't have to change any hooks now. Are you following the latest instructions? I can't duplicate your bbcode problems, try saving your Quote Parsing Options again. The closing quote has been hidden in some situations were it was escaping from the quote table.

El_Muerte

01-31-2007, 04:36 PM

3.11 still doesn't fix all issues. "Quote Parsing Options" and "Quote Administration Options" are not saved (I think), at least they don't show up changed in the admincp

BaconDelight

01-31-2007, 05:18 PM

EDIT - Nothing to see here, fixed the problem.

BaconDelight

01-31-2007, 05:33 PM

So, I'm still not thrilled with the look of this in IE. Take a look at my two screen shots (one of the random quote display and one of the full quote list). I can't seem to get both to look good at the same time.. Any help in editing the templates and css would be greatly appreciated. What I'd like to see is the large gaps between everything (between the "added by" and the quote, between the quote and the author, and between the author and the bottom) shrunk, as well as move the author to the left so it's about 1/4 indented from the left of the quote. Additionally, on the random display, it seems the right side margin is rather small leading to the quote running off centered to the right.

Since both the random quote display and the full quote list both call the same listbit template, if I try to make one look right, it fouls up the other one. Again, any help would be appreciated.

Cap'n Steve

01-31-2007, 10:44 PM

El Muerte - Are you sure about the Administration Options? I have a feeling I know why the Parsing Options might not save, but the others are all saved together.

So, I'm still not thrilled with the look of this in IE.

You and me both. I'm tempted to make each quote a table row like it was in the original version. I know tables are evil and all that, but it would probably make things easier. I'll keep working on it.

my3shadows

02-01-2007, 02:04 AM

You and me both. I'm tempted to make each quote a table row like it was in the original version. I know tables are evil and all that, but it would probably make things easier. I'll keep working on it.

I just installed the latest version and the right sides of all the quotes are cut off in IE 7 along with the buttons at the top of each quote...everything looks fine in Firefox 2 except the quotes are kinda squished toward the center.

I know I wouldn't mind tables if it will clean up the look of the quotes. That aside though, I really like this hack. :)

BaconDelight

02-01-2007, 03:00 PM

Ditto, I've got no problem with tables if that's what it takes to look good.

El_Muerte

02-04-2007, 02:10 PM

El Muerte - Are you sure about the Administration Options? I have a feeling I know why the Parsing Options might not save, but the others are all saved together.

It looks like the settings are saved to the array properly, but they don't show correctly afterwards

brookemegg

02-05-2007, 12:20 AM

Thanks for the great add-on. I really like it!

We have one problem with it though, when we click on "View All Quotes", it takes us to "Add a Quote". Please help me fix this. Thanks!

www.spiffymoms.com

MaestroX

02-05-2007, 02:05 PM

This worked fine until I added a quote, now when I go to quotes.php I get this error message:

Warning: array_merge() [function.array-merge]: Argument #2 is not an array in /includes/functions_quoteit.php on line 23

Warning: Cannot modify header information - headers already sent by (output started at /home/maestrox/public_html/forum/includes/class_core.php:3032) in /includes/functions_quoteit.php on line 1135

Thanks

Cap'n Steve

02-06-2007, 04:48 AM

brookemegg - Do you have any quotes in the database? Make sure you've moderated them if moderation is on.

MaestroX - Try reinstalling or saving the QuoteIt! Options in the admincp.

jw00dy

02-06-2007, 04:57 AM

Pretty sweet add-on, although, the formating (as you already know) is a tad messed up. The box they show in is too big too. I'm all for using a table if it helps. Tables aren't evil anyway.

MaestroX

02-06-2007, 08:10 AM

brookemegg

02-06-2007, 10:42 AM

brookemegg - Do you have any quotes in the database? Make sure you've moderated them if moderation is on.

That was it. I thought I Had moderation turned off, but i was wrong. Once I turned it off, all was good. :D

Thanks so much!!!

BaconDelight

02-06-2007, 02:27 PM

Thanks Cap'n Steve :)

But i've came across another problem. HTML is not parsed. The raw HTML is outputted using "show random quote" variable.

I've checked all options and it seems to be correct.

ThanksDid you click to save the settings? Even if you don't change them, click the save button once. I was having the same problem with BBCode after the last upgrade and saving the parsing settings once solved it.

thepub

02-06-2007, 02:39 PM

so far everything working well except I only have one quotation mark showing on my homepage instead of both.

mamashid

02-06-2007, 03:01 PM

I did something.....I added this hack to my page, now we cant do anything on the board, i cant even get into the admin panel

Cap'n Steve

02-06-2007, 09:35 PM

mamashid - Could you tell me what the problem was? You can disable the plugin system by following these instructions.

ubblite

02-09-2007, 07:05 AM

First off, nice mod Cap'n Steve - thanks.

I am receiving the following error after trying to delete a quote (not from the view all quotes area, but on the top of the quote itself from the forumhome page):

Warning: Invalid argument supplied for foreach() in /quotes.php on line 723

Database error in vBulletin 3.6.4:

Invalid SQL:

SELECT * FROM quotes
WHERE quoteid IN ();

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 2
Error Number : 1064
Date : Friday, February 9th 2007 @ 04:00:41 AM
Script : http://www.*******.com/forum/quotes.php
Referrer :
IP Address : -------------
Username : ----------
Classname : vB_Database_MySQLi

Also, the end quote is uneven with the text quite a bit.

ubblite

02-09-2007, 09:05 AM

I have discovered some more problems.

QuoteIt is not centered and looks different from your screenshot. The collapse button is also out of place. And when you go to add a quote, under category if the name is a bit long it will cut it off. This happens with both IE & FF and I'm using the default vBulletin style. I've attached a screenshot of the forumhome page.

One more thing. In Firefox's Error Console it shows "fillStars is not defined" & "emptyStars is not defined" continuously as you browse over the quote ratings.

Cap'n Steve

02-09-2007, 08:30 PM

ubblite - It's not finding the CSS files. Is that on a vBadvanced page? Could you post a link?

ubblite

02-10-2007, 02:57 AM

Well I guess CMPS was the problem, Steve. I had a CMPS module integrated into my forumhome page and I guess it was treated as a CMPS page. For some reason, other stuff like the Shoutbox is just a forumhome integration hack that doesn't have a problem w/it. Strange but not a big deal - I just removed CMPS from the forumhome.

I do get the same problem here as mentioned earlier in this thread with Languages. It shows an "-a" as another language with this hack installed.

Everything else seems fine for the most part.

Thanks for your help.

Cap'n Steve

02-10-2007, 07:19 AM

ubblite - Are you sure you have the latest version? That bug should have been fixed for good.

ubblite

02-11-2007, 04:06 AM

ubblite - Are you sure you have the latest version? That bug should have been fixed for good.
Yup, I definitely have the latest version installed.

I also have the same problem as another user in this thread who has PhotoPost Pro. When viewing 'Who's Online', under location it is completely blank if they are viewing Photopost.

Thanks

Sadie Frost

02-12-2007, 12:33 AM

Hey!

I went over the table structure carefully, and I have everything you showed above in your table structure EXCEPT for this in the quotes table:

date => INT (10) UNSIGNED NOT NULL DEFAULT 0
views => INT (10) UNSIGNED NOT NULL DEFAULT 0
categoryid => INT (10) UNSIGNED DEFAULT NULL
postid => INT (10) UNSIGNED DEFAULT NULL

I upgraded from the 3.5 version (version 2.1 it says in the Product Manager?) on 5 boards (lol), and it worked fine on 4 of them. The fifth though I seem to be having the same problem as Alien did above (page 9/10 of this thread).

I tried to add the missing fields to the tables but I get this error in phpmyadmin:

ALTER TABLE `quotes` ADD `date` INT( 10 ) UNSIGNED NOT NULL DEFAULT '0',
ADD `views` INT( 10 ) UNSIGNED NOT NULL DEFAULT '0',
ADD `categoryid` INT( 10 ) UNSIGNED NOT NULL DEFAULT '0',
ADD `postid` INT( 10 ) UNSIGNED NOT NULL DEFAULT '0'

MySQL said:

#1060 - Duplicate column name 'quoteid'

I am using MySql version 4.1.21 there. I also get the same errors if I try to use the latest version from the 3.5 version thread. I also did choose the allow overwrite.

Does anyone have any ideas for me? Is it jsut a MySQL version problem?

Also I know that I read this somewhere but I just read through the thread again and couldn't find it, so I'm sorry. But all my dates on my quotes are "12-31-1969"? Is that just because I've just installed the new version?

Thanks :)

Cap'n Steve

02-12-2007, 03:35 AM

ubblite - I'm not sure if you saw the post in the other thread, but could you tell me how many languages you normally have, or even better, give me a link? I can't really test the Photopost problem, but I'll take another look.

Sadie Frost - Try adding each column individually. Try using the phpMyAdmin interface instead of typing it in manually ("add new field" at the bottom of the page when viewing table structure). The date problem is because of the incomplete install, but it will default to the date you installed it when the quote doesn't have a date stored (which is all of the ones added before this version).

I'd love to know what's causing that problem, but I have no clues so far.

Sadie Frost

02-12-2007, 07:25 PM

Hi Cap'n :) Thanks for the response :) I really do love this hack, and have been using it for a while. It's so odd that out of five upgrades done exactly the same at the same time that only one would have a problem when the rest were fine.

The one with the problems is on a different server than the other four, but both are using MySql 4.1.21.

The way I tried to add the new fields before was through the phpmyadmin interface. I tried doing them one by one and trying to do it by just running a query for it, but I still get that duplicate quoteid column message.

Weird! lol

Cap'n Steve

02-13-2007, 04:46 AM

Cap'n Steve

02-13-2007, 07:18 AM

I just uploaded a new version with a few small improvements, including improving the style, especially on vBadvanced pages and especially in Internet Explorer.

turiel

02-13-2007, 12:33 PM

There seems to be a problem with installing it - the Importing Product progress bar seems to go on 'forever' (by forever I mean 15 minutes before I stopped it). Maybe it normally takes that long, I just haven't seen a mod do that before. I'm using the latest vBB and mod.

BaconDelight

02-13-2007, 10:59 PM

I just uploaded a new version with a few small improvements, including improving the style, especially on vBadvanced pages and especially in Internet Explorer.It's certainly an improvement. Thanks!

BTW, I'm working on adding a feature to this, if I get it working I'll pass my code on to you if you want to include it in a future release. I'm trying to add a redirect link back to the thread after you've submitted a post to quotes. A couple users have said they're annoyed that it kinda dead-ends at the page displaying the submitted quote.

jw00dy

02-13-2007, 11:28 PM

Thanks, upgrade worked flawless.

Looks a lot better now too.

Cap'n Steve

02-14-2007, 01:02 AM

turiel - Just try importing it again. Do you have a lot of styles? Updating those seems to take the longest.

BaconDelight - Good idea.

confus

02-14-2007, 06:17 AM

eep installed it without testing thinking its just a small quick simple hack and it killed stuff :(
trying to access admincp or the vbadvanced index page gave php errors (attached)

its possible it was the same problem as mamashid had heh

I had to go to /admincp/plugin.php and untick all the boxes for this hack, then everything ran again and I uninstalled the hack

While it was my fault it was bad consequences for a minor error, in my rush of getting it done so I could do something else I uploaded the files to the main dir, not the forums dir, then installed the xml file
xml files couldn't find the files and gave me those errors

Sadie Frost

02-17-2007, 10:18 PM

Well, the only thing I can think of is to make a backup of your quotes and quoteratings tables, delete them, reimport the product, and then restore the backup (making sure you don't have it add any drop table statements when you export).

Thanks! That worked. The reinstall went off without a hitch, so I have no idea what the deal was with it :) Just had to doctor the backup file a bit to deal with the additional columns but that wasn't bad. Thanks for your help :D

TPOCJames

02-19-2007, 06:22 AM

Okay, I've installed it, but it won't let me approve quotes. I've checked my permissions, they are fine, and I've rebuilt the bitfields, and it still won't work. Help please :)

Cap'n Steve

02-20-2007, 03:25 AM

So it gives you the no permission error? Will it even let you see unapproved quotes? Are you an administrator?

Raw Sugar

02-24-2007, 11:49 PM

ok I've got a huge problem I installed a plugin and after I had installed it, it won't let me view my mod cp or my admincp it says the following.

Warning: Invalid argument supplied for foreach() in /includes/functions.php on line 3542

How do I fix that?

lazyseller

02-25-2007, 02:38 AM

im getting this as well on 3.64 Warning: Invalid argument supplied for foreach() in /includes/functions.php on line 3553

Cap'n Steve

02-25-2007, 09:48 PM

<a href="showthread.php?p=1153153#post1153153" title="vBulletin.org Forum - Post 1153153">These instructions will disable the plugin system.</a>

Did you see any errors during installation? Are you using any PHP cacheing system?

BrettMo

02-26-2007, 01:45 AM

I added all the files to my server in the appropriate location, uploaded the xml file mod, ran the config including turning on quotes, uploaded some quotes, and added the code to FORUMHOME after $navbar, so why won't it display some quotes? (vBulletin 3.6.4) Any ideas? I have jacked around with it for at least half an hour and read through the thread here, but still seem lost.

Cap'n Steve

02-26-2007, 06:16 AM

Do you still have to approve the quotes? Check under "Moderate Quotes".

BrettMo

02-26-2007, 12:10 PM

Looked under Moderation and see nothing to moderate. I uploaded one quote again to be certain that it worked correctly and had no issues uploading it. To double check I did a view source also on the main page and see the two comments ().

Cap'n Steve

02-26-2007, 08:30 PM

Could I get a link to your site?

Cap'n Steve

02-27-2007, 04:04 AM

BrettMo

03-02-2007, 04:15 AM

I'm getting no permission errors on your quotes page, do you have guests or registered users allowed to view quotes? If you have phpMyAdmin on your server, could you post the contents of your quotes table?

Steve, I got it working. It seems that it was that the quotes table was corrupted but when reading the instructions I did not think to rebuild the table because the function was not giving me an permission error. I ran the table fix program and after that I found several messed up records, so dropped all the records and reloaded them. Now it looks great.

Thanks for the great function and the support.

Cap'n Steve

03-02-2007, 05:48 AM

That's strange. Do you have any idea what went wrong? MySQL has been having a lot of strange errors lately.

Chadi

03-02-2007, 07:53 PM

Can you please explain how to remove the author (who submitted the quote) name and date from the quote template? What code and which template?

Also, how do I remove the delete quote link and edit button?

Basically, I want only the quote/author to show up only.

Chadi

03-02-2007, 08:00 PM

I edited the listbit template and got everything going except there is still a big blank gap on the bottom part which I cannot find the proper code to remove to correct that

<tr><td class="quoterow {$quoteclass}" align="left" id="quote{$quote['quoteid']}-{$globalcounter}">

<p class="quote"<if condition="($quote['userid'] == $vbulletin->userinfo['userid'] AND $quoteitpermissions['caneditownquotes']) OR ($quote['userid'] != $vbulletin->userinfo['userid'] AND $quoteitpermissions['caneditotherquotes'])"> ondblclick="editQuote(event, {$quote['quoteid']}, {$globalcounter});return false;"</if>>
<span class="quotetext" id="quotetext{$quote['quoteid']}-{$globalcounter}">{$quote['quote']}</span>
<if condition="!$sidebar">
</if>
</p>

<div class="authorcontainer">
<if condition="!empty($quote['author'])">
<div class="author" id="author{$quote['quoteid']}-{$globalcounter}">- {$quote['author']}</div>
</if>
<if condition="$quoteitoptions['enablecontext'] AND !empty($quote['context'])">
<span class="context" id="context{$quote['quoteid']}-{$globalcounter}">({$quote['context']})</span>
</if>
</div>

<if condition="$_REQUEST['do'] != 'preview' AND !$sidebar">
<div class="quotebottom">
<if condition="$quoteitoptions['ratings']">
<span class="stats" id="stats{$quote['quoteid']}-{$globalcounter}">{$vbphrase['total_rating']}: {$quote['rating']} - {$vbphrase['votes']}: {$quote['votes']} - {$vbphrase['average']}: {$quote['average']}</span>
<span class="ratethis" id="rating{$quote['quoteid']}-{$globalcounter}">{$ratethis}</span>
</if>

<span class="inlineimg unapproved" id="unapproved{$quote['quoteid']}-{$globalcounter}">
<img src="{$stylevar['imgdir_misc']}/moderated.gif" alt="{$vbphrase['unapproved_quote']}" <if condition="$quote['approved']">class="approved" </if>/>
</span>

</div>
</if>

</td></tr>

Cap'n Steve

03-02-2007, 08:27 PM

You'll have to edit clientscript/vbulletin_css/quoteit_main.css.

Chadi

03-02-2007, 08:47 PM

Thanks.

Where can I edit quotes? I need to fix some categories.

Great hack

Feedback
- multiple quote addition ability
- more admin functions in backend (edit quotes)
- sort categories alphabetically, automatically
- choose by topic or by author (now, category shows category list only)
- modify category listing option / frame size

Chadi

03-02-2007, 09:08 PM

You'll have to edit clientscript/vbulletin_css/quoteit_main.css.

Which line/code portion is it? Sorry, not a programmer or coder :)

Cap'n Steve

03-03-2007, 12:59 AM

There's an "edit quote" link in the top right of each quote as long as you have given yourself permission to edit quotes. As far as the CSS file goes, I don't know what the specific problem is, but take a look at the .quote, .quotebottom, and .authorcontainer classes.

- multiple quote addition ability

You can already import a text file containing quotes. Do you have another way that would work?

- more admin functions in backend (edit quotes)
- sort categories alphabetically, automatically

Good idea, but how would editing quotes in the admincp work? I guess I could have a place to enter the quote ID to edit it.

- choose by topic or by author (now, category shows category list only)
- modify category listing option / frame size

I'm not sure what you mean by these.

Chadi

03-03-2007, 01:10 AM

Thanks for your reply. The ability to select from the category list would be two options, either by the quote topics (which I've done on my end at least) or a 2nd category option (frame), would be the author's name (hence this coincides with the author field that one inputs when adding a new quote)

In regards to editing a quote, that is only seen in the actual location (forum) where the quote is shown. Its not in the quotes.php (quotes manager area) anyway