Add-On Releases - Stock Trader for vBulletin [Archive]

zethon

12-29-2006, 10:00 PM

Stock Trader

Summary
This add-on gives your users the ability to use the money system on your board to "invest" in stock. Users can purchase and sell stock at market values. This plugin uses a stock feed from Yahoo to get real time stock quotes.

Release Notes
This product is considered to still be in Beta.This should be ending by the end of January.

This add-on is known to be compatible with vBulletin's built-in reputation system, vbBux and iCash.

Product Specifications

two plugins
one cron job
file uploads
one new DB table
one template
several phrases

Installation
Approx 2-5 mins

As always: Back up your Database!
upload the files in the "upload" directory, preserving the directory structure
Go into AdminCP and import the product-stocktrader.xml file.
(OPTIONAL) add a link in the navbar template or wherever your users can find it!

Upgrading/Updating

upload all files in the upload directory, overwriting any existing files
re-import the XML file, setting "Overwrite" to "Yes"

Configuration

vBulletin Options -> Stock Trader Options

Change History

0.9.9 (07-25-01) - fixed problem with trading mutual funds, fixed cheat with buying off hours (I think)
0.9.8 (07-18-01) - added new options and fixed bug with purchasing really cheap stock
0.9.7 (07-15-01) - fixed bug in top portfolios when using a table prefix
0.9.6 (07-15-01) - fixed table prefix issues, fixed portfolio.gif problem
0.9.5 (07-14-01) - added statistics page, ability to view other user portfolios, and postbit friendly variables
0.9.4 (07-09-01) - added a Capital Gains Tax option
0.9.3 (07-02-01) - fixed error with purchasing negative stock, fixed compatibility with iCash
0.9.2 (07-05-01) - bug fixes
0.9.1 (06-30-12) - added AJAX stock info lookup
0.9.0 (06-29-12) - initial Beta release

Future Features

stock ticker marquee for users

Official Support
http://code.google.com/p/vbtrade/

PLEASE CLICK INSTALL!

zethon

12-29-2006, 11:21 PM

Reserved.

TTG

12-30-2006, 12:17 AM

Looks like an interesting addition .. clicked install and await future features

rinkrat

12-30-2006, 12:48 AM

This sounds like a great idea!

lordnex

12-30-2006, 12:57 AM

Wow.. this is a great idea. So much potential.

TheBlackPoet

12-30-2006, 01:05 AM

i cant wait to get home and test this!!!

lovelypk

12-30-2006, 01:56 AM

looks kool.

Quantnet

12-30-2006, 02:24 AM

this will work great on my financial engineering forum. Would be awesome if we can trade other kind of products such as options, equity along with stocks..:D

UltimateOreo!

12-30-2006, 02:37 AM

I am DEFINATELY going to install this once it gets past the beta stage.

Oddjob

12-30-2006, 03:35 AM

*Hopes vbbux will work with this soon".

zethon

12-30-2006, 03:40 AM

*Hopes vbbux will work with this soon".Give it a try. I believe vBux uses a field in the user table to keep track of that user's "money". This plug-in should be compatible with any money system which uses the user table, which I believe is most money systems.

Oddjob

12-30-2006, 03:48 AM

Give it a try. I believe vBux uses a field in the user table to keep track of that user's "money". This plug-in should be compatible with any money system which uses the user table, which I believe is most money systems.

Yea, ill wait for someone more experienced to give it a whirl.

soletrader

12-30-2006, 04:59 AM

I installed it and turned it on. However, all I am getting is Invalid Action Specified and can not open vbtrade.php

zethon

12-30-2006, 05:19 AM

I installed it and turned it on. However, all I am getting is Invalid Action Specified and can not open vbtrade.phpCan you confirm that you've correctly specified a valid usergroup and money row in the "vBulletin -> Stock Trade" options?

soletrader

12-30-2006, 05:20 AM

I dont use reputations or any form of point system. What should I put in the money row?

zethon

12-30-2006, 05:26 AM

I dont use reputations or any form of point system. What should I put in the money row?You need to use some kind of point/money system, whether it be reputation, vBux or something else. Otherwise what will your users use to "buy" stock?

soletrader

12-30-2006, 05:47 AM

I was thinking more like virtual money where users start off with something like $1million. And when they go bust they can simply refresh their account.

I love the hack though. Nice work.

zethon

12-30-2006, 05:55 AM

I was thinking more like virtual money where users start off with something like $1million. And when they go bust they can simply refresh their account.

I love the hack though. Nice work.That's not a bad idea for a future version. I will ponder this and maybe added it to the future features.

BigJimTheLug

12-30-2006, 06:02 AM

Reserved for future use, hopefully updates.

*installed*

soulface

12-30-2006, 06:13 AM

Installed on my test forum. vbbux as a money row option working fine so far..

Features request:

1. Stock Symbol lookup (AJAX will be gr8)
2. Selling Stocks to other members.

soletrader

12-30-2006, 08:10 AM

I have another request. Perhaps a simpler version where the users can retreive stock quotes only instead of buying and selling shares. Thanks

Lionel

12-30-2006, 01:57 PM

You need to fix the sql insert from VALUE to VALUES

zethon

12-30-2006, 02:02 PM

You need to fix the sql insert from VALUE to VALUESGood catch. Thanks. I will have this change and a couple other minor changes in a release I'm going to put up in a coupe hours.

Lionel

12-30-2006, 02:05 PM

A vbadvanced module displaying the major indices to all, 5 user's top stocks with a link to complete portfolio would be nice.

Total portfolio value would be nice too.

Lionel

12-30-2006, 02:06 PM

This has a lot of potentials, congratulations.

zethon

12-30-2006, 02:53 PM

I've uploaded a small update which includes the change of "VALUE" to "VALUES" and also includes a few more instructions about updating the navbar template (this was asked by a couple people).

For anyone who has already installed this add-on, to update, simply upload the vbtrade.php file to your forum's root directory, overwriting the old one. Also, import the product's XML file, setting "Overwrite" to yes.

Lionel

12-30-2006, 03:34 PM

in the function function GetStockTable I did:

$portfolio[] = ($info['shares'] * $shareinfo['lasttrade']);

and before the submit button in main, I did

$tot=array_sum($portfolio);

$stocktable .= "
<tr class='alt$alt'><td colspan=7 align=right>$tot</td><td colspan=3></td></tr>";

Now I get the portfolio value

zethon

12-30-2006, 04:50 PM

in the function function GetStockTable I did:

and before the submit button in main, I did

Now I get the portfolio valueI've added similar code in the update I posted earlier.

UltimateOreo!

12-30-2006, 07:25 PM

I get it now, Im going to install it. Go to phpmyadmin and see the table name that your cash system uses for its money. If you dont have any kind of points system or reputation system, I believe you will have to install one or make one just for this.

leo1977

12-30-2006, 09:03 PM

I am not getting any yahoo feed, just the options to purchase stocks. running 3.6.0 and vbux. Any ideas?

zethon

12-30-2006, 09:25 PM

I am not getting any yahoo feed, just the options to purchase stocks. running 3.6.0 and vbux. Any ideas?Perhaps I worded it badly. You won't get any feed, the pluging pings Yahoo when it needs to get stock info. What you're seeing is the plugin (look in the screen shots).

leo1977

12-30-2006, 09:33 PM

So if I undertand right, It will ping yahoo after a while and I will get the info?

This is what I have now (see the attachment)

Thanks

Perhaps I worded it badly. You won't get any feed, the pluging pings Yahoo when it needs to get stock info. What you're seeing is the plugin (look in the screen shots).

zethon

12-30-2006, 09:37 PM

So if I undertand right, It will ping yahoo after a while and I will get the info?

This is what I have now (see the attachment)

ThanksGo ahead and purchase stock. There's no way in this plugin to look up stock symbols or get quotes. You have to know the stock symbol ahead of time by using finance.google.com or something like it.

I'm going to look into adding an AJAX interface for looking up stock info though.

leo1977

12-30-2006, 09:59 PM

From screenshot 2 I was under the impression that it's already in this mod. So how would a user know what to put in the fields? Adding an Ajax would be great

Magz

12-30-2006, 10:54 PM

zethon

12-30-2006, 11:09 PM

Great looking mod,

I am always on the lookout for giving my users extra features on my boards, but a quick question. I have a UK based site, what would be involved in making the mod UK ccompatible, ie in ?'s and buying stocks from The UK as opposed to US?

regardsAFAIK the Yahoo feed only supports USD. In the mod you can set an "exchange rate" that specifies how many of your board's points equal 1 USD. Perhaps you could use that somehow.

Lionel

12-31-2006, 01:40 AM

Are you planning to do a vbadvanced module, besides the ticker?

Oddjob

12-31-2006, 02:39 AM

Well, it seems to work flawlessly with vbbux.

Awesome mod, looking forward to the next version.

Would like to see something in the postbit legacy where you can see what stocks people have......

zethon

12-31-2006, 02:47 AM

I just posted an update which implements an AJAX interface to look up stock information. This does not allow you to search for stock symbols, you must know the symbol ahead of time.

There's one extra file that needs to be uploaded in this update.

Carl Anderson

12-31-2006, 06:47 AM

cd1986

12-31-2006, 07:41 PM

This looks great and I think I will install it. I do have a suggestion! Make it so you can have investing contests - issue so many bucks in a portfolio that has a start and end date? Nice job thx a bunch!
I second that suggestion! :D

Looks like the beginnings of a potentially great hack! *clicks installed*

EDIT: as i haven't actually installed yet, can i ask whether this mod allows daytrading via the yahoo feeds? Since they are 15 minutes delayed, it isn't too hard to know the future of the stockmarket as it were. If using yahoo, having it use end of day quotes only would avoid this problem (or paying for a more upto date feed for daytrading).

zethon

12-31-2006, 08:37 PM

I second that suggestion! :D

Looks like the beginnings of a potentially great hack! *clicks installed*

EDIT: as i haven't actually installed yet, can i ask whether this mod allows daytrading via the yahoo feeds? Since they are 15 minutes delayed, it isn't too hard to know the future of the stockmarket as it were. If using yahoo, having it use end of day quotes only would avoid this problem (or paying for a more upto date feed for daytrading).I never thought of that. I will implement an option allowing you to use the most recent update from Yahoo or the previous day's end of day quote.

Lionel

12-31-2006, 09:50 PM

Lionel

01-01-2007, 06:03 AM

I get a javascript error with the ajax on IE

The Ottoman

01-01-2007, 05:24 PM

What if I don't want to use "real" stocks, and want to make up generic stock symbols that are specific to my site?

zethon

01-01-2007, 08:04 PM

One thing I also found out, if you have some stocks, then purchase some more of the same, it will not display the unique name of the share with the combined totals. Rather it will treat each entry of the same as a different entry and gives an impression of duplicates, triplicates etc... If it can't be combined then perhaps a transaction date would be handy in there.The only stock purchases that get combined are those that have the same "purchase price". If you buy 100 shares of MSFT at $10, and then another 100 shares at $15, each group of shares will show up as two listings in the stock table.

I get a javascript error with the ajax on IEI only tested this under Firefox. I will look at this later.

What if I don't want to use "real" stocks, and want to make up generic stock symbols that are specific to my site?Sounds like you want an entirely different plugin then.

Lionel

01-01-2007, 08:16 PM

The only stock purchases that get combined are those that have the same "purchase price". If you buy 100 shares of MSFT at $10, and then another 100 shares at $15, each group of shares will show up as two listings in the stock table.

That is not the case. I made those transactions at market close which means they have the same purchase price. They are however behaving as separate transactions instead of having been combined.

Lionel

01-01-2007, 08:23 PM

here is a screenshot of the double MSFT with same purchase price.
Anyway, I still think a transaction date is important, for later sophisticated reporting.

zethon

01-02-2007, 12:09 AM

here is a screenshot of the double MSFT with same purchase price.
Anyway, I still think a transaction date is important, for later sophisticated reporting.Hmm.. this looks like a bug. Did you buy both sets of stocks after the market had closed?

Lionel

01-02-2007, 12:17 AM

Hmm.. this looks like a bug. Did you buy both sets of stocks after the market had closed?

Yes I did

zethon

01-02-2007, 01:36 AM

I get a javascript error with the ajax on IE

I have fixed this bug and the duplicate entry bug in this last update (0.9.2). Upgrade as normal.

Lionel

01-02-2007, 01:50 AM

hummm, did you upload it? Nothing has changed with what I just downloaded

Oddjob

01-02-2007, 03:08 AM

Error in upgrading to the lastest update...

XML Error: not well-formed (invalid token) at Line 2

zethon

01-02-2007, 12:12 PM

Ok, please try again. Looks like I had an error in the product's XML file which was causing a problem with upgrading. This should be fixed now.

Lionel

01-02-2007, 04:30 PM

The javascript error in IE is gone, but we still have double for identical value stocks

Lionel

01-02-2007, 06:17 PM

Today is january 2 2007 all quotes read from the ajax display 12/29/2006 or 11/30

Harley77

01-02-2007, 07:19 PM

That doesn't seem to be an indication of something wrong with the addon, as google finance and yahoo finance are all showing the same exact thing (12/29) as the last trading date.

Lionel

01-02-2007, 09:46 PM

you are right, market was closed today for president Ford

d8tabyte

01-03-2007, 05:49 AM

Hmm the lookup field does nothing for me. I put in a stock symbol like GOOG and click search and it does nothing.

darkilla2

01-03-2007, 05:55 AM

is this 3.6.4 safe yet? Just would like to have a 3.6.4 safe version

thanxs great mod btw

Harley77

01-03-2007, 01:13 PM

Everything has updated exactly as it should. Excellent hack. I can't wait to see this expanded with multi-user options such as viewing others portfolio and VBA CMPS blocks.

Nominated for MOTM.

Magz

01-03-2007, 02:04 PM

is this 3.6.4 safe yet? Just would like to have a 3.6.4 safe version

Running on 3.6.4 with no issues here

zethon

01-03-2007, 02:17 PM

Hmm the lookup field does nothing for me. I put in a stock symbol like GOOG and click search and it does nothing.Are you using the latest code? Have you tried in multiple browsers? Could you PM me an URL to your board and I can take a look...

xxxsaint

01-03-2007, 03:53 PM

Awesome Hack Man!

However , the " who's online " page shows " unknown location when someone is trading on my forum

trustful88

01-03-2007, 10:17 PM

This would be excellent if we could make a portfolio for our own stock. Could that be implemented?

zethon

01-04-2007, 06:52 PM

This would be excellent if we could make a portfolio for our own stock. Could that be implemented?What do you mean? You can already create your own portfolio. That's the point of the add-on.

d8tabyte

01-04-2007, 07:40 PM

I found out from zethon the ajax in my search wouldn't work because I am on 3.5 ( the rest of the hack works fine) Is there anyone willing to take a look and make the changes in the search needed to make this work on 3.5?

Oddjob

01-04-2007, 09:27 PM

This is such an incredible hack, my users love it.

Thanks so much for this, cant wait for a new release with some of the already mentioned suggestions.

Carl Anderson

01-05-2007, 07:31 AM

zethon

01-05-2007, 01:50 PM

Fatal error: Field money is not defined in $validfields in class vb_datamanager_user in /includes/class_dm.php on line 485

I am using icash and it shows I have 100,000 on hand to buy? I can enter it all but when I click to buy I get that error...are you sure you've configured this pluigin properly? it sounds like your "money row" may not be accurate.

Carl Anderson

01-05-2007, 03:37 PM

are you sure you've configured this pluigin properly? it sounds like your "money row" may not be accurate.

Well I left a post in the icash support thread and I am asking the author of icash what to do?

Thx

This is a great hack, and I sure want to use it and I don't want to use vbux!

Carl Anderson

01-05-2007, 07:00 PM

are you sure you've configured this pluigin properly? it sounds like your "money row" may not be accurate.

Ok what the icash author posted in reply to this is this........

You need to find out the column your stock mod uses in the user table and edit the settings in the admincp

Below is the setting in icash that I think he is talking about.. What do I put in here? Or will icash even work with this?

options icash "Money row"
What the money row is in your user table, this can be used for easy integration amongst your favorite hacks! (default is money)

zethon

01-05-2007, 07:25 PM

Ok what the icash author posted in reply to this is this........

You need to find out the column your stock mod uses in the user table and edit the settings in the admincp

Below is the setting in icash that I think he is talking about.. What do I put in here? Or will icash even work with this?

options icash "Money row"
What the money row is in your user table, this can be used for easy integration amongst your favorite hacks! (default is money)Yes, so you want to set the "Money Row" setting in the Stock plugin to the row that iCash uses. It sounds like that value is "money"

zethon

01-05-2007, 07:29 PM

Please note that there is a problem in the plugin when you change the Exchange Rate setting of the plugin. I will look into this tonight and hopefully have a fix up in a few hours.

Carl Anderson

01-05-2007, 08:26 PM

Yes, so you want to set the "Money Row" setting in the Stock plugin to the row that iCash uses. It sounds like that value is "money"

Ok I went and uninstalled and reinstalled icash and stock trader and icash is using money as its "Money Row"... when I go to stock trader it shows the 100,000 I have on hand. I have it set to money and the trader plugin sees it but when I go to purchase after previewing I get this error...

Fatal error: Field money is not defined in $validfields in class vb_datamanager_user in /includes/class_dm.php on line 485

It looks to me that it money is not included as something that can be altered by stock trader?

It shows up in your stock trader...?

Thx

pds

01-06-2007, 12:05 AM

This looks great and I think I will install it. I do have a suggestion! Make it so you can have investing contests - issue so many bucks in a portfolio that has a start and end date? Nice job thx a bunch!

I agree, this would be a great addition to a hack that has very cool potential. It would also be nice if there was a page where you could show "The Top XX Portfoilios", or view others portfolios.

d8tabyte

01-06-2007, 04:01 AM

A way to showcase the richest portfolios would be great too

JustinBr

01-06-2007, 05:47 AM

If I install this mod and and then later update to later versions, will my users have to start over with their portfolio?

zethon

01-06-2007, 01:45 PM

If I install this mod and and then later update to later versions, will my users have to start over with their portfolio?No, they will not.

Carl Anderson

01-06-2007, 03:56 PM

zethon

01-06-2007, 05:45 PM

Would be nice if this had its own money system I can't seem to get icash to work with it... a simple way to just give money to users as it is I won't use this... can't seem to get it to work.

Nice hack though...I think giving this hack its own money system kinda defeats the purpose of the hack. It's not a money-system hack, it's a hack to use money systems.

And from reading the iCash documentation, it looks like this should work just fine. All you have to do is set the "Money Row" option in this hack's settings to "money" (which is the row that iCash uses).

Carl Anderson

01-06-2007, 09:28 PM

I think giving this hack its own money system kinda defeats the purpose of the hack. It's not a money-system hack, it's a hack to use money systems.

And from reading the iCash documentation, it looks like this should work just fine. All you have to do is set the "Money Row" option in this hack's settings to "money" (which is the row that iCash uses).

I will say this one more time and hope this makes sense....

I set the money row to money in stock trader - this is how I can tell for sure that I am doing that right. If i set it to anything else but money it does not show up in "cash on hand" in your stock trader - so I am setting it right! what I and my users get is this error when we go to purchase stocks..

Fatal error: Field money is not defined in $validfields in class vb_datamanager_user in /includes/class_dm.php on line 485

I have set it to money from the start and I keep getting told to set it to money?

My suggestion to be able to just add the amount from your hack and not have to install a money system too I think is a good one. I looked at vbux and it adds all kinds of extra crap that I don't want. So I attempted using icash as it looked simple and it is not working.... does anyone have this working using icash? Are there other choices than vbux that are simple like icash and do not add other things?

zethon

01-07-2007, 01:39 AM

I will say this one more time and hope this makes sense....

I set the money row to money in stock trader - this is how I can tell for sure that I am doing that right. If i set it to anything else but money it does not show up in "cash on hand" in your stock trader - so I am setting it right! what I and my users get is this error when we go to purchase stocks..

Fatal error: Field money is not defined in $validfields in class vb_datamanager_user in /includes/class_dm.php on line 485

I have set it to money from the start and I keep getting told to set it to money?

I would have to look at your board to see what the problem is, but it sounds to me like you're still misconfigured. Especially since other people are having no problems like yours.

The error you're seeing is what happens when vBulletin or a plugin try to set a value to a field in a data object that doesn't exist. In other words, the money field that the plugin is using DOES NOT EXIST. This is not an error in the plugin, but a misconfiguration. If you want to IM me and have me take a look at your board, I'll be more than happy to do so.

My suggestion to be able to just add the amount from your hack and not have to install a money system too I think is a good one. I looked at vbux and it adds all kinds of extra crap that I don't want. So I attempted using icash as it looked simple and it is not working.... does anyone have this working using icash? Are there other choices than vbux that are simple like icash and do not add other things?You can do what I do on my board and use reputation, which doesn't require any money addon of any kind since it's built into vBulletin.

Carl Anderson

01-07-2007, 06:05 AM

Well I just installed vbbux and your hack works with that? So the author of icash or your stock trader hack are not compatible or I may have a hack or something that conflicts with your two hacks installed..

Hope someone else gives icash a try and then we know if it is my setup or a conflict between your hacks..

Nice job by the way and Thx

I will use this now that it works with vbux - I just hate all the additional suff that comes with that money system...

kcmandava

01-07-2007, 10:35 AM

Will install soon. Might wait for the beta to finish.

DannyMilner

01-07-2007, 10:48 AM

Good idea, I really like it! Nice work

zethon

01-07-2007, 02:37 PM

Well I just installed vbbux and your hack works with that? So the author of icash or your stock trader hack are not compatible or I may have a hack or something that conflicts with your two hacks installed..I'm really curious to know what the problem is now. Hmm.. when I have some time I'll set up a test board and install iCash to see if I can figure out the problem.

zethon

01-07-2007, 02:45 PM

TwinsForMe

01-07-2007, 03:10 PM

I'm running 3.6.4, with the most recent version of ICash (3.6 compatible) and I am getting the same error when trying to make a purchase. My money is defined as money, as per instructions.

Fatal error: Field money is not defined in $validfields in class vb_datamanager_user in /includes/class_dm.php on line 485

I use a prefix on my table. Could that be the error?

Blaine0002

01-07-2007, 03:25 PM

Wait a minute, I just noticed that iCash is written for vBulletin 3.5.X. This Stock Trader plugin is written for 3.6.X.

Carl, are you running 3.5.X? If so, that's probably why you couldn't get this plugin to work with iCash.

ICash works for 3.6.X, but if your modification is not backwards compatable with 3.5.X that would probably be the problem :-/

Blaine0002

01-07-2007, 03:38 PM

TwinsForMe

01-07-2007, 03:42 PM

That new file did the trick.

Thanks. :)

Carl Anderson

01-07-2007, 04:37 PM

ICash works for 3.6.X, but if your modification is not backwards compatable with 3.5.X that would probably be the problem :-/

Hi I am using the latest 3.6.4? It looks like you found a fix for it.....

Blaine0002

01-07-2007, 04:39 PM

Hi I am using the latest 3.6.4?

Did you preform the edit i posted above?

Lionel

01-07-2007, 05:06 PM

a member discovered a major bug.

Try purchasing some stocks and for amount of shares put in -500 (negative). That will increase your points amount. In one case, the guy who had 2900 points ended with 10 billions!!!!!!

TwinsForMe

01-07-2007, 06:23 PM

I also added this ticker:

http://www.tufat.com/s_led_ticker_applets.htm

Carl Anderson

01-07-2007, 06:28 PM

Did you preform the edit i posted above?

No I will use vbux now that I have started a investment contest and gave them all vbux.. When this contest is over I will uninstall vbux and use icash..

a member discovered a major bug.

Try purchasing some stocks and for amount of shares put in -500 (negative). That will increase your points amount. In one case, the guy who had 2900 points ended with 10 billions!!!!!!

This needs to get fixed right away IMO

Blaine0002

01-07-2007, 10:06 PM

try this, i simply added a check where each preview was and it puts an error if the stocks entered was less than 1

Lionel

01-07-2007, 10:40 PM

try this, i simply added a check where each preview was and it puts an error if the stocks entered was less than 1

was that the only change?

if ($shares < 1){
eval(standard_error(fetch_error('invalid_shares')) );
}

Blaine0002

01-07-2007, 11:25 PM

no i also stuck one in there when you sell stocks, OH! and i also added the phrase to the XML file.

Tulsa

01-07-2007, 11:30 PM

try this, i simply added a check where each preview was and it puts an error if the stocks entered was less than 1

I hope you only intended us to upload the vbtrader.php file, as that is what I did and entered a negative amount and it trapped the error! :cool:

Blaine0002

01-07-2007, 11:36 PM

glad it worked for you! :D

Lionel

01-07-2007, 11:37 PM

no i also stuck one in there when you sell stocks, OH! and i also added the phrase to the XML file.

All fixed. Thanks for that. Now, if someone could do a vbadvanced module that will

1-display the major indice to all

2-a register to play message

3-click here to play for registered non participant

4-A list of participant stocks (5 or more) plus a link to their full portfolio.

That will be super cool

zethon

01-08-2007, 01:48 AM

Try this... Open vbtrade.php
find:
$userdata =& datamanager_init('user', $vbulletin, ERRTYPE_STANDARD);
$userdata->set_existing($vbulletin->userinfo);
$userdata->set($moneyrow,($vbulletin->userinfo[$moneyrow] + $total_offer));
$userdata->save();

Replace with:
$db->query("update " . TABLE_PREFIX . "user set {$vbulletin->options['vbst_moneyrow']}={$vbulletin->options['vbst_moneyrow']}+'{$total_offer}' where userid='{$vbulletin->userinfo['userid']}'");

find:
$userdata =& datamanager_init('user', $vbulletin, ERRTYPE_STANDARD);
$userdata->set_existing($vbulletin->userinfo);
$userdata->set($moneyrow,($vbulletin->userinfo[$moneyrow] - $totalcost_fc));
$userdata->save();
Replace with:
$db->query("update " . TABLE_PREFIX . "user set {$vbulletin->options['vbst_moneyrow']}={$vbulletin->options['vbst_moneyrow']}-'{$totalcost_fc}' where userid='{$vbulletin->userinfo['userid']}'");

Hope this works for you..

I wonder why using the User DataManager object broke it. I will go ahead and use the SQL queries instead since that seems to fix this plguin with iCash.

a member discovered a major bug.

Try purchasing some stocks and for amount of shares put in -500 (negative). That will increase your points amount. In one case, the guy who had 2900 points ended with 10 billions!!!!!!Good catch! I will implement the fix that Blaine posted.

zethon

01-08-2007, 02:13 AM

All updates have been added to the distribution, and I've bumped up the version number.

Thanks to Blaine0002 for finding the fix to get this to work with iCash!

Blaine0002

01-08-2007, 02:44 AM

glad to help!

TomJames

01-08-2007, 03:40 AM

This is awesome! Great work
*clicks install*

Carl Anderson

01-09-2007, 12:29 PM

Great hack and I got it working fine using vbux at last.. I had already started a contest using vbux and when it is over I will uninstall it and switch to icash...

Here is your list of future features..

Future Features

stock ticker marquee for users
statistics page (most popular stocks, best performers, etc.)
trade stocks with other board users
view other users' portfoliosMy suggestion is to not have a trade stocks with other users as there is no need to do so - just sell them.

I would like you to consider a top ten list of % gained. Or most money in portfiolio? Something to see to compare and have contests on...

Also a stocks sold (or history) whatever you want to name it so you can view the winners and losers in your portfolio. Maybe at the time of sale it just moves them into another table for storage that can be brought up by a history or sold link?

This hack is great and I love it as people can learn to trade stocks and I run an investing site so I am a bit biased..

Voted it hack of the month.........

Thank you so much!

zethon

01-09-2007, 05:44 PM

A few people on my board requested the plugin charge a capital gains tax, instead of a commissions for selling stock. I implemented this as another setting in the add-on's setting page.

Upgrade as normal

soletrader

01-09-2007, 05:56 PM

Is there anyway you can create a virtual money system for this hack?

Quantnet

01-10-2007, 02:25 AM

Is stock the only underlying asset in this mod ? Can we trade options, futures, forward contracts, etc ?

Thanks

zethon

01-10-2007, 02:48 AM

Is stock the only underlying asset in this mod ? Can we trade options, futures, forward contracts, etc ?

ThanksI'm not much a finance person at all, I only know the basics about stocks and the stockmarket. To answer your question I will say that anything for which you can get a quote from Yahoo's web-service, you can trade.

You can find out more about the service the plugin uses here: http://www.gummy-stuff.org/Yahoo-data.htm

Quantnet

01-10-2007, 04:49 AM

i just installed this and it works as far as I can see. I did the template edit where i add the Stock Trader link on navbar. Where I click this, it just links to User CP, but i have to link directly to vbtrade.php to do the trading.

What is the purpose of Stock Trader navbar ?

Lionel

01-10-2007, 01:50 PM

after last update it no longer deduct the points after purchase

mattswanson

01-10-2007, 08:07 PM

Ok, here is a question you probably haven't heard before. I run a board for a news site. We have a business publication that runs a contest where readers build hypothetical stock portfolio and they compete against a chimp. Pretty much the finance version of the classic Out Pick... sports contest. Would this system allow for the ability for users to set up their own portfolios, but have them visible to the overall group in some sort of comparative table as well as the ability for the public to view the portfolio distributions? Or is everything pretty well privatized?

Just wondering.

xxxsaint

01-10-2007, 09:24 PM

Is there any way to just have it display your total portfolio value in your postbit ??

Quantnet

01-10-2007, 09:27 PM

Is there any way to just have it display your total portfolio value in your postbit ??

Second that. Instead of reputation display, can we put the portfolio value there ?

keithsan

01-11-2007, 01:49 AM

Installed and clicked

I'm using user reputations which was off. now its on and thats how we're purchasing.

Before I tell my users about it. Is this portfolio private. Ie. no one can see what you bought, its value, etc...???

Was hoping we could check each others portfolios out or at least values.

good hack!

keithsan

01-11-2007, 02:15 AM

whoops second question.

I'm trying to use reputation as my money system. but its not working. (reputations are on)

I'm trying to find the "user tabel" point system you reffered to but in my admin cp under users. there is no money or point section?? probably something dumb i'm missing here.

xxxsaint

01-11-2007, 02:18 AM

keithsan

01-11-2007, 02:20 AM

https://vborg.vbsupport.ru/attachment.php?attachmentid=58238&d=1167441300

does yours look like this ^

exactly!

keithsan

01-11-2007, 02:29 AM

could be my error in that i just turned on user reps for the board and jacked up the minimum balance. will check it out later..

Carl Anderson

01-11-2007, 11:51 AM

One other option I would like to make this more realistic...

Have a setting on how long you must hold a stock before you can sell it!

A setting on how long after you sell a stock the money from the sell becomes available.

Without this my users are able to buy like say and Oil or Gold stock before the open when they see the market has been up overseas and then sell it and do the same thing the next morning.

On my real brokerage account I can't sell a stock I just bought that quick because it takes three days to clear and they don't like me selling what I don't really have yet..

So a setting on how long you must hold it would encourage investing instead of just buying anything. Plus you could set it for like 30 days and then people would need to pick their stocks more carefully because if the sell their money is not available for so many days to buy again...

darkilla2

01-12-2007, 07:41 AM

Doesnt work It redirects me to my usercp?!

xxxsaint

01-12-2007, 11:11 AM

Doesnt work It redirects me to my usercp?!

Make your own link to point to vbtrade.php , someone's already asked about the template edit , we're still waiting on a response.

Lionel

01-12-2007, 01:15 PM

Things got messed up after last update. It does not deduct points after purchase and does not add after selling.

zethon

01-12-2007, 02:42 PM

Make your own link to point to vbtrade.php , someone's already asked about the template edit , we're still waiting on a response.You can edit whichever template you want to put the link in. Just make sure the link points to the vbtrade.php file on your server.

Things got messed up after last update. It does not deduct points after purchase and does not add after selling.I am not seeing this problem and so far you're the only one reporting it. If you want to send me a PM with the URL to your board, I can take a look and see if I can figure out what is wrong.

xxxsaint

01-12-2007, 08:18 PM

You can edit whichever template you want to put the link in. Just make sure the link points to the vbtrade.php file on your server.

Cool , I was talking about this though :

(OPTIONAL)
* in AdminCP open the "navbar" template
* find:
<td class="vbmenu_control"><a href="usercp.php$session[sessionurl_q]">$vbphrase[user_cp]</a></td>
* below it add:
<td class="vbmenu_control"><a href="usercp.php$session[sessionurl_q]">$vbphrase[ambst_title]</a></td>

Is there any way to get this mod to post your total portfolio value into your postbit ?

zethon

01-13-2007, 03:53 AM

Cool , I was talking about this though :

(OPTIONAL)
* in AdminCP open the "navbar" template
* find:
<td class="vbmenu_control"><a href="usercp.php$session[sessionurl_q]">$vbphrase[user_cp]</a></td>
* below it add:
<td class="vbmenu_control"><a href="usercp.php$session[sessionurl_q]">$vbphrase[ambst_title]</a></td>

Is there any way to get this mod to post your total portfolio value into your postbit ?Not right now.

zethon

01-14-2007, 03:21 PM

By request, I have added a statistics page to this add-on,the ability to view other user's portfolios, and variables which can be added into the postbit. Upgrade as normal.

Lionel

01-14-2007, 04:23 PM

At what point does it insert those values ambportval, ambportgainamt , ambportgainper in table user? Mine are empty even though there are traders.

Lionel

01-14-2007, 04:59 PM

Few bugs. I found the cron, but:

1-one portfolio value is 147,300.700, it displays 130,135.20 in top portfolios
2-In table user I have many values as -9999999.999 in both ambportval and ambportgainamt
3-If you sell all your stocks, the new portfolio value is not updated and it still displays in top portfoloios.

I am not sure I understand the WHERE clause in the cron

$symbols = $vbulletin->db->query_read("SELECT * FROM " . TABLE_PREFIX . "stocktrader WHERE 1 GROUP BY symbol");

zethon

01-14-2007, 07:00 PM

Few bugs. I found the cron, but:

1-one portfolio value is 147,300.700, it displays 130,135.20 in top portfoliosI will look into this if someone else reports a problem. My test board and my main board, the figures are consistent, as they should be when the market is closed.

2-In table user I have many values as -9999999.999 in both ambportval and ambportgainamtSame as above. The default value for the field is 0.

3-If you sell all your stocks, the new portfolio value is not updated and it still displays in top portfoloios.This is how it's suppose to work. THe cron job updates "Top Portfolio's" everyday. So, you won't see any changes immediatly show up in the "Top Portfolios" page.

I am not sure I understand the WHERE clause in the cronAre you talking about the "WHERE 1"? What's there to understand?

zethon

01-14-2007, 07:01 PM

At what point does it insert those values ambportval, ambportgainamt , ambportgainper in table user? Mine are empty even though there are traders.They are updated by the cron, which by default runs every night at midnight.

Lionel

01-14-2007, 07:19 PM

some screenshots

1.-top portfolio
2.-value of same portfolio
3.-strange value in database

Quantnet

01-14-2007, 07:43 PM

By request, I have added a statistics page to this add-on,the ability to view other user's portfolios, and variables which can be added into the postbit. Upgrade as normal.
How do you access the stat page ? How about postbit instruction ? Are these available yet?

d8tabyte

01-14-2007, 07:47 PM

Hmm I uploaded all files, re-imported product and checked options.. when I go to top investors I get a 404.

Ive since upgraded to 3.6.4 and the standard mod works fine... any ideas?

http://digitalet.net/forum/vbtrade.php&do=topportfolios

zethon

01-14-2007, 08:05 PM

zethon

01-14-2007, 08:06 PM

How do you access the stat page ? How about postbit instruction ? Are these available yet?I like to leave that up to the individual user. You can put the "postbit friendly variables" in postbit wherever you want. Same with the link to the stat page.

Quantnet

01-14-2007, 08:15 PM

zethon

01-14-2007, 11:23 PM

Can you give me instructions on how to display top 10 earners in Cyb - Advanced forum Stat mod ? Similar like top 10 posters....

I had Uncached templates: forumdisplay_sortarrow
when trying to reach vbtrade.php?do=topportfoliosI am not familiar with that plugin or what you're trying to do. You may want to ask the author of that mod how to include my data into his stats. :-\

davidw

01-15-2007, 12:00 AM

The proper link should be: vbtrade.php?do=topportfoliosThis link, along with the link in the installation text file, both give me a database error
Database error in vBulletin 3.6.3:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM vb_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown column 'user.userid' in 'field list'
Error Number : 1054
Date : Sunday, January 14th 2007 @ 07:44:55 PM
Script : mywebsite /vbtrade.php?do=topportfolios
Referrer :
IP Address : nope
Username : sorry
Classname : vB_DatabaseI am using MySQL 5.0.20. Playing around with it and removing the user. in the field list and in the WHERE and ORDER BY temporarily issues a fix, but nothing is displayed for users.

Second, I just purchased stocks yet it shows a change - even though no change is displayed. Screenshot for clarification.

Third, just trivial, but why 3 digit decimal places?

xxxsaint

01-15-2007, 01:27 AM

upgraded and running perfectly fine on 3.6.4!

Thanks so much , we all really appreciate your hard work :)

** Noticed though , that we now have commas in place on the amount of stock quantities owned. If you copy and paste your quantity into the " sell " box , it's not reading all of the digits past the 2nd comma, just a heads up , almost sold 7.2 million worth of stock for 7,200 :)

d8tabyte

01-15-2007, 05:23 AM

This link, along with the link in the installation text file, both give me a database error
Database error in vBulletin 3.6.3:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM vb_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown column 'user.userid' in 'field list'
Error Number : 1054
Date : Sunday, January 14th 2007 @ 07:44:55 PM
Script : mywebsite /vbtrade.php?do=topportfolios
Referrer :
IP Address : nope
Username : sorry
Classname : vB_DatabaseI am using MySQL 5.0.20. Playing around with it and removing the user. in the field list and in the WHERE and ORDER BY temporarily issues a fix, but nothing is displayed for users.

Second, I just purchased stocks yet it shows a change - even though no change is displayed. Screenshot for clarification.

Third, just trivial, but why 3 digit decimal places?

Database error in vBulletin 3.6.4:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM vb3_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown table 'user' in field list
Error Number : 1109
Date : Monday, January 15th 2007 @ 01:20:50 AM
Script : http://digitalet.net/forum/vbtrade.php?do=topportfolios
Referrer : http://digitalet.net/forum/vbtrade.php?do=main
IP Address : ....
Username : ...
Classname : vb_database

Yup me too cept I am running PHP Version 4.4.4 and VB 3.6.4

Quantnet

01-15-2007, 05:32 AM

no error here php 4.4.4 and vb 3.6.4

Quantnet

01-15-2007, 06:00 AM

anyone has a working demo of this mod using reputation as cash ? Did anyone got this working in postbit ?

zethon

01-15-2007, 05:06 PM

This link, along with the link in the installation text file, both give me a database error
Database error in vBulletin 3.6.3:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM vb_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown column 'user.userid' in 'field list'
Error Number : 1054
Date : Sunday, January 14th 2007 @ 07:44:55 PM
Script : mywebsite /vbtrade.php?do=topportfolios
Referrer :
IP Address : nope
Username : sorry
Classname : vB_DatabaseI am using MySQL 5.0.20. Playing around with it and removing the user. in the field list and in the WHERE and ORDER BY temporarily issues a fix, but nothing is displayed for users.I wonder, are you using a table prefix? I will have to go through the code and make sure everything is set up properly to work with table prefixes.

Second, I just purchased stocks yet it shows a change - even though no change is displayed. Screenshot for clarification.Yes, that is how it's suppose to work. That change is the market change based on the last trade. Take a look at: http://finance.yahoo.com/q?s=twx

Even though the market is closed today, it still shows a "change". What you want to pay attention to to se how much you've made is the "Gain" and "Gain %" fields.

Third, just trivial, but why 3 digit decimal places?Some of my users trade "penny stocks" where one share might cost .045 cents. WIth only two decimal places, it was impossible to make a profit all these stocks, so I took the mod to 3 decimal places.

zethon

01-15-2007, 05:07 PM

anyone has a working demo of this mod using reputation as cash ? Did anyone got this working in postbit ?You can check out my board. I use reputation as the cash system and I also have the info working in postbit.

Quantnet

01-15-2007, 06:15 PM

I sign up for your board to check out :)

I add this to my postbit_legacy

<span id="repdisplay_$post[postid]_$post[userid]">Portfolio :$post[ambportval] ($post[ambportgainper]%)</span></div>

This is how it shows Portfolio: 101505.000$ (0.039%) this should have been 3.9% but i notice you divide them to decimal.

I notice on your forum you have it shown as Porfolio: 9,323.75 rep
(+ 12%)

How do you add +/- in front of the percentage return. Also, can you add , in the thousand to make 100K become 100,000.000 as the way US uses.

Can we trim 000 after decimal point ? If those 3 decimals are all 0, why should we keep it.

Tulsa

01-15-2007, 06:34 PM

When I load up the top portfolio screen, it's not populated at all. I get a nice header for members, portfolio value, total earning and percentage but nothing else is listed.

Quantnet

01-15-2007, 06:50 PM

davidw

01-15-2007, 07:09 PM

I wonder, are you using a table prefix? I will have to go through the code and make sure everything is set up properly to work with table prefixes.

Yes, that is how it's suppose to work. That change is the market change based on the last trade. Take a look at: http://finance.yahoo.com/q?s=twx

Even though the market is closed today, it still shows a "change". What you want to pay attention to to se how much you've made is the "Gain" and "Gain %" fields.

Some of my users trade "penny stocks" where one share might cost .045 cents. WIth only two decimal places, it was impossible to make a profit all these stocks, so I took the mod to 3 decimal places.

Yes, I am, which the hack does cover to an extent (the query does set up the table prefix to vb_ in the sql error).

zethon

01-15-2007, 08:46 PM

Anyone got a better portfolio.gif ?
my portfolio.gif image is not shown properly. It should have been /forum/images/misc/portfolio.gif but it points to /images/misc/portfolio.gif

To fix this, in vbtrade.php around line 496 change <img src='/images/misc/portfolio.gif' to <img src='images/misc/portfolio.gif'Damn leading slash, I will take care of that. Thanks!

Yes, I am, which the hack does cover to an extent (the query does set up the table prefix to vb_ in the sql error).I've found a couple instances where the table prefix was missing. This will be fixed in an update I'm about to post. Let me know if this fixes your issue.

Quantnet

01-15-2007, 09:06 PM

Thanks for the quick response, zethon

The latest version fixed the amount display problem. Now it displays 100,000.000 instead of 100000.000

Thanks

d8tabyte

01-16-2007, 03:56 AM

Yup me too cept I am running PHP Version 4.4.4 and VB 3.6.4

I am still recieving a DB error with that link.

<td class="vbmenu_option"><a href="vbtrade.php?do=main">$vbphrase[ambst_title]</a></td>
</tr>
<tr>
<td class="vbmenu_option"><a href="vbtrade.php?do=topportfolios">$vbphrase[ambst_topinv]</a></td>

My nav bar code ( I have it included in a drop down )

The page with error
http://digitalet.net/forum/vbtrade.php?do=topportfolios

I have downloaded the latest version, overwrote all and re-imported product with overwrite on.

Database error in vBulletin 3.6.4:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM vb3_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown table 'user' in field list
Error Number : 1109

Tulsa

01-16-2007, 01:01 PM

When I load up the top portfolio screen, it's not populated at all. I get a nice header for members, portfolio value, total earning and percentage but nothing else is listed.

Well it's working now so I guess it needed to run it's cron job first before populating.

davidw

01-16-2007, 02:25 PM

Damn leading slash, I will take care of that. Thanks!

I've found a couple instances where the table prefix was missing. This will be fixed in an update I'm about to post. Let me know if this fixes your issue.
This still doesn't work - everything else works fine - but the portfolio as before.

Quantnet

01-16-2007, 05:13 PM

Magz

01-16-2007, 06:40 PM

Database error in vBulletin 3.6.4:

Invalid SQL:
SELECT user.userid,user.username,user.ambportval, user.ambportgainamt, user.ambportgainper FROM magical_user WHERE (user.ambportval > 0) ORDER BY user.ambportgainamt desc LIMIT 20;;

MySQL Error : Unknown table 'user' in field list
Error Number : 1109I have had no other ussues while following this product, my users love it btw, but following all the updates, i still get the following error when trying to view the portfolios.

regards

Lionel

01-16-2007, 06:46 PM

try adding "AS user"

FROM magical_user AS user

Magz

01-16-2007, 07:15 PM

sorry to sound dense Lionel, but where and how would i implement this? I see no reference to it in the product file.

zethon

01-16-2007, 10:23 PM

How often is the value in postbit updated ?
My topportfolion http://www.quantnet.org/forum/vbtrade.php?do=topportfolios show different values than when you go to the portfolio value http://www.quantnet.org/forum/vbtrade.php?do=viewportfolio&userid=74This is the same value from the Top Portfolios view. It gets updated once a day.

try adding "AS user"

FROM magical_user AS user Ah-ha! You are right. I now see why he was getting that error. I will post a fix shortly. Thanks Lionel.

zethon

01-16-2007, 10:32 PM

The top portfolio view should be fixed now for people using a table prefix.

zethon

01-16-2007, 10:34 PM

How often is the value in postbit updated ?
My topportfolion http://www.quantnet.org/forum/vbtrade.php?do=topportfolios show different values than when you go to the portfolio value http://www.quantnet.org/forum/vbtrade.php?do=viewportfolio&userid=74As I've explained, the top portfolio values are updated once per day. The portfolio view values are real time values.

Quantnet

01-16-2007, 10:39 PM

can you please post your postbit where you display the portfolio value ? thanks

Just notice that the file still shows as 0.9.6

d8tabyte

01-16-2007, 10:58 PM

Works great now, THANK YOU!!!

davidw

01-16-2007, 11:09 PM

that fixed it :)

Lionel

01-16-2007, 11:28 PM

I've been patiently waiting for midnight, I've been running that cron manually, no matter what

1-portfolio value is different from top portfolio and actual portfolio (I just ran cron again) here (http://www.haitiwebs.com/forums/vbtrade.php?do=topportfolios)

2-It only displays one portfolio. There supposed to be 3 of them. The cron is still inserting -999999 for the other ones.

Quantnet

01-16-2007, 11:30 PM

Lionel,
I can't see your top profile page : Invalid action

How do you run cron manually ?

Magz

01-16-2007, 11:31 PM

Woo hoooo,

Thank you, working a treat.

I can now see that my users are smarter investors than me lol.

Keep up the good work

regards

Lionel

01-16-2007, 11:35 PM

Lionel,
I can't see your top profile page : Invalid action

How do you run cron manually ?

try again I just enabled unregistered

to run the cron manually, admincp/scheduled task manager and look for stock trader, then click "run"

Lionel

01-16-2007, 11:45 PM

<a href="http://www.haitiwebs.com/forums/vbtrade.php?do=viewportfolio&userid=6120" target="_blank">here</a> is a portfolio that doesn't display (shows in db as -999999.999) and I just ran cron again

Lionel

01-17-2007, 12:05 AM

Solved my problem: It was due to the table stocktrader where the cheaters had entered negative values (from other problem that had been solved, but negative values remained in table)

Lionel

01-17-2007, 12:13 AM

But one last bug remains. If someone sells all the stocks and pulls out, the cron which should have first empty all columns before re inserting does not. Therefore, someone who is out still carries old values in user table.

Lionel

01-17-2007, 12:17 AM

so what I did, before the foreach loop in the cron I did

$vbulletin->db->query_write("UPDATE user SET ambportval = '', ambportgainamt = '', ambportgainper = '' ");

and all is well

Quantnet

01-17-2007, 12:37 AM

anyone notice the file for download is still 0.9.6 ? not 0.9.7 ? or just that he didn't change the number ?

Lionel, can you upload the file with the fix ?

Lionel

01-17-2007, 02:49 AM

oh well, no one wanted to do it, so I did it. If it's ok with zethon (https://vborg.vbsupport.ru/member.php?u=84798) I'll post my vbadvanced module.

image1 is seen by unregistered
image2 by member without portfolio
image3 by member with portfolio

Quantnet

01-17-2007, 02:58 AM

wow, that's excellent Lionel. Can't wait to get that vbadvanced module.

Lionel

01-17-2007, 03:26 AM

it does look good :-)
All packaged waiting for an ok.

xxxsaint

01-17-2007, 04:18 AM

Very nice how you've got it showing the different market's position on the day , can that be done without vbadvanced ?

Also , how come we can pull up values of mutual funds , but you can't purchase them ??

Lionel

01-17-2007, 04:28 AM

ok, I released it https://vborg.vbsupport.ru/showthread.php?p=1161159

Quantnet

01-17-2007, 05:12 AM

thanks, Lionel. My modules are not populated. You can check out from my site. I posted on your mod thread.

soulface

01-17-2007, 05:32 AM

when going to: /vbtrade.php?do=topportfolios

Page generated in 0.28073 seconds with 20 queries (1 queries for uncached templates) [Server Loads: 0.07 0.09 : 0.08]
Uncached templates: forumdisplay_sortarrow (1)

Lionel

01-17-2007, 05:37 AM

thanks, Lionel. My modules are not populated. You can check out from my site. I posted on your mod thread.

I answered on other thread. I don't want to hijack this thread.

Quantnet

01-17-2007, 05:52 AM

when going to: /vbtrade.php?do=topportfolios
Got the same uncached template error here but nobody else seems to have it.

Lionel

01-17-2007, 06:01 AM

it's there, you need to cache it

Lionel

01-17-2007, 06:04 AM

This is not the proper way to cache templates, but I am too lazy to do the plugin, so in vbtrade.php I did in red

$globaltemplates = array('vbtrade_main','forumdisplay_sortarrow');

Quantnet

01-17-2007, 06:11 AM

This is not the proper way to cache templates, but I am too lazy to do the plugin, so in vbtrade.php I did in red
This is amazing. Thanks so much lionel. Hope to have the proper fix in the next release.

I have added the portfolio value in postbit. It will only get update once a day when the cron job is run. Anyone is doing this more frequently ?

Lionel

01-17-2007, 06:13 AM

You're welcome. If zethon incorporates it, then you good, won't have to do it every update.

NuclioN

01-17-2007, 07:43 AM

vbtrade.php opens only a search option 'Get Stock Quote' without displaying stocks. Only after a search they show the result. Is this how it works or do we have to change something to have an overlook of available stocks?

NFLfbJunkie

01-17-2007, 05:48 PM

I added the code to the navbar but I have no link showing to get to this MOD.

Quantnet

01-17-2007, 07:49 PM

under which condition the amount i give to each member shows up on postbit ? I gave a dozen member 100K to start but only 2 members have the portfolio shown up on postbit even after i manually do the cron job.

Do they have to trade before the portfolio amount got added into the table ?

MorrisMcD

01-17-2007, 11:56 PM

Excellent Hack!

Thanks!

zethon

01-18-2007, 12:21 AM

Cool! My add-on has an add-on! ;)

zethon

01-18-2007, 12:23 AM

I will add this to the code.
$globaltemplates = array('vbtrade_main','forumdisplay_sortarrow');

Thanks for finding the fix!

Carl Anderson

01-18-2007, 12:26 AM

zethon

01-18-2007, 02:03 AM

One thing I want to have is an option of how long a stock must be held before it can be sold.. I want people to think of this as investing and learn from it..

In the real world my broker will not allow me to buy a stock and sell it the same day and then use the funds again to buy the same day.. It takes three days for stocks to clear for me - I use Fidelity brokerage account..I did not know that! That shouldn't be too difficult to set up. I will try to get this in the next update.

Thanks my users love this ............. I plan to have investing contests with this...I'm interested in any input from anyone on how you might like to see some sort of "contest" functionality built into this...

MistaMarkael

01-18-2007, 02:28 AM

should i download this now or wait ?

Quantnet

01-18-2007, 02:35 AM

I'm interested in any input from anyone on how you might like to see some sort of "contest" functionality built into this...

Set a start and end date, give everyone a set amount of cash (i use 100000 in reputation field) and at the end, the winner will be the one that has best gain (not portfolio value because some will sit on cash and risk only fraction of portfolio). The amount invest =100K - cash. See how much profit you make on the invest amount :)

Ideally, the user would see where he is ranked in the contest. The cron job is updated during business hour, some thing like every 2 hours...(4 times a day)

I still try to find a way to put top 10 gainers on forum home.

Lionel

01-18-2007, 10:30 AM

In the real world my broker will not allow me to buy a stock and sell it the same day and then use the funds again to buy the same day.. It takes three days for stocks to clear for me -

This is not the real world. In day trading you can buy and sell within 1 second apart.

Tulsa

01-18-2007, 11:05 AM

This is not the real world. In day trading you can buy and sell within 1 second apart.

If you choose to put a delay into this mod, please give us the option to invoke it or not. I would hate to see such a delay for my site.

Lionel

01-18-2007, 11:15 AM

What would be nice with this hack would be the possibility to buy on margin

MorrisMcD

01-18-2007, 12:22 PM

Potential issue... A user bought a stock that is unlisted in price for some reason.. They got over a million for 0 points a share.. Once that thing starts showing its value, the user can just sell it and make a killing..

Is there a possibility of restricting the buying of stocks valued at 0?

zethon

01-18-2007, 12:43 PM

If you choose to put a delay into this mod, please give us the option to invoke it or not. I would hate to see such a delay for my site.Absolutely. I built this last night, and you can just leave the requirement at "0 days". I'll be posting this update later.

Potential issue... A user bought a stock that is unlisted in price for some reason.. They got over a million for 0 points a share.. Once that thing starts showing its value, the user can just sell it and make a killing..

Is there a possibility of restricting the buying of stocks valued at 0?Wow. I will fix this in the next release.

NFLfbJunkie

01-18-2007, 12:46 PM

I installed this MOD and added the cde to the navbar template so a link will show on my navbar, but nothing shows up. Actually, after adding coding to the navbar to display links for other MODs, I am getting the same problem. Does anyone know if there's something different with editing the navbar in 3.6.4?

MorrisMcD

01-18-2007, 01:09 PM

Wow. I will fix this in the next release.

Good news.. Its still kinda like an exploit, but it doesnt do what I thought it would. Since its dividing the total out to get the percentage before it gives the gain (I think), it fails and I get a division by 0 error....

See attachments below... The error is appearing at the top of the page.

Still would like to see it fixed if possible though :)

While I am at it, can I make a request? What about a history.. Of selling stocks per portfolio?

zethon

01-18-2007, 01:30 PM

Good news.. Its still kinda like an exploit, but it doesnt do what I thought it would. Since its dividing the total out to get the percentage before it gives the gain (I think), it fails and I get a division by 0 error....

See attachments below... The error is appearing at the top of the page.

Still would like to see it fixed if possible though :)

While I am at it, can I make a request? What about a history.. Of selling stocks per portfolio?I just posted an update that has a fix for this. The minimum price a stock can have for a user to purchase defaults to $0.001. However, I've made this configurable in the add-on's options.

I've also added the minimum number of days feature that someone else requested. This too is configurable.

As for a portfolio history... that's not such a simple change and may not happen until a 2.0 version. :)

Carl Anderson

01-18-2007, 01:33 PM

I have a few requests that would be nice....

One would be a personal Portfolio of the real stocks you own. Where you just enter the amount owned and the price you paid so you can keep tabs on your real portfolio - no one can view it and you don't need bux to enter the amounts.

As far as contests go a start and stop date and an initial amount of funds for it that can't be added to. You have to start with everyone having the same amount to invest to make it a fair contest... So say I give everyone 150,000 vbux the contest would only allow 100,000 something we could set... or have the option of no limit?

As far as the navbar I would like to see just Stock Trader that points to vbtrader.php and then when you click on that the links to top performers and if you have "contest" a link to that... My navbar has too much stuff on it already and don't need more.. Just one link in the navbar is enough.

Thx for the great work

NFLfbJunkie

01-18-2007, 01:36 PM

Zethon, what file needs to be uploaded for the changes you just made?

MorrisMcD

01-18-2007, 01:57 PM

I just posted an update that has a fix for this. The minimum price a stock can have for a user to purchase defaults to $0.001. However, I've made this configurable in the add-on's options.

I've also added the minimum number of days feature that someone else requested. This too is configurable.

As for a portfolio history... that's not such a simple change and may not happen until a 2.0 version. :)
Understandable on the history.. Thanks for the quick fix.. Worked for me! My cron job still reports a divide by zero error when run manually so I wonder if its updating.. You think I just need to del anything in the db referring to HOKU?

Zethon, what file needs to be uploaded for the changes you just made?
Just upload the whole upload folder again and reinstall the product with the overwrite option.. Worked for me

Quantnet

01-18-2007, 05:21 PM

i just updated to the latest version and every trade i made yesterday now shown as Purchased a week ago.

Is it because I manually run the cron job ?

MorrisMcD

01-18-2007, 05:33 PM

i just updated to the latest version and every trade i made yesterday now shown as Purchased a week ago.

Is it because I manually run the cron job ?

Weird.. So does mine actually

TTG

01-18-2007, 06:10 PM

Used this in my post bit for members to better understand what they have :-

<strong>Stocks & Shares</strong> <br />
Portfolio Owned: $post[ambportval]<br />
Stocks Gain: $post[ambportgainper]

Quantnet

01-18-2007, 06:14 PM

Used this in my post bit for members to better understand what they have :-
Do you have an option in User CP for those who don't like to list it in their postbit ?

Here is my postbit http://img256.imageshack.us/img256/9072/portfolioqt2.jpg

zethon

01-18-2007, 06:51 PM

i just updated to the latest version and every trade i made yesterday now shown as Purchased a week ago.

Is it because I manually run the cron job ?This is WAD (Works As Designed). The update now keeps track of the date on which you purchased your stock. In order to make things nice for stocks that were purchased with the older version of the software, I set it to automatically set those stocks as being purchased a week prior to the current date.

Quantnet

01-18-2007, 06:56 PM

Another idea for the trading contest: we can set a minumum number of trade members have to exercise during the contest period.

1) Can you allow trading between members?
2) member request: some have been asking if we can include foreign trading exchange like those in India, China, etc...how much works needed for this ?

Lionel

01-18-2007, 08:03 PM

Quantnet

01-18-2007, 08:17 PM

I incorporated a stock market discussions, but it would be nice if you could put it in your script too, so there will not be any need to add it again at every upgrade. I think this is something that everyone might like.;)
Lionel did it again :)
You can select based on forum id, right ? If so we can create a forum dedicated to trading and enable the feature there.

Lionel

01-18-2007, 08:19 PM

I added a setting in the group where you simply put the forum id that you are using for the discussions.

Quantnet

01-18-2007, 09:01 PM

Moya

01-19-2007, 12:42 AM

Oh oh I like this.

Thanks. I will click installed when I get my site back on.

sportsoutlaw

01-19-2007, 01:45 AM

Dabble in the stock market, and not use any of my own real money. I like this. :)

*Installed

Carl Anderson

01-19-2007, 07:35 AM

This is not the real world. In day trading you can buy and sell within 1 second apart.

True but you must have a margin account to do so...

It takes three business days for stocks to settle.... Brokers do not allow you to do this without a margin account - hence day traders have margin accounts.

d8tabyte

01-19-2007, 07:43 AM

Seems like a bug with rounding small gain/loss. When someone has a very small negative gain, the percentage gain should be -0.00%. Also, we need more decimal places instead of only 2

19.00 0.00%
-27.50 0.00%

Another request: when we view member portfolio, is it possible to display the amount of cash not invested of that member along with the portfolio value ?

You can do this with vbplaza/vbux by entering this where ever you want it to appear:

<phrase 1="$vbphrase[vbbux_points]">$vbphrase[vbbux_total_points]</phrase>: $post[totalpoints]

As once stock is bought it deducts from total point anyway, until stocks are sold again.

Carl Anderson

01-19-2007, 08:10 AM

I see no way of having contests that are fair and equal unless this uses its own money system. You need to enter a set amount as your cash starting point. If you don't do this some people may win the contest by making vbux for posts or reputation and buy stocks with it so it shows in their portfolio - whatever?

There are a lot of things that need to be considered for this to end up really good. I bet your head is spinning from all of the suggestions. Personally I want to see the contest part as the primary objective of your hack and add from there. Get that right and then add on some of the other suggestions. Contests will make it fun and get people to use it IMO - lots of people come to sites with games and contests and it keeps them interested to see how they are doing..

I would like to ask the other posters here if they feel the same and contests be the core and build from there?

I am going to send you a small donation for your work and efforts on this... However it turns out you deserve something from me and the users on my site..

Quantnet

01-19-2007, 08:33 AM

You can do this with vbplaza/vbux by entering this where ever you want it to appear:

<phrase 1="$vbphrase[vbbux_points]">$vbphrase[vbbux_total_points]</phrase>: $post[totalpoints]

As once stock is bought it deducts from total point anyway, until stocks are sold again.

I only use reputation as money and I don't see any reason to install another vbux, cash. As far as i can see, giving member 100K reputation is as good as 100K in cash.

xxxsaint

01-19-2007, 10:57 PM

I would like to ask the other posters here if they feel the same and contests be the core and build from there?

I personally do not want this to become a " stock competition " hack. If that does become the case , then notify us on when it becomes a time-set competition only thing so I can stop upgrading at that point. Nothing wrong with fun competitions , but nothing wrong with having a blast just trading stocks as this has been designed to do.

P.S. Please add Mutual Funds , it gives us the quotes from mutual funds , but doesn't let us buy them!

Lionel

01-20-2007, 04:59 AM

I was wondering if you could make this hack handle stocks splits?

d8tabyte

01-20-2007, 07:49 AM

I only use reputation as money and I don't see any reason to install another vbux, cash. As far as i can see, giving member 100K reputation is as good as 100K in cash.

<if condition="$show['reputation']"><div><span>Reputation: $post[reputation]</span></div></if>

Carl Anderson

01-20-2007, 01:19 PM

I personally do not want this to become a " stock competition " hack. If that does become the case , then notify us on when it becomes a time-set competition only thing so I can stop upgrading at that point. Nothing wrong with fun competitions , but nothing wrong with having a blast just trading stocks as this has been designed to do.

P.S. Please add Mutual Funds , it gives us the quotes from mutual funds , but doesn't let us buy them!

I would suspect that most sites will feel the same as you do. At my site most of my users are stock traders for real stocks and many of the posts are already about stocks. So it is important to me that it works right with no way to win in a contest other than picking the best stocks.

I can see how other sites may want to use this along with reps or posts to build up a portfolio and maybe reward users. We all have different sites and different users - I just hope this add on can have the options to fit most of our needs so we can present it the way we want to our users.

Zethon consider this for the contest part of it..

Add a table that can import the money from vbux, icash etc. In the contest set up area place the amount that can be imported into that table for the contest from vbux etc.. This will be your portfolio starting point and you can't add more than what is set in the contest set up. Have a start date for contest and end date and the one with the most bux at the end date is the winner.

You could also set it to so there is no limit for the sites that want their users to be able to use all of their bux they earn in the contest.

This a great add on and all of us have different visions of how we want to present it to our users. My hope is that their will be enough options that we all can set this up to work for our sites in a way that will be best for each site...

Thanks zethon for all your efforts!:up:

adhari_com

01-20-2007, 02:00 PM

how it could be integrated to use the vB Reputation System?

fastforward

01-20-2007, 05:53 PM

how it could be integrated to use the vB Reputation System?
Simply enter 'reputation' in the 'Money Row' field. That's how I've got it set up.

zethon

01-20-2007, 06:36 PM

P.S. Please add Mutual Funds , it gives us the quotes from mutual funds , but doesn't let us buy them!Can you give me an example of a mutual fund that the system gives a quote for but won't let you buy? I'm guessing this will be an easy fix/change.

zethon

01-20-2007, 06:43 PM

I personally do not want this to become a " stock competition " hack. If that does become the case , then notify us on when it becomes a time-set competition only thing so I can stop upgrading at that point. Nothing wrong with fun competitions , but nothing wrong with having a blast just trading stocks as this has been designed to do.Nothing will be compulsory. I'm still working on the competition design in my head, and of course if you don't want to have competitions, you will not be required to do so.

Add a table that can import the money from vbux, icash etc. In the contest set up area place the amount that can be imported into that table for the contest from vbux etc.. This will be your portfolio starting point and you can't add more than what is set in the contest set up. Have a start date for contest and end date and the one with the most bux at the end date is the winner.

You could also set it to so there is no limit for the sites that want their users to be able to use all of their bux they earn in the contest.I'm still not sure how I want to handle the competition aspect of this add-on. I'm thinking there will be two ways the competition will initially start.

1) Users will have to pay to enter the contest. That fee will be the money that they use in the contest. Hence, if I start a contest with a 10,000 dollar/rep/vbbux/whatever fee, then each use that enters the competition will initially start out with 10,000.

2) Users will be able to join a competition for free and will be allocated X amount of dollars/rep/whatever.

I can see advantages and disadvantages to both methods. I may go with one or the other or both, I'm still undecided.

The competition portion of this plugin is still at least another month or two away. Grad school starts next week and with a fulltime job, I'm not sure how much time I'll be able to dedicate to this, aside from bug fixes.

dholt

01-20-2007, 08:24 PM

Installed

Quantnet

01-20-2007, 08:47 PM

zethon,
Thanks for your time. This has been the best mod i have on my forum in term how it fits the userbase.

Beside the 2 phrases that you have (portfolio value and gain), can you develop more phrases.

Something like the rank of a members in term of top portfolio so we can put in postbit. For example $post[rank_gain] will display the rank of that member based on the gain percentage. $post[rank_value] will display the rank of that member based on the value of the portfolio

sportsoutlaw

01-20-2007, 11:31 PM

I can't buy any stock at all. I have cash on hand, but even when I try to buy just 1 share of $30 stock, is says:
You do not have enough money to make this purchase.

What am I doing wrong? :)

sportsoutlaw

01-20-2007, 11:52 PM

I found the issue, I think.......

The cash on hand that I have is 7,120.31

I found a cheap stock that was $4.00 per share, and it will let me buy 1 share. When I try to buy 2 shares, it says I don't have enough money. For some reason, it appears to be reading 7,120.31 as 7.12031.

Any ideas how to fix this?

Edit - I removed vbux/vbplaza tonight and installed icash. This issue doesn't exist with iCash, so my problem is fixed. :)

xxxsaint

01-21-2007, 02:18 AM

Can you give me an example of a mutual fund that the system gives a quote for but won't let you buy? I'm guessing this will be an easy fix/change.

Here ya go :

CHCGX
SAUSX
DXCLX
DXZLX
FSNGX

Those types of funds :) Thanks for looking into it!

Martyh

01-21-2007, 02:25 AM

ok,

I have it installed and got the green bars switched out to show numbers thanks to another thread in mod discussions ( because, I just used the rep system in VB)

, only problem I am having is after a few people have made purchases , they do not show up in the postbit "total portfolio value" they still show zero, and also when I go to the top investors page there is no info there, as if no one is in the game, no memebrs show up under any of the headings.What could I be missing, the install was pretty simple even for a newbie, any ideas ?

please let me know,

Thank you, and thanks for the mod,
it is my personal favorite,

Quantnet

01-21-2007, 03:32 AM

Martyh,

The postbit value and top portfolio will only show after the cron run (at midnight everyday). You need to manually run it. It's under Scheduled task in Admin CP

Martyh

01-21-2007, 04:56 AM

Thank you very much, that was it.

Really appreciate this mod thanks,

MorrisMcD

01-21-2007, 06:29 AM

Just an FYI.. The product is installing the cron to run every minute of the midnight hour.. Rather than every hour on the hour... (I assume thats how you meant it)

I manually updated mine, but when I upgraded it changed it back.. So I assume its the product itself and just a mix up on your end..

Lionel

01-21-2007, 06:39 AM

It should run the cron once a day at midnight, not every hour

MorrisMcD

01-21-2007, 07:04 AM

It should run the cron once a day at midnight, not every hour

I actually changed mine to run once an hour, but now that I think about it, I guess it would make sense to not reveal purchases by users to others during the trading period

But the cron says 00 for the hour and * for the minute.. Doesnt that mean it would run at 12:00am, 12:01am, 12:02am.... etc etc

I could be wrong.. I am no pro.. I just changed it because I figured that is what it was configured to do and that just seemed weird to me

Lionel

01-21-2007, 11:02 AM

i changed mine to 01 for minutes so it runs once at 12:01 AM

Martyh

01-21-2007, 01:15 PM

Hey this is great, I was wondering if it keeps an individual history of a members trades, I think that may be a necessity considering that admins have the ability to change the reputation points for any member, just a thought.

Nevermind: I found out what the chart and magnifying glass was for,..lol

MorrisMcD

01-22-2007, 01:43 PM

There is an exploit of some sorts... One user keeps making huge money every day right when the market opens..

Not sure what he is doing, but today he made 50K on a stock that says he purchase it at 31 today when it says it opened at 36... Not sure how thats possible..

Maybe he really just is that good.. I just dont get what he is doing

See attachments.. Seems like he was able to buy it at the closing price from friday.. Of course.. It opened 5 dollars more than it closed at.... Hopefully someone can figure this out.. Because this hack is awesome.. But this will ruin a lot if you can constantly cheat

Lionel

01-22-2007, 01:51 PM

MorrisMcD

01-22-2007, 02:14 PM

You will have cheating no matter what with the 15 minutes delay and if you have access to the market live.

For the friday deal, it should be easy to incorporate time factor to prevent people from buying during off hours, but I am not sure on how this would help.

So what he did, at market open he simply bought at 9:40 with friday prices since the current price did not kick in yet (starts for us at 9:45). There are reports which show big movers. He probably read them and picked one.

There is a 15 min delay in the pricing? I didnt realize that.. Is it possible to restrict buying to certain hours? Because essentially he bought that stock lower than the opening price for today.. He bought it at friday's closing price.. With a one day min to hold stocks and something to keep them buying only at certain times, things would be secure enough I suppose...