Query Look Right?

[paul41598]

Does this look ok to use? Because its not working. The votenum gets set correctly, but the votetotal does nothing at all.



if ($_REQUEST['do'] == 'removerater')
{
$vbulletin->db->query_write("
UPDATE " . TABLE_PREFIX . "thread
SET votenum = votenum - 1, votetotal = votetotal - '". $rater['vote'] ."'
WHERE threadid = '" . $threadinfo[threadid] . "'
");
}


Some of my other code that reflects this is:


$whorate = $db->query_read("
SELECT thread1.threadid, thread1.votetotal, threadrate.userid, threadrate.vote, user.username
FROM " . TABLE_PREFIX . "threadrate AS threadrate, " . TABLE_PREFIX . "user AS user, " . TABLE_PREFIX . "thread as thread1
WHERE threadrate.threadid = $threadinfo[threadid]
AND thread1.threadid = $threadinfo[threadid]
AND threadrate.userid = user.userid
ORDER BY vote DESC
");

while ($rater = $db->fetch_array($whorate))
{
$candelete = "<a href=\"misc.php?do=removerater&amp;u=$rater[userid]&amp;t=$rater[threadid]&amp;v=$rater[vote]\" onclick=\"removerater$rater[userid](); return false;\"><img src=\"images/misc/delete.gif\" border=\"0\"></a>";
eval('$raters .= "' . fetch_template('whoratebit') . '";');
}

[CyberAlien]

Maybe variable $rater is unset? That's the only thing that I think might be causing problem with that query. Try debugging it with print_r() before sql query.