PHP implode is exploding my mind!!!!!!

[Antivirus]

What i want to do: pull all forum ids having a specific parent forum, and place them in a string ( $newsfeedforumids ) so they can be added to end of external.php lilke this:

$vboptions[bburl]/external.php?type=rss2&forumids=$newsfeedforumids


My query:

// set parent forum id
$parentid = 6;

// get child forumids for parent
$forumids_q = $db->query_read("
SELECT forumid
FROM " . TABLE_PREFIX . "forum
WHERE parentid = $parentid
");
$forumids = mysql_fetch_array($forumids_q);
$newsfeedforumids = implode(",", $forumids);


Then I plug the $newsfeedforumids onto the end of external.php llike so:

<a href="$vboptions[bburl]/external.php?type=rss2&amp;forumids=$newsfeedforumids" target="_blank">Click for Feed</a>


however there's 14 different forum ids supposed to be queried, and all i get attached to the end of the url is the first result as so:
bburl/external.php?type=rss2&amp;forumids=7,7

What am i doing wrong?

[Paul M]

You are misunderstanding what mysql_fetch_array() does. This fetches one row of the result set as an array, not the entire result set. You need a 'while' loop to fetch the results row by row to build your array of forumids.

[Antivirus]

thanks Paul, this worked for me:


$newsfids_q = $db->query_read
("
SELECT forumid FROM " . TABLE_PREFIX . "forum
WHERE (parentid = " . $news_setup['artist_news_parent_forum_id'] . "
OR forumid = " . $news_setup['eclipse_news_forum_id'] . ")
");
while ($newsfid = mysql_fetch_array($newsfids_q))
{
$forumids .= $newsfid['forumid'] . "," ;
}
$newsfeedforumids = $forumids;


would there have been a better way to do it than above?

[Paul M]

would there have been a better way to do it than above?
Not really.

[Antivirus]

cool, thanks again for the help!

[Code Monkey]

thanks Paul, this worked for me:


$newsfids_q = $db->query_read
("
SELECT forumid FROM " . TABLE_PREFIX . "forum
WHERE (parentid = " . $news_setup['artist_news_parent_forum_id'] . "
OR forumid = " . $news_setup['eclipse_news_forum_id'] . ")
");
while ($newsfid = mysql_fetch_array($newsfids_q))
{
$forumids .= $newsfid['forumid'] . "," ;
}
$newsfeedforumids = $forumids;

would there have been a better way to do it than above?

Yes there would be if you want to be fully integrated. Use vBulletins $db->fetch_array. ;)


$newsfids_q = $db->query_read
("
SELECT forumid FROM " . TABLE_PREFIX . "forum
WHERE (parentid = " . $news_setup['artist_news_parent_forum_id'] . "
OR forumid = " . $news_setup['eclipse_news_forum_id'] . ")
");
while ($newsfid = $db->fetch_array($newsfids_q))
{
$forumids .= $newsfid['forumid'] . "," ;
}
$newsfeedforumids = $forumids;

[Antivirus]

good point Codemonkey, thanks!