creating a rss feed form site.... help!

[DrewM]

Well I'm trying to make a xml/ rss2 feed for my users it works but it just displays text this is my code:
<?php

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NOSHUTDOWNFUNC', 1);
define('SKIP_SESSIONCREATE', 1);
define('DIE_QUIETLY', 1);
define('THIS_SCRIPT', 'external');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
// get special phrase groups
$phrasegroups = array();

// get special data templates from the datastore
$specialtemplates = array();

// pre-cache templates used by all actions
$globaltemplates = array();

// pre-cache templates used by specific actions
$actiontemplates = array();

// ######################### REQUIRE BACK-END ############################
chdir('/home/rdsx667/public_html/forum/');
require_once('./global.php');

// ################################################## #####################
// ######################## START MAIN SCRIPT ############################
// ################################################## #####################

$threads = $db->query_read("select * from " . TABLE_PREFIX . "site_news ");


header('Content-Type: text/xml');
header('Expires: ' . gmdate('D, d M Y H:i:s') . ' GMT');
header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
header('Pragma: public');

echo '<?xml version="1.0" encoding="' . $stylevar['charset'] . '"?>' . "\r\n\r\n";

# Each specs shared code is entered in full (duplicated) to make it easier to read
echo "<rss version=\"2.0\">\r\n";
echo "<channel>\r\n";
echo "\t
<title>RSS Feeds From Sim 2 World</title>
\r\n";
echo "\t<link>" . $vbulletin->options['homeurl'] . "</link>\r\n";
echo "\t<description><![CDATA[" . htmlspecialchars_uni($vbulletin->options['description']) . "]]></description>\r\n";
echo "\t<language>$stylevar[languagecode]</language>\r\n";
echo "\t<pubDate>" . gmdate('D, d M Y H:i:s', TIMENOW) . " GMT</pubDate>\r\n";
echo "\t<generator>Sim 2 World</generator>\r\n";
echo "\t<ttl>60</ttl>\r\n";
// }

$i = 0;

// list returned threads
while ($thread = $db->fetch_array($threads)) {
echo "\r\n\t<item>\r\n";
echo "\t\t<title>$thread[newstitle]</title>\r\n";
echo "\t\t<link>" . $vbulletin->options['homeurl'] . "?news_id=$thread[newsid]</link>\r\n";
echo "\t\t<pubDate>" . $thread['date'] . " </pubDate>\r\n";
echo "\t\t<description><![CDATA[". $thread['newsartcle'] ."]]></description>\r\n";

# this bit is obtuse
echo "\t\t<author><![CDATA[(" . $thread['newsauthor'] . ")]]></author>\r\n";
echo "\t\t<guid isPermaLink=\"false\">" . $vbulletin->options['homeurl'] . "?news_id=$thread[newsid]</guid>\r\n";
echo "\t</item>\r\n";




echo "</channel>\r\n";
echo "</rss>";
}

?>

[Code Monkey]

Without really looking over the code yet.



Cut the tabs bit. You need to code it flush to the left. xml will indent itself when read in a reader, but it can't process those tabs.


You have


echo "</channel>\r\n";
echo "</rss>";

In the loop. It needs to be outside the loop.

Try this.


<?php

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('SESSION_BYPASS', 1);
define('LOCATION_BYPASS', 1);
define('DIE_QUIETLY', 1);
define('THIS_SCRIPT', 'external');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
// get special phrase groups
$phrasegroups = array();

// get special data templates from the datastore
$specialtemplates = array();

// pre-cache templates used by all actions
$globaltemplates = array();

// pre-cache templates used by specific actions
$actiontemplates = array();

// ######################### REQUIRE BACK-END ############################
define('DIR', dirname(dirname(__FILE__))); //how many dirname calls depends on location of file.
chdir(DIR);
require_once DIR . '/global.php';

// ################################################## #####################
// ######################## START MAIN SCRIPT ############################
// ################################################## #####################

$threads = $db->query_read("select * from " . TABLE_PREFIX . "site_news ");

header('Content-Type: text/xml');
header('Expires: ' . gmdate('D, d M Y H:i:s') . ' GMT');
header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
header('Pragma: public');

$output = '<?xml version="1.0" encoding="' . $stylevar['charset'] . '"?>' . "\r\n";

# Each specs shared code is entered in full (duplicated) to make it easier to read
$output .= "<rss version=\"2.0\">\r\n";
$output .= "<channel>\r\n";
$output .= "<title>RSS Feeds From Sim 2 World</title>\r\n";
$output .= "<link>" . $vbulletin->options['homeurl'] . "</link>\r\n";
$output .= "<description><![CDATA[" . htmlspecialchars_uni($vbulletin->options['description']) . "]]></description>\r\n";
$output .= "<language>$stylevar[languagecode]</language>\r\n";
$output .= "<pubDate>" . gmdate('D, d M Y H:i:s', TIMENOW) . " GMT</pubDate>\r\n";
$output .= "<generator>Sim 2 World</generator>\r\n";
$output .= "<ttl>60</ttl>\r\n";
// list returned threads
while ($thread = $db->fetch_array($threads))
{
$output .= "<item>\r\n";
$output .= "<title>$thread[newstitle]</title>\r\n";
$output .= "<link>" . $vbulletin->options['homeurl'] . "?news_id=$thread[newsid]</link>\r\n";
$output .= "<pubDate>" . $thread['date'] . " </pubDate>\r\n";
$output .= "<description><![CDATA[". $thread['newsartcle'] ."]]></description>\r\n";
# this bit is obtuse
$output .= "<author><![CDATA[(" . $thread['newsauthor'] . ")]]></author>\r\n";
$output .= "<guid isPermaLink=\"false\">" . $vbulletin->options['homeurl'] . "?news_id=$thread[newsid]</guid>\r\n";
$output .= "</item>\r\n";
}
$output .= "</channel>\r\n";
$output .= "</rss>";
echo $output;
?>

[DrewM]

Thanks for the help, I always thought you would put it in the loop but sure!

When I open it I get this error:
The XML page cannot be displayed
Cannot view XML input using XSL style sheet. Please correct the error and then click the Refresh button, or try again later.


--------------------------------------------------------------------------------

Whitespace is not allowed at this location. Error processing resource 'http://www.sim2world.com/news_rss.php'. Line 30, Po...

<title>Maxis lost & found</title>
-------------------^

[Code Monkey]

Put the title in CDATA tags.

Try this. Untested

You can't have a & in there. It has to be encoded or in cdata.


<?php

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('SESSION_BYPASS', 1);
define('LOCATION_BYPASS', 1);
define('DIE_QUIETLY', 1);
define('THIS_SCRIPT', 'external');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
// get special phrase groups
$phrasegroups = array();

// get special data templates from the datastore
$specialtemplates = array();

// pre-cache templates used by all actions
$globaltemplates = array();

// pre-cache templates used by specific actions
$actiontemplates = array();

// ######################### REQUIRE BACK-END ############################
define('DIR', dirname(dirname(__FILE__))); //how many dirname calls depends on location of file.
chdir(DIR);
require_once DIR . '/global.php';

// ################################################## #####################
// ######################## START MAIN SCRIPT ############################
// ################################################## #####################

$threads = $db->query_read("select * from " . TABLE_PREFIX . "site_news ");

header('Content-Type: text/xml');
header('Expires: ' . gmdate('D, d M Y H:i:s') . ' GMT');
header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
header('Pragma: public');
$output = '<?xml version="1.0" encoding="' . $stylevar['charset'] . '"?>' . "\r\n";
$output .= "<rss version=\"2.0\">\r\n";
$output .= "<channel>\r\n";
$output .= "<title>RSS Feeds From Sim 2 World</title>\r\n";
$output .= "<link>" . $vbulletin->options['homeurl'] . "</link>\r\n";
$output .= "<description><![CDATA[" . htmlspecialchars_uni($vbulletin->options['description']) . "]]></description>\r\n";
$output .= "<language>" . $stylevar['languagecode'] . "</language>\r\n";
$output .= "<pubDate>" . gmdate('D, d M Y H:i:s', TIMENOW) . " GMT</pubDate>\r\n";
$output .= "<generator>Sim 2 World</generator>\r\n";
$output .= "<ttl>60</ttl>\r\n";
while ($thread = $db->fetch_array($threads))
{
$output .= "<item>\r\n";
$output .= "<title><![CDATA[". $thread['newstitle'] . "]]></title>\r\n";
$output .= "<link>" . $vbulletin->options['homeurl'] . "?news_id=" . $thread['newsid'] . "</link>\r\n";
$output .= "<pubDate>" . $thread['date'] . " </pubDate>\r\n";
$output .= "<description><![CDATA[". $thread['newsartcle'] ."]]></description>\r\n";
$output .= "<author><![CDATA[(" . $thread['newsauthor'] . ")]]></author>\r\n";
$output .= "<guid isPermaLink=\"false\">" . $vbulletin->options['homeurl'] . "?news_id=" . $thread['newsid'] . "</guid>\r\n";
$output .= "</item>\r\n";
}
$output .= "</channel>\r\n";
$output .= "</rss>";
echo $output;


?>

[DrewM]

thanks

I now get this error:
The XML page cannot be displayed
Cannot view XML input using XSL style sheet. Please correct the error and then click the Refresh button, or try again later.


--------------------------------------------------------------------------------

End tag 'description' does not match the start tag 'title'. Error processing resource 'http://www.sim2world.com/news_rss.ph...

2 Vaction Pack</a>]]></description>
-----------------------^

fixed it there needed to be a ">"

[Code Monkey]

Like I said, untested. So is it working now?

[DrewM]

yea It works no proplems.