problem with variable not being passed

[Delphiprogrammi]

hi people,

what the hell is wrong with this code ?


if($_GET['act'] == "completeremove")
{
$vbulletin->input->clean_array_gpc('g', array(
'id' => TYPE_INT,
'userid' => TYPE_INT,
'uname' => TYPE_STR,
'wname' => TYPE_STR,
'postid' => TYPE_INT,
'ban' => TYPE_STR,
'orderstring' => TYPE_STR,
));
}


problem

$vbullein->GPC['ban'] (doesn't work)
$_GET['ban'] (works but that's against the coding standards (http://www.vbulletin.com/docs/html/main/codestandards_gpc))

it's an $_GET so the first parameter should be g (short from get).The strange thing is that the same code works fine in another method(yes the verry same code)

why ohhh why :devious:

[Marco van Herwaarden]

$vbullein->GPC['ban'] (doesn't work)
Try using $vbulletin (missing t)

[Delphiprogrammi]

Try using $vbulletin (missing t)

that's a typo from me :shamed: problem is all variables from type TYPE_INT are passed just fine but TYPE_STR seems to have a problem


echo ($vbulletin->GPC['ban']);


that refuses to work

* Delphiprogrammi is a shamed about the typo

hi people,

Look here you can see what i mean in the attach screengrabs.

i totally don't get it

[Princeton]

it works for me :confused:

?act=completeremove&ban=hello

displays : hello

[Delphiprogrammi]

it works for me :confused:

?act=completeremove&ban=hello

displays : hello

hmmmz i'm getting nuts here if it works for you it must be something i overlook :tired:

[Marco van Herwaarden]

Are you sure you are using GET vars?
How is this field passed/submitted to this scrips?

[Delphiprogrammi]

Are you sure you are using GET vars?
How is this field passed/submitted to this scrips?


if ($_GET['act'] == "remove")
{
$vbulletin->input->clean_array_gpc('g', array(
'id' => TYPE_INT,
'wname' => TYPE_STR,
'userid' => TYPE_INT,
'uname' => TYPE_STR,
'postid' => TYPE_INT,
'orderstring' => TYPE_STR,
'ban' => TYPE_STR,
));

$temp_wid=$vbulletin->GPC['id'];
$temp_wname=$vbulletin->GPC['wname'];
$temp_uid=$vbulletin->GPC['userid'];
$temp_uname=$vbulletin->GPC['uname'];
$temp_postid=$vbulletin->GPC['postid'];
$temp_order=$vbulletin->GPC['orderstring'];
$temp_ban=$vbulletin->GPC['ban'];

echo " BAN: ";
echo ($vbulletin->GPC['ban']);


if ($temp_ban=='Y')
{
$string_ban="<br><b>This warning has caused a ban. The ban will not be removed from the user's account.<br>Use the Complete Removal, if you want to remove tha ban from the user's account.</b>";
}
else
{
$string_ban='';
}

print_cp_header("Advanced Warning System Version {$AWS_VERSION}");
print_form_header('admin_warn', 'do_delete');
print_table_header("Removal (manual maturing) of a Warning");
construct_hidden_code('form','');
construct_hidden_code('temp_wid',$temp_wid);
construct_hidden_code('temp_uid',$temp_uid);
construct_hidden_code('temp_postid',$temp_postid);
construct_hidden_code('temp_order',$temp_order);
construct_hidden_code('temp_ban',$temp_ban);
print_yes_no_row("Are you sure you want to remove this warning?<p><table>
<tr><td>Warned User ID</td><td>:</td><td>$temp_uid</td></tr>
<tr><td>Warned User Name</td><td>:</td><td>$temp_uname</td></tr>
<tr><td>Warning Type</td><td>:</td><td>$temp_wname</td></tr>
<tr><td>PostID</td><td>:</td><td>$temp_postid</td></tr>
<tr><td>Caused Ban</td><td>:</td><td>$temp_ban</td></tr>
<tr><td colspan='3'>$string_ban</td></tr>
</table><P><U><b>Caution:</b></U> This cannot be undone.", 'verify','');
print_submit_row("Proceed", 0);
}
$vbulletin->input->clean_array_gpc('p', array(
'temp_wid' => TYPE_INT,
'temp_wname' => TYPE_STR,
'temp_uid' => TYPE_INT,
'temp_uname' => TYPE_STR,
'temp_postid' => TYPE_INT,
'temp_order' => TYPE_STR,
'ban' => TYPE_STR,
'verify' => TYPE_INT,
));


works


if ($_GET['act'] == "completeremove")
{
$vbulletin->input->clean_array_gpc('g', array(
'id' => TYPE_INT,
'userid' => TYPE_INT,
'uname' => TYPE_STR,
'wname' => TYPE_STR,
'postid' => TYPE_INT,
'ban' => TYPE_STR,
'orderstring' => TYPE_STR,
));
$temp_wid=$vbulletin->GPC['id'];
$temp_uid=$vbulletin->GPC['userid'];
$temp_uname=$vbulletin->GPC['uname'];
$temp_wname=$vbulletin->GPC['wname'];
$temp_postid=$vbulletin->GPC['postid'];
$temp_ban=$vbulletin->GPC['ban'];
$temp_order=$vbulletin->GPC['orderstring'];
echo "BAN: ";
echo ($vbulletin->GPC['ban']);

if ($temp_ban=='Y')
{
$string_ban="<br><b>This warning has caused a ban. The ban will be removed from the user's account, but the user will not be unbanned, if he is currently banned.<br>Use the Unban User option, in the View Banned Users, in AWS Menu, to unban the user.</b>";
}
else
{
$string_ban='';
}

print_cp_header("Advanced Warning System Version {$AWS_VERSION}");
print_form_header('admin_warn', 'do_completedelete');
print_table_header("Complete Removal of a Warning");
construct_hidden_code('form','');
construct_hidden_code('temp_wid',$temp_wid);
construct_hidden_code('temp_uid',$temp_uid);
construct_hidden_code('temp_postid',$temp_postid);
construct_hidden_code('temp_order',$temp_order);
construct_hidden_code('temp_ban',$temp_ban);
print_yes_no_row("Are you sure you want to completely remove this warning?<p><table>
<tr><td>Warned User ID</td><td>:</td><td>$temp_uid</td></tr>
<tr><td>Warned User Name</td><td>:</td><td>$temp_uname</td></tr>
<tr><td>Warning Type</td><td>:</td><td>$temp_wname</td></tr>
<tr><td>PostID</td><td>:</td><td>$temp_postid</td></tr>
<tr><td>Caused Ban</td><td>:</td><td>$temp_ban</td></tr>
<tr><td colspan='3'>$string_ban</td></tr>
</table><P><U><b>Caution:</b></U> This cannot be undone.", 'verify','');
print_submit_row("Proceed", 0);
}
$vbulletin->input->clean_array_gpc('p', array(
'temp_wid' => TYPE_INT,
'temp_wname' => TYPE_STR,
'temp_uid' => TYPE_INT,
'temp_uname' => TYPE_STR,
'temp_postid' => TYPE_INT,
'temp_order' => TYPE_STR,
'ban' => TYPE_STR,
'verify' => TYPE_INT,
));


doesn't work.The complete methods are to big to post

[Marco van Herwaarden]

Well that still don't answer my question. :D

What is the (HTML) source of the page that submits the act=completeremove.

[Delphiprogrammi]

Well that still don't answer my question. :D

What is the (HTML) source of the page that submits the act=completeremove.

that hack is not mine actually just trying to help out my board is down at the moment can't look to post that html but i've seen before


<input type="hidden" name="temp_ban" value="" /> (act=completeremove)
<input type="hidden" name="temp_ban" value="N" />(act remove)


that variable ban is staying empty in ?act=completeremove

[Marco van Herwaarden]

That is not the code for the "ban" variable (but temp_ban). Please post the whole <form> </form> block.

[Delphiprogrammi]

That is not the code for the "ban" variable (but temp_ban). Please post the whole <form> </form> block.

hmmm temp_ban should have the value ban has that's why u call $vbulletin->GPC['ban']

this html is what you see when you goto the deleteform (completeremoval) right muis click => view source


<form action="admin_warn.php" name="cpform" method="post">
<input type="hidden" name="do" value="do_completedelete" />
<br />
<table cellpadding="4" cellspacing="0" border="0" align="center" width="90%" class="tborder">
<tr>
<td class="tcat" align="center" colspan="2"><b>Complete Removal of a Warning</b></td>
</tr>
<tr valign="top">
<td class="alt1">Are you sure you want to completely remove this warning?<p><table>
<tr><td>Warned User ID</td><td>:</td><td>3</td></tr>
<tr><td>Warned User Name</td><td>:</td><td>tester</td></tr>
<tr><td>Warning Type</td><td>:</td><td>ObsceneWords</td></tr>
<tr><td>PostID</td><td>:</td><td>68</td></tr>
<tr><td>Caused Ban</td><td>:</td><td></td></tr>
<tr><td colspan='3'></td></tr>
</table><P><U><b>Caution:</b></U> This cannot be undone.</td>
<td class="alt1"><span class="smallfont" style="white-space:nowrap">
<label for="rb_1_verify"><input type="radio" name="verify" id="rb_1_verify" value="1" tabindex="1" />Yes</label>
<label for="rb_0_verify"><input type="radio" name="verify" id="rb_0_verify" value="0" tabindex="1" checked="checked" />No</label>
</span></td>
</tr>
<tr>
<td class="tfoot" colspan="2" align="center"> <input type="submit" class="button" tabindex="1" value="Proceed " accesskey="s" />
</td>
</tr>
</table>
<input type="hidden" name="form" value="" />
<input type="hidden" name="temp_wid" value="7" />
<input type="hidden" name="temp_uid" value="3" />
<input type="hidden" name="temp_postid" value="68" />
<input type="hidden" name="temp_order" value="w.warned_time DESC" />
<input type="hidden" name="temp_ban" value="" />
</form>


and this is the "normal" remove method


<form action="admin_warn.php" name="cpform" method="post">
<input type="hidden" name="do" value="do_delete" />
<br />
<table cellpadding="4" cellspacing="0" border="0" align="center" width="90%" class="tborder">
<tr>
<td class="tcat" align="center" colspan="2"><b>Removal (manual maturing) of a Warning</b></td>
</tr>
<tr valign="top">
<td class="alt1">Are you sure you want to remove this warning?<p><table>
<tr><td>Warned User ID</td><td>:</td><td>3</td></tr>
<tr><td>Warned User Name</td><td>:</td><td>tester</td></tr>
<tr><td>Warning Type</td><td>:</td><td>ObsceneWords</td></tr>
<tr><td>PostID</td><td>:</td><td>68</td></tr>
<tr><td>Caused Ban</td><td>:</td><td>N</td></tr>
<tr><td colspan='3'></td></tr>
</table><P><U><b>Caution:</b></U> This cannot be undone.</td>
<td class="alt1"><span class="smallfont" style="white-space:nowrap">
<label for="rb_1_verify"><input type="radio" name="verify" id="rb_1_verify" value="1" tabindex="1" />Yes</label>
<label for="rb_0_verify"><input type="radio" name="verify" id="rb_0_verify" value="0" tabindex="1" checked="checked" />No</label>
</span></td>
</tr>
<tr>
<td class="tfoot" colspan="2" align="center"> <input type="submit" class="button" tabindex="1" value="Proceed " accesskey="s" />
</td>
</tr>
</table>
<input type="hidden" name="form" value="" />
<input type="hidden" name="temp_wid" value="7" />
<input type="hidden" name="temp_uid" value="3" />
<input type="hidden" name="temp_postid" value="68" />
<input type="hidden" name="temp_order" value="w.warned_time DESC" />
<input type="hidden" name="temp_ban" value="N" />
</form>

[Princeton]

you are using the post method ... it should be 'p' and not 'g'

[Delphiprogrammi]

you are using the post method ... it should be 'p' and not 'g'

if i change that it isn't working either i change g to p in all calls and the stuff isn't returned .... this is so fu****** frusterating pfffffff

problem solved don't ask me why but if you change p to g in all clean_array_gpc() class all is returned as it should

[Marco van Herwaarden]

I am sorry but your code is very confusing:
- You are using the post method, but are retrieving Get variables
- You are submitting 'temp_ban' but want to retrieve 'ban'
- You are submitting with do=do_completedelete, but you are checking the value of 'act'
- 'act' is not defined on that form.

Looks like you are mixing up things. This form don't seem to belong together with the php that should handle it.