while loop in a function

[harmor19]

I am doing the hook system in my own scripts but I have a small problem.
It only returns the first hook that matches $hook_name.

How do I have it return all the rows where the hook_names match?

function fetch_hook($hook_name)
{
$gethook = mysql_query("SELECT * FROM hooks WHERE hook_name = '$hook_name' ");

while($hook = mysql_fetch_array($gethook))
{
return $hook['phpcode'];
}

[Marco van Herwaarden]

A 'return' statement leaves the function and returns control to the calling script.

[harmor19]

So I'll need to check if I got every field where hook_name = $hook_name?

I don't know how to do this offhand, hopefully I'll find it easily.

[Marco van Herwaarden]

No, you should not return there. Instead you would probably want to evaluate the code you have just read from the database.

[harmor19]

It occured to me that I was using return in the while loop so I took it out of the while loop and now it works.
That's another lesson learned.

Thanks for the help though.

[Marco van Herwaarden]

Well that was my first answer. ;)

[harmor19]

Well that was my first answer. ;)
I didn't interpret it like that.

[The Geek]

Think you want something like this:


function fetch_hook($hook_name)
{
$gethook = mysql_query("SELECT * FROM hooks WHERE hook_name = '$hook_name' ");
$return = array();
while($hook = mysql_fetch_array($gethook))
{
$return[]= $hook['phpcode'];
}
return $return;
}


for a more vb3.5 approach (with cleansing, etc...) try this:



function fetch_hook($hook_name)
{
global $db;
$hooks = $db->query_read("SELECT phpcode FROM hooks WHERE hook_name = '" . $db->escape_string($hook_name) . "' ");
$return = array();
while($hook = $db->fetch_array($hooks))
{
$return[]= $hook['phpcode'];
}
$db->free_result($hooks);
return $return;
}


Havent tested either - but they should work fine for you.

nJoy