Hide threads by usergroup

[Martin64]

I've been working on making the secretely banned users hack even more secret :laugh: but I'm stuck at the moment so I thought I'd ask for help.

What I'm wanting to do is to prevent all threads started by users from my secretely banned users group to show up in forumdisplay (visible to the banned users, admins and mods though). I figured out a way of doing this based on userids, but not usergroups. Here's what I did in forumdisplay.php:

if (($bbuserinfo['usergroupid']!=16 && $bbuserinfo['usergroupid']!=6 && $bbuserinfo['usergroupid']!=5 &&
$bbuserinfo['usergroupid']!=7) && ($thread[postuserid]==X or $thread[postuserid]==XX or
$thread[postuserid]==XXX)) { continue; }

Also, I did this in showthread.php, which gives an error message if members try to view a thread started by those members:

if (($bbuserinfo['usergroupid']!=16 && $bbuserinfo['usergroupid']!=6 && $bbuserinfo['usergroupid']!=5 &&
$bbuserinfo['usergroupid']!=7) && ($thread[postuserid]==X or
$thread[postuserid]==XX or $thread[postuserid]==XXX)) {
      $idname="thread";
      eval("standarderror(\"".gettemplate("error_invalidid")."\");");
    }

Once again, giving this error message based on usergroup rather than having to edit the files whenever a new member is put in the secretely banned users group would be splendid.

I hope someone can help with some tips. :classic:

[Xenon]

well, the usergroupid isn't saved within the threadtable, so you have to include the usertable to the query:

in forumdisplay find this:

PHP Code:

$getthreadids=$DB_site->query("
    SELECT
    ".iif($sortfield=="voteavg",$votequery,"")."
        thread.threadid
    FROM thread
    WHERE thread.forumid = $foruminfo[forumid]
        AND thread.sticky=0
        AND thread.visible=1
    $datecut
    $limitothers
      ORDER BY sticky DESC, $sortfield $sqlsortorder
      LIMIT ".($sel_limitlower-1).",$perpage"); 


and change it to:

PHP Code:

$getthreadids=$DB_site->query("
    SELECT
    ".iif($sortfield=="voteavg",$votequery,"")."
        thread.threadid    FROM thread
              LEFT JOIN user ON (thread.postuserid = user.userid)
    WHERE thread.forumid = $foruminfo[forumid]
        AND thread.sticky=0
 ".iif(in_array($bbuserinfo[usergroupid], array(5,6,7,16)), "", "AND user.usergroupid != 16 ") . "
        AND thread.visible=1
    $datecut
    $limitothers
      ORDER BY sticky DESC, $sortfield $sqlsortorder
      LIMIT ".($sel_limitlower-1).",$perpage"); 


[Chris M]

Couldn't you just make it so that his threads get automatically moved to another forum?

Satan

[Xenon]

then he'd see that something isn't normal for him

[Martin64]

Yeah, I figured it would need something like that. It gives me an error though:

"There seems to have been a slight problem with the EmuTalk.net database.
Please try again by pressing the refresh button in your browser.
An E-Mail has been dispatched to our Technical Staff, who you can also contact if the problem persists.

We apologise for any inconvenience."

[Martin64]

Here's the error report the board sent me:

"Database error in vBulletin 2.2.8:

Invalid SQL:
SELECT

thread.threadid FROM thread
LEFT JOIN user ON (thread.postuserid = user.userid)
WHERE thread.forumid = 19
AND thread.sticky=0
AND user.usergroupid != 16
AND thread.visible=1
AND lastpost >= 1038763258 AND sticky=0

ORDER BY sticky DESC, lastpost DESC
LIMIT 0,20
mysql error: Column: 'lastpost' in where clause is ambiguous

mysql error number: 1052"

[Xenon]

ahh, yes i see

find this code:

PHP Code:

if ($daysprune != 1000) {
  $checkdate = time() - ($daysprune * 86400);
  $datecut = 'AND lastpost >= ' . $checkdate;
} 


and change it to:

PHP Code:

if ($daysprune != 1000) {
  $checkdate = time() - ($daysprune * 86400);
  $datecut = 'AND thread.lastpost >= ' . $checkdate;
} 


[Martin64]

Yeah, I figured it out earlier today with the help of a friend. Thanks a lot.

Now, how would I go about doing the same for showthread.php (cause the error based on usegroup rather than userid)? Any help would be appreciated.

EDIT: Nevermind, problem solved.

[hamed]

The same here. When I use :

PHP Code:

".iif(in_array($bbuserinfo[usergroupid], array(6,12)), "", "AND user.usergroupid != 12 ") . " 


it works perfect for the groups that have the permission to see the threads but the "There seems to have been a slight problem with Database" for the rest.
Any help please?

[Martin64]

Make sure you apply Xenon's latest code change.

[hamed]

Tanx for the help. I have done that but still the database error

[Martin64]

hamed, in forumdisplay...

FIND this:

$sortfield="lastpost";

REPLACE it with:

$sortfield="thread.lastpost";

FIND this:

$sortfield='lastpost';

REPLACE it with:

$sortfield='thread.lastpost';

That should do the trick.

[hamed]

Tanx a lot. That did it.
I had missed the second one.

[hamed]

Is there anyway to stop pms from a user group?

[Xenon]

you can disable the whole pm-function for a usergroup in your ACP