Here is a big issue,
yoursite.com/shop.php?do=BuyItem&id=1
take a page, iframe a bunch of links like that. Now you got a simple attack tool, if anyone of the members finds out, they easily using tinyurl make them purchase unnecessary items.
The options in the ACP aren't showing up. I tried uninstalling and reinstalling twice, and yes, I uploaded all of the files, and yes, especially the bitfield and cpnav ones.
As far as I can tell, this is just a nerfed version of iCash and IShop, renamed, with added glitches. I was hoping it was actually an update. *sigh*
Ah, I figured out why the options were not showing up:
Then they show up properly. You may want to also consider renaming "shop" to 'Shop Options', or something that looks and sounds more professional.
I've fixed this, and I'll be re-evaluating it a bit, but, to be honest, it's done pretty shoddily, and I don't think I'm going to keep it. You may want to consider re-learning PHP, MySQL, and even XML/HTML, trying some smaller projects, and working your way back up. I'm not trying to be harsh, but, the large amounts of errors, and the fact that this is someone else's project (on which you've unimproved?), seems to make it look like you don't know what you're doing.
And while learning by doing is normally okay, it's not when you release a product to the public that is unsafe. I hope no one gets any irreparable SQL errors from this. >.<
EDIT: I ran into even more errors, uninstalled, all of it.
Installs on the test forum perfectly, but when I installed on my normal forum I had this database error:
PHP Code:
Database error in vBulletin 3.7.2:
Invalid SQL:
ALTER TABLE vbuser ADD COLUMN money decimal(15,2) DEFAULT '0' NOT NULL;
MySQL Error : Duplicate column name 'money'
Error Number : 1060
Request Date : Sunday, January 4th 2009 @ 10:02:00 AM
Error Date : Sunday, January 4th 2009 @ 10:02:01 AM
Script : http://www.*****.co.uk/admincp/plugin.php?do=productimport
Referrer : http://www.*****.co.uk/admincp/plugin.php?do=productadd
IP Address : **.**.***.***
Username : **USERNAME**
Classname : **CLASSNAME**
MySQL Version : 4.1.22-standard
Installs on the test forum perfectly, but when I installed on my normal forum I had this database error:
PHP Code:
Database error in vBulletin 3.7.2:
Invalid SQL:
ALTER TABLE vbuser ADD COLUMN money decimal(15,2) DEFAULT '0' NOT NULL;
MySQL Error : Duplicate column name 'money'
Error Number : 1060
Request Date : Sunday, January 4th 2009 @ 10:02:00 AM
Error Date : Sunday, January 4th 2009 @ 10:02:01 AM
Script : http://www.*****.co.uk/admincp/plugin.php?do=productimport
Referrer : http://www.*****.co.uk/admincp/plugin.php?do=productadd
IP Address : **.**.***.***
Username : **USERNAME**
Classname : **CLASSNAME**
MySQL Version : 4.1.22-standard