The Arcive of Official vBulletin Modifications Site.

Prevent Doubleposting · **Released**: 01-07-2004

When a User posts into a thread where he already has the lastpost, no new post will be added. The lastpost of him will be edited and the new text is put after his first message, attachments will be added to the old post as well.
This will be done until the old post is older than 1 hour (you can change this timespan yourself

)
by changing $do_bump in the script, you can define wether the post's time will be altered or not.

Enjoy, and don't forget to click install

Notice: If you have installed the Proxy ip to real ip conversion or Proxy Detector v3.1 Hack, then you should probably take a look at this post.

Goodspeed · #**122** 08-30-2004, 05:40 AM

Great hack Xeon! Thank you! Going to install it...

But at first I have a question: what I need to do to switch off double post prevention after some time left? Is it possible to merge posts during appointed time?

Mosh · #**123** 08-30-2004, 07:01 AM

Quote:

Originally Posted by Xenon

very easy, just remove that line:

Code:

AND dateline > " . (TIMENOW - 3600) . "

and that part:

PHP Code:


			
AND $threadinfo['lastpost'] > TIMENOW - 3600

Xenon,

That worked an absolute treat.

Thanks ever so much for this.

JD.

btw. JD clicks Install

Xenon · #**124** 08-30-2004, 09:58 AM

@Goodspeed: hmm, i'm not sure if i get what you want.
If you want the merge just within the first xxy hopurse, use the default, if you want the merge whenever there's a doublepost show the code i posted for sinclair.

or do you mean that within 10 minutes no post should be merged, and then during the next hour it should?
everything is possible by changing just the conditions

Goodspeed · #**125** 08-30-2004, 04:57 PM

I'm sorry for my english Xenon, still not too good in it

Yes, I want to merge posts only during last 10 minutes, after that new post in thread by the same user should appear as new.
What kind of conditions should I change?

And one more question: is it possible to mark added text after merge? For example by adding line: Added by User at some time...

Thank you!

Xenon · #**126** 08-30-2004, 09:05 PM

no prob

just replace

Code:

AND dateline > " . (TIMENOW - 3600) . "

with

Code:

AND dateline > " . (TIMENOW - 3600) . " AND dateline < " . (TIMENOW - 600) . "

as well as replace

PHP Code:


			
AND $threadinfo['lastpost'] > TIMENOW - 3600

with

PHP Code:


			
AND $threadinfo['lastpost'] > TIMENOW - 3600 AND $threadinfo['lastpost'] < TIMENOW - 600

as for the merging text addition:
in

PHP Code:


			
$post['message'] = $doublepost['pagetext'] . "\n\n" . $post['message'];

replace the "\n\n" with for example:

PHP Code:


			
$post['message'] = $doublepost['pagetext'] . "\nAdded at " . vbdate($vboptions['dateformat'], TIMENOW) . "\n" . $post['message'];

Goodspeed · #**127** 08-30-2004, 09:26 PM

I did everything, checked it twice, but merge not work after those changes.
Now, posts appear one by one without merging.

Update
After couple of tests I understood that is problem in first two changes. I removed them and it works but without 10 min limit.

Addition with update date working GREAT! Thank you very much!

I changed it a little bit: added update time.

PHP Code:


			
$post['message'] = $doublepost['pagetext'] . "\n\n<strong><i>Added at " . vbdate($vboptions['dateformat'], TIMENOW) . ", " . vbdate($vboptions['timeformat'], TIMENOW) . "</i></strong>" . "\n" . $post['message'];

bjornstrom · #**128** 09-13-2004, 07:00 AM

Works great - thanks a lot /Martin

Snatch · #**129** 09-13-2004, 08:40 AM

What do this hack if the Maximum number of sings per post reached and the Memver must creat an new one to complett the post ?

Xenon · #**130** 09-13-2004, 09:45 AM

since the newest version it checks if the merged post is still a vald one.
If it is, then the post will be merged, if it's not valid anymore (too much chars/images or whatever) it will create a new post just as it would do without the hack

HappyPike · #**131** 09-23-2004, 01:38 AM

Looks like a cool hack, Xenon.

Does it have any impact on forum performance on a large forum?

Xenon · #**132** 09-23-2004, 12:07 PM

Since the new version handles most of the conditions without extra queries, you should not see any impacts on huge forums

Slynderdale · #**133** 09-23-2004, 05:38 PM

I made some edits to this hack, this allows you to control it via Admin CP Settings so you can modify the settings for it and turn double post checking on and off. Its backwards compatible so this hack will work even if you don't add the settings.

Note:
Please backup your includes/functions_newpost.php before your install these changes.

In file includes/functions_newpost.php find Xenon's original code and replace it with this:

PHP Code:


			
// ### POST NEW POST ###
// doublepost check
$isdoublepost = false;
$doubleposttime = (intval($vboptions['doubleposttime'])>0?intval($vboptions['doubleposttime']):3600);
if ($type != 'thread' AND $threadinfo['lastpost'] > TIMENOW - $doubleposttime AND $threadinfo['lastposter'] == $post['postusername'] AND $vboptions['doublepostenabled'] == 1) {
    $doublepost = $DB_site->query_first("
     SELECT postid, pagetext, post.userid
     FROM " . TABLE_PREFIX . "post AS post
     LEFT JOIN " . TABLE_PREFIX . "deletionlog AS deletionlog ON(deletionlog.primaryid = post.postid AND type = 'post')
     WHERE threadid = $threadinfo[threadid]
     AND dateline > " . (TIMENOW - $doubleposttime) . "
     AND visible = 1 AND deletionlog.primaryid IS NULL
     ORDER BY dateline DESC
     LIMIT 1
    ");
 
    if ($doublepost['userid'] == $bbuserinfo['userid'])
{
    // we truely have a doublepost, now check if the merged post fits the rules!
    $oldmsg = $post['message'];
    $olderrors = $errors;
 
    $post['message'] = $doublepost['pagetext'] . "\n\n" . $post['message'];
    verify_post_errors($type, $post, $errors);
    if (sizeof($errors) == 0)
    {
     // merged post is ok, so do merging
     $isdoublepost = true;
     $post['postid'] = $doublepost['postid'];
    }
    else
    {
     // merging will produce errors so keep it as a single post..
     $isdoublepost = false;
     $post['message'] = $oldmsg;
    }
    unset($oldmsg);
    $errors = $olderrors;
    unset($olderrors);
}
}
 
if ($isdoublepost)
{
// change this to false if you don't want doubleposts changing post's dateline
$do_bump = (isset($vboptions[doublepostbump])?$vboptions[doublepostbump]:1);
 
// Yes we have a doublepost, so do unindexing
require_once('./includes/functions_databuild.php');
delete_post_index($doublepost['postid'], $doublepost['title'], $doublepost['pagetext']);
unset($doublepost);
 
// Update DB
$DB_site->query("
    UPDATE " . TABLE_PREFIX . "post
    SET pagetext = '" . addslashes($post['message']) . "',
    " . iif($do_bump, 'dateline = ' . TIMENOW . ',', '') . "
    attach = attach + $totalattachments
    WHERE postid = $post[postid]
");
 
//Delete Eventually parsed cached post
$DB_site->query("DELETE FROM " . TABLE_PREFIX . "post_parsed WHERE postid = " . $post['postid']);
 
if ($totalattachments > 0 OR $do_bump)
{
    $DB_site->query("
     UPDATE " . TABLE_PREFIX . "thread
     SET " . iif($do_bump, 'lastpost = ' . TIMENOW . ',', '') . "
     attach = attach + $totalattachments
     WHERE threadid = $threadinfo[threadid]
    ");
}
 
//Update forum if postdate has changed.
if ($do_bump)
{
    $DB_site->query("
     UPDATE " . TABLE_PREFIX . "forum
     SET lastpost = " . TIMENOW . ",
     lastposter = '" . addslashes($post['postusername']) . "',
     lastthread = '" . addslashes($threadinfo['title']) . "',
     lastthreadid = $threadinfo[threadid],
     lasticonid = " . iif($threadinfo['pollid'], -1, $threadinfo['iconid']) . "
     WHERE forumid = $foruminfo[forumid]
    ");
}
}
else
{
$DB_site->query("
    INSERT INTO " . TABLE_PREFIX . "post
     (threadid, parentid, title, username, userid, dateline, pagetext, allowsmilie,
     showsignature, ipaddress, iconid, visible, attach)
    VALUES
     ($threadinfo[threadid], $parentid, '" . addslashes($post['title']) . "',
     '" . addslashes($post['postusername']) . "', $bbuserinfo[userid], " . TIMENOW . ",
     '" . addslashes($post['message']) . "', $post[enablesmilies], $post[signature],
     '" . addslashes($post['ipaddress']) . "', $post[iconid], $post[visible], $totalattachments)
");
$post['postid'] = $DB_site->insert_id();
}

Now to add the options, this can be done manually or with the queries below. I choosed to add them in the Posting settings group.

Manually Add then:

Varname: doublepostenabled
Type: yesno
Value: 1
Title: Check for double posts
Description: If enabled, it will check to see if the user already posted in the thread in a certain time limit, if so, their new post text will be added to their old post.

Varname: doublepostbump
Type: yesno
Value: 1
Title: Double posts bumping
Description: If enabled, and someone double posts, do you want the thread to be bumped because of the changes?

Varname: doubleposttime
Type:
Value: 3600
Title: Double post time
Description: The time in seconds you want to check for double posting.

OR

Queries:
[sql]
INSERT INTO `setting` VALUES ('doublepostenabled', 'posting', '1', '', 'yesno', 250, 0, 0);
INSERT INTO `setting` VALUES ('doublepostbump', 'posting', '1', '', 'yesno', 260, 0, 0);
INSERT INTO `setting` VALUES ('doubleposttime', 'posting', '3600', '3600', '', 270, 0, 0);

INSERT INTO `phrase` VALUES ('', 0, 'setting_doublepostenabled_title', 'Check for double posts', 5000);
INSERT INTO `phrase` VALUES ('', 0, 'setting_doublepostenabled_desc', 'If enabled, it will check to see if the user already posted in the thread in a certain time limit, if so, their new post text will be added to their old post.', 5000);
INSERT INTO `phrase` VALUES ('', 0, 'setting_doublepostbump_title', 'Double posts bumping', 5000);
INSERT INTO `phrase` VALUES ('', 0, 'setting_doublepostbump_desc', 'If enabled, and someone double posts, do you want the thread to be bumped because of the changes?', 5000);
INSERT INTO `phrase` VALUES ('', 0, 'setting_doubleposttime_title', 'Double post time', 5000);
INSERT INTO `phrase` VALUES ('', 0, 'setting_doubleposttime_desc', 'The time in seconds you want to check for double posting.', 5000);
[/sql]

HappyPike · #**134** 09-23-2004, 11:19 PM

Quote:

Originally Posted by Xenon

Since the new version handles most of the conditions without extra queries, you should not see any impacts on huge forums

Cool. I installed it on my forum.

*clicked install *

HappyPike · #**135** 09-25-2004, 12:08 AM

I think I found a little bug:

On my forum I set the attachments per post limit to 5. But people are able to create post with 9 attachments after I install this hack.

Xenon · #**136** 09-26-2004, 10:05 PM

have you installed the newest version of this hack?

I prevented such things with the last upgrade, so can you please tell me if your hack'sversion is 1.4?
If yes, i wonder why, but will put it on my bug-to-fix-list

thx in advance

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.07681 seconds Memory Usage 2,417KB Queries Executed 30 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (3)bbcode_code (7)bbcode_php (2)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (1)pagenav (1)pagenav_curpage (4)pagenav_pagelink (1)pagenav_pagelinkrel (16)post_thanks_box (16)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (16)post_thanks_postbit_info (15)postbit (16)postbit_onlinestatus (16)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!