[VB3 RC3] Attachments in private messages

Unsupported. VB3.5 version is here:
https://vborg.vbsupport.ru/showthread.php?t=91220

Tested on 3.0.3

This hack enables you to send attachments in a private message. This feature was really useful to me in vb2 and I kind of missed it on vb3 so I rehacked it myself.

When a user writes a private message they will be given the option to add an attachment, the same as when writing a post. It uses the same rules you have defined for a convencional attachment including file types, quotas, etc. It is only an extension for attachments to be used in private messages.

As always it is advised to backup your files before hacking in case you want to go back, this is some big hack including modification of multiple files, some templates and adding two extra columns in the database tables.

Instructions are provided in the txt, and some screenshots on where the attachment option appears.

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

Edit by MarcoH64:
Because of multiple requests to make this hack work on vB3.0.7 i created upgrade instructions. These upgrade instructions can be followed after the original instructions (the 3.0.3 version). The original coder can not be held responsible for my modification.

[Boofo]

Shouldn't the attachment show above that button without having to click the manage attachments button to see it?

[Kentaurus]

It should. That way it is very similar to the normal preview way of doing it. Here is the fix.

find this:

        'newpost_attachment'         
);

replace it with:

        'newpost_attachment',
        'newpost_attachmentbit'
);

find this:

eval('$attachmentoption = "' . fetch_template('newpost_attachment') . '";');

replace it with:

$currentattaches = $DB_site->query("
        SELECT filename, filesize, attachmentid
        FROM " . TABLE_PREFIX . "attachment
        WHERE posthash = '$posthash'
                AND userid = $bbuserinfo[userid]
");


$attachcount = 0;
while ($attach = $DB_site->fetch_array($currentattaches))
{
        $attachcount++;
        $attach['extension'] = strtolower(file_extension($attach['filename']));
        $attach['filename'] = htmlspecialchars_uni($attach['filename']);
        $attach['filesize'] = vb_number_format($attach['filesize'], 1, true);
        $show['attachmentlist'] = true;
        eval('$attachments .= "' . fetch_template('newpost_attachmentbit') . '";');
}



eval('$attachmentoption = "' . fetch_template('newpost_attachment') . '";');

[Boofo]

Works great! Thanks!

Is the first post updated?

How would we add the attachments ability to Erwin's Quick Peply hack?

[Kentaurus]

Originally Posted by Boofo

Works great! Thanks!

Is the first post updated?

How would we add the attachments ability to Erwin's Quick Peply hack?

I am still wondering if Erwin's is a quick pm.... he has all the pm reply screen there! Actually in my forum I edited it to only show the textarea and the submit button....

It should be possible to add them, I'll take a look at it.

[Boofo]

Can you pm me with your edits for the textarea and submit button?

[portion]

Can you allow only certain usergroups to use this function?

[Kentaurus]

Originally Posted by portion

Can you allow only certain usergroups to use this function?

That would need further hacking.. and right now I have no use for it.

Anyway, what is this obsession with everything being usergroup based lately? (Second hack I get asked) With around 10 usergroups in my forum it is becoming a nightmare for me checking that every option is right....

[portion]

Can you just point me to the right area, and I can do the editing? I am pretty comfortable with PHP.

[DivisionByZero]

Originally Posted by Kentaurus

Wouldn't that be a little hard on your users? I usually download an attachment more than once, and after I download it I expect it to remain there. That would seem a little un(user-friendly) to me.

This hack uses the same quotas and options that you have already defined for your attachments so if you have a quota for each user no matter if they attach files to posts or private message once they reach their limit they would have to delete some to continue attaching files.

How about automatically deleting the attachment(s) when the recipient actually DELETES the PM? That seems logical, since you wouldn't want orphaned attachments hogging your quota. That would be a waste of space and DB optimization.

I've installed the hack on 3/1/04 and everything seems to be working fine, except some little bug, where I'll describe in a new post!

[DivisionByZero]

Now, my problem with the hack is that the recipient clicks the attachment link, and gets an error message of: "No Post Defined". HELP

[Kentaurus]

Originally Posted by ThePowerPig

How about automatically deleting the attachment(s) when the recipient actually DELETES the PM? That seems logical, since you wouldn't want orphaned attachments hogging your quota. That would be a waste of space and DB optimization.

I've installed the hack on 3/1/04 and everything seems to be working fine, except some little bug, where I'll describe in a new post!

The attachment is automatically deleted when it belongs to no more recipients. There are no orphaned attachments. They are done with the hourly cleanup and that was the reason to modify one of the cron jobs.

Please keep in mind that if you save a copy in your sent folder that counts as a pm, so the attachment wouldn't be deleted until both the recipient's pm and your copy of the pm are deleted.

It is the first time I have seen that "No post defined" error... do you have any other hack that deals with pm's or attachments installed?

[DivisionByZero]

No, I do not. Your hack is the only one I've installed at all. I went back and double checked everything. However, when I get down to the SQL, I did have problems running those. I ran each individually and it did create the three tables. Though the ALTER TABLE attachment add index (private) query gave me problems though, but I eventually did create the table manually.

[DivisionByZero]

ok, BIG problem...... I just found out that someone can easily go to your attachment.php page in the browser and just browse through attachments! they can do this by:

attachment.php?attachmentid=1
attachment.php?attachmentid=2
attachment.php?attachmentid=3

Is there a way you can re-release this hack and change the way vBulletin handles attachments? I would suggest md5summing the attachment upon upload and assigning the checksum as the attachment ID. I certainly don't want someone browsing through my members' private attachments!!!

[Kentaurus]

Originally Posted by ThePowerPig

ok, BIG problem...... I just found out that someone can easily go to your attachment.php page in the browser and just browse through attachments! they can do this by:

attachment.php?attachmentid=1
attachment.php?attachmentid=2
attachment.php?attachmentid=3

Is there a way you can re-release this hack and change the way vBulletin handles attachments? I would suggest md5summing the attachment upon upload and assigning the checksum as the attachment ID. I certainly don't want someone browsing through my members' private attachments!!!

There is already functionality for this. Another member cannot see an attachment that he doesn't own. They get a permission denied screen. Even if they start browsing the attachments. If the attachment is private sender and recipients are the only ones allowed to see it.

[Boofo]

Can you update the first post with all of the changes up until now, please?